[Koha-bugs] [Bug 32614] Highlight important comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32614 --- Comment #12 from Jonathan Druart --- Yes, it's working for me as well! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] OpenSearch description format document generates search errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] OpenSearch description format document generates search errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 --- Comment #3 from David Cook --- Created attachment 145330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145330=edit Bug 32639: Send opac-search.osdx without doing an empty search This patch sends out opac-search.osdx without running the entirety of opac-search.pl without any search query. This prevents unnecessary computations and warnings from appearing in the logs. Test plan: 1. Apply patch 2. Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription 3. Note that no errors appear in /var/log/koha/kohadev/plack-opac-error.log 4. Verify that opac-search.pl still works as expected when doing a search via the web UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] OpenSearch description format document generates search errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] OpenSearch description format document generates search errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 David Cook changed: What|Removed |Added Summary|OpenSearchDescription |OpenSearch description |generates search errors for |format document generates |every OPAC page load|search errors --- Comment #2 from David Cook --- Ok now I'm only able to reproduce the on page load problem when I go to http://localhost:8080 But the same thing doesn't happen for http://kohadev.myDNSname.org:8080 Maybe it's a caching thing. I don't know. Browsers are weird. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] OpenSearchDescription generates search errors for every OPAC page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 --- Comment #1 from David Cook --- Note that this happens with Chrome but not Firefox. I think Firefox just parses the HTML whereas Chrome seems to actually follow the link provided by the markup... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32639] New: OpenSearchDescription generates search errors for every OPAC page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 Bug ID: 32639 Summary: OpenSearchDescription generates search errors for every OPAC page load Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I noticed going to http://localhost:8080/ in Chrome caused the following to appear in /var/log/koha/kohadev/plack-opac-error.log: [2023/01/16 04:58:40] [WARN] WARNING: query problem with ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352. [2023/01/16 04:58:40] [WARN] Use of uninitialized value $hits in numeric eq (==) at /kohadevbox/koha/opac/opac-search.pl line 613. [2023/01/16 04:58:40] [WARN] Use of uninitialized value $times in subtraction (-) at /kohadevbox/koha/C4/Search.pm line 1712. Of course, fixing this will require touching opac-search.pl without breaking anything... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma instead of decimal dot breaking payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32539] UI hooks can break the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32539 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|tomasco...@gmail.com|dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32539] UI hooks can break the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32539 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Created attachment 145329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145329=edit Koha plugin to use for testing this patch Koha plugin to use for testing this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32539] UI hooks can break the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32539 --- Comment #1 from David Cook --- Created attachment 145328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145328=edit Bug 32539: Add exception handling to plugin hooks in template plugin This change wraps Koha plugin hook calls with exception handling within the template plugin for Koha plugins. Test plan: 0) Apply patch 1) Install a plugin that provides "opac_head", "opac_js", "intranet_head", and "intranet_js" with Perl errors in them 2) Load an OPAC page 3) Note that the OPAC page loads correctly 4) Load a staff interace page 5) Note that the staff interface page loads correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32638 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32638] No reason given for why items ignored during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30739 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32638] New: No reason given for why items ignored during MARC import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 Bug ID: 32638 Summary: No reason given for why items ignored during MARC import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org In the past, if you had a "coded_location_qualifier" that was too long, the whole MARC import would bust (see bug 30739). That's no longer the case anymore. However, if the item has a "coded_location_qualifier" like "ABCDEFGHIJKLMNOPQRSTUVWXYZ123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ123456789", it will now just be ignored without any more information shown on the Web UI or in the worker logs. You wouldn't be able to troubleshoot this issue without writing your own code changes to Koha... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30739] Fatal errors during MARC import force status of "Importing" forever
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739 David Cook changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #6 from David Cook --- It looks like it works since bug 27421 The item is shown as ignored in the output, and I can't find a warning anywhere explaining why the item was ignored, but it's better than the job getting stuck as 0% and staying "Importing" forever... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #10 from David Cook --- Like I asked in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410#c18, do we have any example plugins that we can use to verify this change? I don't see any obvious ones listed at https://wiki.koha-community.org/wiki/Koha_plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32637] New: API requests using Content-Type: application/x-www-form-urlencoded fail, user data treated as DB column name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32637
Bug ID: 32637
Summary: API requests using Content-Type:
application/x-www-form-urlencoded fail, user data
treated as DB column name
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: data-27fc05a3c...@office-dateien.de
CC: tomasco...@gmail.com
Created attachment 145327
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145327=edit
IRC log
Requests to the REST API will fail if the Content-type HTTP header is set to
application/x-www-form-urlencoded. This is the default header sent by curl if
nothing else is specified.
curl -v -s -u kohaapi:kohaapi --request GET http://koha_testing/api/v1/patrons
--data-raw '{ "surname": { "-like": "Smith%" } }'
{"error":"Something went wrong, check Koha logs for
details.","error_code":"internal_server_error"}
The following entry shows up in api-error.log
[ERROR] GET /api/v1/patrons: unhandled exception
(DBIx::Class::Exception)<> Koha::REST::Plugin::Exceptions::__ANON__
/usr/share/koha/lib/Koha/REST/Plugin/Exceptions.pm (73)
Specifying any Content-type header, or not sending one at all will make the
issue go away:
curl -v -s -u kohaapi:kohaapi --header "Content-type: application/json"
--request GET http://koha_testing/api/v1/patrons --data-raw '{ "surname": {
"-like": "Smith%" } }'
It appears that sending Content-type: application/x-www-form-urlencoded causes
Koha to treat the complete user supplied data as a column name of the borrowers
table and running a query with it. It then fails because such a column does not
exist.
With Koha 22.05, the following will not cause an error, as firstname is a valid
column name in the borrowers table, so no query fails and no data is returned.
This also works with the items table.
curl -v -s -u kohaapi:kohaapi --request GET http://koha_testing/api/v1/patrons
--data-raw 'firstname'
This won't work if any Content-type header is set as this causes an error:
{"errors":[{"message":"Expected object - got
string.","path":"\/query"}],"status":400}
It appears that x-www-form-urlencoded also overrides the JSON sanity check.
It is not clear why x-www-form-urlencoded is treated special in the first place
and why using it allows user supplied data to be passed to the database
unchecked.
The security implications of this behavior would need to be checked too to
avoid things like SQL injections.
Tests were done on Koha 22.05 and 22.11 running on Debian Bullseye. Koha was
installed using the Debian packages on a newly installed machine.
The IRC log is attached.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #7) > > I would personally only go for pushing the first patch. The two others seem > > not really needed. But thats just my first impression.. > > Yes, same feeling for me. But this problem will come up again if there is no > test :-/ That's possible although I think plugin support was one of the last pieces we needed to add? Perhaps it would be an idea to add some text to the "use " area like "DO NOT ADD KOHA MODULES HERE OR YOU WILL FACE JONATHAN'S WRATH! See BZ 32561!" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32465] koha-worker debian script missing 'queue' in help
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32465 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Yeah... nice catch! I think there used to be more auth logic in get_template_and_user() hence the hack, but yeah... wow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Looking good at a glance, and probably fixes some possible race conditions... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32614] Highlight important comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32614 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- For what it's worth, it seems to be working for me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32609] Remove compiled files from src
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #12 from David Cook --- (In reply to Jonathan Druart from comment #0) > We need to improve our yarn build commands to generate css and js compiled > files. > > Then remove them from our codebase, and generate them when needed: > > - when generating the debian packages > - when ktd is starting up > - when patches are applied on the sandbox I suppose "ktd" startup time makes sense. On one hand, I might like to generate the files 1 time, and re-use them over days/weeks/months, but... having a fresh build on each startup is probably wise. When I switch version branches, I'll destroy my container and rebuild it, so this would work well with that workflow. And if you change branches that have the same version but changes to css and js... you just need to re-compile anyway. So yeah that sounds good to me. -- If we create a Perl script to run these commands, we can include it in Makefile.PL, plus manually call it for "ktd" and sandboxes, so... that should be pretty straightforward overall. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32609] Remove compiled files from src
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- (In reply to Mason James from comment #10) > (In reply to Katrin Fischer from comment #9) > > Hm, what about tarballs? > > > > We roll our own packages - what would be the suggested workflow? Generate > > the files on the git branch before building the packages? > > i think we might be able to add these steps to Makefile.PL, so they get run > for both tarball and deb pkg builds Yeah I reckon we add something to PL_FILES: https://metacpan.org/pod/ExtUtils::MakeMaker#PL_FILES That way it would apply to tarballs, deb pkg builds, and technically even git dev installs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #23 from David Cook --- (In reply to Kyle M Hall from comment #21) > I'd say we need to make the decision on where to ACK and the rest > of the plan will follow from that. Jonathan has put in the early ACK into bug 32393 at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393#c24 I don't know that adding it to that particular patch set is the best idea, but I'll leave it up to you guys to sort it out. I'm not a heavy user of RabbitMQ in Koha at this point, so happy for you folk to make the decision and do the work. If it's an issue later, we can deal with it later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #28 from David Cook --- (In reply to Jonathan Druart from comment #24) > I don't understand what you are asking for guys. I've written a follow-up > patch that I think does what you want, but I don't see how it is better. Looks good. Thanks for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #22 from David Cook --- (In reply to Kyle M Hall from comment #20) > Nick asked me to post this > > https://stomp.github.io/stomp-specification-1.2.html#ACK > --- > ACK is used to acknowledge consumption of a message from a subscription > using client or client-individual acknowledgment. Any messages received from > such a subscription will not be considered to have been consumed until the > message has been acknowledged via an ACK. > --- > > The stomp protocol doesn't specify that an ACK is meant to indicate the > completion of whatever activity a message would require. An ACK is only > meant to verify that the client received the message. The spec doesn't seem to strictly define "consume". I imagine that they've left it intentionally ambiguous so that they don't prescribe the behaviour of message consumers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32614] Highlight important comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32614 --- Comment #10 from Chris Cormack --- Yep its made new ones -rw-r--r-- 1 www-data www-data 273640 Jan 15 23:12 01d1b8200ec3d6070e858c3636a8f000.js So not quite sure whats up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #4 from David Cook --- (In reply to David Cook from comment #3) > (In reply to Jonathan Druart from comment #2) > > I am wondering if it's a good idea, or if we should just warn and let daemon > > deals with the logging. > > Sounds good to me Just warning and letting daemon deal with the logging that is -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #3 from David Cook --- (In reply to Jonathan Druart from comment #2) > I am wondering if it's a good idea, or if we should just warn and let daemon > deals with the logging. Sounds good to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32500] OPAC_REG_VERIFY has too many options for "Message body"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from David Cook --- (In reply to Marcel de Rooy from comment #3) > Why not add_fields on borrower modifications? Maybe you want to change the > notice and show some of the fields that have been entered? This seems too > drastic? Upon reviewing the borrower modifications table, I'm not sure why I thought verification_token should be the only field. It doesn't really make much sense. My concern about add_fields() is that it would have access to the "password" field. It looks like it's the hashed password rather than the clear text password, but it should probably be excluded. But it looks like we could modify the "get_columns_for" function in letter.pl to exclude that field. I'll have another think about this one another time! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32614] Highlight important comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32614 --- Comment #9 from Jonathan Druart --- Did you remove the assets? rm data/assets/*.js data/assets/*.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32614] Highlight important comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32614 --- Comment #8 from Chris Cormack --- Patch is applied to test on bugzilla, but it doesn't seem to be doing anything Chris -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Jonathan Druart changed: What|Removed |Added Change sponsored?|Seeking developer |Sponsored Status|NEW |ASSIGNED CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
