[Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
   Keywords||rel_22_11_candidate
   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #146013|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  ---
Created attachment 146383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146383=edit
Bug 32798: Update parameter passed to Koha::Biblio::Metadata->record

To test:
1 - Enable OAI sets, and define a set with mapping 952 y = BK
2 - perl misc/migration_tools/build_oai_sets.pl -v -i -r
3 - The script dies:
Koha::Biblio::Metadata->record must be called on an instantiated object or
like a class method with a record passed in parameter
4 - Apply patch
5 - Repeat
6 - Success!

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

--- Comment #7 from Jonathan Druart  ---
There is also recall_overdue_fine, but it should not be a problem as it's not a
max.
However, shouldn't we revert the changes made to bug 20395 and restore the
formatting instead of completely removing it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules)

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||32271


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271
[Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20395
 CC||jonathan.druart+koha@gmail.
   ||com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395
[Bug 20395] Use Price formatter in more templates (paycollect, request, parcel,
smart-rules)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511

--- Comment #18 from Mohd Hafiz Yusoff  ---
(In reply to Jonathan Druart from comment #17)
> This patch does not seem to be the correct fix. The columns in items and
> deleteditems are supposed to be the same, if you have a mismatch then you
> must fix the DB structure.
> 
> Did you compare both table structures?

Patch working at me, but this discussion Failed QA.

How to fix DB structures or compare table structures. Tq

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Signed Off  |Failed QA

--- Comment #17 from Jonathan Druart  ---
This patch does not seem to be the correct fix. The columns in items and
deleteditems are supposed to be the same, if you have a mismatch then you must
fix the DB structure.

Did you compare both table structures?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #146307|0   |1
is obsolete||

--- Comment #4 from PTFS Europe Sandboxes  ---
Created attachment 146382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146382=edit
Bug 32705: Display invoice price

On bug 25655 we are storing the unit price and currency used for
invoicing. Here we are displaying them on the invoice page.

Test plan:
Reuse the test plan from 25655 and go to the invoice page
Notice that a new 'Invoice price' column is displayed if at least one
order of the invoice had a price given in a foreign currency

We could discuss the display of the prices here, we've decided to not
format them.
We cannot do better for now as we are not storing the format along with
the currency.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||32906


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906
[Bug 32906] Make 'Replace record via Z3950/SRU' buttons in authorities work
consistently
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32906] New: Make 'Replace record via Z3950/SRU' buttons in authorities work consistently

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906

Bug ID: 32906
   Summary: Make 'Replace record via Z3950/SRU' buttons in
authorities work consistently
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 29173

Bug 29173 implemented search pre-fill for the Replace via Z3950 search form
from the authority detail page, but it did so in a very different, and MARC21
specific, way from the same button on the 'Edit authority' page.

On the edit authority page we extract the pre-fill terms from the current page
and pass them as URI parameters to the search pop-over form.  I think we could
take a similar approach on the detail display page and perhaps even make the
feature work for both MARC21 and UNIMARC in this way?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173
[Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #45 from Martin Renvoize  ---
This all works well and the QA script is happy.

I would have loved to see some consistency in the implementation between the
two buttons however..  At first I thought this approach made the most logical
sense, at the controller level, but as I worked through the code to understand
how it works on the edit page I concluded that I think that's the cleaner
approach pre-populating the search fields using the data already on display in
the page rather than having to query for it again in the search controller.

Anyway.. I don't think that should hold this up.. but it might be nice to clean
up as a follow-up bug.

Passing QA, thanks Thibaud, and welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

--- Comment #44 from Martin Renvoize  ---
Created attachment 146381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146381=edit
Bug 29173: (QA follow-up) Match pop-over sizes

As suggested by David Nind, this patch updates the call to z3950 search
on the authority edit page to match the sizing of the one from the
details page.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #144983|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 146380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146380=edit
Bug 29173: Fixed pre-filling of the search form from the "Replace record with
ZR39.50/SRU" (Authority page detail)

Now this action has the same pre-filling behaviour as the "Edit" -> "Edit
Record" -> "Replace Record via Z39.50/SRU Search" action.
Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled
in if the subfield contains data (like the "Edit->Replace" action).
Unimarc and Marc21 specificities are supported.

Test Plan :

1) You must have a Z39.50/SRU server for authorities
2) Go to an authority detail page (Author - Uniform title - Subject)
3)After go to "Edit"-> "Edit record" -> "Replace record via..." or
choose "Replace Record.." directly
4) See that form is also prefilled with data now

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762

--- Comment #7 from quickfir...@gmail.com ---
(In reply to quickfire28 from comment #6)
> 
> 
> Added new system preference 'UseOCLCEncodingLevels'
> Upgrade to 22.06.00.056  [12:00:42]: Bug 30571 - Table z3950servers: three
> cols
> NOT NULL
> Upgrade to 22.06.00.057  [12:00:42]: Bug 29071 - Set
> HoldsQueueSplitNumbering wh 
> ere not set
> Added new system preference 'HoldsSplitQueueNumbering'
> Upgrade to 22.06.00.058  [12:00:42]: Bug 30944 - Replace
> branchtransfers.cancell 
> ation_reason CancelRecall with RecallCancellation
> Upgrade to 22.06.00.059  [12:00:42]: Bug 25936 - A password change
> notification
> feature
> Added new letter 'PASSWORD_CHANGE' (email)
> Added new system preference 'NotifyPasswordChange'
> Upgrade to 22.06.00.060  [12:00:42]: Bug 10950 - Add preferred pronoun field
> to  
> patron record
> Added column 'borrowers.pronouns'
> Added column 'deletedborrowers.pronouns'
> Added column 'borrower_modifications.pronouns'
> Upgrade to 22.06.00.061  [12:00:42]: Bug 31333 - Add the ability to limit
> purcha  
> se suggestions by patron category
> Added new system preference 'suggestionPatronCategoryExceptions'
> Upgrade to 22.06.00.062  [12:00:42]: Bug 27136 - Add missing languages:
> Cree, Af
> rikaans and Multiple languages, Undetermined and No linguistic content
> Added missing languages
> Upgrade to 22.06.00.063  [12:00:43]: Bug 31569 - Add primary key for
> import_bibl 
> ios
> ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
> '104
> 34' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739
> 
> Enabling plugins on node rabbit@lrc:
> rabbitmq_stomp
> The following plugins have been configured:
>   rabbitmq_stomp
> Applying plugin configuration to rabbit@lrc...
> The following plugins have been enabled:
>   rabbitmq_stomp
> 
> started 1 plugins.
> Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service
> is transient or generated.
> 
> 
> Here is the result of upgrade and the error.

I dont know how to check which table is affected with that error in upgrade.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32905] New: Fine calculation issue in 22.05

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32905

Bug ID: 32905
   Summary: Fine calculation issue in 22.05
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mishrav...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hello
I noticed fine calculation issue in Koha version 22.05 onward and same has been
reported byany in 22.11 also.

Test plan
1. Configure circulation and fine rules
2. Issue book with backdate
3. Run the cronjob fines.pl
4. Check fine is not calculated
5. Under circulation and fine rules remove default value 0.00 from "overdue
fines caps (amount) and give some value to like 100
6. Now run the cronjob fines.pl
7. Check the fine is calculated

Now the issue is in earlier versions by default value was nothing under
"overdue fines cap (amount)" option so the default value 0.00 in above versions
asume fine cap is zero so system does not calculate though everything is
configured well.

Thanking you

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375

Danyon Sewell  changed:

   What|Removed |Added

   Priority|P5 - low|P2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27730] Innocent changes to framework silently delete bibliographic data

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #21 from Aleisha Amohia  ---
Can this fix please be backported to 22.11? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27730] Innocent changes to framework silently delete bibliographic data

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146368|0   |1
is obsolete||

--- Comment #24 from Lucas Gass  ---
Created attachment 146379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146379=edit
Bug 30418: Re-order options of who can edit list contents

The 'Allow changes to contents from' dropdown when creating/edit lists
should be most locked down to least locked down:

1. Nobody
2. Owner only
3. Permitted staff only
4. Staff only
5. Anyone seeing this list

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146367|0   |1
is obsolete||

--- Comment #23 from Lucas Gass  ---
Created attachment 146378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146378=edit
Bug 30418: Unit tests

Test plan:
1. Run unit tests
sudo koha-shell 
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146366|0   |1
is obsolete||

--- Comment #22 from Lucas Gass  ---
Created attachment 146377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146377=edit
Bug 30418: Add ability for permitted staff to edit list contents

Public lists with 'Allow changes to contents from' = 'Permitted staff only'
can have their contents managed by Koha patrons with either of the
permissions below:

- superlibrarian permission
- catalogue permission + 'edit_public_list_contents' sub-permission

Test plan:
1. Apply patches, update database, restart services
2. In the staff client go to: Lists > New List
3. Create a list, choose 'Allow changes to contents from' => 'Permitted
staff only'

4. Log into the OPAC as a patron with no permissions.
5. Confirm you CANNOT add a biblio to the list from the OPAC search result page
and
OPAC biblio detail pages

6. Log into the OPAC as a patron with only the 'catalogue' permissions
enabled
7. Confirm you CANNOT add a biblio to the list from OPAC search result
or biblio detail pages

8. Log into the OPAC as a patron with the 'catalogue' and
'edit_public_list_contents' permissions enabled
9. Confirm you CAN add/remove biblios from the OPAC search result and
biblio detail pages

10. Log into the OPAC as a patron with superlibrarian permissions
11. Confirm you CAN add a biblio to the list from the OPAC search result
page and OPAC biblio detail pages

12. Log into the staff client as a patron with only the
'catalogue' permission and confirm you CANNOT add/remove records from the
list

13. Log into the staff client as a patron with the 'catalogue' and
'edit_public_list_contents' sub-permission (found under 'Lists' parent
permission)
14. Confirm you CAN add/remove records from the list

15. Login into thestaff client as a patron with 'superlibrarian'
permissions and confirm you CAN add/remove records from the list

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146365|0   |1
is obsolete||

--- Comment #21 from Lucas Gass  ---
Created attachment 146376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146376=edit
Bug 30418: Template and JavaScript changes

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146364|0   |1
is obsolete||

--- Comment #20 from Lucas Gass  ---
Created attachment 146375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146375=edit
Bug 30418: Updated schema file

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Attachment #146363|0   |1
is obsolete||

--- Comment #19 from Lucas Gass  ---
Created attachment 146374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146374=edit
Bug 30418: Database changes

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #18 from Lucas Gass  ---
Works as describe and tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

   Assignee|michalurban...@gmail.com|lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #27 from Lucas Gass  ---
This patchset is again ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

--- Comment #4 from Lucas Gass  ---
My patch enables dateaccessioned.pl by default with 952$r but should we also do
the same for other date fields?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

--- Comment #3 from Lucas Gass  ---
> Just wondering, if that could cause problems with bug 31212

Yes, I am running into this problem while working on 31212.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

--- Comment #2 from Lucas Gass  ---
Created attachment 146373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146373=edit
Bug 32168: Add dateaccessioned.pl to 952 (datelastseen) for new installs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

 Attachment #143595|0   |1
is obsolete||

--- Comment #26 from Lucas Gass  ---
Created attachment 146372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146372=edit
Bug 31212: (follow-up) Fix datelastseen when returning item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

 Attachment #142288|0   |1
is obsolete||

--- Comment #25 from Lucas Gass  ---
Created attachment 146371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146371=edit
Bug 31212: Fix date_from_string and explicitly called output_pref subroutine

Signed-off-by: Ann Flournoy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

 Attachment #142287|0   |1
is obsolete||

--- Comment #24 from Lucas Gass  ---
Created attachment 146370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146370=edit
Bug 31212: Add Database update

Signed-off-by: Ann Flournoy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass  changed:

   What|Removed |Added

 Attachment #142286|0   |1
is obsolete||

--- Comment #23 from Lucas Gass  ---
Created attachment 146369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146369=edit
Bug 31212: Change datelastseen from date to datetime field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Katrin Fischer  changed:

   What|Removed |Added

Summary|Marc modification templates |MARC modification templates
   |cannot check or change  |cannot check or change
   |indicators  |indicators

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32899] Unused ILL configs in koha-conf.xml should be removed

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32899

--- Comment #1 from Katrin Fischer  ---
I guess Tomas' check included ours, but I can confirm we don't use it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #17 from Alex Buckley  ---
Rebased against master. Ready for testing again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #16 from Alex Buckley  ---
Created attachment 146368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146368=edit
Bug 30418: Re-order options of who can edit list contents

The 'Allow changes to contents from' dropdown when creating/edit lists
should be most locked down to least locked down:

1. Nobody
2. Owner only
3. Permitted staff only
4. Staff only
5. Anyone seeing this list

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #15 from Alex Buckley  ---
Created attachment 146367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146367=edit
Bug 30418: Unit tests

Test plan:
1. Run unit tests
sudo koha-shell 
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32030] Electronic resource management (ERM)

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||32904


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904
[Bug 32904] Patrons table processing eternally and not loading
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||32030
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored

--- Comment #2 from Aleisha Amohia  ---
I'm not sure how to reproduce this or if this is the 'right' fix but it doesn't
seem harmful.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #14 from Alex Buckley  ---
Created attachment 146366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146366=edit
Bug 30418: Add ability for permitted staff to edit list contents

Public lists with 'Allow changes to contents from' = 'Permitted staff only'
can have their contents managed by Koha patrons with either of the
permissions below:

- superlibrarian permission
- catalogue permission + 'edit_public_list_contents' sub-permission

Test plan:
1. Apply patches, update database, restart services
2. In the staff client go to: Lists > New List
3. Create a list, choose 'Allow changes to contents from' => 'Permitted
staff only'

4. Log into the OPAC as a patron with no permissions.
5. Confirm you CANNOT add a biblio to the list from the OPAC search result page
and
OPAC biblio detail pages

6. Log into the OPAC as a patron with only the 'catalogue' permissions
enabled
7. Confirm you CANNOT add a biblio to the list from OPAC search result
or biblio detail pages

8. Log into the OPAC as a patron with the 'catalogue' and
'edit_public_list_contents' permissions enabled
9. Confirm you CAN add/remove biblios from the OPAC search result and
biblio detail pages

10. Log into the OPAC as a patron with superlibrarian permissions
11. Confirm you CAN add a biblio to the list from the OPAC search result
page and OPAC biblio detail pages

12. Log into the staff client as a patron with only the
'catalogue' permission and confirm you CANNOT add/remove records from the
list

13. Log into the staff client as a patron with the 'catalogue' and
'edit_public_list_contents' sub-permission (found under 'Lists' parent
permission)
14. Confirm you CAN add/remove records from the list

15. Login into thestaff client as a patron with 'superlibrarian'
permissions and confirm you CAN add/remove records from the list

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #13 from Alex Buckley  ---
Created attachment 146365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146365=edit
Bug 30418: Template and JavaScript changes

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #12 from Alex Buckley  ---
Created attachment 146364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146364=edit
Bug 30418: Updated schema file

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #11 from Alex Buckley  ---
Created attachment 146363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146363=edit
Bug 30418: Database changes

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904

--- Comment #1 from Aleisha Amohia  ---
Created attachment 146362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146362=edit
Bug 32904: Check if responseJSON is defined for dataTable error

This patch checks if responseJSON is defined before checking if
responseJSON.errors is defined.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139696|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139697|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139698|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139699|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139700|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Alex Buckley  changed:

   What|Removed |Added

 Attachment #139701|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32904] New: Patrons table processing eternally and not loading

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904

Bug ID: 32904
   Summary: Patrons table processing eternally and not loading
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Error in console: Uncaught TypeError: settings.jqXHR.responseJSON is undefined

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from David Nind  ---
The patch no longer applies - I'm getting a sha1 error:

git bz apply 32746

Bug 32746 - Standardize structure around action fieldsets in acquisitions

145902 - Bug 32746: Standardize structure around action fieldsets in
acquisitions

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32746: Standardize structure around action fieldsets in
acquisitions
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 32746: Standardize structure around action fieldsets
in acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31659] Add SMSAlertNumber to options in borrowers.primary_contact_method

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31659

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31498] Allow for custom primary contact method values

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record"

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901

David Nind  changed:

   What|Removed |Added

 Attachment #146351|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 146361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146361=edit
Bug 32901: Replace use of the slang term "bib" with the term "record"

The "Item processing" pulldown on manage-marc-import.pl uses the slang term
"bib" while the rest of the form uses the correct term "record". This field
should be updated with the correct terminology.

Test Plan:
1) Find or stage a marc record batch
2) Note the "Item processing" pulldown uses the term "bib"
3) Apply this patch
4) Reload that page
5) Note the "Item proccessing" pulldown now uses the term "record"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record"

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32605] Restore some form styling from before the redesign

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605

--- Comment #12 from David Nind  ---
Thanks Owen for the additional information and fixing the issues identified.

I've signed off, even though I haven't checked every form.

I'm making a big assumption that follow-up bugs will be created for any
identified issues once this passes QA and gets pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32605] Restore some form styling from before the redesign

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605

David Nind  changed:

   What|Removed |Added

 Attachment #146349|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 146360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146360=edit
Bug 32605: (follow-up) Additional fixes

This patch makes some further changes to form CSS in order to improve
consistency. Some templates have also been modified to improve layout.

- Acquisitions -> New vendor
- Staff interface home ->  Patrons requesting modifications
- Reports -> Saved SQL reports
- Serials -> New subscription
- Tools -> Import patrons

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32605] Restore some form styling from before the redesign

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605

David Nind  changed:

   What|Removed |Added

 Attachment #146348|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 146359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146359=edit
Bug 32605: Restore some form styling from before the redesign

This patch pulls styles from pre-22.11 staff-global.scss related to the
styling of fieldset.rows and contents. The old CSS is more verbose but
it has been better proven to hold up in a variety of situations.

The patch makes only one template change, a minor correction to the
basket groups form.

To test, apply the patch and rebuild the staff interface SCSS.

Test as many forms as possible to confirm that everything is still
correct. Forms affected are ones shown in the main body of the page, not
in sidebars.

Some good examples: Editing patrons, subscriptions, patron categories,
notices, item types.

This patch should help outstanding bugs 32513, 32543, and 32591

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32605] Restore some form styling from before the redesign

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
As the warning can't be triggered until there is a patch for bug 32888, I
tested by reviewing the diff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293

David Nind  changed:

   What|Removed |Added

 Attachment #146188|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 146358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146358=edit
Bug 32293: Fix terminology in warning when creating orders from staged file

When you are ordering from a staged file and the
fund is missing, there is a warning:

Some budgets are not defined in item records

Budgets shoudl be funds here.

To test:
* Add a new basket
* Add an order from a staged file or from a file
* Leave the fund values of some selected items empty
* Make sure default fund entry is also empty
* Warning message should be triggered on saving
* Apply patch, repeat, verify it is correct now.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #20 from David Nind  ---
Does cataloguing/value_builder/EXAMPLE.pl need updating to reflect the changes
made in the refactoring?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #10 from Jonathan Druart  ---
Created attachment 146357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146357=edit
Bug 32806: Move main-erm.ts to modules/erm.ts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Attachment #146354|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Comment on attachment 146354
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146354
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Accidentally attached a sign-off for another bug, obsoleting!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
I mucked up the sign off, and have done again!

Testing notes (using KTD):

1. In a MARC21 instance, add the callnumber.pl plugin to 952$o for the BKS
framework.
2. Edit an item for a record and add "PREFIX 0009678570" as the call number and
save.
3. Edit another item for another record.
4. For the call number, enter "PREFIX" and then click on the three dots.
5. Note that it generates the call number as "PREFIX 9678572".

Note the description in the script says it should add leading zeros, but it
doesn't. I have added bug 32903 for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815

David Nind  changed:

   What|Removed |Added

 Attachment #146355|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 146356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146356=edit
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815

David Nind  changed:

   What|Removed |Added

 Attachment #146073|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 146355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146355=edit
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

https://bugs.koha-community.org/show_bug.cgi?id=32813

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813

--- Comment #3 from David Nind  ---
Created attachment 146354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146354=edit
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16791] [DOCS] Explanation of callnumber.pl plugin

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16791

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Documentation||David Nind
contact||
Summary|Explanation of  |[DOCS] Explanation of
   |callnumber.pl plugin|callnumber.pl plugin
 Status|NEW |Needs documenting
   Assignee|ch...@bigballofwax.co.nz|da...@davidnind.com

--- Comment #2 from David Nind  ---
There is now a cataloguing (value builder) section in the manual
(https://koha-community.org/manual/23.05/en/html/valuebuilder.html).

My plan is to add a table/list of the plugins with a short description, then to
add the details for each one.

I'll start with this one, and go from there.

Some already have a good description in the actual script, and many of the
UNIMARC ones are helpers used to populate the fields with the required values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32408] If a fine can be overridden on checkout in Koha, what should the SIP client do?

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi  ---
Cool, let's allow setting this things at the account level. That would be
valuable in the long run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32603] Suggester category in Suggestions management

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
*** Bug 32774 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32774] Add patron category to suggestion management tables

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Patch doesn't apply |RESOLVED

--- Comment #13 from Lucas Gass  ---
This is a duplicate of 32603.

*** This bug has been marked as a duplicate of bug 32603 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #7 from Tomás Cohen Arazi  ---
Conflict, please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32774] Add patron category to suggestion management tables

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
Please rebase. It colllides with bug 32603

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32743] Reindent the invoice details page

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743

--- Comment #10 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32743] Reindent the invoice details page

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661

--- Comment #7 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs

2023-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660

--- Comment #7 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >