[Koha-bugs] [Bug 32898] Cypress tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 --- Comment #23 from Jonathan Druart --- Ready to go, thanks for the patch, Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32898] Cypress tests are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > There is one test failing, > > GET 500 /api/v1/erm/eholdings/local/titles?_page=1&_per_page=1 > no alias > 5 > get > main div[class='dialog alert'] > 0 > AssertionError > Timed out retrying after 4000ms: Expected to find element: main > div[class='dialog alert'], but never found it. > > > The error is not raised to the user when we list titles. It's because > fetchLocalTitleCount does not call checkError. > We are dealing with that correctly in follow-up bugs, I am tempted to > comment the test for now and add it back later. What do you think Pedro? Forget that, I was using an old version of dist file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33017] SQL comments are not fully ignoring runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33017 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 David Cook changed: What|Removed |Added Blocks||32994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 [Bug 32994] Remove compiled files from src (2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 David Cook changed: What|Removed |Added Depends on||32975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 [Bug 32975] Error in package.json's definition of css:build vs css:build:prod -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33018] debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #17 from Alex Buckley --- Created attachment 147015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147015=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #16 from Alex Buckley --- Created attachment 147014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147014=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #15 from Alex Buckley --- Created attachment 147013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147013=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #14 from Alex Buckley --- Created attachment 147012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147012=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #13 from Alex Buckley --- Created attachment 147011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147011=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #143156|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #143157|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #143158|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #143159|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #140 from Aleisha Amohia --- Created attachment 147010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147010=edit Bug 8628: (follow-up) Fix search calls and table pagination -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145654|0 |1 is obsolete|| --- Comment #139 from Aleisha Amohia --- Created attachment 147009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147009=edit Bug 8628: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145653|0 |1 is obsolete|| --- Comment #138 from Aleisha Amohia --- Created attachment 147008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147008=edit Bug 8628: (follow-up) Fix documentation, subroutine calls, filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145652|0 |1 is obsolete|| --- Comment #137 from Aleisha Amohia --- Created attachment 147007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147007=edit Bug 8628: (follow-up) Fix layout of signs admin page Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145651|0 |1 is obsolete|| --- Comment #136 from Aleisha Amohia --- Created attachment 147006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147006=edit Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145650|0 |1 is obsolete|| --- Comment #135 from Aleisha Amohia --- Created attachment 147005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147005=edit Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145649|0 |1 is obsolete|| --- Comment #134 from Aleisha Amohia --- Created attachment 147004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147004=edit Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 1 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145648|0 |1 is obsolete|| --- Comment #133 from Aleisha Amohia --- Created attachment 147003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147003=edit Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145647|0 |1 is obsolete|| --- Comment #132 from Aleisha Amohia --- Created attachment 147002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147002=edit Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145646|0 |1 is obsolete|| --- Comment #131 from Aleisha Amohia --- Created attachment 147001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147001=edit Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #145645|0 |1 is obsolete|| --- Comment #130 from Aleisha Amohia --- Created attachment 147000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147000=edit Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 --- Comment #2 from Aleisha Amohia --- Created attachment 146999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146999=edit Bug 33019: Make sure ES records are indexed the first time This patch ensures records are indexed when they are created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Aleisha Amohia --- We've come up with a hacky fix for this because I can't think of any other reason indexing isn't working, but I am really happy to be advised about this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] New: Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Bug ID: 33019 Summary: Records not indexed in Elasticsearch ES when first catalogued Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz We have a Koha instance where records are not being indexed into Elasticsearch when they are first catalogued. They can be accessed if you go to the catalogue detail page directly, but cannot be searched. However if you edit the record and save, it is indexed successfully. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #145656|0 |1 is obsolete|| --- Comment #73 from Aleisha Amohia --- Created attachment 146998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146998=edit Bug 14367: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #145655|0 |1 is obsolete|| --- Comment #72 from Aleisha Amohia --- Created attachment 146997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146997=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Update the database, update the schema files, restart services * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33018] debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m...@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33018] debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #1 from Mason James --- Created attachment 146996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146996=edit Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33018] debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Mason James changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33018] New: debian package tidy-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Bug ID: 33018 Summary: debian package tidy-up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com this bug aims to track a tidy-up of debian package files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James changed: What|Removed |Added Attachment #146994|0 |1 is obsolete|| --- Comment #8 from Mason James --- Created attachment 146995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146995=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #7 from Mason James --- version info below... $ apt policy yarn: *** 1.22.19-1 500 500 https://dl.yarnpkg.com/debian stable/main amd64 Packages $ apt policy nodejs: *** 14.21.3-deb-1nodesource1 999 500 https://deb.nodesource.com/node_14.x buster/main amd64 Packages 100 /var/lib/dpkg/status $ npm -v 6.14.18 $ gulp -v CLI version: 2.3.0 Local version: Unknown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #6 from Mason James --- Created attachment 146994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146994=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL make[1]: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. make[1]: Leaving directory '/build/koha-22.12.00-4~git+20230221145053.b112630a' dh_auto_build: make -j1 returned exit code 2 make: *** [debian/rules:9: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 E: Failed autobuilding of package - apply patch - run makefile, note success -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32609] Remove compiled files from src
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32994 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32609 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #55 from Alex Buckley --- *** Bug 30444 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #27 from Alex Buckley --- I'm going to mark this bug report as a duplicate of bug 30979. Martin: As you said in comment #24 it is a fairly similar use case, but a very different approach. I much prefer your approach on bug 30979 . Thanks everyone for your thoughts on this bug report. *** This bug has been marked as a duplicate of bug 30979 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Text to go in the|The |The release notes|UpdateNotForLoanStatusOnChe |UpdateNotForLoanStatusOnChe |ckin system preference is |ckin system preference is |now more flexible: you can |now more configurable: you |define rules to be applied |can define rules to be |to specific item types upon |applied to specific item |check-in. |types upon check-in. | | |Adding the item |Add |type code followed by a |the item type code followed |colon, and then in separate |by a colon, and then on |lines below each value pair |separate lines below define |rules with leading spaces. |each notforloan value pair |Example: |with leading spaces. | |Example: |BK | | -1: 0 |BK | | -1: 0 |If an | |item type is not defined in |You |UpdateNotForLoanStatusOnChe |can use an _ALL_ wildcard |ckin then items of that |to target all item types. |type will not have their|The _ALL_ wildcard does NOT |notforloan status change on |override item-type specific |check-in, irrespective of |rules. |their current notforloan|Example: |value. | ||_ALL_: || ||-1: 2 || ||If an item type is ||not defined in the ||UpdateNotForLoanStatusOnChe ||ckin system preference, and ||there are no _ALL_ rules ||defined, then items of that ||type will not have their ||notforloan status change on ||check-in, irrespective of ||their current notforloan ||value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Signed Off --- Comment #82 from Alex Buckley --- (In reply to Kyle M Hall from comment #72) > Alex, why not add a wildcard option ( say "*" )? That way, if a notforloan > change applies to all itemtypes, it won't require creating a section for > each and every itemtype. It should also simplify the upgrade patch. Hi Kyle, Setting this back to 'Signed-off' as Katrin said in comment #74. I have added the _ALL_ wildcard, like how Nick suggested in comment #62 . Also, as suggested in that comment I have made this wildcard not override other rules. I've also updated the unit tests to test using the wildcard. Could you please take a look and let me know what other changes might be needed for QA? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #81 from Alex Buckley --- Created attachment 146993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146993=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #146559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33017] New: SQL comments are not fully ignoring runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33017 Bug ID: 33017 Summary: SQL comments are not fully ignoring runtime parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org If you use SQL comments in a report, runtime parameters are not fully ignored. For example: /* WHERE branchcode = <> */ When the report runs, it correctly ignores this parameter, but it still requires the a library branch to be selected before the report can run. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Attachment #145673|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 146992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146992=edit Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Attachment #145672|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 146991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146991=edit Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Attachment #145671|0 |1 is obsolete|| --- Comment #24 from Aleisha Amohia --- Created attachment 146990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146990=edit Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Attachment #145670|0 |1 is obsolete|| --- Comment #23 from Aleisha Amohia --- Created attachment 146989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146989=edit Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Attachment #145669|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 146988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146988=edit Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32717] problems user and cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32717 --- Comment #3 from Katrin Fischer --- I don't see any issues when cataloguing new items/bibliographic records and fines seem to apply fine. Can you please add a step by step on how to reproduce the issue? Do you mean items or bibliographic records? Are you using Zebra or Elasticsearch? Are you trying to link to an authority on field 100? Is there anything in your system logs when the errors occur? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32405] Add Mastodon account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32405 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32405] Add Mastodon account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32405 Katrin Fischer changed: What|Removed |Added Assignee|wizzy...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32405] Add Mastodon account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32405 --- Comment #3 from Katrin Fischer --- (In reply to David Nind from comment #1) > If you could also add this code to the header for verification (not sure how > this is done in WordPress), that would be great as well: > > https://mastodon.world/@KohaILS;>Mastodon > > From the Mastodon account profile: > > "Verification > > You can verify yourself as the owner of the links in your profile metadata. > For that, the linked website must contain a link back to your Mastodon > profile. The link back must have a rel="me" attribute. The text content of > the link does not matter. Here is an example:" I think I have achieved this too with the community resources link. Is that ok? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32405] Add Mastodon account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32405 --- Comment #2 from Katrin Fischer --- (In reply to David Nind from comment #0) > I've created a Mastodon account for Koha - @KohaILS@mastodon.world > (https://mastodon.world/@KohaILS) > > If you are able to add it to the "Community Resources", along with the other > social media accounts that would be great! Done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #160 from Aleisha Amohia --- Created attachment 146987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146987=edit Bug 3150: Include host item entries in LIST and CART notices Incorporating fixes from Bug 16522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32584] Can't update po files on master, because of missing UNIMARC files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32584 Katrin Fischer changed: What|Removed |Added CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Katrin Fischer changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32469] Keyboard shortcuts no longer work in details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32469 --- Comment #3 from Katrin Fischer --- (In reply to Lucas Gass from comment #2) > I'm not entirely convinced this functionality should be brought back. The > standard use of the arrow keys is scroll horizontally or vertically in the > page. Hi Lucas, can you explain your comment? I thought Hebah was referring to thse: https://bywatersolutions.com/education/koha-question-of-the-week-are-there-any-keyboard-shortcuts-in-koha Alt w Alt q Alt r Alt u These probably should not impact using arrow keys for navigation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Katrin Fischer changed: What|Removed |Added Attachment #146985|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 146986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146986=edit Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page To test: * Go to administration > patron restrictions * Search for a specific restrictions * Verify you can't make the 'You searched for' above the results table show * Apply patch * Everything should appear unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 --- Comment #3 from Katrin Fischer --- Created attachment 146985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146985=edit Bug 32215: Remove unused "Your searched for" lines from patron restrictions admin page To test: * Go to administration > patron restrictions * Search for a specific restrictions * Verify you can't make the 'You searched for' above the results table show * Apply patch * Everything should appear unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor Summary|Capitalization: %s You |'You Searched for' for |Searched for %s |patron restrictions is not ||used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32930] [DOCS] No manual entry for "SMTP Servers"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32930 Katrin Fischer changed: What|Removed |Added Summary|No manual entry for "SMTP |[DOCS] No manual entry for |Servers"|"SMTP Servers" Status|NEW |Needs documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #6 from Katrin Fischer --- Created attachment 146984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146984=edit Bug 32918: (follow-up) Add new lines for formatting consistency This adds new lines between each authorised value for better readability and to match the formatting of the rest of the file. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918
Katrin Fischer changed:
What|Removed |Added
Attachment #146438|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 146983
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146983=edit
Bug 32918: ERM authorized values should be in
installer/data/mysql/en/mandatory/auth_values.yml
This patch moves the authorized value insertions for ERM categories into
the language-specific auth_values.yml file.
To test:
1. Count the number of authorized values in the mandatory categories
select count(*) from authorised_values where category in ('YES_NO',
'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS',
'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY',
'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS',
'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION',
'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE',
'COUNTRY', 'LANG', 'qualif');
--> There should be 929
2. Delete the authorized values from these categories
delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE',
'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON',
'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE',
'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS',
'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE',
'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG',
'qualif');
3. Apply patch
4. Load the mandatory authorized values
./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml
--load
5. Redo step 1
--> There should be the same number (929)
6. Update translations
cd misc/translator
./translate update xx-XX
7. Search the po/xx-XX-installer.po file for any of the loaded
authorized values
For example,
grep "Abstract and index" po/xx-XX-installer.po
--> descriptions should be translatable
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32030] Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Katrin Fischer changed: What|Removed |Added Blocks||32918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Depends on||32030 --- Comment #4 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #3) > I had originally made the authorized values themselves translatable since > they are English words, and for historical and legal reasons, that doesn't > always fly here. > > Unfortunately, some of them trigger actions (like the 'closed' > ERM_AGREEMENT_STATUS makes the 'Closure reason' drop down active in > agreements), so we can't translate them... at least not all of them. Since > I'm not sure which ones trigger actions, I removed all of them from the > translations. Now, only the descriptions are translatable. Looking at the values I wish they'd follow a bit more closely recommendations for authorised values, not using _ (we do recommend against these for locations and collections for search reasons) and using capital letters. It would also make it easier to see that these are CODES and not words. But... as Caroline said, we cannot change this easily and it's an oversight that is hard to fix now (and certainly should not be fixed here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32918] ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer changed: What|Removed |Added Version|unspecified |master Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32949] Smart-rules prefills junk date on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32949 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32949] Smart-rules prefills junk date on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32949 Katrin Fischer changed: What|Removed |Added Summary|Smart-rules prefils junk|Smart-rules prefills junk |date on page load |date on page load Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- I don't have the patch applied, but I can't reproduce the issue. I also tried using another date format, but it all behaves nicely: * Set dateformat to DD.MM. * Create a circulation rule ALL-ALL-Books, with 21.2.2023 as hard due date and auto-renewal before. * Save rule. * Edit rule and save without changes. * Edit rule again - dates are still correct. Tested on master as of today. Also with the standard format MM.DD.. Can you please have a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32941] Sys prefs side menu styling applying where not intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32941 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32941] Sys prefs side menu styling applying where not intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32941 Katrin Fischer changed: What|Removed |Added Attachment #146611|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 146982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146982=edit Bug 32941: Sys prefs side menu styling applying where not intended In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a inside a , and possibly other places. The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32941] Sys prefs side menu styling applying where not intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32941 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Katrin Fischer --- I am sorry, but this doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31705: Option for ILL "Manage request" button to appear on left of the screen to improve accessibility error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js). error: could not build fake ancestor Can you rebase your patch to master please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- It seems we keep running into this kind of issue in some variations. Actually, I am also confused: When do we want to update the permanent item location and when do we not? My impression was that whenever the location is updated and the value is not CART or PROC, the we'd also like to make the permanent location match. It's been moved to a new location, so if it was checked out/checked in, set to CART, it should be able to go back to the new location. But now it feels a bit like we might have different uses of the field depending on configuration maybe? And if we do... should we do that? And if so, is this documented somewhere? Do we expect people to always set both manually if they are linked to MARC fields? What if $k was set to hidden in the item form? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33016] MARC diff view still shows tools instead of cataloging in title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 --- Comment #1 from Katrin Fischer --- Created attachment 146981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146981=edit Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging Some remaining to dos of us moving the staged import tools from tools to cataloging. To test: * Export a record from your Koha catalog * Import it using the staged MARC import tool, matching on biblionumber (the diff view is only visible if the record matched an existing one) * View the staged records * Click on the 'Diff' link * Verify that the page title and breadcrumbs still read 'Tools' * Apply patch * Not these should read 'Cataloging' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33016] MARC diff view still shows tools instead of cataloging in title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Blocks||33016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 [Bug 33016] MARC diff view still shows tools instead of cataloging in title and breadcrumbs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33016] New: MARC diff view still shows tools instead of cataloging in title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 Bug ID: 33016 Summary: MARC diff view still shows tools instead of cataloging in title and breadcrumbs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] 'Cancel' link still points to tools home when it should be cataloguing home on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 --- Comment #1 from Katrin Fischer --- Created attachment 146980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146980=edit Bug 33015: Fix some 'Cancel' links to point to cataloging start page Some 'cancel' links of tools moved to the cataloguing module still pointed to the tools start page. This adds some more consistency. To test: * Go to cataloguing * Batch item editing * Batch record deletion * Batch record modification (create a MARC modification template first) * Verify the 'cancel' link on each page points to tools * Apply patch: cancelling should not take you to the cataloging start page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] 'Cancel' link still points to tools home when it should be cataloguing home on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] 'Cancel' link still points to tools home when it should be cataloguing home on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Katrin Fischer changed: What|Removed |Added Summary|Cancel link on batch record |'Cancel' link still points |modification page links to |to tools home when it |tools home instead of |should be cataloguing home |cataloguing home page |on some pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] Cancel link on batch record modification page links to tools home instead of cataloguing home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Katrin Fischer changed: What|Removed |Added Attachment #146640|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 146979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146979=edit Bug 32164: Add link to MARC modification templates from batch record modification page This patch adds a more visible link from the batch record modification page in the event that there are no MARC modification templates defined. The template checks that the user has permission. The patch also modifies the same message on the MARC modification templates page so that the interfaces are more unified, and tweaks the operation of the "New action" button. To test you should have no MARC modification templates defined. - Apply the patch and go to Tools -> Batch record modification. - If you're logged in as a user with permission you should see a message dialog containing a button, "Create a new MARC modification template." - Clicking it should take you to the MARC modification templates page, where you'll see a similar message and a button, "Create a new template." Clicking this button should trigger a modal form, just like clicking the "New template" button in the toolbar should. - Submit the form to create a new template. You should see message on the following page that says "New action." Clicking the button should display the entry form, and then clicking "Cancel" should hide the form and redisplay the message. Signed-off-by: Katrin Fischer Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Blocks||33015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 [Bug 33015] Cancel link on batch record modification page links to tools home instead of cataloguing home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] New: Cancel link on batch record modification page links to tools home instead of cataloguing home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Bug ID: 33015 Summary: Cancel link on batch record modification page links to tools home instead of cataloguing home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 31162 To test: * Create a MARC modification template * Go to Record batch modification page * Click on cancel - it goes to tools home, but this is now a cataloging thing Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
