[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What|Removed |Added Blocks|32808 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 [Bug 32808] Logic in AgreementsList is flawed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32808] Logic in AgreementsList is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32807 Depends on|32807 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32808] Logic in AgreementsList is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- It's actually correct. And things are improved on 32807, closing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32991] Improve our Dialog component and remove routes for deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart changed: What|Removed |Added Blocks||32807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What|Removed |Added Depends on||32991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 [Bug 32991] Improve our Dialog component and remove routes for deletion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #2 from Jonathan Druart --- Created attachment 147111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147111=edit Bug 32807: Fetch count instead of all entries for agreements and licenses To list agreements and licenses we are retrieving the whole list to simply know if at least one exists (and display the table that will fetch the X first elements to display). We should call count instead. Test plan: List agreements and licenses. If none exists, the table is not displayed but a "There are no... defined" message instead. If at least one exists the table must be there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32941] Sys prefs side menu styling applying where not intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32941 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #22 from Jonathan Druart --- Created attachment 147110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147110=edit Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart changed: What|Removed |Added Attachment #146933|0 |1 is obsolete|| Attachment #147106|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 147109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147109=edit Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32991] Improve our Dialog component and remove routes for deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #11 from Jonathan Druart --- (In reply to Matt Blenkinsop from comment #10) > (In reply to Jonathan Druart from comment #6) > > > Finally, there is something weird in Main.vue we need to fix. The > > console is showing a warning > > "[Vue warn]: setup() return property "_is_loading" should not start with "$" > > or "_" which are reserved prefixes for Vue internals." > > This appears to just need a new variable name - Vue won't accept variables > prefixed with "_" in root components so "_is_loading" will need renaming. We > can't just remove the "_" as there is a getter called "is_loading" and this > will conflict. Maybe "content_is_loading"? Yes, the thing is that Agustin decided to prefix the store variables with '_', to get a good getter method name. We should not only rename is_loading, but others as well (for consistency), and so we need to provide a clean solution for all of them. But first I wanted to make sure the trick in Main was necessary and there was no better alternative. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32609] Remove compiled files from src
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart changed: What|Removed |Added Blocks||32994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 [Bug 32994] Remove compiled files from src (2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Jonathan Druart changed: What|Removed |Added Depends on||32609 Assignee|koha-b...@lists.koha-commun |m...@kohaaloha.com |ity.org | --- Comment #20 from Jonathan Druart --- Looks like we are dealing with 2 different problems here. Would have been beteer to have 2 different bugs; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 [Bug 32609] Remove compiled files from src -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #19 from Jonathan Druart --- (In reply to David Cook from comment #18) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > Bug 32975 is probably the reason why the second patch is needed. I haven't > double-checked but that would be my guess. Indeed, I misread the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33034] New: KOHA Upgrade fails from v20.05 to v22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33034
Bug ID: 33034
Summary: KOHA Upgrade fails from v20.05 to v22.11
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Installation and upgrade (command-line installer)
Assignee: koha-bugs@lists.koha-community.org
Reporter: quickfir...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Upgrading database schema for lrc
Upgrade to 22.06.00.063 [05:39:06]: Bug 31569 - Add primary key for
import_biblios
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'11545' for key 'import_biblios.PRIMARY' at /usr/share/koha/lib/C4/Installer.pm
line 739
and this one
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'24064' for key 'import_biblios.import_biblios_ibfk_1' at
/usr/share/koha/lib/C4/Installer.pm line 73
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Attachment #140245|0 |1 is obsolete|| --- Comment #6 from Aleisha Amohia --- Created attachment 147108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147108=edit Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Attachment #140244|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 147107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147107=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #86 from David Cook --- (In reply to Barbara Johnson from comment #85) > Just revisiting this bug since we talked about it today in a koha-US > Acquisitions Special Interest Group meeting. All of the attendees agreed > that this functionality would greatly help their libraries. Also, I see > that this bug has 51 votes. Wondering what the next steps are to move this > bug forward. I imagine koha-US might need to sponsor a developer to work on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #18 from David Cook --- (In reply to Jonathan Druart from comment #9) > With bug 32975 you shouldn't need the second patch. Bug 32975 is probably the reason why the second patch is needed. I haven't double-checked but that would be my guess. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762
--- Comment #8 from quickfir...@gmail.com ---
Here is the table that has Duplicate entry
error - {unknown}: dbi exception: dbd::mysql::db do failed: duplicate entry
'24690' for key 'import_biblios.primary' at /usr/share/koha/lib/c4/installer.pm
line 739
and even the biblios in Reservoir detected as Duplicate entry.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #17 from Mason James --- (In reply to Mason James from comment #15) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > aah, ive just clicked that 32975 isnt pushed ignore this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 --- Comment #7 from Mason James --- (In reply to Mason James from comment #6) > (In reply to Tomás Cohen Arazi from comment #5) > > Pushed to master for 23.05. > > this looks to be missing from master, can you push? oops ignore, now i see it bc43c6e7fe Bug 32975: Error in package.json's definition of css:build vs css:bui ld:prod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #16 from Mason James --- (In reply to Mason James from comment #15) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > aah, ive just clicked that 32975 isnt pushed confirmed package build fails with 32975 applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #15 from Mason James --- (In reply to Jonathan Druart from comment #9) > With bug 32975 you shouldn't need the second patch. aah, ive just clicked that 32975 isnt pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #6 from Mason James --- (In reply to Tomás Cohen Arazi from comment #5) > Pushed to master for 23.05. this looks to be missing from master, can you push? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 --- Comment #14 from Mason James --- (In reply to Tomás Cohen Arazi from comment #11) > Can we remove the lines instead of commenting? new patch uploaded with lines removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Mason James changed: What|Removed |Added Attachment #146995|0 |1 is obsolete|| --- Comment #13 from Mason James --- Created attachment 147106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147106=edit Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32994] Remove compiled files from src (2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994
--- Comment #12 from Mason James ---
(In reply to Tomás Cohen Arazi from comment #11)
> Can we remove the lines instead of commenting?
>
> Also, are you running a dev install on packaging? the map files are only
> supposed to be generated when not using the :prod parameters, as those map
> files are only relevant on dev builds (they carry information about the scss
> file from which the css files were generated, for easier debugging).
>
> Can you post what you run on the build? Also, have you run git clean -f -x
> -d to make sure you don't have stray files?
note: no DEV_INSTALL=1 is set
here is how i'm running a build...
$ git clean -fdx
$ git log --oneline | head -1
9863c18cc8 Bug 32933: Use val() instead of attr("value") when getting field
values with jQuery
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
$ dpkg-buildpackage -b
...
webpack 5.74.0 compiled with 3 warnings in 21555 ms
Done in 36.15s.
make[1]: *** No rule to make target
'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by
'pm_to_blib'. Stop.
make[1]: Leaving directory '/mnt/ssd4/pb-nightly/koha'
dh_auto_build: make -j1 returned exit code 2
make: *** [debian/rules:9: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Text to go in the||Public and tertiary release notes||libraries in New Zealand ||can claim tax back on ||purchases. || ||This ||enhancement adds a new ||system preference ||'CalculateFundValuesIncludi ||ngTax'. || ||When set to ||'Exclude' these libraries ||can input order prices with ||tax included (so vendor ||invoice prices - which do ||contain tax - can be ||entered directly into ||Koha). || ||However, the order ||prices removed from the ||Koha funds are the tax ||exclusive values (NZ ||libraries claim tax back so ||it should not be removed ||from their funds). Status|Failed QA |Signed Off --- Comment #26 from Alex Buckley --- Setting this back to 'Signed off'. I have done the following: 1. Corrected the test plan on the second patch so that it reflects the point David raised in comment #6 2. Submitted a fifth patch fixing QA test tool failures. I am still getting one failure for the template on ordered.tt, but I think that might just be my qa test tools. 3. Fixed the unit tests and expanded the unit test coverage - we now test both when vendors have listincgst/invoiceincgst set to 0 and 1. The unit tests now consistently pass: " kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=156, 12 wallclock secs ( 0.05 usr 0.01 sys + 9.22 cusr 2.01 csys = 11.29 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=156, 11 wallclock secs ( 0.04 usr 0.02 sys + 9.10 cusr 1.50 csys = 10.66 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #25 from Alex Buckley --- Created attachment 147105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147105=edit Bug 31631: (follow-up) Fixes for QA test tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #24 from Alex Buckley --- Created attachment 147104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147104=edit Bug 31631: Unit tests Test plan: Run amended Budgets.t test and all existing unchanged Acquisition tests in koha-shell - sudo koha-shell - prove t/db_dependent/Budgets.t - prove t/db_dependent/Acquisition - prove t/db_dependent/Acquisition.t - prove t/db_dependent/Budgets Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #23 from Alex Buckley --- Created attachment 147103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147103=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631
--- Comment #22 from Alex Buckley ---
Created attachment 147102
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147102=edit
Bug 31631: Optionally use tax-exclusive values for calculating fund values
Test plan:
1. Apply patches
2. sudo koha-upgrade-schema
3. Restart services
4. Set TaxRates syspref = 0.15
5. Create a new fund with amount = 1000
6. Add an order to a basket with the following values:
- Fund = Choose the fund from step #5
- Quantity = 1
- Vendor price = 10
- Tax rate = 15%
- Discount = 20%
- Retail price = 10.00
- Replacement cost = 10.00
- Actual cost = 10.00
- Ensure the basket belongs to a vendor with ("List prices" = "Don't include
tax" and "Invoice prices" = "Don't include tax")
7. Go to the Acquisitions home page
8. Confirm the 'Ordered' column for the step #5 fund contains 9.20
9. Click on the 9.20 link and confirm the ordered.pl page that loads
also contains 9.20 as the 'Subtotal'
10. Change 'CalculateFundValuesIncludingTax' = 'Exclude'
11. On the Acquisitions home page confirm the 'Ordered' column now
contains 8.00
12. Click on the 8.00 link and confirm the ordered.pl page also contains
8.00 as the 'Subtotal'
13. Close your basket and receive your order - change the 'Actual costs'
= 8.00 (the $10 retail price less the 20% discount, tax exclusive)
14. Go to the Acquisitions home page and confirm the 'Spent' column now
contains 8.00
15. Click on the 8.00 link and confirm the spent.pl page also contains
8.00 as the 'Subtotal'
16. Change 'CalculateFundValuesIncludingTax' = 'Include'
17. Confirm the 'Spent' column on the Acquisitions home page now shows
9.20
18. Click on the 9.20 link and confirm the spent.pl page also contains
9.20 as the 'Subtotal'
Sponsored-by: Waikato Institute of Technology, New Zealand
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147098|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147099|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147100|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147101|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32747] OPAC detail page explodes for items without itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33033] Suggested enhancement - item type names in languages other than english
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33033 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Hi, this is already available. Once you have added your item types in administration, edit them and you'll see a link to add translations in all installed languages right next to the description field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #21 from Alex Buckley --- Created attachment 147101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147101=edit Bug 31631: (follow-up) Fixes for QA test tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #20 from Alex Buckley --- Created attachment 147100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147100=edit Bug 31631: Unit tests Test plan: Run amended Budgets.t test and all existing unchanged Acquisition tests in koha-shell - sudo koha-shell - prove t/db_dependent/Budgets.t - prove t/db_dependent/Acquisition - prove t/db_dependent/Acquisition.t - prove t/db_dependent/Budgets Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #19 from Alex Buckley --- Created attachment 147099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147099=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #18 from Alex Buckley --- Created attachment 147098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147098=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147013|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley changed: What|Removed |Added Attachment #147015|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Amanda Campbell changed: What|Removed |Added CC|acampb...@hmcpl.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29250] "Show checkouts/fines to guarantor" cannot be set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29250 Amanda Campbell changed: What|Removed |Added CC|acampb...@hmcpl.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18787] Create permission profiles for staff users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 Amanda Campbell changed: What|Removed |Added CC|acampb...@hmcpl.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33021] Show an alert when adding a reserved item to an item bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- This works as described but I do notice a 409 ( conflict ) error in the console. -http://localhost:8081/api/v1/items/974/bundled_items Is this a problem that needs addressed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 --- Comment #5 from Aleisha Amohia --- Hi all, Yes adding an item does cause the record to be indexed, but this Koha instance does not use items (they are a cataloguing agency). Also it had nothing to do with Zebra being started or stopped, I tried cataloguing with Zebra on and with Zebra off and it had no effect. Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Lucas Gass changed: What|Removed |Added Attachment #147087|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147097=edit Bug 33032: Fix alternate holdings in staff interface search results If system preference AlternateHoldingsField is used, one can see a display in OPAC search results. This display does not appear in staff interface search results anymore. Test plan : 1) Enable feature with system preference 'AlternateHoldingsField', ie 852abc 2) Edit a record to add some datas in field 852 3) Perform a search in staff interface => You see the alternate holdings datas Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] 'Cancel' link still points to tools home when it should be cataloguing home on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Lucas Gass changed: What|Removed |Added Attachment #146980|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147096=edit Bug 33015: Fix some 'Cancel' links to point to cataloging start page Some 'cancel' links of tools moved to the cataloguing module still pointed to the tools start page. This adds some more consistency. To test: * Go to cataloguing * Batch item editing * Batch record deletion * Batch record modification (create a MARC modification template first) * Verify the 'cancel' link on each page points to tools * Apply patch: cancelling should not take you to the cataloging start page Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33015] 'Cancel' link still points to tools home when it should be cataloguing home on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33015 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33033] New: Suggested enhancement - item type names in languages other than english
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33033 Bug ID: 33033 Summary: Suggested enhancement - item type names in languages other than english Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: koha.b...@treasury.govt.nz QA Contact: testo...@bugs.koha-community.org We would like the ability to implement item type names in langauages other than English. This type of enhancement would be useful for all duel/multi language Koha sites. Explanation: We have a Te Reo version of Koha (as well as an English one) but our item type names display in English on that Te Reo site. We have no way of allocating Te Reo names and have then display in Te Reo on the Te Reo site while keeping them displaying in English on the English site. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32973] Use template wrapper for breadcrumbs: about, main, and error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32973 Lucas Gass changed: What|Removed |Added Attachment #146898|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147095=edit Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page This patch updates the staff interface home page, the about page, and the error page template so that they use the new template WRAPPER for breadcrumbs. To test, apply the patch and view each page to confirm that the breadcrumbs are correct: - Staff interface home page - About page - Error page (the easiest example is a 404 error) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32973] Use template wrapper for breadcrumbs: about, main, and error page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32973 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33000] Use template wrapper for breadcrumbs: Acquisitions part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass changed: What|Removed |Added Attachment #146899|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147094=edit Bug 33000: Use template wrapper for breadcrumbs: Acquisitions part 1 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions home - Vendor search results - Basket details - Cancel order - Create EDIFACT order - Basket edit - Basket deletion confirmation - Add to basket - From a staged MARC file - From existing orders (copy) - Basket groups (create, edit) - EDIFACT messages Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33000] Use template wrapper for breadcrumbs: Acquisitions part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Lucas Gass changed: What|Removed |Added Attachment #146917|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147093=edit Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> - Late orders, - moddeliverydate.tt - modordernotes.tt -- These two templates aren't linked to from anywhere, but you can navigate directly to: http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1 - Order search, order search results - Invoice search, - Invoice details, - Invoice files - Vendor -> Basket -> Add to basket -> - From a new (empty) record - From existing orders (copy) - From a subscription Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Lucas Gass changed: What|Removed |Added Attachment #146924|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 147092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147092=edit Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33016] MARC diff view still shows tools instead of cataloging in title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 Lucas Gass changed: What|Removed |Added Attachment #146981|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 147091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147091=edit Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging Some remaining to dos of us moving the staged import tools from tools to cataloging. To test: * Export a record from your Koha catalog * Import it using the staged MARC import tool, matching on biblionumber (the diff view is only visible if the record matched an existing one) * View the staged records * Click on the 'Diff' link * Verify that the page title and breadcrumbs still read 'Tools' * Apply patch * Not these should read 'Cataloging' Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33016] MARC diff view still shows tools instead of cataloging in title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33016 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Attachment #128150|0 |1 is obsolete|| --- Comment #22 from Andreas Roussos --- Created attachment 147090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147090=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process make the "Highlight" / "Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client, with UNIMARC-based instances affected the most as the "Highlight" / "Unhighlight" button disappears if you perform a specific OPAC search (see Test plan below). This patch fixes that by upgrading the highlighter plugin to its latest version for both the OPAC and the Staff interface. Then, the changes from commit 2e4b574074 (Bug 5844) are applied to the plugin code. Also, Koha uses "term" instead of "highlight" as the class name for the highlighting elements, so the plugin code is modified for that aspect, too. Finally, the plugin file is renamed to reflect the version change (v3 -> v5) and all references to the old filename in the Template files are updated. Test plan: 0) In a UNIMARC instance, catalogue two books using the titles given below (Title subfield = 200$a): Book 1: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book 2: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) 1) OpacHighlightedWords and StaffHighlightedWords should both be set to "Highlight". 2) Search the OPAC for "επιτομή των" (without the quotes). In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) the "Highlight" / "Unhighlight" button vanishes c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 3) Repeat the same search in the Staff interface. In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) Even though some terms are highlighted, the button still says "Highlight" c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 4) Apply this patch. 5) Repeat the searches (you may have to press CTRL-F5 to reload the JavaScript code). This time the "Highlight" / "Unhighlight" button is displayed in the OPAC, and all your search terms should be highlighted in yellow. Toggling the highlight should cause no problems, and there shouldn't be any errors logged in your browser's Console. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #21 from Andreas Roussos --- Created attachment 147089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147089=edit Staff interface term highlighting partially broken (UNIMARC instance on current master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #20 from Andreas Roussos --- Created attachment 147088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147088=edit OPAC highlight button disappearing (UNIMARC instance on current master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #19 from Andreas Roussos --- Thank you all for your valuable feedback! Please see my answers below: (In reply to Katrin Fischer from comment #11) > I think if we update the plugin, we will also want to change the version > coded in the file name, so we force browsers to load the updated file: Done. I will attach an updated patch that renames the plugin. > Also, your change is only for the OPAC, we probably need to update in the > staff interface separately. Actually, my first patch took care of both. See here: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128053=diff (In reply to Amaury GAU from comment #15) > I can't reproduce the Test Plan. Everything seems correct before and after > applying the patch, in both the Staff interface and the OPAC. Indeed, when I try the test plan on the current master (commit 9863c18cc8) I get what Katrin observed in Comment 11. However, if I set up a UNIMARC test instance on master I still get the disappearing "Highlight" button but now only in the OPAC! Also, in both the Staff interface and the OPAC the following message is displayed in the JavaScript Console: Uncaught DOMException: Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length. > This might have been corrected throughout the updates. Probably needs some > checkup. I will upload two more screenshots to show the highlighting behaviour in a UNIMARC instance, and will adjust the test plan. (In reply to Fridolin Somers from comment #18) > We need to rename jquery.highlight-3.js => jquery.highlight-5.js no ? Yes, we do. My updated patch will take care of this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 --- Comment #1 from Fridolin Somers --- Created attachment 147087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147087=edit Bug 33032: Fix alternate holdings in staff interface search results If system preference AlternateHoldingsField is used, one can see a display in OPAC search results. This display does not appear in staff interface search results anymore. Test plan : 1) Enable feature with system preference 'AlternateHoldingsField', ie 852abc 2) Edit a record to add some datas in field 852 3) Perform a search in staff interface => You see the alternate holdings datas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Fridolin Somers changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33032] New: Alternate holdings broken in staff interface search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Bug ID: 33032 Summary: Alternate holdings broken in staff interface search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If system preference AlternateHoldingsField is used, one can see a display in OPAC search results. This display does not appear in staff interface search results anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 --- Comment #1 from Owen Leonard --- Created attachment 147086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147086=edit Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs This patch updates the OPAC lists page with Bootstrap markup for the static tabs used to link to private and public shelves. These tabs are not dependent on JavaScript. To test, apply the patch and click "Lists" -> "Public lists" in the OPAC. The "Your lists" and "Public lists" tabs should look correct, and each should link to the correct view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard changed: What|Removed |Added Depends on||33031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33031] New: Update OPAC lists page to use Bootstrap markup for tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Bug ID: 33031 Summary: Update OPAC lists page to use Bootstrap markup for tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 32969 The OPAC's lists page (specifically, the list of lists view) uses jQueryUI markup to display tabs, which I missed in my round of Bootstrap tab updates because they're not triggered by JavaScript. We can replace the markup with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 [Bug 32969] Remove references to jQueryUI assets and style in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #1 from Kyle M Hall --- Created attachment 147085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147085=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Letters/TemplateToolkit.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32747] OPAC detail page explodes for items without itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 --- Comment #2 from Katrin Fischer --- Not that close... we agreed on not always checking - but this is the end user exploding pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Mark Hofstetter changed: What|Removed |Added CC||k...@trust-box.at --- Comment #4 from Mark Hofstetter --- Hi Aleisha, is the hack adding an item? if so it seems that it is related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33008 cheers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21842] always test Koha::ItemType in defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32747 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32747] OPAC detail page explodes for items without itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21842 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32747] OPAC detail page explodes for items without itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32747 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- Closely related to Bug 21842 that has been closed with wont fix. I'd be happy to reopen it ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33008] Record not indexed in Elasticsearch (ES) if no item attached AND zebra not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33008 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33019 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33008 CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32985] DefaultPatronSearchFields not affecting all patron searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 --- Comment #4 from Christopher Brannon --- (In reply to Katrin Fischer from comment #3) > I mean have you tried searching for a field that is not the cardnumber and > not included in the pref. > > My impression is that we might only have an exception for cardnumber in > patron search as we do this as a first step to directly open the record for > an exact match. I understand. I have, and regular patron search works as expected. I've added fields we've needed to search by and the preference works. That exception you mention is understandable, but misleading because it does not work for all patron searching, as in guarantor searching. It needs to be consistent. If we are going to have the cardnumber searchable regardless of what is in DefaultPatronSearchFields, it should be mentioned on the preference, and work EVERYWHERE, not just some places. Otherwise we have oddballs like me trying to figure out what is wrong and filing bugs. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33030] New: Add standardized subroutine for processing Template Toolkit syntax outside of notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Bug ID: 33030 Summary: Add standardized subroutine for processing Template Toolkit syntax outside of notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #85 from Barbara Johnson --- Just revisiting this bug since we talked about it today in a koha-US Acquisitions Special Interest Group meeting. All of the attendees agreed that this functionality would greatly help their libraries. Also, I see that this bug has 51 votes. Wondering what the next steps are to move this bug forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
