[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

David Cook  changed:

   What|Removed |Added

 Attachment #141950|0   |1
is obsolete||

--- Comment #14 from David Cook  ---
Created attachment 148848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148848=edit
Bug 31841: Use location,wrdl when searching Shelving location

The "location" index only has a word index defined, so we need
to specify the wrdl qualifier when searching it via the staff
interface dropdown menu

Test plan:
1) Change QueryAutoTruncate to "only if * is added"
2) Change IntranetCatalogSearchPulldown to "Show"
3) Search for "Shelving location" of "GEN" in catalogue
search bar
4) Note no results returned

5) Apply patch
6) koha-plack --restart kohadev

7) Repeat Step #3
8) Note that results appear for 'location,wrdl: GEN'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

David Cook  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #13 from David Cook  ---
(In reply to Fridolin Somers from comment #9)
> > since "location" doesn't have a phrase index defined...
> Why not add it to Zebra MARC21 configuration ?
> 
> Even if unlikely :
> Imagine two locations "foo bar" and "bar foo", words list type search "wrdl"
> will match both.
> 
> This indexing can be useful for other cases.

It might be worth adding that the status quo right now is doing a "wrdl" search
for "location", so I'm just trying to make the status quo explicit and
functional in all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #12 from David Cook  ---
Thanks for looking Magnus. It's a simple fix. I'll look at doing that now
actually...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33351] Record detail page broken in both OPAC and staff

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33351

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
Works fine for me. Can you provide steps to reproduce the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812

--- Comment #41 from David Cook  ---
(In reply to Hugo Agud from comment #39)
> The accdetail send the password via mail when a new account is created, but
> instead of plain text they receive the encrypted password

To nit-pick a little, it's "the password hash" rather than "the encrypted
password".

I think there's another bug report that removes "borrower.password" from
notices as well, since even emailing the password hash is not ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33352] Password sent by message (accdetails) without decryption

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33352

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from David Cook  ---
Blowfish isn't an encryption algorithm; it's a hashing algorithm. It computes
data only in one direction. You can't reverse the password hash without trying
to hack/crack it.

So the problem here isn't "the password is sent without being [decrypted]". The
problem is that the password hash is being sent instead of the cleartext
password. However, you shouldn't be sending out cleartext passwords by email.

That's why in Koha 21.11.05, due to bug 27812, you can no longer send out
cleartext passwords using ACCTDETAILS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. Applied bug 30975 (interactive, commented out the first patch) - this takes
a while as you have to say yes to all the dependent bugs.
2. Apply this patch - say no to apply dependent bugs (already done is step 1).
3. The plugin marc21_field_005.pl is already added to 005 for the MARC21
bibliographic frameworks in KTD.
4. Edit a bibliographic record: empty the 005 field, change to another field,
then click back into 005 - it should be autopopulated with a value.
5. Create a new record and click in 005 -  - it should be autopopulated with a
value.

Description
~~~

This is a standard cataloguing plugin. It autopopulates the 005 field with the
required value when you click in the field. (From the Library of Congress:
Sixteen characters that indicate the date and time of the latest record
transaction and serve as a version identifier for the record.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818

David Nind  changed:

   What|Removed |Added

 Attachment #146076|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148847=edit
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl

Remove unnecessary return statement

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #9 from David Nind  ---
How I tested


1. Applied bug 30975 (interactive, commented out the first patch) - this takes
a while as you have to say yes to all the dependent bugs.
2. The plugin dateaccessioned.pl is already added in KTD to:
   2.1 subfield 995$5 for the default UNIMARC bibliographic framework (need to
edit to make visible in the editor)
   2.1 subfield 952$d for the BKS MARC21 bibliographic framework (already
visible in the editor)
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard cataloguing plugin. It displays the flatpickr date widget to
let you select the date an item was acquired (995$5 in UNIMARC and 952$d in
MARC21).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817

David Nind  changed:

   What|Removed |Added

 Attachment #146075|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 148846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148846=edit
Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. Applied bug 30975 (interactive, commented out the first patch) - this takes
a while as you have to say yes to all the dependent bugs.
2. Added the plugin unimarc_field_146i.pl to subfield 146$i for the default
UNIMARC bibliographic framework in KTD.
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Bonus: With bug 30975 applied, cloning subfields and using the tag editor on
the cloned subfield now works as expected!

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867

David Nind  changed:

   What|Removed |Added

 Attachment #146132|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148845=edit
Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. Applied bug 30975 (interactive, commented out the first patch) - this takes
a while as you have to say yes to all the dependent bugs.
2. Added the plugin unimarc_field_146h.pl to subfield 146$h for the default
UNIMARC bibliographic framework in KTD.
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Bonus: With bug 30975 applied, cloning subfields and using the tag editor on
the cloned subfield now works as expected!

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866

David Nind  changed:

   What|Removed |Added

 Attachment #146131|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148844=edit
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865

--- Comment #6 from David Nind  ---
How I tested


1. Applied bug 30975 (interactive, commented out the first patch) - this takes
a while as you have to say yes to all the dependent bugs.
2. Remove the authorized value list currently used for 146$a in KTD.
3. Add the plugin unimarc_field_146a.pl to subfield 146$a for the default
UNIMARC bibliographic framework in KTD.
4. Edit a bibliographic record.
5. Select the tag editor for the subfield.
6. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865

David Nind  changed:

   What|Removed |Added

 Attachment #146130|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 148843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148843=edit
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33352] New: Password sent by message (accdetails) without decryption

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33352

Bug ID: 33352
   Summary: Password sent by message (accdetails) without
decryption
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pablo.joneslo...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hello! I'm using version 21.11 of Koha. In our case, we have user
self-registration enabled, and when a user registers, they are automatically
sent a Welcome email through Koha messaging. The message includes their account
name and password, but the problem is that the password is sent without being
encrypted. This did not happen in the previous version. I understand that Koha
uses Blowfish encryption. Do you have any idea how to decrypt the password so
that it can be displayed?

For example, this is the programmed message (accdetails):

Hello, <> <>.

Your account has been created in the UNPSJB Library System. Your account
details are as follows:

Username: <>
Password: <>

The text sent is:

Hello, Ximena Vanina 

Your account has been created in the UNPSJB Library System. Your account
details are as follows:

Username: ximenavanina.
Password: $2a$08$orfJ.jWu.RYvR/nhn.gs1e42FnSnliuLuXmsRG38hTP3irEC5BJUS

Any ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250

--- Comment #6 from David Nind  ---
I had another go at testing, but the jobs list doesn't seem to be uodating
properly for me.

Here is how I tested using KTD:

1. master is up-to-date, so the latest patches for bug 32594 are included.

2. Using ES7 with Searchengine set to Elasticsearch, rebuilt search index
(koha-elasticsearch --rebuild -d -b -a kohadev).

3. Applied both patches, flush_memcached, restart_all.

4. Enabled RealTimeHoldsQueue system preference.

5. Ran perl misc/link_bibs_to_authorities.pl -v

6. Current job list look like this (no change after 10 minutes):

   1New null/1  Update Elasticsearch index  03/28/2023 17:18
   2New null/1  Update Elasticsearch index  03/28/2023 17:18

7. Changed LinkerModule system preference.

8. Ran perl misc/link_bibs_to_authorities.pl -v

9. There are now four jobs in the current job list:

   1New null/1  Update Elasticsearch index  03/28/2023 17:18
   2New null/1  Update Elasticsearch index  03/28/2023 17:18
   4New null/1  Update Elasticsearch index  03/28/2023 17:28
   5New null/1  Update Elasticsearch index  03/28/2023 17:28

Is there something else I need to do? It seems to me that either the ES index
updates are not actually running, or that the status is not updating when it is
finished (even though the latest patches for bug 32594 are in master).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-"

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

--- Comment #2 from Marius  ---
I add a patch to solve this problem. The patch has to make sure that even if
there is a categorycode with "-" it will be able to display it.

testing plan:
1- Go to Administration->Patron categories
2- Make sure you don't already have a boss categories that contains a "-"
3- Go to Administration->Record matching rules
4- Everything should be displayed as it does
5- Return to Patron categories
6- Add a new category
   In the category code put a "-" and save
7- Return to Record matching rules
   The page should be half loaded as in the photo
8- Apply this patch
9- Repeat the step 7, everything should work on the Record matching rules page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

--- Comment #26 from Hammat wele  ---
Created attachment 148842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148842=edit
Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in
opac-display-record-count.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-"

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

--- Comment #1 from Marius  ---
Created attachment 148841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148841=edit
Bug 5: fix marc overlay rules accept '-'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-"

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

Marius  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31706] Journal title and article title fields on the ILL request form should be expandable

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31706

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Pedro Amorim  ---
This bug refers to ILL backend specific work, has been followed-up on and does
not relate with Koha core.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148817|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 148839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148839=edit
Bug 18398: (follow-up) Update POD & Unit tests

Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148816|0   |1
is obsolete||

--- Comment #13 from Nick Clemens  ---
Created attachment 148838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148838=edit
Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address

This patch updates the enque method in C4::Message to expect a
Koha::Patron object in the parameters and then uses that patron object
to select the correct email address for notices as defined by
AutoEmailPrimaryAddress.

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127

Andrew Auld  changed:

   What|Removed |Added

 CC||andrew.a...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #147700|0   |1
is obsolete||

--- Comment #2 from Biblibre Sandboxes  ---
Created attachment 148837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148837=edit
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Record overlay rules
 - Search filters (must have SavedSearchFilters enabled)
 - System preferences
   -> OverDriveAuthName -> OverDrive library authnames table
 - MARC bibliographic framework -> MARC structure (list, new, edit,
   delete confirm).
 - Record matching rules (list, new, edit, delete confirm)
 - OAI sets configuration (list, new, edit)
   -> Define mappings
 - Patron attribute types (list, new, edit, delete confirm)
 - Patron restrictions (list, new, edit, delete confirm)

Signed-off-by: Andrew Auld 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Nick Clemens  changed:

   What|Removed |Added

 Attachment #147815|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 148836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148836=edit
Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc

C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is
called in other modules :
 > git grep GetAuthorizedHeading
C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading
C4/AuthoritiesMarc.pm:  $heading = ({ record => $record,
authid => $authid })
C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading {
C4/Breeding.pm:$heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord });
C4/ImportBatch.pm:$row->{'authorized_heading'} =
C4::AuthoritiesMarc::GetAuthorizedHeading( { authid =>
$row->{'candidate_match_id'} } );
C4/ImportBatch.pm:my $authorized_heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record });

This patch adds it to be exported.
For example for use in Koha plugins.

Test plan :
Check import of authorities from a file is OK

Signed-off-by: Phil Ringnalda 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33166] Can't call method "notforloan" on an undefined value when placing a hold

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33166

Koha Team University Lyon 3  changed:

   What|Removed |Added

 Blocks||23732


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732
[Bug 23732] Hold rules checker: show matched rules and syspref values to help
understand why a hold is possible or not
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732

Koha Team University Lyon 3  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED
 Depends on||33166
 CC||k...@univ-lyon3.fr


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33166
[Bug 33166] Can't call method "notforloan" on an undefined value when placing a
hold
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914

Philip Orr  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Philip Orr  ---
The display issue is now fixed!

All three tabs display correctly.
However when submitting a batch for modification only the tab "Enter a list of
record numbers" actually leads to a batch record modification; both other tabs
"Select a list of records" and "Upload a file" lead to the message "No records
were modified".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens  changed:

   What|Removed |Added

 Attachment #134270|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens  changed:

   What|Removed |Added

 Attachment #134894|0   |1
is obsolete||
 Attachment #140951|0   |1
is obsolete||
 Attachment #140952|0   |1
is obsolete||
 Attachment #140953|0   |1
is obsolete||
 Attachment #140954|0   |1
is obsolete||

--- Comment #23 from Nick Clemens  ---
Created attachment 148835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148835=edit
Bug 30579: Disentangle multi-hold and single bib forms

This patch alters the structure of the hold request page to make it clear
that "Hold next available", "Hold item group", and "Hold specific item" are
mutually-exclusive options.

While there is some duplication from this, it makes the sections easier to read
and allows for more variation in the two forms

To test:
 1 - Find a bib with multiple items
 2 - Enable item groups and item group holds in system preferences
 3 - Load the records detail page
 4 - Add an item group on the item groups tab
 5 - Select two items and add to the group
 6 - Place a hold for a patron
 7 - Confirm the three levels of holds are clear
 8 - Confirm checking the radio next to one disables the others
 9 - Confirm you can successfully place all 3 types of holds
10 - Confirm if placing a second hold that the type is forced correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

--- Comment #28 from Alex Arnaud  ---
Created attachment 148834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148834=edit
Bug 20424: provides biblio-zebra-indexdefs.xsl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #132829|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

--- Comment #27 from Alex Arnaud  ---
Created attachment 148833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148833=edit
Bug 20424: remove zebra index for field 901

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #132828|0   |1
is obsolete||

--- Comment #26 from Alex Arnaud  ---
Created attachment 148832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148832=edit
Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #132827|0   |1
is obsolete||

--- Comment #25 from Alex Arnaud  ---
Created attachment 148831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148831=edit
Bug 20424: Add new zebra indexes for the last IFLA updates

Signed-off-by: Sonia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148405|0   |1
is obsolete||

--- Comment #13 from Philip Orr  ---
Created attachment 148830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148830=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148404|0   |1
is obsolete||

--- Comment #12 from Philip Orr  ---
Created attachment 148829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148829=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148403|0   |1
is obsolete||

--- Comment #11 from Philip Orr  ---
Created attachment 148828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148828=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148402|0   |1
is obsolete||

--- Comment #10 from Philip Orr  ---
Created attachment 148827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148827=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148401|0   |1
is obsolete||

--- Comment #9 from Philip Orr  ---
Created attachment 148826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148826=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Philip Orr  changed:

   What|Removed |Added

 Attachment #148400|0   |1
is obsolete||

--- Comment #8 from Philip Orr  ---
Created attachment 148825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148825=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Hammat wele  changed:

   What|Removed |Added

 Attachment #143292|0   |1
is obsolete||

--- Comment #48 from Hammat wele  ---
Created attachment 148824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148824=edit
Bug 11300: Add a new authority linker which searches for authority links on a
Z39.50 server.

This patch adds a Z39.50 Linker which searches for authority links on a remote
server.

If a matching authority is found, it's imported in the local database for
linking with the current biblio record.

If no matching authority was found on the remote server, the Linker falls back
to a local authority search.

Configuration :
* The option "Z39.50 Server" is added to the LinkerModule preference. You must
choose this to use the new Linker.
* The preference LinkerZ3950Server is required and specifies which server to
use for linking. It must contain the "name" of the server, as defined in the
z3950servers table.
* You can set the "local_first" option in the LinkerOptions preference to force
the Linker to search for authorities in the local database first. If no local
authority match was found, the Linker falls back to a remote Z39.50 search.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #6 from Magnus Enger  ---
$ git bz apply 29268

Bug 29268 - Query used in Koha::Biblio->get_marc_host is incorrect

127591 - Bug 29268: Correct cni handling for get_marc_host

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29268: Correct cni handling for get_marc_host
Using index info to reconstruct a base tree...
M   Koha/Biblio.pm
M   t/db_dependent/Koha/Biblio.t
M   t/db_dependent/Koha/Biblio/host_record.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Biblio/host_record.t
Auto-merging t/db_dependent/Koha/Biblio.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/Biblio.t
Auto-merging Koha/Biblio.pm
CONFLICT (content): Merge conflict in Koha/Biblio.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29268: Correct cni handling for get_marc_host
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-29268-Correct-cni-handling-for-getmarchost-k4WekE.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

Mark Hofstetter  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

--- Comment #2 from Mark Hofstetter  ---
Created attachment 148823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148823=edit
Bug 33299: Item type column displays translated_description  when placing item
level holds in OPAC

0. go to detail page of a record->place hold->"show more options"->"specific
item"
1. Item type column is empty when placing item level holds in OPAC
(or only the image is displayed)
2. apply patch
3. now the translated description is also shown
4. test with another language
4. please sign off ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33351] Record detail page broken in both OPAC and staff

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33351

Pierre CHALON  changed:

   What|Removed |Added

   Severity|major   |critical
Summary|Record detail page broken   |Record detail page broken
   |in both OPAC and staff in   |in both OPAC and staff
   |UNIMARC |

--- Comment #2 from Pierre CHALON  ---
Same results with MARC21 and UNIMARC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
URL|https://gitlab.com/mrenvoiz |https://gitlab.com/mrenvoiz
   |e/Koha/-/commits/bug_29002  |e/Koha/-/tree/bug_29002_reb
   ||ased

--- Comment #17 from Martin Renvoize  ---
Git branch rebased.. commits a little tidying and functionality needs
testing/reviewing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158

alexandra.sp...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||alexandra.sp...@bsz-bw.de

--- Comment #2 from alexandra.sp...@bsz-bw.de ---
Hello, 

everything works, except the following in Item types and Authorized values:
If you did not previously have any icon selected, the "None" tab should be
active. There is no active Tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many barcodes

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mag...@libriotech.no

--- Comment #4 from Magnus Enger  ---
Looks like this needs some more discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342

David Gustafsson  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #5 from David Gustafsson  ---
@Andreas Jonsson, thanks for spotting this! Have now fixed the patch and
changed the description as the previous one did not correctly describe the
current behavior. Since the assignment evaluates to true in a boolean context
$overlay_framework as far as I can tell is always set to undef (which should
now be fixed).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mag...@libriotech.no

--- Comment #11 from Magnus Enger  ---
Sorry, patch does not apply and I don't see how to resolve the conflict: 

$ git bz apply 31841

Bug 31841 - Shelving location search in staff interface sometimes creates
invalid Zebra query

141950 - Bug 31841: Use location,wrdl when searching Shelving location

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 31841: Use location,wrdl when searching Shelving location
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 31841: Use location,wrdl when searching Shelving
location
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-31841-Use-locationwrdl-when-searching-Shelving-qsJQXm.patch

<<< HEAD
[% IF ms_location %]
Shelving location (code)
===
[% IF ms_locationcommawrdl %]
Shelving location (code)
>>> Bug 31841: Use location,wrdl when searching Shelving location

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299

Mark Hofstetter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||k...@trust-box.at
   Assignee|oleon...@myacpl.org |k...@trust-box.at

--- Comment #1 from Mark Hofstetter  ---
found the error submit patch soon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342

David Gustafsson  changed:

   What|Removed |Added

 Attachment #148766|0   |1
is obsolete||

--- Comment #4 from David Gustafsson  ---
Created attachment 148822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148822=edit
Bug 33342: Fix framework handling in manage-marc-import.pl

In a follow up in bug 15869 an if clause is added where "=" is
used instead of "eq" resulting in framwork always being set to undef.
Fix this by using the correct operator. Also fix the name of
the framework placeholder in manage-marc-import.pl
which differed from the template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342

David Gustafsson  changed:

   What|Removed |Added

Summary|Assigment in if clause sets |Fix framework handling in
   |invalid marc framework  |manage-marc-import.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33351] Record detail page broken in both OPAC and staff in UNIMARC

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33351

--- Comment #1 from Pierre CHALON  ---
The problem comes probably from sample data.
We have no problem with different data from sample.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135
[Bug 21135] Upon log in, user is redirected to account page instead of the page
where they logged in from
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21135] Upon log in, user is redirected to account page instead of the page where they logged in from

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||31699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699
[Bug 31699] Add a generic way to redirect back to the page you were on at login
for modal logins
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21135

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21135] Upon log in, user is redirected to account page instead of the page where they logged in from

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31699

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21135] Upon log in, user is redirected to account page instead of the page where they logged in from

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

--- Comment #4 from Martin Renvoize  ---
See bug 31699 for the general approach we now have in code.. it can be used on
any login links we wish.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33351] New: Record detail page broken in both OPAC and staff in UNIMARC

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33351

Bug ID: 33351
   Summary: Record detail page broken in both OPAC and staff in
UNIMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: pierre.cha...@univ-lyon2.fr
QA Contact: testo...@bugs.koha-community.org

This problem appears on sandboxes (PTFS-europe and Biblibre) in UNIMARC.

Can't call method "itemtype" on an undefined value at
/kohadevbox/koha/opac/opac-detail.pl line 709

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mag...@libriotech.no

--- Comment #8 from Magnus Enger  ---
Sooo... I'm not sure what mss is or does, but should we continue to remove it,
get it back or investigate why the new solutions seems to be slower than it
should be?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32964] OPACResultsMaxItemsUnavailable description is misleading

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964

--- Comment #9 from Marcel de Rooy  ---
Created attachment 148821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148821=edit
Bug 32964: (follow-up) Additional rewording for XSLT item display

Test plan:
Check OPAC preferences, OPACResultsMaxItems and siblings.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32964] OPACResultsMaxItemsUnavailable description is misleading

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964

--- Comment #8 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #7)
> Intrigued by this report. I have the impression that you found a bug in the
> group by library option. As it once worked differently :)
> We are now renaming according to current behavior. Digging a bit furthere
> here.

No, I must be wrong. The comments in the XSLT code are clear enough. But the
description on the pref is confusing indeed.

Caroline: What do you think of the additional rewording in the follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223

--- Comment #2 from David Cook  ---
I'll be wanting to look more at these. Sounds very useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346

--- Comment #6 from Martin Renvoize  ---
All working, thanks. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #148808|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 148820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148820=edit
Bug 33346: Add missing class and id to link

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #148807|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 148819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148819=edit
Bug 33346: Add Help link to Koha manual in ERM module

The 'Help' is missing in the ERM module, this patch is adding it.

Test plan:
Confirm that the Help link is displayed on the different pages of the
ERM module and that it leads to the correct page of the manual.

Signed-off-by: Pedro Amorim 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32426] Make userid generation pluggable

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #45 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #44)
> Tomas: Should be okay now.

Thanks for taking care, Marcel. Good job!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #148763|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 148818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148818=edit
Bug 33341: Address some perlcritic errors in 5.36

Some old-style code is making our tests fail when run in Debian Testing.

This patch addresses this.

To test:
1. Launch bookworm KTD:
   $ KOHA_IMAGE=master-bookworm ktd up -d
2. Run:
   $ ktd --shell
  k$ prove t/00-testcritic.t
=> FAIL: It fails!
3. Apply the patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

--- Comment #166 from Victor Grousset/tuxayo  ---
Discussed in current hackfest, now that there is vue in Koha via the ERM
patches, there isn't anything to salvage from the vue patch submitted here.
Mostly because here it's vue 2 (ERM is vue 3) and some other technical reason
IIUC.

But there is also the fact that the vue patch here wasn't a clone of the react
patch. But different UX also. So first step is to settle on what is wanted for
circ rules interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #3 from Martin Renvoize  ---
Fast QAing this one.. it's just simple syntax improvement.. no functional
changes but a move to best practice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

--- Comment #12 from Martin Renvoize  ---
Thanks Nick :).. POD now updated and Unit tests added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail

2023-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >