[Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Victor Grousset/tuxayo --- Works, makes sense (not expert so I just checked fields in code against UNIMARC documentation), QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #2 from Lucas Gass --- Filed Bug 33640 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33640] New: Adding new item group from item additem.pl does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 Bug ID: 33640 Summary: Adding new item group from item additem.pl does nothing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4. At the bottom of the page in the under Add to item group click the 'Options:' dropdown and select 'Create new item group'. 5. Add a name and click add item. 6. No item group is created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Version|21.11 |master CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #1 from Lucas Gass --- Created attachment 150422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150422=edit Bug 33639: Fix selectors for adding to item group To test: Apply patch 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved Note: this does not fix the 'Create new item group' feature in the dropdown. I am having trouble seeing why that would work in the first in place! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass changed: What|Removed |Added Attachment #150418|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 150421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150421=edit Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #6 from Lucas Gass --- Trivial fix, changes make perfect sense, QA script is happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What|Removed |Added Attachment #148593|0 |1 is obsolete|| --- Comment #6 from Hammat wele --- Created attachment 150420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150420=edit Bug 33317: Add system preference to set meta robots for the OPAC Websites must have a robots meta tag to improve search engine crawling, so we could tell search engines to not index OPAC pages for example. To test: 1) Look at opac-main source and see that meta name=robots is missing. 2) Apply patch. 3) Run ./installer/data/mysql/updatedatabase.pl 4) Go to system preferences > OPAC and add some directives to OpacMetaRobots (ex: noindex,nofollow). 5) Look at opac-main source and confirm that meta name=robots now has content equal to the text set in the OpacMetaRobots system preference. 6) This should Prevent search engines from indexing Opac pages (if OpacMetaRobots is set to noindex) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19814] Batch Check-in function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 cart...@slolibrary.org changed: What|Removed |Added CC||cart...@slolibrary.org --- Comment #28 from cart...@slolibrary.org --- Hi, This sounds like a great, this would help a lot with our workflow! I would like to ask that it be more like batch item modification so I can use the scanner or copy/paste barcodes to check in! Thank you, Charlie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] New: Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Bug ID: 33639 Summary: Adding item to item group from 'Add item' screen doesn't work Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: sbr...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When creating a new item in 22.11.02, the 'Add to item group' feature at the bottom of the 'Add item' screen doesn't successfully add that new item to a group. To replicate: -Create one or more item groups for a bib if needed -Create a new item, and at the bottom of the 'Add item' screen, select the item group to which you want this item added. Save. -On the Normal tab, see that the item has not been added to the item group you selected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose changed: What|Removed |Added Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/670 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #274 from Caroline Cyr La Rose --- Hello everyone! This is a bit technical for me, but I attempted to add the information to the manual. Would any of you who worked on this have the time to read what I wrote and let me know if I mangled anything? (It's not very long) https://gitlab.com/koha-community/koha-manual/-/merge_requests/670 Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #5 from Lucas Gass --- *** Bug 33638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 33637 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- Kidclamp's is better. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #10 from David Nind --- I was testing at the same time as Phil (using KTD): 1. Everything works as per the test plan. 2. However, after applying the patch and repeating the searches: - for Step 6, after getting no results using my name and clicking on "Try another search", the name in the field reverts to the original record name and not my name - for Step 10, the same as step 6 - which is probably correct (but I'm not sure...) - feel free to change the status to Failed QA if this is not the expected behavour (I would probably have failed QA if there wasn't already a sign off) 3. I tested using MARC21 and UNIMARC instances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2646] Add sort option for the series number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Attachment #149624|0 |1 is obsolete|| Attachment #150368|0 |1 is obsolete|| --- Comment #9 from Phil Ringnalda --- Created attachment 150419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150419=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda changed: What|Removed |Added Assignee|p...@chetcolibrary.org |n...@bywatersolutions.com --- Comment #8 from Phil Ringnalda --- That does still retain one behavior change, altering the meaning of the "Try another search" button on search results from the historic "Try a different search starting from scratch with an empty form" to "Try another search starting with a form prefilled from the saved record" but I can't object too much to that, since I have always avoided the another search from scratch button, preferring to use the browser's back button if I'm only a page or two forward, or just closing and reopening the popup if I'm several pages deep. According to my concept of the meaning of "stable" we should still revert back down to oldoldstable and then land this on master, but obviously my concept of stable is very different from Koha's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33638 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33637 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #3 from David Nind --- This looks like a duplicate of bug 33638 - I'll leave it to the patch authors to decide which is the 'best' solution 8-). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- This looks like a duplicate of bug 33637 - I'll leave it to the patch authors to decide which is the 'best' solution 8-). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33637] Batch patron modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind changed: What|Removed |Added Attachment #150394|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 150418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150418=edit Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 David Nind changed: What|Removed |Added Attachment #150411|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 150417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150417=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens changed: What|Removed |Added Attachment #149758|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 150416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150416=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Marius Mandrescu Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33633] Check if email exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- I have my doubts whether this should be part of Koha as ILS. I suppose that you could process/parse the mail logs from an internal mail server (if being used) in a "neighboring application" and support changing mail queue status and/or patron email address etc. via REST API in order to signal that there are issues with this address. Perhaps we need a flag to temporarily block email. Just brainstorming.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #9 from Nick Clemens --- I still noted 6 warnings about this, but we don't need to do them all at once :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #8 from Nick Clemens --- Created attachment 150415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150415=edit Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #7 from Nick Clemens --- Created attachment 150414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150414=edit Bug 33597: Fix deleting cookie for holdfor(club) Resolve: Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax. Test plan: Similar to previous patch. Check console on logout page. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens changed: What|Removed |Added Attachment #150148|0 |1 is obsolete|| Attachment #150149|0 |1 is obsolete|| Attachment #150151|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 150413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150413=edit Bug 33597: Get rid of warning about intranet_bib_list Resolve: Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. basket_22.1200022.js:67:65 Test plan: Do not apply this patch. Logout from staff. Check browser console warnings. Apply this patch. Login and logout again. Check warnings again. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Nick Clemens changed: What|Removed |Added Attachment #149985|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 150412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150412=edit Bug 33356: Add mana-kb hint to reports start page An alternate placement of the Mana KB hint on the reports start page. To test: * Go to Reports module * Verify the hint shows when you haven't decided on Mana KB * Once you set yes or no, it will no longer show Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #18 from Nick Clemens --- Something is not right with Koha::Item::last_returned_by It returns a patron object, but the relationship is to ItemsLastBorrower and the call to set it doesn't work prove -v t/db_dependent/Circulation/StoreLastBorrower.t Also Koha/Virtualshelfshare.pm : everywhere else we assign resultset to rs, then create new - it isn't wrong, just inconsistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 --- Comment #1 from Kyle M Hall --- Created attachment 150411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150411=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #150409|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 150410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150410=edit Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #12 from Lucas Gass --- If you are testing this bug it is probably good to know about this one which may effect your ability to test: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 --- Comment #1 from Lucas Gass --- Created attachment 150409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150409=edit Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #150393|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 150408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150408=edit Bug 33634: Correct anchors in system preference submenu To test: 1. Go to Koha Administration -> Global system preferences 2. Go to a tab with a few headings like Circulation 3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls 4. Notice this anchor link does not work, you are not taken to the recalls preferences 5. Apply patch 6. Try again, the links should take you to the proper place. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #12 from Nick Clemens --- (In reply to Katrin Fischer from comment #11) >if you add any line breaks just for > making the HTML more readable, they will also all create a line break. > Should we not do either/or? We had calls that already did this - if we want either or, we need a flag to determine whether the field is HTML or not, otherwise we need to test with regex? I don't think the additional breaks for HTML cause a problem, but I'll follow your viewpoint. Maybe a new bug - so we can make a decision and be consistent on all the calls? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass changed: What|Removed |Added Attachment #150156|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 150407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150407=edit Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Notices and slips - New notice - Edit notice - Confirm deletion - Batch patron modification - Overdue notice/status triggers - Cataloging -> - Manage staged records - Batch details - MARC modification templates - Edit actions for a template Signed-off-by: Barbara Johnson Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #11 from Nick Clemens --- This looks neat, I like the feature, the patches need some cleanup Must fix: - the patch adds the function _add_rowdata, I think it's a rebase leftover? - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine - delete the commented lines from the code Could fix: - the routine should take a hashref, the more parameters we have, the nicer it i s to have them named -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33638] New: Batch patron modification is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Bug ID: 33638 Summary: Batch patron modification is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com While testing Bug 33582 I noticed that Batch patron modification seems to be broken: To recreate: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. Even with valid cardnumbers or borrowernumbers I get: No patron card numbers or borrowernumbers given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27765] Set a custom order to libraries on the libraries page in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 Katrin Fischer changed: What|Removed |Added Summary|Set a custom order to |Set a custom order to |library branches on |libraries on the libraries |opac-library.pl |page in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 --- Comment #6 from Kyle M Hall --- QA note: My initial reaction was to require a cli switch, but simply not having that notice will disable the feature from the UI, which is preferable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall changed: What|Removed |Added Attachment #148244|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 150406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150406=edit Bug 23773: Send membership expiry notices by sms too Test plan: 1. Verify in "About" page that SMS::Send is installed. If not, install it. 2. Set system preferences: - SMSSendDriver = 'Test' - MembershipExpiryDaysNotice = 30 3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and verify that both email and sms parts are filled. Use a different title and body for the sms part 4. Create a new borrower with an email address and an SMS number. Set their expiry date to a date next week 5. Run misc/cronjobs/membership_expiry.pl --confirm 6. Verify in the patron "Notices" tab that two notices are pending, one for email, one for sms Sponsored-by: Médiathèque de Montauban Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #11 from Katrin Fischer --- Thanks, Nick! I am not sure really about allowing HTML and then also meddling with line breaks. It creates a somewhat weird combination. html_line_break This filter replaces any newlines with HTML tags, thus preserving the line breaks of the original text in the HTML output. So you can do now without , but if you add any line breaks just for making the HTML more readable, they will also all create a line break. Should we not do either/or? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #12 from Katrin Fischer --- Does the bug description still fit with what the patch does? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #11 from Katrin Fischer --- Because it fixes JavaScript error breaking functionality with the patron attributes on that page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #7 from Katrin Fischer --- I guess it would always have to be configurable through the *Unwanted* preference like all other fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #12 from Katrin Fischer --- (In reply to David Cook from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to David Cook from comment #9) > > > (In reply to Katrin Fischer from comment #7) > > > > Marked bug 32385 as a dependency for this one. I think in order to have > > > > different timeouts, we need different sessions first. > > > > > > Actually, thinking about this again, you would already have different > > > sessions between the OPAC and staff interface, so long as your hostname is > > > different, which should be 99% of Koha instances... > > > > How do you calculate that 99% ? > > Perhaps I should say 99% of commercially supported Koha instances. Even then > you're right that it's a total guess based off the idea that Koha defaults > to separate hostname for OPAC and staff interface when using Debian > packages, and most commercial support vendors for Koha seem to use Debian > packages. You are right that different subdomains will create separate sessions, but I think the 99% is wrong. Koha used ports for a long time in its default setup and there are still reasons why you would want to do so. We do, with packages, use ports, for the installations we support. And it doesn't solve the problem here... different sessions, one timeout. How could you attach a different timeout to each? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall changed: What|Removed |Added Attachment #149223|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall --- Created attachment 150405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150405=edit Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL To test: 1. prove t/db_dependent/cronjobs/advance_notices_digest.t 2. prove t/db_dependent/Letters/TemplateToolkit.t 3. prove t/db_dependent/Koha/CurbsidePickups.t 4. prove t/db_dependent/Koha/Patrons.t 5. prove t/db_dependent/Patron/Messaging.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33633] Check if email exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #7 from Katrin Fischer --- But how do those tools operate and should we be using them? If you use a web service, it will know that you requested information about a certain email, giving them more information. I might not know much about how this works, but I would not want the library to use a third party vendors software and give them my email (GDPR etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22178] Add start and end date for repeated holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22178 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33633] Check if email exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #5) > Would it not also be dangerous/a security issue if such a service existed? > Guessing email addresses and testing them would be a great activity for > spammers or even people who want to sell email addresses to spammers. Regardless, tools exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Nick Clemens changed: What|Removed |Added Attachment #149736|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 150404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150404=edit Bug 32937: Make Zebra ignore the copyright symbol in searches It's common to catalog the year with the copyright symbol attached to it. This creates some issues with search that we can fix by adding the © to the list of characters Zebra ignores in search. To test: * Search for any existing publication year with ©, example: ©1951 * Verify your record is not found * Add the copyright symbol to a record, verify it's now found with ©, but not without * Apply patch * On ktd: * sudo cp -i /kohadevbox/koha/etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/word-phrase-utf.chr * sudo koha-zebra --restart kohadev * sudo koha-mysql kohadev * DELETE FROM biblio WHERE biblionumber = 369; * The reindex woudl fail for me with this broken record present. * sudo koha-rebuild-zebra -f kohadev * Repeat searches, the records should be found when searching with and without ©. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall changed: What|Removed |Added Attachment #149245|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 150403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150403=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass Signed-off-by: Laura Escamilla Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens changed: What|Removed |Added QA Contact||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #13 from Nick Clemens --- Just to be pedantic, it is possible to use these before these patches, but it is inconvenient: [% FOREACH attribute IN illrequest.illrequestattributes %] [% IF attribute.type == 'title' %] [% attribute.value %] [% END %] [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Kyle M Hall changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #12 from Nick Clemens --- Created attachment 150402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150402=edit Bug 32548: Replace while with map Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #11 from Nick Clemens --- Created attachment 150401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150401=edit Bug 32548: Add tests Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens changed: What|Removed |Added Attachment #149064|0 |1 is obsolete|| Attachment #149065|0 |1 is obsolete|| Attachment #149066|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 150400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150400=edit Bug 32548: Make illrequestattributes available in ILL emails Without this ILL module only provides very limited data to be included in the notices sent about the request itself. We have the columns illrequests, but not the illrequestattributes, that often will contain the more useful information needed. This patch enables to use values of the illrequestattributs using [% illrequestattributes. %] in the notices. To test: * Apply patch * First you'll need to activate the ILL module and install a backend to use it with. FreeForm was used for this test plan, BLDSS is usually also good for testing. See: https://wiki.koha-community.org/wiki/ILL_backends * Also set up an SMTP server to use for notices and make sure the email address is set in KohaAdminEmailAddress and the user you are using for testing this with. * Make sure your user has an email address and will receive ILL notices by seleting them in the messaging preferences. * Create an ILL request with the FreeForm backend for your user. * On the ILL request detail page: "Display supplier metadata" Pick some attributes you want to use in the notice * Go to Tools > Notices and slips and edit ILL_REQUEST_UNAVAIL * Add some of the attributes you picked. Example: [% illrequestattributes.type %] [% illrequestattributes.title %] * Back to the ILL request detail page: Send notice to patron > ILL request unavailable * Go to your patron's account and check the notices tab * The generated notice shoudl show and include the information from the illrequestattributes you picked. Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall changed: What|Removed |Added Attachment #149202|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 150399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150399=edit Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Signed-off-by: Laura Escamilla Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33633] Check if email exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #5 from Katrin Fischer --- Would it not also be dangerous/a security issue if such a service existed? Guessing email addresses and testing them would be a great activity for spammers or even people who want to sell email addresses to spammers. But I like the idea of having users verify their emails and flagging verified ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #236 from Katrin Fischer --- (In reply to Nick Clemens from comment #235) > (In reply to Aleisha Amohia from comment #234) > > There are lots of signoffs on these patches, can this be marked Passed QA? > > Hi Aleisha, > > It appears I was wrong in comment 187, see comment 222 > > It is a question of how the fallback should work, so we either need a DB > update, or to change the expectation for when a rule is not set It sounds like this needs a little bit more work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Nick Clemens changed: What|Removed |Added Attachment #146265|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 150398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150398=edit Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens changed: What|Removed |Added Attachment #150134|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 150397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150397=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
