[Koha-bugs] [Bug 33597] Get rid of few SameSite warnings

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597

--- Comment #10 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #8)
> Signed-off-by: Nick Clemens 

Thx Nick

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24400] REST API: Checkout

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400

Danyon Sewell  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||danyonsew...@catalyst.net.n
   ||z
   Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n
   |ity.org |z
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24400] REST API: Checkout

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400

--- Comment #1 from Danyon Sewell  ---
Created attachment 150449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150449&action=edit
Bug 24400: Rest API for checkout WIP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #34 from Aleisha Amohia  ---
Created attachment 150448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150448&action=edit
Bug 6796: Fix saving of libraries and tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #33 from Aleisha Amohia  ---
Created attachment 150447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150447&action=edit
Bug 6796: Fix atomic updates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #32 from Aleisha Amohia  ---
Created attachment 150446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150446&action=edit
Bug 6796: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #146991|0   |1
is obsolete||

--- Comment #31 from Aleisha Amohia  ---
Created attachment 150445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150445&action=edit
Bug 6796: (follow-up) Fix logic for calculating following day's open hours

Since days for branch hours are stored as 0-6 in the database, when it's
a Saturday (6) incrementing the date leads to an error when issuing an
hourly loan because no opening hours are found for the non-existent day
(7).

This patch fixes this by calculating the tomorrow day and setting it to
0 if it's greater than 6.

This patch also corrects the mappings for days, where local_day_of_week
caluclates the date with Sunday first, which put it out of sync with the
database opening hours days.

Sponsored-by: Auckland University of Technology
Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #146990|0   |1
is obsolete||

--- Comment #30 from Aleisha Amohia  ---
Created attachment 150444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150444&action=edit
Bug 6796: Consider library hours when calculating due date + tests

This feature adds the ability to set opening and closing hours for your
library and for these hours to be considered when calculating due dates
for hourly loans. If the due date for an hourly loan falls after the
library closes, the library can choose for the due date to be shortened
to meet the close time, or extended to meet the open time the next day.
This feature adds a new table 'branch_hours' for storing the open and
close times per day for each library, and a new system preference
'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be
followed when calculating due dates.

To test:
1. Apply patches and update database. Upgrade schema if not applying
patch with schema changes. Restart services.
2. Go to Administration -> Libraries. Edit a library and scroll to the
bottom to find the 'opening hours' section. Test adding and removing
open and close times on various days. Confirm saving works as expected.
3. Add a new library and test adding open and close times works as
expected.
4. Edit your default library and save open and close times for each day.
5. Go to Administration -> Circulation and fine rules. Edit a rule, set
the unit to 'hours' and set the loan period to a number that would cause
a checkout to be due after the close time you just set, i.e. if you set
your close time to be 5pm and your system time is currently 1pm, set the
loan period to be 5 (5 hours) so the calculated due date would be 6pm.
6. Go to Administration -> system preferences. Search for
ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in
the Circulation system preferences. Confirm the pre-selected option is
'ignore'. Keep this tab open.
6. In a new tab, get the barcode for an item that has an itemtype
matching the circulation rule you just set.
7. Go to the checkouts for a patron that has a categorycode matching the
circulation rule you just set.
8. Check out your item. Confirm that the checkout is due at the end of
the loan period, not taking closing hours into consideration. Return the
item.
9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'close', so the due date should be shortened to meet the close time.
10. Check out your item. Confirm the checkout is due when the library
closes. Return the item.
11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'open', so the due date should be extended to meet the opening time.
12. Check out your item. Confirm the checkout is due the next day when
the library opens.
13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #146989|0   |1
is obsolete||

--- Comment #29 from Aleisha Amohia  ---
Created attachment 150443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150443&action=edit
Bug 6796: ConsiderLibraryHoursWhenIssuing system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #146988|0   |1
is obsolete||
 Attachment #146992|0   |1
is obsolete||

--- Comment #28 from Aleisha Amohia  ---
Created attachment 150442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150442&action=edit
Bug 6796: Add branch_hours table and set opening hours for library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

David Nind  changed:

   What|Removed |Added

 Attachment #150430|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 150441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150441&action=edit
Bug 23781: SMS notices and messaging preferences for recalls

This patch adds recalls notices (pick up a waiting recall or return a
requested recall) to the messaging preferences.

To test:
1) Apply Bug 19532
2) Apply this bug
3) Update database, rebuild dbix files
4) Ensure UseRecalls syspref is enabled and values have been set in the
circulation rules for recalls
5) Go to a borrower (Person A) account page in the Intranet or the OPAC
6) Go to messaging preferences
7) Notice there are now preferences for two recalls notices
8) Select email as a preference
9) Find a different borrower (Person B) and set their messaging
preferences to SMS
10) Check out any item to Person B
11) Go to the OPAC logged in as Person A and find that item
12) Recall the item
13) In the terminal, look at the message_queue in the database. There
should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS
14) Go back to the Intranet and check in the item. Confirm the recall
when checking in
15) Look at the message_queue in the database again. There should be a
'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email.
16) Confirm tests pass
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Lucas Gass 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

--- Comment #13 from David Cook  ---
(In reply to Katrin Fischer from comment #12)
> You are right that different subdomains will create separate sessions, but I
> think the 99% is wrong. Koha used ports for a long time in its default setup
> and there are still reasons why you would want to do so. We do, with
> packages, use ports, for the installations we support.
> 
> And it doesn't solve the problem here... different sessions, one timeout.
> How could you attach a different timeout to each?

For your case, I think you'd need different cookie names for OPAC and Staff.
Mostly would involve refactoring...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148791|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 150440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150440&action=edit
Bug 33348: Show authority heading use with Elasticsearch

This patch ensures the ShowHeadingUse system preference and feature works as
expected when using Elasticsearch as the searchengine.

To test, follow the test plan at Bug 29990 Comment 9. Ensure the SearchEngine
system preference is set to Elasticsearch.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #240 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #236)
> (In reply to Nick Clemens from comment #235)
> > (In reply to Aleisha Amohia from comment #234)
> > > There are lots of signoffs on these patches, can this be marked Passed QA?
> > 
> > Hi Aleisha,
> > 
> > It appears I was wrong in comment 187, see comment 222
> > 
> > It is a question of how the fallback should work, so we either need a DB
> > update, or to change the expectation for when a rule is not set
> 
> It sounds like this needs a little bit more work?

Attached an atomic update patch, not sure how it affects the bug status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #239 from Aleisha Amohia  ---
Created attachment 150439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150439&action=edit
Bug 8367: Add holds_pickup_period fallback circulation rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148545|0   |1
is obsolete||

--- Comment #238 from Aleisha Amohia  ---
Created attachment 150438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150438&action=edit
Bug 8367: (QA follow-up) Improve display when value not set for rule

When a rule is not set for a speficic line, the value in the syspref
will be used. This should be made clear in the interface.

To test:
1 - Add a new rule for a specific item type
2 - Do not fill the 'Hold pickup period'
3 - Confirm that the rule defaults to the system preference
4 - Hover on 'Default' in the circ rules under 'Hold pickup period'
5 - Confirm the text is readable

Signed-off-by: Nick Clemens 
Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148544|0   |1
is obsolete||

--- Comment #237 from Aleisha Amohia  ---
Created attachment 150437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150437&action=edit
Bug 8376: (QA follow-up) Update message on Hold waiting pickup report

Signed-off-by: Nick Clemens 

https://bugs.koha-community.org/show_bug.cgi?id=8367
Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

--- Comment #24 from Aleisha Amohia  ---
Created attachment 150436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150436&action=edit
Bug 30928: (QA follow-up) Schema updates

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

--- Comment #23 from Aleisha Amohia  ---
Created attachment 150435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150435&action=edit
Bug 30928: (QA follow-up) DB updates

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150386|0   |1
is obsolete||

--- Comment #22 from Aleisha Amohia  ---
Created attachment 150434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150434&action=edit
Bug 30928: Add interface to statistics

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #147838|0   |1
is obsolete||
 Attachment #150387|0   |1
is obsolete||

--- Comment #21 from Aleisha Amohia  ---
Created attachment 150433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150433&action=edit
Bug 30928: Add tests

prove -v t/db_dependent/Koha/Statistics.t
prove -v t/db_dependent/Stats.t

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30928] Add interface to statistics table

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150408|0   |1
is obsolete||

--- Comment #3 from Aleisha Amohia  ---
Created attachment 150432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150432&action=edit
Bug 33634: Correct anchors in system preference submenu

To test:
1. Go to Koha Administration -> Global system preferences
2. Go to a tab with a few headings like Circulation
3. Click on a heading in the sidebar navigation under Circulation that takes
you a bit down the page, like Recalls
4. Notice this anchor link does not work, you are not taken to the recalls
preferences
5. Apply patch
6. Try again, the links should take you to the proper place.

Signed-off-by: Barbara Johnson 
Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634

Aleisha Amohia  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |alei...@catalyst.net.nz
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #149127|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 150431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150431&action=edit
Bug 30295: Send a notification when a recall is manually cancelled

This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will
be sent to the requestor when their recall is cancelled. This notice
can also be configured using the messaging preferences.

To test:

1. Apply the patch, update database, restart services.
2. Ensure UseRecalls system preference is enabled and values have been
set in the circulation rules for recalls
3. Log in as a patron (Patron A) to the staff client and view your account
details
4. Notice there is now a 'recall cancelled' notice that can be
configured under messaging preferences
5. Confirm this notice also shows in the messaging preferences page on
the OPAC
6. Select email and sms as a preference for the 'recall cancelled' notice and
save. You may need to enable other settings to see the sms options
(SMSSendDriver for example)
7. Check out an item to another patron (Patron B)
8. Log into the OPAC as Patron A and place a recall on the checked out
item/biblio
9. Go back to the staff client and view the biblio. Go to the recalls
tab and cancel the recall.
10. Go to Patron A's accout and view their notices tab
11. Confirm the 'recall cancelled' notice has been generated for both
email and sms.

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Andrew Auld 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

--- Comment #21 from Aleisha Amohia  ---
(In reply to Marcel de Rooy from comment #19)
> Applying: Bug 23781: SMS notices and messaging preferences for recalls
> Using index info to reconstruct a base tree...
> M   Koha/Recall.pm
> M   Koha/Recalls.pm
> M   installer/data/mysql/en/mandatory/sample_notices.yml
> Falling back to patching base and 3-way merge...
> Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml
> Auto-merging Koha/Recalls.pm
> CONFLICT (content): Merge conflict in Koha/Recalls.pm
> Auto-merging Koha/Recall.pm
> CONFLICT (content): Merge conflict in Koha/Recall.pm

Fixed, set back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148260|0   |1
is obsolete||

--- Comment #20 from Aleisha Amohia  ---
Created attachment 150430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150430&action=edit
Bug 23781: SMS notices and messaging preferences for recalls

This patch adds recalls notices (pick up a waiting recall or return a
requested recall) to the messaging preferences.

To test:
1) Apply Bug 19532
2) Apply this bug
3) Update database, rebuild dbix files
4) Ensure UseRecalls syspref is enabled and values have been set in the
circulation rules for recalls
5) Go to a borrower (Person A) account page in the Intranet or the OPAC
6) Go to messaging preferences
7) Notice there are now preferences for two recalls notices
8) Select email as a preference
9) Find a different borrower (Person B) and set their messaging
preferences to SMS
10) Check out any item to Person B
11) Go to the OPAC logged in as Person A and find that item
12) Recall the item
13) In the terminal, look at the message_queue in the database. There
should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS
14) Go back to the Intranet and check in the item. Confirm the recall
when checking in
15) Look at the message_queue in the database again. There should be a
'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email.
16) Confirm tests pass
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6

2023-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910

--- Comment #13 from Katrin Fischer  ---
Any chance for this one still? I'd like to pick a new icon for inventory from
the newer version :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/