[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #31 from David Cook --- Despite my above comment, I think this should go ahead. It's a valuable contribution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046
--- Comment #30 from David Cook ---
Comment on attachment 150125
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125
Bug 29046: Use EmailFieldPrecedence in first_valid_email_address
Review of attachment 150125:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=29046=150125)
-
::: Koha/Patron.pm
@@ +1439,5 @@
> +
> +my @fields = split /\s*\|\s*/,
> + C4::Context->preference('EmailFieldPrecedence');
> +for my $field (@fields) {
> +$email = $self->$field;
You could crash Koha by putting junk into EmailFieldPrecedence.
I think either @fields should be validated or $self->$field should be
validated.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Cook --- Bug 33223 - Koha::Patron->notice_email_address isn't consistently used 148168 - Bug 33223: Replace 'first_valid' with 'notice' for email addresses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33223: Replace 'first_valid' with 'notice' for email addresses Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt M opac/opac-sendbasket.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33223: Replace 'first_valid' with 'notice' for email addresses hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33223-Replace-firstvalid-with-notice-for-email-t8SwfM.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33592] Use drag or sorting options for AutoEmailPrimaryAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33592 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #14 from David Cook --- I still wish that we'd done a better shift from home/work to primary/secondary overall. So many libraries use work/secondary emails as the most important email and Koha has made things so confusing over the years. Bug 18398, Bug 33223 and Bug 29046 go a long way to improving things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #29 from David Cook --- I am so excited for this one to get in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #21 from David Cook --- Just double checking... this is an Elasticsearch issue only right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #17 from David Cook --- (In reply to Katrin Fischer from comment #16) > (In reply to David Cook from comment #15) > > (In reply to Katrin Fischer from comment #14) > > > Not only for our use case - currently it's not possible to set different > > > timeouts even if you are using different sub domains which divides the > > > sessions. > > > > I'm not 100% sure I understand what you're saying. > > > > Different subdomains have different cookies, but in Koha there is only the > > "timeout" syspref. Is that what you mean? > > Yes. So if we added a new "opac_timeout" syspref and hooked it into the Auth system, we'd be able to have separate timeouts for OPAC and staff interface, but only for systems that have separate cookies for the OPAC and staff interface. I figure it's probably worth moving forward on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 Mason James changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Mason James changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate --- Comment #48 from Mason James --- (In reply to Lucas Gass from comment #47) > Backported to 22.05.x for upcoming 22.05.12 can we get this backported to 21.11 and 21.05 please -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #2 from David Nind --- The patch no longer applies 8-(... git bz apply 31652 Bug 31652 - Add geo-search 141406 - Bug 31652: Add geo-search Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31652: Add geo-search .git/rebase-apply/patch:323: trailing whitespace. # can be single or multiple parameters separated by comma: kw,right-Truncation warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch.pm M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M Koha/SearchEngine/Elasticsearch/Search.pm M admin/searchengine/elasticsearch/field_config.yaml M admin/searchengine/elasticsearch/mappings.yaml M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt M opac/opac-search.pl .git/rebase-apply/patch:323: trailing whitespace. # can be single or multiple parameters separated by comma: kw,right-Truncation warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging admin/searchengine/elasticsearch/mappings.yaml Auto-merging admin/searchengine/elasticsearch/field_config.yaml CONFLICT (content): Merge conflict in admin/searchengine/elasticsearch/field_config.yaml Auto-merging Koha/SearchEngine/Elasticsearch/Search.pm Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Auto-merging Koha/SearchEngine/Elasticsearch.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31652: Add geo-search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #15 from Alex Buckley --- (In reply to Lucas Gass from comment #10) > Alex, > > The QA tool complains about quite a few missing filters within Cookies.set. > I think we can add the html filter in those cases, right? > > Also, should none be option along with lax and strict? Hi Lucas, Thanks for your comments. Yes, adding the HTML filters does fix up the QA test tool failures, so I have added that as a followup patch. Currently all Koha cookies have 'samesite' = 'Lax' which is why I made it the default syspref value. However, according to https://web.dev/samesite-cookies-explained/ there are three possible options for the 'samesite' attribute: - Strict - Lax - None - means you intentionally want the cookie sent in a third-party context. So I think yes we should probably add 'none' as a value along with lax and strict. I have amended the first patch 'Add SameSiteSessionCookie system preference' to add the 'none' option. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #14 from Alex Buckley --- Created attachment 150560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150560=edit Bug 33259: (follow-up) Add HTML filters to Cookies.set Test plan: Run QA test tools and confirm the no complaints about filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #13 from Alex Buckley --- Created attachment 150559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150559=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #12 from Alex Buckley --- Created attachment 150558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150558=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors 11. Change 'SameSiteSessionCookie' to 'None' 12. Open a new private browser window, repeat step 4, and confirm the 'SameSite' = 'None' 13. Go to: Cataloguing > New record 14. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #11 from Alex Buckley --- Created attachment 150557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150557=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #148589|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #148590|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #150259|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #22 from Katrin Fischer --- Created attachment 150556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150556=edit Bug 33419: (QA follow-up) Remove changes to basic_workflow.t These are not needed: 942 and 200 have no subfields for homebranch and holdingbranch. The tests pass without these changes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer changed: What|Removed |Added Attachment #150553|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 150555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150555=edit Bug 33419: Make home library and current library mandatory by default Items without a home and current library can cause errors in Koha. On the bibliographic page, items appear without the "edit" drop-down or the selection check box. On a bulk delete page, items without a home library create a red error that says "Cannot delete". Making the home and current library values mandatory helps avoid these issues. Test plan (using koha-testing-docker (KTD)): 1. Reset KTD so that the web installer is used to setup Koha.[1] 2. Setup Koha using the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. [1] How to access the web installer to setup Koha in KTD: 1. Access the database server: mysql -uroot -ppassword -hkoha-db-1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (there may be some errors listed): flush_memcached and then restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33607] Show framework on record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass --- Hey Nick, Can this take into account the default framework, which does not have a framworkcode? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #20 from Katrin Fischer --- I had another look - the note about UNIMARC is invalid - holdingbranch already is mandatory without this patch. But now I get: FAIL t/db_dependent/selenium/basic_workflow.t FAIL valid syntax error Missing right curly or square bracket t/db_dependent/selenium/basic_workflow.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #5) > This table can be configured, you need to update admin/columns_settings.yml I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config. > Also you don't need the third parameter (opac=0), it's the default value. Fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer changed: What|Removed |Added Attachment #149731|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 150554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150554=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet Signed-off-by: Katrin Fischer Removed IS_OPAC param from AuthorisedValues.GetByCode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #19 from David Nind --- Hi Laura. I have signed off, and also had a go at amending the commit message to include a description and the test plan (including adding your name as the author). (See https://wiki.koha-community.org/wiki/Commit_messages) Feel free to amend it! David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind changed: What|Removed |Added Attachment #150532|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 150553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150553=edit Bug 33419: Make home library and current library mandatory by default Items without a home and current library can cause errors in Koha. On the bibliographic page, items appear without the "edit" drop-down or the selection check box. On a bulk delete page, items without a home library create a red error that says "Cannot delete". Making the home and current library values mandatory helps avoid these issues. Test plan (using koha-testing-docker (KTD)): 1. Reset KTD so that the web installer is used to setup Koha.[1] 2. Setup Koha using the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. [1] How to access the web installer to setup Koha in KTD: 1. Access the database server: mysql -uroot -ppassword -hkoha-db-1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (there may be some errors listed): flush_memcached and then restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What|Removed |Added Blocks||33590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Depends on||32571 Component|Serials |Staff interface CC||gmcha...@gmail.com QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Attachment #150460|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 150552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150552=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select CSV format. *If CSV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of CSV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Attachment #150459|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 150551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150551=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Attachment #150458|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 150550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150550=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Attachment #150457|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 150549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150549=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer --- Hi Laura, 2 small problems: 1) UNIMARC is missing the change for holdingbranch. +++ b/installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.yml @@ -849,7 +849,7 @@ tables: liblibrarian: "Home library" libopac: "Home library" repeatable: 0 - mandatory: 0 + mandatory: 1 kohafield: items.homebranch tab: 10 authorised_value: branches 2) Patch was not authored by you :) From 56de1c94a44702135407c30d318c896b50fd1fcb Mon Sep 17 00:00:00 2001 From: John Doe Date: Tue, 2 May 2023 18:35:23 + Subject: [PATCH] Bug 33419: Make home library and current library mandatory by default Have a look at git commit --amend --reset-author (when you have fixed the config) or git commit --amend --author if you just want to rewrite the line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #2 from Katrin Fischer --- I was wondering too - maybe only on the advanced editor? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #108 from Katrin Fischer --- (In reply to Jonathan Druart from comment #95) > (In reply to Martin Renvoize from comment #94) > > RM note.. the QA tool threw two issues.. POD coverage which is a false > > positive here I believe and a permissions issue.. but the permissions all > > look correct to me.. not sure what's going on there. > > FAIL t/db_dependent/Koha/AdditionalField.pm >FAIL file permissions > File must not have the exec flag > > Well, this is valid: > -rwxr-xr-x 1 jonathan jonathan 2506 mai2 11:51 > t/db_dependent/Koha/AdditionalField.pm > > Actually I guess it should be renamed to .t Small rebase (conflicts in the USE statements, not hard), fixed the test, unit and QA tests pass now. Also did some tests in the GUI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33654] Add more permissions to Item Group Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33654 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- On what version of Koha did this previously work for you? I would love to implement something like I proposed in Bug 30437 here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #107 from Katrin Fischer --- Created attachment 150548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150548=edit Bug 11844: (QA follow-up) Fix unit test file ending t/db_dependent/Koha/AdditionalField.pm -> t/db_dependent/Koha/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149692|0 |1 is obsolete|| --- Comment #106 from Katrin Fischer --- Created attachment 150547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150547=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149691|0 |1 is obsolete|| --- Comment #105 from Katrin Fischer --- Created attachment 150546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150546=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149690|0 |1 is obsolete|| --- Comment #104 from Katrin Fischer --- Created attachment 150545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150545=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149689|0 |1 is obsolete|| --- Comment #103 from Katrin Fischer --- Created attachment 150544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150544=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149688|0 |1 is obsolete|| --- Comment #102 from Katrin Fischer --- Created attachment 150543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150543=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149687|0 |1 is obsolete|| --- Comment #101 from Katrin Fischer --- Created attachment 150542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150542=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149686|0 |1 is obsolete|| --- Comment #100 from Katrin Fischer --- Created attachment 150541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150541=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149685|0 |1 is obsolete|| --- Comment #99 from Katrin Fischer --- Created attachment 150540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150540=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149684|0 |1 is obsolete|| --- Comment #98 from Katrin Fischer --- Created attachment 150539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150539=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149683|0 |1 is obsolete|| --- Comment #97 from Katrin Fischer --- Created attachment 150538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150538=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149682|0 |1 is obsolete|| --- Comment #96 from Katrin Fischer --- Created attachment 150537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150537=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #14 from Alex Buckley --- (In reply to David Nind from comment #13) > (In reply to Alex Buckley from comment #9) > > Hi David, > > > > I have attached a patchset adding a note to the system preference > > description noting to keep the text length to 3 lines. > > > > Is that what you had in mind? > > > > Thanks, > > Alex > > That looks fine to me. Thanks Alex! Thanks so much David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED|RESOLVED --- Comment #7 from Michael Hafen --- I think I jumped the gun here. I read the regexp as a character class, but it's not. The field is split on space followed by a new line. Having actually tested it, I see that there isn't a problem in practice. I'm still not sure about that regexp, but it does work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #6 from Michael Hafen --- Yes, I meant should not. The BarcodeSeparators sys pref should not apply, since it seems the barcode list field is already separated (one barcode per line). And the field should not be split on space, as you say, since space in a barcode is valid (many of my libraries have such barcodes). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 --- Comment #5 from Katrin Fischer --- Small fix, great effect, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer changed: What|Removed |Added Attachment #150483|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 150536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150536=edit Bug 32253: Load all CodeMirror lines initially when using advanced editor To test: 1. Have advanced editor turned on. 2. Load a record with many lines and see that not all the lines appear until you click on the visible ones. 3. Apply patch and try again 4. All lines should load. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #5 from Katrin Fischer --- > Looking at the page again, the field hint states that there should be one > barcode per line. I don't think the BarcodeSeparators system preference > should be applied to the field, and I also thing the field should split on > space. Should or should not? One per line seems save or using BarcodeSeparators seems the safest bet as we can't rule out libraries using spaces within their barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #4 from Michael Hafen --- I meant that the BarcodeSeparators system preference should not be applied to the barcode list field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen changed: What|Removed |Added Resolution|WORKSFORME |FIXED --- Comment #3 from Michael Hafen --- That would effect the file upload field, as per the code. The barcode list field is processed separately from the upload field, and does not reference the BarcodeSeparators system preference. I have already removed the \s from the BarcodeSeparators system preference. Looking at the page again, the field hint states that there should be one barcode per line. I don't think the BarcodeSeparators system preference should be applied to the field, and I also thing the field should split on space. I could understand stripping space from the beginning and/or the end of a barcode, but that's not what is currently done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Try changing the default \s\r\n to \r\n - that should give you the result you want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #1 from Katrin Fischer --- I believe BarcodeSeparators could be at play here (or should be), so it might be a configuration issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen changed: What|Removed |Added Summary|Barcode list field in |Barcode list field in |Inventory report doesn't|Inventory report shouldn't |honor BarcodeSeparators |be split on space |system preference | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33652] Always show datatable column filters at the top instead of the bottom of the table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33652 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33652 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33657] New: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Bug ID: 33657 Summary: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: michael.ha...@washk12.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia changed: What|Removed |Added Attachment #150533|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 150535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150535=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33656] In serial collection, items with "Missing" status are always checked by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33656 Maude changed: What|Removed |Added CC||maude.boudr...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33656] New: In serial collection, items with "Missing" status are always checked by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33656 Bug ID: 33656 Summary: In serial collection, items with "Missing" status are always checked by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: maude.boudr...@collecto.ca QA Contact: testo...@bugs.koha-community.org Created attachment 150534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150534=edit Example Hi, In serial collection, items with "Missing" status are always checked by default. Some libraries always maintain this status in issues. This creates a problem when they want to prune issues. Example : (see file attachment) To prune all the numbers of 2021, i need to : Go to the 2022 and 2024 tab to uncheck all missing numbers so that it is not deleted. Go to the 2021 tab, click on "select all" and on "delete selected issues". If you forget to uncheck before clicking delete, all the missing numbers of 2022 and 2024 will be deleted! Also, when we edit serials. All missing numbers appear. Which can become cumbersome when there are several numbers for several years. It would be nice to have a system preference that allows us to choose if we want to check it or not by default Thanks! Maude -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- Testing notes (using KTD): 1. To replicate the issue (note: ACCOUNTS_SUMMARY has no email notice, DUEDGST does have an email notice) I had to install another language (other than just having the Default and English (en) tabs): - Install another language: koha-translate install fr-CA - Enable the language: Administration > System preferences > I18N/L10N > language > Français (fr-CA) - Enable the TranslateNotices system preference - Edit the DUEDGST notice - It opens on the Default tab: expand the Email notice --> it is blank - Click on the tabs for English (en) and Français (fr-CA), and expand the email notice section (should be blank, unless you've added translations already) - Click back on the Default tab and expand the Email notice --> it is now not blank - Refreshing the page resets things, so you can then replicate the issue again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617 Kim Gnerre changed: What|Removed |Added CC||kgne...@hotchkiss.org --- Comment #3 from Kim Gnerre --- Because we support bugs 27595 and 33363 we support the development of this bug as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind changed: What|Removed |Added Attachment #150529|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 150533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150533=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33655] New: z39.50 search no longer shows search in progress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Bug ID: 33655 Summary: z39.50 search no longer shows search in progress Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl With 22.11 when adding a new bib record via z39.50 import there is no longer any indication that a search has been submitted. Previously, the cursor icon would change to the busy status, but now there is no change so there is no way to know if the search has been submitted or not. This leads to staff submitting the same search repeatedly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #16 from Laura Escamilla --- Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. How to setup the web installer ~~~ 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #15 from Laura Escamilla --- Created attachment 150532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150532=edit Bug 33419: Make home library and current library mandatory by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Attachment #150531|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Attachment #150530|0 |1 is obsolete|| --- Comment #14 from Laura Escamilla --- Created attachment 150531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150531=edit Bug 33419: Set home library and current library as mandatory by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #13 from Laura Escamilla --- Created attachment 150530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150530=edit Bug 33419: Set home library and current library as mandatory by default Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. How to setup the web installer 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33644] Link tracking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33644 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Attachment #149211|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Attachment #149213|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What|Removed |Added Attachment #149218|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #5 from Owen Leonard --- Created attachment 150529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150529=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Nind changed: What|Removed |Added Attachment #139647|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 150528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150528=edit Bug 31339: Add staff wrapper template include for tool plugins This change adds a template include which can be used as a WRAPPER for tool plugins, which makes it easy to pages in tool templates without having to copy and maintain a lot of template boilerplate. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. To search (step 3), go to Administration > Plugins > Manage plugins. 2. Searching for 'barclaycard' didn't generate an error, but searching for 'edifact' did. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind changed: What|Removed |Added Attachment #150523|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 150527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150527=edit Bug 30367: Skip processing if we don't get releases Some repos don't have releases, and this seems to break things as get returns an empty response. Calling from_json on this is the error This simply skips the bad responses to avoid the error: To test: 1. Have this on your koha-conf.xml file: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' The search will give an error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 4. Apply patch 5. Repeat 6. No error Note: The barclaycard plugin won't install even though it is returned as of this note - the plugin needs an update I believe, I don't think it's a Koha issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
