[Koha-bugs] [Bug 33683] Hello, I am writing this report in order to know what are the hardware required for install koha 22.11 on a module-server.

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33683

David Cook  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||dc...@prosentient.com.au
 Resolution|--- |INVALID

--- Comment #1 from David Cook  ---
Bugzilla is for reporting bugs and enhancements - not for asking general
questions.

I think what you want is probably the mailing lists. Consider the options at
https://koha-community.org/support/

--

That said, you're unlikely to find one ready answer to your question.

You can find some general information at
https://wiki.koha-community.org/wiki/System_requirements_and_recommendations

There are no published hardware requirements since Koha is a large
multi-component system and it depends on how many concurrent users it will
have. 

If you search around on the mailing lists, you can find some past conversations
on this topic: https://lists.katipo.co.nz/public/koha/2020-December/055608.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28965] Add public routes for lists

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #5)
> This failure is because you didn't run the updatedatabase script with bug
> 28959 applied. That said, I found some missing bits on that bug as well. So
> hold on.

Now that the dependencies are pushed, what else needs to be done to move this
into Needs Signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33683] New: Hello, I am writing this report in order to know what are the hardware required for install koha 22.11 on a module-server.

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33683

Bug ID: 33683
   Summary: Hello, I am writing this report in order to know what
are the hardware required for install koha 22.11 on a
module-server.
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: PC
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rulyvazque...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hi, my name is Raúl Francisco, and I'm studying mechatronics engineering. I'm
doing this post because of a project that tries to implement the KOHA software
in a physical library, more specifically 22.11 version. I would like to know
what would be the hardware requirements to install this version of Koha. In
this case, we will use a module-server. Thank you in advance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18148

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32341

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #150321|0   |1
is obsolete||

--- Comment #25 from David Cook  ---
Created attachment 150712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150712=edit
Bug 32341: (follow-up) Making the label not showed twice when the tables are in
responsive mode

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #149986|0   |1
is obsolete||

--- Comment #24 from David Cook  ---
Created attachment 150711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150711=edit
Bug 32341: (follow-up) Add responsivity to Curbside pickups table and changing
button style for finestables

To activate Curbside pickups
1- Enable the CurbsidePickup system preference
1.1 Go to Administration > Global system preferences
1.2 Search for CurbsidePickup
1.3 Change the value for 'Enable'
1.4 Click on 'Save all circulation preferences'
2- Configure time slots for at least one library
2.1 Go to Administration > Curbside pickup
2.2 Fill out the form for Centerville (or another library)
Enable: Check
Pickup interval: 10 (or other)
Maximum boss per interval: 3 (or other)
Patron-scheduled pickup: Check
Enable for waiting holds only: DO NOT check
2.3 Add a time slot
In 'New slot', enter
Monday
From: 10:00
To: 12:00
Click on 'Add'
3- Make an appointment from the OPAC
3.1 Go to OPAC
3.2 Open mobile mode
3.3 Connect with a user
3.4 Click on 'Curbside pickups'
3.5 Choose the library in 'Pick a library'
3.6 Choose a date in 'Pickup date'
3.7 Choose a time range in 'Select a time'
3.8 Click on 'Schedule pickup'
=> Notice The table is not responsive
4- Apply the patch
5- Execute 'yarn build --view opac'
6- Clean your cache or open your navigator on private mode (to load updated
css files)
7- Perform step 3.1, 3.2, 3.3, 3.4,
8- click on 'Your pickups'
 => Confirm that the CurbsidePickup table are now displayed correctly and
is now responsive.
9- Click on 'Charges'
 => Confirm that the Charges table are now displayed correctly and is now
responsive.

I correct a little bug. The "suspend_hold" button did not work anymore. This
change resets it to it's original state.

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #146294|0   |1
is obsolete||

--- Comment #23 from David Cook  ---
Created attachment 150710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150710=edit
Bug 32341: (follow-up) Making the remains OPAC tables responsive

Apply the patch and check for the responsivity of the following tables
1- Go to the OPAC
2- Open mobile mode
3- The following tables are not responsive
- Summary - Clubs
- Summary - Recalls
- Summary - Article requests
- Charges - (relative's)
- Search history - Authority
- Checkout history - All
- Checkout history - Checkouts
- Checkout history - On-site
- Recalls history
- Messaging
- Subscription (serial)
- Course reserves - Courses
- Course reserves - Reserves
- Authority search results
4- Apply the patch
5- Execute 'yarn build --view opac'
6- Clean your cache or open your navigator on private mode (to load updated css
files)
7- Perform previous step (1-3)
8- Confirm that the tables are now displayed correctly and is now responsive.

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #145159|0   |1
is obsolete||

--- Comment #22 from David Cook  ---
Created attachment 150709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150709=edit
Bug 32341: (follow-up) Alternate button style

This patch applies a different button style and does a couple of clean
up tasks: Removing the redundant sorting-related CSS and moving the
responsive button CSS to _common.scss where other DataTable-related
styles are found.

I think this different button style is more consistent with the OPAC's
design. It also eliminates untranslatable strings from the CSS.

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #144808|0   |1
is obsolete||

--- Comment #21 from David Cook  ---
Created attachment 150708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150708=edit
Bug 32341: (Fix) Changing the placement of the button

This attachment correct the placement of the responsive button. It is now in
its own column at the last column and the '+' and '-' are remplaced by 'Expand'
and 'Unexpand' to make it more clear.

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Attachment #144768|0   |1
is obsolete||

--- Comment #20 from David Cook  ---
Created attachment 150707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150707=edit
Bug 32341: Some OPAC tables are not displayed well in mobile mode

Some OPAC tables are not displayed well in mobile mode, it is absolutely
necessary to scroll to the right to read the content properly

This patch fix this problem by making the tables responsive

To test:
  1- Go to the OPAC
  2- Open mobile mode
  3- Go to a bibliographic record detail page in the OPAC
(opac-detail.pl?biblionumber=X)
  4- Check the Holdings table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> we see very narrow columns
--> unreadable text
  5- Go to to the page 'Summary' (opac-user.pl)
  6- Check the 'Checked out' table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  7- Check the 'Overdue' table
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  8- Go to the page 'Charges' (opac-account.pl)
  9- Click on 'Show all transactions'
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  10- Go to the page 'Search history' (opac-search-history.pl)
--> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
--> The columns are overflowing to the right
  11- Apply the patch
  12- Execute 'yarn build --view opac'
  13- Clean your cache or open your navigator on private mode (to load
updated css files)
  14- Perform previous step (1-10)
  15- Confirm that the tables are now displayed correctly and is now
responsive.

Signed-off-by: pauld 
Signed-off-by: LMSCloudPaulD 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #19 from David Cook  ---
Of course, since we .gitignore built files, it's tough to say if anything
changed. But it looks like the timestamp on
koha-tmpl/opac-tmpl/bootstrap/css/opac.css is different, so we'll assume it
worked despite the webpack error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #18 from David Cook  ---
root@kohadevbox:koha(bug_32341)$ yarn build --view opac
yarn run v1.22.19
$ yarn css:build && yarn js:build --view opac
$ gulp css && gulp css --view opac
[00:48:48] Using gulpfile /kohadevbox/koha/gulpfile.js
[00:48:48] Starting 'css'...
[00:48:48] Finished 'css' after 12 ms
[00:48:51] Using gulpfile /kohadevbox/koha/gulpfile.js
[00:48:51] Starting 'css'...
[00:48:51] Finished 'css' after 13 ms
$ webpack --mode development --view opac
[webpack-cli] Error: Unknown option '--view'
[webpack-cli] Run 'webpack --help' to see available commands and options
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this
command.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Attachment #150684|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 150706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150706=edit
Bug 33262: Add new field to REST API route for orders

Without this patch the API driven list of pending orders
on the order receive page was broken.

With the patch, all should be well now.

prove -v t/db_dependent/api/v1/acquisitions_orders.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Attachment #150683|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 150705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150705=edit
Bug 33262: Unit tests

prove t/db_dependent/Biblio.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Attachment #150682|0   |1
is obsolete||

--- Comment #23 from David Nind  ---
Created attachment 150704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150704=edit
Bug 33262: Store the biblionumber of a deleted record in the order line

When a bibliographic record is deleted and linked to an order
in the acquisition module, the biblionumber in the order line is
currently deleted as well. This makes it impossible to tell what
was ordered in the first place. This is a big issue for libraries
that need to be able to track how money was spent over long periods
of time.

With this patch the biblionumber of the deleted record will be moved
to a new column deleted_biblionumber in the order line, keeping the FK
on biblionumber.

To test:
* Apply patch, run dataase update
* Create a order/basket in the acquisitions module
* Order several things, you can use existing records from the sample data
* Make sure you order one of the records at least twice
* Take a look at the aqorders table in your database, using a report:

  SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders;

* From the catalog, delete the items on the records and then the records

  Note: There is a warning about attached orders warning about consequences
  for acquisitions. I have chosen to keep it at this point in time, as
  there are still visible side effects of deleting the record, like bug 10758.

* Re-run the report and compare results to the first run. deleted_biblionumber
  should now be filled with the biblionumber of the deleted record.
  biblionumber should be NULL/empty.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Attachment #150681|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 150703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150703=edit
Bug 33262: [DO NOT PUSH) Schema update

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Attachment #150680|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 150702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150702=edit
Bug 33262: Add deleted_biblionumber column to aqorders table

This adds a new column deleted_biblionumber to the aqorders table.
This will allow us to store the biblionumber of a deleted record,
so we will still be able to tell what has been ordered once the
record is deleted.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #84 from David Nind  ---
I've tested and added my sign-off (status was set to needs signoff - maybe Kyle
or Nick didn't change the status?).

Testing notes (using KTD):
- All tests pass before after the patch is applied (ran prove -v
t/db_dependent/)
- Everything works as per the test plan
- I also checked out an item with a due date before today and checked the
automatic renewal, then ran the automatic renewal script
misc/cronjobs/automatic_renwal.pl -v -c

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Nind  changed:

   What|Removed |Added

 Attachment #150678|0   |1
is obsolete||

--- Comment #83 from David Nind  ---
Created attachment 150701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150701=edit
Bug 31735: Fix array that should be passed as reference

Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Nind  changed:

   What|Removed |Added

 Attachment #150677|0   |1
is obsolete||

--- Comment #82 from David Nind  ---
Created attachment 150700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150700=edit
Bug 31735: Optimize OPAC checkouts view

Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Nind  changed:

   What|Removed |Added

 Attachment #150676|0   |1
is obsolete||

--- Comment #81 from David Nind  ---
Created attachment 150699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150699=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library
Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #17 from David Cook  ---
Upgrading the severity of this one, since this really should be fixed ASAP. 

--

That said, I'm looking at 21.11, and the holdings on the OPAC detail page looks
bad too (although in a totally different way).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook  changed:

   What|Removed |Added

   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31650] We should publish our coding guidelines more openly

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31650

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
(In reply to Julian Maurice from comment #1)
> Just an idea: we could move them inside the git repository. That would bring
> them closer to where they are needed, they can be published using a link to
> git.koha-community.org, and changes can be proposed using the current patch
> workflow.

I was just thinking how a lot of projects have a CONTRIBUTING.md file for this
in their git repos. 

https://github.com/github/docs/blob/main/CONTRIBUTING.md

https://github.com/rails/rails/blob/main/CONTRIBUTING.md

https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297

--- Comment #14 from David Cook  ---
(In reply to Jonathan Druart from comment #13)
> (In reply to David Cook from comment #12)
> > Hoping to look at these soon...
> 
> How soon?

Alas, I've given up hope for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #13)
> Maybe it would be better to have a clean break?

Makes sense to me. I'm already telling people that those tools have moved from
Tools to Cataloguing. No one has complained yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22848] Ability to merge suggestions

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22848

Tracy  changed:

   What|Removed |Added

 CC||tracy.skousen@suncitywest.c
   ||om

--- Comment #1 from Tracy  ---
I would also like the option to merge multiple suggestions. For popular books
we can get several suggestions this way we can add holds for all that made
suggestions. For some subjects we wait until we have multiple requests before
purchasing so a easy way to see how many have requested a title would be
helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610

--- Comment #4 from Nick Clemens  ---
[] are inclusive
{} Are exclusive

They can be mixed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Katrin Fischer  ---
Simple template fix, thx Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150648|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 150698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150698=edit
Bug 33672: Don't show item group holds on OPAC if not enabled

This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the
opac request form

To test:
1 - Enable 'EnableItemGroups' system preference
2 - On staff client, view a record details
3 - Go to 'Item groups' tab, add a enw group
4 - On holdings tab, select one or more items and add to group
5 - View record in OPAC
6 - PLace a hold
7 - Note group option is visible
8 - Apply patch
9 - Refresh, no group option
10 - Enable 'EnableItemGroupHolds' system preference
11 - Refresh opac page, note group option is visible

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

--- Comment #49 from Aleisha Amohia  ---
(In reply to Patrick Robitaille from comment #48)
> Hi,
> 
> It seems there is a problem with the default values ​​in the acquisition
> module as well. When adding a record to a basket with the "from a new
> (empty) record" option, the default values ​​are not added to the record
> according to the default grid.
> 
> Was there work for this problem? currently the ApplyFrameworkDefaults system
> preference does not fix the problem for the acquisition module.
> 
> Thanks, Patrick.

Hi Patrick, can you please open a new bug report for this enhancement so
someone can add to ApplyFrameworkDefaults to make it work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22375] Due dates should be formatted consistently

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375

--- Comment #8 from Katrin Fischer  ---
Thx, Jonathan :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610

--- Comment #3 from Katrin Fischer  ---
[ and } correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Nicolas Giraud  changed:

   What|Removed |Added

 Attachment #138069|0   |1
is obsolete||

--- Comment #8 from Nicolas Giraud  ---
Created attachment 150697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150697=edit
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

Test that the button looks and behaves as expected after submitting a
search.

Signed-off-by: nicolas 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Nicolas Giraud  changed:

   What|Removed |Added

 Attachment #137596|0   |1
is obsolete||

--- Comment #7 from Nicolas Giraud  ---
Created attachment 150696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150696=edit
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind 
Signed-off-by: nicolas 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33682] New: Logs don't give enough information

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33682

Bug ID: 33682
   Summary: Logs don't give enough information
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I'm not sure what component this should be part of.  Looking at the cataloging
logs, it records when a cataloging record is changed, and what the record looks
like at that moment.  But it does not indicate what part was changed, and what
it was before the change.  This would be VERY HELPFUL. If all I want to know is
when the record took on its current form, then the log is useful.   If you are
not purging old log records on a regular basis, then there is a chance you
might have an older record showing the last change.  Even if that were the
case, you would have to compare it bit by bit to find out what changed.

Please consider noting what parts are changed, and their previous state in the
logs.  This would be incredibly helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300

--- Comment #17 from Fridolin Somers  ---
Please backport this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676

--- Comment #1 from Katrin Fischer  ---
I totally agree about recognizing documentation writers. Not sure how hard it
would be to automate, happy with both options.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594

--- Comment #9 from Katrin Fischer  ---
(In reply to Janusz Kaczmarek from comment #8)
> Nick, thank you for your contribution.  Changing "sort: ~" into "sort: 1"
> makes the mappings.yaml to be more explicit and therefor less mysterious.  
> 
> But the patch does not change the way Koha with ES sorts titles, so it does
> not fix the problem.  I think, everybody would expect that when choosing
> sort order by title (both in staff and OPAC interface) the sorting will by
> done according to the main title, i.e. 245 in MARC 21 and 200 in UNIMARC. 
> 
> So, IMHO, in searchfield 'title' only 245 (for MARC 21) and 200 (for
> UNIMARC) should have 'sort: 1', and the rest of tags indexed with title --
> 'sort: 0'.
> 
> I would appreciate your feedback.

I'd agree with that expectation. The other titles don't even all show, so it
can get quite confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673

--- Comment #2 from David Nind  ---
This is the first time I've done a database update - hopefully I got it right!

Also, I'm not sure anyone will agree with me about changing this - comments
welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673

--- Comment #1 from David Nind  ---
Created attachment 150695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150695=edit
Bug 33673: Change "global system preferences" to "system preferences"

The Koha Community normally refers to "global system preferences"
as just "system preferences".

This updates the staff interface and other occurences to refelect
this, including:
- Administration > Global system preferences and the description
- Patrons > [a patron] > More > Set permissions > Manage Koha
  system settings > Manage global system preferences
  (manage_sysprefs)
- The installer files and the database (permissions table)

Test plan:
1. Note that in the staff interface "Global system preferences"
   is dispalyed in two places:
   1.1 Administration: Go to Administration. There is a section
   called "Global system preferences" with a description
   and a search box.
   1.2 User permissions: View the details for a patron > More >
   Set permissions > expand 'Manage Koha system settings' >
   scroll down to 'Manage global system preferences
   (manage_sysprefs)'
2. Apply the patch.
3. Update the database.
4. Revisit the pages in step 1 - these should now show as
   "System prefereneces" or "system preferences" as appropriate.
5. Sign off!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673

David Nind  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594

Janusz Kaczmarek  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Janusz Kaczmarek  ---
Nick, thank you for your contribution.  Changing "sort: ~" into "sort: 1" makes
the mappings.yaml to be more explicit and therefor less mysterious.  

But the patch does not change the way Koha with ES sorts titles, so it does not
fix the problem.  I think, everybody would expect that when choosing sort order
by title (both in staff and OPAC interface) the sorting will by done according
to the main title, i.e. 245 in MARC 21 and 200 in UNIMARC. 

So, IMHO, in searchfield 'title' only 245 (for MARC 21) and 200 (for UNIMARC)
should have 'sort: 1', and the rest of tags indexed with title -- 'sort: 0'.

I would appreciate your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959

Hinemoea Viault  changed:

   What|Removed |Added

 Attachment #149700|0   |1
is obsolete||

--- Comment #3 from Hinemoea Viault  ---
Created attachment 150694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150694=edit
Bug 32959: Don't store results of autobarcode in item editor templates

Test Plan:
1) Enable autobarcode
2) Create a new item template, leave the barcode field blank
3) Apply that item template
4) Note the template prefills the barcode field
5) Delete that item template
6) Apply this patch
7) Restart all the things!
8) Repeat steps 2-4
9) Note the barcode field remains empty!

Signed-off-by: Phil Ringnalda 
Signed-off-by: Hinemoea Viault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #150623|0   |1
is obsolete||

--- Comment #31 from Lucas Gass  ---
Created attachment 150693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150693=edit
Bug 16122: Add maintenance script to update items.localuse from stats

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507

--- Comment #6 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)

> I am wondering how this can work with the digest option.

There's a loop to split based on borrowers. We push all the issues from the
first borrower to chunk 0, when we complete one borrower we push the next on to
the next chunk, then the next borrower to next chunk

When we have pushed to as many chunks as we need (as many loops) we start
again.

So a single borrower, no matter how many checkouts, will always be processed by
a single fork. It means the chunks won't be necessarily the same size, but they
will work with digest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507

Nick Clemens  changed:

   What|Removed |Added

 Attachment #132056|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 150692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150692=edit
Bug 29507: Speed up auto renew cronjob via parallel processing

The cron can take a very long time to run on systems with many issues.
For example, a partner with ~250k auto_renew issues is taking about 9 hours to
run.

If we run that same number of holds in 5 parallel chunks
( splitting the number of issues as evenly as possible ), it could take under 2
hours.

Test Plan:
1) Generate a number of issues marked for auto_renew
2) Run the automatic_renewals.pl, use the `time` utility to track how much time
it took to run
3) Set parallel_loops to 10 in auto_renew_cronjob section of config in
koha-conf
4) Repeat step 2, note the improvement in speed
5) Experiment with other values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

--- Comment #22 from ddem...@oslri.net ---
(In reply to Katrin Fischer from comment #21)
> I think the patron category is not ideal, but maybe the web based self check
> could get its own sessions as well, while we are at it?

I would support that too. Basically a way to force an auto-logoff for staff but
still be able to keep our self-check machines logged in for the full day.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731

Nick Clemens  changed:

   What|Removed |Added

 Attachment #145752|0   |1
is obsolete||
 Attachment #145753|0   |1
is obsolete||
 Attachment #148947|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 150691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150691=edit
Bug 32731: Move cataloging tools to an include and show on tools home

This patch moves the cataloging tools to an include, which is then added
with a toggle to the tools homepage. This allows for the content to be on both
pages,
and can easily be hidden or shown by default. It ensures we don't have to
maintain the
same links in two places

To test:
1 - Apply patch
2 - Ensure cataloging home page looks the same
3 - Ensure you can view/hide the cataloging tools on the tools page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

--- Comment #21 from Katrin Fischer  ---
I think the patron category is not ideal, but maybe the web based self check
could get its own sessions as well, while we are at it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #10 from Nick Clemens  ---
Created attachment 150690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150690=edit
Bug 32478: (follow-up) Tidy code

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #9 from Nick Clemens  ---
Created attachment 150689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150689=edit
Bug 32478: (follow-up) UpdateItemLocationOnCheckin no longer needs flattening

This patch removes a line flattening the arrays generated by get_yaml_pref_hash
as it is no longer necessary

Conditionals are adjusted to avoid warnings in tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #8 from Nick Clemens  ---
Created attachment 150688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150688=edit
Bug 32478: Fix handling of undef values in ItemsDeniedRenewal

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

Nick Clemens  changed:

   What|Removed |Added

 Attachment #144633|0   |1
is obsolete||
 Attachment #150685|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 150687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150687=edit
Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache

get_yaml_pref_hash also allows invalid YAML and only parses a limited
subset so remove this method to avoid future issues.

To test):

Since tests already exists for C4::Context->yaml_preference and this
is a trivial change, do we really need a test plan for this?

Sponsored-by: Gothenburg University Library
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33653] Search for late orders can show received order lines

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653

Hinemoea Viault  changed:

   What|Removed |Added

 Attachment #150669|0   |1
is obsolete||

--- Comment #7 from Hinemoea Viault  ---
Created attachment 150686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150686=edit
Bug 33653: Never consider received orders as late

We should not list received orders on the late orders page.

Test plan:
* Create a basket
* Create a normal order (not from a subscription, no standing order)
* Leave estimated delivery date empty
* Close the basket
* Create a new invoice and receive the order line
* Go to acq > late orders
* Verify the order is not in the list
* Set filter for 'To' date into the future, i.e. 01/01/2025
=> Without this patch the order shows up
=> With this patch applied the received order does not show up

Signed-off-by: Michaela Sieber 
Signed-off-by: Katrin Fischer 
Signed-off-by: Hinemoea Viault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

--- Comment #48 from Patrick Robitaille  ---
Hi,

It seems there is a problem with the default values ​​in the acquisition module
as well. When adding a record to a basket with the "from a new (empty) record"
option, the default values ​​are not added to the record according to the
default grid.

Was there work for this problem? currently the ApplyFrameworkDefaults system
preference does not fix the problem for the acquisition module.

Thanks, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

ddem...@oslri.net changed:

   What|Removed |Added

 CC||ddem...@oslri.net

--- Comment #20 from ddem...@oslri.net ---
I'm going to echo other's sentiments. Ideally Patron Category would be the
defining attribute for different time out requirements. 

We would set our self-check patron category for a longer timeout to ensure even
during inactive periods the machine stays logged in. Library Staff users would
have a short inactivity period defined to auto-log-out if they're not using the
system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #6 from David Gustafsson  ---
(In reply to Nick Clemens from comment #4)
> (In reply to Nick Clemens from comment #3)
> > (In reply to Jonathan Druart from comment #2)
> > > I don't think the removal here is correct, the method does more than
> > > C4::Context->yaml_preference
> > > 
> > > Nick maybe?
> > 
> > perl -e 'use Koha::Config::SysPrefs; use C4::Context; my $sp =
> > Koha::Config::SysPrefs->find("ItemsDeniedRenewal")->get_yaml_pref_hash; warn
> > Data::Dumper::Dumper($sp); warn Data::Dumper::Dumper(
> > C4::Context->yaml_preference("ItemsDeniedRenewal"));'
> > 
> > It doesn't convert from 'NULL' to undef - the expectation is that we can
> > pass the return value into a DBIC search directly
> 
> Perhaps we removed the wrong copy here:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154
> 
> One was an object, the other took a pref name, so would have used cache

Yes, it would have used cache, but still a good thing to remove it as
C4::Context->yaml_preference exists using a proper yaml-parser (and utilized
cache). Thanks for pointing out the nuance of the special handling of NULL
values. null (lowercase) is valid yaml for null values (converted to undef by
the perl parser). So the problem can be solved by using that instead of NULL.
Provided a patch to fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33669] Adding options to ApplyFrameworkDefaults preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11436] Default values in subfields are not passed on when cloning the field

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11436

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #5 from David Gustafsson  ---
Created attachment 150685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150685=edit
Bug 32478: Fix handling of undef values in ItemsDeniedRenewal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681

--- Comment #3 from Katrin Fischer  ---
Do we need to keep the option to configure in the file for backwards
compatibility? I am not sure if it would be possible to migrate.

I like the idea of a configuration page. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #2 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #1)
> I think one issue here could be all the extra configuration options we have
> tied to the SIP logins. 
> 
> Maybe we'd need some kind of default entry in the .xml to make sure we can
> still connect the config to the user?

I'm certain we can build a UI editor that can handle all those SIP options. I
think the two blocks of the xml file that should be moved to the database/ui
are the accounts (
https://github.com/Koha-Community/Koha/blob/edbc81199798aa084365a1845188aa24e6ad010b/etc/SIPconfig.xml#L55
) and the institutions (
https://github.com/Koha-Community/Koha/blob/edbc81199798aa084365a1845188aa24e6ad010b/etc/SIPconfig.xml#L105
).

One thing to consider is you can currently set institution codes to
non-branchcodes, but this makes things explode. We should probably start with a
something to codify that SIP institutions *must* be branchcodes now, then it
would be trivial to move that part to the database/UI.

We have another thought that perhaps would should get rid of
accounts/login/institution as the SIP patron's branchcode is functionally
equivalent. That's not necessary but could be a good followup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

--- Comment #20 from Katrin Fischer  ---
Created attachment 150684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150684=edit
Bug 33262: Add new field to REST API route for orders

Without this patch the API driven list of pending orders
on the order receive page was broken.

With the patch, all should be well now.

prove -v t/db_dependent/api/v1/acquisitions_orders.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150664|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 150683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150683=edit
Bug 33262: Unit tests

prove t/db_dependent/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150663|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 150682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150682=edit
Bug 33262: Store the biblionumber of a deleted record in the order line

When a bibliographic record is deleted and linked to an order
in the acquisition module, the biblionumber in the order line is
currently deleted as well. This makes it impossible to tell what
was ordered in the first place. This is a big issue for libraries
that need to be able to track how money was spent over long periods
of time.

With this patch the biblionumber of the deleted record will be moved
to a new column deleted_biblionumber in the order line, keeping the FK
on biblionumber.

To test:
* Apply patch, run dataase update
* Create a order/basket in the acquisitions module
* Order several things, you can use existing records from the sample data
* Make sure you order one of the records at least twice
* Take a look at the aqorders table in your database, using a report:

  SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders;

* From the catalog, delete the items on the records and then the records

  Note: There is a warning about attached orders warning about consequences
  for acquisitions. I have chosen to keep it at this point in time, as
  there are still visible side effects of deleting the record, like bug 10758.

* Re-run the report and compare results to the first run. deleted_biblionumber
  should now be filled with the biblionumber of the deleted record.
  biblionumber should be NULL/empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150662|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 150681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150681=edit
Bug 33262: [DO NOT PUSH) Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150661|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 150680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150680=edit
Bug 33262: Add deleted_biblionumber column to aqorders table

This adds a new column deleted_biblionumber to the aqorders table.
This will allow us to store the biblionumber of a deleted record,
so we will still be able to tell what has been ordered once the
record is deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

nicolas.gir...@inlibro.com changed:

   What|Removed |Added

 Attachment #150644|0   |1
is obsolete||

--- Comment #15 from nicolas.gir...@inlibro.com ---
Created attachment 150679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150679=edit
Bug 19249: Fix date inputs on patron quick add form

This patch create a "apply_flatpickr" JS function to make the code
reusable from the template, where we loop over the date inputs to
reinstantiate flatpickr.

Signed-off-by: Sally 
Signed-off-by: Nick Clemens 
Signed-off-by: Nicolas Giraud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #80 from Kyle M Hall  ---
Created attachment 150678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150678=edit
Bug 31735: Fix array that should be passed as reference

Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #79 from Kyle M Hall  ---
Created attachment 150677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150677=edit
Bug 31735: Optimize OPAC checkouts view

Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #150611|0   |1
is obsolete||
 Attachment #150612|0   |1
is obsolete||
 Attachment #150613|0   |1
is obsolete||

--- Comment #78 from Kyle M Hall  ---
Created attachment 150676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150676=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Circulation/transferbook.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library
Signed-off-by: Nick Clemens 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32333] IdRef system preference revamping

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

Frédéric Demians  changed:

   What|Removed |Added

 Attachment #147762|0   |1
is obsolete||

--- Comment #13 from Frédéric Demians  ---
Created attachment 150675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150675=edit
Bug 32333: IdRef system preference revamping

IdRef system preference enables a Unimarc-only functionality. Authors
fields contain in $3 subfield a PPN, an unique identifier in IdRef a
French national authority file, similar to VIAF.

KohaLa, the Koha French users association, has designed a revamped
implementation of IdRef in Koha. The goal is to improve the visual and
to add a functionality.

- Visually — The author publications list is currently displayed in
  an old fashion dialog box. It uses greybox library, which is
  deprecated. See bug 8290. With this patch, the list is displayed in a
  distinct tab of holdings block.

- Functionality — The title in the list are searched in Koha local
  catalog. So it's possible to mark titles locally available and link
  to them. PPN are searched directly in Elasticsearch for efficiency.
  Koha IdRef users are academic libraries or higher education school. So
  Zebra support is not required for them.

NOTE: After pushing this patch, greybox library could be removed
  completely for OPAC :
  /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/

TO TEST :

- On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef.
- Use default OPAC XSL.
- On opac-detail.pl page, you can see a logo IdRef next to authors
  having a $3 (ppn) subfield. Click on the logo.
- Confirm that a tab is added to holdings. It contains the author
  publications found in the Sudoc.
- A Sudoc logo is displayed in front of each title. Clicking the icon
  open the title in Sudoc web site.
- A Koha logo is displayed in from of each title available locally.
  Clicking the logo open the title in Koha OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32333] IdRef system preference revamping

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

Frédéric Demians  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911

--- Comment #14 from Katrin Fischer  ---
Created attachment 150674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150674=edit
Bug 32911: (follow-up) Move pref from Notifications to Features section

The new preference appeared under Notifications, but is better
suited for the Features section on the ILL tab in system
preferences.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911

--- Comment #13 from Katrin Fischer  ---
Created attachment 150673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150673=edit
Bug 32911: Database update

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #147417|0   |1
is obsolete||
 Attachment #147418|0   |1
is obsolete||
 Attachment #147419|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 150672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150672=edit
Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a
system preference

Preparation:
1) apply patch
2) run reset_all
3) enable ILLModule sys preference
4) install a backend (e.g. FreeForm)
5) go into system preferences and confirm that ILLPartnerCode exists and is the
default inter-library loan (IL)

Test plan:
1) create an ILL request
2) ensure the patron of category 'IL' has a primary e-mail configured
3) click on "place request with partners"
4) verify that the patron(s) of said category are on the partners list

Upgrade test:
1) Remove the system preference from the database, run query:
delete from systempreferences where variable="ILLPartnerCode";
2) Check or edit the value or partner_code in koha-conf.xml and run
atomicupdate:
installer/data/mysql/updatedatabase.pl
3) Confirm the value in koha-conf.xml has been successfully migrated into the
system preference, run query:
select * from systempreferences where variable="ILLPartnerCode";

Optional tests:
- Set a patron category in the sys pref and then delete said patron category
(needs to not have patrons in it)
- Check the about page -> System information and confirm the warning message is
correct

- Set the sys pref to the empty option
- Check the about page -> System information and confirm the warning message is
correct

- Set the sys pref to a category that has no patrons of its type (ktd examples:
Board, or Library)
- Check the about page -> System information and confirm the warning message is
correct

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #26 from Phil Ringnalda  ---
Why use insert_grouped_field for move rather than insert_fields_ordered?

My vague memory of looking at it in 2020 says that it's because just using
$record->insert_fields_ordered( @new_fields ); winds up putting them in
reversed, so that if you say to move all 502 to 520 you go from

502 $aFirst
502 $aSecond

to

520 $aSecond
520 $aFirst

but if that was all it was, why not just reverse @new_fields before calling
insert_fields_ordered?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453

--- Comment #17 from Agustín Moyano  ---
Created attachment 150671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150671=edit
Bug 29453: (follow-up) Add tests and fix minimum amount in credit.yaml
definition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #147644|0   |1
is obsolete||

--- Comment #16 from Agustín Moyano  ---
Created attachment 150670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150670=edit
Bug 29453: Add endpoints for fetching patron credits & debits

This patch adds two new API endpoints for fetching a patrons credits and
a patrons debits.

Signed-off-by: Lucas Gass 

Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

--- Comment #13 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #12)
> Not sure whats going on, but clicking these Print buttons or options does
> actually do totally nothing..

All working for me, ensure you hard refresh the browser so that the JS reloads
- I saw your issue before I did that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681

--- Comment #1 from Katrin Fischer  ---
I think one issue here could be all the extra configuration options we have
tied to the SIP logins. 

Maybe we'd need some kind of default entry in the .xml to make sure we can
still connect the config to the user?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911

--- Comment #11 from Katrin Fischer  ---
I'll try to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33653] Search for late orders can show received order lines

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #150624|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 150669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150669=edit
Bug 33653: Never consider received orders as late

We should not list received orders on the late orders page.

Test plan:
* Create a basket
* Create a normal order (not from a subscription, no standing order)
* Leave estimated delivery date empty
* Close the basket
* Create a new invoice and receive the order line
* Go to acq > late orders
* Verify the order is not in the list
* Set filter for 'To' date into the future, i.e. 01/01/2025
=> Without this patch the order shows up
=> With this patch applied the received order does not show up

Signed-off-by: Michaela Sieber 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33653] Search for late orders can show received order lines

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590

Katrin Fischer  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #17 from Katrin Fischer  ---
*** Bug 33679 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33679] Buttons Select all and Clear all do not work on serial collection

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33679

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Hi Marcel, I had already reported that one, the fix is on bug 33590.

*** This bug has been marked as a duplicate of bug 33590 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262

--- Comment #15 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #14)
> "Deleted bibliographic record, can't find title" should not we adjust that
> then?

This would be the next step, but I wanted to keep things small and manageable.
this is taking care of the data only, but there are already bug 10758 and bug
10869 filed and linked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #12 from Marcel de Rooy  ---
Not sure whats going on, but clicking these Print buttons or options does
actually do totally nothing..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >