[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #18 from David Cook --- Real world library confirmed that this change resolves the timeout problem when using their corporate HTTP forward proxy which has a 60 second timeout threshold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34016] Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #2 from Aleisha Amohia --- Created attachment 152372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152372=edit Bug 34016: [WIP] Working on fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34016] Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #1 from Aleisha Amohia --- Created attachment 152371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152371=edit Bug 34016: Tests for fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > Regarding Zebra, I don't think we can get full feature parity here. However, > we could potentially add a Title-punc_removed index and update > ./etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl to strip punctuation for it, > and then add that into C4::Search::_build_weighted_query() (or elsewhere). Alternatively, we could store a punctuation removed version into the same index. That way you end up indexing both "Carrie's war" and "Carries War". But then do you do that for all indexes? That would double the size of your index... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #75 from David Cook ---
(In reply to Janusz Kaczmarek from comment #74)
> ... I mean the original apostrophe filter:
> https://www.elastic.co/guide/en/elasticsearch/reference/8.7/analysis-
> apostrophe-tokenfilter.html
According to the documentation, that was originally created for the Turkish
language.
In English, it would work well with apostrophe S ('s) but not so well for
contractions like "don't" or "can't".
It would also break languages like Ukrainian:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153#c14
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #17 from David Cook --- (In reply to David Cook from comment #16) > So far I've only tested this in koha-testing-docker (using a ProxyPass to > inventory.pl from a custom endpoint - needed to update inventory.tt to point > to that custom endpoint). > > It works as expected, but I typically run Koha behind yet another reverse > proxy, so I'm curious how that will go. I suspect that I'll need to disable > compression on that proxy for inventory.pl. > > (Note that compression isn't enabled for CSV exports from Koha by default > anyway, so it's not a huge drama in terms of the status quo...) I've tried this on a more real-world setup, and it works well even when sitting behind another Apache reverse proxy that has compression enabled. It doesn't seem to buffer. It just starts streaming the data. (It does need the compression disabled for inventory.pl on the Apache sitting in front of Starman though.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34016] Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34016] New: Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Bug ID: 34016 Summary: Enable fulfillment of recalled items through SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Currently items that have been recalled are not fulfilled properly when they're checked out using SIP2 (i..e a self-check machine). The item is successfully checked out but the recall request is not filled and closed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz, ||lu...@bywatersolutions.com --- Comment #39 from Aleisha Amohia --- Thanks Pedro! Can this please be backported to 22.05? Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #16 from David Cook --- So far I've only tested this in koha-testing-docker (using a ProxyPass to inventory.pl from a custom endpoint - needed to update inventory.tt to point to that custom endpoint). It works as expected, but I typically run Koha behind yet another reverse proxy, so I'm curious how that will go. I suspect that I'll need to disable compression on that proxy for inventory.pl. (Note that compression isn't enabled for CSV exports from Koha by default anyway, so it's not a huge drama in terms of the status quo...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #15 from David Cook --- Created attachment 152370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152370=edit Bug 31744: Run inventory.pl as CGI with keep alives to prevent timeouts This patches causes inventory.pl to run as CGI instead of PSGI, since Plack::App::CGIBin buffers the whole response before sending any data to the Apache reverse proxy. This patch also causes inventory.pl to quickly output HTTP headers, and print NULL characters roughly every 5 seconds until the HTML or CSV data is ready to be printed. This prevents HTTP forward and reverse proxies from timing out waiting for data from the inventory script, which can be very slow. In the future, we will want to move inventory.pl to use background jobs, but this change makes inventory.pl usable for staff users stuck behind HTTP forward proxies with short timeouts. Test plan: 0. Apply patch 1. cp debian/templates/apache-shared-intranet-plack.conf /etc/koha/apache-shared-intranet-plack.conf 2. cp debian/templates/apache-shared.conf /etc/koha/apache-shared.conf 3. service apache2 restart 4. Go to create a SQL report from SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL 5. Save a report with the following SQL: SELECT barcode FROM items where barcode <> ''; 6. Run the report 7. Download as CSV 8. Edit the CSV and remove the "barcode" heading 9. Open F12 dev tools in browser and open the "Network" tab 10. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 11. Note that mainpage.pl has a "Content-Encoding: gzip" header 12. Go to http://localhost:8081/cgi-bin/koha/tools/inventory.pl 13. Note that inventory.pl does not have a "Content-Encoding: gzip" header, while the .js and .css files do have this header. 14. Click "Choose file" and choose your barcode CSV file 15. Uncheck "Compare barcodes list to results" 16. Check "Export to CSV file" 17. Click "Submit" 18. Note that the download initially only increases in size by 1B at a time 19. Open inventory.csv with a text editor that can show symbols like Notepad++ 20. Note approximately 7 or 8 NULL characters at start of file 21. Note that CSV loads without problems in Excel or LibreOffice (ie the NULL characters are ignored) 22. Return to your browser and uncheck "Export to CSV file" 23. Click "Submit" 24. On the "Response" tab, note approximately 7 or 8 NULL characters at start of response -- 25. For bonus points, set up a reverse proxy in front of inventory.pl with a proxy timeout of 10 seconds and run an inventory job. Note that the proxy times out without the patch, and does *not* time out with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #14 from David Cook --- In the end, the trick was to override AddOutputFilterByType just for inventory.pl. So overall: 1. Don't proxy inventory.pl to Starman/Plack 2. Override AddOutputFilterByType so the DEFLATE compression output filter isn't added 3. At the start of the inventory.pl processing output the HTTP headers and then roughly every 5 seconds print out a NULL character to keep alive the HTTP connection until the HTML template/CSV response is ready to be printed out. -- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- (In reply to Aleisha Amohia from comment #6) > Hi David, > > Sorry I didn't realise this was already Signed off, I've just amended the > second patch - this was the only change from the patch you had already > tested. > .. > Thanks > Aleisha No problem! I have retested (I think I tested correctly for the second patch, so have signed off.) David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Attachment #152365|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 152369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152369=edit Bug 33992: Only consider the date when auto-expiring problematic recalls This patch carries this fix into the misc/cronjobs/recalls/expire_recalls.pl cronjob so that recalls are automatically expired when they have been waiting a problematic number of days, not considering hours, as expected. To test, follow the test plan from the first patch. This will set you up with a waiting problematic recall. Run the cronjob manually perl misc/cronjobs/recalls/expire_recalls.pl Refresh your 'Recalls awaiting pickup' page. Your problematic recall should be gone/expired. Expiration dates will apply when expiring any 'unfulfilled' recall i.e. newly requested, overdue to be returned, and awaiting pickup. Sponsored-by: Auckland University of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Attachment #152363|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 152368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152368=edit Bug 33992: Only consider the date when labelling a waiting recall as problematic This patches makes sure Koha ignores the hours/minutes/seconds when comparing a recall waiting date to decide if it has been waiting too long for pickup. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Log into the database and get the time for now sudo koha-mysql INSTANCE select now(); 11. Change the waiting_date in the database for this recall to yesterday so we would expect to see it under the 'Recalls waiting over 1 days' tab. Base the hours on the now() timestamp from the step before, add a few hours to this. For example, if the above SQl query returns "2023-06-13 10:54:21", change waiting_date to be slightly less than 1 day/24 hours before this now() timestamp, but still what we would consider 'yesterday' select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-12 14:54:21" where recall_id = X; 12. Refresh the Circulation -> Recalls awaiting pickup page. The recall will not show up under the 'Recalls waiting over 1 days' tab, even though we expect it to. 13. Apply the patch, restart services, refresh the page 14. Confirm the recall now shows under the 'Recalls waiting over 1 days' tab as expected. Sponsored-by: Auckland University of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33879] Check_cookie_auth overwrites interface set by get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes an issue with release notes||recording the interface for ||the log viewer where ||installations run the OPAC ||and staff interface on the ||same domain name. Before ||this patch, if a user ||logged into the OPAC and ||then went to the staff ||interface and performed a ||logable action (such as a ||checkout), the interface in ||the log was incorrectly ||recorded as the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33879] Check_cookie_auth overwrites interface set by get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879 David Nind changed: What|Removed |Added Attachment #152329|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 152367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152367=edit Bug 33879: Do no longer overwrite interface in check_cookie_auth This will only have effect on installations running OPAC and staff on the same domain name. In that case an OPAC cookie still allows you to access intranet, and v.v. Test plan: Repeat the following steps WITHOUT this patch and WITH it. Login via OPAC. Go to staff. Perform an action that logs the interface in e.g. the statistics table, like a checkout. Inspect interface in the corresponding table. Observe difference that this patch makes. With this patch: Run t/db_dependent/Auth.t. Should pass again. Signed-off-by: Marcel de Rooy Signed-off-by: Björn Nylén Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33879] Check_cookie_auth overwrites interface set by get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879 David Nind changed: What|Removed |Added Attachment #152328|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 152366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152366=edit Bug 33879: Add unit test to show problem Test plan: Run t/db_dependent/Auth.t without second patch. Should fail: # got: 'opac' # expected: 'intranet' Signed-off-by: Marcel de Rooy Signed-off-by: Björn Nylén Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 --- Comment #13 from David Cook --- So it seems to me that you can provide "no-gzip" and it won't compress the response but it still buffers the response: [Wed Jun 14 23:32:04.176918 2023] [filter:trace2] [pid 15344] mod_filter.c(185): [client 172.28.0.1:44628] Content-Type condition for 'deflate' matched, referer: http://localhost:8081/cgi-bin/koha/tools/inventory.pl [Wed Jun 14 23:32:44.751593 2023] [deflate:trace1] [pid 15344] mod_deflate.c(624): [client 172.28.0.1:44628] Not compressing (no-gzip), referer: http://localhost:8081/cgi-bin/koha/tools/inventory.pl So I reckon we need to not add the DEFLATE filter at all for inventory.pl. Now I tried this yesterday but for some reason it also turned off the compression for the Javascript, so I'm going to have another crack at that today... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26170] Create "system" patrons that cannot be (easily) deleted via the web UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 --- Comment #13 from David Cook --- (In reply to Magnus Enger from comment #12) > As a start, I'd be happy if we just made it harder to delete some patrons. > We are seeing some cases where users related to things like SIP2 and SCO get > deleted, and it would be a big gain if we could just make that happen less > often. So maybe we could start there and do the other protections later? Yeah I'd be happy with that too. I've had some cases where they've changed the passwords for those users, but the more common scenario has been deleted ones. > But even "make it hard to delete" could mean different things: > - Just a popup saying "are you really sure you want to delete this patron" > - Make it impossible to delete protected patrons, but make it easy to remove > the "protected" flag (so an extra step to delete) > - Make it really hard to remove the "protected" flag and delete the patron Yeah I was thinking all those could make some sense hehe. > And we need to think about what happens when someone tries to delete a > protected patron. A "direct" delete on one patron is probably not too hard, > but what should happen when a protected patron is included in a batch > delete? Should the batch delete stop, or should we just report in some way > that the protected patron was not deleted? Or should we just ignore it? I've been wondering about that as well. I imagine the batch delete must already have some capacity for showing errors but I haven't checked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992
Aleisha Amohia changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment #6 from Aleisha Amohia ---
Hi David,
Sorry I didn't realise this was already Signed off, I've just amended the
second patch - this was the only change from the patch you had already tested.
--- a/misc/cronjobs/recalls/expire_recalls.pl
+++ b/misc/cronjobs/recalls/expire_recalls.pl
@@ -42,7 +42,7 @@ cronlogaction({ info => $command_line_options });
my $recalls = Koha::Recalls->search({ completed => 0 });
my $today = dt_from_string()->truncate( to => 'day' );
while( my $recall = $recalls->next ) {
-if ( ( $recall->requested or $recall->overdue ) and
$recall->expiration_date ) {
+if ( ( $recall->requested or $recall->overdue or $recall->waiting ) and
$recall->expiration_date ) {
Thanks
Aleisha
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #5 from David Cook --- I like where this is going though. It is annoying when I have to go into the database to fix broken records... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 Aleisha Amohia changed: What|Removed |Added Attachment #152364|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 152365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152365=edit Bug 33992: Only consider the date when auto-expiring problematic recalls This patch carries this fix into the misc/cronjobs/recalls/expire_recalls.pl cronjob so that recalls are automatically expired when they have been waiting a problematic number of days, not considering hours, as expected. To test, follow the test plan from the first patch. This will set you up with a waiting problematic recall. Run the cronjob manually perl misc/cronjobs/recalls/expire_recalls.pl Refresh your 'Recalls awaiting pickup' page. Your problematic recall should be gone/expired. Expiration dates will apply when expiring any 'unfulfilled' recall i.e. newly requested, overdue to be returned, and awaiting pickup. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014
--- Comment #4 from David Cook ---
(In reply to Nick Clemens from comment #2)
> This largely works - the logs don't capture the error though.
You could just add a warn when catching the error?
> Should we have a:
> $biblio->metadata->record({ attempt_cleaning => 1 });
>
> or something?
Not sure I follow, although I'm opposed to things like "maybe_" and "attempt_"
as they are harder to test and imply that the function being performed can have
different behaviours besides just doing that one function.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Attachment #152289|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 152364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152364=edit Bug 33992: Only consider the date when auto-expiring problematic recalls This patch carries this fix into the misc/cronjobs/recalls/expire_recalls.pl cronjob so that recalls are automatically expired when they have been waiting a problematic number of days, not considering hours, as expected. To test, follow the test plan from the first patch. This will set you up with a waiting problematic recall. Run the cronjob manually perl misc/cronjobs/recalls/expire_recalls.pl Refresh your 'Recalls awaiting pickup' page. Your problematic recall should be gone/expired. Sponsored-by: Auckland University of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Attachment #152288|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 152363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152363=edit Bug 33992: Only consider the date when labelling a waiting recall as problematic This patches makes sure Koha ignores the hours/minutes/seconds when comparing a recall waiting date to decide if it has been waiting too long for pickup. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Log into the database and get the time for now sudo koha-mysql INSTANCE select now(); 11. Change the waiting_date in the database for this recall to yesterday so we would expect to see it under the 'Recalls waiting over 1 days' tab. Base the hours on the now() timestamp from the step before, add a few hours to this. For example, if the above SQl query returns "2023-06-13 10:54:21", change waiting_date to be slightly less than 1 day/24 hours before this now() timestamp, but still what we would consider 'yesterday' select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-12 14:54:21" where recall_id = X; 12. Refresh the Circulation -> Recalls awaiting pickup page. The recall will not show up under the 'Recalls waiting over 1 days' tab, even though we expect it to. 13. Apply the patch, restart services, refresh the page 14. Confirm the recall now shows under the 'Recalls waiting over 1 days' tab as expected. Sponsored-by: Auckland University of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #3 from Phil Ringnalda --- Works unless you EnableAdvancedCatalogingEditor, which just hangs at "Loading, please wait..." without having caught the 500 from /cgi-bin/koha/svc/bib/369 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 David Nind changed: What|Removed |Added Attachment #152361|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 152362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152362=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- The only thing I noticed was that the buttons (such as 'Revert waiting status' and 'Expire recall') were previously orange, but are now standard buttons with a white background. Also, I didn't refresh the bug page, and note that was already signed off. I also managed to add a bugzilla link, which I'll fix up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 David Nind changed: What|Removed |Added Attachment #152358|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 152361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152361=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau https://bugs.koha-community.org/show_bug.cgi?id=34010 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32726] Authority search result display and relator terms in 22.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726
Phil Ringnalda changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||p...@chetcolibrary.org
--- Comment #7 from Phil Ringnalda ---
No, with more context authorize.heading doesn't contain $e, because in
$subfields_to_report =
$handler->get_auth_heading_subfields_to_report($tag);
if ($subfields_to_report) {
push @authorized, {
heading => $field->as_string($subfields_to_report),
hemain => ( $field->subfield( substr($subfields_to_report,
0, 1) ) // undef ),
field => $tag,
};
} else {
push @authorized, {
heading => $field->as_string(),
hemain => ( $field->subfield( 'a' ) // undef ),
field => $tag,
};
}
$subfields_to_report will be true for 100/110/111 and will not include the
relator subfield (which is $e for 100/110, but $j for 111), because it is not
what people tend to think it is. In an authority record, the relator describes
the relationship between the name and the work in a name-title heading, like
"$aBlum, Leon,$d1872-1950,$edefendant$tLeon Blum devant la Cour supreme,
Riom.$lHebrew" as explained in https://www.loc.gov/marc/authority/adx00.html
Having a 100/110 with a $e but no $t or a 111 with a $j but no $t is wrong.
That doesn't necessarily mean that Koha shouldn't show it (particularly because
it autocreated authority records that way for years), but not with this patch:
blindly adding $e to every heading whether it's defined as relator, defined as
something other than relator (it's a repeatable "subordinate unit" subfield for
meeting names), or undefined, is not the right solution.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33990] Fix the 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||33990, 33992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 [Bug 33990] Fix the 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 [Bug 33992] Only consider the date when labelling a waiting recall as problematic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34015] New: Terminology: Relative issues should be Relative's checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Bug ID: 34015 Summary: Terminology: Relative issues should be Relative's checkouts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I found this string while translating. It seems to be a string for screen readers only. But I think it should still follow terminology. The string is in opac-user.tt, around line 670. Relative issues It's for the tab that shows Relatives' checkouts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #12 from Michaela Sieber --- (In reply to Barbara Johnson from comment #11) > Being able to limit search results by publication date would help our > patrons as well as staff who are assisting them. This is really needed. +1 We agree! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34003] Add messaging preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34003 --- Comment #1 from Christopher Brannon --- Yes! +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34003] Add messaging preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34003 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #24 from Christopher Brannon --- (In reply to Kristi from comment #23) > A digest option for holds ready for pickup across all methods, particularly > phone would be greatly appreciated by our patrons at Cuyahoga County Public > Library. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014
--- Comment #2 from Nick Clemens ---
This largely works - the logs don't capture the error though.
Should we have a:
$biblio->metadata->record({ attempt_cleaning => 1 });
or something?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens changed: What|Removed |Added Blocks||34014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 [Bug 34014] There is no way to fix records with broken MARCXML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Nick Clemens changed: What|Removed |Added Blocks||34014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 [Bug 34014] There is no way to fix records with broken MARCXML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||tomasco...@gmail.com Depends on||29697, 23846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #1 from Nick Clemens --- Created attachment 152360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152360=edit Bug 34014: Allow staff to edit degraded records This patch adds an eval to the call for the record form metadata If there is an error we catch it, display it, and attempt to strip bad characters from the record To test: 1 - In koha testing docker attempt to view record 369 in the staff interface 2 - You see a warning about degraded view 3 - Attempt to edit the record 4 - Internal server error 5 - Apply patch, restart all 6 - Reload the editor 7 - Record successfully loads! 8 - You have a warning about encoding issues! 9 - Save the record 10 - No more warning! 11 - Edit again, no more warning! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] New: There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Bug ID: 34014 Summary: There is no way to fix records with broken MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl See bug 29697 and bug 23846 Koha currently catches an exception if the view is degraded in order to allow the staff to know there is a problem with the record. However, if the staff user tries to edit the record, we simply throw the exception and there is no way to recover. In other places we use StripNonXmlCharacters to get past encoding issues. We should do the same in the record editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34011] [DOCS] Add information on the option to place multiple bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34011 Emily Lamancusa changed: What|Removed |Added Status|NEW |Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34011] [DOCS] Add information on the option to place multiple bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34011 Emily Lamancusa changed: What|Removed |Added Documentation||Emily Lamancusa contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/696 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34011] [DOCS] Add information on the option to place multiple bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34011 --- Comment #1 from Emily Lamancusa --- Merge request submitted https://gitlab.com/koha-community/koha-manual/-/merge_requests/696 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau changed: What|Removed |Added Attachment #152350|0 |1 is obsolete|| Attachment #152357|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 152359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152359=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Sam Lau changed: What|Removed |Added Attachment #152351|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152358=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||sama...@gmail.com --- Comment #3 from Sam Lau --- (In reply to Sam Lau from comment #2) > Created attachment 152357 [details] [review] > Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup > > This patch updates the recalls awaiting pickup template so that it uses > the new WRAPPER directive to build tabbed navigation. > > Note: this patch includes indentation changes, so check the diff > accordingly. > > To test you must have UseRecalls enabled. Apply the patch and go to > Circulation -> Recalls awaiting pickup. > > Both the "Recalls waiting" and "Recalls waiting over X days" tabs should > look correct and work correctly. > > Signed-off-by: Sam Lau Oops, attached wrong one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #2 from Sam Lau --- Created attachment 152357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152357=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Sam Lau changed: What|Removed |Added Attachment #152354|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152356=edit Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g --- Comment #23 from Kristi --- A digest option for holds ready for pickup across all methods, particularly phone would be greatly appreciated by our patrons at Cuyahoga County Public Library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau changed: What|Removed |Added Attachment #152352|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 152355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152355=edit Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 --- Comment #1 from Owen Leonard --- Created attachment 152354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152354=edit Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Hammat wele changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 --- Comment #1 from Hammat wele --- Created attachment 152353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152353=edit Bug 33978: Adding authority from automatic linker closes imported record If you import a record, then create an authority record using the automatic linker, it closes the biblio record. The problem occures when a record is edited in a new tab. To recreate: 1. Import the example records 1.1. Download the example records 1.2. Go to Cataloging > Stage records for import 1.3. Choose the downloaded file 1.4. Click Upload file 1.5. Click Stage for import 1.6. Click View batch 1.7. Click Import this batch into the catalog 1.8. Click View detail of the enqueued job 1.9. Click Manage imported batch Correct behaviour: 2. In another tab, search for one of the records (for example, Fafounet) 3. Click Edit > Edit record 4. Go to field 100 5. Click Link authorities automatically --> It should say 100 - No matching authority found. 6. Click the plus sign next to 100 7. Fill out the mandatory fields by clinking in the text fields (000, 003, 005, 008, 040), field 100 should already be filled 8. Click 'Save' --> Authority number is added in 100 and you get to stay in the record for more edits if needed Incorrect behaviour: 9. Go back to the imported batch tab 10. Click Edit next to the second title (the one by Paventi, Eza) 11. Redo steps 4 to 8 --> Record is closedclear :( The behaviour should be the same, stay in the bibliographic record until it is saved. 12. Apply the patch 13. Redo step 9, 10, 4 14. Edit field 100, Type 'Paventi Test 2' 15. Redo step 5 to 8 --> Authority number is added in 100 and you get to stay in the record for more edits if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Hammat wele changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Owen Leonard changed: What|Removed |Added Blocks||34013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 [Bug 34013] Recalls awaiting pickup doesn't show count on each tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] New: Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Bug ID: 34013 Summary: Recalls awaiting pickup doesn't show count on each tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34012 The recalls awaiting pickup page is supposed to show a count on each tab, e.g. Recalls waiting: 10 Recalls waiting over 7 days: 14 The template tries to do it this way: Recalls waiting: [% recalls.count | html %] But it doesn't work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass changed: What|Removed |Added Attachment #152347|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 152352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152352=edit Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 --- Comment #1 from Owen Leonard --- Created attachment 152351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152351=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Owen Leonard changed: What|Removed |Added Blocks||34012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Owen Leonard changed: What|Removed |Added Depends on||34010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 [Bug 34010] Template corrections to recall pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What|Removed |Added Blocks||34012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] New: Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Bug ID: 34012 Summary: Use template wrapper for tabs: Recalls awaiting pickup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the recalls awaiting pickup page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Dave changed: What|Removed |Added CC||ddagh...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #1 from Owen Leonard --- Created attachment 152350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152350=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34011] New: [DOCS] Add information on the option to place multiple bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34011 Bug ID: 34011 Summary: [DOCS] Add information on the option to place multiple bib-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: emily.lamanc...@montgomerycountymd.gov Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org The feature to place multiple bib-level holds for a single patron that was added in bug 14695 doesn't seem to be mentioned in the manual. It would be helpful to have a note about it in Circulation/Holds/Placing holds in the staff interface, and in the page on Circulation and Fines rules, since the "Holds to place (count)" textbox only appears if the circulation rules allow more than 1, but fewer than Unlimited, holds per record for that patron type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33887] Automatic checkin should be able to optionally fill the next hold with the returned item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887 Sam Lau changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33887] Automatic checkin should be able to optionally fill the next hold with the returned item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887 Sam Lau changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sama...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33980] No results on search creates double sets of quotes on breadcrumb search term and page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33980 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33963] Remove C4::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33963 Sam Lau changed: What|Removed |Added Attachment #152208|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 152349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152349=edit Bug 33963: Remove leftovers from previous works Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33963] Remove C4::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33963 Sam Lau changed: What|Removed |Added Attachment #152207|0 |1 is obsolete|| --- Comment #3 from Sam Lau --- Created attachment 152348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152348=edit Bug 33963: Remove C4::BackgroundJob Finally! No more occurrences of this module, we can happily remove it! Test plan: git grep is your friend Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33963] Remove C4::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33963 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Dan Lerch changed: What|Removed |Added CC||dle...@pentictonlibrary.ca --- Comment #22 from Dan Lerch --- We have numerous power users that have many holds arrive at the same time. A digest would help reduce a lot of miscommunication between the library and our patrons. In our opinion a crucial feature enhancement. Dan Lerch, Penticton Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau changed: What|Removed |Added Attachment #152346|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152347=edit Bug 33500: Account for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20859] SMS number amd SMS provider during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
