[Koha-bugs] [Bug 33907] Improve translation of title tags: OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33907 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34046] New: The barcode number is not being accepted in the receiving order option in KOHA 23.05.00 after upgrading from 22.11.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34046 Bug ID: 34046 Summary: The barcode number is not being accepted in the receiving order option in KOHA 23.05.00 after upgrading from 22.11.05 Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: librar...@pilani.bits-pilani.ac.in QA Contact: testo...@bugs.koha-community.org Created attachment 152454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152454=edit Steps followed - Screen capture We have recently upgraded from version 22.11.05 to 23.05.00 in KOHA. Prior to the upgrade, the acquisition module was functioning flawlessly. However, after the upgrade, we have encountered an issue. When receiving an item, KOHA prompts for the barcode number, but upon clicking the newly changed "Confirm" button, the system fails to save the assigned barcode. The record appears as a received item but without any barcode, resulting in a Holding zero status. I have attached screen prints of the relevant screens, starting from Global presence settings. I kindly request the KOHA community to urgently investigate and resolve this problem, as it is a critical issue that affects all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Found this when testing for server side enforcement: 0. apply patches 1. have a bundle 2. have it's page opened and it's manage bundle menu too 3. in another tab, check the bundle out 4. back to the 1st tab, try to add another item to the bundle 5. error: "Failure: Item 'BARCODE' belongs to another bundle" this is false! note: API response: 409 and error bundle_checked_out, nothing wrong here it seems 6. try to remove an item 7. nothing happens, which is okay 8. API response: 501 not implemented, error: No response rule for "409" Is the wrong message UI at step 5 a big deal? Same question for API response at step 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34040] Add option to limit fund usage to branch or group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34040 Lisette Scheer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Lisette Scheer --- oooh, I definitely tested as a superlibrarian. Testing now without all those permissions it works as expected. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Phil Ringnalda changed: What|Removed |Added Attachment #152353|0 |1 is obsolete|| --- Comment #2 from Phil Ringnalda --- Created attachment 152453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152453=edit Bug 33978: Adding authority from automatic linker closes imported record If you import a record, then create an authority record using the automatic linker, it closes the biblio record. The problem occures when a record is edited in a new tab. To recreate: 1. Import the example records 1.1. Download the example records 1.2. Go to Cataloging > Stage records for import 1.3. Choose the downloaded file 1.4. Click Upload file 1.5. Click Stage for import 1.6. Click View batch 1.7. Click Import this batch into the catalog 1.8. Click View detail of the enqueued job 1.9. Click Manage imported batch Correct behaviour: 2. In another tab, search for one of the records (for example, Fafounet) 3. Click Edit > Edit record 4. Go to field 100 5. Click Link authorities automatically --> It should say 100 - No matching authority found. 6. Click the plus sign next to 100 7. Fill out the mandatory fields by clinking in the text fields (000, 003, 005, 008, 040), field 100 should already be filled 8. Click 'Save' --> Authority number is added in 100 and you get to stay in the record for more edits if needed Incorrect behaviour: 9. Go back to the imported batch tab 10. Click Edit next to the second title (the one by Paventi, Eza) 11. Redo steps 4 to 8 --> Record is closedclear :( The behaviour should be the same, stay in the bibliographic record until it is saved. 12. Apply the patch 13. Redo step 9, 10, 4 14. Edit field 100, Type 'Paventi Test 2' 15. Redo step 5 to 8 --> Authority number is added in 100 and you get to stay in the record for more edits if needed Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #46 from David Nind --- (In reply to Katrin Fischer from comment #45) > --pro= takes the path to Koha's perltidyrc file. I have updated the section > for Geany again. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34027] Add functionality to cleanup_database.pl to purge action logs in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34027 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #3 from Liz Rea --- omg yes. I love this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34045] New: Allow libraries to delete an attribute from authorized values while it is in use, with extra confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34045 Bug ID: 34045 Summary: Allow libraries to delete an attribute from authorized values while it is in use, with extra confirmation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Libraries sometimes implement borrower extended attributes, put data in them, and then decide they don't want them anymore, at all. Currently, Koha does not allow you to remove these wholesale, easily, from the interface. It might be nice to allow that with a Severe Warning and maybe even a "type 'I accept'" sort of confirmation box. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34040] Add option to limit fund usage to branch or group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34040 --- Comment #2 from Katrin Fischer --- Hm, and maybe manage_order_all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34040] Add option to limit fund usage to branch or group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34040 --- Comment #1 from Katrin Fischer --- But we do have that :) The key is removing the manage_budgets_all permission. Then you can user owners, users and library as options to restrict the use of funds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda changed: What|Removed |Added Attachment #152449|0 |1 is obsolete|| --- Comment #2 from Phil Ringnalda --- Created attachment 152452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152452=edit Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14347] Running overdue_notices.pl with --html flag set does not create well structured html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14347 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu --- Comment #4 from Michaela Sieber --- (In reply to Magnus Enger from comment #3) > > * The file is always named 'attachment.txt' regardless of whether the > > script is called using the "--html" or "--text" flags. > > This is adressed in Bug 29354. Perhaps this bug should be marked as RESOLVED DUPLICATE of bug 29354 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34044] New: System preference EmailOverduesNoEmail is missing in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34044 Bug ID: 34044 Summary: System preference EmailOverduesNoEmail is missing in manual Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sie...@kit.edu QA Contact: testo...@bugs.koha-community.org There is no description for system preference EmailOverduesNoEmail It should be part of the chapter Global system preferences > Administration > interface options See: https://koha-community.org/manual//23.05/de/html/administrationpreferences.html#interface-options Text for manual: Asks: ___ overdue notices for patrons without email address to staff. Default: Send Values: Don’t send Send Description: If this system preference is enabled overdue notices for patrons without email address to staff (see system preference AddressForFailedOverdueNotices). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Fabricio Molins changed: What|Removed |Added CC||fabriciomol...@theke.io Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fabriciomol...@theke.io |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29354] Make overdue_notices.pl send HTML attachment as .html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30002] Add project-level perltidyrc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #45 from Katrin Fischer --- (In reply to David Nind from comment #39) > I've updated the Perltidy page on the Wiki with some consistent structure > and formatting - feel free to edit to fix up any errors that I may have > inadvertently introduced: > https://wiki.koha-community.org/wiki/Perltidy > > Questions: > > Q1. I'm not sure what the perltidy -pro=.perltidyrc command is supposed to > do - it did nothing for me in KTD (pertidy version is 20200110), it just sat > there with a flashing cursor. Outside KTD with perltidy installed, it did > the same as well. > > Q2. For usage in Geany, I'm not sure what "Select part of your file or > script to perltidy -pro=/home/path/to/.perltidyrc" means either. > > (Possibly, the answer to these questions are obvious to developers 8-).) --pro= takes the path to Koha's perltidyrc file. I have updated the section for Geany again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34003] Add messaging preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34003 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||34043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 [Bug 34043] Improve translation of CSV header templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34043] New: Improve translation of CSV header templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 Bug ID: 34043 Summary: Improve translation of CSV header templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 21156 Koha has several templates which are used to define the headers for CSV export files, but they are not structured well for easy translation. For example, this is how the translation tool presents csv_headers/catalogue/itemsearch.tt in the .po file: #: koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt:1 #, c-format msgid "%s %s %s %s \"Title\" %s \"Publication date\" %s \"Publisher\" %s \"Collection\" %s \"Barcode\" %s \"Serial enumeration\" %s \"Call number\" %s \"Home library\" %s \"Current library\" %s \"Shelving location\" %s \"Item type\" %s \"Inventory number\" %s \"Not for loan status\" %s \"Lost status\" %s \"Withdrawn status\" %s \"Checkouts\" %s \"Due date\" %s " These files can be restructured to make the translation process easier. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20859] Enter SMS number and SMS provider during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Katrin Fischer changed: What|Removed |Added Summary|SMS number amd SMS provider |Enter SMS number and SMS |during self registration|provider during self ||registration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 Emily Lamancusa changed: What|Removed |Added Attachment #151962|0 |1 is obsolete|| --- Comment #28 from Emily Lamancusa --- Created attachment 152451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152451=edit Bug 23817: Include all phone numbers Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 Emily Lamancusa changed: What|Removed |Added Attachment #151961|0 |1 is obsolete|| --- Comment #27 from Emily Lamancusa --- Created attachment 152450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152450=edit Bug 23817: Normalize phone number when searching This patch rewrites the phone number DBIC query when sent from DataTables like in the Patron module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 2. Input '1-(234)-567-8901' into the 'Primary phone' field 3. Note on the next screen the phone number is shown as '1-(234)-567-8901' 4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 5. Choose "Search field" of "All phones" 6. Search for '12345678901' 7. Note you are taken to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8. Try out different permutations like '234 567 8901' or '5678901' 9. Note that every permutation works to find the borrower Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 Emily Lamancusa changed: What|Removed |Added Attachment #145221|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Owen Leonard changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 --- Comment #1 from Owen Leonard --- Created attachment 152449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152449=edit Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard changed: What|Removed |Added Blocks||34042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 [Bug 34042] Item search broken by FontAwesome upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] New: Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Bug ID: 34042 Summary: Item search broken by FontAwesome upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 32910 A minor regression snuck in with the FontAwesome upgrade (Bug 32910), probably from multiple rebases. We went back to "can_edit_item()" where we should have kept "can_edit_items_from( item.homebranch )". This causes an error when trying to do an item search in the staff interface: "Template process failed: undef error - The method Koha::Patron->can_edit_item is not covered by tests!" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 --- Comment #1 from Liz Rea --- Created attachment 152448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152448=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - bonus points, uncomment it and make sure you can start/stop/restart koha-z3950-responder with the example config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] New: z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Bug ID: 34041 Summary: z3950 responder additional options not coming through properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The z3950 responder default configuration has responder options, but the start script is looking for them in the node, which isn't in the config, so it never finds them if required. Probably we need to fix that, one way or another. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028
--- Comment #33 from Katrin Fischer ---
Updated test plan:
* Set CurrencyFormat to FR
* Enable UseRecalls
* Enable ArticleRequests
* Administration > circulation and fine rules
* Add a new rule:
* Fine amount: 0.10
* Fine charging interval: 1
* Overdue fines cap: 1.50
* Recall overdue fine amount: 1.10
* Save rule
* Verify that both Overdue fines cap and recall overdue fine amount show
formatted with comma as: 1,50, 1,10
* Edit rule
* Fine amount: 0.10 - OK!
* Fine charging interval: 1
* Overdue fines cap: 1,50 - NOT OK!
* Recall overdue fine amount: 1,10 - NOT OK!
* Save rule
* With SQL:
select * from circulation_rules where rule_name in
("fine","overduefinescap","recall_overdue_fine","article_request_fee");
+++--+--+-++
| id | branchcode | categorycode | itemtype | rule_name | rule_value
|
+++--+--+-++
| 9 | NULL | NULL | NULL | fine| 0.10
|
| 11 | NULL | NULL | NULL | overduefinescap | 1,50
|
| 32 | NULL | NULL | NULL | recall_overdue_fine | 1,10
|
+++--+--+-++
* Edit rule for Article request fee
* Fee: 1,0
* Verify it's also wrong in the database with above SQL.
--> This is already fixed by the patch set now, as we don't allow to edit the
rules and the pattern check works.
Missing bits and pieces:
Have to:
* When a rule is edited, the input field will be set to the display value
(1,00). I didn't find an "unformat" equivalent for JS. This now triggers the
pattern check, so you need to edit all values before being able to save them.
We could use the inputmode="decimal" on the input fields to select for
unformatting.
* Should we be able to deactivate overduefinescap by leaving it empty?
(Unlimited?)
Would be nice:
* It would be nice to provide more help in fixing wrong values or automatically
fixing obvious ones like xx,xx.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Mark Hofstetter changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152438|0 |1
is obsolete||
Attachment #152440|0 |1
is obsolete||
--- Comment #8 from Mark Hofstetter ---
Created attachment 152447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152447=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #32 from Katrin Fischer --- Created attachment 152446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152446=edit Bug 33028: (follow-up) Rewrite database update This rewrite the database update with some things in mind: * We now use a positive value list of allowed characters to check This makes sure that all of those are recognized: 1,00 1.00€ abc * Instead of dying after finding one wrong value, we loop through all values first, building up an error string * When we have errors... we die and print the full list of things that need fixing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #31 from Katrin Fischer --- Created attachment 152445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152445=edit Bug 33028: Add TT filters for Price and pattern checks to input fields With this patch, all monetary values in the table will be displayed formatted. Also, the input will be checked against our agreed pattern to make sure no false values can be entered. Missing: When editing a rule, we need to unformat the value, so that instead of the display format we have the input format available for editing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #30 from Katrin Fischer --- Created attachment 152444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152444=edit Bug 33028: Add is_monetary to recall_overdue_fine and article_request_fee This patch marks the 2 missing monetary values for recal over due fines and article request fees as monetary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #147688|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 152443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152443=edit Bug 33028: (follow-up) Fix trailing 0 decimals We want to recognise the truthyness of a number vs string so we drop trailing decimals if they're just 0. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #147687|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 152442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152442=edit Bug 33028: (follow-up) Move monetary definition into hash This patch moves the defintion of monetary rule type into the rule kinds hash. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Attachment #147686|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 152441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152441=edit Bug 33028: Fix calculations around cronjob fines.pl When currency format is set on FR commas are decimals separators but when cron like fines.pl try to calculate fines it's fails due to this format. I changed this behavior by targetted 'fine' and 'overduefinescap' in circulation_rules.rule_name to unformat them when we save them. This also fix the display in smart_rules table (before with commas price was not good displayed - without decimals) Test Plan : 1) Set your currency format on 'FR' and 'fine' OR/AND 'overduefinescap' with commas 2) Be sure to have some patron overdues 3) Run ~/misc/cronjobs/fines.pl with args to find overdues 4) See an error like 'isn't numeric in substraction[..] or gt > [...]' 5) Run updatedatabase script (it will replace commas in your rules changed in step 1) ) 6) Repeat step 3 and see that everything was going "fine" (:tada:) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152439|0 |1
is obsolete||
--- Comment #7 from Mark Hofstetter ---
Created attachment 152440
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152440=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Mark Hofstetter changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152437|0 |1
is obsolete||
--- Comment #6 from Mark Hofstetter ---
Created attachment 152439
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152439=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #5 from Mark Hofstetter ---
Created attachment 152438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152438=edit
Bug 33036: REST API: Merge biblio records
implements merging of records + attached items, subscriptions etc via the API
as an alternative to the web interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152436|0 |1
is obsolete||
--- Comment #4 from Mark Hofstetter ---
Created attachment 152437
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152437=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Mark Hofstetter changed: What|Removed |Added Patch complexity|--- |Medium patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #3 from Mark Hofstetter ---
Created attachment 152436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152436=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33966] "Update and run SQL" for non-English templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #8 from Emily Lamancusa --- Thanks for sharing this, Jason! I just added it to our installation and it looks great! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33980] No results on search creates double sets of quotes on breadcrumb search term and page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33980 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #6 from Emily Lamancusa --- I can't quite remember enough detail to search it, but isn't there a feature somewhere that retries a search with quotes if the unquoted search doesn't work? I'm guessing those added quotes could be coming through in the breadcrumbs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Summary|Add ability to search |Add ability to search |biblios endpoint using ISBN |biblios endpoint any ||biblioitem attribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint using ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #5 from Tomás Cohen Arazi --- Marking NSO to get some eyes here. The Objects.t tests haven't been reviewed yet and are expected to fail. Any help is of course welcome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint using ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 152435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152435=edit Bug 33974: (follow-up) Adapt the orders endpoint In order to reduce the technical debt carried on the orders controller, and to highlight the decisions made on the prior patch, I adapted the list() orders controller using the new tools in town. The result is this endpoint can now embed bibio, without needing to have a custom piece of code. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/*.t => SUCCESS: Tests pass :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint using ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 152434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152434=edit Bug 33974: Make biblioitem columns searchable in a generic way This patch makes biblioitem attributes be searchable on the biblios endpoint. It does so by using the new method in Koha::Biblios, and by adjusting objects.search(_rs) to accept a $query_fixer arrayref of functions to be applied to each query or order_by parameters. The result is cleaner code to write, but complex internals. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Searching for biblioitem attributes works on the API! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint using ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 152433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152433=edit Bug 33974: Add Koha::Biblios->api_query_fixer This patch adds the `api_query_fixer` method to the class, and adds tests to validate its behavior. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblios.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #32 from Emily Lamancusa --- Lucas, can you provide a test plan for that last patch? If so I'd be happy to sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34026] Move translatable cover-handling strings out of opac-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 --- Comment #3 from Owen Leonard --- This change cannot be made to coce.js because it is outside koha-tmpl/intranet-tmpl/prog/js. Files in koha-tmpl/intranet-tmpl/js are not processed for translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34026] Move translatable cover-handling strings out of opac-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 Owen Leonard changed: What|Removed |Added Attachment #152393|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 152432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152432=edit Bug 34026: Move translatable cover-handling strings out of opac-bottom.inc This patch removes several instances from opac-bottom.inc where we define strings for translation and use in separate JavaScript files. The JavaScript files are updated to use the __() function to mark strings for translation. Note: Definition of the variable NO_COCE_JACKET is removed because it is unused. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, enable OPAC cover image services: - OPACAmazonCoverImages - BakerTaylorEnabled - GoogleJackets - OpenLibraryCovers - In the OPAC, perform a search and confirm that there are no JS errors on the search results page related to cover images. - Check the bibliographic detail page as well. To confirm that the strings are being picked up for translation, run the update process for another language, e.g. perl misc/translator/translate update fr-FR Then check the newly-built po file: fr-FR-messages-js.po. It should list the updated files: koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js:8 koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js:10 koha-tmpl/opac-tmpl/bootstrap/js/bakertaylorimages.js:7 koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js:77 koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js:63 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34026] Move translatable cover-handling strings out of opac-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 --- Comment #16 from Jonathan Druart --- Created attachment 152431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152431=edit Bug 33971: Remove x-koha-query header support This patch removes support for the `x-koha-query` header entirely from the codebase. For the purpose: - $c->objects->search is adjusted - Relevant tests are cleared/adapted - The OpenAPI spec gets the header removed To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t \ t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 --- Comment #15 from Jonathan Druart --- Created attachment 152430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152430=edit Bug 33971: Remove x-koha-query handing in Orders.pm This patch removes manual handling of `x-koha-query` in the Orders:list() controller. There are no tests for the feature but you can verify no behavior is changed by doing: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Jonathan Druart changed: What|Removed |Added Attachment #152302|0 |1 is obsolete|| Attachment #152303|0 |1 is obsolete|| Attachment #152422|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 152429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152429=edit Bug 33971: Remove x-koha-query usage in biblios.t This patch removes handling of x-koha-query from the tests. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Change from x-koha-header to q= gives same results. 4. Sign off :-D Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34026] Move translatable cover-handling strings out of opac-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34040] New: Add option to limit fund usage to branch or group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34040 Bug ID: 34040 Summary: Add option to limit fund usage to branch or group Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org While you can limit who can edit funds, it doesn't limit who can use a fund in a basket. It would be very helpful for consortia, who may have a large number of funds if there was maybe a permission or preference to only let staff use funds from their library or maybe their library group. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #30 from Jonathan Druart --- Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149818|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 152428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152428=edit Bug 31383: Restore updated_on for individual content Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149817|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 152427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152427=edit Bug 31383: DBIC specific Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149816|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 152426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152426=edit Bug 31383: DBIC changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149815|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 152425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152425=edit Bug 31383: DB changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149814|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 152424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152424=edit Bug 31383: Adjust and add tests Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Attachment #149813|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 152423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152423=edit Bug 31383: Create a parent-child DB relation for additional content In the design of additional contents the idea of a parent-child relation is implicitly present. You have a default page and translations. But we do this in one table coming from the old news items. Several reports show that we would be better off creating a parent table listing the main news items, CMS pages or HTML content. And a child table containing the title, content and lang. Note that this first step is a prelimenary step to clean this area and make it more robust and extensible. More enhancements to come. What is this patchset doing? * DB changes - Rename additional_contents.idnew with id - Create a new table additional_contents_localizations(id, additional_content_id, title, content, lang) that will contain the translated contents - Move the content to this new table - Remove title, content and lang columns from additional_contents - Replace the notice templates that are using ''" (should only be ISSUESLIP) and remove support for this syntax. Also add a warning in case other occurrences of uses of the old syntax exist. * CRUD - We add a new Koha::AdditionalContentsLocalization[s] couple, and move some logic from Koha::AdditionalContent[s] to there. Note that, to prevent too much drastic changes in notice templates, and to make them easy to use, the different attributes of the content object is accessible from the translated content object (ie. Koha::AdditionalContentsLocatlization->library is available and return $self->additional_content->library). I think it's an elegant way to keep things simple. - No changes expected for "NewsLog" logging - Little behaviour changes for pages, see tools/page.pl changes. We are now passing the id of the content, and the desired language, instead of the mix of "page_id" or code and lang. Note that here we certainly need to rename "language" query param to not change the full interface language. Test plan: 0. Preparation steps, use master a. Create notice templates that are using "<< additional_contents.code >>". This won't be replaced, but we want the update process to alert us. b. Create several news, additional contents, pages. Some with translated contents, some without. c. Make sure ISSUESLIP has the "" section. If you are using the sample data there is nothing to do here d. Turn on NewsLogs 1. Apply the patches, restart_all, updatedatabase => Confirm that the new table is created and filled with the contents you had prior to the update => Confirm that additional_contents_localizations.updated_on has been kept to the previous values => Confirm that ISSUESLIP has been replaced properly => Confirm that you get a warning about the additional_contents 2. Create, update, delete news, html customs, pages => Confirm that the additional_contents_localizations.updated_on is only adjusted when required => Confirm that the logs are correctly created when NewsLogs is on 3. Check some items out, generate a slip => Confirm that the news are displayed at the bottom of the slip, and that the publication date is correctly formatted 4. Have several HTML customizations (like OpacNav, opacheader), in translated in different languages => Confirm that the default values is displayed when you are using the interface in a language without translation => Confirm that the translated version is picked when it exists Notes for QA: * I am not sure we really need the alert during the update DB process about the additional_contents leftover. We should not have them outside of ISSUESLIP. Shouldn't it hurt? * There is something ugly in sample_news.yml, the id is hardcoded. But how do we prevent that and keep translatability? Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > What about the occurrence in api/v1/swagger/swagger.yaml? Done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Tomás Cohen Arazi changed: What|Removed |Added Attachment #152304|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 152422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152422=edit Bug 33971: Remove x-koha-query header support This patch removes support for the `x-koha-query` header entirely from the codebase. For the purpose: - $c->objects->search is adjusted - Relevant tests are cleared/adapted - The OpenAPI spec gets the header removed To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t \ t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #16 from Jonathan Druart --- Too bad that this has been revived before bug 31383 was pushed... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 --- Comment #1 from Owen Leonard --- Created attachment 152421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152421=edit Bug 34038: Fix incorrect use of __() in .tt and .inc files This patch corrects instances of the double-underscore function being used in .tt and .inc files where the single-underscore function should be used instead. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find these lines: - koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc: "No title." - koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: "Check in and add to bundle" "Ignore holds and add to bundle" - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt: "Please enter only a barcode, or only a biblionumber." - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt: "Please enter only barcodes, or only biblionumbers." - koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt: "Please specify a content for 'Default'" - Check fr-FR-opac-bootstrap.po for these lines: - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc: "Please enter a valid date (should match %s)." - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt: "No item was selected" - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: "No item was selected" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #26 from Katrin Fischer --- I am working on a few follow-ups here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34039] New: TT comments in translated strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34039 Bug ID: 34039 Summary: TT comments in translated strings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr A couple of TT comments strings appeared in the strings to be translated for the html_helpers.inc file. %s %s %s %s %s %s %s %s %s %s %s%s %s %s %s %s [%% # [ WRAPPER tab_item tabname= "tab_name_1" bt_active= 1 ] [ END ] %%] %s %s %s %s %s %s %s %s %s %s [ END ] %%] [%% # [ WRAPPER tab_item tabname= "tab_name_2" ] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33983] Move translatable strings out of OPAC's datatables.inc into JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33983 Owen Leonard changed: What|Removed |Added Attachment #152277|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 152419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152419=edit Bug 33983: Move translatable strings out of OPAC's datatables.inc into JavaScript This patch removes the definition of translatable strings out of the OPAC datatables.inc file and into datatables.js using the new JS i81n function. To test apply the patch and test some DataTable-driven tables in the OPAC. A list of possible examples: - Cart - Bibliographic detail page - Place hold (with OPAC item level holds enabled in circulation rules) - Show more options -> - A specific item - Bibliographic detail page for a serial record -> - More details -> - Full history - Most popular - Self checkout - Logged in user -> - Charges - Curbside pickups - Messaging - Checkout history - Suggestions - Holds history - Tags - Recalls history - Search history - ILL requests DataTables functionality should be unaffected. Check that the strings defined for translation are still working. For instance the "Clear filter" label on user summary checkouts, or the "No matching records found" text displayed when you search a table for a string that doesn't exist. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, in this case misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members.js for translation, e.g.: msgid "Clear filter" - Edit the corresponding "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 Katrin Fischer changed: What|Removed |Added Attachment #152417|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 152418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152418=edit Bug 34029: Extend datatypes of biblioitems.columns to longtext to avoid breaking import This updated the datatype of the following columns from varchar(255) to longtext to avoid import problems if the mapped MARC field's data exceeds 255 characters. This is for: * place (260$a and 264$a) * publishercode (260$b and 264$b) * size (300$c) * illus (300$b) * pages (300$a) To test: * Edit a bibliographic record and enter more than 255 characters into the MARC fields listed above. Try to save. * Run the updatedatabase script to modify the DB structure * restart_all * Edit a bibliographic record and enter more than 255 characters into the MARC fields listed above. * Save * Export the record * Import the record using staging tools, all should work well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 Katrin Fischer changed: What|Removed |Added Attachment #152404|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 152417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152417=edit Bug 34029: Extend datatyps of common biblioitems.columns to longtext to avoid breaking import This updated the datatype of the following columns from varchar(255) to longtext to avoid import problems if the mapped MARC field's data exceeds 255 characters. This is for: * place (260$a and 264$a) * publishercode (260$b and 264$b) * size (300$c) * illus (300$b) * pages (300$a) To test: * Edit a bibliographic record and enter more than 255 characters into the MARC fields listed above. Try to save. * Run the updatedatabase script to modify the DB structure * restart_all * Edit a bibliographic record and enter more than 255 characters into the MARC fields listed above. * Save * Export the record * Import the record using staging tools, all should work well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added Summary|The decimal separator |Wrongly formatted monetary |'comma' and its |amounts in circulation |consequences on the |rules break scripts and |calculation of fines|calculations |(crons) | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028
--- Comment #25 from Katrin Fischer ---
To test:
* Set CurrencyFormat to FR
* Enable UseRecalls
* Administration > circulation and fine rules
* Add a new rule:
* Fine amount: 0.10
* Fine charging interval: 1
* Overdue fines cap: 1.50
* Recall overdue fine amount: 1.10
* Save rule
* Verify that both Overdue fines cap and recall overdue fine amount show
formatted with comma as: 1,50, 1,10
* Edit rule
* Fine amount: 0.10 - OK!
* Fine charging interval: 1
* Overdue fines cap: 1,50 - NOT OK!
* Recall overdue fine amount: 1,10 - NOT OK!
* Save rule
* With SQL:
select * from circulation_rules where rule_name in
("fine","overduefinescap","recall_overdue_fine");
+++--+--+-++
| id | branchcode | categorycode | itemtype | rule_name | rule_value
|
+++--+--+-++
| 9 | NULL | NULL | NULL | fine| 0.10
|
| 11 | NULL | NULL | NULL | overduefinescap | 1,50
|
| 32 | NULL | NULL | NULL | recall_overdue_fine | 1,10
|
+++--+--+-++
So the problem is, that you will save false values unnoticed that will cause
errors.
You cannot tell wrong and right values apart in the table, because all values
show formatted, if correct in the database or not.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 --- Comment #11 from Jonathan Druart --- What about the occurrence in api/v1/swagger/swagger.yaml? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33888] Overdues with fines report displays error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Katrin Fischer changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Katrin Fischer --- Can this please be backported for next bugfix releas? No strings! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27663] statistics table should have some way to include items.permanent_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27663 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #9 from Sally --- +1 Adding items.permanent_location to statistics would resolve this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33983] Move translatable strings out of OPAC's datatables.inc into JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33983 --- Comment #4 from Jonathan Druart --- Actually I don't understand why you are adding the PROCESS to the different templates. __ is defined in js/i18n.js Here you don't remove/move lines that are using the I18N TT plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||34038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 [Bug 34038] Fix incorrect use of __() in .tt and .inc files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] New: Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 Bug ID: 34038 Summary: Fix incorrect use of __() in .tt and .inc files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 21156 We have several instances of translatable strings in templates and include files being wrapped in the double-underscore function which should only be used in .js files. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #1 from Owen Leonard --- Created attachment 152416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152416=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #26 from Tomás Cohen Arazi --- Follow-up pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
