[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 --- Comment #10 from Marcel de Rooy --- Created attachment 152843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152843=edit Bug 34146: Add a client-side check with maxlength too Test plan: Try to add more than 3 characters now in the number of copies. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 --- Comment #9 from Marcel de Rooy --- (In reply to Owen Leonard from comment #8) > (In reply to Marcel de Rooy from comment #7) > > There is a size="2" but it does not work. > > It sounds like you may be thinking of the "maxlength" attribute? Size only > controls the width, not the values it accepts. Good point. Will add maxlength. Was trying to deduct why the check was removed. Note that size for a input text has a vague connection to the number of chars according to html specs. This attribute tells the user agent the initial width of the control. The width is given in pixels except when type attribute has the value "text" or "password". In that case, its value refers to the (integer) number of characters. END QUOTE Note that it also depends on font etc. So not a good choice. Bootstrap offers other options for width too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #11 from Marcel de Rooy --- (In reply to Owen Leonard from comment #10) > Signed-off-by: Owen Leonard Thx ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30661] Able to update more hold parameters via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23269] Long hold queues are slowing the service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Emmi Takkinen changed: What|Removed |Added Depends on||30660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 [Bug 30660] Add cancellation reason to holds delete endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30660] Add cancellation reason to holds delete endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 Emmi Takkinen changed: What|Removed |Added Blocks||23269 CC||emmi.takki...@koha-suomi.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23269] Long hold queues are slowing the service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #2 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #1) > Maybe this would be another candidate to be moved to the REST API? Johanna has actually worked on this (but is currently absent) and we've been using it for awhile now https://github.com/KohaSuomi/Koha-22x/commit/c26f53eeac4c12e13e1e595931b4ec279f054da7 However, this depends on bug 30660 and bug 30661. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #4 from Phil Ringnalda --- Koha does try to set biblio.serial based on seriestitle, in https://git.koha-community.org/Koha-community/Koha/src/commit/532cf4ab9f5549c1e8f41d6c7191f9e1a9ed9e3c/C4/Biblio.pm#L233 And from a quick sandbox test, it succeeds (had to use a sandbox, since my production install has seriestitle only mapped from 440, not 490, so I lack both seriestitle and serial). Blame says that Koha has been that way at least since "rel_3_0 moved to HEAD" 17 years ago. It's not sane, but it's a longstanding lack of sanity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Jessie Zairo changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128 --- Comment #3 from Katrin Fischer --- Note: default mapping for biblioitems.serial appears to be 942$s! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #35 from Lucas Gass --- (In reply to Emily Lamancusa from comment #32) > Lucas, can you provide a test plan for that last patch? If so I'd be happy > to sign off. To test: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Using this report can help: SELECT COUNT( IF( statistics.type = 'localuse', statistics.itemnumber, NULL ) ) AS 'local use count' FROM statistics WHERE statistics.itemnumber=<> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hm, I believe there are some things here that are a little odd. 490 doesn't indicate if something is a serial - it only indicates it's part of a series (a volume of a series). I believe I haven't seen serial flag set in MARC21 installations, but I might be mistaken. Could a library have changed the Koha-to-MARC mappings falsely resulting in it to validate to true? Also we should not hardcode a framework code. Koha comes with some examples, but libraries can and will built their own with any code. Also: Test plan needs updating (mentions 942 set to Books) I'd suggest checking the mappings! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #34 from Lucas Gass --- (In reply to Emily Lamancusa from comment #33) > Tried to test this, but the patch does not apply. > > Applying: Bug 16122: Add localuse column to items and deleteditems > Applying: Bug 16122: API and Schema updates > Applying: Bug 16122: Increment items.localuse in AddReturn > Applying: Bug 16122: Add display to holdings/otherholdings and Table settings > Using index info to reconstruct a base tree... > M admin/columns_settings.yml > M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt > Falling back to patching base and 3-way merge... > Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt > Auto-merging admin/columns_settings.yml > Applying: Bug 16122: Increment localuse when checking out to stats patron > error: sha1 information is lacking or useless (C4/Circulation.pm). > error: could not build fake ancestor > Patch failed at 0001 Bug 16122: Increment localuse when checking out to > stats patron This still applies cleanly for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33934] 'No encryption_key in koha-conf.xml' needs more detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33934 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31059 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31059] encryption_key config entry not generated when upgrading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33934 CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 quinn.mor...@citruslibraries.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 ByWater Sandboxes changed: What|Removed |Added Attachment #152841|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 152842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152842=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 ByWater Sandboxes changed: What|Removed |Added Attachment #152840|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 152841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152841=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34122] Updating Shelvingloc changes location of all related records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 --- Comment #2 from Laura Escamilla --- Revised/reworded test plan: 1. Create a bib record that has at least 3 items. 2. Change the shelving location of item 1 and do not add shelving locations to the other items. 3. View the bib record for the items in catalogue/detail.pl, all three items will have the shelving location that was assigned to item 1. However, if you look at the items in cataloguing/additem.pl, only item 1 will show the shelving location change. Item 2 and 3 will still show a blank shelving location. 4. Apply patch 5. Repeat step 3. Only item 1 should have a shelving location visible in both catalogue/detail.pl and cataloguing/additem.pl. 6. Sign off! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 --- Comment #8 from Owen Leonard --- (In reply to Marcel de Rooy from comment #7) > There is a size="2" but it does not work. It sounds like you may be thinking of the "maxlength" attribute? Size only controls the width, not the values it accepts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #4 from Owen Leonard --- (In reply to quinn.morris from comment #2) > Just for clarification, where would I put this information to try the fix? In case you were referring to an incomplete test plan, I have revised it with more details. If you're asking how to apply and test the patch, check out this page: https://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard changed: What|Removed |Added Attachment #152812|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 152840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152840=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34122] Updating Shelvingloc changes location of all related records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 --- Comment #1 from Laura Escamilla --- Created attachment 152839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152839=edit Bug 34122: Fix for shelving locations that were applying to all item records. Test plan: 1. Create a bib record that has at least 3 items. 2. Change the shelving location of item 1 and do not add shelving locations to the other items. 3. View the bib record in the catalog, all three items will have the shelving location that was assigned to item 1. 4. Apply patch 5. Refresh the page on the bib record. Only item 1 should have the shelving location set. 6. Sign off! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34122] Updating Shelvingloc changes location of all related records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m --- Comment #349 from Catrina Berka --- Academic libraries would find this useful to limit their open hours, specifically for summer holidays. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34122] Updating Shelvingloc changes location of all related records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 Laura Escamilla changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13556] Undo Item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13556 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34151] New: Hard due date being ignored in circulation rules in favor of loan period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34151 Bug ID: 34151 Summary: Hard due date being ignored in circulation rules in favor of loan period Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1. Create a circulation rule for All Patrons, All Categories with a loan period of 10 days. 2. Set a hard due date for a date after the loan period. 3. Check out an item and see that the due date is based off the loan period and not the hard due date. Also, setting a loan period for the exact time period and the hard due date (so the dates are the same) also appears to fail and it reverts to the previous loan period. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34097] Using the three ellipses to set the date cataloged (952|d) for an item repositions the screen to the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34097 Sam Lau changed: What|Removed |Added Attachment #152772|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152838=edit Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up Test plan: 1. Find a record with several items (in ktd "MacLaren's Gaelic self-taught" will do nicely 2. Click the Edit button next to one of the items 3. Click the "..." to the right of "d - Date acquired" and verify that the page doesn't scroll up to the top, and that the current date is inserted in the field 4. Click the "..." to the right of "w - Price effective from" and verify that the page doesn't scroll up and the current date is inserted Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34097] Using the three ellipses to set the date cataloged (952|d) for an item repositions the screen to the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34097 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 Sam Lau changed: What|Removed |Added Attachment #152650|0 |1 is obsolete|| --- Comment #12 from Sam Lau --- Created attachment 152837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152837=edit Bug 33270: Attempt to recover from invalid metadata exception This patch uses the new record_strip_nonxml routine to attempt to display the record when it contains invalid characters Rather than silently strippg these, we warn in the logs, then add an 'about' container to the response. It is displayed nicely in the web view or sent as "INVALID_METADATA" in the xml response The 'error' codes for OAI seem to be at the request level, and the offered codes don't have a match for a bad record. Adding the about when we can recover seems the most generous response To test: Test plan, assumes using KTD default data - otherwise you need to find and import a record with encoding issues: 1 - Enable OAI-PMH system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml/3500/0/352 3 - 500 error: Invalid data, cannot decode metadata object (biblio_metadata.id=368, biblionumber=369, format=marcxml, schema=MARC21, decoding_error=':8: parser error : PCDATA invalid Char value 31... 4 - Apply patch, restart all 5 - Reload the page 6 - It loads! 7 - Click 'Metadata' for record 369 - it succeeds! 8 - Check the logs - confirm you see a warning of the record problem 9 - Confirm 369 has an about section 10 - Check the individul 'GetRecord' response as well http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord=oai_dc=KOHA-OAI-TEST:369 Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 Sam Lau changed: What|Removed |Added Attachment #152649|0 |1 is obsolete|| --- Comment #11 from Sam Lau --- Created attachment 152836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152836=edit Bug 33270: Add record_strip_nonxml routine to Koha::Biblio::Metadata This adds a routine that can strip non xml characters form a record. It is intended for cases where we do not wish to throw an exception, but rather need to process a record to allow other work to continue To test: prove -v t/db_dependent/Koha/Biblio/Metadata.t Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 Sam Lau changed: What|Removed |Added Attachment #152702|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152835=edit Bug 34116: Add page-sectioning to item search in label creator This patch adds a "page-section" class to search results page seen when adding items to a label batch. The patch also makes some minor changes to markup around the search header to make it more consistent with other search pages. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch - Without entering anything in the textarea, click the "Add item(s)" button" - In the pop-up window, perform a search which will return multiple results. - Confirm that everything looks correct and all controls work as they should. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26558] Guarantor information is lost when an error occurs during new account creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26558 Sam Lau changed: What|Removed |Added Attachment #152782|0 |1 is obsolete|| --- Comment #9 from Sam Lau --- Created attachment 152834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152834=edit Bug 26558: Make guarantor information persist despite an error When one tries to create an account with patron guarantor and error occurs (already used username, wrong age etc.), guarantor information is lost. This patch always saves added patron guarantor information to the template param new_guarantors. To test: 1. Create a new account but cause an error that will keep the account from saving (enter the wrong age for a category or give the patron a username that's already being used). 2. Search for and select a guarantor. 3. Try to save the account and wait for the "The following fields are wrong. Please fix them." message. => Note that the guarantor information is gone and you need to search for and select the guarantor again. 4. Apply this patch. 5. Repeat steps 1.-3. => Note that guarantor information hasn't been lost. This patch also removes code block from duplicate patron check because we now save param new_guarantors even if error doesn't occur. To test: 1. Create a new account but cause a duplicate patron error. 2. Search for and select a guarantor. 3. Try to save the account. => Guarantor information should persist. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26558] Guarantor information is lost when an error occurs during new account creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26558 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34150] New: Personal name (100a) field missing tag editor on acquisition framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34150 Bug ID: 34150 Summary: Personal name (100a) field missing tag editor on acquisition framework Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Created attachment 152833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152833=edit Missing tag editor button With the RequireChoosingExistingAuthority set to required for cataloging, this requirement is now enforced on the acquisitions framework. However, the authority field is missing the tag editor to allow a look up. To recreate: 1. Set the RequireChoosingExistingAuthority system setting to required. 2. Make sure the acquisitions framework has the 100 Personal name field 2. In Acquisitions, find a vendor and add to a basket from a new empty record. See that the 100 Personal name field is missing the tag editor button. This is new behavior with 22.11. Previously the required look up was not present with this system setting enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #4 from Heather --- We were just upgraded to Koha 22.11.06 and we're having this problem (with Edge 114.0.1823.58 and with Chrome 114.0.5735.135) when trying to download the .pdf for a barcode label range/batch. I'm hoping very much it gets fixed--I can't catalog anything or receive any periodicals if I can't print barcodes!! --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34148] mainpage.pl shows background jobs to users without manage_background_jobs permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34148 Lucas Gass changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Lucas Gass --- I just saw Bug 29020. So this is working as intended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34149] New: Syndetics cover images don't load in staff interface detail page in other images services are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Bug ID: 34149 Summary: Syndetics cover images don't load in staff interface detail page in other images services are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1. Turn on Syndetics 2. Set AmazonCoverImages to show 3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. 4. The image never loads. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34148] mainpage.pl shows background jobs to users without manage_background_jobs permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34148 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34148] New: mainpage.pl shows background jobs to users without manage_background_jobs permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34148
Bug ID: 34148
Summary: mainpage.pl shows background jobs to users without
manage_background_jobs permission
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff interface
Assignee: koha-bugs@lists.koha-community.org
Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
On mainpage.pl we show the count of background jobs only to users who do not
have the manage_background_jobs permission:
unless ( $logged_in_user->has_permission( { parameters =>
'manage_background_jobs' } ) ) {
my $already_ran_jobs = Koha::BackgroundJobs->search(
{ borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0;
$template->param( already_ran_jobs => $already_ran_jobs );
}
This seems backwards to me. Is there a reason to show the count only to users
without the permission?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092
--- Comment #10 from Pedro Amorim ---
Test plan to is test different patron searches and make sure everything is
working as intended, before and after applying the patch.
Examples of patron-autocomplete.js:
- Patrons lists (create new list, add patrons to it):
/cgi-bin/koha/patron_lists/lists.pl
- View logs ("Librarian:" input):
/cgi-bin/koha/tools/viewlog.pl
- Reserve request:
/cgi-bin/koha/reserve/request.pl
Examples of patron-search.inc:
- ERM, "Add new user" button:
/cgi-bin/koha/erm/agreements/add
- New patron card batch:
/cgi-bin/koha/patroncards/edit-batch.pl (Click "add patron" button")
Bonus:
- Create a patron attribute type and set it "searchable".
- Edit a patron and put some unique in that new patron attribute
- Search for that, or part of that.
More: Play with DefaultPatronSearchFields and DefaultPatronSearchMethod system
preferences and verify that the searches all return as expected.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Attachment #152698|0 |1 is obsolete|| --- Comment #9 from Pedro Amorim --- Created attachment 152832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152832=edit Bug 34092: Move search-patron.inc logic into buildPatronSearchQuery -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Attachment #152683|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 152831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152831=edit Bug 34092: Preparation: New buildPatronSearchQuery function Move patron search query logic out of patron_autocomplete into new function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Attachment #152682|0 |1 is obsolete|| --- Comment #7 from Pedro Amorim --- Created attachment 152830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152830=edit Bug 34092: Move patron_autocomplete to staff-global.js Remove patron-autocomplete.js file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #66 from Martin Renvoize --- OK... with that last patch I think we should be working correctly in all cases.. Please follow the test plan in comment 25 to confirm this. We can drop/squash half the patches here.. the bug has become a real mess with things getting added then reverted, then added and finally reverted again. I'm not sure we need the js unformat function I created at all at this point.. it's no longer used here.. but might be helpful migrated to another bug in case anyone needs it elsewhere. I'm also not sure about the location of the unformat call deep down in Circulation rules.. it feels like we should perhaps be calling this higher up in the controller rather than the module expecting different input types based on configuration. Anyway.. I'd love to see this move forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #65 from Martin Renvoize --- Created attachment 152829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152829=edit Bug 33028: (follow-up) Remove inputmode and pattern -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34147] New: Patron Search Displays "Processing" when Category Has Library Limitations that Exclude the Logged In Branch Name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34147 Bug ID: 34147 Summary: Patron Search Displays "Processing" when Category Has Library Limitations that Exclude the Logged In Branch Name Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jyo...@equinoxinitiative.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I'll start by saying that I don't know if this relates to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24132 or not. To replicate, you'll need more than one library in Administration | Libraries. Setup a patron category with a Library Limitation, so that one library is excluded (by not selecting it). Create a patron with a common surname in your borrowers table and assign to that category. While the logged in branch is set to one of the libraries that are not excluded for that category you created above, search for patrons with the surname of your test patron. You should get results as expected. Change the logged in branch name to the excluded library. Conduct the same search. A processing message appears and just spins. I'm not sure whether the desired result should be to exclude the patron in question from the search results or whether it should display but with some restriction on the Patron Category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #64 from Martin Renvoize --- OK.. I should have read Katrins patches in more depth before continuing here.. Bug 33028: Add TT filters for Price and pattern checks to input fields This actually takes us backwards and breaks input more.. We are expecting currency format to be correctly passed to us in system currency format.. NOT always US decimal.. as such by adding the pattern and setting the input types to decimal only we are forcing US decimal input which means the unformat call on the serverside is breaking the inputs. I think we should go all the way back to `Bug 33028: Add is_monetary to recall_overdue_fine and article_request_fee` and we had a working system at that point following Katrins test plan.. at least it was working for me for all cases at that point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Sam Lau changed: What|Removed |Added Attachment #152827|0 |1 is obsolete|| --- Comment #12 from Sam Lau --- Created attachment 152828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152828=edit Bug 34094: Use DefaultPatronSearchMethod consistently This patch updates the patron search bar and pages to default search method to that defined by DefaultPatronSearchMethod system preference. Test plan 1) Prior to this patch confirm that regardless of what you set DefaultPatronSearchMethod to, the search in /members/member.pl, members/members-home.pl and the search from the patrons search top bar all default to 'contains'. 2) Apply the patch 3) Confirm that the system preference now affects the default option for match type upon page load. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Martin Renvoize changed: What|Removed |Added Attachment #152787|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 152827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152827=edit Bug 34094: Use DefaultPatronSearchMethod consistently This patch updates the patron search bar and pages to default search method to that defined by DefaultPatronSearchMethod system preference. Test plan 1) Prior to this patch confirm that regardless of what you set DefaultPatronSearchMethod to, the search in /members/member.pl, members/members-home.pl and the search from the patrons search top bar all default to 'contains'. 2) Apply the patch 3) Confirm that the system preference now affects the default option for match type upon page load. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #2 from quinn.mor...@citruslibraries.org --- Just for clarification, where would I put this information to try the fix? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 --- Comment #10 from Martin Renvoize --- Ah, that looks like a rebase error.. I think that particular line was removed in a recently pushed patch and then re-introduced here accidentally as part of a rebase. I will remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #48 from Nick Clemens --- (In reply to Pedro Amorim from comment #47) > I squashed more minor comment updates to the copy/paste fixes patch and kept > your signature in it Nick. Thanks for looking at this! Yeah, nice catch ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #47 from Pedro Amorim --- I squashed more minor comment updates to the copy/paste fixes patch and kept your signature in it Nick. Thanks for looking at this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim changed: What|Removed |Added Attachment #152822|0 |1 is obsolete|| --- Comment #46 from Pedro Amorim --- Created attachment 152826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152826=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm and TypeDisclaimer.pm Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #10 from Owen Leonard --- Created attachment 152825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152825=edit Bug 23059: (QA follow-up) Put status strings in a span No test plan. Read the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Owen Leonard changed: What|Removed |Added Attachment #151579|0 |1 is obsolete|| Attachment #152679|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 152824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152824=edit Bug 23059: reserve_stats.pl: Simplify reservestatus This patch does the following: [1] Go back to four statuses: Cancelled, Filled, Waiting or Placed. Placed is used as collective name for all other statuses: pending (placed), processing (found==P) or transit (found==T). Placed before anyway. [2] Allow translation of these statuses in the template. Remove the sub reservestatushuman. [3] The output of changeifreservestatus is considerably shorter and less ugly in the constructed sql statement. Test plan: [1] Use reservestatus as row, as column and only as filter (clicking few statuses). [2] Verify that the shown statistics meet your expectations. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||sama...@gmail.com --- Comment #2 from Sam Lau --- After I created the new notice template using the report option when I try to go to Reports and then select 'create from SQL', the page did not load and I'm left with this error: Could not compile /kohadevbox/koha/reports/guided_reports.pl: Can't locate Koha/TemplateUtils.pm in @INC (you may need to install the Koha::TemplateUtils module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/aarch64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/aarch64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/aarch64-linux-gnu/perl-base /usr/lib/aarch64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at /kohadevbox/koha/reports/guided_reports.pl line 41. BEGIN failed--compilation aborted at /kohadevbox/koha/reports/guided_reports.pl line 41. at /usr/share/perl5/CGI/Compile.pm line 144 It is also important to note that before creating a new notice template, the report page loads perfectly fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #45 from Nick Clemens --- Created attachment 152823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152823=edit Bug 33716: (QA follow-up) Fix styling for Type_disclaimer_date and Type_disclaimer_value on 'Request details' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #44 from Nick Clemens --- Created attachment 152822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152822=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #43 from Nick Clemens --- Created attachment 152821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152821=edit Bug 33716: (QA follow-up) Add atomic update file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #42 from Nick Clemens --- Created attachment 152820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152820=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #41 from Nick Clemens --- Created attachment 152819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152819=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #40 from Nick Clemens --- Created attachment 152818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152818=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #39 from Nick Clemens --- Created attachment 152817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152817=edit Bug 33716: Tests Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #38 from Nick Clemens --- Created attachment 152816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152816=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #37 from Nick Clemens --- Created attachment 152815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152815=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #36 from Nick Clemens --- Created attachment 152814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152814=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Nick Clemens changed: What|Removed |Added Attachment #151403|0 |1 is obsolete|| Attachment #151404|0 |1 is obsolete|| Attachment #151405|0 |1 is obsolete|| Attachment #151406|0 |1 is obsolete|| Attachment #151407|0 |1 is obsolete|| Attachment #151408|0 |1 is obsolete|| Attachment #151409|0 |1 is obsolete|| Attachment #151411|0 |1 is obsolete|| Attachment #152809|0 |1 is obsolete|| Attachment #152810|0 |1 is obsolete|| Attachment #152811|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 152813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152813=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #1 from Owen Leonard --- Created attachment 152812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152812=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #34 from Pedro Amorim --- Created attachment 152811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152811=edit Bug 33716: (QA follow-up) Fix styling for Type_disclaimer_date and Type_disclaimer_value on 'Request details' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #33 from Pedro Amorim --- Created attachment 152810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152810=edit Bug 33716: (QA follow-up) Fix copy/paste issues in Workflow.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #32 from Pedro Amorim --- Created attachment 152809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152809=edit Bug 33716: (QA follow-up) Add atomic update file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com Status|Needs Signoff |Failed QA --- Comment #9 from Sam Lau --- Hi Martin, I'm running into one main issue when trying this patch. After applying, all the search forms have the same method as expected, however, the patron table is not loading for me. Thus, none of the searches are giving me back any results. I was able to fix this issue by removing this line in koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: let filters = []; Upon removing this line, everything seemed to be working fine for me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33800] Error 500 in issues_stats.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800
--- Comment #5 from Marcel de Rooy ---
Here is a pointer:
$DBversion = '20.06.00.041';
if ( CheckVersion($DBversion) ) {
if ( column_exists( 'items', 'paidfor' ) ) {
my ($count) = $dbh->selectrow_array(
q|
SELECT COUNT(*)
FROM items
WHERE paidfor IS NOT NULL AND paidfor <> ""
|
);
if ($count) {
warn "Warning - Cannot remove column items.paidfor. At least one
value exists";
}
else {
$dbh->do(q|ALTER TABLE items DROP COLUMN paidfor|);
$dbh->do(q|UPDATE marc_subfield_structure SET kohafield = '' WHERE
kohafield = 'items.paidfor'|);
}
}
if ( column_exists( 'deleteditems', 'paidfor' ) ) {
my ($count) = $dbh->selectrow_array(
q|
SELECT COUNT(*)
FROM deleteditems
WHERE paidfor IS NOT NULL AND paidfor <> ""
|
);
if ($count) {
warn "Warning - Cannot remove column deleteditems.paidfor. At least
one value exists";
}
else {
$dbh->do(q|ALTER TABLE deleteditems DROP COLUMN paidfor|);
}
}
NewVersion( $DBversion, 26268, "Remove items.paidfor field" );
}
The field paidfor should not be present anymore.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33800] Error 500 in issues_stats.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800 Eugene Espinoza changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33800] Error 500 in issues_stats.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800 --- Comment #4 from Eugene Espinoza --- Marcel, Thanks for commenting! I am missing the paidfor column in my deleteditems table. As far as I can remember, we did not delete any columns in tables for this Koha instance. This Koha instance was upgraded from 20.11 then 22.11 then 23.05. I wander why the paidfor field was not included in the upgrade? Anyway closing this bug, as it is an isolated case. Thank you very much! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 --- Comment #7 from Marcel de Rooy --- It seems that Bootstrap does not respect the size attribute that is present on the number_of_copies input. There is a size="2" but it does not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard changed: What|Removed |Added Summary|Holds Cancellation Tab |Requested cancellation date |Configure Table Not in |column missing from holds |Order |awaiting pickup table ||config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Holds Cancellation Tab Configure Table Not in Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Version|22.11 |master OS|Windows |All Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 --- Comment #4 from Kyle M Hall --- > I can see that the patches are not finished yet, but wanted to give you an > early feedback anyway. I hope that helps Thanks for the feedback. I'm presuming that can_load is heavier than a query. I should test my assumptions. I also should implement caching per-method. I'm also leaning toward the the second patch being a bad idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146
--- Comment #6 from Marcel de Rooy ---
Someone removed this btw in js:
+
+if (f>99) {
+return confirm(_("More than 99 copies will be added. Should they be
added?"));
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34146] How to limit number of copies?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #13 from Lucas Gass --- Sorry for the confusion here. Thanks Martin and Pedro, the follow-up makes perfect sense to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
