[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 David Cook changed: What|Removed |Added Attachment #153022|0 |1 is obsolete|| --- Comment #34 from David Cook --- Created attachment 153023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153023=edit Bug 34064: Add SQL::Translator dependency to cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #33 from David Cook --- The API looks the same so maybe I will just downgrade it... https://metacpan.org/release/VEESH/SQL-Translator-1.63/view/lib/SQL/Translator/Diff.pm https://metacpan.org/release/ILMARI/SQL-Translator-0.11024/view/lib/SQL/Translator/Diff.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #32 from David Cook --- Worth noting that SQL::Translator 1.62 is available from Debian 11 and Ubuntu 20.04. While we've dropped Ubuntu 18.04 from https://wiki.koha-community.org/wiki/System_requirements_and_recommendations we haven't dropped Debian 10. While Debian 10 has passed it's normal EOL, it appears to have EOL LTS to 2024-06-30. This patch was tested against SQL::Translator 1.62, so that's what I've put into the cpanfile patch. -- We could either lower the cpanfile requirement to 0.11024 (the version in Debian 10 and Ubuntu 18.04) and test, or we could package SQL::Translator 1.62 for Debian 10 Buster. While the version numbers are very different, the changes don't look massive: https://metacpan.org/dist/SQL-Translator/changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #31 from David Cook --- Created attachment 153022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153022=edit Bug 34064: Add SQL::Translator dependency to cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #12 from David Cook --- (In reply to Katrin Fischer from comment #11) > Is this similar/same as bug 31168? Seems like a duplicate to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > (But to be fair, I think that this might actually be a problem with the > current db_revs system as well... I'd have to test it...) Actually, it might not be a problem with the current version, because db_revs also check their version against the database version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #26 from David Cook --- (In reply to Julian Maurice from comment #18) > Sequence does matter indeed. But there are several different valid sequences > of execution. > You can't write a migration to add a FK to a table before the migration to > add the table has been written, so the timestamp for the FK migration will > always be after the timestamp for the table migration. So these two > migrations will always be executed in the correct order. > But if you have a migration that adds a column to table A and another > migration that adds a column to table B, the order of execution of these two > migrations does not matter. I understand your logic here, but I just wonder if you're missing some scenarios. I'm struggling to think of them, but there's just something bothering me in the back of my mind. At the moment, I wonder about backporting causing problems... Scenario: Version 23.05 and Master - Bug 1 : Add column A to Table A Master: - Bug 2 : Modify Column A in Table A - Bug 3 : Drop Column A in Table A 23.05: - Bug 3 : Drop Column A in Table A (backported) -- When you upgrade from 23.05 to 23.11, the migration for Bug 2 will exist on the file system, but it won't be marked as executed in the database, so Koha will try to apply the migration for Bug 2, and it should generate an error. (But to be fair, I think that this might actually be a problem with the current db_revs system as well... I'd have to test it...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #25 from David Cook --- (In reply to Julian Maurice from comment #17) > (In reply to Julian Maurice from comment #14) > > It would be interesting to see how much time it takes to process a directory > > of 100, 1000 and 1 entries (we are getting close to 1500 updates > > actually in master) > > Just ran a quick test: > > Time to execute pending_migrations with an empty executed_migrations table > and: > - 100 migration files: <1ms > - 1000 migration files: ~1.2ms > - 1 migration files: ~6ms > > Time to execute pending_migrations with a full executed_migrations table and: > - 1000 migration files: ~1.6ms > - 1 migration files: ~12ms > > Note that I got these times with two small modifications I made to > pending_migrations, which I will submit with the rebased patch, they save a > few ms in the "1 files" test. > > One way to avoid slowdowns as the number of files grows is to check for > pending migrations only once at the start of the application, and not at > every request. I'm a bit surprised that pending_migrations ran that fast. It takes me a lot longer just to load C4::Context and get a database handle via C4::Context->dbh on koha-testing-docker. Did you run that on koha-testing-docker or on a server? -- Regarding only checking for migrations at the start of the application, that's a good point. I've noticed that's what other (persistent) applications do as well. I think we have consensus at this point that Koha should always be run persistently, so I think that is a reasonable move to make. That said, I'm less worried about slowdowns with the web UI vs updatedatabase.pl, since updatedatabase.pl is where I notice the worst performance impacts when installing a new koha-common package. What do you think about bug 34088 in this context? If the code version and the database version match and there are no atomic updates to run, it exits out of updatedatabase.pl. Koha::Migrations does look pretty minimal, but I found C4::Context to be too slow, so I used Koha::Database::dbh() and Koha::Config for a database handle and config since they were much faster to load and use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #9 from David Cook --- For what it's worth, I'm locally going to drop it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor and deleteditems.paidfor still sometimes exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 David Cook changed: What|Removed |Added Summary|items.paidfor haunting |items.paidfor and |beyond the grave|deleteditems.paidfor still ||sometimes exist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor haunting beyond the grave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #8 from David Cook --- Of course, as soon as I do that, I notice that some databases also still have deleteditems.paidfor... but some don't. Think we just need to re-blitz paidfor across both tables... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor haunting beyond the grave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #7 from David Cook --- Actually you know what... while the data might be in the database, I don't see a place where it gets surfaced, so for all intents and purposes... it doesn't really exist. So maybe we do just drop it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor haunting beyond the grave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > (In reply to Jonathan Druart from comment #4) > > The easiest way forward is to simply drop the column. > > True but that would lead to data loss. > > I'm scanning through databases now and most only have data in single/double > digit numbers of items, but I see a few that have thousands of rows of > data... That said, as I look through it, it mostly looks like garbage data... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor haunting beyond the grave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #4) > The easiest way forward is to simply drop the column. True but that would lead to data loss. I'm scanning through databases now and most only have data in single/double digit numbers of items, but I see a few that have thousands of rows of data... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 --- Comment #7 from David Cook --- I'm keen to QA this one, so I'm just waiting for someone else to sign it off. We've been setting up a lot more SMTP lately. I'm curious to compare the speed of Email::Sender::Transport::SMTP vs Email::Sender::Transport::SMTP::Persistent as well. I suspect that the latter will be much nicer for performance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34198] Interface to define relational rules for MARC fields that use authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34198 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26977] Update Koha Documentation to use absolute paths instead of relative ones
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26977 --- Comment #5 from David Cook --- (In reply to Rex Barkdoll from comment #2) > With Koha, I've had to go to multiple sources and 3rd-party documentation > (like Koha geek) to get answers and tutorials to things that really should > have been in the official documentation/manual (initial setup, importing a > previous koha database, setting up cron tasks, tutorials on XSLR > modifications, detailed guides on building reports, etc). What if Koha geek > or other third-party resources go away one day? Overall, documentation can always be improved but time is money and money is limited. Installation and initial setup should be covered by https://wiki.koha-community.org/wiki/Koha_on_Debian via https://koha-community.org/documentation/ XSLT modifications would be for advanced users. I'd expect advanced users would be the ones to offer tutorials. That's outside the scope of Koha developers. There's a number of resources for building reports listed in the Reports module including http://schema.koha-community.org/22_11 and http://wiki.koha-community.org/wiki/SQL_Reports_Library Finally there are a number of free and paid options for support found at https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26977] Update Koha Documentation to use absolute paths instead of relative ones
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26977 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- Looking at https://koha-community.org/manual/latest/en/html/cron_jobs.html I see the following: "The locations below assume a development install which puts the crons in misc/, if you have a standard install you may want to look in bin/ for these files if you cannot find them in misc/" That could probably be tweaked to something like: "The locations in the documentation assume a development install where files are found in misc/ relative to the git root checkout. If you have installed using Debian packages or the standard install from source, you will want to look for files in /usr/share/koha/bin/. Other locations are possible with other installation methods." -- FYI for anyone with shell access using Debian packages, the following command is an easy way to find files installed by a Debian package: dpkg -L koha-common This provides a comprehensive listing of the files installed by the koha-common package. You can then easily find the file from there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27909] When upgrading, old sysprefs are only copied in english news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27909 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > I believe this has moved into WONTFIX territory due to age and versions > having moved on. If we now migrate other contents, we can use the since > added default value instead of making copies for multiple languages. I had been wondering about this as I've noticed a lot of my instances migrating to "English" instead of "Default" which has been a pain... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34198] Interface to define relational rules for MARC fields that use authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34198 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34198] New: Interface to define relational rules for MARC fields that use authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34198 Bug ID: 34198 Summary: Interface to define relational rules for MARC fields that use authorised values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We have a case where a set of MARC tags use authorised values i.e. 902$a, 902$b, 902$c, 902$d. Each of these subfields will use different authorised values. We'd like the authorised values displayed for 902$b to change depending on how 902$a is set. For example, if 902$a is set to a specific value, then the irrelevant options for 902$b should be hidden so they can't be selected. This might go on i.e. the values for 902$c are then dependent on the setting of 902$b. These rules would need to be editable by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #14 from Pablo AB --- Not sure if it's still mandatory to run before the update the `DELETE FROM borrower_relationships WHERE guarantor_id IS NULL`, but the errors still happen on the same upgrade, from 22.05 to 22.11, but on Installer.pm line 741. The procedure continues till the end, resulting in a broken Koha. If I understand Katrin Fischer comment 7 correctly, these issues shouldn't happen. Now rereading Gass comment 13, "Missing dependencies for 22.05.x, no backport". Why this issue is marked as RESOLVED, if aims directly to 22.05? If the DELETE query solve the issue, couldn't the installer do it transparently? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26917] Searching for patrons: member.pl vs circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26917 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This behaviour has now changed as now we always use the patron module search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26977] Update Koha Documentation to use absolute paths instead of relative ones
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26977 --- Comment #3 from Caroline Cyr La Rose --- Is this the actual sentence to be added? "Depending on your installation method and OS, this files will most likely be found in /usr/share/koha/... OR in /etc/koha/... You can also perform a simple find search if they are not located in either of these directories." I don't have the experience to know where they normally should be. Mine are literally in the root git directory, in misc/cronjobs/... so, exactly what it says in the manual. I don't mind adding the sentence to the manual, but it needs to be dictated to me :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26934] SIP2 allows checkin of already checked in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26934 --- Comment #1 from Katrin Fischer --- I am not sure this would be the intended behaviour. In the staff interface multiple checkins just generate a note, but you are not blocked from doing it. If the patron checks it in multiple times, it doesn't seem to cause harm. It might also happen accidentally by moving the item in and out of the reader's field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26977] Update Koha Documentation to use absolute paths instead of relative ones
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26977 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs documenting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26980] UNIMARC_sync_date_created_with_marc_biblio.pl is setting MarcFieldForModifierName to CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26980 --- Comment #1 from Katrin Fischer --- Hi Didier, can you explain this in a bit more detail? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26981] Writing off Accruing Fines causes another accruing fine to appear at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26981 Katrin Fischer changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Martin Renvoize from comment #1) > I'm struggling to replicate this.. was it really only on 20.05 or could you > also replicate it on master? We had no other reports of this, neither has it been confirmed. 20.05 is no longer maintained. Marking WORKSFORME. Please reopen if this bug is still present for you in maintained versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27893 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Delete of biblio with order does not always warn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10869 --- Comment #6 from Katrin Fischer --- Blocking the deletion might no longer be the desirable or necessary action here. We still need to resolve bug 10869, but with bug 33262 now pushed, we have much better means to fix any remaining issues with deleted records in the acq module. Should we try and move this back to a warning and NSO? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27895] Internal server error when trying to change pickup location for a hold with no valid locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895 --- Comment #4 from Katrin Fischer --- Nick, can you have a look at the patches attached here please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27909] When upgrading, old sysprefs are only copied in english news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27909 Katrin Fischer changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I believe this has moved into WONTFIX territory due to age and versions having moved on. If we now migrate other contents, we can use the since added default value instead of making copies for multiple languages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27919] Split claims return from LOST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Katrin Fischer changed: What|Removed |Added Version|20.05 |master Summary|Split Claims Return from|Split claims return from |LOST|LOST -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27934] Table sorting using title-string option is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934
--- Comment #13 from Katrin Fischer ---
It looks like we sill got some remaining title-string attributes:
koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc:{
"targets": [ "title-string" ], "type": "title-string" },
koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt:
Earliest recall
date
koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_to_pull.tt:
{ "sType": "title-string", "aTargets" : [ "title-string" ] },
koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt:
Available since
koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt:
Available since
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34197] New: UI enhancement in vendor form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34197 Bug ID: 34197 Summary: UI enhancement in vendor form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When adding a vendor, you can add contacts for this vendor. In the contact form, there is a list of checkboxes where some are about acquisitions and some are about serials, mixed together. I wonder if it would be possible to change this into either two columns or two sub-sections, separating the acquisitions and serial options? Acquisitions options: - Primary acquisitions contact - Contact when ordering? - Contact about late orders? Serials options: - Primary serials contact - Contact about late issues? I always find it weird to explain in training, this one is for acquisitions and this one is for serials and this one is for acquisitions, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27957] Attributes removed in LDAP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27957 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #9 from Katrin Fischer --- Shoudl this have been marked as NSO? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34187] OPAC advanced search should default to "Fewer options"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34187 --- Comment #3 from Katrin Fischer --- No error at all - if that helped I a glad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28323] Invalid record in sample data leading to error when displaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28323 --- Comment #3 from Katrin Fischer --- Is there a more elegant way then deleting it by SQL when you need to reindex? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34196] New: UI adjustment to aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34196 Bug ID: 34196 Summary: UI adjustment to aqbudgets Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org Created attachment 153021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153021=edit Screenshot showing which title to change When viewing funds in acquisitions administration, there is a filter box on the left of the screen. The "title" of this box is... underwhelming? It looks like there is a style missing. To access: 1. Go to Administration > Funds --> On the left, there is a white box with a title "Fund filter", and just above that box is a "Filters" title that doesn't look like it has any styling. I have added a screenshot with an arrow pointing to the "Filters" title, in case my description is not clear. Since the box already has a title "Fund filter", the "Filters" title could be removed. Or the "Refine your search" box when viewing search results could be an example to follow. It tops the box in green. To access: 1. Make a search in the catalog --> On the left, above the facets is the "title" of the box -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #24 from Katrin Fischer --- (In reply to Julian Maurice from comment #23) > (In reply to Katrin Fischer from comment #22) > > How and when is the timestamp set? > > The timestamp is in the filename (e.g. 20230704114126-add-syspref.pl if you > create the file on 2023-07-04 at 11:41:26) But I don't know when it will be pushed, to renaming will be necessary for the RM like they do now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 Michaela Sieber changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33787] Remove option to archive system debit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Bug 33787 depends on bug 32450, which changed state. Bug 32450 Summary: Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32751] [Omnibus] Extend, improve and standardize additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 Bug 32751 depends on bug 11844, which changed state. Bug 11844 Summary: Additional fields for order lines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11870] Add more information to histsearch.pl results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Bug 11870 depends on bug 11844, which changed state. Bug 11844 Summary: Additional fields for order lines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34195] New: Import from List into ERM Title should warn you it is overwriting the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34195 Bug ID: 34195 Summary: Import from List into ERM Title should warn you it is overwriting the record Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.fi...@ptfs-europe.com CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, pedro.amo...@ptfs-europe.com In ERM Local Titles (cgi-bin/koha/erm/eholdings/local/titles) if you import from a List and that list has full MARC records, the creation of the ERM titles uses the data it can extract from the MARC records but then overwrites the source title. This means you may actually loose data in your MARC record because some of the data is not mapped. We should either retain the full MARC infomation from the original record or at least warn the user that they could potentially loose MARC data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #9 from Pedro Amorim --- This last patch removes the change from EHoldingsEBSCOPackagesList.vue (not needed, that column is not searchable or sortable). And also added the same behavior to EHoldingsLocalTitlesList.vue for consistency (was not possible to filter by id in titles list before, even though it shows, like other tables). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Pedro Amorim changed: What|Removed |Added Attachment #153019|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 153020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153020=edit Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #92 from Jonathan Druart --- (In reply to David Cook from comment #91) > (In reply to Jonathan Druart from comment #90) > > (In reply to David Cook from comment #89) > > > What's outstanding on this one? > > > > Read the commit messages. > > I did and I couldn't make sense of them. Ok, trying to be more verbose then. 1. For discussion, waiting for review and feedback: (In reply to Jonathan Druart from comment #82) > Created attachment 150929 [details] [review] > Bug 17427: HACKY - force new session > > Look at Data::Session->new, it's calling $self -> load_session; > Then look at load_session then user_id > => we are retrieving the ID from the cookie > > But in our Auth.t tests we are mocking CGI->cookie to always return the > previous CGISESSID > > We should certainly adjust the test here, and remove this patch. > > 194 # Note: We can test return values from checkauth here since we > mocked the safe_exit after the Redirect 303 > 195 is( $return[0], $patron2->userid, 'Login of patron2 approved' ); > 196 isnt( $return[2], $sessionID, 'Did not return previous session > ID' ); > 197 ok( $return[2], 'New session ID not empty' ); What do you think about this, should we adjust the test? 2. The behaviour is buggy, see the following comment: (In reply to Jonathan Druart from comment #86) > (In reply to Jonathan Druart from comment #73) > > Created attachment 150638 [details] [review] [review] > > Bug 17427: Retrieve sessionID from HTTP_COOKIE > > > > To make some tests pass (t/db_dependent/Auth.t) and mimick what did > > CGI::Session, but that is certainly useless and the tests should be > > adjusted. > > This patch fixes some tests but make the sessionID handling very wrong. We > always end up with the same sessionID (even after logout, change user, etc.) > > I think we should revert it and remove the related tests. Do you agree that we should remove the related tests? 3. This needs to be fully tested, but first we need to fix the failures and bugs highlighted in 1 and 2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #7 from Pedro Amorim --- (In reply to Jonathan Druart from comment #4) > Then you are removing the ability to filter by id on the column (where we > show it). > The correct fix I think is to put the id after the name: > > -data: "me.agreement_id:me.name", > +data: "me.name:me.agreement_id", You're right, thank you! I'm not sure we need the change on EHoldingsEBSCOPackagesList.vue though, it's not searchable or orderable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Pedro Amorim changed: What|Removed |Added Attachment #152622|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 153019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153019=edit Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34063] items.paidfor haunting beyond the grave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34063 --- Comment #4 from Jonathan Druart --- The easiest way forward is to simply drop the column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Jonathan Druart changed: What|Removed |Added Severity|normal |enhancement --- Comment #13 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #12) > This feels like an enh? Am I correct? Yes, adjusted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #26 from Jonathan Druart --- Independent QA missing here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34113] Replace the use of jQueryUI autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34113 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- Linking to bug 29222 comment 3 and bug 29222 comment 4, and https://gitlab.com/joubu/Koha/-/commits/bootstrap-autocomplete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #22 from Jonathan Druart --- Quick note: bug 33953 introduces Koha::Biblio->ratings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29633] Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29633 --- Comment #2 from Jonathan Druart --- Yes, the suggestion is still valid and can still be implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #12 from Michaela Sieber --- (In reply to Jonathan Druart from comment #0) > On bug 25655 we stored the invoice currency and invoice price. The "change > currency" checkbox should be checked only if the previous order (in case of > partial receives) had it checked. I agree. And you fixed that with the existing patch (2023-05-30) BUT : if you uncheck the 'change currency' this does not trigger a change of the invoice_currency back to the "normally" (=active) used currency in the system. If you want to switch back to the active system currency you first have to select that currency from the drop down and THEN deactivate the checkbox 'Change currency' This behavior requires very good documenting! The use case could be a vendor change of a standing order (e.g. for serials) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17620] Fix format of date/data-times in Swagger definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #6 from Jonathan Druart --- Yes, this is fixed now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 --- Comment #27 from Jonathan Druart --- (In reply to Fridolin Somers from comment #26) > Interresting. > > Maybe a silly question : > why not caching entire Koha::Patron object in > CanBookBeReserved/CanItemBeReserve ? "entire"? What do you mean? The unblessed/hash version? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34178 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32476 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #24 from Jonathan Druart --- Created attachment 153018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153018=edit Bug 32496: Some fixes This can be squashed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Jonathan Druart changed: What|Removed |Added Attachment #150614|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 153017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153017=edit Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/api/v1/return_claims.t t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Reserves.t t/db_dependent/HoldsQueue.t t/db_dependent/selenium/regressions.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Plugins/Recall_hooks.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Circulation/_CalculateAndUpdateFine.t Sponsored-by: Gothenburg University Library Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #53 from Jonathan Druart --- There are a couple of warnings t/db_dependent/api/v1/checkouts.t .. 7/101 Argument "1672:1738:confirm1:confirm2:please" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Token.pm line 298. Argument "1672:1738:confirm1:confirm2" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Token.pm line 298. t/db_dependent/api/v1/checkouts.t .. 100/101 Argument "1674:1739:confirm1:confirm2" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Token.pm line 298. Argument "1674:1739:confirm1:confirm2:please" isn't numeric in numeric eq (==) at /kohadevbox/koha/Koha/Token.pm line 298. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #10 from Jonathan Druart --- What about my patch here? Should I obsolete it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974
--- Comment #19 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #18)
> You broke t/db_dependent/Koha/REST/Plugin/Objects.t
Can't use string ("+name,-country") as an ARRAY ref while "strict refs" in use
at /kohadevbox/koha/Koha/R
EST/Plugin/Objects.pm line 165.
And lot of others.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 --- Comment #18 from Jonathan Druart --- You broke t/db_dependent/Koha/REST/Plugin/Objects.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336
--- Comment #52 from Jonathan Druart ---
C4::Circ
1536 # get actual issuing if there is one
1537 my $actualissue = $item_object->checkout;
1549 $issue = Koha::Checkouts->find( { itemnumber =>
$item_object->itemnumber } );
1549 should call ->checkout as well
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28184] Terminology: Edit or Modify on forms for changing information in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28184 --- Comment #2 from Caroline Cyr La Rose --- I can help for the modifications too. Not being a native English speaker, I can't really help in choosing the term... 'Edit' seems to flow more easily in my ears, but it's probably because in French it's 'Modifier' so Modify just seems like a copy of the French word ;) Or maybe one is American English and the other UK English, and I'm more used to American English... Some references that I found, but nothing is conclusive... I think we just have to choose one and stick with it. https://english.stackexchange.com/questions/42032/is-there-a-difference-of-meaning-between-edit-and-modify-in-this-context https://ux.stackexchange.com/questions/8837/difference-between-modify-and-edit-buttons https://www.merriam-webster.com/dictionary/edit 1c: to alter, adapt, or refine especially to bring about conformity to a standard or to suit a particular purpose https://www.merriam-webster.com/dictionary/modify 3a: to make minor changes in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 --- Comment #15 from Jonathan Druart --- This patch broke patrons_search.t # Failed test at t/db_dependent/selenium/patrons_search.t line 247. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 15 of 26 entries (filtered from 80 total entries)' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #54 from Jonathan Druart --- Sorry Martin, this needs another rebase (bug 34092). Does not seem hard but not trivial. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #25 from Jonathan Druart --- Created attachment 153016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153016=edit Bug 33404: Add unit tests Test plan: Run t/db_dependent/Breeding.t Run t/db_dependent/Breeding_Auth.t Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Amended patch: perltidy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #24 from Jonathan Druart --- Created attachment 153015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153015=edit Bug 33404: Fix serverhost and init $page The array serverhost is not filled. Should be replaced with values from servers array. Test plan: Nothing exciting here. Read the patch. Note that we will test in the next patch if the hostname is saved correctly in the import batch. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Jonathan Druart changed: What|Removed |Added Attachment #151868|0 |1 is obsolete|| Attachment #151869|0 |1 is obsolete|| Attachment #151870|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 153014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153014=edit Bug 33404: Z3950SearchAuth: Save in UTF-8 encoding Test plan: [1] If you have access to a Z3950 MARC8 auth server, search for an authority record and import it. [2] If you have access to a Z3950 UTF8 auth server, search for an authority record and import it. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #58 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #44)
> This was my add contents test table:
>
> | news| News_1 | NULL |
> | news| News_2 | NULL |
> | html_customizations | CatalogConcernHelp_1 | NULL |
> | html_customizations | CatalogConcernTemplate_1 | NULL |
> | pages | opac_only_5 | NULL |
> | pages | opac_only_5 | NULL |
> | pages | staff_only_7 | CPL|
> | pages | staff_only_7 | CPL|
> | pages | staff_only_7 | CPL|
> | news| News_1 | NULL |
> | news| News_2 | NULL |
> | news| News_2 | NULL |
> | news| News_13 | CPL|
> | news| News_13 | CPL|
> | html_customizations | CatalogConcernTemplate_1 | NULL |
>
> After all contents has been copied to localization, you try to add UNIQUE
> constraint on the above data. Which obviously does not work. Since you did
> not delete the double entries in additional_contents.
Should be fixed in the last patch. Didn't catch it because I was no using a
specific branchcode I guess (NULL).
(In reply to Marcel de Rooy from comment #43)
> (In reply to Marcel de Rooy from comment #42)
> > (In reply to Marcel de Rooy from comment #41)
> > > Main thing I still want to do, is test the dbrev a bit better than I did
> > > at
> > > first.
> >
> > First test crashes:
> > Added new table 'additional_contents_localizations'
> > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
> > 'pages-staff_only_7-CPL' for key 'additional_contents_uniq' at
> > /usr/share/koha/C4/Installer.pm line 741
>
> I would suggest to put the logic in a txn_do because I ended up now with a
> half conversion of data.
We run dbrevs in a transaction already but the DBMS will implicitly commit for
CREATE/ALTER/DROP/etc statements (yes, that's bad).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #57 from Jonathan Druart --- Created attachment 153013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153013=edit Bug 31383: Fix dbrevs We need to remove duplicate entries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #56 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #53) > Created attachment 152668 [details] [review] > Bug 31383: Use one query in search_for_display instead of four > > Benchmarking does however not show real performance gain. > But it might be considered as a code improvement? I am expecting faster results without this patch. If we want to keep it we need to remove the following statement: use Array::Utils qw( array_minus ); (In reply to Marcel de Rooy from comment #54) > Created attachment 152669 [details] [review] > Bug 31383: Fix URLs on staff AC detail view IMO we should move this to its own bug report as it's a behaviour change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Marcel de Rooy changed: What|Removed |Added Attachment #152991|0 |1 is obsolete|| --- Comment #38 from Marcel de Rooy --- Created attachment 153012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153012=edit Bug 18855: Don't create duplicate overdue fines if an issue is returned This includes Jonathan's followup If cronjobs/fines.pl is running during circulation hours, then an issue may be considered for having it's overdue fine updated after the issue has been returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'. In this case UpdateFine will create a duplicate fine because it can't find the specific accountline for the (formerly) overdue issue. This changes cronjobs/fines.pl to double check the issue before updating the fine. If the issue has changed between starting the script and updating the fine, then the script will skip it. There is a small amount of time between the check and calling UpdateFine where the issue can be changed and this problem can reoccure. The chance of that happening is so small that it's probably fine to leave as is. It is also possible that the fine won't be updated because the issue was returned. In this case the fine payed by the patron will be lower, but that is better then the patron finding later that there is more to a fine they thought they had paid all of. Test plan (by Caroline): 0. Preliminary settings 0.1. finesMode system preference must be set to Calculate and charge 0.2. There must be a circulation rule that will charge fines (beware of bug 32271) 0.3. In Tools > Calendar, today must not be a holiday 1. Make a lot of overdue checkouts - I used the batch checkout feature, but if your system already has a lot of overdue checkouts, you can skip to step 2 1.1. Enable batch checkouts 1.1.1. Go to Administration > Global system preferences 1.1.2. Search for BatchCheckouts 1.1.3. Set BatchCheckouts to Allow 1.1.4. Select all categories in BatchCheckoutsValidCategories 1.1.5. Click "Save all Circulation preferences" 1.2. Get a list of barcodes 1.2.1. Go to Reports 1.2.2. Click "Create from SQL" 1.2.3. Give the report a name 1.2.4. For the SQL query, enter SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60; 1.2.5. Click "Save report" 1.2.6. Click "Run report" 1.2.7. Click "Download" > "Tab separated text" 1.3. Go to a patron's file 1.3.1. Go to Patrons 1.3.2. Click on "Search" 1.3.3. Click on a patron's name 1.4. Do a batch checkout with a due date in the past 1.4.1. Click on the "Batch check out" tab on the left 1.4.2. In "Use a file", click "Choose file" 1.4.3. Choose the file downloaded from the report 1.4.4. In "Hard due date", choose a date in the past 1.4.5. Click "Check out" 1.4.6. Click "Checkout or renew" 2. Find the last issue in the database 2.1. In the database (or in reports), type the following query SELECT issues.*, items.itype as itemtype, items.homebranch, items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM issues LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G; 2.2. Copy the barcode from the last entry 3. Set up so that you can run fines.pl and check in the item at the same time (or very close to the same time) 3.1. In Koha, click the "Check in" option in the search bar at the top of the page 3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW RIGHT AWAY 3.3. In a terminal, enter the fines.pl command ./misc/cronjobs/fines.pl 3.4. Execute the command and immediately click on the arrow in the staff interface to check in the item 4. Check the patron's fines 4.1. Click on the patron's name in the check in screen 4.2. Go to the Accounting tab on the left 4.3. In the search box just above the table, paste in the returned item's barcode --> Without the patch, there are two fines, one Fine (Accruing) and one Fine (Returned) for the same item at the same time --> With the patch, there is only one fine, Fine (Returned) Signed-off-by: Sam Lau Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #30 from Marcel de Rooy --- (In reply to David Cook from comment #28) > At the moment "libtest-dbix-class-perl" is a dependency of koha-common, but > it's one that I'd like to remove one day, so it's worth adding > "libsql-translator-perl" as a Koha dependency. Just do it. Love to hear that :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Jonathan Druart changed: What|Removed |Added Severity|normal |major CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #231 from Jonathan Druart ---
See bug 34155, OPAC item level holds="force" is broken
in opac-reserve.pl:
495 $biblioLoopIter{force_hold} = 1 if $opac_hold_policy eq
'F';
But we are ignoring this with the change in "24860: Add ability to select an
item group when placing a hold - OPAC"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --- Comment #7 from Jonathan Druart --- We could test if the column is empty, but this leads to problem in the past. I am in favor of dropping the column. There are release notes and backups to prevent data loss. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 --- Comment #6 from Jonathan Druart --- Created attachment 153011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153011=edit Bug 33379: DBIx changes Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Jonathan Druart changed: What|Removed |Added Attachment #152770|0 |1 is obsolete|| Attachment #152771|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 153010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153010=edit Bug 33379: Remove virtualshelfcontents.flags This field is unused. A historic leftover from 2000-2010. Test plan: Run dbrev. Run prove t/db_dependent/Koha/Virtualshel* Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34194] New: Not able to search a Book via 'Search a Catalogue' option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34194 Bug ID: 34194 Summary: Not able to search a Book via 'Search a Catalogue' option Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: vidya.kajb...@trigyn.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When I am trying to search a book using the search option via 'Search a Catalogue', it does not display results. It throws an error "No results found No results match your search for 'kw,wrdl: phr="engineering"'. Even if I search without using phr= , it does not display the results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #10 from Jonathan Druart --- Created attachment 153009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153009=edit Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Jonathan Druart changed: What|Removed |Added Attachment #153008|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #5 from Jonathan Druart --- Created attachment 153008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153008=edit Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #9 from Jonathan Druart --- Key is missing on the auth screen: https://snipboard.io/PlARWt.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
