[Koha-bugs] [Bug 34220] Running log viewer for only Catalog module loads wrong side navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34220 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34220] Running log viewer for only Catalog module loads wrong side navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34220 --- Comment #1 from Lucas Gass --- Created attachment 153206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153206=edit Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34220] Running log viewer for only Catalog module loads wrong side navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34220 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 --- Comment #2 from Lucas Gass --- Created attachment 153205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153205=edit Bug 34233: Move select2 include out of patron-search.inc 1. Apply patch 2. Place a hold and make sure the patron pickup locations are populating correctly again/ 3. Work through the test plan on Bug 28726 to make sure it still works. 4. Enable ArticleRequests, make sure you can still do a patron search there. 5. Do a patron search from members.tt, make sure that still works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Lucas Gass changed: What|Removed |Added Blocks||34233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 [Bug 34233] Pickup location pulldowns in request.pl are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Depends on||28726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 [Bug 28726] Add sort1 and sort2 to patron card creator patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Lucas Gass changed: What|Removed |Added Blocks|34233 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 [Bug 34233] Pickup location pulldowns in request.pl are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Depends on|28726 | --- Comment #1 from Lucas Gass --- This is being caused by Bug 28726. I think it is because we are now using [% INCLUDE 'select2.inc' %] in request.tt and inside the include 'patron-search.inc'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 [Bug 28726] Add sort1 and sort2 to patron card creator patron search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Lucas Gass changed: What|Removed |Added Blocks||34233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 [Bug 34233] Pickup location pulldowns in request.pl are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Depends on||28726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 [Bug 28726] Add sort1 and sort2 to patron card creator patron search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34234] Item groups dropdown in detail.tt modal does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Emily Lamancusa changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34232 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Emily Lamancusa changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34234 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34234] New: Item groups dropdown in detail.tt modal does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34234 Bug ID: 34234 Summary: Item groups dropdown in detail.tt modal does not respect display order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: 1. EnableItemGroups 2. Find a record and add some new item groups with display orders that are different from the order in which the groups were added 3. Check the checkbox next to one or more items and click the link to "Add/move to item group" 4. Notice that the values in the dropdown do not respect the display order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Emily Lamancusa changed: What|Removed |Added Attachment #153203|0 |1 is obsolete|| --- Comment #2 from Emily Lamancusa --- Created attachment 153204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153204=edit Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] New: Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Bug ID: 34233 Summary: Pickup location pulldowns in request.pl are blank Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com There seems to be an issue with populating the pickup location pulldowns in request.pl in master. If you go to a bib record and try to place a hold, the pickup location pulldowns for both record-level and item-level holds are blank. The pulldown to change pickup location for existing holds is blank as well. Attempting to place a hold will succeed in placing a hold at the default pickup location despite the blank pulldown. The pulldown to change pickup location on moremember.pl works normally. I've replicated this on KTD and a sandbox with default settings, but no idea what's causing it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 --- Comment #1 from Lucas Gass --- Created attachment 153203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153203=edit Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] New: Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Bug ID: 34232 Summary: Item groups dropdown on additem.tt does not respect display order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Kyle M Hall changed: What|Removed |Added Attachment #151504|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 153202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153202=edit Bug 33776: Additional default plugin repo in koha-conf-site.xml.in Solutions inLibro started formating its repository to be found by Bug 23975. This patch adds it to the default list in the config template. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 Kyle M Hall changed: What|Removed |Added Attachment #150528|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 153201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153201=edit Bug 31339: Add staff wrapper template include for tool plugins This change adds a template include which can be used as a WRAPPER for tool plugins, which makes it easy to pages in tool templates without having to copy and maintain a lot of template boilerplate. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31498] Allow for custom primary contact method values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 --- Comment #20 from Christopher Brannon --- I think authorized values are the way to go. No hard coded values. Unless something is going to be tied to some automatic function down the road, and as long as this is informational only, admins can put whatever they want. However, if the goal is to tie this somehow to fields that have been filled out, maybe the choices are automatically filled in based off what contact methods have been filled out, and the authorized values is supplemental only. I would be in favor of the second choice, because it would automatically list what has only been supplied, and you only need to add what isn't usual or always want. However, I understand that this would make this a more challenging project. Plus, what happens if one of the built-in methods is selected and the patron has removed that method? Does it default to something else? If the second option is too difficult to implement, then I would definitely just go with the first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31498] Allow for custom primary contact method values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 --- Comment #19 from Lucas Gass --- Also, adding values like 'Do not contact' will be confusing. Patrons will assume that marking themselves as 'Do not contact' will mean they will not be notices. As stated previously this field is simply informational. Marking oneself as 'Do not contact' will have no bearing on whether or not one receives a notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31498] Allow for custom primary contact method values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 --- Comment #18 from Lucas Gass --- I don't know where to take this now. A couple of options have been mentioned: -Go the debit types route, making this its own page. Is that better for translations? -Make it a free text field. I took on this bug because I have had many requests to add custom values and requests to eliminate the current hard coded ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Attachment #153193|0 |1 is obsolete|| --- Comment #44 from Emily Lamancusa --- Created attachment 153200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153200=edit Bug 16122: Add display and increment localuse Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Attachment #150693|0 |1 is obsolete|| --- Comment #43 from Emily Lamancusa --- Created attachment 153199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153199=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Attachment #150234|0 |1 is obsolete|| --- Comment #42 from Emily Lamancusa --- Created attachment 153198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153198=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Christopher Brannon Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Attachment #150233|0 |1 is obsolete|| --- Comment #41 from Emily Lamancusa --- Created attachment 153197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153197=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Attachment #150232|0 |1 is obsolete|| --- Comment #40 from Emily Lamancusa --- Created attachment 153196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153196=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Sam Lau changed: What|Removed |Added Attachment #153191|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 153195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153195=edit Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add pattern check for monetary fields to acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #1 from Katrin Fischer --- This could be a quick fix while we work on 34231. Joubu suggested using a CSS class and adding the pattern check with jQuery in the global .js file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add pattern check for monetary fields to acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34231 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34231 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34231 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34231 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34231] New: Allow different input formats for monetary values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34231 Bug ID: 34231 Summary: Allow different input formats for monetary values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com, michaela.sie...@kit.edu, tomasco...@gmail.com There are several bugs already about this, but after discussing with Joubu and Tomas today I think it deserves a fresh start. On bug 30718 Jonathan wrote: > "Show the user a readable date (as per altFormat), but return > something totally different to the server." > > It's actually an option we want to use for all our dates, that will > reduce a lot the overhead in our controllers. And we should use the same approach for dealing with monetary amounts in patrons/account and in the acquisition module. Using a client side solution we avoid having to touch the .pl scripts and it will also make it easier to work with the API. We'd have 2 input fields, one hidden, with the 'raw' data in the expected database format, and one visible input field for entering and displaying the 'formatted' data. When sending the data to the server, only the 'raw' data will be processed. To explain the need/use case: At the moment we don't have any validation on input fields in the acquisition module and that leads to input errors that can have dire consequences. 1,00 might be turned into 100 or 1000 or just end up as an empty field. We also only allow the 'US' format with decimal dot, but not the French/German format of decimal comma. This is also a usability issue as keyboard with German layout don't have a . in the number block, only a comma. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Emily Lamancusa changed: What|Removed |Added Attachment #151997|0 |1 is obsolete|| --- Comment #4 from Emily Lamancusa --- Created attachment 153194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153194=edit Bug 33898: background_jobs_worker.pl may leave defunct children processes for extended periods of time It appears that the background jobs worker can leave defunct processes for periods of time. Though it is mostly harmless, it would be nice if that did not happen. Children are reaped automatically when start or wait_all_children are called. We only call start when a new job is found, and wait_all_children after exiting our while loop. The solution is to simply call reap_all_children after we sleep. This is a non-blocking call that will clean up those defunct processes. Test Plan: 1) Disable Rabbit 2) Set background_jobs_worker/max_processes to something like 5 3) Restart all the things! 4) Run a bunch of elastic index updates 5) Verify you have defunct processes 6) Apply this patch 7) Run more elastic index updates 8) Defunct processes should disappear every 10 seconds or so! If you do not see defunct processes, the test plan is to simply verify everything continues to work as expected. Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #39 from Lucas Gass --- rebased for current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21507 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24499 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #38 from Lucas Gass --- Created attachment 153193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153193=edit Bug 16122: Add display and increment localuse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #150236|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What|Removed |Added Attachment #150235|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29762] Patron batch modification tool - mobile phone number column naming
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29762 Sam Lau changed: What|Removed |Added Attachment #153181|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 153192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153192=edit Bug 29762: Change field names from "Mobile" to "Other phone" This Patch changes the field name for "Mobile" to "Other phone" in Patron batch modification. To test: 1. Apply the patch 2. Go to Tools -> Batch Patron Modification and add some patrons 3. Hit "continue" 4. Verify that in the list of patrons you selected, the field "Mobile" has been replaced by the field "Other phone" 5. Verify that down below in the fields to be batch modified, the field "Mobile" has also been replaced by the field "Other phone" 6. Add some data into the field "Other phone" (e.g. 12345 or some other number) and hit save 7. Confirm that the field was correctly modified and is still named "Other phone" Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29762] Patron batch modification tool - mobile phone number column naming
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29762 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 --- Comment #3 from Katrin Fischer --- I looked at the existing unit tests for SearchSubscriptions and right now we don't verify the return values at all, just checking that an ARRAY is returned. I was not sure how to extend that if deemed necessary. Pointers welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Katrin Fischer changed: What|Removed |Added Attachment #153189|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 153191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153191=edit Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34225] KohaTable broken on batch item deletion and modification results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Sam Lau changed: What|Removed |Added Attachment #153171|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 153190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153190=edit Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34225] KohaTable broken on batch item deletion and modification results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 --- Comment #1 from Katrin Fischer --- Created attachment 153189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153189=edit k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34230 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34230] New: Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34230 Bug ID: 34230 Summary: Add part_name and part_number to subscription result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: michaela.sie...@kit.edu We added the subtitle to the subscription results, but as series often have similar names and are hard to distinguish, it would be great if part_name and part_number would also be shown to help to identify the correct entries (245$n and $p in MARC21). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass changed: What|Removed |Added Attachment #150297|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 153188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153188=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added Summary|Add part_name and |Add part_name and |part_number to subscription |part_number to subscription |result list |detail page Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Sam Lau changed: What|Removed |Added Attachment #153186|0 |1 is obsolete|| --- Comment #3 from Sam Lau --- Created attachment 153187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153187=edit Bug 34199: Add full title information to subscription detail page Show the full title information, including part_name and part_number on the subscription detail page. To test: * Add a subscription linked to a record with 245$abnp set * Verify only 245$ab will show up on the subscription detail page * Apply patch * Verify that the full title information shows up on the detail page Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34227] Add persistent selections and batch operations to item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Sam Lau --- (In reply to Owen Leonard from comment #1) >- Confirm that the "Export selected.." options work and that your CSV > and barcode files now contain only the items you selected. Failing QA at this step. When nothing is selected, I can export to CSV and Barcode with no problem, but when I have anything selected, clicking the export buttons do nothing for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 --- Comment #2 from Katrin Fischer --- Definitely one of our older templates and more cleanup could be done, but I tried to keep it clean and simple for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34229] Warns from Acquisition/Order.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34229 Liz Rea changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 --- Comment #1 from Katrin Fischer --- Created attachment 153186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153186=edit Bug 34199: Add full title information to subscription detail page Show the full title information, including part_name and part_number on the subscription detail page. To test: * Add a subscription linked to a record with 245$abnp set * Verify only 245$ab will show up on the subscription detail page * Apply patch * Verify that the full title information shows up on the detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34229] New: Warns from Acquisition/Order.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34229 Bug ID: 34229 Summary: Warns from Acquisition/Order.pm Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org We are seeing a lot of this in our logs lately: [2023/07/07 10:30:17] [WARN] Use of uninitialized value in addition (+) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 520. [2023/07/07 10:30:17] [WARN] Use of uninitialized value in addition (+) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 521. [2023/07/07 10:30:17] [WARN] Use of uninitialized value in addition (+) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 527. [2023/07/07 10:30:17] [WARN] Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 532. [2023/07/07 10:30:17] [WARN] Use of uninitialized value in addition (+) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 587. [2023/07/07 10:30:17] [WARN] Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/Koha/Acquisition/Order.pm line 591. It might be nice to quiet these down a bit :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #22)
> Created attachment 153183 [details] [review]
> Bug 33497: Don't get host items if the MARC record is invalid
>
> When don't want to explode with "invalid data" later so we need to
> condition the host_item search
>
> call trace was
>
> Koha::Biblio::Metadata::record('Koha::Biblio::
> Metadata=HASH(0x55ab92e60120)') called at /kohadevbox/koha/Koha/Biblio.pm
> line 538
> Koha::Biblio::_host_itemnumbers('Koha::Biblio=HASH(0x55ab92e4d5c0)')
> called at /kohadevbox/koha/Koha/Biblio.pm line 498
> Koha::Biblio::items('Koha::Biblio=HASH(0x55ab92e4d5c0)',
> 'HASH(0x55ab934615d8)') called at /kohadevbox/koha/catalogue/detail.pl line
> 200
>
> This is fixing t/db_dependent/selenium/regressions.t
Follow-up pushed. Thanks, Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34214] Toolbar component should make the icon configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34214 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34214] Toolbar component should make the icon configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34214 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34201] Missing sorting indicator on the ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34201] Missing sorting indicator on the ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33484] Generalise table saveState for all tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #8 from Phil Ringnalda --- I copy-pasted this rule, added !important, and added the selector nav. Do we use a somewhere that it should be printed? Don't know, didn't test or grep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34152] Tests in t/db_dependent/Koha/Item.t fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34152 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com --- Comment #4 from Sam Lau --- Oddly enough, I also can't get it to fail. I ran it 5 times and it passed every time. This is especially weird since tests were failing for me and Lucas on Bug 12133, but it wasn't initially failing for you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33484] Generalise table saveState for all tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
Emily Lamancusa changed:
What|Removed |Added
Status|Patch doesn't apply |Failed QA
--- Comment #32 from Emily Lamancusa
---
Taking another stab at testing this. I'm still getting a few tables (holds to
pull and saved SQL reports, at least) that will continue to save the local
configuration indefinitely if a local save state was ever created, even if it
was later disabled in the configuration. I couldn't figure out why it happens
with some tables and not others, but it did clear up when I tried moving the
block that clears the local save state (if configured not to save) to occur
before trying to load the local save state:
Lines ~21-53 (columns_settings.inc):
+if ( table_settings.hasOwnProperty('default_save_state') &&
table_settings['default_save_state'] === 0 ) {
+localStorage.removeItem(table_key);
+}
+
// enable stateSave
dt_parameters['stateSave'] = true;
dt_parameters['stateSaveCallback'] = function( settings, data ) {
localStorage.setItem( table_key, JSON.stringify(data) )
}
dt_parameters['stateLoadCallback'] = function(settings) {
return JSON.parse( localStorage.getItem(table_key) )
}
// merge stateSave for column settings
var local_settings = localStorage.getItem(table_key);
var system_settings = table_settings['columns'];
var columns_settings = get_columns_saved_state(local_settings,
system_settings);
$(columns_settings).each( function() {
var named_id = $( 'thead th[data-colname="' + this.columnname +
'"]', selector ).index( selector + ' th' );
var used_id = dt_parameters.bKohaColumnsUseNames ? named_id :
counter;
if ( used_id == -1 ) return;
if ( this['is_hidden'] == "1" ) {
hidden_ids.push( used_id );
}
if ( this['cannot_be_toggled'] == "0" ) {
included_ids.push( used_id );
}
counter++;
});
-if ( table_settings.hasOwnProperty('default_save_state') &&
table_settings['default_save_state'] === 0 ) {
-localStorage.removeItem(table_key);
-}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33857] Reduce and resize local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Manos PETRIDIS changed: What|Removed |Added CC||egpetri...@yahoo.com --- Comment #7 from Manos PETRIDIS --- In my experience the problem arises from the change of format from JPEG to PNG. There should be a way to contain file size, without compromising pixel size. One could tamper for example with JPEQ quality index. Please see bug 33143 for examples. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 --- Comment #8 from Sam Lau --- (In reply to Fabricio Molina from comment #6) > Hello Sam. Thank you very much for taking the time to make the correction. I > apologize for the mistake made in the previously uploaded patch. Tomás > helped me fix it. Could you please review it again?. Thanks! Fabricio, no need to apologize! The bug is now signed off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34219] getAll not allowing additional parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 --- Comment #3 from Pedro Amorim --- getAll allows for additional parameters, e.g. query (see AgreementRelationships.vue), problem is it doesn't allow for additional URL parameters! We have to: - Add URLparams as a parameter to getAll - Have a clear distinction between query parameters and URL parameters in http-client.js (and maybe also somewhere else) - Rename getAll to search - Handle default _per_page value - Likely rename this bug I hope to revisit this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Sam Lau changed: What|Removed |Added Attachment #153105|0 |1 is obsolete|| --- Comment #7 from Sam Lau --- Created attachment 153185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153185=edit Bug 28805: Add on-site checkout checkbox in batch checkout Add the 'on-site checkout' checkbox to the 'Batch checkout'. To verify the functionality, follow these steps: 1) Before the modification is added, enable the 'OnSiteCheckouts' and 'BatchCheckout' system preferences. 2) In the 'BatchCheckoutsValidCategories' preference, select all categories. 3) Find a user in the system. For example, Henry Acevedo. 4) In the 'Check out' section, you can see that the 'Checkout settings' option displays the 'On-site Checkout' checkbox when clicked. 5) Check the 'On-site checkout' option. This will display the current date with a runtime deadline of 23:59. 6) Enter a barcode (for example 311418). 7) Click the 'Check out' button. This will show that the loan was made on-site. 8) Check the 'Batch checkout' section. This section does not hace the 'On-site checkout' checkbox. When loading the patch with the addition of the 'on-site checkout' checkbox in 'Batch checkout' starting from step 3), you can already find the checkbox in the 'Batch checkout' section. To use it, you can try the barcodes 306179 and 308494 together. Then continue from step 5). When viewing the loans, you will see that both items (306179 and 308494) will appear with the label 'On-site checkout'. If this patch is deactivated, the functionality will remain the same as it was before this change. Sponsored-by: Banco Central de la República Argentina Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34199] Add part_name and part_number to subscription result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133
--- Comment #40 from Sam Lau ---
I am still failing subtest 'safe_to_delete() tests'. The only thing that
changed in that subtest was that you commented out this line:
$patron->account->pay({ amount => 10, debits => [ $debit ] });
Uncommenting it made all tests successful for me
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #57 from Jonathan Druart --- If you were interested in this, can you help testing bug 33948 please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844
--- Comment #25 from Katrin Fischer ---
I'd really love to see this long standing issue fixed :)
1) Migration of data
At the moment this change would break processing the existing suggestions. As
the suggestion_id for the existing orders is empty, the information would not
show up on the orders in acq, and I am also not sure that the patrons would be
informed by email.
My suggestion:
We only compare entries with the same biblionumber:
1 suggestion with status in (ORDERED, AVAILABLE) and 1 order => link them
1 suggestion with status (ORDERED) and 1 order with orderstatus in (ordered,
partial) => link them
1 suggestion with status (AVAILABLE) and 1 order with orderstatus (complete) =>
link them
For the rest:
Mimick what we have done until now, use the first match (LIMIT 1, ->single):
For every order line that has no suggestion_id yet
that has a matching biblionumber in suggestions
link to the suggestion_id with the lowest/smallest suggestion_id where status
in (ORDERED, AVAILABLE)
So it might not be correct, but I think it's what would be displayed on the
order line now and where the email would be sent to, so that might be the best
we can do?
2) ModSuggestion
ModSuggestion is called to update the status of the suggestion and to send the
email, but the calls haven't always been adjusted to look up the correct
suggestion.
Orders.pm cancel()
my $suggestion = Koha::Suggestions->find({ biblionumber => $self->biblionumber,
status => "ORDERED" });
if ( $suggestion and $suggestion->id ) {
Wouldn't this fail if there is more than one suggestion for biblionumber with
status ORDERED?
addorder.pl = seems OK, because using the suggestion_id passed, but double
checking would be good
EDI.pm
my $s = $schema->resultset('Suggestion')->search(
{
biblionumber => $order->biblionumber->biblionumber,
}
)->single;
if ($s) {
ModSuggestion(
{
suggestionid => $s->suggestionid,
STATUS => 'AVAILABLE',
}
);
}
And there are more calls I haven't checked that need to be verified.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
