[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #102 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #101)
> (In reply to Jonathan Druart from comment #93)
> > I have a use case on bug 33568 where I need at least the library of the
> > patron, to display "a patron from LIBRARY".
> 
> You should just embed the patron's library... Then if the patron of
> undefined, you use the patron library string.

How do you know the patron's library if they've been filtered out ahead of
time?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #101 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #93)
> I have a use case on bug 33568 where I need at least the library of the
> patron, to display "a patron from LIBRARY".

You should just embed the patron's library... Then if the patron of undefined,
you use the patron library string.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #100 from David Cook  ---
I have a different system where I needed to control access to resources based
on requesting user. Fortunately, it is a smaller system than Koha with clearer
boundaries around the key data, so I focused on the key data.

For "single" access, each resource has a method for testing authorization to
itself. It takes a requesting user, a policy, a requesting action, and
optionally resource attributes for more fine-grained control. Since it's just 1
resource, I could use a lot of logic without having problems with
scale/efficiency.

For "plural" access, it got more complicated, because I needed to leverage SQL
and not code logic. Fortunately, I really only needed to worry about GETs in
this context, since I wasn't doing bulk modifications or bulk deletions. For
the GETs, I was able to insert extra SQL into the WHERE clause where needed to
make sure only resources the requesting user was authorized to see were
retrieved from the database.

That's probably a lot harder in Koha, especially if we're trying to do it
globally. 

But if we're just trying to restrict what patrons a requesting user can see
based on if they're from the same library... that could be a lot easier. 

It wouldn't feel great having a resource-specific authorization scheme instead
of a global one, but it would be a lot easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #99 from David Cook  ---
(In reply to Jonathan Druart from comment #94)
> Are not we trying to provide a global solution for a tricky problem?

Jonathan, are you saying that you think the solution is trying to be "too"
global and that we should instead just be focusing on protecting patron
information?

A global solution would be great, but it's hard to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #98 from David Cook  ---
I actually just thought of another potential issue...

Other than Koha's internal use of the API, I think most third-party API usage
involves using 1 potentially high privileged user. 

I assume there will be times where that API user is making a call on behalf of
an anonymous user or a low-privileged user, but since the API user is the
"logged in" user, the anonymous/low-privileged user will get access to data
that they shouldn't - unless the third-party API user does post-processing on
their end (which is something we said we wanted to avoid on bug 29275).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

--- Comment #97 from David Cook  ---
(In reply to Jonathan Druart from comment #96)
> How can we move this forward?

I suppose more eyes on it. I've tried reading through everything a couple
times, and it seems complicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275

--- Comment #42 from David Cook  ---
But I could also be misunderstanding how this is supposed to work...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275

--- Comment #41 from David Cook  ---
(In reply to David Cook from comment #40)
> Wouldn't it make more sense to just change the text to something like:
> "Patron details suppressed", or "Unknown Patron", or even ""?

"Patron details currently unavailable"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #40 from David Cook  ---
(In reply to Jonathan Druart from comment #37)
> +if ( row.patron != null ) {
>  +return $patron_to_html( row.patron, {
> display_cardnumber: true, url: true } );
> +}
> +else {
> +return _("A patron from library
> %s").format(escape_str(row.library.name));
> }
> 
> This is not correct, is it?
> row.library.name should be row.patron.library.name, but we don't have it.

It took me a minute, but I think I see what you're saying. "row.library.name"
would be the name of the library where the checkout occurred - not the name of
the library the patron is from. 

While it's possible that these two values could be the same, it's also possible
that they could be different.

Wouldn't it make more sense to just change the text to something like: "Patron
details suppressed", or "Unknown Patron", or even ""?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #60 from David Cook  ---
(In reply to Katrin Fischer from comment #59)
> If we do this, could we make it work for scheduled repeated sending?
> 
> I am thinking of something like daily, on a specific day of the week, first
> of the month, etc. and also a time for each of those. 
> 
> A specific time might not work I guess or at least not exactly. Maybe
> something like "after 8:00" and then the first cron run after that time
> would run it and  set a 'last run on' date?

It would probably be wise to factor in recurring scheduled tasks.

We do have some local backend stuff for this where we have "hourly", "daily",
"weekly", and "monthly" granularity. Plus you can set hours and days... 

Needs more thought but probably a good idea to think about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #24 from Kelly McElligott  ---
This came up with a library recently.  When adding an item to a record with
over 50 items this is a lot of scrolling, but imagine a library with 200 items,
massive amount of scrolling.  I would love to see this move forward at this
point .  A collapsed option of all the items, and the ability to uncollapse?
Owen's attachments are a definite improvement to what we are working with now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34343] Z39.50 search background not updated

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343

--- Comment #3 from Owen Leonard  ---
(In reply to Caroline Cyr La Rose from comment #2)
> I don't have the language footer in the pop-up window. Is it normal?

Yes we don't typically show the language menu footer in pop-up windows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||34427


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34427
[Bug 34427] Fix responsive table style in the OPAC for items tables
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34427] Fix responsive table style in the OPAC for items tables

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34427

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||31248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248
[Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap
tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34427] Fix responsive table style in the OPAC for items tables

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34427

--- Comment #1 from Fridolin Somers  ---
Created attachment 153942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153942=edit
Screenshot of current mobile display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34427] New: Fix responsive table style in the OPAC for items tables

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34427

Bug ID: 34427
   Summary: Fix responsive table style in the OPAC for items
tables
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Like Bug 31248 fixed some tables in OPAC, items (holdings) tables needs to be
fixed to be responsive like before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #49 from Tomás Cohen Arazi  ---
Created attachment 153939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153939=edit
Bug 28966: (QA follow-up) tmp_holdsqueue no longer an iterator

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34425] Fix breadcrumbs vue component

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34425

--- Comment #2 from Agustín Moyano  ---
Created attachment 153938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153938=edit
[DO NOT PUSH] Bug 34425: Implementation example for Preservation module

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

--- Comment #39 from Agustín Moyano  ---
(In reply to Jonathan Druart from comment #38)
> (In reply to Matt Blenkinsop from comment #35)
> > The patch above is an example of an implementation for this by passing a
> > parameter into the breadcrumbs from a particular component.
> > 
> > Currently I've only set it up for Agreements and Licenses for discussion but
> > the implementation is simple to repeat.
> > 
> > I've also included two dummy routes to tackle Joubu's issue in comment 27
> > that would need removing once this example is reviewed. These have been
> > added into Agreements as a substitute for the Preservation module
> > 
> > Test plan
> > 1) Apply and yarn js:build
> > 2) Create an agreement
> > 3) Click on the link to view the agreement
> > 4) The breadcrumb should contain your agreement's name
> > 5) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/
> > 6) Breadcrumb should read "Agreements" > "Your agreement name" > "Add item
> > to train"
> > 7) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/1
> > 8) Breadcrumb should read "Agreements" > "Your agreement name" > "Add items
> > to train"
> 
> Thanks a lot Matt, I have opened 2 bug reports, I will split your patch. See
> bug 34417 and 34418. See you there ;)

I did not see Matt's reply before... I uploaded a patch to fix this problem in
bug 34425

Could you and Matt check it out, please?

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34425] Fix breadcrumbs vue component

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34425

--- Comment #1 from Agustín Moyano  ---
Created attachment 153937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153937=edit
Bug 34425: fix Breadcrumbs vue component

This patch fixes Breadcrumbs component when there is no title in a node in the
routes tree,
and fixes the links when there are parameters and the node has no name defined

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34425] Fix breadcrumbs vue component

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34425

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28970] Create runtime parameters on the fly

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34425] New: Fix breadcrumbs vue component

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34425

Bug ID: 34425
   Summary: Fix breadcrumbs vue component
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: agustinmoy...@theke.io
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When a node in the routes tree has no title, breadcrumbs do not display nicely,
for example, "Preservation > Trains > Show train > > Add item to train" and
when the links in each step of the breadcrumbs have parameters and the route
node has no name, they are not replaced with the actual values

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024

--- Comment #2 from Emily Lamancusa  ---
I think those restrictions are coded in at the UI level, so the API provides an
unintentional loophole.

To reproduce on KTD:
1. Place a hold for pickup at CPL
2. Check in an item at CPL to fill the hold and set it to Waiting
3. Note that the hold now appears in the Holds Awaiting Pickup table for
Centerville
4. Send an API request to /api/vi/holds/:hold_id/pickup_location to change
   the pickup location to MPL
5. Note that the request succeeds and the hold is moved to the Holds Awaiting
   Pickup table for Midway.

For In Transit holds, the API should respect OPACAllowUserToChangeBranch, when
applicable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34410] Allow for alternative or better customization of items.content in digest notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34410

--- Comment #2 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #1)
> Hi Lucas, I believe this is possible now with TT, see: bug 29698.
> 
> *** This bug has been marked as a duplicate of bug 29698 ***

Wow, I even signed off on it! Thanks Katrin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33901] Only one issue shown when testing prediction pattern

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs documenting   |Pushed to oldstable

--- Comment #12 from Katrin Fischer  ---
(In reply to Sue from comment #11)
> Still experiencing only one issue showing when testing prediction patterns
> in 22.11.07.  Similar to bug 32554

This is to be expected: see the Versions released in at the top. The fix will
be included in 22.11.08.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19192

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19192] Update default DUEDGST and PREDUEDGST notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19192

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29698

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25763] Allow update of order fund after receipt

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763

Katrin Fischer  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=19192   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19192] Update default DUEDGST and PREDUEDGST notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19192

Katrin Fischer  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=25763   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34422] Reindent facets.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34422

Katrin Fischer  changed:

   What|Removed |Added

Summary|Reindent factets.inc|Reindent facets.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25763] Allow update of order fund after receipt

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19192

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19192] Update default DUEDGST and PREDUEDGST notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19192

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25763

--- Comment #1 from Katrin Fischer  ---
We should update the sample notices, but not 'like that' but using TT. 

See bug 25763.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698

--- Comment #8 from Katrin Fischer  ---
*** Bug 34410 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34410] Allow for alternative or better customization of items.content in digest notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34410

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
Hi Lucas, I believe this is possible now with TT, see: bug 29698.

*** This bug has been marked as a duplicate of bug 29698 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34410] Allow for alternative or better customization of items.content in digest notices

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34410

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33901] Only one issue shown when testing prediction pattern

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901

Sue  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Needs documenting
 CC||y...@morainevalley.edu

--- Comment #11 from Sue  ---
Still experiencing only one issue showing when testing prediction patterns in
22.11.07.  Similar to bug 32554

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276

ivan  changed:

   What|Removed |Added

 CC||ipine...@isep-cba.edu.ar

--- Comment #17 from ivan  ---
(In reply to Jeremiah from comment #11)
> Hi,
> 
> I am having the same problem as SOS.
> 
> Upgrade to 23.05.00.002 [11:09:02]: Bug 21983 - Deleted biblio handling on
> ILL
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key
> name 'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
> 
> I am coming from 22.05 I believe.
> 
> I tried their suggestion: 
> "ALTER TABLE illrequests DROP KEY illrequests_bibfk;"
> 
> I got: Cannot drop index 'illrequests_bibfk': needed in a foreign key
> constraint

Hi,

I tried this suggestion and i got the same:

Cannot drop index 'illrequests_bibfk': needed in a foreign key constraint

message... So i searched and droped the foreign key constraint first:

"ALTER TABLE illrequests DROP FOREIGN KEY fk_illrequests_books;"

( I got some help from ChatGPT :) )

And then droped the index as proposed:

"ALTER TABLE illrequests DROP KEY illrequests_bibfk;"

And then  it worked! but now i have the question of the consequences of
dropping
the foreign key constraint. Will it impact on some transaction? I guess this is
a provisional fix. I appreciate any help you can provide on this matter.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Keywords|additional_work_needed  |

--- Comment #48 from Tomás Cohen Arazi  ---
Thanks Kyle, for promptly fixing the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #153856|0   |1
is obsolete||

--- Comment #4 from Emily Lamancusa  ---
Created attachment 153936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153936=edit
Bug 34365: Add cancellation request flow to DELETE /holds

This patch adds a new `x-koha-override` header to allow enforcing the
cancellation request flow for waiting holds.

If the hold is not waiting, the header has no effect.

To test:
1. Apply the tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: The endpoint doesn't implement the required logic
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The endpoint behavior is changed!
5. Sign off :-D

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #153855|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 153935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153935=edit
Bug 34365: Unit tests

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

--- Comment #105 from Katrin Fischer  ---
This requires backporting down to 22.11 please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
Summary|REST API should not allow   |REST API should not allow
   |changing the pickup |changing the pickup
   |location on a waiting hold  |location on found holds

--- Comment #1 from Kyle M Hall  ---
My testing indicates that Koha doesn't allow changing the pickup location of
any found holds, including In Transit holds. The API should reflect this same
restriction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769

--- Comment #4 from Katrin Fischer  ---
I agree, we could update the default mappings that are installed with Koha.
This would be a fix for any new installation, existing installations are harder
because people might be used to the behavior or might have changed the mappings
already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #59 from Katrin Fischer  ---
(In reply to David Cook from comment #58)
> As Martin has noted elsewhere:
> 
> (In reply to Martin Renvoize from comment #6)
> > I've long felt our use of 'at' in scheduler was wrong, but we've not had a
> > reasonable alternative.  We now have BackgroundJobs and I could see us using
> > that system as an alternative to using 'at' and calling a script.
> 
> I agree about using BackgroundJobs for the execution. 
> 
> We'll still need a scheduler, and I think the shortest path forward is a
> cronjob-based scheduler script, which polls the database every X interval
> looking for jobs to run.

If we do this, could we make it work for scheduled repeated sending?

I am thinking of something like daily, on a specific day of the week, first of
the month, etc. and also a time for each of those. 

A specific time might not work I guess or at least not exactly. Maybe something
like "after 8:00" and then the first cron run after that time would run it and 
set a 'last run on' date?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276

Katrin Fischer  changed:

   What|Removed |Added

 CC||afran...@gmail.com

--- Comment #16 from Katrin Fischer  ---
*** Bug 34416 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34416] Upgrade error bug

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34416

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
Please search first before posting a new bug, this is a duplicate to bug 34276.

*** This bug has been marked as a duplicate of bug 34276 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34424] New: Update release team on about page for new QA team member

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424

Bug ID: 34424
   Summary: Update release team on about page for new QA team
member
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: emily.lamanc...@montgomerycountymd.gov,
martin.renvo...@ptfs-europe.com

We've added Emily Lamancusa as new QA team member, the about page should be
updated accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34376] Node.js v14 is EOL

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34376

--- Comment #1 from Tomás Cohen Arazi  ---
Nothing seems to be failing once we moved to Node.js v18 (LTS) in KTD.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365

Myranda Fuentes  changed:

   What|Removed |Added

 CC||myra...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33241] Manual: Typo "Records changed to recalls"

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33241

Emmanuel Bétemps  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Emmanuel Bétemps  ---
Added to master manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33241] Manual: Typo "Records changed to recalls"

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33241

Emmanuel Bétemps  changed:

   What|Removed |Added

  Documentation||Emmanuel Bétemps
contact||
 Status|NEW |Needs documenting
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/705

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31872] Remove warning in cron-jobs section of the manual about needing StaticHoldsQueueWeight to use RandomizeHoldsQueueWeight

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31872

Emmanuel Bétemps  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Emmanuel Bétemps  ---
Added to master manual

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31872] Remove warning in cron-jobs section of the manual about needing StaticHoldsQueueWeight to use RandomizeHoldsQueueWeight

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31872

Emmanuel Bétemps  changed:

   What|Removed |Added

 Status|NEW |Needs documenting
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/705
 CC||e.bete...@gmail.com
  Documentation||Emmanuel Bétemps
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994

Shi Yao Wang  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com
   |ity.org |
 Status|NEW |Needs Signoff
 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||shi-yao.w...@inlibro.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29248] Manual 21.05 - 'position' missing in syspref UNIMARCAuthorityField100

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29248

Emmanuel Bétemps  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Emmanuel Bétemps  ---
Added to master manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994

--- Comment #3 from Shi Yao Wang  ---
Created attachment 153934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153934=edit
Bug 26994: List names in alphabetical order in Suggestion filter

Display list of names in alphabetical order when using the Suggestion
information filter in Suggestions management

Test plan:
1. Add different purchase suggestions from various patron's names
2. Go to Acquisition > Suggestions
3. Click on the Suggestion information filters on the left-hand side
4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or
"Accepted by"
--> notice the list of names in menus, names aren't displayed from A to Z
5. Apply patch and refresh page
6. Redo step 4
--> notice now it's sorted alphabetically

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29248] Manual 21.05 - 'position' missing in syspref UNIMARCAuthorityField100

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29248

Emmanuel Bétemps  changed:

   What|Removed |Added

  Documentation||Emmanuel Bétemps
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/705

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29248] Manual 21.05 - 'position' missing in syspref UNIMARCAuthorityField100

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29248

Emmanuel Bétemps  changed:

   What|Removed |Added

 Status|NEW |Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34345] 'Circulation and fine rules' vs 'Circulation and fines rules'

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345

--- Comment #3 from Caroline Cyr La Rose  ---
Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34345] 'Circulation and fine rules' vs 'Circulation and fines rules'

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Attachment #153836|0   |1
is obsolete||

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 153933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153933=edit
Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules'

This patch corrects two instances of the phrase "Circulation and fines
rules" in favor of the more common "Circulation and fine rules" for
consistency's sake.

To test, apply the patch and go to Administration.

- In the description under the "Circulation and fine rules" link it
  should read, "Define circulation and fine rules..."
- Open the Circulation and fine rules page and confirm that the link in
  the sidebar menu is correct.

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34345] 'Circulation and fine rules' vs 'Circulation and fines rules'

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34380] Inconsistencies in Item types page titles, breadcrumbs, and header

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380

--- Comment #1 from Caroline Cyr La Rose  ---

> Breadcrumb
> - Change 'Item types administration' in breadcrumb to 'Item types'
> 
> Page header
> - Change 'Item types administration' in page header to 'Item types'

These two points are corrected in bug 34344.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34380] Inconsistencies in Item types page titles, breadcrumbs, and header

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34344

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34380

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Attachment #153834|0   |1
is obsolete||

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 153932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153932=edit
Bug 34344: Make item types breadcrumbs uniform

This patch updates the breadcrumbs on the item types administration page
so that it reads "Item types" instead of "Item types administration,"
making it more consistent with other administration pages. The same
change is made to the page's main heading.

To test, apply the patch and go to Administration -> Item types.

The breadcrumbs should read "Home -> Administration -> Item types. The
page heading should read "Item types."

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34422] Reindent factets.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34422

--- Comment #2 from Owen Leonard  ---
Created attachment 153931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153931=edit
Bug 34422: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34422] Reindent factets.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34422

--- Comment #1 from Owen Leonard  ---
Created attachment 153930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153930=edit
Bug 34422: Reindent factets.inc

This patch reindents the staff interface catalog search results facets
template so that it has consistent indentation. These changes should
have no visible effect on the page.

To test, apply the patch and perform a catalog search in the staff
interface.The facets should look the same as always.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34422] Reindent factets.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34422

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34423] New: (proof-of-concept) Bugzilla could look better with a new skin

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423

Bug ID: 34423
   Summary: (proof-of-concept) Bugzilla could look better with a
new skin
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jake.de...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Hello,

I've been experimenting with Bguzilla5 for a few projects, and have got stuck
in with the skinning system. As a side project, and side product of this, I've
put together a Koha 22.11-inspired skin, the CSS of which can be found at the
Gitlab URL below:

https://gitlab.com/jahdobble/koha-bz-new-skin 

I've also put together a few screenshots, so one might look on what it may look
like:

https://gitlab.com/jahdobble/koha-bz-new-skin/-/tree/main/screenshots

I give these files with an Apache 2 licence, but if this needs changing to
match Koha's licence, I can do this easily.

Please do offer feedback, and submit patches. This proof of concept is free to
be either adopted, adapted, or ignored entirely.

Many thanks,
Jake Deery

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34422] New: Reindent factets.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34422

Bug ID: 34422
   Summary: Reindent factets.inc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I would like to reformat the staff interface search facets include so that it
has consistent spacing and indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #153928|0   |1
is obsolete||

--- Comment #47 from Kyle M Hall  ---
Created attachment 153929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153929=edit
Bug 28966: (QA Follow-up) Fix failing unit tests

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note tests fail
3) Apply this patch
4) Run updatedatabase.pl
5) Update the schema files ( alias 'dbic' can be used in
   koha-testing-docker )
6) prove t/db_dependent/TestBuilder.t
7) Tests now pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #46 from Kyle M Hall  ---
Created attachment 153928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153928=edit
Bug 28966: (QA Follow-up) Fix failing unit tests

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note tests fail
3) Apply this patch
4) Run updatedatabase.pl
5) Update the schema files ( alias 'dbic' can be used in
   koha-testing-docker )
6) prove t/db_dependent/TestBuilder.t
7) Tests now pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34343] Z39.50 search background not updated

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343

--- Comment #2 from Caroline Cyr La Rose  ---
I don't have the language footer in the pop-up window. Is it normal?

Otherwise everything is A-OK!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140

--- Comment #5 from Owen Leonard  ---
I corrected the commit message and added the test plan. Everything worked as it
should in my tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140

Owen Leonard  changed:

   What|Removed |Added

 Attachment #147773|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 153927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153927=edit
Bug 33140: Use facet label value for mouseover text on facet removal link

This patch updates the facets includes in both the staff interface and
OPAC so that the title attribute on "remove" links uses the full name
rather than the code of the facet. So, library name instead of
branchcode, collection code description instead of authorized value
code.

To test, apply the patch and perform a search in the staff interface.

- Click a facet in the left-hand sidebar which will return more than one
  result.
  - On the reloaded page there should be a link next to that facet: [X].
Hovering your mouse over it should show "Remove facet [facet name]"
e.g. "Remove facet Centerville" instead of "Remove facet CPL"
- Test on library facets, item type facets, and collection code facets.
- Perform the same test in the OPAC.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34421] New: Add option to include a 'Search library groups' dropdown in catalogue-search-box.inc

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34421

Bug ID: 34421
   Summary: Add option to include a 'Search library groups'
dropdown in catalogue-search-box.inc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some libraries would like to be able to search within library groups from the
main catalog search. We should add a dropdown that can be toggled on/off via a
system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34420] New: Add GET endpoint for listing library groups

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34420

Bug ID: 34420
   Summary: Add GET endpoint for listing library groups
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
CC: tomasco...@gmail.com

It would be pretty handy if there was a REST API endpoint that listed library
groups.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34419] koha-plack contains a wrong test about missing Apache modules

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34419

--- Comment #3 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #2)
> /usr/sbin/apachectl -M 2>/dev/null | grep -q headers; echo "${PIPESTATUS[0]}
> ${PIPESTATUS[1]}"
0 0

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34419] koha-plack contains a wrong test about missing Apache modules

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34419

--- Comment #2 from Marcel de Rooy  ---
Error fixed

/usr/sbin/apachectl -M 2>/dev/null | grep -q headers; echo "${PIPESTATUS[0]}
${PIPESTATUS[1]}"

/usr/sbin/apachectl -M 2>/dev/null | grep -q badheaders; echo "${PIPESTATUS[0]}
${PIPESTATUS[1]}"
0 1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34419] koha-plack contains a wrong test about missing Apache modules

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34419

--- Comment #1 from Marcel de Rooy  ---
/usr/sbin/apachectl -M 2>/dev/null | grep -q headers; echo "${PIPESTATUS[0]}
${PIPESTATUS[1]}"
1 1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|23.05.00,22.11.07   |23.05.00,22.11.07,22.05.15
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34419] koha-plack contains a wrong test about missing Apache modules

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34419

Marcel de Rooy  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34419] New: koha-plack contains a wrong test about missing Apache modules

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34419

Bug ID: 34419
   Summary: koha-plack contains a wrong test about missing Apache
modules
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

All needed Apache modules are installed but koha-plack tells me:

WARNING: koha-plack requires some Apache modules that you are missing.
You can install them with:
sudo a2enmod headers proxy_http

This really is not true.
What happened?
There is a syntax error in one of my local sed changes in a config file.

Looking a bit deeper, I see this test in sub check_env_and_warn()

if ! /usr/sbin/apachectl -M 2> /dev/null | grep -q ${module}; then
missing_modules="${missing_modules}${module} "
fi

Altough the grep -q part looked mysterious to me at first, the problem seems to
be the pipe. If the first process exits with an error, the second will have an
error too on the closed handles.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34122] Updating location changes location of all related records

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34392] Run automated Stylelint fixes on staff CSS

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34392

--- Comment #1 from Owen Leonard  ---
Created attachment 153926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153926=edit
Bug 34392: Run automated Stylelint fixes on staff CSS

This patch corrects errors raised by the new stylelint configuration in
staff-global.scss. Many of the fixes were made automatically by using
the "--fix" option:

npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss --fix

Some examples of errors found:

- Expected single space after ":"
- Expected single space after "("
- Expected single space before ")"
- Expected empty line before comment
- Expected no more than 1 empty line
- Expected a trailing semicolon

Manual fixes include replacing named colors with hex codes, combining
duplicate selectors, removing empty blocks, etc.

Some warnings remain: "Unexpected !important" requires more than a
quick fix, if we should choose to address them.

To test, apply the patch and rebuild the staff interface CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

The changes affect CSS all around the staff interface, but there should
be no visible results of the patch. Everything should look correct.

The stylelint check should return only warnings about "!important"

npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34392] Run automated Stylelint fixes on staff CSS

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34392

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

--- Comment #32 from Martin Renvoize  ---
Some work towards what I was suggesting.. let me know what you think.. it's all
a bit crude, but until we get some more of the Plugins foundations solid I
think it may be the middle ground we can take.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

--- Comment #31 from Martin Renvoize  ---
Created attachment 153925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153925=edit
Bug 25672: WIP - Convert to restricting to repo only

I think instead of a plain on/off switch we should use it in combination
with the plugin_repo's and set it to restrict to only those repos' (i.e.
disable uploads entirely if no repo's are listed, or just allow those
repo's when there are)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34258] Cannot renew item via SIP2

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258

--- Comment #13 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34258] Cannot renew item via SIP2

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12773] Branch transfer limits show codes instead of descriptions (item types/collections)

2023-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12773

Owen Leonard  changed:

   What|Removed |Added

  Component|Templates   |System Administration
 CC||gmcha...@gmail.com
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
 Status|ASSIGNED|NEW

--- Comment #4 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #3)
> Maybe we could add the full descriptions as a title/tooltip?

I think this is a good idea but I'm not sure how to get the right data to the
template. Right now all there is to work with is code, and I'm assuming that it
would be more efficient to fetch the descriptions in the script.

Correct me if I'm wrong and I'll use the template plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >