[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #23 from David Cook --- Another thing about "None" is that I think it can only be set with the Secure attribute set as well. Not sure what happens when you try to send a cookie with "None" that isn't secure... I imagine it would default back to Lax but don't know for sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #63 from Alex Buckley --- Created attachment 154152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154152=edit Bug 21159: (follow-up) Remove tab space Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #62 from Alex Buckley --- Created attachment 154151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154151=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #154149|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #154150|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #61 from Alex Buckley --- (In reply to Laura Escamilla from comment #56) > Applying: Bug 21159: Database changes > Using index info to reconstruct a base tree... > M installer/data/mysql/mandatory/sysprefs.sql > Falling back to patching base and 3-way merge... > Auto-merging installer/data/mysql/mandatory/sysprefs.sql > Applying: Bug 21159: Template and yaml changes > Applying: Bug 21159: Update item location on checkout > Using index info to reconstruct a base tree... > M C4/Circulation.pm > M Koha/Item.pm > M t/db_dependent/Circulation/issue.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Circulation/issue.t > CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t > Auto-merging Koha/Item.pm > CONFLICT (content): Merge conflict in Koha/Item.pm > Auto-merging C4/Circulation.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 21159: Update item location on checkout > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-21159-Update-item-location-on-checkout-TimIX1.patch Thanks for trying to test Laura. I've rebased against master, these patches should now apply cleanly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #60 from Alex Buckley --- Created attachment 154150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154150=edit Bug 21159: (follow-up) Remove tab space Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #59 from Alex Buckley --- Created attachment 154149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154149=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #58 from Alex Buckley --- Created attachment 154148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154148=edit Bug 21159: Template and yaml changes Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #57 from Alex Buckley --- Created attachment 154147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154147=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #146605|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #146606|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #146607|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #146608|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #22 from Alex Buckley --- (In reply to David Cook from comment #21) > It might be worth adding that "None" has security implications and is not > recommended? > > Overall, I think only "Lax" and "Strict" makes sense for Koha with "Strict" > being preferable overall, although it would need some testing, especially > with identity providers... That's a great idea to add that None has security implications and isn't recommended, thanks for suggesting that David, Will add that to the syspref description in the yaml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #25 from Andreas Roussos --- (In reply to Stephanie Etallaz from comment #23) > CONFLICT (rename/rename): Rename > "koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"- > >"koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.highlight-3.js" in branch > "HEAD" rename > "koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"- > >"koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-5.js" in > "Bug 29578: Upgrade the jQuery highlighter plugin" Thank you for your interest in this bug report, Stephanie. The patch has been rebased against the current master, please try again ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Attachment #147090|0 |1 is obsolete|| --- Comment #24 from Andreas Roussos --- Created attachment 154146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154146=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process make the "Highlight" / "Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client, with UNIMARC-based instances affected the most as the "Highlight" / "Unhighlight" button disappears if you perform a specific OPAC search (see Test plan below). This patch fixes that by upgrading the highlighter plugin to its latest version for both the OPAC and the Staff interface. Then, the changes from commit 2e4b574074 (Bug 5844) are applied to the plugin code. Also, Koha uses "term" instead of "highlight" as the class name for the highlighting elements, so the plugin code is modified for that aspect, too. Finally, the plugin file is renamed to reflect the version change (v3 -> v5) and all references to the old filename in the Template files are updated. Test plan: 0) In a UNIMARC instance, catalogue two books using the titles given below (Title subfield = 200$a): Book 1: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book 2: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) 1) OpacHighlightedWords and StaffHighlightedWords should both be set to "Highlight". 2) Search the OPAC for "επιτομή των" (without the quotes). In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) the "Highlight" / "Unhighlight" button vanishes c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 3) Repeat the same search in the Staff interface. In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) Even though some terms are highlighted, the button still says "Highlight" c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 4) Apply this patch. 5) Repeat the searches (you may have to press CTRL-F5 to reload the JavaScript code). This time the "Highlight" / "Unhighlight" button is displayed in the OPAC, and all your search terms should be highlighted in yellow. Toggling the highlight should cause no problems, and there shouldn't be any errors logged in your browser's Console. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #17 from David Cook --- (In reply to Katrin Fischer from comment #12) > It's still a bit wrong isn't it? Since we don't show the time, the user only > gets this: No renewal before 01.08.2023 (which makes no sense, when that day > is today. Maybe we should show the time or rephrase for 23:59:00 to "after". It is worth double-checking. When I set the due date to "08/06/2023 13:45" it said no renewal before "08/01/2023 13:45". But I think it just said no renewal before "08/01/2023" when I didn't specify a time which I think defaults to 23:59? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #21 from David Cook --- It might be worth adding that "None" has security implications and is not recommended? Overall, I think only "Lax" and "Strict" makes sense for Koha with "Strict" being preferable overall, although it would need some testing, especially with identity providers... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What|Removed |Added Attachment #128857|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What|Removed |Added Attachment #128817|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #20 from Alex Buckley --- Rebased against master, applies cleanly now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #19 from Alex Buckley --- Created attachment 154145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154145=edit Bug 33259: (follow-up) Add HTML filters to Cookies.set Test plan: Run QA test tools and confirm the no complaints about filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #18 from Alex Buckley --- Created attachment 154144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154144=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #17 from Alex Buckley --- Created attachment 154143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154143=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors 11. Change 'SameSiteSessionCookie' to 'None' 12. Open a new private browser window, repeat step 4, and confirm the 'SameSite' = 'None' 13. Go to: Cataloguing > New record 14. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #16 from Alex Buckley --- Created attachment 154142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154142=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #150557|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #150558|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #150559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What|Removed |Added Attachment #150560|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What|Removed |Added Blocks|29750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What|Removed |Added Depends on|23172 | Status|ASSIGNED|Needs Signoff Change sponsored?|--- |Sponsored --- Comment #7 from Alex Buckley --- (In reply to Katrin Fischer from comment #4) > Hi Alex, should this have a different status? Hi Katrin, My apologies for the late reply. Yes you're right this should be 'Needs signoff' As this is an old bug report I've just checked upstream and this bug can still be replicated. I've tidied up the patches a bit, they apply cleanly, and they actually don't depend on bug 23172 so I've removed that dependency. Ready for testing. Kind regards Alex Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #6 from Alex Buckley --- Created attachment 154141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154141=edit Bug 29750: Unit test fixes for Reserves.pm Test plan: 1. sudo koha-shell 2. prove t/db_dependent/Holds.t prove t/db_dependent/Reserves.t Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #5 from Alex Buckley --- Created attachment 154140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154140=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What|Removed |Added Attachment #128859|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What|Removed |Added Attachment #128858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29664] Do not show voided payments in cash register statistics wizard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664
Andrii Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
--- Comment #20 from Andrii Nugged ---
Follow-up bug note:
$whereTType .= q{ AND status != 'VOID' };
This makes MariaDB act unexpectedly: statuses with NULL are also skipped!
When I added this to our piloting production:
$whereTType .= q{ AND (status IS NULL OR status != 'VOID') };
it started to show those accountlines which has NULLs.
Reasoning: https://mariadb.com/kb/en/null-values/
SELECT NULL != 'VOID', 'VOID' != 'VOID', 'TOTAL' != 'VOID';
++--+---+
| NULL != 'VOID' | 'VOID' != 'VOID' | 'TOTAL' != 'VOID' |
++--+---+
| NULL |0 | 1 |
++--+---+
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34454] New: Error:Can't call method "raw"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34454 Bug ID: 34454 Summary: Error:Can't call method "raw" Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: bibliote...@biteca.com QA Contact: testo...@bugs.koha-community.org Hi, I have an installation in Koha 22.05.09, we just updated to 22.05.14 We have 800,000 bibliographic records Sometimes in the search the system throws the following error: Error:Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 774. We have reindexed several times, and the server has 16 GB of RAM and 16 processor cores. In the database, the server is somewhat more modest, but both work well. What could be happening? Andrés -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What|Removed |Added Attachment #154136|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 154139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154139=edit Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What|Removed |Added Attachment #153737|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 154138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154138=edit Bug 30362: Fix unit test Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What|Removed |Added Attachment #153736|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 154137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154137=edit Bug 30362: Unit test Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30036 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11083 CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What|Removed |Added Attachment #153738|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 154136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154136=edit Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #12 from Katrin Fischer --- (In reply to David Cook from comment #11) > (In reply to Katrin Fischer from comment #8) > > Something is not working quite right there: > > > > * loan period 5 days > > * no renewal before 5 dates > > * today is 2023-07-29 and date in ktd also shows me that > > * message shown: no renewal before 2023-07-29 > > > > ... but I can't renew :( > > In fact, with "exact time", that's the norm with master even without this > patch. > > Going to move this one back to "Signed Off" You were right, I was actually not aware of that system preference! It's still ab it wrong isn't it? Since we don't show the time, the user only gets this: No renewal before 01.08.2023 (which makes no sense, when that day is today. Maybe we should show the time or rephrase for 23:59:00 to "after". But not part of this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What|Removed |Added Attachment #154129|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 154135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154135=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 --- Comment #5 from Katrin Fischer --- -Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? +Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? The span should be after the ? because you might have a different sentence structure for a question. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 --- Comment #4 from Katrin Fischer --- Created attachment 154134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154134=edit Bug 34436: (QA follow-up) Move spans to surround full text Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What|Removed |Added Attachment #154128|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 154133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154133=edit Bug 34436: Some breadcrumbs lack for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 --- Comment #5 from Katrin Fischer --- The regex rules don't work, but there is a lot of mark-up useful for splitting with jQuery and CSS if you have a look at how it presents in HTML. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34453] New: Update background of quick spine label pop-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Bug ID: 34453 Summary: Update background of quick spine label pop-up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When printing a quick spine label, the background of the pop-up window is still in the old style. To recreate: 0. Make sure to have an item with a call number and a barcode 1. Go to Cataloging > Quick spine label creator 2. Enter the barcode of the item and press Enter --> The background of the pop-up is blue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- We've just had someone on IRC ask about this. https://irc.koha-community.org/koha/2023-08-01#i_2501434 They had a label printer and wanted to use the quick spine label creator to print the spine labels with a specific splitting rule. Test plan : 1. Create a splitting rule that splits on periods and spaces 1.1. Go to Administration > Classification configuration 1.2. Click 'New splitting rule' 1.3. Fill out the form - Splitting rule code: TEST - Description: Split on period and spaces - Splitting routine: RegEx - Regular expression: s/\s/\n/g (click 'New' to add a second regex) s/\./\n\./g 1.4. Optionally, test the regex by entering a call number, e.g. 822.33 H521 It should be split as follows 822 .33 H521 1.5. Click 'Save' 2. Add this splitting rule to the Other/Generic Classification Scheme 2.1. In Classification sources, click 'Edit' next to Other/Generic Classification Scheme 2.2. Edit as follows - Source in use: Check - Splitting rule: Split on period and spaces (TEST) 2.3. Click 'Save' 3. Create or edit an item to add a call number 3.1. Find or create a record 3.2. Edit or create an item 3.3. Edit/Create the item as follows - 2 - Source of classification or shelving scheme: Other/Generic Classification Scheme - o - Full call number: 822.33 H521 - p - Barcode: enter a barcode, note this down, you'll need it later - y - Koha item type: fill this out if it's not already 3.4. Click 'Add item' or 'Save changes' 4. Print a quick label 4.1. Go to Cataloging > Quick spine label creator 4.2. Enter the barcode of the item and press Enter --> The call number is not split according to the rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 154132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154132=edit Bug 34024: (QA follow-up) Allow pickup location changing for in transit holds Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Michaela Sieber changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #16 from Michaela Sieber --- *** Bug 28771 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Michaela Sieber changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Michaela Sieber --- I think it was fixed in version 20.11.00 see bug 6819 *** This bug has been marked as a duplicate of bug 6819 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 --- Comment #3 from Andreas Roussos --- Created attachment 154131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154131=edit Bug 21828: build $bib_heading_fields only once per invocation In UNIMARC instances, the run time of link_bibs_to_authorities.pl can be reduced by up to 80% and the number of DBI calls can be reduced by up to 90% with a very simple fix that optimises the constructor of the C4::Heading::UNIMARC object. Currently, the constructor resets the $bib_heading_fields hash *in each invocation* (i.e. for every field the bibliographic record contains), then populating it again with the results fetched from the database! This is inefficient. The patch/fix is trivial: we take advantage of the fact that $bib_heading_fields is declared at the top of the C4::Heading::UNIMARC module and is thus a package variable that is in scope for the entire execution of the program (more info here: https://stackoverflow.com/q/75317862). Placing the section that generates the $bib_heading_fields hash inside a "unless ( defined $bib_heading_fields )" code block is enough to cause a significant reduction in the number of "expensive" SQL SELECT queries that must be run. Test plan: 0) Have a UNIMARC instance with some sample data (the KTD one will do just fine for this experiment). 1) Run the following commands: $ ktd --shell k$ DBI_PROFILE=1 ./misc/link_bibs_to_authorities.pl -t Observe the output from the script and the DBI profiling info. [You may want to play with different DBI_PROFILE levels (such as 2, 4, 6, 8, etc.) to see what's going on under the hood DBI-wise, for reference see: https://metacpan.org/pod/DBI::Profile] 2) Apply this patch. 3) Rerun the script from step 1), it should run a lot faster! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |a.rous...@dataly.gr |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What|Removed |Added URL||misc/link_bibs_to_authoriti ||es.pl --- Comment #2 from Andreas Roussos --- bulkmarcimport.pl seems to be the only script that is affected the most by this, as it can potentially make an excessive number of calls to LinkBibHeadingsToAuthorities(). Also, if the AutoLinkBiblios system preference is set to 'Do', then AddBiblio() and ModBiblio() both call BiblioAutoLink() which in turn calls LinkBibHeadingsToAuthorities() to do the heavy-lifting. So, I believe my patch might bring an improvement in the overall responsiveness of the Staff interface when saving new bibliographic records or modifying existing ones, especially for records with many many fields. However, the big win here is the significantly lower execution times for any helper scripts that call these functions. These benefits apply to UNIMARC only ;-) To put the above claim to the test, I profiled the DBI calls made while using link_bibs_to_authorities.pl and also timed how long it took to run the script. The exact command line used is shown below. My database had 8,241 authority and 23,142 biblio records. +---+++ DBI calls made | without patch | with patch | difference | +---+++ |14,732,858 |626,090 |-95.75% | +---+++ +---+++ execution time | without patch | with patch | difference | +---+++ | 1,125 sec |186 sec |-83.47% | +---+++ Command line used: $ DBI_PROFILE=1 ./misc/link_bibs_to_authorities.pl -t I include the "raw" profiling data from my test runs below: Bib authority heading linking report === Linker module: C4::Linker::Default Run started at: 08/01/23 20:10:39 Run ended at: 08/01/23 20:29:24 Total run time: 1124977 ms Number of bibs checked: 23142 Number of bibs modified:0 Number of bibs with errors: 0 Number of headings linked: 32316 Number of headings unlinked:15793 Number of headings fuzzily linked: 0 Ran in test mode only DBI::Profile: 880.455353s 78.05% (14732858 calls) link_bibs_to_authorities.pl @ 2023-08-01 20:29:24 Bib authority heading linking report === Linker module: C4::Linker::Default Run started at: 08/01/23 20:40:06 Run ended at: 08/01/23 20:43:12 Total run time: 185965 ms Number of bibs checked: 23142 Number of bibs modified:0 Number of bibs with errors: 0 Number of headings linked: 32316 Number of headings unlinked:15793 Number of headings fuzzily linked: 0 Ran in test mode only DBI::Profile: 29.444538s 15.58% (626090 calls) link_bibs_to_authorities.pl @ 2023-08-01 20:43:12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828
--- Comment #1 from Andreas Roussos ---
(In reply to Martin Renvoize from comment #0)
> The routine iterates through all fields in a biblio and compares them to a
> list of acceptable tags that may link to an authority. It may be more
> efficient to do the opposite iteration, working through acceptable authority
> tags and looking for the existence of that field in the biblio. (Note.. I've
> not tested this hypothesis.. it depends heavily on how efficient it is to
> fetch a single MARC tag using Marc::Record)
Hi Martin,
TL;DR: In UNIMARC instances, link_bibs_to_authorities.pl run time
can be reduced by 80% and the number of DBI calls can be
reduced by 90% with a very simple fix that optimises the
C4::Biblio::LinkBibHeadingsToAuthorities routine ;-)
I had a go at optimising this routine recently, as I'm in the process
of writing a Perl script that will perform some housekeeping tasks
in our bibliographic records. [The script is meant to search for
"TOPICAL SUBJECT" authority headings (UNIMARC field 250) using the
text found in our existing "UNCONTROLLED SUBJECT TERMS" (biblio
subfield 610$a) and, when a match is found, add a new "TOPICAL NAME
USED AS SUBJECT" tag (field 606) to the bibliographic record, copy
the authority record contents over, link it via subfield $9, then
finally remove the (unwanted) uncontrolled subject term.]
In developing this script, I investigated the inner workings of the
routine in question, and I'm pleased to report that I've identified
where the inefficiency in LinkBibHeadingsToAuthorities() actually
lies. The patch for fixing this is trivial and backportable, too! ;-)
> The routine iterates through all fields in a biblio and compares them to a
> list of acceptable tags that may link to an authority.
Indeed, that's exactly what happens in LinkBibHeadingsToAuthorities()
with the crucial bit being line 641:
637 foreach my $field ( $bib->fields() ) {
638 if ( defined $tagtolink ) {
639 next unless $field->tag() == $tagtolink ;
640 }
641 my $heading = C4::Heading->new_from_field( $field, $frameworkcode
);
642 next unless defined $heading;
[...]
Then, in C4::Heading->new_from_field():
61 sub new_from_field {
62 my $class = shift;
63 my $field = shift;
64 my $frameworkcode = shift; #FIXME this is not used?
65 my $auth = shift;
66 my $marcflavour = C4::Context->preference('marcflavour');
67 my $marc_handler = _marc_format_handler($marcflavour);
[...]
277 sub _marc_format_handler {
278 my $marcflavour = uc shift;
279 my $pname = "C4::Heading::$marcflavour";
280 load $pname;
281 return $pname->new();
282 }
This is where things get interesting as the behaviour diverges a bit
depending on the MARC flavour being used: in C4/Heading/MARC21.pm the
object is constructed with:
255 sub new {
256 my $class = shift;
257 return bless {}, $class;
258 }
... and the $bib_heading_fields data structure/hash is statically
set at the top of the module:
49 my $bib_heading_fields = {
50 '100' => {
51 auth_type => 'PERSO_NAME',
52 subfields => 'abcdfghjklmnopqrst',
53 main_entry => 1
54 },
55 '110' => {
56 auth_type => 'CORPO_NAME',
57 subfields => 'abcdfghklmnoprst',
58 main_entry => 1
59 },
[...]
Whilst in C4/Heading/UNIMARC.pm the object is constructed with:
68 sub new {
69 my $class = shift;
70
71 my $dbh = C4::Context->dbh;
72 my $sth = $dbh->prepare(
73 "SELECT tagfield, authtypecode
74 FROM marc_subfield_structure
75 WHERE frameworkcode = '' AND authtypecode <> ''"
76 );
77 $sth->execute();
78 $bib_heading_fields = {};
79 while ( my ( $tag, $auth_type ) = $sth->fetchrow ) {
80 $bib_heading_fields->{$tag} = {
81 auth_type => $auth_type,
82 subfields => 'abcdefghjklmnopqrstvxyz',
83 };
84 }
85
86 return bless {}, $class;
87 }
... thus resetting the $bib_heading_fields hash *in each invocation*,
then populating it again with the results fetched from the database!
Does this information really need to be re-calculated for each field
of the record being saved/updated/linked? I think not, as:
1) Changes to the marc_subfield_structure table are not that frequent,
and are unlikely to occur in the relatively short timeframe that a
save/update/linking takes to complete.
2) As per the official Koha manual, you're not really meant to edit
the Default framework as this will cause problems, but rather
clone it to a different one which you'll use to catalogue your
records. [C4::Heading->new_from_field() can actually be fed with
a $frameworkcode parameter, but it doesn't currently use it.
I'll leave that for a different bug report, though ;-)]
--
You are
[Koha-bugs] [Bug 34452] Button Update adjustments is hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #1 from Michaela Sieber --- Created attachment 154130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154130=edit acqui/invoice.pl Hidden Button Update Adjustments Screenshot old vs. new UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Emily Lamancusa from comment #10)
> Is changing the pickup location on a hold that's in transit truly an
> unhandled situation?
The code for handling it in the OPAC is defined in:
sub can_update_pickup_location_opac {
my ($self) = @_;
my @statuses = split /,/,
C4::Context->preference("OPACAllowUserToChangeBranch");
foreach my $status ( @statuses ){
return 1 if ($status eq 'pending' && !$self->is_found &&
!$self->is_suspended );
return 1 if ($status eq 'intransit' && $self->is_in_transit);
return 1 if ($status eq 'suspended' && $self->is_suspended);
}
return 0;
}
I assume it should be safe to allow in_transit. I just don't know the area
(staff UI-wise) enough to feel confident about enabling. Some thought on the
initial report was needed though, as I found the in processing use case while
digging.
I'm open to change it to allow changing the pickup location for in transit
holds. I just thougth it deserved it's own bug report in which people involved
in the area could weight in.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34452] New: Button Update adjustments is hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Bug ID: 34452 Summary: Button Update adjustments is hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sie...@kit.edu QA Contact: testo...@bugs.koha-community.org To recreate: 1. Go to acquisition modul 2. search for Vendor 3. Button receive shipment and create invoive 4. click finish receiving (we don't need an order line for this test) 5. Click +Add an adjustment 6. Enter an amount and save via Button 'Update adjustments' 7. Now change the amount 8. recognize that there is not button to save or update the changed amount The Button 'Update adjustments' is hidden, you first have to click on 'Add an adjustment' That is not intuitive and changed with Version 22.11 and the new UI. Check in older Koha Versions (e.g. 21.11) that the Button 'Update adjustments' was always visible underneath the Link to 'Add an adjustment'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34036] Single receive doesn't reload data and order lines appears as pending
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #11 from Jonathan Druart --- (In reply to Nick Clemens from comment #10) > (In reply to Jonathan Druart from comment #9) > > Nick, I would remove the changes in ModBiblio, and keep the explicit update > > in the controller. > > > > Also I think we should have a selenium test. We already have 'Bibliographic > > record detail page must not explode even with invalid metadata' in > > regressions.t. > > The ModBiblio changes are needed to prevent an explosion in logging - > without them we die on recording the modification Got it, agreed. Thanks for your quick answer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28771 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6819 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30247] Add a receive shipment link to unreceived orders in acq advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30247 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Felicity Brown changed: What|Removed |Added CC||felicity.brown@montgomeryco ||untymd.gov --- Comment #11 from Felicity Brown --- I second "allowing a staff member to mess with transit data as a workaround is riskier." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #10 from Emily Lamancusa --- Is changing the pickup location on a hold that's in transit truly an unhandled situation? Looking at bug 30500 and bug 14783, if the syspref is set to allow it, opac-modrequest.pl calls $hold->set_pickup_location without extra handling, because AddReturn already has logic to handle a situation where a transfer completes and a new transfer needs to be initiated based on hold pickup location. It's true the functionality to directly change the pickup location on an in-transit hold wasn't added to the staff interface when it was added to the OPAC, but is there a practical reason it shouldn't be permitted, or more just that there hasn't been a need to add it yet (in part because staff have the capability to revert the transit status on a hold in order to make those types of changes, while the OPAC and API do not)? I'm not sure I fully understand the implications of a privileged API endpoint being able to change the pickup location on an in-transit hold, versus allowing the OPAC to do it, versus allowing a person in the staff interface to revert the transit status, change the pickup location, and then put the hold back in transit. (though actually I'd say the existing behavior allowing a staff member to mess with transit data as a workaround is riskier than adding the ability for them to change the pickup location directly, but that's beyond the scope of this bug) If there's a true risk to allowing the API to change the pickup location on an in-transit hold without an override, then it makes sense to be cautious. But if that's the case, please open a follow-up bug to add such an override route and restore the functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Nick, I would remove the changes in ModBiblio, and keep the explicit update > in the controller. > > Also I think we should have a selenium test. We already have 'Bibliographic > record detail page must not explode even with invalid metadata' in > regressions.t. The ModBiblio changes are needed to prevent an explosion in logging - without them we die on recording the modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau changed: What|Removed |Added Attachment #153923|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 154129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154129=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Sam Lau changed: What|Removed |Added Attachment #153996|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 154128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154128=edit Bug 34436: Some breadcrumbs lack for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What|Removed |Added Attachment #154105|0 |1 is obsolete|| --- Comment #9 from Sam Lau --- Created attachment 154127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154127=edit Bug 34024: Unit tests Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What|Removed |Added Attachment #154106|0 |1 is obsolete|| --- Comment #8 from Sam Lau --- Created attachment 154126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154126=edit Bug 34024: Block changing pickup location for found holds This patch adds a check on holds for 'found' statuses. Holds with the following statuses have special workflows in Koha, and overwritting their pickup locations yields uncertain scenarios: * Waiting: the item has probably been put on a special shelve * In transit: the item is travelling to a new destination, and changing the pickup location should include some validations, and probably generate some notifications. At least. * In processing: the item has already been taken out of the shelve for some internal processing. Changing the pickup location could interfere with this workflow. Overriding this limitation could be introduced with care on a separate report. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests don't pass. Holds go through (200) instead of being rejected (409). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Tomás Cohen Arazi changed: What|Removed |Added CC||n...@bywatersolutions.com, ||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #4 from Marcel de Rooy --- Not (yet) actively working on this, but if you are interested, add yourself to cc or comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #3 from Marcel de Rooy --- Created attachment 154125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154125=edit Bug 34430: Module for validating input Test plan: Run t/Koha/Validator.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #2 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > Copying code from 34367 here. Got obsoleted. No, bug 34349 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34349 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #10 from Marcel de Rooy --- A similar idea on bug 34430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34367 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34367 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #1 from Marcel de Rooy --- Copying code from 34367 here. Got obsoleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17433 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34430] Add Koha::Validator module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What|Removed |Added Summary|Polish Koha::Validator |Add Koha::Validator module |module | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34004] Typo: new items > news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34004 Emmanuel Bétemps changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #1 from Emmanuel Bétemps --- Added to master manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34004] Typo: new items > news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34004 Emmanuel Bétemps changed: What|Removed |Added Documentation||Emmanuel Bétemps contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/707 CC||e.bete...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
