[Koha-bugs] [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736

--- Comment #9 from Victor Grousset/tuxayo  ---
oh no, very weird it did that. Thanks for finding it out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449

Emmanuel Bétemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
Testing notes (using KTD):

1. Checked out an item to koha using the staff interface: 311418

2. Checked item in using SIP - no message at end after CRREF|: 

misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m
checkin --item 311418
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'checkin'
SEND: 09N2023092501381820230925   
013818APCPL|AOCPL|AB311418|ACterm1|BIN|
READ: 101YNN20230925013818AOCPL|AB311418|AQCPL|AJProgramming Perl
/|AA42|CRREF|

3. Applied the patches.

4. Edited /etc/koha/sites/kohadev/SIPconfig.xml and added
show_checkin_message="1":
...
  
   


5. Restarted everything (restart_all).

6. Checked out the item again and then checked in using SIP - message displayed
when UseLocationAsAQInSIP = permanent_location:

misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m
checkin --item 311418
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'checkin'
SEND: 09N2023092502031820230925   
020318APCPL|AOCPL|AB311418|ACterm1|BIN|
READ: 101YNN20230925020318AOCPL|AB311418|AQGEN|AJProgramming Perl
/|AA42|CRREF|AFItem checked-in: GEN - GEN.|

7. Checked out the item again and the checked in using SIP - message displayed
when UseLocationAsAQInSIP = homebranch:

misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m
checkin --item 311418
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'checkin'
SEND: 09N2023092502083420230925   
020834APCPL|AOCPL|AB311418|ACterm1|BIN|
READ: 101YNN20230925020834AOCPL|AB311418|AQCPL|AJProgramming Perl
/|AA42|CRREF|AFItem checked-in: Centerville - GEN.|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814

David Nind  changed:

   What|Removed |Added

 Attachment #154687|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 156142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156142=edit
Bug 25814: SIP: Add a message on successful checkin.

Currently, Koha does not return a message on successful SIP checkin.

This patchs adds the show_checkin_message option to SIPconfig.xml, disabled by
default. When enabled, the following message is displayed on SIP checkin:

"Item checked-in: {homebranch|permanent_location} - {location}"

The UseLocationAsAQInSIP system preference is used to determine whether the
homebranch or the permanent location will be used.

Test plan:

 - Perform a successful checkin using SIP
 - Check that the message is in the checkin response (AF field)
 - prove t/db_dependent/SIP/Transaction.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Attachment #155627|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 156141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156141=edit
Bug 34784: Implement feature in staff interface

Some libraries would like to auto-populate item callnumbers for items on a
record based on the system preference "itemcallnumber". Only items with empty
callnumbers would affected. This would add a button "Populate empty item
callnumbers" on catalogue/detail.pl, as well as a "Populate callnumber" button
for each line in the holdings table to set the callnumber for that specific
item.

Test Plan:
1) Set the systempreference to something ( "245a" will make the
   callnumber the record title for testing purposes )
2) Apply this patch set
3) Restart all the things!
4) Browse to a record details page, note no new buttons
5) Enable the new syspref EnablePopulateCallnumbers
5) Reload the record details, note the new "Populate callnumbers" button
   in the cataloging toolbar
7) Add one or more items with no callnumber to the record
8) Test the "Populate callnumbers" button
9) Add another item with no callnumber to the record
10) Test the "Populate callnumber" button for that single item

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Attachment #155626|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 156140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156140=edit
Bug 34784: Add REST API endpoints for updating single item or all applicable
items on a bib

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/biblios.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Add Hours as an age unit to auto item modifications by age for the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

David Nind  changed:

   What|Removed |Added

 Attachment #138896|0   |1
is obsolete||

--- Comment #30 from David Nind  ---
Created attachment 156139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156139=edit
Bug 21173: Unit tests

Test plan:
1. sudo koha-shell kohadev
2. prove t/db_dependent/Items/AutomaticItemModificationByAge.t

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Add Hours as an age unit to auto item modifications by age for the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

David Nind  changed:

   What|Removed |Added

 Attachment #138895|0   |1
is obsolete||

--- Comment #29 from David Nind  ---
Created attachment 156138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156138=edit
Bug 21173: Add Hours as an age unit to auto item modifications by age

items.damaged_on, items.itemlost_on, and items.withdrawn_on are datetime
fields, so it could be
useful to configure rules based on the number of hours since these values.

All other fields in the automatic item modifications by age tool will
use the days unit.

Test plan:
1. Go to Tools->Automatic item modifications by age

2. Create a new rule

3. Apply patches and restart services

4. Confirm the rule you created has an 'Age unit' displayed of 'Days'

5. Edit the existing rule. Notice if your 'Age field' is not set to
items.damaged_on,
items.itemlost_on or items.withdrawn_on then the 'Age unit' dropdown is
disabled

6. Confirm if you try to save a rule with age unit = 'Hours' and a field
other than items.damaged_on, items.itemlost_on, or items.withdrawn_on
then the 'List of rules' table shows that rule with the unit of
'Days'

7. Click 'Add rule'. Observe the 'Age unit' dropdown is initially disabled and
set
to 'Days' until you change the 'Age field' dropdown to items.damaged_on,
items.itemlost_on, or items.withdrawn_on

8. Save the rule:
Age: 1
Age unit: Hours
Age field: items.itemlost_on
Conditions: items.barcode = TEST
Substitutions: items.barcode = TEST1

9. Find an item. Set it's barcode to TEST. In the database change it's
items.itemlost_on to more than 1 hour ago

10. Restart services

11. Run the automatic_item_modification_by_age.pl script:
sudo koha-shell kohadev
./misc/cronjobs/automatic_item_modification_by_age.pl -c

12. Confirm the item's barcode has changed to TEST1

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Add Hours as an age unit to auto item modifications by age for the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

David Nind  changed:

   What|Removed |Added

 Attachment #138894|0   |1
is obsolete||

--- Comment #28 from David Nind  ---
Created attachment 156137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156137=edit
Bug 21173: Template and JavaScript changes

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Add Hours as an age unit to auto item modifications by age for the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from David Nind  ---
Patch no longer applies 8-(...

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33260: Add view_generated_notices user permission
Applying: Bug 33260: Add NoticesManagement system preference
Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message
Using index info to reconstruct a base tree...
M   t/db_dependent/Letters.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33260: Add a patron getter method to
Koha::Notice::Message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26170] Add protected status for patrons

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #22 from David Nind  ---
The patch no longer applies 8-(..

git bz apply 26170

Bug 26170 - Add protected status for patrons

154602 - Bug 26170: Database update
154603 - Bug 26170: Add protected status for patrons
154604 - Bug 26170: Update Schema - DO NOT PUSH

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26170: Database update
Applying: Bug 26170: Add protected status for patrons
Using index info to reconstruct a base tree...
M   C4/Members.pm
M   Koha/Exceptions/Patron.pm
M   Koha/Patron.pm
M   Koha/REST/V1/Patrons.pm
M   api/v1/swagger/paths/patrons.yaml
M   koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M   t/db_dependent/Koha/Patron.t
M   t/db_dependent/Koha/Patrons.t
M   t/db_dependent/Members.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Members.t
CONFLICT (content): Merge conflict in t/db_dependent/Members.t
Auto-merging t/db_dependent/Koha/Patrons.t
Auto-merging t/db_dependent/Koha/Patron.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
Auto-merging api/v1/swagger/paths/patrons.yaml
Auto-merging Koha/REST/V1/Patrons.pm
Auto-merging Koha/Patron.pm
Auto-merging Koha/Exceptions/Patron.pm
Auto-merging C4/Members.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26170: Add protected status for patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889

David Nind  changed:

   What|Removed |Added

 Attachment #156111|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 156136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156136=edit
Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system
preference to HTML customization

This patch moves the PatronSelfRegistrationAdditionalInstructions system
preference into HTML customizations, making it possible to have
language- and library-specific content.

To test you should have some content in the
PatronSelfRegistrationAdditionalInstructions system preference before
applying the patch. Apply the patch and run the database update process.

 - In the staff client, go to Tools -> HTML customizations and verify
   that the content previously in the
   PatronSelfRegistrationAdditionalInstructions preference is
   now stored there.
 - The HTML customization entry form should offer
   PatronSelfRegistrationAdditionalInstructions as a choice under
   "Display location."
 - Go to Administration -> System preferences and enable
   "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail"
   to "Don't require."
 - Go to the OPAC and click "Register here."
 - Submit a new registration and confirm that the content that was
   previously stored in the system preference is shown correctly on the
   registration confirmation page.
 - Update and reinstall active translations (for instance fr-FR):
   - cd misc/translator/
   - perl translate update fr-FR
   - perl translate install fr-FR
 - Enable the translation if necessary under Administration -> System
   preferences -> language.
 - Enable the "opaclanguagesdisplay" preference if necessary.
 - Edit the PatronSelfRegistrationAdditionalInstructions HTML
   customization and add unique content to the "fr-FR" tab.
 - Go to the OPAC and switch to your updated translation.
   Complete the online registration process again to confirm that the
   content you added for your translation shows up correctly on the
   confirmation page.
 - Go to Administration -> System preferences and confirm that the
   PatronSelfRegistrationAdditionalInstructions  preference has been
   removed.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12802] Send notices using several email addresses

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

--- Comment #114 from David Cook  ---
I'm curious how this would work with SSO that relies on the email field...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #14 from David Cook  ---
Since it's in the staff interface, users can always be trained anyways. So
maybe we should just go with "Session settings" after all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26303] [OMNIBUS] Preparing for Perl 7

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26303

--- Comment #3 from David Cook  ---
(In reply to Katrin Fischer from comment #2)
> Are we done here?

I guess so. Perl is an interesting creature...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #9 from David Nind  ---
I'm getting this error when running the script:

perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'holddate' in 'order clause' at
/kohadevbox/koha/Koha/Objects.pm line 394

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34800] Update contributor openhub links

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34800

--- Comment #5 from Aleisha Amohia  ---
Thanks David for the testing plan, oversight from me oops!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34800] Update contributor openhub links

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34800

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Testing notes (using KTD):

1. Tested a sample of contributors in the patch to make sure that the new links
to openhub work as expected. (About Koha > Koha team tab)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34800] Update contributor openhub links

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34800

David Nind  changed:

   What|Removed |Added

 Attachment #155631|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 156135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156135=edit
Bug 34800: Adding openhub links for Koha contributors

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34800] Update contributor openhub links

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34800

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34902] decreaseLoanHighHolds does not reduce loan period

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34902

Eric Phetteplace  changed:

   What|Removed |Added

 CC||pnavarr...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34902] New: decreaseLoanHighHolds does not reduce loan period

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34902

Bug ID: 34902
   Summary: decreaseLoanHighHolds does not reduce loan period
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:

- create item type with 14 day checkout period that allows holds
- create bib with one of those items
- decreaseLoanHighHolds = enable, decreaseLoanHighHoldsDuration = 7,
decreaseLoanHighHoldsValue = 1, decreaseLoanHighHoldsControl = "over the number
of holdable items on the records"
- place 2 holds on the item (which would be 1 over the number of holdable
items)
- checkout the item to a different patron

Expected: the manual says you'll see a warning because decreaseLoanHighHolds is
triggered and the checkout period should be 7 days (the reduced loan duration).

Actual: no warning and the item checks out for 14 days (the item type's
default).

The bug is likely specific to the item-level holds configuration for
decreaseLoanHighHolds but I'm not sure, all we've done is verify these exact
conditions recreate it. We asked ByWater if we were doing something wrong and
they also verified the bug.

I see there's a few bugs related to decreaseLoanHighHolds like Bug 25824 (about
its tests) and Bug 22005 (about it counting the hold currently being filled
towards the holds value, note that is NOT this bug describes because it occurs
when a patron _without_ a hold goes to check out the item) but I believe this
specific behavior is not covered by those.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #12 from David Nind  ---
I had a go at testing, but haven't signed off.

Some things I noted - don't think any are show stoppers:

0. Took a little getting used to - but seems OK overall. For example, if you
are used to typing the separators such as 25/ and having it come up
automatically.

1. Entering dates: 

- if you start, but don't finish (for example, you get interrupted), the date
clears after about 14-15 seconds (for some date fields only). For example:
Patron date of birth, type 2023 (where date format = -MM-DD).

- if you partially complete a date, for example 20.02.2 then click away (for
example another tab or application window) it autocompletes the date using what
is in the date picker - in the example it would add it as 2023. Another
example: 20. and then click on another window, makes it 20.01.2023. If date
picker doesn't have Yesterday or Today options, and you click away on another
tab/window, it is cleared.

- acquisitions - adding an item from an existing record: item details - date
acquired - autocompletes, when you click away, doesn't time out; accounting
details - estimated date of delivery - same behavour.

- cataloguing - dateaccessioned.pl plugin (added to a tag for a framework):
defaults to today's date (as expected), you can change.

- log viewer: as per acquisitions.

2. Dates with time: for example, checkouts and specifying the due date - from
the date picker if you select any date (including Yesterday, Today, and
Tomorrow) it puts the time as 23:59; entering it manually, it automatically
makes it 00, and you can't enter the seconds (I vaguely remember testing for a
bug where the time was important and caused "issues", but I can't remember
what).

3. Koha About > Licenses page: I think we normally add the license information
for libraries used in Koha.

4. OPAC - there doesn't seem to be too many places where there is a date field,
but this may just depend on modules enabled: 

- Placing a hold: doesn't seem to work, for example: for a record select Place
a hold, then show more options - can't manually enter the date (note that there
are no Yesterday Today Tomorrow options - only today's date and future dates).

- Your account > Personal details > Date of birth: doesn't time out, if you
click away it autocompletes if it can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
Owen,

I am having trouble getting content to appear when language packs are
installed.

I have installed both fr-FR and es-ES, turned them on, and added content in the
right place for that language. Then I am switching to that language and
registering. 

Maybe I am missing something but can you check once more?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395

Lucas Gass  changed:

   What|Removed |Added

 Attachment #156127|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 156134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156134=edit
Bug 33395: Patron search results - show number of overdues and checkouts when
patrons have overdues

This fixes the display of patron search results, so that it shows
the number of checkouts when a patron has overdue items. For
example: 1 / 2

Bug 30063 changed the display to show only the number of overdue
items in bold and red, without the total number of items checked
out.

Test plan:
1. Check out two items to a patron - make one overdue (click the
   checkout setting options and then specify a due date a month
   ago).
2. Check out another item to another patron.
3. Search for patrons so that the two patrons you checked out
   items to are listed in the results.
4. Note the display for the 'Checkouts' column:
   4.1 For patrons without any checkouts: 0 / 0
   4.2 For the patron from step 2 with one checkout: 0 / 1
   4.3 For the patron from step 1 with one overdue and one
   checkout: 1 (in bold and red)
5. Apply the patch.
6. Refresh the page of results (step 3).
7. Note that for the patron from step 1, the display now shows:
   1 / 2 (with the 1 in bold and red).
8. Sign off! 8-)

Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33050] Allow to specify quote char in runreport.pl

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33050

David Nind  changed:

   What|Removed |Added

 Attachment #152499|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 156133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156133=edit
Bug 33050: Allow to specify quote char in runreport.pl

Add to script misc/cronjobs/runreport.pl quote char arg (only for CSV).
See perl doc https://metacpan.org/pod/Text::CSV#new

This patch also adds missing '--separator' in POD.

Test plan :
1 - Write a SQL report
2 - perl misc/cronjobs/runreport.pl --format csv 1 (or correct report number)
3 - Note you get double quotes
4 - Apply patch
5 - Repeat #2 - no change
6 - perl misc/cronjobs/runreport.pl --format csv --quote "'" 1
7 - Now it is single quote delimited
8 - perl misc/cronjobs/runreport.pl --format tsv --separator "'" 1
9 - Error is reported, you cannot set quote unless csv
10 - Try empty string as quote

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33050] Allow to specify quote char in runreport.pl

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33050

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #15 from David Nind  ---
I had a go at testing, but I got some errors when running the script:

- with the help option:

misc/maintenance/dedup_authorities.pl --help
Undefined subroutine ::pod2usage called at
misc/maintenance/dedup_authorities.pl line 99.

- duplicated an authority record, the attempted to run using the date option:

misc/maintenance/dedup_authorities.pl -v -c -m date
Fetching authtypecodes...
The method Koha::Authority::Types->authtypecode is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572
Koha::Objects::AUTOLOAD('Koha::Authority::Types=HASH(0x564621d97918)') called
at misc/maintenance/dedup_authorities.pl line 132

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/