[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |
 Status|Signed Off  |Failed QA

--- Comment #29 from Victor Grousset/tuxayo  ---
Works as expected, here is a 2nd signoff :)

I couldn't get it to change the password of another user via editing and
resending the POST query  and the code looks well guarded against that 

Code looks good functionally.

I found this:
`print $input->redirect(...)` followed by `exit;` is used in many other pages
to make guard closes. So it seems to me we can avoid wrapping the whole happy
path in an `else {...}`

That also avoids the need to indent tons of lines. Or to choose to not do it
which makes perltidy complain a lot. And about much more than actually changed
lines.

So just some polishing and it will be good :)
I'll go ask about what should be the default value of StaffLoginResetPassword
for new installs and existing installs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20192] ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192

Roland Keck  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #5 from Roland Keck  ---
Can be closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #156514|0   |1
is obsolete||

--- Comment #28 from Victor Grousset/tuxayo  ---
Created attachment 156516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156516=edit
Bug 30700: (follow-up) Redirect to patron page after changing password

This patch ensures the logged in user is redirected to the patron detail page
after successfully changing another patron's password (rather than the
homepage).

Signed-off-by: Sam Lau 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #156513|0   |1
is obsolete||

--- Comment #27 from Victor Grousset/tuxayo  ---
Created attachment 156515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156515=edit
Bug 30700: (follow-up) Add system preference StaffLoginResetPassword

This syspref wraps around the functionality added for patrons with the
'catalogue' permission to reset their own password via the staff client.

Signed-off-by: Sam Lau 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #153292|0   |1
is obsolete||

--- Comment #26 from Victor Grousset/tuxayo  ---
Created attachment 156514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156514=edit
Bug 30700: (follow-up) Redirect to patron page after changing password

This patch ensures the logged in user is redirected to the patron detail page
after successfully changing another patron's password (rather than the
homepage).

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #153291|0   |1
is obsolete||

--- Comment #25 from Victor Grousset/tuxayo  ---
Created attachment 156513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156513=edit
Bug 30700: (follow-up) Add system preference StaffLoginResetPassword

This syspref wraps around the functionality added for patrons with the
'catalogue' permission to reset their own password via the staff client.

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff interface should be able to change their own password

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #153290|0   |1
is obsolete||

--- Comment #24 from Victor Grousset/tuxayo  ---
Created attachment 156512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156512=edit
Bug 30700: Allow staff users to change their password via staff client

Patrons who can log into the staff client (have the 'catalogue'
permission) should be able to change their own password.

To test:
0) Apply the patch, install database updates, restart services. Go to System
preferences and enable the StaffLoginResetPassword system preference.
1) Create a user with only 'catalogue' permissions (Patron A)
2) Log in to the staff client as Patron A
3) Click the menu with your username in the top-right of the window.
Click the 'your account' menu link.
4) Confirm you are forced to a login screen, so you cannot view your
account, which is where the 'change password' link is normally found.
5) Try to access the page to change your password directly
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X
(swap Patron A's borrowernumber in). Confirm you are forced to a login
screen.
6) Apply this patch and restart services. Go back to the mainpage logged
in as Patron A.
7) Click the menu with your username in the top-right of the window.
Notice there is now a 'Change password' menu link. Go to 'change
password'.
8) Confirm you are now shown a page to change your password. Change your
password, and confirm you are redirect to the mainpage.
9) Try to access the page to change someone else's page directly
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X
(swap some other borrowernumber in). Confirm you are redirected to a
404.
10) Log out and log back in as your original borrower. Confirm you are
able to change your password as normal.

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind 
Signed-off-by: Sam Lau 
Rebased-by: Victor Grousset/tuxayo 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

Amit Gupta  changed:

   What|Removed |Added

 CC||amit.gupta@informaticsgloba
   ||l.com,
   ||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335

--- Comment #15 from David Cook  ---
If folk don't want it in core Koha, that's fine.

I'm already using this pattern in existing plugins. I've found it useful and
thought others would too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335

--- Comment #14 from David Cook  ---
(In reply to Marcel de Rooy from comment #13)
> Why not just call something like:
> 
> perl -MKoha::Plugin::RMA::ItemHook::Adapter
> -e"Koha::Plugin::RMA::ItemHook::Adapter->new->install"
> 
> etc.
> 
> Do we really need a script for that?

That's an overly simplistic example.

For a more complicated example, you'd need to write a full custom Perl script. 

This change means you don't need a custom script. You can just pass in
configuration/data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

--- Comment #6 from David Cook  ---
I've been thinking about this topic for some time... and maybe a solution is to
create a new Template::Toolkit filter that uses C4::Scrubber/HTML::Scrubber. 

An old version already exists on CPAN:
https://metacpan.org/pod/Template::Plugin::Filter::HTMLScrubber

We could either use that one or come up with our own.

The tough part here is the configuration. Deciding how rigid/flexible to make
it for long-term maintainability but also end-user usability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709

--- Comment #5 from David Cook  ---
Using the following I found one more instance:

egrep -R " on[a-z]+=" koha-tmpl/opac-tmpl/*

Bug 34980

Once we've pushed the dependent bugs, we'll be adhering to
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events
in the OPAC!

It would also allow us to start using Content-Security-Policy in the OPAC...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709

David Cook  changed:

   What|Removed |Added

 Depends on||34980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980
[Bug 34980] Remove the use of event attributes from title-actions-menu.inc in
OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980

David Cook  changed:

   What|Removed |Added

 Blocks||34709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709
[Bug 34709] Eliminate event handler attributes in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34980] New: Remove the use of event attributes from title-actions-menu.inc in OPAC

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980

Bug ID: 34980
   Summary: Remove the use of event attributes from
title-actions-menu.inc in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

There are some event attributes in the title-actions-menu.inc include. These
should be removed in favor of defining events in JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709

--- Comment #4 from David Cook  ---
Thanks for taking care of this, Owen. You're a legend. I haven't had time
lately so really appreciate it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33934] 'No encryption_key in koha-conf.xml' needs more detail

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33934

--- Comment #16 from David Cook  ---
(In reply to Marcel de Rooy from comment #15)
> For purists, taken from Crypt::CBC
> 
> -pass,-key  The encryption/decryption passphrase. These arguments
>are interchangeable, but -pass is preferred
>("key" is a misnomer, as it is not the literal 
>encryption key).
> 
> So our "encryption key" is a misnnomer too :)
> It is a passphrase used to generate the real encryption key.

That's true although I think colloquially it's all right to call it the
encryption key. 

> We say now: We recommend one of at least 32 bytes.
> It should be formally at least 16 bytes (AES blocksize) in order to be safe.
> So 32 is fine. Shouid we enforce a minimum length in Koha::Encryption?

Probably a good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976

--- Comment #2 from David Cook  ---
Having a single master key isn't uncommon, but it could be nice to be able to
have multiple encryption keys and to specify which one is needed for what
feature.

I think that this mechanism could be especially useful for key rotation. (I
notice Marcel has already commented on bug 32078 where we had talked a bit
about key rotation.) I've used other systems where I've rotated encryption keys
in this way. 

Another future use could be data interchange. Perhaps you'd want to share
encrypted data with another system without giving that other system your master
key. You could just encrypt that particular information with a shared key while
keeping most other data encrypted using a master key. This scenario is pretty
hypothetical though.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes some
  release notes||inconsistencies in the MARC
   ||bibliographic framework
   ||administration page, making
   ||sure the page title,
   ||breadcrumb navigation, and
   ||page headers are consistent
   ||with each other.
 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
I've signed off, but there were two that I wasn't sure of.

1. View subfield constraints


Tab title: Tag 006 > Books, Booklets, Workbooks (BKS) >  MARC bibliographic
frameworks > Administration > Koha

Breadcrumb:  Administration > MARC bibliographic frameworks > Books, Booklets,
Workbooks (BKS) > Tag 006 subfield structure

Page title: Tag 006 subfield structure (framework BKS)

Comment: maybe the tab title should be 'Tag XXX subfield structure'?


2. Edit subfield constraints


Tab title: Edit subfields constraints > Tag 006 > Books, Booklets, Workbooks
(BKS) > MARC bibliographic frameworks  > Administration > Koha

Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets,
Workbooks (BKS) > Tag 006 > Edit subfields constraints

Page title: Tag 006 subfield constraints

Comment: I don't know why, but 'subfields constraints' seems wrong to me. There
could be multiple subfields, with each of them having constraints. But it just
sounds wrong to me... So I prefer 'Tag 006 subfield constraints'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393

David Nind  changed:

   What|Removed |Added

 Attachment #156506|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 156511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156511=edit
Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles,
breadcrumbs, and header

This patch fixes some inconsistencies in the MARC bibliographic
framework administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The file admin/marc_subfields_structure.pl is modified so that it
provides the framework name to the template.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- MARC bibliographic frameworks
  - New framework
  - Edit framework
  - Delete a framework which is not used
  - Delete a framework which is in use
  - Framework MARC structure
- New tag
- Edit tag
- Delete tag
- View subfields
- Edit subfields

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34925] Favorite reports

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34925

--- Comment #2 from Christopher Brannon  ---
(In reply to Michael Adamyk from comment #1)
> This would be different from a Report Group so that you could have any
> report marked as a Favorite, regardless of its Report Group -- is that
> correct?

Correct.  It would also be based on the logged in person.

If a table was in order, it might be foresight to construct the table in such
away that the borrowernumber and table it is referring to is listed, in
addition to specific report number.  That way, if we found use of favorites
elsewhere in Koha, we could use the same table to store those favorites.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34552] No Results when filtering "All payments to the library" or "payment" in Statistics wizards : Cash register

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552

--- Comment #21 from Christopher Brannon  ---
(In reply to Matt Blenkinsop from comment #20)
> Nice work everyone!
> 
> Pushed to oldstable for 22.11.x

Thank you!  :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264

Suzanne  changed:

   What|Removed |Added

   Priority|P5 - low|P2

--- Comment #2 from Suzanne  ---
Any chance we could get some movement on this bug? It is a continued source of
frustration for patrons and staff. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check for multiple holds allowed on a record

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260

--- Comment #4 from Christopher Brannon  ---
(In reply to Christopher Brannon from comment #1)
> I agree that this AllowHoldsOnPatronsPossessions is a problem.
> 
> Currently, we have certain records that we allow mulitple holds on.  The
> patron cannot place a hold on one of these items if they have something on
> that record checkout out and AllowHoldsOnPatronsPossessions is set to Don't
> allow.  This preference needs to take into account circ rules that allow
> multiple holds on a record.

Would really like to see this oversight or conflict in logic addressed.  It is
an ongoing issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

Caroline Cyr La Rose  changed:

   What|Removed |Added

Summary|AutoApprovePatronProfileSet |System preferences missing
   |tings missing from  |from sysprefs.sql
   |sysprefs.sql|

--- Comment #2 from Caroline Cyr La Rose  ---
Feel free to close if this is completely irrelevant :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] AutoApprovePatronProfileSettings missing from sysprefs.sql

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

--- Comment #1 from Caroline Cyr La Rose  ---
Also missing

- EmailSMSSendDriverFromAddress
- HidePersonalPatronDetailOnCirculation
- ManaToken
- OPACDetailQRCode
- OverDriveAuthname
- OverDriveWebsiteID
- RecordStaffUserOnCheckout
- SelfCheckInModuleUserID

And not removed from the db after being moved out of sysprefs, also not sure if
it's supposed to be like that or not.

- OpacMoreSearches
- OPACMySummaryNote

This one is in sysprefs.sql but not in updatedatabase.pl

- UpdateNotForLoanStatusOnCheckout

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] New: AutoApprovePatronProfileSettings missing from sysprefs.sql

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

Bug ID: 34979
   Summary: AutoApprovePatronProfileSettings missing from
sysprefs.sql
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I'm wondering if this is normal. The system preference
AutoApprovePatronProfileSettings is in updatedatabase.pl and in patrons.pref,
but not in sysprefs.sql (unless I'm not looking in the right place).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399

--- Comment #1 from Owen Leonard  ---
Created attachment 156510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156510=edit
Bug 34399: Fix inconsistencies in Record overlay rules page titles,
breadcrumbs, and headers

This patch fixes some inconsistencies in the record overlay rules
page, making sure the page title, breadcrumb navigation, and page
headers are consistent with each other.

Test the record matching rules page to confirm that page title, heading,
and breadcrumbs are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34399] Inconsistencies in Record overlay rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34399

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398

--- Comment #1 from Owen Leonard  ---
Created attachment 156509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156509=edit
Bug 34398: Fix inconsistencies in Record matching rules page titles,
breadcrumbs, and headers

This patch fixes some inconsistencies in the record matching rules
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Some controls on this page have been updated to use Bootstrap link style
with Font Awesome icons added.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Record matching rules
  - New record matching rule
  - Edit record matching rule
  - Delete record matching rule
  - Test the process of adding new match points and new match checks,
and removing match points and match checks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978

Émily-Rose Francoeur  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||emily-rose.francoeur@inLibr
   ||o.com,
   ||philippe.blo...@inlibro.com
   Assignee|koha-b...@lists.koha-commun |emily-rose.francoeur@inLibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34978] New: Add --include and --exclude options to install_plugins.pl to choose the plugins to install

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978

Bug ID: 34978
   Summary: Add --include and --exclude options to
install_plugins.pl to choose the plugins to install
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emily-rose.franco...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

It would be great to be able to choose which plugins to install and which ones
not to install when using the install_plugins.pl
script([Koha]/misc/devel/install_plugins.pl).

The --include option would take a list of plugins and only install those. 
The --exclude option would take a list of plugins and install all plugins
except those.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34963] Unable to delete notes in suggestions

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397

--- Comment #1 from Owen Leonard  ---
Created attachment 156508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156508=edit
Bug 34397: Fix inconsistencies in Classification sources page titles,
breadcrumbs, and headers

This patch fixes some inconsistencies in the classification
configuration administration page, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

Test each view to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Classification configuration
  - New classification source
  - Edit classification source
  - New filing rule
  - Edit filing rule
  - New splitting rule
  - Edit splitting rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34395] Inconsistencies in Authority types page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34395

--- Comment #2 from Owen Leonard  ---
Created attachment 156507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156507=edit
Bug 34395: Fix inconsistencies in Authority types page titles, breadcrumbs, and
header

This patch fixes some inconsistencies in the authority
types administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- Administration -> Authority types
  - New authority type
  - Edit authority type
  - Delete an authority type which is not used
  - Delete an authority type which is in use
  - Authority type MARC structure
- New tag
- Edit tag
- Delete tag
- View subfields
- Edit subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34395] Inconsistencies in Authority types page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34395

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Emily Lamancusa  changed:

   What|Removed |Added

 Depends on||31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169

Emily Lamancusa  changed:

   What|Removed |Added

 Blocks||20955
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955
[Bug 20955] Add ability to trigger holds that violate holds policies
(overridden holds)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|ASSIGNED|In Discussion

--- Comment #6 from Emily Lamancusa  ---
+1 for adding a flag - holds violating the holds policy should trap if and only
if the hold policy was explicitly overridden. Retaining that information in a
flag seems like a good way to enforce that.

Even with an override flag, there are some possible side effects with bib level
holds, though... For sure I can see problems for consortia that have
set-in-stone rules about which branches can and cannot share resources, but
allow overrides for other reasons. With a simple true/false override flag, a
hold that was placed with an override for other reasons (e.g. patron category,
hold limits, etc) could unintentionally override the branch restriction and
trigger a transfer that may not be possible or reasonable to actually fulfill.

I'm not sure what the solution is here.
- Flagging which specific policies were overridden when the hold was placed?
(seems messy and with a high potential for side effects)
- More granularity in the sysprefs governing which policies are allowed to be
overridden at all? (I think this would be great, but not sure if this is the
right place)
- Apply this enhancement only to item-level holds, or give
TriggerForbiddenHolds three settings - All / Item-level only / Off?

We at MCPL would definitely like to see something like this go through (our
staff often place holds to get their hands on items for workflow reasons, and
currently that doesn't work for items that aren't normally holdable). But I
think it needs a bit more examination to make sure it isn't unusable for
systems that need to keep some things set in stone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34977] The "Patron Lists" only allows deleting one list at a time

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977

Salah Ghedda  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com
   Assignee|koha-b...@lists.koha-commun |salah.ghe...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34977] New: The "Patron Lists" only allows deleting one list at a time

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977

Bug ID: 34977
   Summary: The "Patron Lists" only allows deleting one list at a
time
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: salah.ghe...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Instead of deleting one list at a time, it's more helpful to be able to delete
multiple lists at once by adding checkboxes for each list along with a button
(at the bottom or top of the page) to enable the deletion of multiple lists at
once.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976

--- Comment #1 from Jonathan Druart  ---
Why that? Security?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

--- Comment #5 from Marcel de Rooy  ---
(In reply to David Cook from comment #1)
> In master, I'm only seeing Koha::Encryption used in Koha::Patron, and within
> Koha::Patron it's used in the function "encode_secret".

Unfortunately this is no longer true. EDI and Acquisition started using it too.
See the other report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32078] We should have an easy way for an administrator to update the encryption keys

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #4 from Marcel de Rooy  ---
Bug 34976 - Encryption keys should not be shared between modules

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976

Marcel de Rooy  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au,
   ||jonathan.druart+koha@gmail.
   ||com,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34976] New: Encryption keys should not be shared between modules

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976

Bug ID: 34976
   Summary: Encryption keys should not be shared between modules
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

At this time we are using the encryption key in koha-conf to encrypt stuff for
2FA, EDI and Acquisition already. The key was introduced for 2FA.

I think that it would be better to differentiate and use separate keys for
various processes in Koha. For instance, the key for 2FA should be used
exclusively for that purpose.
We could consider if that is needed also for EDI and Acq since these are
related modules. They could use one or two new keys.

When adding a new call to Encryption, we should think about it. Perhaps this
would be forced a bit more by passing a parameter to K::E indicating which key
to use?

Opening the discussion :) What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838

--- Comment #16 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #6)
> Note that 4 warnings remain
> 
> t/db_dependent/Koha/Illbackend.t .. Use of uninitialized value in exists at
> /kohadevbox/koha/Koha/Illrequest.pm line 1956.
> Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm
> line 1961.
> Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm
> line 1956.
> Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm
> line 1961.

So this was t/db_dependent/Koha/Illbackend.t

But the problem remains for t/db_dependent/Illrequests.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393

--- Comment #2 from Owen Leonard  ---
Created attachment 156506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156506=edit
Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles,
breadcrumbs, and header

This patch fixes some inconsistencies in the MARC bibliographic
framework administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The file admin/marc_subfields_structure.pl is modified so that it
provides the framework name to the template.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- MARC bibliographic frameworks
  - New framework
  - Edit framework
  - Delete a framework which is not used
  - Delete a framework which is in use
  - Framework MARC structure
- New tag
- Edit tag
- Delete tag
- View subfields
- Edit subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34393] Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #15 from Jonathan Druart  ---
I am still getting a lot of warnings

t/db_dependent/Illrequests.t .. 1/15 illrequestattributes is DEPRECATED in
favor of extended_attributes at t/db_dependent/Illrequests.t line 101.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 111.
t/db_dependent/Illrequests.t .. 6/15 Subroutine Koha::Illrequest::SUPER::status
redefined at /kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 884.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 884.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 884.
t/db_dependent/Illrequests.t .. 8/15 Subroutine Koha::Illrequest::SUPER::status
redefined at /kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1013.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1013.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1013.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1033.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1033.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1033.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1071.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1071.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1071.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1114.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1114.
illrequestattributes is DEPRECATED in favor of extended_attributes at
t/db_dependent/Illrequests.t line 1114.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
t/db_dependent/Illrequests.t .. 11/15 Subroutine
Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm
line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
t/db_dependent/Illrequests.t .. 12/15 Subroutine
Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.
t/db_dependent/Illrequests.t .. 14/15 Subroutine
Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm
line 922.
Subroutine Koha::Illrequest::SUPER::status_alias redefined at
/kohadevbox/koha/Koha/Object.pm line 922.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

--- Comment #6 from Jonathan Druart  ---
(quick note)
test_connection returns 500 if credentials are not correct (I guess it's the
problem).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Emily Lamancusa  changed:

   What|Removed |Added

 CC||mada...@ckls.org

--- Comment #5 from Emily Lamancusa  ---
*** Bug 28788 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28788] Default holds policy by item type can be overridden but holds will not capture

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28788

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Emily Lamancusa  ---


*** This bug has been marked as a duplicate of bug 20955 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33934] 'No encryption_key in koha-conf.xml' needs more detail

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33934

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #15 from Marcel de Rooy  ---
For purists, taken from Crypt::CBC

-pass,-key  The encryption/decryption passphrase. These arguments
   are interchangeable, but -pass is preferred
   ("key" is a misnomer, as it is not the literal 
   encryption key).

So our "encryption key" is a misnnomer too :)
It is a passphrase used to generate the real encryption key.

We say now: We recommend one of at least 32 bytes.
It should be formally at least 16 bytes (AES blocksize) in order to be safe. So
32 is fine. Shouid we enforce a minimum length in Koha::Encryption?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #62 from Jonathan Druart  ---
This is not very nice, but the tests now pass and it's flexible enough for now
IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #156483|0   |1
is obsolete||

--- Comment #61 from Jonathan Druart  ---
Created attachment 156505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156505=edit
Bug 32474: Pass label and identifier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

--- Comment #60 from Jonathan Druart  ---
Created attachment 156504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156504=edit
Bug 32474: Adjust tests

We need to use the same data, for instance we had "license name" and
"first license name" for the license with license_id=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

R Bradshaw  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/738
 Status|Needs documenting   |RESOLVED

--- Comment #10 from R Bradshaw  ---
Hi - This has been added to the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

R Bradshaw  changed:

   What|Removed |Added

  Alias|Rebecca |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

R Bradshaw  changed:

   What|Removed |Added

  Alias|Bradshaw|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

R Bradshaw  changed:

   What|Removed |Added

  Documentation||Rebecca Bradshaw
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838

Pedro Amorim  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Pedro Amorim  ---
*** Bug 34897 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34897] ILL unit tests have lots of 'redefined' warnings

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34897

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Pedro Amorim  ---


*** This bug has been marked as a duplicate of bug 34838 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

R Bradshaw  changed:

   What|Removed |Added

 CC||rebecca.brads...@nnuh.nhs.u
   ||k
  Alias||Rebecca, Bradshaw

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34955] One Koha manual (to rule them all)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34955

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Emily Lamancusa  ---
The script output looks right in terms of which items should renew, but the
renewal itself doesn't seem to be happening. After running the cron with the
--confirm switch, the item's due date doesn't change, and the patron's
checkouts table line for that item still says "Scheduled for automatic renewal
(2 of 2 renewals remaining and 2 of 2 unseen renewals remaining)". The patron
does have a queued automatic renewal notice saying that the item renewed and is
due on the original due date.

I tried again with only the first patch applied and got the same result, so I'm
guessing the problem is there somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #68 from Tomás Cohen Arazi  ---
Follow-up pushed to master, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34967] Move Prices.t to t/db_dependent

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34942] Typo: brower

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34942] Typo: brower

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34917] Fix suggestions.tt table default sort column

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34917

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34801] Fix incorrect use of __() in .tt and .inc files (bug 34038 follow-up)

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34801

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34391] Inconsistencies in Cash registers page headers

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34389] Inconsistencies in Debit types page titles, breadcrumbs, and header

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34934] Remove the use of event attributes from OPAC lists page

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34934] Remove the use of event attributes from OPAC lists page

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34930] Fix timezone problem in Koha/Object.t

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34930

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34930] Fix timezone problem in Koha/Object.t

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34930

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918

--- Comment #10 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34918] Koha/Items.t crashes on missing borrower 42 or 51

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34918

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded

2023-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842

--- Comment #15 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >