[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #13 from Katrin Fischer --- Created attachment 157177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157177=edit Bug 27943: (QA follow-up) Alternate display in result lists The original display put the equivalent heading right after the main heading with a = as separator. As the 7xx are repeatable that could get croweded easily, also if the terms are longer we might see not so nice breakage. This puts every 7xx on its own line below the main heading with some indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 --- Comment #12 from Katrin Fischer --- Created attachment 157176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157176=edit Bug 27943: (QA follow-up) Perltidy I have some trouble to get the tidyness test on AuthoritiesMarc.pm passing. There are several outstanding patches touching this file, so I didn't dare to perltidy the whole file just yet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #154502|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 157175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157175=edit Bug 27943: (follow-up) Fix unit test, and use systempreference AuthoritySeparator Instead of hardcoding the separator we take the value from systempreference. Also adjust the unit test to expect the "equalterm" array. Test plan same as before. Signed-off-by: Christian Nelson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #133712|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 157174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157174=edit Bug 27943: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Attachment #132778|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 157173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157173=edit Bug 27943: add support for 7XX equal terms on authorities marc21 display Currently when a MARC21 authority has 7XX field they do not display on authority search result page. 7XX is equal term of 1XX based on LC rules. Applying this patch will enable that feature, which is important for non latin catalogues. Test plan: 1) Add a new authority with 1XX and 7XX fields. 2) Try to search that authority and check if 7XX values are displayed 3) Apply this patch 4) Try to search that authority and you will see that 7XX values are displayed like "1XX = 7XX" Sponsored-by: Keratsini-Drapetsona Municipal Library, Greece Mentored-by: Andreas Roussos Signed-off-by: Frank Hansen Works for me! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3007] Remove untranslated unimarc_field_700-4 value builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |vic...@tuxayo.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35058] New: No contents displaying when an authority record is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Bug ID: 35058 Summary: No contents displaying when an authority record is saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org I believe this has to do with our changes for tabs: When an authority record is edited and saved, you get directed to the authority detail page, but only the tabs themselves and no contents show. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #37 from Katrin Fischer --- Created attachment 157172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157172=edit Bug 10762: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Attachment #154562|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 157171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157171=edit Bug 10762: (follow-up) Add tests Signed-off-by: Johanna Miettunen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Attachment #154561|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 157170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157170=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Attachment #154560|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 157169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157169=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Attachment #154559|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 157168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157168=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #20 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #19) > (In reply to Katrin Fischer from comment #18) > > I think removing them would be nice, but is probably a page specific change > > whie this takes care of the general elements. I think maybe we could take a > > closer look at other pages separately. Also: patron search results has a > > export > print option on the table that gives nice results :) > > Alright, let's go with the current proposal then! :) > > > > minor findings: > > > - on record detail page, should the content of the descriptions tab be > > > after > > > the list of items? And same for acquisition details. No reliable idea on > > > what is more relevant when printing, mentioning this just in case. > > > > They both appear after the item list for me. And it doesn't matter which tab > > is active before switching to print layout. > > My phrasing was weird. I meant that they are indeed after the item list, but > should they? > (It sounded that like I was suggesting that they should be after. But it's > already the case) That's the sequence in the source code, I think it's correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #7) > > 1) Go in System preferences and find the "UseBranchTransfertLimits". > > 2) Change the value of "Don't enforce" to "Enforce". I honestly need a little help here. In the patch we still see the dependency on UseBranchTransferLimits, but the test plan in the commit message doesn't mention the preference. Could you please revise the test plan? Please also check below and the results I got there: > I don't understand why the behavior you've coded here only applies when > UseBranchTransfertLimits is set to Enforce. These two separate dropdowns > exist regardless of whether or not one is using Branch Transfer Limits. > > More importantly, this patch breaks existing behavior when I have two items > on the same bib with different allowed pickup locations. To recreate: > > (apply patch, set UseBranchTransfertLimits to Enforce) > 1: Set Hold Pickup Library Match in circ rules to "item's hold group" > 2: Create two library groups, both defined as local holds groups. Give each > group a couple of libraries, making sure they don't overlap > 3: Find or create a biblio record with two items. The items should be held > by different libraries, one in each of your hold groups > 4: try to place a hold on your bib. on reserve/request.pl, observe that you > have 3 pickup location dropdown (one for the biblio, one for each item) and > that all 3 show the same value. That's not the case in my test. I got: Library group F: Fairfield, Fairview Library group C: Centerville, Liberty Items: Fairfield, Centerville Pickup location pull downs: * Record level: All 4 * Item Fairfield: Fairfield, Fairview * item Centerville: Centerville, Liberty > 5: confirm that changing the biblio-level dropdown forces the page to reload > and changes both item dropdowns to match what you selected in the biblio > dropdown When I change the record level pick-up location, nothing happens to the item level ones. > 6: HOWEVER -- your items each have a distinct set of allowed pickup > locations. One of your two items will be showing a branch at which it is not > allowed to be picked up. Can't replicate this behaviour. > 7: attempt to place the item-level hold with an illegal pickup location that > koha has suggested to you. observe that Koha leaves the holds creation page > without actually making a hold or giving an error message. Can't replicate this behaviour. BUT: I see the wrong behaviour if UseBranchTransferLimits is Set to "Don't enforce". * Set prefernece to "Don't enforce" * Change the biblio record pick-up location from Centerville (logged in library) to something else and back to Centerville. * Items do have pickup location Centerville now. But this is not allowed for the Fairfield item. * When saved, the hold is not placed. Then I get the behaviour that invalid pickup locations will get selected for my items, although they are not actually listed in the pull downs. This only happens with the patch applied :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||michaela.sie...@kit.edu --- Comment #29 from Katrin Fischer --- Hi, this is a really interesting feature! Some notes: 1) The QA test tools are currently still failing, but it's only a perltidy that is needed. 2) The database update still has the old format and should be moved to the newer atomic update template. 3) The system preference is added correctly, but should a) Include a note that this feature is "Elasticsearch only" b) Be moved to the "Features" section instead of the "Did you mean" where it appears now. 4) It didn't work in my testing :( Maybe something broke with changes made to the OPAC since this was submitted the first time? * I used ktd --es7 up * Made sure SearchEngine was Elasticsearch and search worked * Applied patch * restart_all * Turned on OPACDisplayRecordCount system preference I don't see any errors in the console, but the JSON responses come back empty, possibly because the q param is empty:: http://localhost:8080/cgi-bin/koha/svc/elasticsearch/opac-elasticsearch.pl?q=[]=nb_notice ? I searched for "perl" in a MARC21 sample database and paged through a lot of the results with no counts showing. 5) Code review * Please translate code comments if you want to keep them: +/* Regex pour tous les URL avec un recherche */ This uses the older /svc pattern, we might want to get a second more technical review on this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #18) > I think removing them would be nice, but is probably a page specific change > whie this takes care of the general elements. I think maybe we could take a > closer look at other pages separately. Also: patron search results has a > export > print option on the table that gives nice results :) Alright, let's go with the current proposal then! :) > > minor findings: > > - on record detail page, should the content of the descriptions tab be after > > the list of items? And same for acquisition details. No reliable idea on > > what is more relevant when printing, mentioning this just in case. > > They both appear after the item list for me. And it doesn't matter which tab > is active before switching to print layout. My phrasing was weird. I meant that they are indeed after the item list, but should they? (It sounded that like I was suggesting that they should be after. But it's already the case) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9567] Favorite reports per user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 Lauren Denny changed: What|Removed |Added CC||lauren_de...@sil.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de Summary|Show the number of records |Show the number of records |in the bibliographic record |in the bibliographic record |detail page with|detail page with |ElasticSearch. |ElasticSearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24833] Field ending punctuation needs to consider abbreviations and exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35036 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35036] Incorrect chopping to punctuation in 246 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24833 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35036] Incorrect chopping to punctuation in 246 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- There are some issues with this this patch set: * If a library does the ending . at the end of fields, it will now keep showing. As we always always remove it, that will be inconsistent. The chop punctuation is thought to remove that ending dot, but the problem is that we cannot distinguish between an abbreviation dot and the field ending punctuation. This is not only a problem for 246, it's a general known issue. * Removing the common separator | on the staff results page doesn't give the expected result (missing space at least, but also no longer consistent) Other title: TitleA : RemainderA.TitleB : RamainderB. I think if we want to change this, we need to find a general solution and apply it to more than only the 246 field. I believe this needs more thought. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 Katrin Fischer changed: What|Removed |Added Attachment #156788|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 157167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157167=edit Bug 27249: Replace DateTime->now by dt_from_string Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 Katrin Fischer changed: What|Removed |Added Attachment #156787|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 157166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157166=edit Bug 27249: Add missing POD for Koha::Exceptions::Calendar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 Katrin Fischer changed: What|Removed |Added Attachment #156786|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 157165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157165=edit Bug 27249: Fix code style Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 Katrin Fischer changed: What|Removed |Added Attachment #154921|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 157164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157164=edit Bug 27249: Catch NoOpenDays exception while checking out an item Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249
Katrin Fischer changed:
What|Removed |Added
Attachment #154920|0 |1
is obsolete||
--- Comment #19 from Katrin Fischer ---
Created attachment 157163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157163=edit
Bug 27249: Prevent infinite loop when searching for an open day
Calendars can be configured in a way that all days are closed.
The simplest way to do that is to configure a repeatable holiday for
every day of the week.
With such calendars, searching for an open day will literally take
forever.
This patch sets a hard limit on how many iterations are allowed before
giving up. This limit is set to the arbitrary value of 5000, which
should be large enough to be able to consider there is no open days if
we haven't found any with that many iterations, and small enough to
allow the loop to end quickly
Test plan:
1. Set system preference 'useDaysMode' to 'Use the calendar to push the
due date to the next open day' ('Datedue'). Make sure the existing
circulation rules do not conflict with that setting.
2. Browse to Tools » Calendar
3. Set every day of the week to "Holiday repeated every same day of the
week"
4. Issue an item to a patron
5. Check the box and select 'Renew selected items'
6. The renewal should fail pretty quickly
Signed-off-by: Sam Lau
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a library can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #19 from Michaela Sieber --- First of all thank you for the work you already did! I added two of our main providers = Springer and De Gruyter Testing results: -- HARVESTING -- Harvesting of about 190.000 rows for SpringerLink was done with some errors, e.g. Building the Cycling City could not be processed - please check the logs Statistische Datenanalyse mit SPSS für Windows could not be processed - please check the logs Concise Manual of Hematology and Oncology could not be processed - please check the logs See http://staff-usagestats.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/admin/background_jobs.pl?op=view=40 It would be helpful if you could provide the number of titles successfully added/that could not be processed in the Job report similar to the number of usages added/skipped. The same with De Gruyter, many titles could not be processed. -- REPORTS -- Feedback on sorting reports tables: E-resource management > eUsageReports > View report I tried to sort by month March but the table was not sorted, just processing It would be great to have a 'Reporting_Period_Total' column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34901] Item-level holds can show inaccurate transit status on the patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer changed: What|Removed |Added Attachment #157067|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 157162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157162=edit Bug 34901: Display transit status on patron holds tab only if hold found value is "T" Check the transit status of the *hold* in addition to the transit status of the *item*, to avoid displaying a misleading transit status on item-level holds when the item is actually in transit for a different hold To test: 1. Create a record-level hold for Patron A for pickup at a library other than the logged-in library 2. Check in an item to fill that hold 3. Put an item-level hold on that same item for Patron B at a different library other than the logged-in library 4. Open Patron A's and Patron B's account details pages in separate tabs --> Note that the Holds tab on Patron A's account detail page correctly shows that their hold is in-transit --> Note that the Holds tab on Patron B's account detail page incorrectly shows that their hold on the same item is also in-transit 4. Apply patch 5. Clear browser cache 6. Refresh both patrons' account details pages --> Confirm that the holds tab on Patron A's account still correctly says their hold is in-transit --> Confirm that the holds tab on Patron B's account now correctly shows a blank status for their hold 7. Cancel Patron A's hold 8. Check in the item again to put it in transit for Patron B's hold 9. Reload Patron B's account page --> Confirm that the holds tab on Patron B's account now correctly says their hold is in-transit Signed-off-by: Katariina Hanhisalo Signed-off-by: Tuomas Kunttu Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34901] Item-level holds can show inaccurate transit status on the patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34901] Item-level holds can show inaccurate transit status on the patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added Attachment #156814|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 157161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157161=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119
Katrin Fischer changed:
What|Removed |Added
Attachment #156813|0 |1
is obsolete||
--- Comment #16 from Katrin Fischer ---
Created attachment 157160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157160=edit
Bug 34119: (Preliminary) Run stylelint fixes on print.css
This patch corrects errors raised by the new stylelint configuration in
print.css. Most of the fixes were made automatically by using the
"--fix" option:
npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix
Some examples of errors fixed automatically:
- Expected indentation of 4 spaces
- Unexpected whitespace before ":"
- Unexpected unit
- Expected single space before "{"
- Expected newline after ";" in a multi-line declaration block
Errors from use of "!important" have been ignored.
Signed-off-by: Marcel de Rooy
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] Improve staff interface print stylesheet following redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35057] New: Improve table heading "Lib" in MARC field structure page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35057 Bug ID: 35057 Summary: Improve table heading "Lib" in MARC field structure page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When editing a MARC framework, the list of fields in a framework displays with "Lib" as a heading of the table. This is not very helpful without context and can cause confusion when translating. We have lots of space there for a nice table heading :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35055] Don't export actions column from patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35055 Katrin Fischer changed: What|Removed |Added Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35056] New: Can't search for library or patron category using search field on top of patron search table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35056 Bug ID: 35056 Summary: Can't search for library or patron category using search field on top of patron search table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The search field on top of the patron search results doesn't allow to search for 'Midway' or 'Patron'. It requires you to enter the codes instead. Like "CPL" will work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35055] New: Don't export actions column from patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35055 Bug ID: 35055 Summary: Don't export actions column from patron search results Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The "Edit" and "Checkout" links are included in the export files for patron search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29074] DefaultHoldExpirationdatePeriod blank value interpreted as zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Katrin Fischer ---
1) The changes make sense, but I wondered if it wouldn't be safer to change
sub _set_default_expirationdate {
my $self = shift;
my $period = C4::Context->preference('DefaultHoldExpirationdatePeriod') ||
0;
my $timeunit =
?
This would mean one change in one spot instead of changing 2.
We could just "do onthing" if DefaultHoldExpirationdatePeriod is
undefined/empty.
2) For the note I suggest a tiny rephrase:
If DefaultHoldExpirationdatePeriod
is left blank default expiration date is not set.
..., the default expiration date is not set.
..., no default expiration date is set.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added Attachment #157157|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 157159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157159=edit Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott Signed-off-by: Johanna Miettunen Signed-off-by: Päivi Knuutinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added Attachment #157156|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 157158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157158=edit Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott Signed-off-by: Johanna Miettunen Signed-off-by: Päivi Knuutinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added Attachment #157062|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 157157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157157=edit Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott Signed-off-by: Päivi Knuutinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added Attachment #157061|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 157156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157156=edit Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott Signed-off-by: Päivi Knuutinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 --- Comment #14 from Katrin Fischer --- This works as described, but only solves the issue on template side. We now have an API route for checkouts, should we add something there as well? ILS-DI? A small glitch that we could also fix separately: The messages on details/checkouts show up in different spots, one below and one above the heading. But this is also the case for other existing messages on these pages now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34910] Do not allow checkout for anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34910 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34852] Use template wrapper for breadcrumbs: OPAC part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer changed: What|Removed |Added Attachment #157055|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 157155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157155=edit Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Navigate to /cgi-bin/koha/ilsdi.pl - Check a variety of links in the list - Advanced search - Locate a bibliographic record and view the ISBD detail page - View the MARC detail page - Locate a serial record which has a patron notification notice defined in its subscription details - On the detail view under the "Subscriptions" tab, click the "Subscribe to email notification on new issues" button. - Confirm the subscription, then when you return to the detail page, click "Cancel email notification" to check that view as well. - Authority search - Perform a search which will return results - Click the "Details" link on one of the results - Also view the "MARC view" tab (note that I didn't address the breadcrumb inconsistency between the normal and MARC view in this patch). - Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 942$n to 1 to suppress it in the OPAC. - In a system with ElasticSearch enabled, go to "Browse search" (or navigate directly to /cgi-bin/koha/opac-browse.pl - With OpacBrowser enabled, go to "Browse by hierarchy." Signed-off-by: Philip Orr Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34852] Use template wrapper for breadcrumbs: OPAC part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34852] Use template wrapper for breadcrumbs: OPAC part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer changed: What|Removed |Added Attachment #157064|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 157154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157154=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page Signed-off-by: Philip Orr Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35042] Members.t: should not set datelastseen to NULL everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35042 Katrin Fischer changed: What|Removed |Added Attachment #156954|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 157153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157153=edit Bug 35042: Remove set datelastseen to null on table in Members.t Non-trivial was adding the category_type <> S. Test plan: Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35042] Members.t: should not set datelastseen to NULL everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35042 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35042] Members.t: should not set datelastseen to NULL everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35042 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34966] Terminology: Add item form - "Add & duplicate" should be "Add and duplicate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 --- Comment #6 from Katrin Fischer --- (In reply to David Nind from comment #4) > Thanks Katariina and Reetta for signing off! Thanks from me too :) Keep going! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34966] Terminology: Add item form - "Add & duplicate" should be "Add and duplicate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer changed: What|Removed |Added Attachment #157066|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 157152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157152=edit Bug 34966: Terminology - fix add item form (& to and) This patch updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology Test plan: 1. In the staff interface, search for and select a record. 2. Select New > New item. 3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form. 4. Apply the patch. 5. Refresh the page. 6. Note that the action button is now labelled 'Add and duplicate'. 7. Sign off! 8-) Signed-off-by: David Nind Signed-off-by: Katariina Hanhisalo Signed-off-by: Reetta Pihlaja Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34966] Terminology: Add item form - "Add & duplicate" should be "Add and duplicate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34966] Terminology: Add item form - "Add & duplicate" should be "Add and duplicate"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34966 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 Katrin Fischer changed: What|Removed |Added Attachment #156990|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 157151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157151=edit Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the item search fields administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch makes some changes to the way new item search fields are added in order to keep the display consistent with other similar interfaces: The "add" form is no longer shown dynamically from the page listing item search fields. Clicking the "New search field" toolbar button will now take you to the same template used for editing existing search fields. This allows us to put the correct context into page title, breadcrumbs, and headings. To test, apply the patch and go to Administration -> Item search fields. Test the process of adding a new search field and editing an existing search field. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34401] Inconsistencies in Item search fields page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34401 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #266 from Katrin Fischer --- This is almost there, but we need a small fix for the circulation rules editor. When a rule is edited and the Pickup period is "Default" (was saved as empty before), the "Default" shows up in the input field. This is bad as it will break on save and also when translated. We need to make it show up as empty when the rule is edited. And as 0 when 0 was entered. My patch didn't work and created a display issue at the beginning of the table (second column). Aleisha, could you have a go please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157150|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #265 from Katrin Fischer --- Created attachment 157150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157150=edit Bug 8367: Make sure "Default" is not copied when editing circulation rules When editing a circulation rules the "Default" was copied into the input field. This would cause problems on saving and especially with translations. So now the field will be empty and appear as "Default" after saving as we already do it for other values with "unlimited". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #264 from Katrin Fischer --- Created attachment 157149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157149=edit Bug 8367: (QA follow-up) Fix QA script * Add +x to atomic database update file * Perltidy * Add spans to rewritten tab label for translatability Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153246|0 |1 is obsolete|| --- Comment #263 from Katrin Fischer --- Created attachment 157148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157148=edit Bug 8367: Add holds_pickup_period fallback circulation rule Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153245|0 |1 is obsolete|| --- Comment #262 from Katrin Fischer --- Created attachment 157147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157147=edit Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153244|0 |1 is obsolete|| --- Comment #261 from Katrin Fischer --- Created attachment 157146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157146=edit Bug 8367: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153243|0 |1 is obsolete|| --- Comment #260 from Katrin Fischer --- Created attachment 157145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157145=edit Bug 8367: (follow-up) possible to delete circ rule Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153242|0 |1 is obsolete|| --- Comment #259 from Katrin Fischer --- Created attachment 157144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157144=edit Bug 8367: (follow-up) Remove unnecessary code and atomic update Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153241|0 |1 is obsolete|| --- Comment #258 from Katrin Fischer --- Created attachment 157143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157143=edit Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153240|0 |1 is obsolete|| --- Comment #257 from Katrin Fischer --- Created attachment 157142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157142=edit Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153239|0 |1 is obsolete|| --- Comment #256 from Katrin Fischer --- Created attachment 157141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157141=edit Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153238|0 |1 is obsolete|| --- Comment #255 from Katrin Fischer --- Created attachment 157140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157140=edit Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153237|0 |1 is obsolete|| --- Comment #254 from Katrin Fischer --- Created attachment 157139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157139=edit Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #153235|0 |1 is obsolete|| --- Comment #253 from Katrin Fischer --- Created attachment 157138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157138=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34363] Clicking on Holds or Overdues on the patron summary on OPAC links you to Checkouts tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34363 Owen Leonard changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34813] Passing empty array from pl result in empty string in tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34813 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 --- Comment #1 from Owen Leonard --- Created attachment 157137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157137=edit Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34980] Remove the use of event attributes from title-actions-menu.inc in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34980 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35049] Add ability to choose which status is included in MaxOpenSuggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35049 Owen Leonard changed: What|Removed |Added Component|OPAC|System Administration Version|unspecified |master Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org CC||gmcha...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31080] Block adding the bundle item to its own bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32178] query parameters in check_api_auth lets anyone assume a user id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34321] Tidy skeleton too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34321 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34351] ILL list table - access_url column content should be clickable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34351 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34598] Error 500 is shown when ILL request is not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 34418, which changed state. Bug 34418 Summary: Allow empty nodes in breadcrumb's elements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34217] Add missing cypress tests for vendors in agreements and licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34217 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
