[Koha-bugs] [Bug 12532] Copy guarantee email to guarantor (or redirect if guarantee has no email set)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #170 from Kati Sillgren --- Thanks for this new feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. To show the comments column for the table in the database: SHOW FULL COLUMNS FROM biblioitems; 2. To see the updated comments: apply the patch, reset_all, repeat step 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What|Removed |Added Attachment #158022|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 158056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158056&action=edit Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode This fixes a typo in the comment. To test: * Please check diff of the patch closely. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35180] Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35180 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 --- Comment #6 from David Nind --- (In reply to David Nind from comment #5) > The only thing I noticed with the WELCOME notice, is that it displayed OK > for me before the patch under Patrons > [Account] > Notices, but the email > received was all on one line. After the patch, there are extra lines > displayed under Patrons > [Account] > Notices, but the email received is now > nicely formatted. I tried using s instead of s - no visible change > for email message received, and only slightly better under Patrons > > [Account] > Notices. Better that the email message that goes out is correct > by default. Please ignore these comments - just read the comments for the other bugs to address/look at this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | CC||da...@davidnind.com --- Comment #5 from David Nind --- All nice improvements! The only thing I noticed with the WELCOME notice, is that it displayed OK for me before the patch under Patrons > [Account] > Notices, but the email received was all on one line. After the patch, there are extra lines displayed under Patrons > [Account] > Notices, but the email received is now nicely formatted. I tried using s instead of s - no visible change for email message received, and only slightly better under Patrons > [Account] > Notices. Better that the email message that goes out is correct by default. I changed the bug assignee 8-) Testing notes (using KTD): 1. Add email to KohaAdminEmailAddress system preference. 2. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 3. WELCOME - Before the patch: . Displays OK for me if you view the message under Patron > [Account] > Notices . The email received (after running misc/cronjobs/process_message_queue.pl) is all on one line - After the patch: . There are extra lines if you view the message under Patron > Notices (not a showstopper for me - better that the email that goes out is correct) . The email received (after running misc/cronjobs/process_message_queue.pl) is now correctly formatted and looks great! . I tried using tags instead of tags: the email message comes through the same, the preview under Patrons > [Account] > Notices looks slightly better, but still has extra lines . Not sure what the best way to do this is! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What|Removed |Added Attachment #158050|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 158055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158055&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34899] Circulation Rules: Only Allow "Local Use" Patron Category to Place Hold on Specific Branch Copies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34899 --- Comment #4 from Katrin Fischer --- On first glance, I would have expected that the hold policy: From home library: Only patrons from the item's home library may put this book on hold. would do the trick. I haven't tested, but mine would look a little different than the ones from your example: | 27 | NULL | NULL | BK | hold_fulfillment_policy | homebranch| | 28 | NULL | NULL | BK | returnbranch | homebranch| | 29 | NULL | NULL | BK | holdallowed | from_home_library | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #1 from Katrin Fischer --- 22.11 is the LTS... it would be great to get some help here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34428] Update database creates a wrong table transport_cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428
--- Comment #2 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #1)
> Bug 23995 removed it from kohastructure.sql but still exists in
> updatedatabase.pl
That's not great... right?
It's this update here, still in updatedatabase:
$DBversion = "3.09.00.037";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$dbh->do("INSERT INTO `systempreferences`
(variable,value,explanation,options,type)
VALUES('UseTransportCostMatrix',0,'Use Transport Cost Matrix when filling
holds','','YesNo')");
$dbh->do("CREATE TABLE `transport_cost` (
`frombranch` varchar(10) NOT NULL,
`tobranch` varchar(10) NOT NULL,
`cost` decimal(6,2) NOT NULL,
`disable_transfer` tinyint(1) NOT NULL DEFAULT 0,
CHECK ( `frombranch` <> `tobranch` ), -- a dud check, mysql does
not support that
PRIMARY KEY (`frombranch`, `tobranch`),
CONSTRAINT `transport_cost_ibfk_1` FOREIGN KEY (`frombranch`)
REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT `transport_cost_ibfk_2` FOREIGN KEY (`tobranch`)
REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8");
print "Upgrade to $DBversion done (creating `transport_cost` table; adding
UseTransportCostMatrix systempref, in circulation)\n";
SetVersion($DBversion);
}
Should we fix and try to drop the CHECK in a database update?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What|Removed |Added Text to go in the||This removes unnecessary release notes|| tags in two ||email notices: ||* ||PASSWORD_RESET ||* ||STAFF_PASSWORD_RESET ||These ||notices are only updated in ||new installations, for ||existing installation ||manually change the ||notices. CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. After applying the patch, ran reset_all, so that the notices are updated. 2. Needed to set the OpacResetPassword and KohaAdminEmailAddress system preference. OpacResetPassword required for Patron account > More > Send password reset option to appear. 3. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #3 from Katrin Fischer --- Thanks David :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186
David Nind changed:
What|Removed |Added
Attachment #158048|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 158054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158054&action=edit
Bug 35186: Remove unnecessary html tags from PASSWORD notices
In HTML notices we don't need to explicitly use .
This removes them from the 2 notices using them:
* PASSWORD_RESET
* STAFF_PASSWORD_RESET
To test:
* Apply patch
* Make sure your Koha can send email (set up SMTP server,
KohaAdminLibraryAddress)
* Make sure your patron has an email set
* In patron account, use "More > Send password reset"
* Log out
* In the OPAC, request password reset ("forgot your password?")
* Verify both notices appear nicely formatted (line breaks, bold, etc.)
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32980] Checkouts for guarantees are not shown if patron also has a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32980 --- Comment #20 from Katrin Fischer --- (In reply to Katrin Fischer from comment #19) > Hm, I can double check the OPAC behaviour maybe. But I think having > different behaviour for staff and OPAC is also at least confusing. I didn't get back to test this one yet. I am happy to have someone else take the lead here and won't block any decision made. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Katrin Fischer changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Katrin Fischer --- We should definitely add these to sysprefs.sql. I feel like we used to have an automated test or something in the QA script to catch these, but couldn't find it. Joubu, do you know maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34596] Items in transit should not show up in the holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34596 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW --- Comment #3 from Katrin Fischer --- Any update on this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #27 from Katrin Fischer --- I wanted to check the 'size' of this problem a bit more and did some testing. And it's not as bad as one would think: I tested the HTML notices especially and the results are interesting: 1) Slips: use explicit line breaks When a slip template is printed in the browser, only br and other block elements will cause a line break. I fixed some of our sample notices on bug 35187. 2) E-mail notices: use explicit line breaks When an email is sent in HTML format, only br and other block elements will cause a line break. I fixed the WELCOME notice also on bug 35187. 3) Print notices with gather_print_notices and --html: implicit line breaks Note that we have a known display bug on the notices tab: bug 30287. It shows implicit line breaks, not reflecting how the actual email will look later. --- (In reply to Martin Renvoize from comment #24) > OK, I see you're points now. > > This was meant to be "least invasive", but I do agree it would be nice to > drop it entirely and require proper HTML throughout for these notices. > > The challenge will be to write a DB update that looks at all the existing > notices and fixes them for all current html notices to include the breaks. We have never used the --html option on this job so I can't tell about how widely it would be used. I am not sure it's worth messing with the existing notices. * If you have a working email template that is used as a fallback for print, it will definitely add unnecessary/additional line breaks. * So only explicit print layouts that use HTML could be affected negatively. I'd like to avoid a system preference for this inconsistent behavior... but could a command line switch for 'implicit_line_breaks' help some? > Also, we'd need to update all the existing default notices for install. It's not as big an issue as one would think. I already did it: I fixed all HTML notices in the 3 bugs dependent on this one: 35185, 35186, 35187 With these 3 bugs I believe we can consider the sample notices fixed and improved. It helps that most our notices are still plain text (is_html: 0) > This is all a much larger job that we were expecting to undertake here.. > worthwhile I suppose, but I'm not sure where I'm going to find funding for > that extra time. We can have this go in as is, but I believe removing would be better instead of changing the output somewhat arbitrarily. Maybe we should just "bite the bullet" here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #1 from David Cook --- *** Bug 27236 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27236] Package PO translation files separately to koha-common
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27236 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #11 from David Cook --- *** This bug has been marked as a duplicate of bug 35174 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #24 from David Cook --- (In reply to Jonathan Druart from comment #22) > Why do you want to remove C4::Context from updatedatabase? What would be the > gain? While I don't directly accuse C4::Context in bug 34088, it is one reason for slowness when running updatedatabase.pl against a large number of instances. Philippe, you might find that bug interesting. That one isn't for the memory footprint per se but rather speed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #27 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #25) > (In reply to Martin Renvoize from comment #23) > > I had a look to see if there was any obvious way to get the instance name or > > track up to find the parent PID so we could call the HUP call mentioned > > above.. but I failed so far. > > Is a SIGHUP on all starmans running on a large shared hosting server a > paralyzing load? On the occasional plugin install/upgrade/uninstall. If you ran ./misc/devel/install_plugins.pl against all instances, it would be a paralyzing load on a large shared hosting server, yes. If it was just on a web upload or a single install for ./misc/devel/install_plugins.pl then it should be fine since it would just be restarting 1 starman master process. Certainly something to be careful with... I'm a bit apprehensive about giving a web user the ability to restart Starman. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind changed: What|Removed |Added Attachment #158051|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 158053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158053&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 David Nind changed: What|Removed |Added Attachment #158041|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 158052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158052&action=edit Bug 34520: Fix FK for item_groups in reserves for new installations There was a discrepancy between the database update for reserves and the kohastructure.sql definition. This makes sure that the FK is always "ON DELETE SET NULL". To test: * Before applying this path * sudo koha-mysql kohadev * show create table reserves; CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE * Apply patch * Run database update * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE * reset_all (create a new database) * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Aleisha Amohia --- Hi Kelly, I think you may have been seeing that message if you forgot to apply the patches from Bug 33478 first. Bug 33478 now needs to be rebased so will update when this patchset can be tested again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35184] Consolidate UNIMARC value builders for 100, 124, 125, 125
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35184 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What|Removed |Added Attachment #158047|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158051&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What|Removed |Added Attachment #158049|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158050&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 --- Comment #2 from Katrin Fischer --- Created attachment 158049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158049&action=edit Bug 35187: Make sure HTML notices use explicit line breaks When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Affects: * ISSUEQSLIP * ISSUESLIP * TRANSFERSLIP * CHECKINSLIP * HOLD_SLIP * WELCOME The biggest change is the WELCOME notices. With this patch it appears no longer on only one line, but properly formatted. To test: WELCOME * Without patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Welcome email" * Verify all text is on one line * Apply patch * reset_all to install new sample notice templates * Repeat test, verify welcome notice is now nice ISSUESLIP, ISSUEQSLIP * Checkout at least 2 items * Print > Print slip * Print > Print quick slip * Verify both look nice! CHECKINSLIP * Return both items * Print checkin slip (button in list of checkouts) * Verfiy... you know, that it looks nice! TRANSFERSLIP * Checkin an item from another library * "Print transfer slip" * Verify again. HOLD_SLIP * Place a hold on a record * Return an item that can fill the hold * "Print slip and confirm" * Verify. * Note: if you compare to before, this also removes a <> appearing instead of the city. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #1 from Katrin Fischer --- *** Bug 35018 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35018] Welcome notice contains just a bit of HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35018 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 35187 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35018] Welcome notice contains just a bit of HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35018 --- Comment #2 from Katrin Fischer --- I'll fix this as part of bug 35187 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 [Bug 35187] Fix line breaks in some HTML notices, including WELCOME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] New: Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Bug ID: 35187 Summary: Fix line breaks in some HTML notices, including WELCOME Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Blocks: 34704 When a notices is marked as HTML, we need to use block elements (p, div, li, etc.) or explicit line breaks. This adds the line breaks where required. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #2 from Katrin Fischer --- The WELCOME notice needs to be fixed to be proper HTML as it includes a link to the catalog. Removing from patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186
--- Comment #1 from Katrin Fischer ---
Created attachment 158048
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158048&action=edit
Bug 35186: Remove unnecessary html tags from PASSWORD notices
In HTML notices we don't need to explicitly use .
This removes them from the 2 notices using them:
* PASSWORD_RESET
* STAFF_PASSWORD_RESET
To test:
* Apply patch
* Make sure your Koha can send email (set up SMTP server,
KohaAdminLibraryAddress)
* Make sure your patron has an email set
* In patron account, use "More > Send password reset"
* Log out
* In the OPAC, request password reset ("forgot your password?")
* Verify both notices appear nicely formatted (line breaks, bold, etc.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 [Bug 35186] Remove html tags from sample notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35186] New: Remove html tags from sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Bug ID: 35186 Summary: Remove html tags from sample notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Blocks: 34704 HTML notices don't require that we explicitly add tags. We have 2 notices where these are included in the sample notices and should be removed: PASSWORD_RESET STAFF_PASSWORD_RESET Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Depends on||35185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 [Bug 35185] Remove is_html flag from sample notices for text notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What|Removed |Added Blocks||34704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #1 from Katrin Fischer --- Created attachment 158047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158047&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY * WELCOME We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35185] New: Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Bug ID: 35185 Summary: Remove is_html flag from sample notices for text notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org We have a few notices that are not formatted using HTML tags, but are still marked as "is_html". This will cause issues with line breaks. Example: - module: members code: 2FA_OTP_TOKEN branchcode: "" name: "two-authentication step token" is_html: 1 title: "Two-authentication token" message_transport_type: email lang: default content: - "Dear [% borrower.firstname %] [% borrower.surname %] ([% borrower.cardnumber %])" - "" - "Your authentication token is [% otp_token %]." - "It is valid one minute." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #25 from Alex Buckley --- (In reply to Katrin Fischer from comment #24) > (In reply to Marcel de Rooy from comment #23) > > My current thought would be: I do not oppose this as a workaround with > > commitment to follow up and improve. > > Hi Marcel, what would you ask for as follow-up/improvements here in order to > pass? Hi Katrin and Marcel, Thanks for your replies. Yes, Marcel if you wouldn't mind noting what you would want as follow-ups/improvements here that would be helpful so we can raise them with our sponsoring library. Thanks so much, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #24 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #23) > My current thought would be: I do not oppose this as a workaround with > commitment to follow up and improve. Hi Marcel, what would you ask for as follow-up/improvements here in order to pass? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer changed: What|Removed |Added Keywords||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Katrin Fischer changed: What|Removed |Added Attachment #146792|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 158046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158046&action=edit Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 --- Comment #6 from Katrin Fischer --- (In reply to Julian Maurice from comment #5) > (In reply to Katrin Fischer from comment #4) > > Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look > > like that in the manual. Any hints? > Can this issue be moved to another bug report ? This is blocking bug 30975 > and the patch doesn't change anything functionally Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer changed: What|Removed |Added Attachment #146789|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 158045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158045&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #8 from Katrin Fischer --- (In reply to Julian Maurice from comment #7) > (In reply to Katrin Fischer from comment #4) > > This works, but doesn't really seem to make sense. > > It's not linked by default anywhere and it uses the template of UNIMARC 100. > > Looking at the definition of 125 doesn't clear things up either. > > (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) > > Can this issue be moved to another bug report ? This is blocking bug 30975 > and the patch doesn't change anything functionally Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35184] New: Consolidate UNIMARC value builders for 100, 124, 125, 125
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35184 Bug ID: 35184 Summary: Consolidate UNIMARC value builders for 100, 124, 125, 125 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It looks like all these plugins do the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31029] ILL request ID in ILL history table should link to the ILL request if permissions allow for it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31029 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Confirmed, this works now: http://localhost:8081/cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34424] Update release team on about page for new QA team member
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Katrin Fischer --- Self SO and directly for QA team review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34424] Update release team on about page for new QA team member
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 --- Comment #1 from Katrin Fischer --- Created attachment 158042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158042&action=edit Bug 34424: Add Emily Lamancusa to QA Team Long overdue. To test: * Apply patch * Verify that Emiley shows as part on the QA Team on the About page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34424] Update release team on about page for new QA team member
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34424] Update release team on about page for new QA team member
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34488] Cannot import default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488 Katrin Fischer changed: What|Removed |Added Summary|Import default framework|Cannot import default ||framework -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34488] Import default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488 Katrin Fischer changed: What|Removed |Added Version|23.05 |master --- Comment #1 from Katrin Fischer --- I can confirm this. * Export default MARC framework - works OK * Change field description of LEADER * Import default MARC framework * Confirm security question "Do you really..." * Watch loading... * Get redirected to the page, that you see when editing an empty framework * Go back to the Default framework * Confirm the LEADER description hasn't been changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #4 from Katrin Fischer --- In the end, it wasn't that confusing, but check my patch carefully please :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #3 from Katrin Fischer --- Created attachment 158041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158041&action=edit Bug 34520: Fix FK for item_groups in reserves for new installations There was a discrepancy between the database update for reserves and the kohastructure.sql definition. This makes sure that the FK is always "ON DELETE SET NULL". To test: * Before applying this path * sudo koha-mysql kohadev * show create table reserves; CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE * Apply patch * Run database update * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE * reset_all (create a new database) * Check database again: CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE CASCADE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520
--- Comment #2 from Katrin Fischer ---
OK, now I totally confused myself here:
kohastructure.sql:
reserves
CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES
`item_groups` (`item_group_id`) ON DELETE CASCADE ON UPDATE CASCADE
This means, that when the item_group is deleted, we delete the reserve. I think
this could create possible issues as we usually should not delete but cancel
(move to old_reserves). If we set to null, it turns itself into a title level
hold, which seems safer at least. I think SET NULL would make more sense here
too.
old_reserves
CONSTRAINT `old_reserves_ibfk_ig` FOREIGN KEY (`item_group_id`) REFERENCES
`item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE SET NULL
So, when an item_group is deleted, we set it to null in old_reserves. This
makes sense, as we would want to keep the entry for hold statistics.
Database update:
unless ( column_exists( 'reserves', 'item_group_id' ) ) {
$dbh->do(q{
ALTER TABLE reserves
ADD COLUMN `item_group_id` int(11) NULL default NULL AFTER
biblionumber,
ADD CONSTRAINT `reserves_ibfk_ig` FOREIGN KEY (`item_group_id`)
REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL ON UPDATE
CASCADE;
});
}
unless ( column_exists( 'old_reserves', 'item_group_id' ) ) {
$dbh->do(q{
ALTER TABLE old_reserves
ADD COLUMN `item_group_id` int(11) NULL default NULL AFTER
biblionumber,
ADD CONSTRAINT `old_reserves_ibfk_ig` FOREIGN KEY
(`item_group_id`) REFERENCES `item_groups` (`item_group_id`) ON DELETE SET NULL
ON UPDATE SET NULL;
});
}
I suggest to alter the database definition to fit the original updates.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What|Removed |Added Blocks||34520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What|Removed |Added Depends on||24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34989] Subscription cannot be added if a control field is set up in "Additional Fields" parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34989 Katrin Fischer changed: What|Removed |Added Version|23.05 |master --- Comment #1 from Katrin Fischer --- Confirmed in current development version. Tested with 001 and 001@. It would be nice if we could add support as the 001 would be really useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What|Removed |Added Attachment #157223|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 158040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158040&action=edit Bug 35073: perltidy subscription-batchedit.pl git show -w Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What|Removed |Added Attachment #157222|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 158039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158039&action=edit Bug 35073: Default to existing value if there is one For values that dont exist in the batch edit submission, i.e. UI says 'No change', we default to existing value if there is one. Test plan: Preparation - Additional fields: 1) Add a new 'additional field', visit: /cgi-bin/koha/admin/additional-fields.pl 2) Click 'subscription' and '+ New field'. Enter a 'name' and hit 'save'. Serials: 1) Add a new serial, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Put a biblionumber in the 'record' field, i.e. '112'. Press 'next' and click 'ok' on the alert box 3) Fill all the required fields and click 'test prediction' 4) Input something in the additional field created previously. 5) Click 'save subscription'. Notice the additional field is as expected. 6) Repeat steps 1-5 to create a second serial. Batch edit: 1) Visit serials and hit the 'Search' button: /cgi-bin/koha/serials/serials-home.pl 2) Click the 2 checkboxes for the 2 serials we created previously and click the new link that pops up 'edit selected serials'. 3) Click 'Save' without changing anything. 4) Go back to either of the serials, notice the value for the additional field is unchanged. Visit: /cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What|Removed |Added Attachment #157221|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 158038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158038&action=edit Bug 35073: Rename additional_fields to available_additional_fields 'additional_fields' is ambiguous and in other places we name this available_additional_fields instead. Do the same here. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35073] Serials batch edit deletes unchanged additional fields data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 Katrin Fischer changed: What|Removed |Added Severity|minor |major --- Comment #4 from Katrin Fischer --- This is a data loss bug, marking as major. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33842] Search for authid not returning right results with QueryAutoTruncate ON
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Janusz Kaczmarek changed: What|Removed |Added CC||janus...@gmail.com --- Comment #3 from Janusz Kaczmarek --- (In reply to Katrin Fischer from comment #2) > Maybe bug 32707 would fix this as well? Yes, it would--in a more general way, IMHO, also solving a problem of sn:1 and the like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #17 from Katrin Fischer --- (In reply to mathieu saby from comment #16) > Well, our vendor (Biblibre) told us not to activate the logs in general, but > we did not ask specifically if logging acquisition activities could impact > performances... > > Anyway, my colleagues asked recently for a way to *easily* track changes to > their funds by the acquisition coordinator (quite often at the end of the > year). We will give a try to the logging system, maybe it could suit our > needs, but I doubt that. It doesn't work right now. There is no logging implemented for fund changes, but only other acq activities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #16 from mathieu saby --- Well, our vendor (Biblibre) told us not to activate the logs in general, but we did not ask specifically if logging acquisition activities could impact performances... Anyway, my colleagues asked recently for a way to *easily* track changes to their funds by the acquisition coordinator (quite often at the end of the year). We will give a try to the logging system, maybe it could suit our needs, but I doubt that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #22 from Alex Buckley --- (In reply to David Nind from comment #21) > (In reply to Alex Buckley from comment #16) > > Hi David, > > > > Sorry for my delay, I've just back from a long holiday. I hope you are doing > > well :) > > > > I've rebased these patches against master. Ready to test again now. > > > > Alex > > Hi Alex. > > Welcome back! I hope you had a great holiday! (I'm doing well, thanks!) > > I've now signed off. > > I've also updated the system preference description, mainly for consistency > with other system preferences (such as NOTE in capitals, script name in a > code block) as well as some other wording changes. Feel free to remove if > you prefer the original description. > > David Hi David Thanks so much, yes I did have a very nice holiday around Italy with my parents it was lovely. That's great to hear you're doing well :) Thank you for testing and signing off, also appreciate your update to the system preference description that is much better now! Kind regards, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32479] Replace sort: ~ by sort: 0 in mappings.yaml file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32479 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- It looks like this was fixed with the first patch of: Bug 33594 - Sorting results by Title A-Z might use wrong title field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8367 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 --- Comment #3 from Katrin Fischer --- The display issue here might be fixed by Bug 8367 - How long is a hold waiting for pickup at a more granular level It removes the number from the tab, as with it being in the circulation rules multiple different values might apply. For the timing, I am not sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34504] Elasticsearch error when updating mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34504 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I just tested and believe this was fixed by patches on other bugs. The sortable pull down now shows Yes/No. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7827] After creating a new biblio to be used in a subscription, the subscription entry form should be populated with the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7827 --- Comment #3 from Katrin Fischer --- I just tested this and the biblionumber was not sent back to the form when closing the window. 1) Add new subscription 2) Create record link 3) Downloaded a record from Z39.50 4) Fixed errors 5) Saved 6) Went to item form, instead of closing 7) Closing window manually - biblionumber remains empty. If this is not supposed to work, maybe we should open the cataloguing form in a new tab instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Katrin Fischer changed: What|Removed |Added Component|Acquisitions|Templates Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | --- Comment #1 from Katrin Fischer --- It looks like this is still the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34783] Update list of 'Contributing companies and institutions' on about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34783 --- Comment #3 from Katrin Fischer --- (In reply to Martin Renvoize from comment #2) > Coming up to release.. please remind me a little closer and I can work with > Tomas to get it done.. must admit, I've forgotten how the scripts work at > this point. *ping* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35095 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32783 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #9 from Katrin Fischer --- Is this a duplicate of bug 32783 now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32699] Patron browse 'forgets' how many entries to show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32699 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I just tested this in the current development version and in 22.11: * Searched for 'all' patrons with an empty search * Changed per page setting to 10 * Clicked on an entry in the list, going to the patron account * Used the browser back button - setting remained I think we cannot save longer than this right now - there is no cookie or similar for this type of setting on the tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33842 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33842] Search for authid not returning right results with QueryAutoTruncate ON
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32707 --- Comment #2 from Katrin Fischer --- Maybe bug 32707 would fix this as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer changed: What|Removed |Added Attachment #145875|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 158037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158037&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
