[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 --- Comment #76 from Ray Delahunty --- My apologies, but one thing I should have noticed in testing was the unexpected order of results delivered. Prior to the patch I believe the sort was on column 2 (Transferred), with newest at the top, but now it appears to be on column 1 (Type). Certainly the ordering for us goes INVOICE > ORDERS > ORDRSP > QUOTE. Within those I don't know what further ordering is based on. Default sorting based on Transferred (newest at the top) would be the preferred option I think- it certainly is mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #6 from Jonathan Druart --- See also: ktd changes https://gitlab.com/koha-community/koha-testing-docker/-/issues/402 Wiki page about the context (move to Weblate) https://wiki.koha-community.org/wiki/Translation_server_migration_weblate Reference wiki page: https://wiki.koha-community.org/wiki/Translation_files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #5 from Jonathan Druart --- Created attachment 159024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159024=edit Bug 35174: Don't run gulp po commands if po dir is missing Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #4 from Jonathan Druart --- Created attachment 159023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159023=edit Bug 35174: Add misc/translator/po to .gitignore Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #3 from Jonathan Druart --- Created attachment 159022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159022=edit Bug 35174: Add a warning to the about page Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35174] Remove .po files from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174 --- Comment #2 from Jonathan Druart --- Created attachment 159021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159021=edit Bug 35174: Do not explode if po dir does not exist Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #8 from David Cook --- While I think we should ultimately retire the "Cataloging search", this at least makes it a bit more usable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 --- Comment #7 from David Cook --- Created attachment 159020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159020=edit Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 --- Comment #6 from David Cook --- (In reply to Lucas Gass from comment #3) > The same is true for checked out items. No location information is > displayed. Only "Checked out (x)" It looks like the data comes straight from searchResults and is displayed like this: [% IF ( resultsloo.onloancount ) %] Checked out ([% resultsloo.onloancount | html %]), [% END %] [% IF ( resultsloo.withdrawncount ) %] Withdrawn ([% resultsloo.withdrawncount | html %]), [% END %] [% IF ( resultsloo.itemlostcount ) %] Lost ([% resultsloo.itemlostcount | html %])[% END %] [% IF ( resultsloo.recalledcount ) %] Waiting to fill recall ([% resultsloo.recalled | html %])[% END %] [% IF ( resultsloo.onholdcount ) %] Waiting on hold ([% resultsloo.onholdcount | html %])[% END %] Whereas for notforloan it's displayed a bit differently. That said, there is a "onloan_items_loop" which could be used to display the items... [% IF ( resultsloo.other_items_loop ) %] [% FOREACH items_loo IN resultsloo.other_items_loop %] [% IF ( items_loo.notforloan ) %][% items_loo.notforloan | html %] ([% items_loo.count | html %])[% END %] [% END %] [% END %] It's a bit of a mess... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34018] Patron image upload silently fails without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook changed: What|Removed |Added Severity|normal |enhancement --- Comment #3 from David Cook --- I've raised bug 35344 which warns if the patron is missing the cardnumber and prevents an attempt at uploading the patron image. I think that's the most I'm going to do on this one without sponsorship. Going to change this from a bug to an enhancement... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34018] Patron image upload silently fails without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook changed: What|Removed |Added Summary|Patron image upload fails |Patron image upload |without cardnumber |silently fails without ||cardnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 --- Comment #1 from David Cook --- Created attachment 159019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159019=edit Bug 35344: Warn on patron image upload if missing cardnumber This change displays a warning message instead of the patron image upload feature in the patron record when the patron is missing the cardnumber. Without this change, the staff user can try to upload a patron image but it will silently fail. This change warns the staff user of the cardnumber requirement for patron image upload. Test plan: 0. Apply the patch 1. Enable the "patronimages" system preference 2. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 3. Click "Add" over the patron image placeholder 4. Note the "Upload photo" button and the ability to take a patron photo if your device has a camera 5. Remove "cardnumber" from BorrowerMandatoryField 6. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 7. Edit the patron to remove the cardnumber 8. Click "Add" over the patron image placeholder 9. Note that no patron image upload features appear. Instead, only a warning appears stating that the patron needs a cardnumber before the patron image upload can be performed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34018] Patron image upload fails without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35344 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34018 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35344] New: Patron image upload does not warn about missing cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 Bug ID: 35344 Summary: Patron image upload does not warn about missing cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As noted in bug 34018, the ./tools/picture-upload.pl silently fails if a patron doesn't have a cardnumber. It would be better to use the borrowernumber, but that would require rewriting the whole script, which seems like a lot of work for little gain. Instead, we'll add a warning / prevent upload if the patron doesn't have a cardnumber. That way the staff user can at least know they should add a cardnumber if they want to upload a patron image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34018] Patron image upload fails without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > I suppose there are some minor changes that could be made that could get it > over the line... Actually, I don't think so. I don't know what I was thinking back in June when I wrote this comment. While http://localhost:8081/cgi-bin/koha/members/moremember.pl does pass a borrowernumber, the handle_dir and handle_file functions are hard-coded to only accept cardnumber. Any change to just use borrowernumber would need to be tested, but then ./tools/picture-upload.pl isn't currently unit tested. But to unit test it you'd need to rewrite ./tools/picture-upload.pl, so it's just going to be too much work for too little gain. The workaround here is to just use a temporary dummy cardnumber for a patron when uploading a patron image. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34919] Unimarc 106 182
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34919 Igor A. Sychev changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31175] OPAC Logout should return you to where you were (unless that's a restricted page)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31175 --- Comment #4 from David Cook --- I think that Bug 34164 illustrates how "/cgi-bin/koha/opac-main.pl?logout.x=1" can be a problem. I wonder if there's anything that relies on ""/cgi-bin/koha/opac-main.pl?logout.x=1" currently though... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958
--- Comment #13 from David Cook ---
(In reply to Lucas Gass from comment #12)
> You're right, it comes down to preference. I am not sure if this even
> warrants another new system preference since one can just add to OPACUserCSS:
>
> #opac-main .breadcrumbs {
> display: none;
> }
>
>
> Maybe a sys pref is overkill and we should just "RESOLVE - WONT FIX" this
> one?
Part of me thinks a syspref is overkill, but it must be annoying having to add
that to each new instance, so I suppose I'd like to make everyone happy.
I suppose I always add the following to OPACUserCSS for every new instance, so
maybe we all have different bits and bobs we always add.
#logo {
display: none;
}
Previously, I've suggested adding a profile for koha-create that could setup
sysprefs in a vendor-specific way. That could be an interesting alternative
too...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958
--- Comment #12 from Lucas Gass ---
> Overall, I think this one might just come down to preference, so probably
> best to add a system preference.
You're right, it comes down to preference. I am not sure if this even warrants
another new system preference since one can just add to OPACUserCSS:
#opac-main .breadcrumbs {
display: none;
}
Maybe a sys pref is overkill and we should just "RESOLVE - WONT FIX" this one?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Aleisha Amohia changed: What|Removed |Added CC|alei...@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- I've never had any complaints about this from any libraries, and personally I like having the "Home" breadcrumb on the home page. Looking around online but not finding anything on this exact topic. I found oregon.gov used in an article on usability, and their Oregon Health Authority section is an example where the breadcrumb isn't shown on some home/landing pages, but I think it looks terrible. Although I think it's terrible because the banner is smaller on pages with the breadcrumb and bigger on pages without it, which makes for an inconsistent look and feel. I think my libraries would complain about content displaying higher on the home page without the breadcrumb and lower on pages with the breadcrumbs, but maybe I'm wrong. Maybe they wouldn't care either way. But I don't think we can 100% remove a visual element that's been present for so long without a way to bring it back. Overall, I think this one might just come down to preference, so probably best to add a system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309 Lucas Gass changed: What|Removed |Added Attachment #158978|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 159018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159018=edit Bug 35309: Remove DT's fnSetFilteringDelay On bug 35284 we added the delay on the column filters using dt's throttle builtin function. From doc: https://datatables.net/plug-ins/api/fnSetFilteringDelay """ Please note that this plug-in has been deprecated and the dt-init searchDelay option in DataTables 1.10 should now be used. This plug-in will not operate with v1.10+. Test plan: Note that column filtering still work as before (test on different tables, see bug 35284 for the list) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28129] Allow staff to add subscription alerts on behalf of patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28129 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1 from Donna --- This would be really helpful for special libraries, where patrons don't typically log in to the OPAC, but do want to get notifications. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #15 from David Nind --- All looks good and now working as expected. The documentation looks fine to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind changed: What|Removed |Added Attachment #159010|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 159017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159017=edit Bug 31415: Exclude found holds and fix hold ID call Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415
David Nind changed:
What|Removed |Added
Attachment #157002|0 |1
is obsolete||
--- Comment #13 from David Nind ---
Created attachment 159016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159016=edit
Bug 31415: Script to automate converting holds to recalls
This patch adds a script which can be used to automatically convert the
oldest hold on a record to a recall, if there are a specified minimum
number of holds on the record.
To test:
1) Enable UseRecalls and configure circulation rules relevant to
recalls. Keep the 'on shelf recalls allowed' setting to 'any' for the
sake of testing ('all' would require all items to be checked out for the
hold to be converted to a recall)
2) Check out items from multiple records (at least 2 different records)
to Patron A.
3) Place multiple holds on each record (at least 2 holds).
4) Place multiple holds on another record which has no items checked
out.
5) We now have multiple records where the oldest hold is eligible for
recall, plus a record where the oldest hold is NOT eligible for
recall (because no items are checked out).
6) In your terminal, get into the shell and run the script. -v means
verbose and will print the holds that are converted into recalls.
--min 1 means there must be more than 1 hold on the record to be
considered.
sudo koha-shell INSTANCE
perl misc/cronjobs/recalls/convert_holds_to_recalls.pl -v --min 1
7) Confirm that, for the records where items are checked out and there
are multiple holds, the oldest hold was converted into a recall
8) Confirm that, for the record where no items are checked out, the
holds all remain and not converted into a recall.
9) Confirm documentation for the script looks good
perldoc misc/cronjobs/recalls/convert_holds_to_recalls.pl
Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24035] When recording local use, there is no alert for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24035 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Lucas Gass --- This has been dealt with in Bug 27992. I am going to mark this as RESOLVED FIXED. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #158698|0 |1 is obsolete|| --- Comment #32 from David Nind --- Created attachment 159015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159015=edit Bug 23781: Add phone transport option Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #158697|0 |1 is obsolete|| --- Comment #31 from David Nind --- Created attachment 159014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159014=edit Bug 23781: Make atomic updates executable and perltidy fixes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #158696|0 |1 is obsolete|| --- Comment #30 from David Nind --- Created attachment 159013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159013=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27919] Split claims return from LOST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #31 from Zeno Tajoli ---
A new version that follow the requests given.
To test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another
one from which to merge (with biblio_id_to_merge, eg 9) which will be
deleted! both records may/should have items, subscription,
subscriptionhistory, serial, suggestions, orders and holds
3) check both records via the web
4) Apply patch
5) Write a JSON file with inside the field 'biblio_id_to_merge' and the
biblionumber from wihich to merge.
As example:
{
"biblio_id_to_merge" : 9
}
6) Execute an API call with correct headers and location. For example:
curl -s -u koha:koha --header "Content-Type: application/json" --header
"Accept: application/marc-in-json" --request POST
"http://127.0.0.1:8080/api/v1/biblios/262/merge; -d @file.json
You must to setup the headers and to use a json file with parameters
7) The record with the id 9 is deleted now, the record with 262 has all
items, etc attached, the return is: return code 200 and the changed
record 262 in marc-in-json format
8) It is possible to override biblio data with an external bib record. You
need to put external bib record into the json file in marc-in-json
format. To write use the json file uploaded as example
You need to fill the fields 'rules' and 'datarecord'. The field 'rules'
must contains 'override_ext'
To do the call:
curl -s -u koha:koha --header "Content-Type: application/json"
--header
"Accept: application/marc-in-json" --request POST
"http://127.0.0.1:8080/api/v1/biblios/XXX/merge; -d @file_with_recod.json
9) The record in 'biblio_id_to_merge' is deleted now, in biblio XXX now
there are the bibliographic data of field 'datarecord' of json file,
the return is: return code 200 and the changed record XXX in
marc-in-json format
10) Go into intranet and do a search. Select two or (better) more record.
11) Merge them; merge must be a success.
12) Test with prove -v t/db_dependent/Koha/Biblio.t
13) Test with prove -v t/db_dependent/api/v1/biblios.t
To test with curl the step 8 you can customize the json file attached in
bugzilla.
The marc-in-json record inside follows the MAR21 standard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10958] no need for home link on home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- (In reply to Katrin Fischer from comment #9) > With the staff interface redesign we still have the home icon on the start > page, same for the OPAC. > Can we agree to keep or remove? I vote for remove. I always have to hide this with CSS for new instances. Breadcrumbs are a trail back to the homepage and if you are already there I find them useless, redundant, and confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 --- Comment #30 from Zeno Tajoli --- Created attachment 159012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159012=edit Patch that implemnts the end point -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Zeno Tajoli changed: What|Removed |Added Attachment #157481|0 |1 is obsolete|| Attachment #157482|0 |1 is obsolete|| Attachment #157731|0 |1 is obsolete|| --- Comment #29 from Zeno Tajoli --- Created attachment 159011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159011=edit An example of JSON file to use in testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 --- Comment #12 from Aleisha Amohia --- Created attachment 159010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159010=edit Bug 31415: Exclude found holds and fix hold ID call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 David Nind changed: What|Removed |Added Attachment #158701|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 159009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159009=edit Bug 30295: Add phone transport option Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 David Nind changed: What|Removed |Added Attachment #158700|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 159008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159008=edit Bug 30295: Use blessed patron to enqueue notice and QA fixes Signed-off-by: Stina Hallin Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 David Nind changed: What|Removed |Added Attachment #158699|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 159007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159007=edit Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- Thanks David for double checking master/main Bug affects 22.11.x but not 22.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #158957|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 159006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159006=edit Bug 35307: Add a hidden input for expired holds To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold 8 - Delete the holds 9 - Apply patch 10 - Repeat 1-6 11 - Confirm only the correct hold is updated Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 David Nind changed: What|Removed |Added Attachment #158980|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 159005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159005=edit Bug 35341: Fix ciruclation rule dates being overwritten This patch correctly sets the values of the date fields so that they are not overwritten when only one is amended. It also amends the collumn indexes being used in the click event as new columns have been added without these being updated Test plan: 1) Navigate to Administration > Circulation and fine rules 2) Add a new circulation rule for a category of your choice 3) For the "All" rule, add the date 31/12/2023 to both the Hard due date and No automatic renewal after (hard limit) (NARAHL) columns and save 4) Now edit the rule that you created. 5) Change the two columns above to 01/12/2023 and click save 6) Edit the rule again and change the Hard due date to 15/12/2023. Click save 7) Note that the date for your rule in the NARAHL has changed to 31/12/2023 despite not being edited 8) Click edit again, and change the NARAHL date to 15/12/2023 and save. 9) This time the date in Hard due date will have changed to 31/12/2023 10) Apply patch 11) Edit the dates individually a few times and this time your rule should update correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15248] Make it possible to configure duplicate check on bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #13 from David Gustafsson --- Would be nice with some feedback whether this is preferable to the current way rules are evaluated, will also need to update documentation in the manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #12 from David Gustafsson --- Now added some tests, it would probably be a good idea to add a test for multiple contexts with regards to module precedence. Besides from that it should be ready for review. Also have not run the qa-script yet. Don't know how much more time I currently have to spend on this though, it should more or less be ready for review. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #158956|0 |1 is obsolete|| --- Comment #11 from David Gustafsson --- Created attachment 159004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159004=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 --- Comment #3 from Martin Renvoize --- Confirmed no regressions introduced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35316] Add call number to holds history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35316 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31981] Need to be able to more clearly distinguish between hold warning boxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #7 from David Nind --- Tests pass if the koha-plugin-ill-actions plugin is disabled. Note: with version 1.0.1 of the plugin, the new action no longer works[1] (it did previously with v1.0.0), but I don't know if that is relevant for signing off. I'm not a developer, so I don't know whether tests should pass with and without the koha-plugin-ill-actions plugin enabled. [1] Page not found error when clicking on new action - "New request for this user": Page URL: http://127.0.0.1:8081/api/v1/contrib/ill_actions/new_request_for_patron/1 Start of the page content ()no CSS style sheet): Page Not Found This application is in development mode and will show internal information to help you with debugging. None of these routes could generate a response for your GET request for /api/v1/contrib/ill_actions/new_request_for_patron/1, maybe you need to add a new one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35229] Add further cypress tests for Usage reporting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35229 --- Comment #4 from David Nind --- Created attachment 159003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159003=edit Screenshot - test failure Here is some more detail about the failing test. I've added the screenshot. Running: ERM/UsageReports_spec.ts (9 of 12) Reports home tabs ✓ Should display the saved reports page (2596ms) ✓ Should display the custom report builder (4992ms) Saved reports ✓ Should correctly populate the dropdown menu (2376ms) ✓ Should redirect to the reports viewer with the correct url params (3019ms) Custom reports ✓ Should limit report types based on the provider(s) selected (3615ms) ✓ Should limit data providers based on the report type(s) selected (3069ms) ✓ Should limit metric types based on the report type(s) selected (2840ms) ✓ Should allow access_type for certain report types (2776ms) ✓ Should disable the month selectors when a yearly report is selected (2414ms) 1) Should correctly allow columns to be selected depending on the report type ✓ Should correctly identify the months selected (3400ms) ✓ Should correctly produce URL parameters based on selected inputs (3301ms) ✓ Should show the Display by year filter when filter is required (5514ms) 12 passing (53s) 1 failing 1) Custom reports Should correctly allow columns to be selected depending on the report type: AssertionError: Timed out retrying after 1ms: Too many elements found. Found '7', expected '6'. + expected - actual -7 +6 at Context.eval (webpack://koha/./t/cypress/integration/ERM/UsageReports_spec.ts:252:51) (Results) ┌┐ │ Tests:13 │ │ Passing: 12 │ │ Failing: 1 │ │ Pending: 0 │ │ Skipped: 0 │ │ Screenshots: 1 │ │ Video:true │ │ Duration: 53 seconds │ │ Spec Ran: ERM/UsageReports_spec.ts │ └┘ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35327] Fix capitalization of language name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Thanks David for the test plan :) Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35327] Fix capitalization of language name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #158958|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 159002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159002=edit Bug 35327: Fix capitalization of language name Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35229] Add further cypress tests for Usage reporting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35229 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #3 from David Nind --- The tests fail for me - ERM/UsageReports_spec.ts. I started KTD fresh and ran the command in the test plan. Is there anything else I need to do? Spec Tests Passing Failing Pending Skipped ┌┐ │ ✔ KohaTable_spec.ts00:0311 --- │ ├┤ │ ✔ ERM/Agreements_spec.ts 00:3155 --- │ ├┤ │ ✔ ERM/DataProviders_spec.ts00:43 13 13 --- │ ├┤ │ ✔ ERM/Dialog_spec.ts 00:1544 --- │ ├┤ │ ✔ ERM/Licenses_spec.ts 00:2155 --- │ ├┤ │ ✔ ERM/Packages_spec.ts 00:2155 --- │ ├┤ │ ✔ ERM/Searchbar_spec.ts00:0544 --- │ ├┤ │ ✔ ERM/Titles_spec.ts 00:3666 --- │ ├┤ │ ✖ ERM/UsageReports_spec.ts 00:53 13 12 1-- │ ├┤ │ ✔ Preservation/Settings.ts 00:1055 --- │ ├┤ │ ✔ Preservation/Trains.ts 00:2088 --- │ ├┤ │ ✔ Preservation/WaitingList.ts 00:0833 --- │ └┘ ✖ 1 of 12 failed (8%) 04:34 72 71 1-- error Command failed with exit code 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 --- Comment #2 from Martin Renvoize --- Testing on customer site to double-check the work then will pass directly to the 22.11.x rmaints. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Martin Renvoize changed: What|Removed |Added Blocks||35343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 [Bug 35343] record method, required for bug 26611, missing from Koha::Authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added Depends on||26611 Severity|enhancement |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 [Bug 26611] Required match checks don't work for authority records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 --- Comment #1 from Martin Renvoize --- Created attachment 159001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159001=edit Bug 35343: Add record accessor method to Koha::Authority Code lifted from bug 31794 to fix already backported bug 26611. Unit tests included. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35343] New: record method, required for bug 26611, missing from Koha::Authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Bug ID: 35343 Summary: record method, required for bug 26611, missing from Koha::Authority Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Bug 26611 was backported to 22.11.x, but missed that Koha::Authority->record was added in bug 31794. We need the record method adding for 22.11 to prevent code explosions when matches are found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #32 from Shi Yao Wang --- rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157868|0 |1 is obsolete|| --- Comment #31 from Shi Yao Wang --- Created attachment 159000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159000=edit Bug 32610: Remove data-date_to and tweak comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157867|0 |1 is obsolete|| --- Comment #30 from Shi Yao Wang --- Created attachment 158999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158999=edit Bug 32610: Add date extended patron attribute handling to overdues report This makes sure that the overdues report manages filters for extended patron attributes of the type date correctly. To test: * Make sure you have at least one PA marked as 'searchable' * Make sure your patron has at east one checked out item * Go to circulation > overdues * If you have no overdue items, check "Show any items currently checked out:" * Verify the list of checkouts displays * Verify the PA filter option displays with the calendar widget * Limit to the date in your patron's record - list remains * Limit to any other date - list empties Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157866|0 |1 is obsolete|| --- Comment #29 from Shi Yao Wang --- Created attachment 158998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158998=edit Bug 32610: Add date extended patron attributes to the OPAC This makes sure that the attributes are handled correctly when displayed and edited in the OPAC during address changes or self registration. To test: * You will need to test different configuration options for extended patron attributes (PA) in combination with the date option: * PA displays in OPAC, but is not editable * The date will show nicely formatted on the personal details tab. * PA displays and is editable in the OPAC * The date can be edited using the calendar widget * PA displays, is editabe and mandatory * The date is marked as required and you can't save without it being set. * Test the form behaves correctly when requesting changes for an existing patron account and when self registering. Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157865|0 |1 is obsolete|| --- Comment #28 from Shi Yao Wang --- Created attachment 158997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158997=edit Bug 32610: Add date extended patron attributes to patron module This makes the necessary changes in the patron module of the staff interface, so the new patron attribute appers and behaves correctly when editing a patron record. To test: * You will need to test different configuration options for extended patron attributes (PA) in combination with the date option: * PA is a date and not mandatory * Patron form should have the calendar widget to let you set the date. * PA is a date and mandatory * Patron form shoudl have calendar widget and check that the date is set for allowing you to save the record. * PA is a date and unique * For this set the date in one patron record and try to set the same date in another. You should not be able to save. * PA displays in brief patron information * Make sure the date displays on the left formatted correctly * When the date PAs are saved, they should display nicely formatted on the details tab. Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157864|0 |1 is obsolete|| --- Comment #27 from Shi Yao Wang --- Created attachment 158996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158996=edit Bug 32610: Add date option to extended patron attributes administration page With this page it will be possible to configure patron attributes to be a date. To test: * Go to administration > patron attribute types * Add a new patron attribute of type date * Dates cannot be repeatable or linked to an AV category, so: * Verify, if you check repeatable, date is disabled * Verify, if you select an AV category, date disabled * Verify, if you check date, AV category and repeatable are disabled * Save the new patron attribute * Edit the patron attribute * Verify all settings have been kept/stored correctly Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157863|0 |1 is obsolete|| --- Comment #26 from Shi Yao Wang --- Created attachment 158995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158995=edit Bug 32610: [DO NOT PUSH] DBIC Update Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #157862|0 |1 is obsolete|| --- Comment #25 from Shi Yao Wang --- Created attachment 158994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158994=edit Bug 32610: Add borrower_attribute_types.is_date to the database * Change to kohastructure.sql for new installations * Atomic database update to add the column for updating installations Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #10 from Martin Renvoize --- As highlighed above, this is also an issue in 22.11.x.. this patch inadvertantly depends on bug 31794 which adds the record accessor into Koha::Authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31794] Add GET endpoint for Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Martin Renvoize changed: What|Removed |Added Blocks||26611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 [Bug 26611] Required match checks don't work for authority records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Martin Renvoize changed: What|Removed |Added Depends on||31794 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 [Bug 31794] Add GET endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35336] Add a notification to patrons when a restriction is applied to their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35336 --- Comment #2 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > Does this refer specifically to a manual restriction? I believe so. I know that restrictions can be automated with overdues, and language can be added to the overdue notifications, but in any other case, it would be good if we could send notifications. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #6 from Pedro Amorim --- Created attachment 158993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158993=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #16 from Katrin Fischer --- I think in testing we need to make sure that there is no regression when there are no entries in the table, but the renewals count on the checkout is > 0 (maybe also needs a last renewed date if you are faking the data). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #15 from Pedro Amorim --- (In reply to Katrin Fischer from comment #14) > We are not even on a version with the table yet, I'd like to keep it then :) Please let me know what's needed from me to move this bug, Katrin. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35342] Use a Makefile to manage PO files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35342 Julian Maurice changed: What|Removed |Added Attachment #158981|0 |1 is obsolete|| --- Comment #3 from Julian Maurice --- Created attachment 158992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158992=edit Bug 35342: Use a Makefile to manage PO files There were some problems recently involving gulp and PO files, which are still unresolved at the time of writing. Debugging this is hard and time-consuming (failures are hard to reproduce) Why make/a Makefile ? * Creating/updating PO files is essentially passing a list of input files to a command that will produce a new/updated output file, and that's exactly what make does * It builds only what's needed by default (if source files haven't changed, no need to rebuild the .pot, and so .po files don't need to be updated either) * It handles parallelism well To use the Makefile, you need to be at the root directory of Koha, and then you can run: make -f misc/translator/Makefile help To have a list of available targets make -f misc/translator/Makefile all To update all PO files make -f misc/translator/Makefile pot To rebuild all POT files make -f misc/translator/Makefile en-GB To update all en-GB PO files make -f misc/translator/Makefile misc/translator/Koha-installer.pot To update that particular file By default, it won't build a target (output file) if its prerequisites (input files) are older than the target. It can be forced with -B/--always-make By default, all targets are built sequentially. To enable parallelism, use -j/--jobs Multiple targets can be specified on the command line, so it's possible to do: make -f misc/translator/Makefile -j -B en-GB fr-FR gulpfile.js is updated to uses this Makefile This patch also includes a fix in Koha/Database/Columns.pm (a translated empty string caused gettext to emit a warning and to place the header in the middle of the .po/.pot file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #14 from Katrin Fischer --- We are not even on a version with the table yet, I'd like to keep it then :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35273] When editing items on receive, aqorders_items is not updated correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Klas Blomberg changed: What|Removed |Added CC||klas.blomb...@skovde.se --- Comment #14 from Klas Blomberg --- *** Bug 35244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35244] AcqItemSetSubfieldsWhenReceived not working after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35244 Klas Blomberg changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Klas Blomberg --- This seems to be the same problem as bug 35273 *** This bug has been marked as a duplicate of bug 35273 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #35 from Pedro Amorim --- (In reply to Jonathan Druart from comment #34) > ERM/UsageReports_spec.ts and ERM/DataProviders_spec.ts are failing See bug 35229. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35229] Add further cypress tests for Usage reporting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35229 --- Comment #2 from Pedro Amorim --- Created attachment 158991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158991=edit Bug 35229: Fix DataProviders_spec.ts The intercept was wrong: Was intercepting GET instead of POST Was intercepting /run route intead of /process_SUSHI_response (this naming was updated in the rest of the code but not here) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #35 from Jonathan Druart --- (In reply to Katrin Fischer from comment #25) > I'd really love to see this long standing issue fixed :) > > > 1) Migration of data > So it might not be correct, but I think it's what would be displayed on the > order line now and where the email would be sent to, so that might be the > best we can do? It was left on purpose. I don't think we should copy an information if we are not sure it is correct. I am not confident in migrating something here. > 2) ModSuggestion > > ModSuggestion is called to update the status of the suggestion and to send > the email, but the calls haven't always been adjusted to look up the correct > suggestion. Correct, good catch. Should be fixed. > And there are more calls I haven't checked that need to be verified. Other calls look good. I let you decide what the status is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #34 from Jonathan Druart --- Created attachment 158990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158990=edit Bug 28844: Adjust tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
