[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #14 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #13)
> Note: I like the consistency of the change to the class, but it could have
> some side effects for existing CSS. I decided to push, because the change is
> in the staff interface, not in the OPAC.

I was thinking the same thing. Initially, I thought we should've kept the
existing class and added the new one, but then I figured since it's the staff
interface people can just update on upgrade as needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104

--- Comment #30 from David Cook  ---
(In reply to Martin Renvoize from comment #29)
> Awesome.. I knew it was something silly when catching the exception!
> 
> That gives me enough to get going again :), thanks David

Yay teamwork! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24889] Sort subscription in opac view : closed vs open

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24889

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900

--- Comment #20 from David Nind  ---
(In reply to Victor Grousset/tuxayo from comment #18)
> These are very nice improvements, much cleaner :)
> 
> After comparing the pages before and after the patches, here is the relevant
> thing I've found:
> There is no more mention of FileSaver library despite it being included in
> cateditor-ui.inc and lib/datatables/datatables.js
> 
> Mistake or good reason?


After a quick look, that looks like a mistake, so should be added back in.

I've just had a quick look (not comprehensive), and it looks like there are
some software licences missing, including:
- DataTables (koha-tmpl/intranet-tmpl/lib/datatables)
- GreyBox (koha-tmpl/intranet-tmpl/lib/greybox)
- Some jQuery plugins - jsTree, rowGroup (doesn't look the same as
jquery.dataTables.grouping.js), fnReloadAjax (part of DataTables?), Humanized
Messages, jquery.dataTables.columnFilter.js (part of DataTables?), highlight
(part of DataTables?), jquery-jeditable
(koha-tmpl/intranet-tmpl/lib/jquery/plugins/)
- linters (several) (koha-tmpl/intranet-tmpl/lib/linters)
- sortable (koha-tmpl/intranet-tmpl/lib/linters/sortable)
- vis-timeline and vis-graph2d (koha-tmpl/intranet-tmpl/lib/vis-timeline/)
- media.match.js (koha-tmpl/opac-tmpl/lib/)

Maybe this should be a separate bug to review what is used and add any missing
ones?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35519] New: apt install koha-common has error with koha-l10n

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35519

Bug ID: 35519
   Summary: apt install koha-common has error with koha-l10n
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m...@kohaaloha.com

Tomas said he saw this too, so it's not my (really Kyle's) custom package. :) 

Installing koha-common with apt install koha-common= with 23.05.06 over the top of an older version errors out as follows: 

dpkg: error processing archive
/tmp/apt-dpkg-install-tZKDjI/062-koha-l10n_23.05.06-1_all.deb (--unpack):
 trying to overwrite
'/usr/share/koha/misc/translator/po/am-Ethi-installer-MARC21.po', which is also
in package koha-common 23.05.05

This can be fixed by running

apt install -f

and subsequent installs are ok.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900

--- Comment #19 from Victor Grousset/tuxayo  ---
Also, no entry for DataTables itself. Is there a reason or should I open a
ticket to report it?


Some opinions about:

(In reply to David Nind from comment #17)
> Questions for other bugs, if required:
> - Should the version of a piece of software be shown? A few do.

Might be tough to be reliably maintained. Maybe not actually, it's not often to
have library updates and a QA guideline to remind to keep the about page up to
date would do.

> - Should we have a short description of what they do, where they are used in
> Koha?

Maybe, if someone wants to volunteer to implement it why not. Or maybe we
prefer to spare any new string for translators unless necessary? Or even a few
dozen are not a big deal?

> - Should we change to a bullet list?
> - Versions of libraries: many seem quite old or not updated for a while. 
>   . Should I create an omnibus bug to update?

Now that you remention it, it might have enough value as a technical
documentation. Both for regular development and when looking at security
issues. Oops, I understood that as creating a ticket to add the version for all
libraries. Answer to your question comes later down.

>   . Should we update all libraries used at the start of a cycle? (The
> biggies, such as Bootstrap and jQuery, might be more problematic.)

Even the small ones, multiple of them might need to test and tweak a lot of
pages. So overall it might be equivalent like if we had another (or multiple
more?) Bootstrap, jQuery, datatable.

>   . Or do we have a "if it isn't broken, don't fix it" approach, unless
> there are security updates?

Seems like the current situation due to limited resources. It's seems hard
enough at the moment to keep the biggies up to date. Unless there is some spare
capacity after catching up for security, compatibility, big bugfixes. Until
then it's tough to plan for general updates of the rest. If someone needs a new
feature or just has an itch for updating a library it can still happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #14 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21)

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|24.05.00|24.05.00,23.11.01
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ...

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|24.05.00|24.05.00,23.11.01
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches)

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
   Patch complexity|--- |String patch

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|24.05.00|24.05.00,23.11.01
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well!

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|24.05.00|24.05.00,23.11.01
released in||
   Patch complexity|--- |String patch
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35441] Typo 'UniqueItemsFields' system preference

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35441

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #6 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
   Patch complexity|--- |String patch

--- Comment #9 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.01
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29438] Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29438

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #1 from Lucas Gass  ---
Any ISBN prefixed with 979 cannot be converted to an ISBN10. An 979 ISBN will
also not pass the check here:

if ( $isbn && $isbn->is_valid() ) 


For example:

use Business::ISBN; 
my $isbn = Business::ISBN->new(9798986969305); 
warn Data::Dumper::Dumper($isbn->is_valid);

this returns an empty string for $isbn->is_valid

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798

Slava Shishkin  changed:

   What|Removed |Added

 Blocks||35518


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518
[Bug 35518] Call to C4::Context->userenv happens before it's gets populated
breaks code logic
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35518] New: Call to C4::Context->userenv happens before it's gets populated breaks code logic

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518

Bug ID: 35518
   Summary: Call to C4::Context->userenv happens before it's gets
populated breaks code logic
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: slavashish...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com,
nug...@gmail.com
Depends on: 17798

We getting results from `C4::Context->userenv` on line 72:

my $userenv = C4::Context->userenv;

but `C4::Context->userenv` gets populated only far below in
`get_template_and_user` call, line 142,
this means that everything that we getting further from `$userenv` is empty.
And more, because autovivification occurs for the `$userenv` at line 73:

my $branch = $userenv->{'branch'} // ''; 

that does not cause any visible errors, but it causes malfunctions at places
where $branch, $desk_id is used, and also where $userenv is accessed, at line
153:

if (!C4::Auth::haspermission( $userenv->{id} , { circulate =>
'force_checkout' } ) ). 


To check that we have undef and it gets autovivificated, let's add some dumps
into code when we open any borrower, e.g.
/cgi-bin/koha/circ/circulation.pl?borrowernumber=19,

Let's dump $userenv before and after `$branch = $userenv->{'branch'} // '';`
line:

72 my $userenv = C4::Context->userenv;
73 use Data::Dumper;
74 warn __LINE__, ' ', Dumper($userenv);
75 my $branch  = $userenv->{'branch'} // '';
76 warn __LINE__, ' ', Dumper($userenv);

this gives in server logs:

74 $VAR1 = undef;
76 $VAR1 = {};


and also to check when `C4::Context->userenv` gets its real values, let's dump
before and after the `get_template_and_user()` call at line 142 (line 145 if to
continue above dumps code):

145 warn __LINE__, ' ', Dumper([C4::Context->userenv]);
146 my ( $template, $loggedinuser, $cookie ) = get_template_and_user (
...
153 );
154 warn __LINE__, ' ', Dumper([C4::Context->userenv]);

this gives in server logs:

145 $VAR1 = [];
154 $VAR1 = [
  {
...
'id' => 'admin',
...
  }
];

what depicts the whole bug.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798
[Bug 17798] Checking out an item on hold for another patron prints a slip but
does not update hold
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

--- Comment #18 from Victor Grousset/tuxayo  ---
These are very nice improvements, much cleaner :)

After comparing the pages before and after the patches, here is the relevant
thing I've found:
There is no more mention of FileSaver library despite it being included in
cateditor-ui.inc and lib/datatables/datatables.js

Mistake or good reason?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #39 from Esther Melander  ---
To add a wrinkle to this discussion. OCLC is using $0 in authority records,
perhaps as intended with linking information. An example authority:

Conduct of life. $2 fast $0 (OCoLC)fst00874563

In this case, a library wants to retain this subfield as a reference point. It
would cause a conflict if a library is using $0 for internal linking and
brought in a record which contains reference data in this field for a different
system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573

--- Comment #10 from David Nind  ---
I thought I might have caused it, but it is something to do with line 150
(after the patches are applied) - that text appears in the HTML page title if
you add a new vendor or modify an existing vendor.

I don't understand how it works enough to fix it 8-(.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|minor   |normal
 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo  ---
Good catch, it was possible to save any value in the syspref  :o

Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159482|0   |1
is obsolete||

--- Comment #4 from Victor Grousset/tuxayo  ---
Created attachment 159666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159666=edit
Bug 35450: Preservation system preferences should authval dropdowns

This patch updates two preservation module system preferences so that
they offer dropdowns of "Not for loan" values instead of requiring entry
of a specific code.

The patch also adds a missing "." at the end of one preference
description.

To test, apply the patch and restart services.

- Go to Administration -> System preferences.
- Search for "preservation"
- Check that the "PreservationNotForLoanDefaultTrainIn" and
  "PreservationNotForLoanWaitingListIn" preferences have dropdowns
  offering "Not for loan" values.
- Confirm that your choices are correctly saved.

Signed-off-by: Barbara Johnson 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35449] Accessibility: No links on "here"

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35449] Accessibility: No links on "here"

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159481|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 159665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159665=edit
Bug 35449: Accessibility: No links on "here"

This patch updates two system preferences, "OPACUserJS" and
"OPACUserCSS" so that the "here" links in the description instead read
"library administration".

To test, apply the patch and go to Administration -> System preferences.

- Search for "opacuser"
- The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences
  should include the phrase "...can be defined in library
  administration," with "library administration" leading to the correct
  page.

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #4 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159480|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 159664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159664=edit
Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl

This parameter is actually --log-module.

Test plan :
Run misc/cronjobs/cleanup_database.pl -h
Confirm you see --log-module

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #9 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159468|0   |1
is obsolete||

--- Comment #8 from Victor Grousset/tuxayo  ---
Created attachment 159663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159663=edit
Bug 35436: Copy is not translatable in OPAC Search History

Test plan
1 Enter in OPAC Search History in a language other than English and
  check that Copy is not translated
2 Apply patch, restart services
3 Regenerate the templates for that language
4 Repeat step 1 and check that Copy appears now translated

Signed-off-by: Owen Leonard 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35505] Add specific selectors

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35505

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410

David Nind  changed:

   What|Removed |Added

  Text to go in the|This updates the default|This updates the default
  release notes|staff interface and OPAC|staff interface and OPAC
   |XSLT files so that "Online  |XSLT files so that "Online
   |resources" is used as the   |resources" is used as the
   |label in search results for |label in search results for
   |filed 856 - Electronic  |field 856 - Electronic
   |Location and Access,|Location and Access,
   |instead of "Online access". |instead of "Online access".
   |This matches the label used |This matches the label used
   |in the detail page for a|in the detail page for a
   |record.
|record.
   |
   |
   |It also adjusts |It also adjusts
   |the CSS class so OPAC and   |the CSS class so OPAC and
   |staff interface both use|staff interface both use
   |online_resources.   |online_resources.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the
  release notes||capitalization of some
   ||label names in the
   ||Preservation module (name
   ||-> Name, and barcode ->
   ||Barcode).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the
  release notes||capitalization of English
   ||(english -> English) in the
   ||ILS_DI GetAvailability
   ||information page
   ||(:/cgi-bi
   ||n/koha/ilsdi.pl?service=Des
   ||cribe=GetAvailability)
   ||.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35516] OPAC search results incorrectly displays order when skipping lost items

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35516

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes some submit
  release notes||buttons in the ERM and
   ||Preservation modules so
   ||that are now translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476

--- Comment #5 from David Nind  ---
(In reply to Jonathan Druart from comment #3)
> Hi David,
> I cannot test right now, but you need:
> 8. Apply the patch
> 9. yarn build (or simply yarn js:build)
> 10. restart_all (JS translations are cached in memcached)
> 
> That should be enough.

Thanks Jonathan!

That worked.

Simplified test plan:

1. Install another language, for example: koha-translate --install es-ES --dev
kohadev
2. Enable the language for the staff interface (Administration > System
preferences > I18N/L10N > language)
3. Enable the ERM module (ERMModule)
4. Change the language to the one you installed
5. Go to E-resource management > eHoldings > Local > Packages > +New package
6. Note that the submit button is not translated (for +New package it is Submit
instead of Enviar for es-ES)
  (Compare to one of the other submit buttons that is translated correctly
(E-resource management > Agreements > +New agreement)
7. Apply the patch, yarn js:build, restart_all
8. Repeat step 5 - the submit button is now translated!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476

David Nind  changed:

   What|Removed |Added

 Attachment #159527|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 159662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159662=edit
Bug 35476: Make 'Submit' buttons translatable in vue components

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517

--- Comment #1 from Owen Leonard  ---
Created attachment 159661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159661=edit
Bug 35517: Choose correct default header search tab according to permissions

This patch adds some additional template logic to the header search form
for the staff interface home page so that users with different
permissions will see the correct tab in the header search form.

To test, apply the patch and view the staff interface home page using a
user with different permissions:

- 'catalogue' and 'circulate'
  - Header should show circulation search
- 'catalogue' and 'borrowers'
  - Header should show patron search
- 'catalogue' only
  - Header should show catalog search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35517] New: Choose correct default header search tab according to permissions

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517

Bug ID: 35517
   Summary: Choose correct default header search tab according to
permissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

On the staff interface home page the default header search box is the checkout
one. But if the user doesn't have circulation permission the search tabs are
initially hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences"

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #2 from Caroline Cyr La Rose  ---
If you have a local copy, you can do the following command to find all the
occurrences 

git grep -i "Global system preferences"

caroline@ahuntsic[12:36:27](master-dev)/inlibro/git/koha-manual/source$ git
grep -i "Global system preferences"
accountspreferences.rst:*Get there:* More > Administration > Global system
preferences >
acquisitionspreferences.rst:*Get there:* More > Administration > Global system
preferences > Acquisitions
administrationpreferences.rst:*Get there:* More > Administration > Global
system preferences >
authoritiespreferences.rst:*Get there:* More > Administration > Global system
preferences >
catalogingpreferences.rst:*Get there:* More > Administration > Global system
preferences >
circulationpreferences.rst:*Get there:* More > Administration > Global system
preferences > Circulation
enhancedcontentpreferences.rst:*Get there:* More > Administration > Global
system preferences >
ermpreferences.rst:-  Get there: More > Administration > Global System
Preferences > E-Resource management
i18npreferences.rst:*Get there:* More > Administration > Global system
preferences >
illpreferences.rst:*Get there:* More > Administration > Global system
preferences > Interlibrary
intro.rst:*Get there:* More > Administration > Global system preferences
localusepreferences.rst:*Get there:* More > Administration > Global system
preferences > Local
logspreferences.rst:*Get there:* More > Administration > Global system
preferences > Logs
opacpreferences.rst:*Get there:* More > Administration > Global system
preferences > OPAC
patronspreferences.rst:*Get there:* More > Administration > Global system
preferences > Patrons
searchingpreferences.rst:*Get there:* More > Administration > Global system
preferences >
serialspreferences.rst:*Get there:* More > Administration > Global system
preferences > Serials
staffclientpreferences.rst:*Get there:* More > Administration > Global system
preferences > Staff 
toolspreferences.rst:*Get there:* More > Administration > Global system
preferences > Tools
webservicespreferences.rst:*Get there:* More > Administration > Global system
preferences > Web

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences"

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515

--- Comment #1 from Aude Charillon  ---
It would be worth doing a proper search to check for occurences.

As an example, all the preferences pages (e.g. Acquisitions) start with: "Get
there: More > Administration > Global system preferences > Acquisitions"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35516] New: OPAC search results incorrectly displays order when skipping lost items

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35516

Bug ID: 35516
   Summary: OPAC search results incorrectly displays order when
skipping lost items
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 159660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159660=edit
Lost item is skipped in ordered list.

To recreate:

1. Ensure the system preference hidelostitems is set to don't show.
2. Search the staff interface using search catalog with a term that returns
several results. Select a bib record with an item and change the status to
lost. (In my example, I choose an item in the 4th result).
3. Do a search in the OPAC for the same term. See that the results are ordered
in the list 1, 2, 3, 5, 6.

The system preference is doing its job and hiding the lost item. However, the
results should be ordered 1, 2, 3, 4, 5, etc., and not indicate that an item
was skipped or suppressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673

Aude Charillon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35515

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35515] New: Change occurences of "Global system preferences" to "System preferences"

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515

Bug ID: 35515
   Summary: Change occurences of "Global system preferences" to
"System preferences"
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: Needs documenting
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aude.charil...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

With Bug 33673, Administration > Global system preferences became
Administration > System preferences. We need to update this on all pages of the
manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151

--- Comment #9 from Pedro Amorim  ---
This is great, not only the language specific but also library specific option.

My only minor concern (not about this patch) is that, before, ILL related
options where somewhat exclusive to sys prefs, now it's sys prefs and html
customizations (among others, like ILL batch statuses in the Koha admin) but
this relates to a different problem, one that could maybe be addressed by
having an ILL config dedicated admin page where all ILL related configs would
be accessible through that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #158741|0   |1
is obsolete||

--- Comment #8 from Pedro Amorim  ---
Created attachment 159659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159659=edit
Bug 35151: Convert ILLModuleCopyrightClearance system preference to additional
contents

This patch moves the ILLModuleCopyrightClearance system preference into
HTML customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the ILLModuleCopyrightClearance
system preference before applying the patch. Apply the patch, run the
database update process, and rebuild the OPAC CSS.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from ILLModuleCopyrightClearance is now stored there.
- The HTML customization entry form should offer
  ILLModuleCopyrightClearance as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Enable the "opaclanguagesdisplay" preference if necessary.
- Edit the ILLModuleCopyrightClearance HTML customization and add unique
  content to the "fr-FR" tab.

- Enable the "ILLModule" and "ILLModuleUnmediated" system preferences if
  necessary. You must have at least one ILL backend installed.
- Log into the OPAC and click the "Interlibrary loan requests" in the
  sidebar menu on the user summary page.
- Click "Create new request."
- You should be taken to a page with your ILLModuleCopyrightClearance
  content shown along with "Yes" and "No" buttons.
  - Clicking "Yes" should take you to the form for creating a new
request.
- Switch to your updated translation and confirm that the content
  appears correctly.
- Remove all "ILLModuleCopyrightClearance" html customizations. Test the
  "Create new request" process in the OPAC again.
  - There should be no confirmation step before arriving at the form for
creating a new ILL request.
- Go to Administration -> System preferences and search for
  "ILLModuleCopyrightClearance." It should return no results.

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284

--- Comment #17 from Andrew Fuerste-Henry  ---
Hi all, giving this bug a bump as it continues to force us to keep patron
circulation history in violation of their privacy selection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #157464|0   |1
is obsolete||

--- Comment #5 from Pedro Amorim  ---
Created attachment 159658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159658=edit
Bug 35108: Hide optionally empty fields label entries, these are:

orderid, biblio_id, batch already was the case, type, type_disclaimer_value,
type_disclaimer_date, cost, price_paid, notesstaff, notesopac

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click
'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer
displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #157463|0   |1
is obsolete||

--- Comment #4 from Pedro Amorim  ---
Created attachment 159657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159657=edit
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less
horizontal length

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361

Benjamin Daeuber  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from Owen Leonard  ---
The qa tool still has complaints about the atomicupdate. Please take another
look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

--- Comment #1 from Thibaud Guillot  ---
Created attachment 159656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159656=edit
Bug 35514: Fix costs update when adding multiple items from staged file

Test plan:

1) Stage a file with records
2) Create a basket and add order line from imported records to go on
   neworderempty.pl
3) Choose to add one item and repeat the operation
4) See on form that the total cost is updated without update vendor
   price
5) Now add multiple items, for example, "2" you will see that the total
   cost is not updated and if you save "0" price will be set
6) Apply this patch and repeat step 5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Thibaud Guillot  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Thibaud Guillot  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New: Total prices not updated when importing records from staged file with multiple items added

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Bug ID: 35514
   Summary: Total prices not updated when importing records from
staged file with multiple items added
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: thibaud.guil...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Hello everyone,

When you add an order line to a basket from a staged file, on the
neworderempty.pl page during entry the prices are correctly calculated when you
add item one by one, but if you add multiple items simultaneously the total
costs are not updated and adding the line leads to having the prices set to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34075] Allow specifying default tab view for authorities

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34075

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #159633|0   |1
is obsolete||

--- Comment #46 from ByWater Sandboxes  ---
Created attachment 159654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159654=edit
Bug 30230: Add new 'list_borrowers' permission

When a patron search is performed only a user with edit_borrowers
permission can search by name. Search can works only with cardnumber but
it makes searching less intuitive I think.

So, as mentioned in the discussion, I've added a new 'list_borrowers'
permission,
completely independent of 'edit_borrowers', so that I can search for a member
via the interface
and get the results. In addition to the permission to perform check in and
checkouts, this no longer poses an obstacle to simple use.

Test plan:

1) Check with a user without 'edit_borrowers' permission that the patron search
can only be performed with cardnumber
2) Apply this patch
3) Make the updatedatabase to add new 'list_borrowers' permissions
4) Set 'list_borrowers' permission on one user and see the difference

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

--- Comment #45 from Andrew Fuerste-Henry  ---
> Normally I've taken your comments into account and removed the "Search
> patrons" link from the main search bar... it's only accessible to members
> with 'catalog' permission. Unless I've misunderstood, but from my point of
> view, with a member who only has the 'list_borrowers' permission, this seems
> correct.

Hi Thibaud, thanks for your work here! This code will help us a lot.
That "Search Patrons" link still shows up and behaves oddly for someone with
just list_borrowers permission, but only in one little spot. To see it:
 - have an account with permissions "Staff access, allows viewing of catalogue
in staff interface (catalogue)", "Remaining circulation permissions
(circulate_remaining_permissions)", and "Search and list patrons
(list_borrowers)"

 - Go to the checkout screen on any patron record
(/cgi-bin/koha/circ/circulation.pl?borrowernumber=)

- Click "Routing Lists" in the menu on the left of the screen

- That takes you to /cgi-bin/koha/members/routing-lists.pl?borrowernumber=

- "Search patrons" shows in the search bar, with no search field displayed
while "Search patrons" is selected.

I realize this is a really minor display issue on one page few users look at.
I'm going to go ahead and sign off on this because it works in every other way.
I'm happy to sign off again if you have a chance to change that page, or we can
worry about it on a follow-up bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869

--- Comment #6 from Marcel de Rooy  ---
Note that things only 'explode' in strict SQL mode probably. Otherwise they are
just silently converted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869

--- Comment #5 from Marcel de Rooy  ---
Just some related questions here.

Should we save authorised_values.id in connected fields? Perhaps theoretically,
but it does not sound very practical at this point in our codebase. So NO.

Should we adjust other item fields that are of integer type connected to AV
where the same problem actually may occur? Move them all to varchar(80)? It
feels a bit like overkill?
These are:
| stack | tinyint(1)   |  # on this report
| notforloan| tinyint(1)   |
| damaged   | tinyint(1)   |
| itemlost  | tinyint(1)   |
| withdrawn | tinyint(1)   |
| restricted| tinyint(1)   |

IF doing so, we could look at default values. They are not completely
consistent, since damaged and withdrawn default to 0.
`restricted` tinyint(1) DEFAULT NULL COMMENT 'authorized value defining use
restrictions for this item (MARC21 952$5)',
`stack` tinyint(1) DEFAULT NULL,
`ccode` varchar(80) DEFAULT NULL COMMENT 'authorized value for the collection
code associated with this item (MARC21 952$8)',
`location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the shelving
location for this item (MARC21 952$c)',

I thought about warning for a wrong value in an item field of type integer/date
BEFORE saving. Now we can just enter something in various fields, save, get no
warning and come back later to discover that our data is lost. E.g. the example
of 127 for a higher number. (Coming back as 127 with a warning in the editor.)
Or just 0 for a string.

But since this originates from AV. We should perhaps add a restriction THERE!
Why not add an AV column that allows you to only enter tinyints instead of 80
char codes? If we solve it in AV, there will be no problem in items?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #12 from Hammat wele  ---
Created attachment 159653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159653=edit
Bug 33317: (follow-up) Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869

--- Comment #4 from Marcel de Rooy  ---
The promised comment is still coming btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #159651|0   |1
is obsolete||

--- Comment #11 from Pedro Amorim  ---
Created attachment 159652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159652=edit
Bug 30645: Consider multiple instances of extended_attributes in query params

This will rewrite a query like:

{
"-and":[
[
{
"extended_attributes.value":{
"like":"abc%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
],
[
{
"extended_attributes.value":{
"like":"123%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
]
]
}

To:

{
"-and":[
[
{
"extended_attributes.value":{
"like":"abc%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
],
[
{
"extended_attributes_2.value":{
"like":"123%"
},
"extended_attributes_2.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
]
]
}

And it'll also add the number of required 'join' attributes to the query
attributes to match it.

Test plan (with Joubu's test patch applied), run:
prove t/db_dependent/selenium/patrons_search.t

Or

Test plan, k-t-d:
1) Create 2 patron attributes, visit:
/cgi-bin/koha/admin/patron-attr-types.pl
2) Name the first attribute 'test1' and the second attribute 'test2'
3) On both, tick the 'Searchable' and 'Search by default' checkboxes
4) Edit a koha borrower, example visit:
/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51
5) Put '123' on the test1 attribute, and 'abc' on the test2 attribute
6) Visit the main patrons page:
/cgi-bin/koha/members/members-home.pl
7) On the first left side filter input called 'Search', type '123' and search.
Notice you get the patron result
8) Repeat step 7, but type 'abc' instead of '123'. Notice you get the patron
result
9) Now do the same search but type '123 abc'. Notice you do not get the patron
result.
10) Apply patch. Repeat test plan. Notice you get the patron result in step 9).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/768
  Documentation||Caroline Cyr La Rose
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34677] Update to MARC21 relator terms list

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED

--- Comment #28 from Caroline Cyr La Rose  ---
Nothing to document here, that I can see. Feel free to reopen with more details
if I'm wrong! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #159414|0   |1
is obsolete||

--- Comment #10 from Pedro Amorim  ---
Created attachment 159651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159651=edit
Bug 30645: Consider multiple instances of extended_attributes in query params

This will rewrite a query like:

{
"-and":[
[
{
"extended_attributes.value":{
"like":"abc%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
],
[
{
"extended_attributes.value":{
"like":"123%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
]
]
}

To:

{
"-and":[
[
{
"extended_attributes.value":{
"like":"abc%"
},
"extended_attributes.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
],
[
{
"extended_attributes_2.value":{
"like":"123%"
},
"extended_attributes_2.code":[
[
"arbitrary_attr_code",
"another_attr_code"
]
]
}
]
]
}

And it'll also add the number of required 'join' attributes to the query
attributes to match it.

Test plan (with Joubu's test patch applied), run:
prove t/db_dependent/selenium/patrons_search.t

Or

Test plan, k-t-d:
1) Create 2 patron attributes, visit:
/cgi-bin/koha/admin/patron-attr-types.pl
2) Name the first attribute 'test1' and the second attribute 'test2'
3) On both, tick the 'Searchable' and 'Search by default' checkboxes
4) Edit a koha borrower, example visit:
/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51
5) Put '123' on the test1 attribute, and 'abc' on the test2 attribute
6) Visit the main patrons page:
/cgi-bin/koha/members/members-home.pl
7) On the first left side filter input called 'Search', type '123' and search.
Notice you get the patron result
8) Repeat step 7, but type 'abc' instead of '123'. Notice you get the patron
result
9) Now do the same search but type '123 abc'. Notice you do not get the patron
result.
10) Apply patch. Repeat test plan. Notice you get the patron result in step 9).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645

Pedro Amorim  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361

Aude Charillon  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/767
  Documentation|Aude Charillon  |Benjamin Daeuber
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104

--- Comment #29 from Martin Renvoize  ---
Awesome.. I knew it was something silly when catching the exception!

That gives me enough to get going again :), thanks David

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

--- Comment #1 from Katrin Fischer  ---
Failing again with today's run:
https://jenkins.koha-community.org/job/Koha_Master/2762/
t_db_dependent_TestBuilder_t.build_sample_biblio() tests (2071)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506

--- Comment #3 from Katrin Fischer  ---
Failing again with today's run:
https://jenkins.koha-community.org/job/Koha_Master/2762/

t_db_dependent_selenium_regressions_t.Display circulation table correctly (344)
t_db_dependent_selenium_regressions_t.Encoding in session variables (344)
t_db_dependent_selenium_regressions_t.Number of runned tests does not match
plan. (344)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21329] Add additional fields to purchase suggestions

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

library_jane  changed:

   What|Removed |Added

 CC||j.hens...@lcm.ac.uk

--- Comment #8 from library_jane  ---
Custom fields for the purchase suggestion form would be wonderful. Firstly,
we're often asked for music materials in different formats and it would be good
to have a free-text field to ask a specific question (rather than relying on
'notes') and we'd also like requesters to specify which course module something
is for - if a field could be added that linked to an authorised value that we
use for additional fields in aqbasket, even better!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35197] Expose additional fields through REST API

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35197] Expose additional fields through REST API

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197

--- Comment #12 from Martin Renvoize  ---
I updated the mappings to be more consistent with the communities agreed
guidelines.. though it raised lots of little questions for me.. I'm wondering
how often our embeded extended_attributes are going to really look like the
spec here.

Sending Tomas's way for final QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35197] Expose additional fields through REST API

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197

--- Comment #11 from Martin Renvoize  ---
Created attachment 159650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159650=edit
Bug 35197: Field name consistency

This patch adds a to_api_mapping and updates the yaml definitions to be
ensure we are consistent with modern best practice for our api field
names.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35197] Expose additional fields through REST API

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158578|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 159649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159649=edit
Bug 35197: Add tests

prove t/db_dependent/api/v1/additional_fields.t

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35197] Expose additional fields through REST API

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158577|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 159648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159648=edit
Bug 35197: Add additional_fields REST API endpoint

Test plan:
1) Apply patch, restart plack 'koha-plack --restart kohadev'
2) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice its empty
3) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqbasket and add a
new additional field
4) Do step 2) again - Notice the newly created additional field is there
5) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqinvoices and add
a new additional field for invoices
6) Do step 2) again - Notice both additional fields are there
7) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice only the
additional field for aqinvoices is listed

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #5)
> RM: You know that this contains a string change :)

XD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Philip Orr  changed:

   What|Removed |Added

 Attachment #159586|0   |1
is obsolete||

--- Comment #26 from Philip Orr  ---
Created attachment 159647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159647=edit
Bug 35463: More preservation manual links

This patch adds some missing links from the preservation module to the manual.

To test:
1. Go to Preservation > Trains
2. Click on a train name
   --> You are brought to the Show train section of the Preservation chapter of
the manual
3. Click Edit next to an item
   --> You are brought to the Add items section of the Preservation chapter of
the manual (there is no section specific to editing items, but the form to edit
is the same as the form to add)
4. Go back to the trains list, and click the Edit button next to one of the
trains
   --> You are brought to the Trains section of the Preservation chapter of the
manual (there is no section specific to editing trains yet)

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Philip Orr  changed:

   What|Removed |Added

 Attachment #159584|0   |1
is obsolete||

--- Comment #25 from Philip Orr  ---
Created attachment 159646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159646=edit
Bug 35463: perltidy formatting corrections

Signed-off-by: Martin Renvoize 
Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Philip Orr  changed:

   What|Removed |Added

 Attachment #159583|0   |1
is obsolete||

--- Comment #24 from Philip Orr  ---
Created attachment 159645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159645=edit
Bug 35463: Open erm and preservation help in new tab

Signed-off-by: Martin Renvoize 
Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Philip Orr  changed:

   What|Removed |Added

 Attachment #159582|0   |1
is obsolete||

--- Comment #23 from Philip Orr  ---
Created attachment 159644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159644=edit
Bug 35463: Link preservation module help to the manual

This patch links the various pages of the preservation module to each
specific section of the preservation module chapter in the manual.

To test:
1.  Enable the PreservationModule system preference
2.  Go to the Preservation module
3.  Click "help" in the top right corner
--> You are brought to the manual, but not a specific page
4.  Apply patch
5.  Click "Help" in the top right corner
--> You are brought to the Preservation chapter of the manual
6.  Click "Settings"
7.  Click "Help" in the top right corner
--> You are brought to the Settings section of the Preservation chapter of
the manual
8.  Choose a not for loan status for items added to the waiting list (the
mandatory field) and submit
9.  Click "Add a new processing"
10. Click "Help" in the top right corner
--> You are brought to the Add a new processing section of the Preservation
chapter of the manual
11. Fill out the form to create the processing and submit
12. Click "Edit this processing"
13. Click "Help" in the top right corner
--> You are brought to the Add a new processing section of the Preservation
chapter of the manual (there is no edit a processing section)
14.  Click "Waiting list"
15. Click "Help" in the top right corner
--> You are brought to the Waiting list section of the Preservation chapter
of the manual
16. Add items to the waiting list
17. Click "Trains"
18. Click "Help" in the top right corner
--> You are brought to the Trains section of the Preservation chapter of
the manual
19. Click "New train"
20. Click "Help" in the top right corner
--> You are brought to the New train section of the Preservation chapter of
the manual
21. Fill out the form to create a new train and submit
22. Click "Add items"
23. Click "Help" in the top right corner
--> You are brought to the Add items section of the Preservation chapter of
the manual

24. Also check ERM help links to make sure nothing is broken

Signed-off-by: Martin Renvoize 
Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35463] Link preservation module help to the manual

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463

Philip Orr  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204

--- Comment #7 from Tomás Cohen Arazi  ---
I was going to fail this one yesterday but had a flight delayed.

- We need tests (they should highlight what dcook is saying)
- My opinion is we should return `error_code` => 'password_expired' or similar,
so API consumers can really act correctly on further steps for the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

Edith Speller  changed:

   What|Removed |Added

 CC||edith.spel...@ukhsa.gov.uk
 Status|Needs Signoff   |Signed Off

--- Comment #21 from Edith Speller  ---
Great work, thanks very much Pedro!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #158734|0   |1
is obsolete||

--- Comment #20 from PTFS Europe Sandboxes  ---
Created attachment 159643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159643=edit
Bug 35287: perltidy for green QA script

Signed-off-by: Edith Speller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #158733|0   |1
is obsolete||

--- Comment #19 from PTFS Europe Sandboxes  ---
Created attachment 159642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159642=edit
Bug 35287: Vue - Add additional fields support to ERM Licenses

Test plan, k-t-d:
1) Add a new additional field for the newly supported 'erm_licenses', visit:
/cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses
2) Create 4 fields by clicking on '+ New field'
2.1) 'text non-repeatable'
2.2) 'text repeatable', check the 'repeatable' box
2.3) 'av non-repeatable', pick an authorised value category
2.4) 'av repeatable', pick an authorised value category and check the
'repeatable' box
3) Add a new ERM license, visit:
/cgi-bin/koha/erm/licenses/add
4) Notice there is now a 'Additional fields' section at the bottom listing the
fields we created
5) Fill in the mandatory regular license fields and play around with the
additional fields
5.1) Put in some text in the text fields, test out the 'clear' and '+new'
buttons
5.2) Select some AV options from the AV fields, deselect them, notice the
repeatable one allows for multiple selection, the non-repeatable one does not
6) Save the license. On the list table, click on the license name (to navigate
to the show page), or if license id=1, visit:
/cgi-bin/koha/erm/licenses/1
7) Notice the additional fields are listed there, AV fields show their human
readable description, not the AV code. Repeatable fields are shown comma
separated
8) Edit the license, visit:
/cgi-bin/koha/erm/licenses/edit/1
9) Play around again, do some more inserting and deletion of additional fields.
Save. Notice everything is as expected.

Searchable testing:
10) Go back to the additional fields admin panel, visit:
/cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses
11) Edit one field (AV or not) that you have inserted some data in, in the
previous steps, and tick the 'searchable' box
12) Go back to licenses, visit:
/cgi-bin/koha/erm/licenses
13) Notice the searchable additional field now has its own column in the
licenses list table
14) If the searchable field is AV, it has a dropdown with the AV values of the
same AV category
15) If the searchable field not AV, it has a text input that allows for normal
text search
16) If the searchable field is repeatable and has multiple values, its
displayed in comma separated

Signed-off-by: Edith Speller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #158732|0   |1
is obsolete||

--- Comment #18 from PTFS Europe Sandboxes  ---
Created attachment 159641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159641=edit
Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional
fields

This follows the same pattern as in subscription serials searchable additional
fields, i.e. if an additional field is searchable, it is added to the list
table - with the corresponding search inputs and functionality

Signed-off-by: Edith Speller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #158731|0   |1
is obsolete||

--- Comment #17 from PTFS Europe Sandboxes  ---
Created attachment 159640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159640=edit
Bug 35287: Vue preparation - AdditionalFields

New api client: additional-fields-api-client.js to interact with the REST
endpoint introduced by bug 35197
2 new components:
- AdditionalFieldsEntry: Component used to extend the FormAdd component
including the corresponding additional fields
- AdditionalFieldsDisplay: Component used to display the additional fields
associated to a data record implementing it (makes use of strings_map)

Signed-off-by: Edith Speller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #158730|0   |1
is obsolete||

--- Comment #16 from PTFS Europe Sandboxes  ---
Created attachment 159639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159639=edit
Bug 35287: REST API - Add additional fields support to ERM Licenses

Signed-off-by: Edith Speller 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >