[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

David Nind  changed:

   What|Removed |Added

 Attachment #160616|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 160619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160619=edit
Bug 34979: Fix mistakes in system preference files highlighted by unit test

This fixes the mistakes the unit test helped to find:
* Add missing system preferences to sysprefs.sql
* Correct spelling for AutoUpdateSetsEmbedItemData
* Correct capitalization, so that code and pref files match
* Fix OverDrive sytem preferences, where explanation/options
  columns where switched, resulting in strange database entries

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

David Nind  changed:

   What|Removed |Added

 Attachment #160615|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 160618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160618=edit
Bug 34979: Sort sysprefs.sql alphabetically

This doesn't add or remove any entries, but only changes
the sequence of entries to be alphabetic again, compared
to:

SELECT variable FROM systempreferences ORDER BY variable;

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

David Nind  changed:

   What|Removed |Added

 Attachment #160614|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 160617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160617=edit
Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql

The unit tests will help to detect any discrepancies
and missing entries in the YAML and sysprefs.sql files.

To test:
* Apply only this patch
* prove -v t/db_dependent/check_sysprefs.t
* It will fail.
* Apply other patches
* Run database update
* Re-run test. It should pass now.
* Recreate your database or reset_all with patches applied.
* System preferences should be installed correctly.
* Test should still pass.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35570] Add a generic master form in ILL

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from David Nind  ---
I'm now getting this error after applying the first three patches (and
dependent patches), for step 3 in the Atomicupdate patch:

Can't locate Koha/Illrequests.pm in @INC (you may need to install the
Koha::Illrequests module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib
/kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1
/usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32
/usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at
/kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25.
BEGIN failed--compilation aborted at
/kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25.
Compilation failed in require at /kohadevbox/koha/Koha/ILL/Request.pm line 464

in Koha::ILL::Request::load_backend at /kohadevbox/koha/Koha/ILL/Request.pm
line 464

  461: my @raw   = qw/Koha Illbackends/;   
 # Base Path
  462: my $location  = join "/",  @raw, $backend_name,
"Base.pm";# File to load
  463: my $backend_class = join "::", @raw, $backend_name, "Base"; 
 # Package name
  464: require $location;
  465: $self->{_my_backend} = $backend_class->new($backend_params);
  466: }
  467: 



I also tried applying all the patches, and still got the error.

I'm sure I got past this point for my previous testing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #10 from Katrin Fischer  ---
The mistake in OAI-PMH:AutoUpdateSetsEmbedItemData (Set vs. Sets) made the
system preference non-functional, so updating this to a bug.

Be gentle in review, tried my best with the unit test :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

--- Comment #9 from Katrin Fischer  ---
Created attachment 160616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160616=edit
Bug 34979: Fix mistakes in system preference files highlighted by unit test

This fixes the mistakes the unit test helped to find:
* Add missing system preferences to sysprefs.sql
* Correct spelling for AutoUpdateSetsEmbedItemData
* Correct capitalization, so that code and pref files match
* Fix OverDrive sytem preferences, where explanation/options
  columns where switched, resulting in strange database entries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

--- Comment #8 from Katrin Fischer  ---
Created attachment 160615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160615=edit
Bug 34979: Sort sysprefs.sql alphabetically

This doesn't add or remove any entries, but only changes
the sequence of entries to be alphabetic again, compared
to:

SELECT variable FROM systempreferences ORDER BY variable;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

--- Comment #7 from Katrin Fischer  ---
Created attachment 160614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160614=edit
Bug 34979: Add unit test for comparing YAMl files with sysprefs.sql

The unit tests will help to detect any discrepancies
and missing entries in the YAML and sysprefs.sql files.

To test:
* Apply only this patch
* prove -v t/db_dependent/check_sysprefs.t
* It will fail.
* Apply other patches
* Run database update
* Re-run test. It should pass now.
* Recreate your database or reset_all with patches applied.
* System preferences should be installed correctly.
* Test should still pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

David Nind  changed:

   What|Removed |Added

 Attachment #160584|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 160613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160613=edit
Bug 35718: Remove ES6 warns from JS system preferences

To test:
1. Add some JS like this to any of the UserJS system preferences:

$(document).ready( function() {
let something = 1;
const another_thing = 2;

let an_arrow_function = (a, b) => a + b;
console.log( an_arrow_function(something, another_thing) );
});

2. Notice the icons and warnings to the left of the line numbers:

let is available in ES6
const is available in ES6
arrow_function_syntax is available in ES6

3. APPLY PATCH
4. Try steps 1 and 2 again, the warnings should be gone.
5. Check that the JavaScript still works, in my example it should console.log
3.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35300] Add page-section to table of invoice files

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300

David Nind  changed:

   What|Removed |Added

 Attachment #160603|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 160612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160612=edit
Bug 35300: Add page-section to invoice files page

To test:
* Enable AcqEnableFiles system preference
* Go to acquisitions
* Search for a vendor and receive shipment
* Enter an invoice number and create new invoice
* Finish receive
* Click on 'manage invice files' link
* Upload a sample file
* Verify the table is missing the usual white background
* Apply patch
* Verify the the table now displays with the usual white
  background

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35300] Add page-section to table of invoice files

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395

David Nind  changed:

   What|Removed |Added

 Attachment #160604|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 160611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160611=edit
Bug 35395: Update DefaultPatronSearchMethod system preference description

This updates the system preference description of DefaultPatronSearchMethod
so that it's clear that the preference applies to all patron
searches, including patron module search and auto-completes.

To test:
* Search for DefaultPatronSearchMethod system preference in administration
* Verify the setting is reflected in the filters of the patron search
* Apply patch
* Verify that the description now is now improved.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35395] Update description of DefaultPatronSearchMethod

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

David Nind  changed:

   What|Removed |Added

 Attachment #160602|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 160610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160610=edit
Bug 35323: Fix hint for OpacMoreSearches HTML customization

There was some confusion on where this content appears.
This patch fixes the description shown as hint in the HTML
customizations tool when when the OpacMoreSearches entry is
selected.

To test:
* Before appyling the patch
* Add a new HTML customization for OpacMoreSearches
* Verif hint showing below the pull down
* Set a title and a publication date in the past
* Enter a short text, like "Koha" as content
* Save
* Go to the OPAC, verify text shows in the navigation
* Apply patch
* Verify hint is now correct

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35602] Typo: AutoMemberNum

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602

David Nind  changed:

   What|Removed |Added

 Attachment #160601|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 160609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160609=edit
Bug 35602: Fix typo AutoMemberNum

The correct spelling is autoMemberNum.

To test:
* Enable autoMemberNum system preference
* Set cardnumber to mandatory in BorrowerMandatoryField
* Add a new patron account
* Verify correct spelling in hint below cardnumber input field

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35602] Typo: AutoMemberNum

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35602

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691

David Nind  changed:

   What|Removed |Added

 Attachment #160600|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 160608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160608=edit
Bug 25691: (follow-up) Update control file with wiki link

This is in case it's needed anyway (see comment on previous patch)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691

David Nind  changed:

   What|Removed |Added

 Attachment #160599|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 160607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160607=edit
Bug 25691: Replace link to non-existing README with wiki link

This doesn't update the occurrence in the control file
as it says in control.in:

To test:
* Verify all occurrences of the README file have been updated. Exceptions:
  * control (see above)
  * changelog

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

David Nind  changed:

   What|Removed |Added

   Assignee|alex.arn...@biblibre.com|emily-rose.francoeur@inLibr
   ||o.com
 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #19 from David Nind  ---
I was about to sign off, but then came across this Zebra only error - I get
this error after the patches are applied (and a reindex):

   Error: Can't use an undefined value as an ARRAY reference at
/kohadevbox/koha/labels/label-item-search.pl line 88
   

1. Generated by putting a letter in the input box for these index searches
(without any dates in the filters): publication date, standard number, ISBN,
ISSN, call number, acquisition date

2. I could also generate this error with a number in a text field, for example:
Author index, 2011 (but with 2000 no error is generated)

3. With Elasticsearch, no results are displayed and the form just refreshes
(both before and after the patches, and the same with Zebra before the patches)

Other notes
===

1. I couldn't work out how or where cgi-bin/koha/labels/label-item-search.pl is
used/accessed from - something to do with acquisitions?

2. I've changed the assignee.

3. I didn't test with a UNIMARC installation.

Testing notes (using koha-testing-docker)
=

Setup
~

To test with Elasticsearch or OpenSearch - start up KTD with Elasticsearch or
OpenSearch: ktd --es8 up OR ktd --os2 up (I didn't test with Open Search, just
Zebra and Elasticsearch)

Go to this page in the staff interface:
http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl

Searching using Zebra (after KTD is started with --es8):
- Change the SearchEngine system preference to Zebra
- Reload http://127.0.0.1:8081/cgi-bin/koha/labels/label-item-search.pl
- Reindex: koha-rebuild-zebra -d -f -v kohadev
- Repeat all the example searches - you should get the same results

Demonstrating the issue and that the patches fix it
~~~

Notes: In the sample data, the acquisition date is recorded in 952$d - Date
acquired. 
   For many items, 09/04/2014 is used.
   For some items, these dates are used 05/08/2014, 05/07/2014, 10/15/2014,
12/04/2014, 1/05/2015.
   Many items don't have a date recorded.
   If there is no value in the index field, it is ignored.
   If an index is selected and a value is entered, the results should be
filtered by any values entered in 'Added on or after date' and 'Added on or
before date' fields.

Before the patches: index searches work, but when used with 'Added on or after
date' and 'Added on or before date' options, the search results ignore them.
However, entering a date for the 'Acquisition date' index does work.

A title index search:
- Title index: perl
  => Expected result: 11
  => Actual result: 11

A combined search with dates:
- Title index: perl
- Added on or after date: 09/04/2014
  => Expected result: 10 (1 perl record has no items)
  => Actual result: No results

A combined search with dates:
- Title index: perl
- Added on or before date: 09/04/2014
  => Expected result: 10 (1 perl record has no items)
  => Actual result: No results

Acquisition date index search:
- Index: select 'Acquisition date' from the dropdown list
- Value to enter: 09/04/2014
  => Expected result: 352 results
  => Actual result: 352 result

Acquisition date index search:
- Index: select 'Acquisition date' from the dropdown list
- Value to enter: 09/04/2014
- Added on or after date: 09/04/2014
  OR
- Added on or before date: 09/04/2014
  OR
  Use both or none
  => Expected result: 352 results
  => Actual result: 352 results

Search using 'Added on or after date' (after date) only:
- Added on or after date: 09/04/2014
  => Expected result: should get 408 records
  => Actual result: 0 results

Search using 'Added on or before date' (before date) only:
- Added on or after date: 09/04/2014
  => Expected result: should get 354 records
  => Actual result: 0 results

Publication date index search using 2011 (AFTER patches are applied - doesn't
work as expected BEFORE the patches are applied):
- Results if no before or after filter added: 8 (as expected)
- Results if Added on or after date: 09/04/2014 - 8 (as expected)
- Results if Added on or before date: 09/04/2014 - 7 (as expected)
- Results for a date range - 7 (as expected):
  . Added on or after date: 09/04/2014
  . Added on or before date: 09/05/2014
- Results for a date range - 8 (as expected):
  . Added on or after date: 09/04/2014
  . Added on or before date: 10/15/2014
- Results for a date range - 1 (as expected):
  . Added on or after date: 09/05/2014
  . Added on or before date: 10/15/2014
(One record 

[Koha-bugs] [Bug 35394] Tone down "!!A booking exists!!" a bit

2024-01-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394

--- Comment #2 from Martin Renvoize  ---
Pretty sure this was just debugging left in by mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/