[Koha-bugs] [Bug 24778] Move from Memcached to Redis to solve L1 caching issues?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- If no one else gets this first, I'll try to look at it tomorrow or week after next... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35732] No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 --- Comment #2 from Katrin Fischer --- We can't assume URL is common with the English term in every language, so they should show in translations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35732] No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 --- Comment #1 from Katrin Fischer --- What is the issue you are trying to point out? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35697] Checkingout books causes a error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Please verify that your item has complete information. It needs: > > * an itemtype (MARC21 $y) > * a homebranch (MARC21 $a) > * a holdingbranch (MARC21 $b) > > If the item is complete, it would help to get the full error from the server > logs. Did you check these? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35729] Coce Should Account for New ISBN 979*
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Thanks for reporting this one, Kal. I think this is going to have wide-ranging implications across a number of different areas of Koha (and other library systems). I haven't done anything with Coce but I'm going to think about some of those other consequences of this new(ish) prefix... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1610] Redirect to result when opac search returns only one item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1610 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35728 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=1610 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #4 from Martin Renvoize --- This is looking great, nice one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35697] Checkingout books causes a error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697 Pradeep changed: What|Removed |Added CC||agasti...@gmail.com --- Comment #2 from Pradeep --- I also experienced same problem. all other functions are working fine. While checking out it gives 500 error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from David Nind --- The patch for master still applies, however the tests are still failing. I haven't fully re-tested the 22.05 and master patches yet - see comment #10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35545] "additional" item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #6 from Igor A. Sychev --- Created attachment 160682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160682=edit OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35545] "additional" item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #5 from Igor A. Sychev --- OPAC https://koha.lib.tpu.ru/cgi-bin/koha/opac-detail.pl?biblionumber=669655 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35545] "additional" item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #4 from Igor A. Sychev --- Created attachment 160681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160681=edit MARC preview -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35545] "additional" item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545 --- Comment #3 from Igor A. Sychev --- Created attachment 160680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160680=edit staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Hi Aleisha. I like this! It looks like the patch(es) with the database update/system preference addition is missing... David Testing notes (using KTD and the sample data): 1. Search for higher-order for a single search result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35732] New: No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 Bug ID: 35732 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: igor.a.syc...@mail.ru QA Contact: testo...@bugs.koha-community.org %sURL: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35731] New: No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35731 Bug ID: 35731 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: igor.a.syc...@mail.ru QA Contact: testo...@bugs.koha-community.org %sLCCN: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35730] New: No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35730 Bug ID: 35730 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: igor.a.syc...@mail.ru QA Contact: testo...@bugs.koha-community.org %s%sISBN: %s%s%s; %s%s%s%s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35729] New: Coce Should Account for New ISBN 979*
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 Bug ID: 35729 Summary: Coce Should Account for New ISBN 979* Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kall...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hi, I noticed that there was a cover mismatch with a coce_amazon cover because the new 2024 title has an ISBN of 9798885795692 (using the 979 instead of 978). There is an Italian title with an ISBN of 8885795692 that is showing instead. It looks like they have updated the valid ISBN standards: https://isbn.org/about_isbn_standard and it seems like coce should be updated to recognize this new standard and not match 9798885795692 to be the same as 8885795692. Thanks! Kal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen changed: What|Removed |Added Attachment #149475|0 |1 is obsolete|| --- Comment #5 from Michael Hafen --- Created attachment 160679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160679=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists [Rebase on master 2023-12-28] Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observe that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What|Removed |Added Attachment #160627|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 160678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160678=edit Bug 35686: (follow-up) Correct page heading Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What|Removed |Added Attachment #160593|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 160677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160677=edit Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.122 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 --- Comment #5 from Lucas Gass --- Straightforward and simple fixes, no issues with the QA tool. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #69 from Victor Grousset/tuxayo --- Hi :) change needed when bug 35517 (passed QA) is pushed to master (so soon unless a surprise comes up): Look at the patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160671=diff The change should be: [% ELSIF ( CAN_user_borrowers_edit_borrowers ) %] ↓↓ [% ELSIF ( CAN_user_borrowers_edit_borrowers ) || ( CAN_user_borrowers_list_borrowers ) %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #33 from Lucas Gass --- Created attachment 160676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160676=edit Bug 34668: (QA follow-up) Change file permission Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158530|0 |1 is obsolete|| --- Comment #32 from Lucas Gass --- Created attachment 160675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160675=edit Bug 34668: pass whole waiting_holds rs Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158529|0 |1 is obsolete|| --- Comment #31 from Lucas Gass --- Created attachment 160674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160674=edit Bug 34668: remove binding/unbinding event for one submit event Signed-off-by: Mia Kujala Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158528|0 |1 is obsolete|| --- Comment #30 from Lucas Gass --- Created attachment 160673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160673=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there are holds waiting for patrons, sometimes the librarian misses the "Holds waiting here" display. This patch adds a modal popup warning when checking out an item for a patron with waiting holds. Test plan: 1) find a user (user1) 2) find a biblio (biblio1) 3) add a hold for biblio1 to user1 (search biblio1 > Holds > find user1 > Place hold) 4) checkout biblio1 to another user if not already checked out and checkin through circulation page (not through the user page) > confirm hold 5) there should be a "Holds waiting here (1)" section added on user1 page 6) checkout any items that isn't the one on hold for user1 -> notice it just checks out as normal 7) apply patch and update database 8) go to administration > system preferences > switch "WaitingNotifyAtCheckout" to "Notify" 9) refresh page and redo step 6 -> notice there is now a modal to warn the librarian of a waiting hold click Ok to proceed with the checkout, click outside the modal to not do anything 10) additionnally, the popup shouldn't appear if we checkout any of user1's waiting hold Signed-off-by: Matt Blenkinsop Signed-off-by: Mia Kujala Signed-off-by: Kelly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #29 from Lucas Gass --- Working as described. QA script is mostly happy, 1 issue with file permissions that I am fixing in a follow-up. The rest of the code looks good. DBUpdate looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Chris Cormack changed: What|Removed |Added Attachment #138520|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 160672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160672=edit Bug 31286: Embed see-from headings into bibliographic records export In misc/export_records.pl add an option to add see-from headings (from authorities 4xx) into bibliographic records export. Like it is done during record indexing. Test plan : 1) Choose a biblio record having a field (for example 650) linked to an authority with a see-form. 2) Export this record without see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_without.xml --format xml 3) Export this record with see-from headings : misc/export_records.pl --starting_biblionumber=X --ending_biblionumber=X --filename /tmp/record_with.xml --format xml --embed_see_from_headings 4) Compare /tmp/record_without.xml and /tmp/record_with.xml => you should see two 650, one with main heading and one with see-from heading Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31286] Embed see-from headings into bibliographic records export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31286 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #159677|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 160671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160671=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Chris Cormack changed: What|Removed |Added Attachment #131933|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 160670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160670=edit Bug 11180: IP branch attribute should accept CIDR notation and add multiple ip This patch adds the ability to set more than ip to IP setting of a branch and also CIDR notation can recognised also. Test plan: 1) Change systempreference AutoLocation to "Yes" 2) Go to the library settings ( Administration -> Libraries ) and you can add only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.* 3) Apply patch 4) Go to the library settings and you can enter to IP setting those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats. 3) Logout 4) Try to login from an ip that not belong on the set of ip that you enter before and now CIDR notation can regognized also and also you can have more than one ip for restriction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Chris Cormack changed: What|Removed |Added Attachment #131927|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 160669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160669=edit Bug 11180: IP branch attribute should accept CIDR notation This patch adds the ability to set more than ip to IP setting of a branch and also CIDR notation can recognised also. Test plan: 1) Change systempreference AutoLocation to "Yes" 2) Go to the library settings ( Administration -> Libraries ) and you can add only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.* 3) Apply patch 4) Go to the library settings and you can enter to IP setting those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats. 3) Logout 4) Try to login from an ip that not belong on the set of ip that you enter before and now CIDR notation can regognized also and also you can have more than one ip for restriction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 --- Comment #1 from Aleisha Amohia --- Created attachment 160668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160668=edit Bug 35728: Add ability to NOT redirect to result when search returns only one record This enhancement adds a new system preference RedirectToSoleResult. By default it is enabled, which matches current behaviour - to redirect to the detail page if it is the only search result. To test: 1) Apply the patch, install database updates, restart services. 2) Go to Koha Administration -> Global system preferences. The RedirectToSoleResult system preference is in the Searching tab. Confirm it is enabled (set to "Redirect") by default. 3) Conduct a catalogue search on the staff interface that you know will return a single result. Confirm you are redirected to the detail page. 4) Do the same search on the OPAC. Confirm you are redirected to the detail page. 5) Go back to the system preferences and disable the RedirectToSoleResult system preference by setting it to "Don't redirect" 6) Do the searches again on the staff interface and OPAC. Confirm you are NOT redirected to the detail page, and the search results page shows as expected. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- (In reply to Katrin Fischer from comment #4) > As we are on the library page, I feel like we don't need to point out that > it's library specific, all the fields on the page are and it would help to > keep the label/hint a bit shorter. I agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #3 from Chris Cormack --- Sorry I forgot to mention you will need to go to https://bugs.koha-community.org/bugzilla3/userprefs.cgi and set your skin to KohaV2 to see the new skin. Few little things to work out on smaller screens but people can test it now. I've symlinked in the repo so if you update it lemme know and ill do a git pull and you can see the changes in bugzilla -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Chris Cormack --- This has been applied, I like it :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] New: Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Bug ID: 35728 Summary: Add option to NOT redirect to result when search returns only one record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 Phan Tung Bui changed: What|Removed |Added Attachment #160220|0 |1 is obsolete|| --- Comment #5 from Phan Tung Bui --- Created attachment 160667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160667=edit Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. - Nicely done! Signed-off-by: Phan Tung Bui -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 Phan Tung Bui changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 --- Comment #4 from Katrin Fischer --- As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I don't mind the replacement labels, as they are a great improvement: - UserJS -> Specific OPAC JS - UserCSS -> Specific OPAC CSS Some alternatives: 1. Library specific OPAC JavaScript Library specific OPAC CSS 2. Library specific JavaScript for the OPAC Library specific CSS for the OPAC 3. OPAC JavaScript for this library OPAC CSS for this library I think I like 3 better, but leaving up to the QA Team. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What|Removed |Added Attachment #160626|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 160666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160666=edit Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35530] Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 David Nind changed: What|Removed |Added Attachment #160649|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 160665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160665=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 David Nind changed: What|Removed |Added Attachment #160652|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 160664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160664=edit Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 David Nind changed: What|Removed |Added Attachment #160651|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 160663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160663=edit Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status s to s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What|Removed |Added Attachment #160650|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 160662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160662=edit Bug 35725: Fix 'Create' button enabled/disabled The previous patch fixed what it stated, but uncovered a new issue: If you input a cardnumber + a branchcode and then change type, the 'Create' button becomes disabled This happens because the trigger for it is on change only, the current patch updates this to also happen on DOMContentLoaded. Test plan: 1) Apply previous patch 2) Do steps from previous patch plan up to and including step 5) 3) Click 'Create'. Notice it doesn't submit (nothing happens). 4) Apply this patch and do a hard reload (clearing browser js cache) 5) Repeat steps 1) to 3). Notice it now submits correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What|Removed |Added Attachment #160630|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 160661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160661=edit Bug 35725: Keep cardnumber and library data when changing request type Test plan: 1) Apply 35570 2) Enable ILLModule sys pref through UI, or run: echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev 3) Create a new Standard request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create=Standard 4) Input a cardnumber and/or set a library at the bottom under "Patron options". 5) Change the type (top of the form). Notice the data from step 4) is gone. 6) Apply patch. Repeat test plan and notice data is kept when changing request type. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #24 from David Nind --- Additional testing == I created a new ILL request and tested the various options available on the ILL requests page (this wasn't part of the test plan): - Confirm request: page not found (404) error when confirming request (URL was /cgi-bin/koha/ill/%2Fcgi-bin%2Fkoha%2Fill%2Fill-requests.pl%3Fmethod%3Dconfirm%26stage%3Dconfirm%26illrequest_id%3D2) - presume something else is required to configure this? - All the other areas seemed to work as expected: . Edit request . Place request with partner libraries (add a couple of patrons to the Inter-Library Loan patron category, make sure they have an email address) . Delete request . Edit item metadata . Send notice to patron (I added an email to the patron used to create the request, updated patron message preferences, and added an email address to the various email system preferences) . Display supplier metadata (found this confusing - it shows the request metadata, but this is the existing terminology) . ILL request log (changes made to the request show after enabling the IllLog system preference) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570
--- Comment #23 from David Nind ---
Testing notes (using KTD):
1. Apply the first three patches:
- Bug 35570: Put 'FreeForm' backend into core as 'Standard'
- Bug 35570: Consider 'Standard' core backend
- Bug 35570: Atomicupdate
Notes:
- Apply all the dependent bugs
- For 35570 (this bug) use i (for interactive) and add a # hash in front of
the patches not to apply at this time
2. Run the database update: updatedatabase
=> Output:
Upgrade to 23.12.00.003 [18:41:32]: Bug 35681 - Test DB Rev output
Something in red is a warning
Somthing in yellow is a call to action
Something in blue is for information only
You could use 'WHITE' too?
Or leave color off and stick to default
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [18:41:32]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
Bug 35570: Finished database update.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [18:41:32]:
Bug 35681 - Test Atomic update output
Something in red is a warning
Somthing in yellow is a call to action
Something in blue is for information only
You could use 'WHITE' too?
Or leave color off and stick to default
3. Install the FreeForm backend. Run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
4. Change the FreeForm branch to reorganize_ILL. From within the
Koha/Illbackends/FreeForm directory: git checkout reorganize_ILL
5. Run flush_memcached and restart_all (not sure whether these are required
here, but I ran them anyway).
6. Install the Pubmed plugin:
- Download from https://github.com/PTFS-Europe/koha-plugin-api-pubmed
- Upload the plugin: Koha administration > Plugins > Manage plugins
- Run restart_all
7. Create a new 'FreeForm' ILL batch:
- + New ILL requests batch
- Select the 'FreeForm' option
- Batch details:
. Batch name: BZ35570
. Card number...: 42 (koha)
. Library: Centerville
- Select 'Continue'
- Add '123' to the PubMed ID list of identifiers
- Click 'Process identifiers'
- Once processed, click 'Add items to batch'
- Click 'Finish and view batch'
=> You now have 1 request, 1 batch and a few ILL request attributes in the
'FreeForm' backend
8. Run updatedatabase again, notice that there are now extra messages from the
previous database update - "Updated ILL batches from 'FreeForm' to
'Standard'...":
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:26:57]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard
Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard
Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard
Bug 35570: Finished database update.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:26:57]:
Bug 35681 - Test Atomic update output
Something in red is a warning
Somthing in yellow is a call to action
Something in blue is for information only
You could use 'WHITE' too?
Or leave color off and stick to default
9. Create a saved SQL report with this SQL (note that if you run the report you
get no results): Select * from illrequests where backend="FreeForm"
10. Run the updatedatabase again. Note that there is a warning about the report
you created "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing
occurrences of 'FreeForm' were found.":
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:30:47]:
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard'
Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing
occurrences of 'FreeForm' were found.
The following reports MUST be updated accordingly ('FreeForm' ->
'Standard'):
Report ID: 1 | Edit link:
http://kohadev-intra.koha-testing:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1=Edit%20SQL
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:30:47]:
Bug 35681 - Test Atomic update output
Something in red is a warning
Somthing in yellow is a call to action
Something in blue is for information only
You could use 'WHITE' too?
Or leave color off and stick to default
11. Apply the remainder of the patches for this bug:
- Say no for all the dependencies, as they are already installed
- For 35570 (this bug) use i (for interactive) and add a # hash in front of
the first three patches
- There is no need to run the databaseupdate again
- Run flush_memcached and restart_all (not sure if this is required, but is
what I normally do after applying a patch)
12. Go to the ILL page: Administration > ILL
[Koha-bugs] [Bug 35554] Authority search popup is only 700px
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Phan Tung Bui changed: What|Removed |Added CC||phan-tung@inlibro.com --- Comment #7 from Phan Tung Bui --- Failed QA The width of the popup remains 700px -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #22 from David Nind --- (In reply to Pedro Amorim from comment #14) ... > > I believe the error you're getting is because you may have skipped this step: > 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: > https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ > > After you git checkout reorganize_ILL in FreeForm you may have to koha-plack > --restart. Would you please try again? Reach out to me on IRC, I'm always > available. Thanks! Thanks Pedro. That was the issue! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #21 from David Nind --- Created attachment 160660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160660=edit Bug 35570: (QA follow-up): Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af0181341dea5ce8c3bb2e into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #160452|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 160659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160659=edit Bug 35570: QA follow-up: Update updatedatabase report colors to base on bug 35681 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #159947|0 |1 is obsolete|| Attachment #160457|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 160658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160658=edit Bug 35570: (QA follow-up): Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #159946|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 160657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160657=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #159944|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 160656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160656=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #159943|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 160655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160655=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Attachment #159942|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 160654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160654=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #26 from Victor Grousset/tuxayo --- Great, so the main idea of the patch doesn't have a fatal flaw. That was the main focus of the last few days. > What's the next step then There is this question remaining: Instead of having the flag window._pageFullyReady, should the problematic buttons be hidden in the HTML? (and *maybe* have a dummy button with a loading icon in place to show the user that stuff it loading) And then the stuff in $(document).ready() makes them visible after setting the onclick callback. And the test just waits for the button to be visible instead of the flag to be set. Also, can we try without the sleeps (DT_delay) before wait_for_ajax? That's 10 seconds of sleep in total (because loop). And in my very numerous runs, I never had a failure where wait_for_ajax instantly returned and the table content wasn't loaded. So there are fair chances that the show checkout button isn't affected by the same issue as seen in bug 35284. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35554] Authority search popup is only 700px
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac --- Failed QA The authority search popup remains at a width of 700 pixels after the patch is applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||matthias.le-...@inlibro.com --- Comment #4 from Matthias Le Gac --- Patch doesn't apply. I have this error : Applying: Bug 32105 - Add Library and Individual sharing modes to Patron Lists error: sha1 information is lacking or useless (patron_lists/patron-lists-tab.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32105 - Add Library and Individual sharing modes to Patron Lists hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32105---Add-Library-and-Individual-sharing-mod-6hyf27nh.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What|Removed |Added Blocks||28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha::
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What|Removed |Added Depends on||35721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35584] Missing licenses in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #13 from Owen Leonard --- Created attachment 160653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160653=edit Bug 35584: (follow-up) Remove duplicate license entry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35584] Missing licenses in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 Andreas Jonsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35727] Unused code in HoldsQueue::MapItemsToHoldRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727 --- Comment #1 from Andreas Jonsson --- Created attachment 160652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160652=edit Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Owen Leonard changed: What|Removed |Added Attachment #160571|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 160651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160651=edit Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status s to s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35727] New: Unused code in HoldsQueue::MapItemsToHoldRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35727
Bug ID: 35727
Summary: Unused code in HoldsQueue::MapItemsToHoldRequests
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
The hash %specific_items_requested is computed but never used anywhere. I went
all the way back to v3.0.6 and couldn't find any sign that it has ever been
used.
# identify item-level requests
my %specific_items_requested = map { $_->{itemnumber} => 1 }
grep { defined($_->{itemnumber}) }
@$hold_requests;
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 --- Comment #3 from Pedro Amorim --- Created attachment 160650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160650=edit Bug 35725: Fix 'Create' button enabled/disabled The previous patch fixed what it stated, but uncovered a new issue: If you input a cardnumber + a branchcode and then change type, the 'Create' button becomes disabled This happens because the trigger for it is on change only, the current patch updates this to also happen on DOMContentLoaded. Test plan: 1) Apply previous patch 2) Do steps from previous patch plan up to and including step 5) 3) Click 'Create'. Notice it doesn't submit (nothing happens). 4) Apply this patch and do a hard reload (clearing browser js cache) 5) Repeat steps 1) to 3). Notice it now submits correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35726] New: Add ability to edit automatic item modification by age rules individually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35726 Bug ID: 35726 Summary: Add ability to edit automatic item modification by age rules individually Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When there are several rules, it would be nice if it were possible to edit individual rules. Right now, in order to edit one rule, all rules are opened for editing. This could be done by adding an edit button at the end of the row in the table that lists the rules. As an extension, the rules table should be sortable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721 Martin Renvoize changed: What|Removed |Added Attachment #160632|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 160649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160649=edit Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl This patch replaces the call to ModItemTransfer in circ/returns.pl with a call to Koha::Item->request_transfer and Koha::Item::Transfer->transit. Test plan 1) Set 'AutomaticItemReturn' to "Don't" 2) Check an item in at a location other than it's 'home' or 'holding' branch 3) Note you should be asked a about returning the item to another branch 4) Opting to not proceed should NOT result in a row in the branchtransfers table 5) Option to proceed (either with a print slip or just 'OK') should result in a branchtransfer from the current checkin branch to the home or holding branch depending on the circulation rules. 5a) The item should be marked as immediately in transit in, i.e. the 'datesent' set to today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What|Removed |Added Attachment #160647|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 160648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160648=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What|Removed |Added Attachment #160643|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 160647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160647=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Update get_transfer and get_transfers to ensure ordering isn't lost when prefetch is used and add tests for this Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Martin Renvoize changed: What|Removed |Added Blocks||35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What|Removed |Added Depends on||34639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 --- Comment #3 from Alex Buckley --- Created attachment 160646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160646=edit Bug 35724: Define non-standard ports for EDI SFTP in EDI accounts Not all EDI vendors accept Koha servers connecting on port 22, sometimes they require a different port to be used, so it would be helpful for librarians to be able to configure non-standard EDI SFTP ports themselves. Test plan: 1. Set EDIFACT syspref = 'Enable' and define a EDI account: Administration > Acquisition parameters > EDI accounts. 2. Create an EDI order: https://koha-community.org/manual/latest/en/html/acquisitions.html#ordering-via-edi 3. Confirm you can upload the EDI order and download the vendor invoice. 4. Apply patches, update database, and restart services. 5. Go to the EDI account you made in #1. 6. Confirm there are two new fields: Upload port and Download port, both have the value of 22. 7. Create a new EDI order. 8. Confirm you can upload the EDI order and download the vendor invoice. 9. Change the EDI account. Set the Download port = 10022. 10. Create a third EDI order. 11. Confirm you can upload the EDI order and download the vendor invoice. Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
