[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #21 from Jonathan Druart --- (In reply to Martin Renvoize from comment #20) > For consistency you're right, thanks for spotting it. Consistency only? Then why do we need this parameter if we can pass a wrong value? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #43 from Marcel de Rooy --- Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What|Removed |Added Attachment #160844|0 |1 is obsolete|| Attachment #160850|0 |1 is obsolete|| --- Comment #42 from Marcel de Rooy --- Created attachment 160896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160896=edit Bug 35341: Improve processing hard due date and auto renewal date After quite a struggle, came up with this approach using flatpickr's parseDate and setDate. Seems to be the best. The dateformat variable is set in calendar.inc. Test plan: Test edit, save, clear rules, focus on both dates. Toggle all I18N preference date formats. Signed-off-by: Marcel de Rooy Bug 35341: Do not reinstantiate flatpickr We do not need to reinstantiate flatpickr, we need to retrieve the existing instance. Test plan: See previous patch. Signed-off-by: Marcel de Rooy 12-01-2024 Squashed both patches. Removed the unused hidden inputs for hardduedatecompare and added a data attribute for the duedate. The check with is_valid_date seems no longer needed here. Normally date is empty or valid. A js warning from parseDate should be exceptional. Made code for both dates a bit more consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35772] Double escaping of patron fields in bookings modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35772 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Replicated the issue as per comment #1 2. Applied the patch. 3. Repeated step 1. 4. Name now displays (with HTML code shown). Note: IN KTD I had to set DefaultPatronSearchMethod to 'Contains', otherwise searching for Test didn't return any autocomplete results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35772] Double escaping of patron fields in bookings modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35772 David Nind changed: What|Removed |Added Attachment #160832|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 160895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160895=edit Bug 35772: Remove double escaping Patch as proposed by Jonathan in a comment on bug 29002 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35772] Double escaping of patron fields in bookings modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35772 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #58 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #56) > Signed-off-by: Kyle M Hall Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35732] No translation is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35532] Use of calendar for date range in bookings is not clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #6 from David Nind --- It was not obvious to me. However, it seems obvious now that you've pointed it out! I don't think I've seen this pattern elsewhere in Koha (but I'm probably wrong about that...). Since I'm not familiar with the booking feature, I "assumed" it was just for one day. Normally, with the date picker, I pick a day then click outside the picker so that the date appears in the input field. So I hope that this didn't come across as too negative! Some ideas - not tied to any of them: 1. Label for Period: . Start and end date of booking (this is quite long though) . Booking dates . Start and end date 2. Hint for the field (like for the patron): . Select the booking start and end date 3. Not sure how these would work for translation. I think I prefer a combination of "Booking dates" as the label and a hint for the field "Select the booking start and end date". Other things noted (outside scope for this bug, just noting - happy to open bugs if they don't exist already): 1. Not sure how to use the 'Tomorrow' date link in the picker - does nothing for me. Should this be disabled? 2. Accessibility things - using keyboard instead of a mouse (I don't know enough to know if these are fixable, or even issues): . Patron field: works OK with tab, search, and then the down arrow to select a patron . Item field: can tab to it, but can't select item using down or up arrows . Period: tab opens date picker, but not sure how to select a date range 3. You need to pick a date range: what if you only wanted to book for one day? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 --- Comment #10 from Emily Lamancusa --- Incidentally, while testing different scenarios with this patch to check for regressions, I found bug 35780 - HoldsAutoFill allows both a hold and a recall to be filled simultaneously by the same item I can't justify spending time on it myself since MCPL doesn't use recalls, but it should definitely be addressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35780] New: HoldsAutoFill allows both a hold and a recall to be filled simultaneously by the same item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35780 Bug ID: 35780 Summary: HoldsAutoFill allows both a hold and a recall to be filled simultaneously by the same item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To replicate: 1. Configure sysprefs: HoldsAutoFill to Do HoldsAutoFillPrintSlip to Do (optional but makes behavior very obvious) UseRecalls to Use 2. Edit the default circ rule to set a nonzero value for max recalls allowed and recalls per record allowed 3. Check out an item to Patron A 4. Place a hold on that title for Patron B 5. Place a recall on that title for Patron C 6. Check in Patron A's item --> Patron B's hold autofills --> Note that you still get a modal to confirm Patron C's recall 7. Confirm Patron C's recall --> Note that the hold and the recall are both set to "Waiting" with the same item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/814 CC||caroline.cyr-la-rose@inlibr ||o.com Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 --- Comment #9 from Emily Lamancusa --- *** Bug 30505 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30505] Warning when issuing recalled item that has a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30505 Emily Lamancusa changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #1 from Emily Lamancusa --- The patch for bug 35322 resolves this too, and 35322 has passed QA, so I'm marking this one as a duplicate *** This bug has been marked as a duplicate of bug 35322 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33399] Improve checks of other items to determine if this is a valid recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Status|Needs Signoff |Failed QA --- Comment #3 from Matthias Le Gac --- Hi, I followed the plan test all it's work until I apply the patch when I do again the step 4 I have again the message "There are no items available for recall". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #14 from Emily Lamancusa --- Is this still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18054] Refreshing the screen for a confirmed checkout can cause odd results (item checked out and waiting on hold)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18054 Emily Lamancusa changed: What|Removed |Added Status|NEW |RESOLVED CC||emily.lamancusa@montgomeryc ||ountymd.gov Resolution|--- |WORKSFORME --- Comment #1 from Emily Lamancusa --- Just tested whether this is still an issue on master. It appears not - refreshing the tab reverted the hold and checked out the item. Marking this one as resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/813 Resolution|--- |FIXED Documentation||Caroline Cyr La Rose contact|| Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 --- Comment #8 from Emily Lamancusa --- Looks good, works, and passes the QA script! This also cleans up the messages in the staff interface - without the patch, if you try to check out an item that has both a recall and a hold from the staff interface, you get a confusing message that mixes the two confirmation questions, and offers the option to cancel checkout and fill the hold but not the option to fill the recall. With the patch, you get one confirmation message that warns of the recall and provides the expected options. Given that recalls are meant to take precedence over holds, it's my understanding that this would be the expected behavior. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 --- Comment #8 from David Nind --- FYI: I answered a query on Facebook about this bug - they were able to successfully fix it. Just a "normal" upgrade, I think. https://www.facebook.com/groups/6381238597/permalink/10161615713058598/?mibextid=oMANbw -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14092] Add ability to search on 'all statuses' to orders search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED --- Comment #22 from Caroline Cyr La Rose --- The orders advanced search is already documented in the manual, without specifying details and options of each field. I will close this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 --- Comment #7 from Emily Lamancusa --- Created attachment 160894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160894=edit Bug 35322: (QA follow-up) Perltidy Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Emily Lamancusa changed: What|Removed |Added Attachment #159511|0 |1 is obsolete|| --- Comment #6 from Emily Lamancusa --- Created attachment 160893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160893=edit Bug 35322: Add unit tests Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Emily Lamancusa changed: What|Removed |Added Attachment #159510|0 |1 is obsolete|| --- Comment #5 from Emily Lamancusa --- Created attachment 160892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160892=edit Bug 35322: Fix the logic for checking for holds in CanBookBeIssued We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. Test Plan: 1) Enable AllowItemsOnHoldCheckoutSCO 2) Place a hold on an item 3) Attempt to check that item out to another patron 4) Note the checkout is blocked 5) Apply this patch 6) Restart all the things! 7) Attempt the checkout again 8) The checkout now succeeds! Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34708] Ability to modify an order line to increase quantity of ordered item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34708 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #7 from Caroline Cyr La Rose --- The manual only says we can edit orders, without specifying with or without items. So I won't change anything there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29855] Add a repeated subfield with a MARC modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29855 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34752] Use AV descriptions in display for sort1/sort2 in basket display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Bug 34752 depends on bug 34618, which changed state. Bug 34618 Summary: Add sort 1 and 2 fields to basket in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 Bug 28449 depends on bug 34618, which changed state. Bug 34618 Summary: Add sort 1 and 2 fields to basket in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34618] Add sort 1 and 2 fields to basket in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from Caroline Cyr La Rose --- Nothing to add to the manual. The table is already listed as being configurable and we don't list the specific columns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35779] Publisher label missing in Staff Interface and OPAC record detail view when using 264 tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35779 Esther Melander changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Esther Melander --- Yes, it was the indicators. Thanks Katrin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 David Nind changed: What|Removed |Added Text to go in the|This enables breaking large |This enables breaking large release notes|Elasticsearch or Open |Elasticsearch or Open |Search indexing requests|Search indexing requests |into smaller chunks (for|into smaller chunks (for |example, from batch |example, from batch |modifications). It adds a |modifications). It adds a |chunk_size configuration to |chunk_size configuration to |the elasticsearch section |the elasticsearch section |in koha-conf.xml (for |in koha-conf.xml (the |example:|default is 5,000: |2505000). So instead of sending a |e>). So instead of sending |single background request |a single background request |for indexing, which could |for indexing, which could |exceed the limits of the|exceed the limits of the |search server or take up|search server or take up |too many resources, this|too many resources, this |limits index update |limits index update |requests to a more |requests to a more |manageable size. |manageable size. | | |NOTE: |NOTE: |This doesn't change the |This doesn't change the |command line indexing |command line indexing |script, as this already |script, as this already |allows passing a commit |allows passing a commit |size defining how many |size defining how many |records to send.|records to send. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 David Nind changed: What|Removed |Added Text to go in the|This removes the ability to |This removes the ability to release notes|drag and drop the order of |drag and drop the order of |the bibliographic and |the bibliographic and |authorities search fields |authorities search fields |(Administration > Catalog > |(Administration > Catalog > |Search engine configuration |Search engine configuration |(Elasticsearch)). This was |(Elasticsearch)). This was |removed as it feature has |removed as the feature has |no effect on the search |no effect on the search |results when using |results when using |Elasticsearch or OpenSearch |Elasticsearch or OpenSearch |as the search engine. |as the search engine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35779] Publisher label missing in Staff Interface and OPAC record detail view when using 264 tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35779 --- Comment #1 from Katrin Fischer --- Hi Esther, did you set the indicators? The indicators determine which label is used for 264. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35779] New: Publisher label missing in Staff Interface and OPAC record detail view when using 264 tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35779 Bug ID: 35779 Summary: Publisher label missing in Staff Interface and OPAC record detail view when using 264 tag Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Created attachment 160891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160891=edit Missing publisher label in record detail view To Recreate: 1. Ensure the default framework is showing the 264 tag and fields 2. Find a record and ensure there is data in the 264 $a, $b, $c fields. 3. View the record and see the data from the fields are showing, but without a label. 4. View the record in the OPAC and see there is no label. If the 260 is used instead, the label is present. It should be present for the 264. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What|Removed |Added Attachment #160785|0 |1 is obsolete|| --- Comment #16 from Aleisha Amohia --- Created attachment 160890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160890=edit Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail When the 'RestrictPatronsWithFailedNotices' syspref is enabled then patrons with email and sms notices which failed sending (have a message_queue.status field of 'failed') have a restriction (debarment) applied to them. Test plan: 1. In the Koha staff client > Tools > Overdue notice/status triggers and create the 'First' rule for all patron categories as: Delay: 1 Letter: Overdue Notice SMS: ticked Ensure you have an SMS notice for the ODUE letter. 2. In the system preferences make sure you enter dummy data into the SMSSendUsername, SMSSendPassword and EmailSMSSendDriverFromAddress sysprefs 2. Find two non-debarred patrons and make sure they have invalid SMS numbers set. The SMS numbers must be INCORRECT, for example "123" as an SMS number. Leaving this field empty will result in the message_transport_type defaulting to 'print' instead of 'sms'. 3. Check one item out to each patron in step 2 4. Jump into the database and run the query: UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; 5. Go to misc/cronjobs directory and enter the Koha shell: sudo koha-shell 6. Run: ./overdue_notices.pl 7. Exit the shell and jump back into the database and run the query: SELECT message_transport_type, status FROM message_queue WHERE borrowernumber= OR borrowernumber=; 8. Confirm both new notice records have the message_transport_type is 'sms' and the status of 'pending' 9. Exit the database and re-enter the Koha shell and run the command: ./process_message_queue.pl 10. Jump back into the database re-run the query from step 7 and confirm the status is 'failed' for both 11. Also run the query: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice there is no added debarment to these two patrons 12. Apply patch, restart memcached and plack. In the installer/data/mysql directory enter the Koha shell and run the command: ./update_database.pl 13. In the Administration > Global System Preferences interface of the staff client notice there is a new system (set to "Don't" by default) named 'RestrictPatronsWithFailedNotices'. Enable it (i.e. select 'Do') 14. Create a new file in the /etc/cron.daily directory named koha-custom and add the following line to it: koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/restrict_patrons_with_failed_notices.pl 15. In the misc/cronjobs directory enter the Koha shell and run the command: ./restrict_patrons_with_failed_notices.pl 16. The script should output text saying: There are borrowers with failed SMS or email notices However because you haven't given the script the argument -c it won't apply debarments (restrictions) to any of the patrons with the failed SMS or email notices. 16. Query the borrower_debarments table: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice they still have no restriction 17. Now in the Koha shell run the command: ./restrict_patrons_with_failed_notices.pl -c 18. Notice the script outputs the text: There are borrowers with failed SMS or email notices Applying restriction to patron : ; 19. Repeat step 16 and notice both patrons now have 1 restriction each with the borrower_debarments.type=SUSPENSION and comment=SMSnumber invalid and expiration=NULL 20. Query the borrowers table: SELECT debarred, debarredcomment FROM borrowers WHERE borrowernumber= OR borrowernumber=; 21. Notice the values are: debarred= -12-31 debarredcomment= SMS number invalid 22. Repeat step 17 and notice the script outputs: There are borrowers with failed SMS or email notices Patron : is currently restricted due to having an invalid SMS number. No new restriction applied" 23. Repeat step 16 and notice no new debarment has been added to those borrowers as they have already been restricted from having a failed SMS notice. 24. In the Koha home directory run the command: prove t/db_dependent/Koha/Notices.t This unit test contains the tests for the new subroutines added to Koha/Notice/Message.pm which are restrict_patron_when_notice_fails() and get_failed_notices() 25. All tests should pass 26. Sign off Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org
[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35778] New: Patron Lists - Remove Multiple Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35778 Bug ID: 35778 Summary: Patron Lists - Remove Multiple Patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: rco...@arlingtonva.us QA Contact: testo...@bugs.koha-community.org Home > Tools > Patron Lists There is currently a way to "Add Multiple Patrons" by either Cardnumber or Borrowernumber, but there is no way to REMOVE multiple patrons in a group. It would be helpful to have this option added, so that the user doesn't need to find & click every individual patron that they want to remove from list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35777] New: Barcode label dimensions need unit of measure designation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35777 Bug ID: 35777 Summary: Barcode label dimensions need unit of measure designation Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In reference to the enhancement in Bug 10762 that allows for adjusting the dimensions of the barcode, it is not clear what units of measure are being used. The barcode dimension units need to match the units selected for the template. Some text to the right of the box would make it clear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24956] Add ability to define emergency/override circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19037] Circulation and fine rules test tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11456] Add validation to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11456 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #57 from Kyle M Hall --- Only "issue" is the use of Data/Datas instead of Datum/Data or something less confusing than Datum/Data. I don't consider this a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15521] Make circulation rules backend more granular
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18207] smart-rules.pl should validate that all branches / patron categories / item types are covered by circ rules.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18207 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #5 from Brendan Lawlor --- Somehow my test plan did not get attached to this patch. This is a work in progress patch that adds a new syntax to reports for multiselect similar to adding <> Currently the patch adds the syntax to the report allowing you to select multiple authorized values when you run the report. The multiselected values are passed as multiple url parameters, but those parameters will need to be parsed and formatted for the query to work. I think this part could be done using either javascript to override the default functionality of the multiselect to send a single parameter, or done in the perl somewhere. Test Plan: 1. Try writing a report with the new syntax ie. WHERE itemtype in (<>) 2. Save the report and notice there is an error 3. Apply patch 4. Write a report with the new syntax select * from items where itype in ( <> ) 5. Note the report now saves without error 6. Run the report 7. Note that you can now select multiple parameters in the dropdown 8. Click 'Run the report' 9. Note the report fails to run 10. Check the url to see the multiselected parameters are included TODO: Make the multi selected params insert into the SQL as a comma separated list of strings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #56 from Kyle M Hall --- Created attachment 160889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160889=edit Bug 35536: DO NOT PUSH !!! - Example plugin After applying patch, run: perl -MKoha::Plugins -e"Koha::Plugin->new->InstallPlugins" This installs the TestMR plugin. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #55 from Kyle M Hall --- Created attachment 160888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160888=edit Bug 35536: Remove last two references to resultset PluginData Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #54 from Kyle M Hall --- Created attachment 160887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160887=edit Bug 35536: Silence tests when run from koha-qa.pl Extending the regex in Plugins::_verbose. Test plan: Run qa tools on patch set. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #53 from Kyle M Hall --- Created attachment 160886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160886=edit Bug 35536: Refine verbose handling in some Koha::Plugins calls Three routines in Plugins got the verbose parameter on 35507. We can refine this a bit further. The idea here is report when you are installing plugins but not report when just calling plugins (flooding logs). [1] GetPlugins: Most callers do not expect (or check) results for failing plugins. This patch makes GetPlugins only return errors when passing the *errors* flag (in 2 cases). [a] The misc/devel script prints warnings now using verbose, so does not need the errors flag anymore. [b] plugins/plugins-home is the only case left. Tiny adjustment to keep current behavior. Fixed colspan in template. Does not need verbose in favor of 'errors' (passed to template). [c] For most calls we do not want verbose. New default is 0. [2] InstallPlugins [a] Disabled verbose in plugin-upload. Not really needed. Added a FIXME; we need to improve individual install. [b] misc/devel: No warnings anymore when calling InstallPlugins after GetPlugins. [3] get_enabled_plugins [a] Plugins->call does not need verbose. [b] Plugins->feature_enabled does not need it too. Test plan: [1] See previous plan. With TestMR data but without patch, run misc script and go to plugins-home. Do you see load errors on commandline or form? [2] Run plugins/plugins-upload (uploading just some file is good enough); verify that you do not see TestMR lines in logfile. [3] Run t/db_dependent/Koha/Plugins/Plugins.t for the additional test on verbose and errors flag. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #52 from Kyle M Hall --- Created attachment 160885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160885=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
--- Comment #51 from Kyle M Hall ---
Created attachment 160884
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160884=edit
Bug 35536: Add RemovePlugins calls in plugin unit tests
[1] Replace Methods->delete by RemovePlugins.
git grep -l "Plugins::Methods->delete" | xargs sed -i
-e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
might be better off with disable? Added a comment.
Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
Signed-off-by: Marcel de Rooy
Signed-off-by: Martin Renvoize
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #50 from Kyle M Hall --- Created attachment 160883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160883=edit Bug 35536: Add Koha::Plugins->RemovePlugins class method Test plan: Run t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 --- Comment #49 from Kyle M Hall --- Created attachment 160882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160882=edit Bug 35536: Add Koha object classes for plugin_data Test plan: Read the patch. The objects will be used in subsequent patches, and tested there. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Kyle M Hall changed: What|Removed |Added Attachment #160817|0 |1 is obsolete|| Attachment #160818|0 |1 is obsolete|| Attachment #160819|0 |1 is obsolete|| Attachment #160820|0 |1 is obsolete|| Attachment #160821|0 |1 is obsolete|| Attachment #160822|0 |1 is obsolete|| Attachment #160823|0 |1 is obsolete|| Attachment #160824|0 |1 is obsolete|| Attachment #160825|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall --- Created attachment 160881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160881=edit Bug 35536: Reorganize Plugins.t Move stuff in the middle into new subtest. Add transaction around second set of subtests. Test plan: t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 --- Comment #4 from Brendan Lawlor --- Created attachment 160880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160880=edit Bug 35746: add multiselect to report dropdowns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #20 from Martin Renvoize --- For consistency you're right, thanks for spotting it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35766] Allow staff to adjust privacy settings for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35766 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #1 from Esther Melander --- This is needed for homebound patrons, but also for others. There are many patrons that will never log in to their account for whatever reason but want to have the reading history enabled. The work around I have used is to ask the patron if I can log in to their account for them, which may require changing the password to do so. It may be helpful to add a note field/log to track changes to this setting and who did it. I like the idea of asking for confirmation via email, but it runs into the same problem of not-tech savvy patrons, patrons who do not know their email login or patrons with no email address. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 --- Comment #5 from Kyle M Hall --- (In reply to Martin Renvoize from comment #3) > Kyle.. I think we'll need an additional check in the plugin side to look for > whether the table has already been migrated prior to upgrade (i.e check that > the bookings table has booking_id vs bookingid column.) > > I'm also tempted to add a 'disable' call into here to disable the room > reservations plugin if found to ensure people go and upgrade it prior trying > to use it again. Sounds like a good plan to me! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Kyle M Hall changed: What|Removed |Added Attachment #160827|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 160879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160879=edit Bug 35473: Handle room reservations plugin conflict We now look for the existance of the room reservations 'bookings' table prior to attempting to install the core bookings table and migrate it in the same way the upstream plugin does before proceeding with installing the core bookings tables. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 Nick Clemens changed: What|Removed |Added Depends on||18139 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 [Bug 18139] 'Too many checked out' can confuse librarians -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Nick Clemens changed: What|Removed |Added Blocks||35776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 Nick Clemens changed: What|Removed |Added Depends on||30324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 [Bug 30324] Parent and child itemtype checkout limits not enforced as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Nick Clemens changed: What|Removed |Added Blocks||35776 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 --- Comment #2 from Nick Clemens --- Created attachment 160878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160878=edit Bug 30324: Don't use default rule if we have a parent rule Currenty, if we find only a defult rule for a checkout we are ignoring the parent rule. We should not use the default if there is a parent rule To test: 1: have an itype BK 2: create an itype BK2, set BK as the parent to BK2 3: create a circ rule for All Patrons, item type BK (displays as "Books (All)" in the circ rules interface), setting total checkouts to 1 4: do not create any rule specifically for the BK2 itype 5: have some BK items and some BK2 items 6: check a BK item out to a patron 7: check a BK2 item out to the same patron, observe you are not blocked from doing so 8: try to check out a second BK2 item to the same patron, get message "Too many checked out. 1 checked out, only 1 are allowed." 9: try to check out a second BK item to the same patrons, get message "Too many checked out. 2 checked out, only 1 are allowed." 10: return both items 11: check a BK2 item out to your patron 12: try to check a BK item out to your patron, get message "Too many checked out. 1 checked out, only 1 are allowed." 13: Apply patch 14: Repeat 7, you are now blocked 15: Other results should be the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 --- Comment #1 from Nick Clemens --- Created attachment 160877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160877=edit Bug 30324: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35776] New: Wrong circulation rule displayed when parent itemtypes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 Bug ID: 35776 Summary: Wrong circulation rule displayed when parent itemtypes are used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Follow the plans on bug 30324 - note the rule displayed is always the default rule. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35775] New: Modern Auth (OAuth 2.0) Support for SMTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35775 Bug ID: 35775 Summary: Modern Auth (OAuth 2.0) Support for SMTP Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: andrea...@gmail.com QA Contact: testo...@bugs.koha-community.org Deprecation of basic authentication in Exchange Online/Office365 for SMTP Auth. Looking for Modern Auth (OAuth 2.0) capabilities for SMTP to send out notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479
--- Comment #21 from Matt Blenkinsop ---
In the meantime, if any libraries / customers are struggling with this issue
then the code below can be added to IntranetUserJS. This will wipe the
selection history every time you navigate so it won't persist between patron
searches
$(document).ready(function() {
var patron_search_selections = [];
localStorage.setItem('patron_search_selections', JSON.stringify(
patron_search_selections ));
});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #41 from Marcel de Rooy --- Back to Assigned. Needs more attention still :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What|Removed |Added Blocks||35774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Lucas Gass changed: What|Removed |Added Depends on||33639 CC||jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 [Bug 33639] Adding item to item group from 'Add item' screen doesn't work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 --- Comment #10 from Martin Renvoize --- Can we be even clearer here somehow? i.e. should it be 'list_`something`_borrowers' (and whilst we're here can we swap out 'borrowers' for 'users' as it affect both borrowers and staff 'users'. The reason I add the 'something' in the middle is that I want it made clear this permission only allows the end api consumer to see the users they should be able to see (i.e. limited by library or library group depending on settings, vs the 'view_borrower_infos_from_any_library' option that expands that list significantly.. in theory at least) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35774] New: add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Bug ID: 35774 Summary: add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Opening this based on a comment in Bug 33639 446 add_item_to_item_group( $item->biblionumber, $item->biblioitemnumber, $item_group, $item_group_description ); Should it be $item->itemnumber instead of biblioitemnumber here as well? Looks like this should indeed be $item->itemnumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #19 from Lucas Gass --- (In reply to Jonathan Druart from comment #14) > 446 add_item_to_item_group( $item->biblionumber, > $item->biblioitemnumber, $item_group, $item_group_description ); > > Should it be $item->itemnumber instead of biblioitemnumber here as well? Even though this works as is, I think you're right. I will open a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 --- Comment #5 from Lucas Gass --- > Did you ask Nick? I did, we feel like this is leftover cruft from a previous iteration to item groups. Currently, the JS I removed doesn't work/do anything anyways. We think it should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 --- Comment #1 from Martin Renvoize --- Created attachment 160876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160876=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Martin Renvoize changed: What|Removed |Added Blocks|35773 | Depends on||35773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 [Bug 35773] Cannot create bookings without circulation permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize changed: What|Removed |Added Depends on|29509 | Blocks||29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Martin Renvoize changed: What|Removed |Added Blocks||35773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 [Bug 35773] Cannot create bookings without circulation permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize changed: What|Removed |Added Depends on||29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Blocks||35773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 [Bug 35773] Cannot create bookings without circulation permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] New: Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Bug ID: 35773 Summary: Cannot create bookings without circulation permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com, kyle.m.h...@gmail.com, n...@bywatersolutions.com, testo...@bugs.koha-community.org Depends on: 29002 When attempting to place a booking on an item in the catalogue a user needs several permissions: 1 - Patron search permissions (see bug 29509) [Any of "borrowers:edit_borrowers", "tools:label_creator", "serials:routing", "acquisition:order_manage"] 2 - circulate: manage_bookings 3 - circulate_ circulate_remaning_permissions If you don't have one of the first, the loading of patrons seems dies on looking up patrons via the api Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Martin Renvoize changed: What|Removed |Added Assignee|tomasco...@gmail.com|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Attachment #160866|0 |1 is obsolete|| --- Comment #40 from Matt Blenkinsop --- Created attachment 160875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160875=edit Bug 34355: Rebase changes made in bug 33170 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Attachment #160865|0 |1 is obsolete|| --- Comment #39 from Matt Blenkinsop --- Created attachment 160874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160874=edit Bug 34355: Add a plugin hook - before_orderline_create -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Attachment #160864|0 |1 is obsolete|| --- Comment #38 from Matt Blenkinsop --- Created attachment 160873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160873=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Attachment #160863|0 |1 is obsolete|| --- Comment #37 from Matt Blenkinsop --- Created attachment 160872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160872=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34355] Automated MARC record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop changed: What|Removed |Added Attachment #160862|0 |1 is obsolete|| --- Comment #36 from Matt Blenkinsop --- Created attachment 160871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160871=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
