[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #88 from Jonathan Druart  ---
Oops, just noticed you have opened bugs already! Marked bug 35846 and bug 35861
as duplicate!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35862] Display patron search result on the right of the form (modal)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #1 from Jonathan Druart  ---
*** Bug 35846 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35846] On wide screens, we should display the patron search results next to the filters rather than beneath

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35846

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jonathan.druart+koha@gmail.
   ||com
 Resolution|--- |DUPLICATE

--- Comment #1 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 35862 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35847] We should consistently display the select options when appropriate in the patron search modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35847

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
*** Bug 35861 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35861] Allow to add several patron at once when selecting patrons (from modals)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35861

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 35847 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854

--- Comment #2 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #1)
> Did editing the suggestion work for you? Because there is bug 34963.

I just tested with adding to the title or something like that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29587] Test mail option in SMTP servers

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587

Misbahullah Jan  changed:

   What|Removed |Added

 CC||misbahja...@yahoo.com

--- Comment #3 from Misbahullah Jan  ---
(In reply to vimal kumar from comment #0)
> Dear Developers,
> Here is a feature suggestion to Administration > SMTP servers.
> Test mail option helpful for users to try newly added SMTP server works or
> not.

hello sir,
sir i have a problem, i have been updated my trigger email with smtp server
password so now how i can cahnge please guide me thank you. koha 23.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35545] "additional" item

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545

--- Comment #14 from Igor A. Sychev  ---
How do I check EasyAnalytics?
If delete $9, the item "disappears".
$9 is created automatically when using
/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35870] Adding an edit_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870

--- Comment #1 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 161264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161264=edit
Bug 35870: Adding new subpermission edit_authorities

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35871] Adding a merge_delete_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871

--- Comment #1 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 161263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161263=edit
Bug 35871: Adding new subpermission merge_delete_authorities

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472

--- Comment #2 from David Roberts  ---
I can't see a great deal in the logs that is meaningful:

[2024/01/23 03:06:39] [WARN] item-level_itypes set but no itemtype set for item
(121386) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 979.


Template process failed: undef error - The method Koha::Serial::Item->serialseq
 is
not covered by tests!

Trace begun at /usr/share/koha/lib/Koha/Object.pm line 900
Koha::Object::AUTOLOAD('Koha::Serial::Item=HASH(0x5640d6589300)') called at
/usr   
 /share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-detail.tt line
1340
eval {...} at
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-de 
   tail.tt line
1340
eval {...} at
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-de 
   tail.tt line
1429
eval {...} at
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-de 
   tail.tt line
1183
Template::Provider::__ANON__('Template::Context=HASH(0x5640da2017b0)') called
at 
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 348
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x5640da2017b0)',
'items_tabl
e', 'HASH(0x5640db784748)', 'localize me!') called at
/usr/lib/x86_64-linux-gnu/ 
   perl5/5.32/Template/Context.pm line 409
Template::Context::include('Template::Context=HASH(0x5640da2017b0)',
'items_tabl
e', 'HASH(0x5640db784748)') called at
/usr/share/koha/opac/htdocs/opac-tmpl/boot 
   strap/en/modules/opac-detail.tt line 534
eval {...} at
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-de 
   tail.tt line 18
Template::Provider::__ANON__('Template::Context=HASH(0x5640da2017b0)') called
at 
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x5640db7180f0)',
'Template  
  ::Context=HASH(0x5640da2017b0)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/  
  Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x5640da2017b0)',
'Template::
Document=HASH(0x5640db7180f0)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/T 
   emplate/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 91
Template::Service::process('Template::Service=HASH(0x5640db9c2ce8)',
'/usr/share
/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-detail.tt',
'HASH(0x5640db 
   691e88)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template.pm
line 66
Template::process('Template=HASH(0x5640da4e43f8)',
'/usr/share/koha/opac/htdocs/  
  opac-tmpl/bootstrap/en/modules/opac-detail.tt',
'HASH(0x5640db691e88)', 'SCALAR(   
 0x5640d28a6088)') called at
/usr/share/koha/lib/C4/Templates.pm line 127
C4::Templates::output('C4::Templates=HASH(0x5640db9bff98)') called at
/usr/share 
   /koha/opac/cgi-bin/opac/opac-detail.pl line 1249
eval {...} at /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl line 2
CGI::Compile::ROOT::usr_share_koha_opac_cgi_2dbin_opac_opac_2ddetail_2epl::__ANO
   
N__('CGI::Compile=HASH(0x5640ce960da8)', '',
'/usr/share/koha/opac/cgi-bin/opac/
   

[Koha-bugs] [Bug 35871] Adding a merge_delete_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n
   |ity.org |et.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35871] New: Adding a merge_delete_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871

Bug ID: 35871
   Summary: Adding a merge_delete_authorities subpermission for
editauthorities
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wainuiwitikap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35870] Adding an edit_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n
   |ity.org |et.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35870] Adding an edit_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35870] New: Adding an edit_authorities subpermission for editauthorities

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870

Bug ID: 35870
   Summary: Adding an edit_authorities subpermission for
editauthorities
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wainuiwitikap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24977] Enable translations for authorised values (POC)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35869] New: Dismissing an OPAC message from SCO logs the user out

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35869

Bug ID: 35869
   Summary: Dismissing an OPAC message from SCO logs the user out
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate: 

1. Enable  WebBasedSelfCheck
2. Add an OPAC mesaage to a patron account
3. Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl )
4. Enter your credentials to login
5. See the OPAC message, click dismiss. 
6. Notice you are logged out at redirected to: (
http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #13 from David Cook  ---
(In reply to David Cook from comment #11)
> It looks like Koha::OAI::Client::Harvester is still missing unit tests
> though. I think that's going to be a QA blocker.

At a minimum, I think the code handling "$response->next" should be in separate
unit tested functions. 

(In theory, the other earlier code within the "new" constructor could probably
be moved into an "init" function as well. But that is harder to test since it
interacts with a real website. We could create a fake website but I think that
would be a bit above and beyond.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the display of
  release notes||authority terms in the OPAC
   ||for UNIMARC systems. The
   ||authority record number was
   ||displaying instead of the
   ||term, depending on the
   ||order of the $9 and $a
   ||subfields (example for a
   ||606 entry: if $a then $9,
   ||the authority number was
   ||displayed; if $9 then $a,
   ||the authority term was
   ||displayed).

--- Comment #16 from David Nind  ---
Thanks Andreas for the steps on how to reproduce the issue!

I have now tested and signed off using KTD (koha-testing-docker).

Updated test plan:
1. KTD startup: edit your .env file and change KOHA_MARC_FLAVOUR=unimarc
2. Start up KTD as normal: ktd pull and ktd up
3. Edit any record so that it has two 606 entries - NOTE: The order displayed
in the editor is important:
   - For record 560 ([Le ]Jardin des Henderson : roman [LIVR] / Hermary-Vieille
Catherine), remove the existing values in the 606 field
   - Add these values:
 606 _a écosystèmes
 _9 6410
 606 _9 6410
 _a écosystèmes
   NOTE: The sample data for UNIMARC records is very incomplete - you will need
to:
 1. Add data for the mandatory fields before you can save the record.
 2. Update the item(s) for the record so that any values with dropdown
lists have valid values (otherwise you will have errors in the OPAC when you
try to view the record).
4. View the record in the OPAC and staff interface:
   - OPAC: Subject - Topical Name: 6410 | écosystèmes 
   - Staff interface: Subject - Topical Name: écosystèmes | écosystèmes 
5. Apply the patch.
6. Restart everything.
7. View the record again in the OPAC and staff interface
   - OPAC: Subject - Topical Name: écosystèmes | écosystèmes
   - Staff interface: Subject - Topical Name: écosystèmes | écosystèmes
8. Experiment with changing the order and adding new terms - these should now
display correctly, irrespective of the $a and $9 order in the record.
9. Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #12 from David Cook  ---
Comment on attachment 160744
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160744
Bug 35659: OAI Harvester

Review of attachment 160744:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=35659=160744)
-

::: Koha/OAI/Client/Harvester.pm
@@ +127,5 @@
> +printlog("ListMetadataFormats failed");
> +};
> +
> +#my $response = $h->Identify;
> +#print "Repository supports protocol version ", $response->version, "\n";

Looks like some debugging code that needs to be removed here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #11 from David Cook  ---
I'm in my last week of holiday mode, so I should be more available for this in
the coming weeks.

Thanks Matthias for looking at that. I'll take another look soon at the QA
tools output another time.

It looks like Koha::OAI::Client::Harvester is still missing unit tests though.
I think that's going to be a QA blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539

David Nind  changed:

   What|Removed |Added

 Attachment #155604|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 161262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161262=edit
Bug 29539: UNIMARC: authority number in $9 displays for thesaurus controlled
fields instead of content of $a

When you try to dislpay a bibliographic record on unimarc that has subjects
linked with authorities then only the $9 is displayed as link instead of the
content of $a and it's subdivisions, if any.

To test:
1) You will need to have a bibliographic record with at least one subject
autority connected in unimarc framework.
2) View that record on OPAC on detail display. The subject will display as
a number ( $9 )  and you cannot see the text/term of the subject ( $a )
3) Apply patch
4) Repeat step 2
5) The subject display in a normal way based on content $a - or more subfields

Sponsored-by: National Library of Greece
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539

David Nind  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30623] Copy permissions from one user to another

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623

--- Comment #19 from David Cook  ---
(In reply to Katrin Fischer from comment #18)
> I agree that permission profiles are the ultimate solution we should have,
> but this seems like it's available "now" and would be really helpful. I know
> my coworkers would love it as we do a lot of staff user setup in terms of
> "same permissions as user x".

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #111 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #110)
> See bug 24977 comment 9, it was the last movement for this.
> 
> I am out however.

Does it mean we should follow this approach?
Would this benefit from putting some heads together at the hackfest?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35582] Advanced search languages should be listed with selected UI language descriptions shown first if available

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582

--- Comment #13 from Katrin Fischer  ---
(In reply to Lari Strand from comment #12)
> If I run the whole file through pertidy the qa tool is happy. There's 211
> dirty lines in the file according to qa tool before the commit. Don't know
> how many messy lines got "fixed" by perltidy, but the qa tool is happy if
> there's less of them than before the commit it seems. Isn't this a problem
> with the qa tool for falsely reporting my committed line as messy rather
> that it actually being a messy new line?

I think the truth is in the middle. If I tidy just the if-else block the tests
pass too.
The lines show as changed in the patch - I guess that's what triggers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30623] Copy permissions from one user to another

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623

--- Comment #18 from Katrin Fischer  ---
I agree that permission profiles are the ultimate solution we should have, but
this seems like it's available "now" and would be really helpful. I know my
coworkers would love it as we do a lot of staff user setup in terms of "same
permissions as user x".

If we haven't been able to identify a security concern until now, I don't think
this should be stuck in "In Discussion".

The only comment I have is that I'd relabel "settings" to "permissions": Copy
settings -> Copy permissions etc. Settings is a very general term, specific is
always good for translations and such :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

--- Comment #65 from Katrin Fischer  ---
(In reply to Emily Lamancusa from comment #64)
> I'll take a look at this early next week. I think I can get others from MCPL
> to test too - we have bibs with hundreds of items, and would definitely like
> to see performance improvements on that move forward!

Thanks Emily, that would be awesome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35662] Improper redirection to Advanced Editor when saving in Basic Editor, Save fails

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35662

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
I cannot recreate this on master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35867] Bug 33039 needs to be easier for librarians to use/understand

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867

--- Comment #2 from Katrin Fischer  ---
>Could these simply be options that a serial librarian could pick from a list? 
>I don't think we should assume that librarians are comfortable 
>writing/editing/testing template toolkit.

Something we need to solve as we are trying to deprecate the older syntax...
but I agree. We need to think about how to make this easier, at least by
documentation, but ideally also allow for easier testing and better editor
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||35868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35868
[Bug 35868] Warning sign for using a patron category that is limited to another
library has moved to other side of page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35868] New: Warning sign for using a patron category that is limited to another library has moved to other side of page

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35868

Bug ID: 35868
   Summary: Warning sign for using a patron category that is
limited to another library has moved to other side of
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 31422

Bug 31422 implemented a warning sign, when a patron has a patron category that
you are not allowed to set due to library limitations on the code. It should
appear right next to the field, but might appear on the other side of the page
now being easily missed.

To test:
* User's login branch and home library is: Centerville
* Patron category "B - Board" is limited to Franklin
* Create a new patron: Board doesn't show
* Edit an existing patron with another patron category: Board doesn't show
* Edit a patron with Board category from Centerville: Board appears in the list
of options but the nice little icon with the tooltip has moved all the way to
the right... 

Maybe another tiny side effect of the staff re-design?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422
[Bug 31422] Library limitations might cause data loss when editing patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35867] Bug 33039 needs to be easier for librarians to use/understand

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867

--- Comment #1 from Lucas Gass  ---
At the very least I think we need hints on serials/subscription-add.pl to aid
here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35867


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867
[Bug 35867] Bug 33039 needs to be easier for librarians to use/understand
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35867] Bug 33039 needs to be easier for librarians to use/understand

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867

Lucas Gass  changed:

   What|Removed |Added

 Depends on||33039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039
[Bug 33039] Add ability to specify a template for serial subscription
"Published on (text)" field
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748

--- Comment #29 from Katrin Fischer  ---
(In reply to Thibaud Guillot from comment #28)
> Hi Katrin,
> 
> Sorry for the delay in my reply. I've gone back over the code a bit,
> concerning the presence of the value if it's not the current value, I've
> taken a look at the form for modifying the categorycode of a borrower and
> the value, even if it's limited to a branch, does appear in the list...

That should not be the case. I quickly retested:
* My user's login branch and home library is: Centerville
* Patron category "B - Board" is limited to Franklin
* Create a new patron: Board doesn't show
* Edit an existing patron with another patron category: Board doesn't show
* Edit a patron with Board category: Board appears in the list of options (but
the nice little icon and text have moved all the way to the left... maybe with
the staff re-design. See bug 31422)

Another area where the "keep current" is implemented really nicely is funds. If
you receive an order with a fund you are not allowed to use for ordering, it
will still show up in the list on receive and be marked as "current". 

To see this, something like this should work:
* Create an order line with using fund X
* Set the fund to be limited by library
* set the fund to be owned by a library that is not yours
* Make sure your user is not superlibrarian and doesn't have budget_manage_all
* Receive the order...

> maybe it's a recent patch, I seemed to have seen a few things that dealt
> with this but I can't find them :/
> 
> Could we add the disabled attribute to the entry to display it all the same,
> or should we stick with "hidden"? 

One big motivation for libraries to use library limitations is 'shrinking the
list' for better usability. 
So yes, we do want to hide and only display what is absolutely necessary.


> On the other hand, I don't understand your sentence "It looks like the code
> doesn't take the 'false' AV like itemtype into account, but it should." I'm
> calling the original GetAuthorisedValues function with an extra parameter,
> but it didn't retrieve the basic itemtypes, so I'd like to ask you to
> clarify this.

I think maybe we could deal with this separately as it might be a different
part of the code?

What I meant is that when setting up the item form in the bibliographic
framework, you will set up the authorised values "itemtypes" and "branches" to
create the item type and home and holding branch pull downs. Re-thinking this,
we could deal with these separately I think - especially since only itemtypes
are 'library limitable'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35867] New: Bug 33039 needs to be easier for librarians to use/understand

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35867

Bug ID: 35867
   Summary: Bug 33039 needs to be easier for librarians to
use/understand
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 33039 introduced a new field 'Publication date template:' which is mapped
to subscription.published_on_template

This seems like it needs some work before it is useful to librarians:

1. No mention of it here:
https://schema.koha-community.org/master/tables/subscription.html
2. Publication date template requires Template Toolkit to get the desired
'publisheddatetext'. There should be some hints on what can be added here, and
what cannot. 

It appears like the following can be added:

subscription  => $subscription,
serialseq => $serialseq,
serialseq_x   => $subscription->lastvalue1(),
serialseq_y   => $subscription->lastvalue2(),
serialseq_z   => $subscription->lastvalue3(),28 
subscriptionid=> $subscriptionid,
biblionumber  => $biblionumber,
status=> $status,
planneddate   => $planneddate,
publisheddate => $publisheddate,
publisheddatetext => $publisheddatetext,
notes => $notes,
routingnotes  => $routingnotes,


Could these simply be options that a serial librarian could pick from a list? I
don't think we should assume that librarians are comfortable
writing/editing/testing template toolkit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

Katrin Fischer  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

--- Comment #10 from Katrin Fischer  ---
Trying to help untangle this, in hope of not making it worse :)

Problem: When all libraries owning a requested item are closed, we are not able
to allocate a hold.

Past:
In the past and without RTHoldsQueue the holdsqueue was rebuilt completely. As
a result, the unallocated holds would get allocated.

Present:
We now have RTHoldsQueue and try to avoid running the build_holdsqueue
additionally, so we need a way to deal with the unallocated holds without still
rebuilding the table regularly.

I think having a switch on the build_holdsqueue that does prevent it deleting
the table and makes it only add the so far unallocated would be OK.

What could be alternatives?
* Having a separate script: not ideal really as it would be too similar really.
* Have some other way of triggering re-allocation - I don't think we have an
option there apart from cron?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35866] New: Filter in parcels.pl only checks 20 first results

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35866

Bug ID: 35866
   Summary: Filter in parcels.pl only checks 20 first results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When a library has a lot of invoices for a vendor, the filter box at the top of
the invoice table only looks in the 20 first results. (The filter box on the
left side is OK.)

To recreate:
1. Go to Acquisitions
2. Search for a vendor
3. Click "Receive shipments"
4. If there are less than 21 invoices, create some until you have at least 21
   4.1. Fill out the "Vendor invoice" field
   4.2. Click Save
   4.3. Click "Back" in your browser
   4.4. Redo steps 4.1 to 4.3
5. In the filter box at the top of the table, search for an invoice number on
the second page of results
   --> No results
6. In the filter box on the left, search for an invoice number on the second
page of results
   --> Result found
   --> Also note that when the filter is not used, it says "XX shipments" at
the top of the page (mine says 36 shipments), but at the top and bottom of the
table it says "Showing 1 to 20 of 20 entries"

The filter box at the top of the table seems to be defective. Maybe we could
change the table to a datatable? On those types of tables, the filter box
searches in all the entries, and the entry count is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35865] Missing hint about permissions when adding managers to a basket

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35865] Missing hint about permissions when adding managers to a basket

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865

--- Comment #1 from Jonathan Druart  ---
Created attachment 161261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161261=edit
Bug 35865: Add missing hint about permissions when adding managers to a basket

When searching for managers for an acquisition basket, the list of patrons is
limited to patrons with the baskets_managers permission. For other patron
searches there is a hint about the restriction but it does not appears here.

Test plan;
Edit a basket, click "Add user" to select a manager.
Notice the hint about the permission.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35865] Missing hint about permissions when adding managers to a basket

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34355] Automated MARC record ordering process

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355

--- Comment #42 from Katrin Fischer  ---
Is the setup of the mentioned SFTP server something done in Koha or something
done outside? 
Are you expected to set it up on the Koha server itself? 
Maybe this works similar like picking up files for EDI?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #87 from Jonathan Druart  ---
> (In reply to Martin Renvoize from comment #83)
> > There's also a mismatch in the filter names.. 'baskets_managers' vs
> > 'orders_managers'.. I think this does need fixing before we go PQA... I had
> > a quick look and couldn't work out the logic flow here I'm afraid :(
> 
> I don't think so. However orders_managers is never used (neither on master)
> and we should investigate that.

Ok, opened bug 35865.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35865] New: Missing hint about permissions when adding managers to a basket

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865

Bug ID: 35865
   Summary: Missing hint about permissions when adding managers to
a basket
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When searching for managers for an acquisition basket, the list of patrons is
limited to patrons with the baskets_managers permission. For other patron
searches there is a hint about the restriction but it does not appears here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35825] User without edit_any_item permission gets "Edit item" and "Delete item" options on restricted item

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35825

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #86 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #58)
> Minor comment, I think the result of an action could be made more apparent..
> it's rather hidden away..

Added some styling on "Add styling to info and error", but could still be
improved I think.

> also, if re-opening the modal, the result of the
> last operation is still visible.

Yes, I didn't know if it would be considered a bug or not, and it was not
trivial to implement. Opened bug 35864 for discussion.

(In reply to Martin Renvoize from comment #59)
> Next comment.. could we perhaps put the results next to rather than under
> the filters form in the modal?
> 
> It feels odd to have so much whitespace in the modal and have the actual
> useful content almost hidden off screen.. widescreen aspect ratios are
> pretty common these days?

Good idea, but definitely for a separate bug. Opened bug 35862.

(In reply to Martin Renvoize from comment #63)
> We should have a message similar to that on the funds ownership search in
> the basket manager search.. we limit that search to users with particular
> permissions too.

Yes, this is a bug, fixed in "Fix filter vars scope".

(In reply to Martin Renvoize from comment #64)
> For consistency, I feel like whenever a search can be used to add to a list
> of patrons, we should expose the select boxes and add selected functionlity.
> I don't think this should be specifically limited to patron card creator
> batches.

No behavior changes here, but yes that could be nice. Opened bug 35861.

(In reply to Martin Renvoize from comment #83)
> There's also a mismatch in the filter names.. 'baskets_managers' vs
> 'orders_managers'.. I think this does need fixing before we go PQA... I had
> a quick look and couldn't work out the logic flow here I'm afraid :(

I don't think so. However orders_managers is never used (neither on master) and
we should investigate that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #85 from Jonathan Druart  ---
Created attachment 161260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161260=edit
Bug 35329: Add styling to info and error

There were 2 "class" attribute and the second was ignored.
This could still be improved, but then we should adjust the css from
staff-global, but won't be trivial to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #84 from Jonathan Druart  ---
Created attachment 161259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161259=edit
Bug 35329: Fix filter vars scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #5 from Katrin Fischer  ---
(In reply to Andreas Jonsson from comment #4)
> Replacing "prefetch" with "join" actually solves this problem.   Why are we
> using "prefetch"?  This is what the documentation has to say:
> 
> "Prefetch does a lot of deep magic. As such, it may not behave exactly as
> you might expect."

Tomas, can you maybe help with that question?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35338] Error in SQL syntax when upgrading to 22.06.00.084

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35338

--- Comment #2 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #1)
> From bug 32162
> 
> (In reply to Nick Clemens from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > What's the version of the DBMS, Nick?
> > 
> > Server version: 5.7.12 MySQL Community Server (GPL)
> 
> If this is a MySQL 5.7 thing, are we still supporting it?
> 
> See also bug 29805.

22.06... is an update to 22.11. 22.11 as the LTS is still maintained and will
be for a while.

We list these OS as supported on the requirements page in the wiki:

* Debian 12
* Debian 11
* Debian 10
* Ubuntu 22.04
* Ubuntu 20.04

So if 5.7 is in 20.04... we are still supporting it I guess?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35864


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35864
[Bug 35864] Should we clear patron search result when the modal is reopened?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35864] New: Should we clear patron search result when the modal is reopened?

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35864

Bug ID: 35864
   Summary: Should we clear patron search result when the modal is
reopened?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: In Discussion
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 35329

From bug 35329 comment 58. Should this considered a bug or a feature?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35625] Add support for system flag to additional fields

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625

--- Comment #14 from Katrin Fischer  ---
So this feels no like we are trying to implement something like inheritance in
the database. We have a "base" ticket table and we have an additional table for
any specifics. I think I get the idea now.

The idea is very similar to the illrequestattributes, more than to the
patron_attributes. The patron_attributes implement limited functionality for
workflows, while the illrequestattributes are the data storage for any
additional data a backend might need to function properly.

At the moment I believe we are thinking to unify the functionality of:
* OPAC problem reports
* Catalog concerns
* 

As always there is pros and cons to everything. The problems I see with
additional attributes in their key/value form are:
* No FK constraints on database level.
* No proper datatypes. We store everything as a varchar. This can complicate
validation and reporting.
* Ease of writing reports with all columns (libraries have repeatedly told me
they find it hard)

I think there is a use case here... but I am not totally persuaded yet that
it's strong enough for the examples given.

For the reasons mentioned above, I feel like at least biblio_id might be better
off as a column allowing for FK etc. and easy joining with other tables. And
logging it could be of some use for the problem reports too (a lot of
opac-pages are "biblio record" based (detail, isbd, marc, request,
article_request ...) and logging it could allow for interesting reporting)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35863] New: Title display in basket.pl in wrong order (part number and part name should be right after title)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35863

Bug ID: 35863
   Summary: Title display in basket.pl in wrong order (part number
and part name should be right after title)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 161258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161258=edit
MARC21 records with part name, part number, and series information

When displaying titles with series statement (490 in MARC21, or formerly 440)
in the acquisitions basket, they appear immediately after the title, before the
part number and part name. The part number and part name are part of the title,
they should come immediately after the title.

Also, if there is more than one series statement with volume information, it
shows like "series title 1 | series title 2 / volume 1 | volume 2". It looks
really strange.

I'm hoping this is a "me" problem, but I was able to recreate in KTD and in a
ByWater sandbox...

I attached a file of MARC21 records with information in 245$n, 245$p, 440$a,
440$v, 490$a, and 490$v. Sometimes both series at a time.

To recreate:
1. Create a basket in Acquisitions
   1.1. Go to Acquisitions
   1.2. Search for a vendor
   1.3. Click New > Basket
   1.4. Fill out the basket form
   1.5. Click Save

2. Add to the basket from new file
   2.1. Click Add to basket and choose From a new file
   2.2. Choose the attached sample file (or other MARC file that has part names
and part numbers)
   2.3. Click Upload file
   2.4. Click Stage for import
   2.5. (Wait for the staging to finish)
   2.6. Click Add staged files to basket
   2.7. Click Select all, and if necessary, choose funds
   2.8. Click Save
   --> In the basket view, the record information is displayed as (for example)

Notice test. / Collection 440; | Collection 490; / 440v. | 490v. 5, Perdue / by
Girard-Audet, Catherine,
- 9782896571390, Éditions Les Malins, 2012

Which is 

245$a / 400$a | 490$a / 440$v | 490$v 245$n 245$p by 100$a - 020$a, 260$b 260$c

or in db column names

biblio.title / biblio.seriestitle / biblioitems.volume biblio.part_number
biblio.part_name by biblio.author - biblioitems.isbn,
biblioitems.publishercode, biblio.copyrightdate


I think the series information should come after the part number and part name. 

And if possible group by series information if there is more than one (ie.
series title 1 volume 1 | series title 2 volume 2). But I understand if this is
not possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35862


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862
[Bug 35862] Display patron search result on the right of the form (modal)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35862] New: Display patron search result on the right of the form (modal)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862

Bug ID: 35862
   Summary: Display patron search result on the right of the form
(modal)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 35329

From bug 35329 comment 59

> Next comment.. could we perhaps put the results next to rather than under
> the filters form in the modal?
> 
> It feels odd to have so much whitespace in the modal and have the actual
> useful content almost hidden off screen.. widescreen aspect ratios are
> pretty common these days?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35861


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35861
[Bug 35861] Allow to add several patron at once when selecting patrons (from
modals)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35861] New: Allow to add several patron at once when selecting patrons (from modals)

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35861

Bug ID: 35861
   Summary: Allow to add several patron at once when selecting
patrons (from modals)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 35329

From bug 35329 comment 64
For consistency, whenever a search can be used to add to a list of patrons, we
should expose the select boxes and add selected functionality. It should not be
specifically limited to patron card creator batches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35172] Order receiving error

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172

--- Comment #5 from Katrin Fischer  ---
If you have entries in your biblio table without a matching entry in the
biblioitems table, that would be a serious data issue.

What else I could imagine is that your biblionumbers and biblioitemnumbers got
out of sync. Could you check if biblionumber = biblioitemnumber in your
biblioitems table? Most of the time that is the case as we have a 1:1
relationship, but through migration etc. things can get out of synch sometimes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35545] "additional" item

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545

Katrin Fischer  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35545] "additional" item

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35545

--- Comment #13 from Katrin Fischer  ---
My guess is for this to be a side effect of EasyAnalytics - maybe something
where the pref is not checked properly?
If you remove the $9, the item goes away? What is the meaning of $9 in your
461?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35744] Implement +strings for GET /patrons/:patron_id

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744

--- Comment #5 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #4)
> What pushed you toward the choice of using +strings here vs just an embed? 
> Whilst it does reduce a small amount of data down the line, the db queries
> will be the same I believe.. so I'm not sure what the decision making
> process was?

I had to pick one of the two options and choose this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35662] Improper redirection to Advanced Editor when saving in Basic Editor, Save fails

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35662

Todd Goatley  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

--- Comment #1 from Todd Goatley  ---
Orange County Law reports that they're experiencing this issue through the
biblonumber edit feature available in reports. The cataloger reports that it is
not consistent but consistent enough to be problematic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854

--- Comment #1 from Katrin Fischer  ---
I think the notices should only be sent when the status changes.

Did editing the suggestion work for you? Because there is bug 34963.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35646

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33039

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #22 from Nick Clemens  ---
*** Bug 31792 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31792] Serial Patterns: Customize to allow for both full date and enumeration

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31792

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 33039 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539

--- Comment #14 from Andreas Roussos  ---
(In reply to Thibault Keromnès from comment #12)
> Couldn't replicate either on a sandbox (display is ok whether it's 606$a and
> then 606$9 or 606$9 and then 606$a)
That's interesting, I actually replicated the problem today by setting
up a UNIMARC flavour instance on ByWater Solutions' sandbox server (on
the current master b54da05c73 and without applying George's patch).

As you can see here the first Topical subject does not display properly:
https://opac-abefore9.sandbox.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=53

The order of the relevant subfields in that biblio is as follows:
606 _a écosystèmes
_9 6410
606 _9 6410
_a écosystèmes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539

Andreas Roussos  changed:

   What|Removed |Added

Version|21.05   |master

--- Comment #13 from Andreas Roussos  ---
(In reply to David Nind from comment #11)
> I've changed the assignee.
Thanks, David.

> I couldn't replicate the issue on the current master (using the sample data
> in koha-testing-docker) - the topical terms for a record displayed correctly
> in the OPAC.
I just managed to replicate the issue using KTD. Since I already had a
MARC21 KTD container up and running on the current master b54da05c73
and didn't want to lose my bash history, I ran these commands to set it
up with the UNIMARC sample data and fix the Zebra index configuration:

reset_all unimarc
sed -i.safe 's/marc21/unimarc/g' \
 /etc/koha/sites/kohadev/zebra-authorities-dom.cfg \
 /etc/koha/sites/kohadev/zebra-biblios-dom.cfg
koha-rebuild-zebra -a -b -f -v kohadev

I then linked the same Topical Name subject with field 606 of a test
biblio twice, and changed the order of the subfields so that in the
first 606 the $9 would appear after the $a and in the second 606 the
$a would appear after the $9. In the OPAC details view for that biblio
I got exactly what Rafael describes in this Bug's Description.

> Is this for 21.05 only?
No, it manifests on the current master, too. I've changed the Version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

--- Comment #1 from Andrew Fuerste-Henry  ---
To me, use of a statistical patron implies that one is fairly certain that a
local use should be recorded, so we should record both a local use and a return
if an item is scanned to a statistical patron while previously checked out to
another patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #17 from Lucas Gass  ---
Filed Bug 35860 to continue the discussion. Setting this one back to FQA and
will have a patch soon!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Lucas Gass  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org,
   ||bwsdo...@gmail.com,
   ||emily.lamancusa@montgomeryc
   ||ountymd.gov,
   ||esther.melander@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35860


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860
[Bug 35860] Checking out an item that to stats patron that is already checked
out results in 2 entries in the stats table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Lucas Gass  changed:

   What|Removed |Added

 Depends on||35840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840
[Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn
and statistical patrons
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] New: Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Bug ID: 35860
   Summary: Checking out an item that to stats patron that is
already checked out results in 2 entries in the stats
table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

This arises from Bug 35840. 

Scenario: Checking out an item to the stats patron that is already checked out
to someone else. 

Should this be counted as return and a localuse in the statistics table, or
should it only record a return. 


OR should it be configurable per system?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35859] Add part_name and part_number to addorderiso2709.pl

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35859

--- Comment #1 from Caroline Cyr La Rose  ---
Note: part number must be displayed before the part name, right after the
title.

Like this:

title part_number part_name author (isbn)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35859] New: Add part_name and part_number to addorderiso2709.pl

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35859

Bug ID: 35859
   Summary: Add part_name and part_number to addorderiso2709.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 161257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161257=edit
MARC21 records that include 245$n and 245$p

When importing MARC records to add to an acquisitions basket, it would be nice
to see the part name and part number, especially when adding records from the
same series.

I provided a file of MARC21 records that include 245$n and 245$p.

To recreate:
1. Create a basket in Acquisitions
   1.1. Go to Acquisitions
   1.2. Search for a vendor
   1.3. Click New > Basket
   1.4. Fill out the basket form
   1.5. Click Save

2. Add to the bask from new file
   2.1. Click Add to basket and choose From a new file
   2.2. Choose the attached sample file (or other MARC file that has part names
and part numbers)
   2.3. Click Upload file
   2.4. Click Stage for import
   2.5. (Wait for the staging to finish)
   2.6. Click Add staged files to basket
   --> In this table, there is the title, author, and ISBN (in MARC21, 245$a,
100$a and 020$a). 

It would be nice to see the part number and part name here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #16 from Andrew Fuerste-Henry  ---
(In reply to Lucas Gass from comment #15)
> So maybe, in an effort to move this forward and stop the double counting of
> localuse, we keep current existing behavior and stop the double increment of
> localuse? That seems like the kind of thing that could be a problem and
> inflate stats. 
> 
> We could move the discussion about  localuse + return / just return to
> another bug?

This sounds like a good path to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/821
 Resolution|--- |FIXED
  Documentation||Caroline Cyr La Rose
contact||
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Needs documenting   |RESOLVED

--- Comment #13 from Caroline Cyr La Rose  ---
I only updated the screenshots in the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #15 from Lucas Gass  ---
So maybe, in an effort to move this forward and stop the double counting of
localuse, we keep current existing behavior and stop the double increment of
localuse? That seems like the kind of thing that could be a problem and inflate
stats. 

We could move the discussion about  localuse + return / just return to another
bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

--- Comment #14 from Martin Renvoize  ---
Just some scaffolding to show what I'm planning here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

--- Comment #13 from Martin Renvoize  ---
Created attachment 161256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161256=edit
Bug 29509: WIP - Start of DB and specification update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

Martin Renvoize  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35858] New: Local cover image doesn't display on initial load of OpacBrowseResults

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35858

Bug ID: 35858
   Summary: Local cover image doesn't display on initial load of
OpacBrowseResults
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate;

1. Enable OpacBrowseResults and OPACLocalCoverImages.
2. Add a local cover image for a record. 
3. Go to the OPAC detail page for that record and in the holdings table click
'Browse shelf'.
4. Notice the local cover image does not appear initially. 
5. Use the shelf browsers Previous/Next buttons to page away from the current
record and page back.
6. When you get back to your record after Previous/Next'ing away you will see
the local cover image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #14 from Andrew Fuerste-Henry  ---
I tend to agree with Emily's assumption: an item found to be already checked
out when scanned for a local use via statistical patron was likely returned by
one patron, not properly checked in, and then later used by another patron. In
that case, it would be correct to record both a return *and* a local use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836

Matthias Le Gac  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #13 from Emily Lamancusa  
---
(In reply to Lucas Gass from comment #9)

> Are you saying it should add 2 entries to the stats table if a checked out
> item is checked out to the stats patron? 1 for localuse and 1 for a return?
> Seems like it should be one or the other, not both.

That's a good question... At the very least, we shouldn't change the existing
behavior that a statistical patron records a localuse no matter what, imo,
because that's the primary purpose of a statistical patron.


For MCPL, I think we would want both - we use both pieces of data to track
library usage in different ways, and in this scenario, we would generally
assume that the item really was returned by one patron and later used locally
by another. (It's pretty common for items to get accidentally skipped when a
staff member is scanning a pile of returns, and get put back on the shelf
without actually getting checked in.)

But I'm sure there are other libraries that use those stats in very different
ways, and may have different opinions - I agree we need to get more input on
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #12 from Lucas Gass  ---
(In reply to Lucas Gass from comment #10)
> > Are you saying it should add 2 entries to the stats table if a checked out
> > item is checked out to the stats patron? 1 for localuse and 1 for a return?
> > Seems like it should be one or the other, not both.
> 
> Im 2nd guessing now. I'm thinking that if it actually does a return it
> should be logged as such but NOT logged as a localuse.

In this scenario a book had been checked out to a patron but for whatever
reason is left behind at the library. Staff finds it and checks it in. That
should count as a return and not local use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #40 from Andreas Roussos  ---
(In reply to Loïc from comment #38)
> Created attachment 161234 [details]
> Page with the bug
> 
> With Opera I have the same issue. 
> (For the size of the web page see the screenshot)
Hi, Loïc!

Thanks for your feedback, however I think the screenshot you provided
(attachment 161234) was uploaded in error? When I preview it,
I don't see anything Koha-related...

Also, please see my previous reply to Andrea about the need to run the
`yarn build` command to regenerate the OPAC CSS once you've applied the
patches from this Bug report. Can you confirm you performed this step?

If you do indeed face a problem when using Opera after all, let us know
of the specifics of your setup (O/S, Opera version, etc.) and we'll see
if more CSS wizardry is required for the Shelf browser to work properly
in that web browser.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||29509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509
[Bug 29509] GET /patrons* routes permissions excessive
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||30230


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230
[Bug 30230] Search for patrons in checkout should not require edit_borrowers
permission
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35850] Use template wrapper for tabs: Header search forms

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850

--- Comment #1 from Owen Leonard  ---
Created attachment 161252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161252=edit
Bug 35850: Use template wrapper for tabs: Header search forms

This patch updates search header includes so that the tabs use WRAPPER
to build markup.

To test, apply the patch and test at least one page which uses each
updated search include. Search header tabs should look correct and work
correctly.

- Acquisitions
  - Suggestions
- Administration
- Budgets and funds
- Cities
- Currencies
- Desks
- Patron categories
- System preferences
- Z39.50
- Advanced search
- Authorities
- Bibliographic detail page
- Cataloging home page
- Check in
- Check out
- Acquisitions -> Vendor -> Contracts
- ERM
- Staff interface home page
- Serials
- Tool -> Notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35850] Use template wrapper for tabs: Header search forms

2024-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >