[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

Jonathan Druart  changed:

   What|Removed |Added

Version|23.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

--- Comment #11 from Jonathan Druart  ---
Created attachment 162132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162132=edit
Bug 36034: Add test

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #162130|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  ---
Created attachment 162131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162131=edit
Bug 36034: (bug 34893 follow-up) fix capture of return values from checkpw

Adapt code to the change of return value type of checkpw
introduced in bug 34893

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36091] New: Spelling: Patron card number/cardnumber

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091

Bug ID: 36091
   Summary: Spelling: Patron card number/cardnumber
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Not sure which spelling is correct, but consistency is good. 

$ grep -rn "Patron cardnumber" *
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt:4:
   "[% t("Manager name") | html %]"[% sep | html %]"[% t("Patron
cardnumber") | html %]"[% sep | html %]"[% t("Patron name") | html %]"[% sep |
html %]"[% t("Transaction library") | html %]"[% sep | html %]"[%
t("Transaction date") | html %]"[% sep | html %]"[% t("Updated") | html %]"[%
sep | html %]"[% t("Transaction type") | html %]"[% sep |html %]"[% t("Notes")
| html %]"[% sep | html %]"[% t("Amount") | html %]"[% sep | html %]"[%
t("Title") | html %]"[% sep | html %]"[% t("Barcode") | html %]"[% sep | html
%]"[% t("Item type") | html %]"
grep:
misc/translator/po/.git/objects/pack/pack-b0a884343922aff65f857e780adda0f2bcc2203f.pack:
binary file matches
grep: misc/translator/po/.git/objects/pack/tmp_pack_O9fPOy: binary file matches
misc/release_notes/release_notes_20_05_00.html:1588:http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329;>[24329]
Patron cardnumber change times are lost during upgrade for bug 3820
misc/release_notes/release_notes_20_05_00.md:1194:-
[[24329]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329)
Patron cardnumber change times are lost during upgrade for bug 3820

$ grep -rn "Patron card number" *
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:172:
   Patron card number

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35637] Batch patrons modification - add "Preferred language for notices"

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35637

Apostolos Chouliarakis  changed:

   What|Removed |Added

 CC||choul...@anatolia.edu.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed records in output

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36090

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #7 from David Cook  ---
Also, can you define "crashes the system"? 

At the moment, I don't know that this one is "critical", because I haven't
heard of any systems crashing because of this.

Does the server hang because of the large result set? Is a 500 error thrown?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
(In reply to Andreas Jonsson from comment #0)
> The search filter for the table on the page acqui/parcel.pl generates the
> below api-request, which results in the below sql query.  Note how the LIMIT
> clause is applied to the sub-query, not the whole query.  For us, this
> specific query actually yielded a search result of in total over 171 000
> rows.

This particular query here does seem hypothetical rather than practical. 

The size of the query does make it difficult to boil down. It looks like your
vendor must have a large number of orders. In theory, that LIMIT 20 should
limit the results, but there are a lot of JOINs across different tables, so you
could end up with some unexpected results I suppose...

(In reply to Andreas Jonsson from comment #2)
> Do we have a plan to move away from DBIx?

No, Koha is in deep with DBIx. 

(In reply to Andreas Jonsson from comment #4)
> Replacing "prefetch" with "join" actually solves this problem.   Why are we
> using "prefetch"?  This is what the documentation has to say:
> 
> "Prefetch does a lot of deep magic. As such, it may not behave exactly as
> you might expect."
> 
> On the other hand, the documentation also says:
> 
> "...,  only the prefetch technique will deal sanely with fetching related
> objects over a has_many relation. "

Koha does some interesting generic handling of search queries that get
translated into DBIx queries. It might be that Koha is doing something wrong as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #9 from David Cook  ---
I can't reproduce this problem in master. Can you double-check your steps for
reproducing the problem?

It's working perfectly for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

--- Comment #9 from David Cook  ---
As Kyle said, code review shows the fix clearly. 

You can also see the difference in the "sessions" table after a logging both
before and after applying the patch. After applying the patch, the session data
looks correct and isn't full of serialized data from a Koha::Patron object. 

QA tools are happy. 

This one is a ticking timebomb for anyone running one of the versions that
contains bug 34893, so I think releasing this ASAP would be wise.

I don't know how to reproduce the "Too many nested open parens in regex;" error
thrown by YAML::XS::__qr_loader, but I imagine it's happening to people in the
wild as it's been happening to us in dev. 

Good job on reporting and fixing this one, Andreas. I didn't notice it in my
emails until I sent that listserv email where you commented. Not sure what
happened there...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

David Cook  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au
   |y.org   |
 CC||dc...@prosentient.com.au
   Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

David Cook  changed:

   What|Removed |Added

 Attachment #161926|0   |1
is obsolete||

--- Comment #8 from David Cook  ---
Created attachment 162130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162130=edit
Bug 36034: fix capture of return values from checkpw

Adapt code to the change of return value type of checkpw
introduced in bug 34893

Signed-off-by: Kyle M Hall 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

David Cook  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Attachment #161859|0   |1
is obsolete||

--- Comment #3 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 162129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162129=edit
Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff
interface
- also give the test user the "edit_catalogue" subpermission under the
"editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there is no option to "Delete
record"
- change the permissions of the test user to also have "delete_any_record"
subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there is now an option to
"Delete record"

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #5 from Emily Lamancusa  ---
I've gotten feedback from our staff about this as well - we also don't use the
cron for waiting holds, and it is common for staff to grant last-minute
extensions if a customer called and asked for one.

Incidentally, I also noticed an inconsistency the other day - the expiration
dates becomes un-editable on the expiration date of the hold, but holds don't
appear on the Holds Over tab until the day after the expiration date. Not sure
off the top of my head which way the cron goes, but those three things should
be consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35945] Expand OverduesBlockCirc to guarantees and guarantors

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35945

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #2 from Marie-Luce Laflamme  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Betsy  changed:

   What|Removed |Added

 CC||eapple...@law.utexas.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088

--- Comment #1 from Kyle M Hall  ---
Created attachment 162128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162128=edit
Bug 36088 - Remove useless code form opac-account-pay.pl

The script opac-account-pay.pl sums the selected accountlines, formats the
amount, pulls the currently active currency, and does nothing with any of this
data.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Note there is no change in behavior

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36088] New: Remove useless code form opac-account-pay.pl

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088

Bug ID: 36088
   Summary: Remove useless code form opac-account-pay.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The script opac-account-pay.pl sums the selected accountlines, formats the
amount, pulls the currently active currency, and does nothing with any of this
data.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063

--- Comment #8 from Lucas Gass  ---
(In reply to Owen Leonard from comment #7)
> In my system with custom test data I'm seeing a mismatch between the count
> on the home page and the number of holds returned by pendingreserves.pl. I
> see that there is a lot of extra filtering going on in that script, so I
> wonder if the simple 'Koha::Holds->search( found => undef )' is not counting
> too many holds.
> 
> The other issue I see is that pendingreserves.pl has a default date range
> which makes the user's experience of what the home page reports different
> from what they see on that page by default.
> 
> In my system the home page reports 59 pending holds, pendingreserves.pl
> reports zero holds by default, and with an all-inclusive date range returns
> 31 holds.
> 
> - I think the home page count should definitely use the same (non-date)
> limits, but should it also use the same date limits?
> - Alternatively, should we remove the default date limit on
> pendingreserves.pl?

Thanks Owen. You're right, there needs to be more filters. That makes me want
to move some of the logic from pendingreserves.pl into Koha/Holds.pm (
something like 'filter_by_holds_to_pull') so it can be reused on mainpage.pl
and covered by tests. I will work up a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36087] New: Editing dates of a booked items causes failure

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36087

Bug ID: 36087
   Summary: Editing dates of a booked items causes failure
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If an item is marked as 'bookable', and has been booked for a time frame.  If
this item's booking time frame is edited, a failure error appears on the modal.
 If the booking bar is adjusted to reflect different dates, this also causes a
failure. 
To reproduce:
1. Create an item as bookable
2. Book this item for a patron with the dates 2/14-2/29
3. Save
4. View the booking and edit this booking, changing the dates to 2/19-2/29
5. Receive a 'failure' error.
6. Attempt to change the dates with the booking bar within the calendar view to
the same 2/19-2/29
7. Receive a 'failure error'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36073] Add Holds Queue info to intranet-main page

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #7 from Brendan Lawlor  ---
Some notes to make testing autorenewals easier:

In circulation and fine rules
loan period: 3
renewal period: 3
No automatic renewal before: 3
Automatic renewal : yes

In system preferences
NoRenewalBeforePrecision: date

after checking out items run ./misc/cronjobs/automatic_renewals.pl to confirm
items would be renewed then run again with options -c -v before checking the
notices tab for the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #161469|0   |1
is obsolete||

--- Comment #6 from Brendan Lawlor  ---
Created attachment 162127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162127=edit
Bug 23296: Set patron branchcode when preparing non-digest version

To test:
1. APPLY PATCH
2. Set up circ rules to allow for auto renewals.
3. Set AutoRenewalNotices to 'according to message prefs'
4. Make a branch specific version of the the AUTO_RENEWAL notice.
5. Find a patron belonging to that branch and set the message prefs to allow
for a AUTO_RENEWAL. But no digest option!
6. Check some things out and make sure they are eligble for auto renewal.
7. Run the cron.
8. Make sure the patron gets the branch specific notice.
9. Delete the branch specific notice.
10. DO 6-7 again.
11. Make sure they now get the all library notice.

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

--- Comment #4 from Owen Leonard  ---
Created attachment 162126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162126=edit
Bug 35977: (follow-up) Perltidy whitespace fixes

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Owen Leonard  changed:

   What|Removed |Added

 Attachment #161928|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 162125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162125=edit
Bug 35977: Set holddatefrom default to today

This patch sets the holddatefrom date to today by default on the opac.

Signed-off-by: Barbara Johnson 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #162068|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 162124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162124=edit
Bug 36055: Simplify MARC21 Fast Add framework

This patch removes or hides a lot of unecessary fields from the
MARC21 Fast Add framework, notably subfields $6 and $8 which are
used only in advanced cataloging. Fast Add is meant to add an item
fast, while the patron is waiting, in order to check it out to them.
There is no need to enter details, only what is necessary to
identify and check out the item.

To test:
1. Go to Circulation > Fast cataloging
   --> Notice all the fields present
2. Fill out mandatory fields (000, 008, 245$a, 942$c)
3. Click 'Save'
   --> Notice all the item fields present
4. Apply patch and reset
5. Redo steps 1-3
   --> There should be a lot less fields

Signed-off-by: David Nind 
Signed-off-by: Esther 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #13 from Kyle M Hall  ---
(In reply to Andreas Jonsson from comment #11)
> I have created an RFC:
> https://wiki.koha-community.org/wiki/
> Optimize_holds_queue_building_using_the_Hungarian_Algorithm
> 
> The discussion is on whether the community thinks that this is a worthwhile
> solution or not.

I'm going to go out on a limb and say that this is absolutely worthwhile. If
anyone disagrees please let us know!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36044] Show ISBN number of purchase suggestions on the OPAC

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044

--- Comment #1 from Owen Leonard  ---
Created attachment 162123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162123=edit
Bug 36044: Show ISBN number of purchase suggestions on the OPAC

This patch adds output of ISBN in the table of purchase suggestions in
the OPAC.

The patch also adds some formatting markup to the output of suggestions
information to make it more compact, and corrects the label on the
suggestion titles so that they work to trigger the corresponding
checkbox.

To test, apply the patch and submit some suggestions. Include ISBN with
some requests.

Log in to the OPAC and view your suggestions. Confirm that the
information is displayed well, including ISBN.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36044] Show ISBN number of purchase suggestions on the OPAC

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36044] Show ISBN number of purchase suggestions on the OPAC

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36044] Show ISBN number of purchase suggestions on the OPAC

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044

Owen Leonard  changed:

   What|Removed |Added

Summary|Purchase suggestions on |Show ISBN number of
   |OPAC should show ISBN   |purchase suggestions on the
   |number  |OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36074] Make materials specified note easier to customize, part 2

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #162069|0   |1
is obsolete||

--- Comment #2 from Brendan Lawlor  ---
Created attachment 162122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162122=edit
Bug 36074: Add classes to materials specfied message on check in and checkout
when CircConfirmItemParts is on.

To test:
1. APPLY PATCH
2. Set CircConfirmItemParts to 'Require'.
3. Add a materials specified message to an item. ( 952$3 )
4. Add the following CSS to your IntranetUserCSS:

.mats_spec_label { color: white; background: purple;  }
.mats_spec_message { color: white; background: green; }

5. Checkout that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.
6. Check in that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36074] Make materials specified note easier to customize, part 2

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35170] Make long overdue item type options configurable in interface

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35170

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36086] New: Course reserve availability/status inaccurate

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36086

Bug ID: 36086
   Summary: Course reserve availability/status inaccurate
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1. Add several items to course reserves in a combination of statuses
(available, missing, lost, in transit, on hold)
2. Observe that all items in course-details.pl show as available. (Checked out
will show checked out, but transit, lost, and on hold all show 'Available')

Information is correct on item and bib details, but availability in course
reserves module is incorrect. Assuming problem is in master, confirmed same
behavior in 22.11 and 23.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390
[Bug 17390] Add REST API endpoint for Authorised Values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||34920


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920
[Bug 34920] ERM breaks if an ERM authorized value is missing a description
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32997] Add GET endpoint for listing authorised value categories

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390
[Bug 17390] Add REST API endpoint for Authorised Values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||32997


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997
[Bug 32997] Add GET endpoint for listing authorised value categories
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #18 from Martin Renvoize  ---
Actually.. there's a fair bit of additional functionality in this submission..
the other two bugs only implement listing functions and not add or edit.. so I
think this could be rebased/reworked a little and retitled for those cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #7 from Martin Renvoize  ---
I agree with this approach and am as such signing off.. all works nicely in
testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162037|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 162121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162121=edit
Bug 34920: Default to using av.value is av.description is falsy

Test plan:
1. Enable ERM module
2. Confirm that you can open the ERM module in the staff interface.
3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit
the 'Cancelled' authorized value by removing the description. Making this
change with any of the ERM authorized values will result in an error.
4. Go back to the ERM module and notice that there is an error. 'Something went
wrong: Error: Expected string - got null.'
5. Apply patch. Run yarn js:build. Repeat test plan

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162036|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 162120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162120=edit
Bug 34920: Make av description nullable in API spec

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 CC||jake.de...@ptfs-europe.com,
   ||ryan.henderson@ptfs-europe.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #8 from Martin Renvoize  ---
Simple, useful improvement. All works as expected, is resilient to mistakes and
QA scripts are happy.. Going for a straight PQA here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162115|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #161945|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

--- Comment #7 from Martin Renvoize  ---
Created attachment 162118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162118=edit
Bug 36051: (QA follow-up) Use IGNORE in INSERT

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

--- Comment #6 from Martin Renvoize  ---
Created attachment 162117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162117=edit
Bug 36051: (QA follow-up): Use yaml_preference

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

--- Comment #5 from Martin Renvoize  ---
Created attachment 162116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162116=edit
Bug 36051: Add option to specify SMS::Send driver parameters in a system
preference

If an SMS::Send driver ( such as Twilio ) requires additional parameters, those
parameters have to be placed in a yaml file named after the SMS::Send driver,
and the path to that file specified in the Koha conf file.

It would be good if we had the option to specify those parameters in a YAML
system preference instead. This would be less complicated and avoid requiring
an administrator to update that data from the backend.

Test Plan:
1) Set up an SMS::Send driver that requires additional options;
   a Twilio account meets these requirements and can be created for
   free. Set this up using the traditional file based system.
2) Verify you can send SMS messages
3) Move the contents of that file into the new system preference
   SMSSendAdditionalOptions
4) Verify you can still send SMS messages
5) Delete the file
6) Verify yet again you can still send SMS messages!

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Martin Renvoize  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

--- Comment #4 from Kyle M Hall  ---
Created attachment 162115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162115=edit
Bug 36051 (QA follow-up): Use yaml_preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051

--- Comment #3 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #2)
> Can we use C4::Context->yaml_preference here Kyle?

TIL! Can do!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893

--- Comment #52 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #51)
> Please see [Koha-devel] Session corruption in koha-testing-docker master
> 
> Seems related to this change.

This is bug 36034.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

Phil Ringnalda  changed:

   What|Removed |Added

 CC||janus...@gmail.com

--- Comment #11 from Phil Ringnalda  ---
*** Bug 36069 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36069] (bug 29990 follow-up) authority heading use in search results should work with ES as well

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36069

Phil Ringnalda  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Signed Off  |RESOLVED
 CC||p...@chetcolibrary.org

--- Comment #3 from Phil Ringnalda  ---
The patch in bug 33348 is another fix ahead, and just needs signoff and qa on
the unit test

*** This bug has been marked as a duplicate of bug 33348 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.03   |24.05.00,23.11.03,23.05.09
released in||

--- Comment #10 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com, m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35843] No such thing as Koha::Exceptions::Exception

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35843

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.03   |24.05.00,23.11.03,23.05.09
released in||
 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|36084   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35919] Add record sources CRUD

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919

--- Comment #18 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Tomás Cohen Arazi from comment #0)
> > This bug replaces bug 32607 (it will be closed) in order to make it easier
> > to track things.
> 
> Easier by hiding the history?...

- Some generalizations got dropped.
- Some generalizations were taken care of on separate bugs already in master.
- Some features were simplified to make this easier to match the client's MVP,
and future enhancements will be dealt with on follow-up bugs in which pertinent
discussions can take place in a better way.

I think that's the best way to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36085] New: Protected Status should come with a permission

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36085

Bug ID: 36085
   Summary: Protected Status should come with a permission
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

With the new enhancement, 26170, add protected status to patrons, this allows
any patron to be updated/edited to be a 'protected patron'.  Staff with 'edit
borrowers' permission will be able to update this status. I believe there
should be a permission to allow for this field to be updated/edited within
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893

--- Comment #51 from Jonathan Druart  ---
Please see [Koha-devel] Session corruption in koha-testing-docker master

Seems related to this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||36084

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23486] Date last seen should be set upon registration

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486

Inkeri Hakulinen  changed:

   What|Removed |Added

 CC||inkeri.hakulinen+bugz@helsi
   ||nki.fi

--- Comment #30 from Inkeri Hakulinen  ---
I think that Katrin's suggestion is good. It lets every library then decide, do
they want adding a patron to set a date to "lastseen" or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Kelly McElligott  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36083] Not able to create customizable areas to intranet home pages that are library specific

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #42 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #41)
> Right.. we're all rebased and QA scripts are passing.. 
> 
> However, not all tests are.. we need to account for the bad xml chars
> stuff.. whilst we wrap things in evals as part of the rebase.. the errors
> thrown aren't propagating properly yet so we're failing tests.
> 
> I also think we should merge Koha::Biblio->record and
> Koha::Biblio->metadata_record rather than having both.
> 
> Passing the ball to the next dev however.. it's time for me to clock off for
> the evening.

Thanks Martin for resurrecting this. It is a relief to see there's still hope
on stuff. I'll finish this once I'm back from this short time off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36083] New: Not able to create customizable areas to intranet home pages that are library specific

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083

Bug ID: 36083
   Summary: Not able to create customizable areas to intranet home
pages that are library specific
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When testing the enhancement coming in 23.11, bug 6419, it appears that
library-specific text does not display as it should with the HTML Customization
tool. 
Process to test:
1. Tools> HTML Customizations
2. Choose to create an entry in StaffAcquisitionsHome
3. Assign it to a specific library 
4. Add text and publication date. 
5. Save
6. Go to the Acquisitions Home page - logged into that library, no text
displays.

This enhancement does work if creating an entry for 'all libraries'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Kelly McElligott  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration form

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] New: OPACResultsSideBar not working with library specific message

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Bug ID: 36082
   Summary: OPACResultsSideBar not working with library specific
message
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

With the introduction in 23.11 moving the system preference,
OPACResultsSideBar, to the Tools> HTML customization, it does not appear to be
working with a library specific message.  When creating a OPACresultsidebar to
'all libraries', this message does appear.
Steps to reproduce:
1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library. 
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is
assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar
would appear.
8. No text.

Attempt to do this test plan, but creating a 'all libraries' entry will appear
in the OPAC as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||36081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36081
[Bug 36081] ArticleRequestsSupportedFormats not enforced server-side
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36081] New: ArticleRequestsSupportedFormats not enforced server-side

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36081

Bug ID: 36081
   Summary: ArticleRequestsSupportedFormats not enforced
server-side
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 20472

./opac-request-article.tt
// Initialize format(s)
var supported_formats = "[%
Koha.Preference('ArticleRequestsSupportedFormats') | $raw %]";
if( !supported_formats.match(/PHOTOCOPY/) )
$('#format option[value="PHOTOCOPY"]').remove();
if( !supported_formats.match(/SCAN/) )
$('#format option[value="SCAN"]').remove();


This is the only place we deal with ArticleRequestsSupportedFormats...


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472
[Bug 20472] Add digital scan as optional format to Article Requests
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22603] Move boilerplate into Koha::Cron class

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Martin Renvoize  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

--- Comment #36 from Martin Renvoize  ---
* Bug 26170 added protected patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26170] Add protected status for patrons

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22577

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26170

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22415] Koha::EDI should not use Log::Log4perl directly

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22415

--- Comment #1 from Martin Renvoize  ---
Still the case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
Bug 5334 depends on bug 22480, which changed state.

Bug 22480 Summary: itemtype/itype is used to join allot of tables, but often 
isn't defined as a key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22324] Might be nice to list forks

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22324

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |LATER

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21862] Outdated translation credits

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21862

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #2 from Martin Renvoize  ---
Not a priority in the slightest.. I do feel we should do more to respect those
continuing to work on Koha more however rather than continue to recognize early
contributors above all else. It leads to resentment when people aren't
recognised for the things they contribute.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21825] UNIMARC Authority subfields missing 'u'

2024-02-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21825

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >