[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #162132|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  ---
Created attachment 162529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162529=edit
Bug 36034: [22.05] Add test

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #32 from Andreas Roussos  ---
Created attachment 162528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162528=edit
Bug 35659: (follow-up) Better handling of accented characters

If you try to harvest bibliographic records from a UNIMARC OAI
repository (using oai_dc data format) in a MARC21 Koha instance
and run the OAI harvester script in verbose mode, you may get
lines similar to the following in the output:

no mapping found for [0xC9] at position 0 in Économie politique
g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line
308.
no mapping found for [0xC9] at position 0 in Église et société g0=ASCII_DEFAULT
g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308.

When looking at the imported records' biblio details page in
the OPAC, most words containing accented characters will not
appear correctly.

The fix is to apply Franck Theeten's solution from Bug 16488
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488#c24)
and modify the value of the MARC leader's 10th character
to 'a' in the XSLT that transforms the UNIMARC OAI records
into MARC21 XML. Then, the accented characters get imported
properly and the records appear correctly in the OPAC.

Test plan:

0) Without this patch, running the OAI harvesting script in
   verbose mode produces many warnings, and garbled characters
   appear in the OPAC biblio details page wherever accented
   characters are in use.

1) Apply this patch.

2) Re-run the OAI harvesting script in verbose + force mode
   (force mode is required to ignore record datestamps from
   previous runs):

   misc/cronjobs/harvest_oai.pl -v -r  -f

   This time there should be no warnings printed on your
   screen, and any characters with accents in the updated
   records should look OK in the OPAC.

Thanks-to: Franck Theeten 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

Andreas Roussos  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

--- Comment #31 from Andreas Roussos  ---
Just wanted to point out that I tried to harvest bibliographic
records from the first repository suggested in the Test plan
(http://staroai.theses.fr/OAIHandler, oai_dc data format) in a
MARC21 Koha instance (therefore using OAIDCtoMARC21XML.xsl to
transform the records prior to importing), and when I ran the
OAI harvester script in verbose mode I got many lines similar
to the following in the output:

no mapping found for [0xC9] at position 0 in Économie politique
g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line
308.
no mapping found for [0xC9] at position 0 in Église et société g0=ASCII_DEFAULT
g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308.

The script did actually finish and managed to add 91 records,
but I noticed that in the biblio details page in the OPAC some
(not all) words containing accented characters did not appear
correctly. I have uploaded a screenshot that illustrates this.

Upon further investigation, it looks like the script *does*
manage to populate database fields such as biblio.title and
biblio.abstract with the correctly accented characters, but
some MARC fields (such as 245 - Title, and 6xx - Subjects)
in the MARCXML representation in biblio_metadata.metadata
still contain weird characters wherever accents exist.

The fix is to apply Franck Theeten's solution from Bug 16488
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488#c24)
and modify the value of the MARC leader's 10th character
to 'a' in the XSLT. Then, the accented characters get imported
properly and the records appear correctly in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

--- Comment #30 from Andreas Roussos  ---
Created attachment 162527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162527=edit
Screenshot - Accented characters in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
Summary|We need selenium tests to   |We need tests to check for
   |check for 'cud-' operations |'cud-' operations in stable
   |in stable branches  |branches (pre-24.05)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] We need selenium tests to check for 'cud-' operations in stable branches

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

--- Comment #2 from Jonathan Druart  ---
Not necessarily selenium tests. We can grep 'cud-', it will be a good and easy
start.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Incorrect translation of Template Toolkit directive causes patron view error in ru-RU

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

--- Comment #6 from sergeinik  ---
The patch works. But, as soon as I update the language according to the last
point, the problem returns. This happened after the last update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #3 from Alex Buckley  ---
Patches written, test plans to come. 

Not ready for testing yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #2 from Alex Buckley  ---
Created attachment 162525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162525=edit
Bug 36188: Sort lists by items.dateaccessioned in the OPAC

WIP

Sponsored-By: The Treasury, New Zealand

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #1 from Alex Buckley  ---
Created attachment 162524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162524=edit
Bug 36188: Sort lists by items.dateaccessioned in the staff client

WIP

Sponsored-By: The Treasury, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] New: Allow to sort lists by items.dateaccessioned of item records

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

Bug ID: 36188
   Summary: Allow to sort lists by items.dateaccessioned of item
records
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Currently you can sort a list by 'Date added', but this is the date the record
was added to the list.

It would be nice if libraries could sort lists by the items.dateaccessioned of
linked items. 

A use case for this would be a 'New resources' list - where the library curates
a list of records including bib records who have linked items recently
purchased. The library would want the list to be sorted by
items.dateaccessioned descending i.e. newest first.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #5 from Victor Grousset/tuxayo  ---
It works :)

Also split commit to check that the new tests indeed need the implementation to
pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

--- Comment #4 from Victor Grousset/tuxayo  ---
Created attachment 162523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162523=edit
Bug 35963: (QA follow-up): tidy up code and fix exec permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #161812|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 162522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162522=edit
Bug 35963: Fix bundled items table ordering and filtering

Using the many-to-many relationship results in the table alias `me` to
be used for table `item_bundles` instead of the expected table `items`.
This causes ordering and filtering to fail for columns Callnumber and
Barcode.
Using Koha::Items->search does not have this problem.

This patch also disables ordering by status because it does not work
(error message is: "Cannot find Koha::Object class for return_claim'")

Test plan:
1. Create an item bundle
  
https://koha-community.org/manual/23.11/en/html/circulation.html#circulating-bundles
2. Add at least 2 items to this bundle
3. Verify that ordering/filtering by callnumber or barcode works
4. Run `prove t/db_dependent/api/v1/items/bundled_items.t`

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

--- Comment #2 from Victor Grousset/tuxayo  ---
Created attachment 162521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162521=edit
Bug 35963: Add tests

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules)

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959

--- Comment #25 from Victor Grousset/tuxayo  ---
I suspect I wasn't the only one that needed some guesswork to test this.
Because I'm going from oldest to newest bugs so I'm mostly doing stuff that has
been likely already looked at and skipped.

Might be also that refactoring and code cleanup isn't the most attractive
stuff.

Anyway, it's back on track again ^o^
cleanup++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27105] Add checkout notes from staff interface

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27105

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35597


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597
[Bug 35597] Purchase Suggestion changes aren't logged
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

Lucas Gass  changed:

   What|Removed |Added

 Depends on||36187


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187
[Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the
staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

--- Comment #2 from Lucas Gass  ---
Created attachment 162520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162520=edit
Bug 36187: Corrected set data.patron_id in select_suggestor()

To test:
1. Make a new suggestion in the staff interface and attempt to set the "Created
by" patron to someone other than the logged in user.
2. Submit the suggestion.
3. select suggestedby from suggestions where suggestionid = X; ( Where X is the
suggestionid )
4. The value is NULL
5. On suggestion/suggestion.pl the "Suggested by" column is blank.
6. APPLY PATCH
7. Try 1 - 3 again. This time the suggestedby should be correctly set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

--- Comment #1 from Lucas Gass  ---
In the select_suggester() function data.borrowernumber is incorrect. It should
be data.patron_id

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] New: Cannot set suggestedby when adding/editing a suggestion from the staff client

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Bug ID: 36187
   Summary: Cannot set suggestedby when adding/editing a
suggestion from the staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1. Make a new suggestion in the staff interface and attempt to set the "Created
by" patron to someone other than the logged in user.
2. Submit the suggestion.
3. select suggestedby from suggestions where suggestionid = X; ( Where X is the
suggestionid )
4. The value is NULL
5. On suggestion/suggestion.pl the "Suggested by" column is blank.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771

Katrin Fischer  changed:

   What|Removed |Added

 CC||cd...@sthelens.ac.uk

--- Comment #4 from Katrin Fischer  ---
*** Bug 36181 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36181] Allow additional tabs in overdue notice/status triggers

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36181

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
At the moment you can only send up to 3 overdue notices. 

Additional notices could maybe be created using the patron-emailer feature. It
allows to create additional notices from reports and notice templates and send
them out via a specific cron.

I am marking this as a duplicate of bug 12771. - I believe it's the same
requirement.

As this is more of a general question/support request, it would be better
suited for the mailing list - Bugzilla should only be used for enhancement
requests and bugs (errors) and you will reach a lot more readers there.
Alternatively the IRC chat is also a good place to ask questions like this.

*** This bug has been marked as a duplicate of bug 12771 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] We need selenium tests to check for 'cud-' operations in stable branches

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

Katrin Fischer  changed:

   What|Removed |Added

Summary|We need selenium tests to   |We need selenium tests to
   |check fro 'cud-' operations |check for 'cud-' operations
   |in stable branches  |in stable branches

--- Comment #1 from Katrin Fischer  ---
Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36094] svc/authentication needs adjustements

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36094

--- Comment #21 from David Cook  ---
(In reply to Jonathan Druart from comment #20)
> why not simply reject if the request_method ne "POST"?

Because the GET is used to obtain the CSRF in order to do the POST like I
describe in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36094#c14

If MarcEdit is trying to use the SVC API, they'll first do a GET against
svc/authentication to get the initial CSRF token and to check if they're
authenticated already (since the SVC API uses cookie auth). 

If they're not authenticated, then they POST to svc/authentication to login
using the CSRF token they got from the previous GET. 

They could then use the CSRF token they get back from the POST to do the next
operation. (In theory all the SVC endpoints should return a CSRF token in their
response headers, but I haven't gotten that far. I think you've mentioned
elsewhere that the primary concern is Koha's internal use of SVC API so fair
enough. But as Katrin mentions in Comment 2 we do need to think about external
users too, so I've still got it on my mind.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement converts   |This enhancement converts
  release notes|the edifact messages|the EDIFACT messages
   |display table to an api |display table to an API
   |driven asynchronous |driven asynchronous
   |datatable greatly improving |datatable greatly improving
   |the performance of that |the performance of that
   |page when large numbers of  |page when large numbers of
   |messages exist. |messages exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35434] Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434

Phan Tung Bui  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559

--- Comment #7 from Emily Lamancusa  ---
It looks like this is a regression (or the indirect result of one), and I think
I've tracked down how we got here, but I'm not familiar enough with flatpickr
to submit an alternate patch. Hopefully this will be helpful to someone who is:

1. We had a bug in the past, where a flatpickr with futuredate wouldn't display
the previously input date (e.g. the expiration date on an expired hold) if that
date was in the past. We fixed that in Bug 29241 and its follow-up, Bug 29500.

2. Bug 30718 (Use flatpickr's altInput option everywhere) caused a regression,
and the date field on an expired hold (or any other futuredate field with a
preexisting date in the past) would show as blank again.

3. Bug 34634 fixed the regression by removing the input field and simply
displaying the date if the hold was expired. However, some library staff are
accustomed to extending holds on or after the expiration date is reached, so
this less than ideal for those workflows.

Also, the regression caused by bug 30718 (presumably) still exists for all
other futuredate inputs, besides the holds page. So it would be ideal if we can
fix that underlying regression and allow editing of the dates on expired holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35434] Non-superlibrarians should not place holds in other libraries when IndependentBranches is enabled

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434

Phan Tung Bui  changed:

   What|Removed |Added

 CC||phan-tung@inlibro.com

--- Comment #8 from Phan Tung Bui  ---
Here comes the updated version of plan test :

TEST PLAN
1) Appy the patch.
2) In 'Koha administration > System preferences' : 
- set 'IndependentBranches' to 'yes'
- set 'IndependentBranchesPatronModifications' to 'yes'
- set 'IndependentBranchesTransfers' to 'yes'
- set 'canreservefromotherbranches' to 'Don't allow'
3) In 'Koha administration > Circulation and fines rules', add a rule by only
clicking the 'Save' button (this will create a circulation rule for all patron
categories and all item types, allowing unlimited holds).
4) Create a staff patron (with username and password).
---> In 'Patrons > + New patron > Staff', fill the required fields, add a
username and password.
---> Remember the home library.
---> Click the 'Save' button.
5) Add permissions to the created patron.
---> In the patron detail page, click on 'More > Set permissions' and check
the following boxes:
- Staff access, allows viewing of catalogue in staff interface
- Add, modify and view patron information
- Place and modify holds for patrons
---> Click the 'Save' button.
6) Create an other patron of any patron category with the same home library as
the staff patron you created.
7) Create a record with one item.
---> In 'Cataloging > + New record', fill the required fields.
---> Click the 'Save' button.
---> You should now be in the item form. Fill the required field (home
library and current library should be the same as the patron's home library).
---> Click the 'Add item' button.
8) On the record details page, click 'Place hold' and search for the patron you
created in step 6.
---> In the 'Pickup at' field, you should see all the libraries.
---> In the 'Allowed pickup locations' column of the item, you should see
the same.
9) Log out from the staff interface and login with the staff patron you
created.
10) Click 'Search catalog' from the search bar and search for the record you
created.
11) On the record details page, click 'Place hold', then search for the patron
in step 6.
---> In the 'Pickup at' field, you should only see the home library of the
item.
---> In the 'Allowed pickup locations' column of the item, you should see
the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

--- Comment #3 from Katrin Fischer  ---
[comment not intended as a blocker]

Hi Pedro, 

I wonder if it would make sense to resolve the ID to the vendor's name. Could
be a separate bug.

To explain:
Libraries not using the acq module like to write a vendor name in the field in
the cataloguing editor as there is no plugin or similar to search for a vendor
to create a proper link (there is a bug for that somewhere...)
For libraries using the acq module, Koha adds the booksellerid of the vendor
automatically in the acquisition process. 
Some libraries will have a mix of both (retro-cataloguing, migrated data,
donations, etc.)

If we have the ID, we won't resolve to the vendor name with this patch and
there is no easy way for the library to figure out the actual vendor. We
neither allow searching by booksellerid, nor do we display the ID on the
vendor's detail page. You can only see it in the URL.

I see that the items tab in the staff interface (moredetails.pl) uses this
code:

if ($item_info->{'basketno'}){
my $basket = GetBasket($item_info->{'basketno'});
my $bookseller = Koha::Acquisition::Booksellers->find(
$basket->{booksellerid} );
$item_info->{'vendor'} = $bookseller->name;
}

So if an order for the item exists, it gets resolved to the name, otherwise it
remains as is. 

Also something that could probably be improved on. But re-using the logic would
give us a consistent display/behavior between items tab and holdings table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Lucas Gass  ---
Matthias,

Can you update sysprefs.sql to include the new system preferences? You also
need to use INSERT IGNORE INTO in your database update. 

Also, perltidy :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Lucas Gass  changed:

   What|Removed |Added

 Attachment #162515|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 162519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162519=edit
Bug 36182: Add booksellerid column to holdings table

1) Apply patch, reset_all
2) Configure holdings_table, visit:
/cgi-bin/koha/admin/columns_settings.pl?module=catalogue=detail=holdings_table
3) Confirm holdings_booksellerid is there and is hidden by default
4) Visit a record:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
5) Edit one of the items and add a value to field 'e' Source of acquisition
6) Go back to the record and click on the 'Columns' above the table
7) Click 'Source of acquisition'. Confirm it shows as expected

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36140] Wrong for attribute on Invoice number: label in invoice.tt

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36140

Lucas Gass  changed:

   What|Removed |Added

 Attachment #162311|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 162518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162518=edit
Bug 36140: Correct label for attribute invoice.tt

To test:
1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X  where X is the invoice
number.
2. Look at the Invoice number with your dev tools, the for attribute is wrong.
( shippingdate )
3. Apply patch and look again, the attribute should correctly be invoicenumber.

Alternatively, just look at the diff of this trivial change. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36140] Wrong for attribute on Invoice number: label in invoice.tt

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36140

Lucas Gass  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31572] E-mail and SMS verification

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572

--- Comment #3 from Christopher Brannon  ---
So, I've done a little research.  There are several email verification APIs out
there.  One I've been looking at is
https://verifalia.com/email-verification-api.  You can sign up for free and
test up to 25 emails a day for free.  That is great for testing the api, and
then you can pay to use the validator for day-to-day operations.  It would be
great if we had a plugin that would allow you to use these api's. 
Unfortunately, I can't just throw this in the patron edit form via jquery
because of the script involved, but one of our keen developers out there might
be able to come up with something.

This particular api, if incorporated into the patron edit form properly, would
check the email addresses entered into any valid email field on the form.  If
the email address doesn't have any issues, it will allow you to save the form.

This would be fantastic!  I would love to be able to test this, but someone
would have to come up with a way of adding to Koha for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35981] Add authorized values for Relator Terms

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35981

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add authorized values for   |Add authorized values for
   |Relator Codes   |Relator Terms
Version|23.11   |master

--- Comment #1 from Katrin Fischer  ---
(In reply to Esther Melander from comment #0)
> Bug 34677 updates the relator terms and codes list. There are authorized
> values for Relator Terms but not for Relator Codes. This should be separated
> out so that the codes can be selected for $4, which is more correct for that
> subfield. While it is possible for a user to add authorized values for
> Relator Codes, it would be nice if they were included.

I think this is not quite right:

RELTERMS AV category has the authorised values for the codes, not the terms. 

What happens is that we resolve the code in the MARC record to the term when
the XSLT is parsed for display automatically. So you see the description when
looking at it in Koha, but when you export the record, it has the code. So we
have $4, but are missing values for $e maybe?

I wonder if using AV codes is the best way here. Maybe we should have a
cataloguing plugin that automatically populates the other subfield depending on
the value chosen?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36186] New: Add the table on opac-topissues.pl (#topissuest ) to table settings

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36186

Bug ID: 36186
   Summary: Add the table on opac-topissues.pl (#topissuest ) to
table settings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice if you could control which columns show on opac-topissues.pl
via Table settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36185] New: Add option to enforce time limit on suspended holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36185

Bug ID: 36185
   Summary: Add option to enforce time limit on suspended holds
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: kkrue...@cuyahogalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently when you suspend a hold in Koha, you have the choice of adding a
suspend until date. If the date is left blank the hold is suspended
indefinitely, even if DefaultHoldExpiration system preferences are configured. 

When the hold is unsuspended after the hold expiration date, it is canceled. 

Being able to limit the amount of time a hold can be suspended would make the
holds timeline clearer to patrons. It would also make determining how many
copies are needed to fill holds. 

This could take the form of a system preference that adds the date limitation
into the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724

--- Comment #16 from Alex Buckley  ---
(In reply to Martin Renvoize from comment #15)
> Sensible defaults in place, unit tests passing, QA scripts happy.
> 
> I'm going to PQA on this as one of the few people here that understand EDI. 
> Thanks for the patch Alex.

Thanks Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753

--- Comment #7 from Laura Escamilla  ---
Created attachment 162517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162517=edit
Bug 27753: Added two new system preferences for automatically resolving claims.

NOT READY FOR TESTING

Current status: ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36184] New: Receiving individual items in Preservation Module is unclear

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36184

Bug ID: 36184
   Summary: Receiving individual items in Preservation Module is
unclear
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Preservation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.druart+k...@gmail.com

After creating a train with items, closing, and sending, receiving the items
back is confusing. The table allows you to select an individual item but it is
not clear what, if anything, happens. An item can be selected but the only
option is to close the train once selected. It appears that a "train" can be
received, but not individual items within the train. It would be nice to be
able to receive individual items within a train.

Much of this depends on the processing and workflow created. I can see groups
of items being sent and individual items being received back one at a time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36183] New: Add item barcodes to staff search results page

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36183

Bug ID: 36183
   Summary: Add item barcodes to staff search results page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Several libraries have requested that the item barcode be added to the staff
results page. While I can see the benefit to this, I am unsure how to make it
happen. 

Currently Koha "groups" items by there availability and then by holding branch,
location, itype, and ccode.

C4/Search.pm
1854 ( $item->{$hbranch} ? $item->{$hbranch} . '--' : q{} )
1855   . ( $item->{location} ? $item->{location} : q{} )
1856   . ( $item->{itype}? $item->{itype}: q{} )
1857   . ( $item->{ccode}? $item->{ccode}: q{} )

I don't quite know how to "group" something like barcode which would be unique
for every single item. 

Maybe it gets added in a separate display/column?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12907] MARC21 relator codes and terms: Display relator term ($e) instead of relator code ($4)

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12907

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #1 from Esther Melander  ---
Bug 35981 is about adding relator codes as authorized values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Incorrect translation of Template Toolkit directive causes patron view error in ru-RU

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

--- Comment #5 from Owen Leonard  ---
Created attachment 162516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162516=edit
Bug 36171: Use FILTER collapse instead of tilde in address includes

A couple of our include files used for displaying addresses have "~"
added to every template directive in order to collapse whitespace in the
generated HTML. This seems to cause problems for the translation script
which was picking up the "SET" in "[% SET foo = 'bar' %].

This patch modifies the affected files and related files (for
consistency) to use '[% FILTER collapse %]'. This seems to fix the
problem.

Note: This patch makes indentation changes, so ignore whitespace when
viewing the diff.

To test, apply the patch and search for a patron in the staff interface.

- View the patron detail page. All addresses, including alternate
  address and alternative contact address, should be displayed
  correctly.
- Edit the patron and confirm that the forms for entering those
  addresses also look correct.
- Go to Administration -> System preferences and test using other
  options for the "AddressFormat" preference.

- In the OPAC, view the "Libraries" page. Confirm that addresses are
  displayed correctly.

- Rebuild the ru-RU templates to confirm that there is no error:
> perl misc/translator/translate update ru-RU
> perl misc/translator/translate install ru-RU
   - Enable the language, if necessary, by updating the "language" and
 "OPACLanguage" system preferences.
   - Repeat the testing steps above.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Incorrect translation of Template Toolkit directive causes patron view error in ru-RU

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Pedro Amorim  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
   |ity.org |m
   Keywords||Sandbox
   Patch complexity|--- |Trivial patch
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Pedro Amorim  changed:

   What|Removed |Added

 CC||bernard.scaife@ptfs-europe.
   ||com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

--- Comment #1 from Pedro Amorim  ---
Created attachment 162515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162515=edit
Bug 36182: Add booksellerid column to holdings table

1) Apply patch, reset_all
2) Configure holdings_table, visit:
/cgi-bin/koha/admin/columns_settings.pl?module=catalogue=detail=holdings_table
3) Confirm holdings_booksellerid is there and is hidden by default
4) Visit a record:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
5) Edit one of the items and add a value to field 'e' Source of acquisition
6) Go back to the record and click on the 'Columns' above the table
7) Click 'Source of acquisition'. Confirm it shows as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] New: Add booksellerid column to holdings table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Bug ID: 36182
   Summary: Add booksellerid column to holdings table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Incorrect translation of Template Toolkit directive causes patron view error in ru-RU

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Incorrect translation of Template Toolkit directive causes patron view error in ru-RU

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

Owen Leonard  changed:

   What|Removed |Added

  Component|System Administration   |I18N/L10N
Version|23.11   |master
 OS|Linux   |All
Summary|Problems with the Russian   |Incorrect translation of
   |program interface   |Template Toolkit directive
   ||causes patron view error in
   ||ru-RU
   Hardware|HP  |All
 CC||frede...@tamil.fr,
   ||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Problems with the Russian program interface

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

--- Comment #4 from Owen Leonard  ---
(In reply to Owen Leonard from comment #3)
> It looks like the same problem is in display-library-address.inc.

I should have pointed out that this include is in the OPAC, not the staff
interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35398] EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|Failed QA   |Passed QA

--- Comment #10 from Katrin Fischer  ---
I asked and as it's a bug fix, I am open to make an exception here.

I cannot really test EDI unless I am provided with data and a detailed test
plan. I think it's similar for others, so we might rely more on code review
here than elsewhere. I think in the long term unit tests would be really
helpful to avoid breaking things and make us more confident about making
changes. I know EDIFACT is a critical feature for a lot of libraries.

As you know, pushing might still take a bit for reasons, but I'll switch back
to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Problems with the Russian program interface

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

--- Comment #3 from Owen Leonard  ---
Template process failed: file error - parse error -
member-display-address-style.inc line 1: unexpected token (line_break)
  [% КОМПЛЕКТ line_break = "" %] at /kohadevbox/koha/C4/Templates.pm line
134

It looks like a template directive is being picked up for translation. This is
the line from the English language template:

[%~ SET line_break = "" ~%]

A temporary fix would be to edit the affected file,
member-display-address-style.inc, to replace "КОМПЛЕКТ" with "SET"

It looks like the same problem is in display-library-address.inc.

The real fix will require that we figure out why the translation script is
picking that line up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36181] New: Allow additional tabs in overdue notice/status triggers

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36181

Bug ID: 36181
   Summary: Allow additional tabs in overdue notice/status
triggers
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cd...@sthelens.ac.uk
QA Contact: testo...@bugs.koha-community.org

Investigating possibility of sending recurring overdue notices.  Are additional
tabs available to access, beyond first, second, third?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36180] New: Add holds confirmation screen following user placing hold on an item

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36180

Bug ID: 36180
   Summary: Add holds confirmation screen following user placing
hold on an item
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cd...@sthelens.ac.uk
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

At user request, development of screen displaying holds confirmation message
would be appreciated following hold placed on item(s) via OPAC

The jump from the holds screen directly to the holds area of the user account
doesn't provide the necessary reassurance that the hold has successfully been
placed.

Ability to self-customise this to allow appropriate wording (such as 'an email
will be sent to you when the item is ready for collection') would also be a
great feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36179] "Quick add" patron form should be a modal

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36179

--- Comment #1 from Pedro Amorim  ---
Created attachment 162514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162514=edit
Bug 36179: patron quick add wip

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36179] New: "Quick add" patron form should be a modal

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36179

Bug ID: 36179
   Summary: "Quick add" patron form should be a modal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Hackfest
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: pedro.amo...@ptfs-europe.com
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com,
martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162504|0   |1
is obsolete||

--- Comment #9 from Pedro Amorim  ---
Created attachment 162513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162513=edit
Bug 36103: Remove the "Cancel hold" link for item level holds

This link is broken and doesn't make sense from a UI/UX perspective
and thus should be removed.

Signed-off-by: Owen Leonard 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Pedro Amorim  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34355] Automated MARC record ordering process

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355

Jessie Zairo  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
   ||,
   ||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Owen Leonard  changed:

   What|Removed |Added

 Attachment #162502|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 162504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162504=edit
Bug 36103: Remove the "Cancel hold" link for item level holds

This link is broken and doesn't make sense from a UI/UX perspective
and thus should be removed.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #2 from Liz Rea  ---
Mike Griffin at Rackspace was the originator of this suggested change. :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

--- Comment #1 from Kyle M Hall  ---
Created attachment 162503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162503=edit
Bug 36178: Add index for status on message queue table

For large libraries, the query to gather pending notices from the message queue
can take a very long time. ByWater's Rackpace DBA Mike was kind enough to do
some work on this for us and found the issue. He recommends adding a simple
index on the status column to fix this issue.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) SHOW CREATE TABLE message_queue
   should show the new index via koha-mysql

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32778] Auto-unsuspended holds do not trigger realt-ime holds queue update

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32778

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
An easy fix for this is to add a single forced run of the holds queue to the
early morning hours after the auto-unsuspend job runs, to force these onto the
list.

We should add that to our default cron.daily/koha-common cron definition.

And also fix the unsuspend job to tickle the real time hold queue. Just belt
and bracers.


Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36177] We need selenium tests to cover csrf checks

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |critical
 CC||jonathan.druart+koha@gmail.
   ||com
   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36178] New: Add index for status on message queue table

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178

Bug ID: 36178
   Summary: Add index for status on message queue table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

For large libraries, the query to gather pending notices from the message queue
can take a very long time. ByWater's Rackpace DBA Mike was kind enough to do
some work on this for us and found the issue. He recommends adding a simple
index on the status column to fix this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36177] We need selenium tests to cover csrf checks

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177

Nick Clemens  changed:

   What|Removed |Added

 Depends on||36148

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36177] New: We need selenium tests to cover csrf checks

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177

Bug ID: 36177
   Summary: We need selenium tests to cover csrf checks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 36148 will be adding a check in our middleware for csrf coverage on post
operations - we need selenium tests to cover all scenarios

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] New: We need selenium tests to check fro 'cud-' operations in stable branches

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

Bug ID: 36176
   Summary: We need selenium tests to check fro 'cud-' operations
in stable branches
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 34478 will be adding 'cud-' (create/update/delete) to all actions that
change state. We need to ensure these are not backported when fixing bugs - we
test to check for this

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36175] Checking out items that are booked doesn't quite work

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36175

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36175] New: Checking out items that are booked doesn't quite work

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36175

Bug ID: 36175
   Summary: Checking out items that are booked doesn't quite work
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

At the moment, if an item is currently "booked" and that item is attempted to
be checked out which would cause the due date to be during the 'booked' period,
there is a box to edit the date of the due date, which is locked.
Process to test:
1. Make an item booked from 3/3/2024-3/9/2024
2. Go to check out this item to another patron, the circulation period of the
item type is 2 weeks.
3. Koha presents a box which tells staff that this item is booked, provides a
locked date picker and two other options, checkout - yes /no.
4. Since the date picker is locked, no new date can be used to still check out
the item to the patron with a smaller circulation period.
5. if Choose Yes, the item is checked out with a regular circulation period,
totally ignoring the booking.


The date picker should not be locked, staff should be able to checkout the item
and give the item a different due date. (I tested using a SuperLibrarian
Permission)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36171] Problems with the Russian program interface

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171

--- Comment #2 from sergeinik  ---
You need to switch the interface language to Russian and open the card of any
user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30037] Set default profile when staging MARC records on import

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

--- Comment #11 from Noémie Labine  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #162492|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 162502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162502=edit
Bug 36103: Remove the "Cancel hold" link for item level holds

This link is broken and doesn't make sense from a UI/UX perspective
and thus should be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

Kyle M Hall  changed:

   What|Removed |Added

Summary|"Cancel hold" link broken   |Remove the "Cancel hold"
   |for item level holds|link for item level holds

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36103] "Cancel hold" link broken for item level holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103

--- Comment #6 from Kyle M Hall  ---
(In reply to Owen Leonard from comment #4)
> In my opinion we should remove the link altogether. I don't think it makes
> sense to offer a cancel link when a new hold is in the process of being
> placed.

Nick and I both happened to discuss this very link last week and we came to the
same conclusion!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||36174


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36174
[Bug 36174] Holds with cancellation requests tab display
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36174] Holds with cancellation requests tab display

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36174

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||22456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456
[Bug 22456] Allow patrons to cancel their waiting holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36174] New: Holds with cancellation requests tab display

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36174

Bug ID: 36174
   Summary: Holds with cancellation requests tab display
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The feature of cancelling waiting holds depends on circulation rules.
It may not be used at all.
So when there are no cancellation requests tab whe should not show the tab in
circ/waitingreserves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129

Anni Rajala  changed:

   What|Removed |Added

 CC||anni.raj...@turku.fi

--- Comment #2 from Anni Rajala  ---
When testing this I noticed that after refreshing page the selected checkbox
didn't always remain. Both batch modification and deletion tool use the same
code (+ browser's cache) when hiding columns so apparently what happened in my
case was that my previous selection from batch modification tool was retrieved
when I refreshed the batch deletion tool -page.

Not sure if this can or needs to be fixed, but just to let everyone know what I
bumped into. The patch does however fix the original issue where selection and
columns hidden didn't match after reloading the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173

--- Comment #2 from Jonathan Druart  ---
If this patch does not apply, wait for bug 34478 to be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173

--- Comment #1 from Jonathan Druart  ---
Created attachment 162501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162501=edit
Bug 36173: Display basket info when cancelling an order

The basketno is missing from the 2 links in acqui/parcel.tt

Better to retrieve the basketno from the order in the controller.

Test plan:
Create an order, receive it
On the parcel view notice that the "Cancel order" link leads to a
confirmation page that does not contain the info of the basket.
It's fixed with this patch applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36173] Cancelling order confirmation view does not show basket's info

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36173] New: Cancelling order confirmation view does not show basket's info

2024-02-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36173

Bug ID: 36173
   Summary: Cancelling order confirmation view does not show
basket's info
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >