[Koha-bugs] [Bug 36203] Authorised value's descriptions should not be NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36203 --- Comment #2 from Katrin Fischer --- In the past it was sometimes necessary to add an empty entry manually, as the pull downs would not offer one otherwise. So such entries might exist in the existing databases for a reason. I am not sure if they are still needed. How would a fix with the atomicupdate look like? Would we aim for deleting such entries? I believe just removing them could cause issues: a pull down that does not offer an empty entry on its own, would jump to the first entry in list, which would result in saving/displaying wrong values in forms. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Katrin Fischer changed: What|Removed |Added Summary|Cannot set suggestedby when |Cannot set suggestedby when |adding/editing a suggestion |adding/editing a suggestion |from the staff client |from the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12141] On Display Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #25 from Victor Grousset/tuxayo --- (In reply to Pedro Amorim from comment #20) > Created attachment 162269 [details] [review] > Bug 32565: QA Follow-up: Fix tests > > Apply original tests patch + this follow-up. Run: > prove t/db_dependent/HoldsQueue.t > Notice tests fail. > Apply fix patch, run the above prove command again. > Notice tests pass. Confirmed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA --- Comment #7 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) Should circulate_remaning_permissions be needed for bookings? It's the one necessary for the calendar to load in the booking form. Even if there is something to do about it, it's not really for this ticket so still passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162249|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 162695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162695=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24125] Batch delete should not remove authorities that are still in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 --- Comment #8 from Esther Melander --- I like having an option to unlink versus delete. Does the unlink here retain the authority record in the system? If so, won't the authority in the bibliographic record eventually relink if AutoLinkBiblios, CatalogModuleRelink, and LinkerRelink are enabled? If I wanted to batch delete authorities that are in use, the system should unlink and then delete, while retaining the authority in the bibliographic record. That retention step is perhaps the part that should be optional. I can see cases where the authority in the bibliographic record is retained and cases where it is not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Michal Denar changed: What|Removed |Added Attachment #162528|0 |1 is obsolete|| --- Comment #36 from Michal Denar --- Created attachment 162694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162694=edit Bug 35659: (follow-up) Better handling of accented characters If you try to harvest bibliographic records from a UNIMARC OAI repository (using oai_dc data format) in a MARC21 Koha instance and run the OAI harvester script in verbose mode, you may get lines similar to the following in the output: no mapping found for [0xC9] at position 0 in Économie politique g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308. no mapping found for [0xC9] at position 0 in Église et société g0=ASCII_DEFAULT g1=EXTENDED_LATIN at /usr/share/perl5/MARC/Charset.pm line 308. When looking at the imported records' biblio details page in the OPAC, most words containing accented characters will not appear correctly. The fix is to apply Franck Theeten's solution from Bug 16488 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488#c24) and modify the value of the MARC leader's 10th character to 'a' in the XSLT that transforms the UNIMARC OAI records into MARC21 XML. Then, the accented characters get imported properly and the records appear correctly in the OPAC. Test plan: 0) Without this patch, running the OAI harvesting script in verbose mode produces many warnings, and garbled characters appear in the OPAC biblio details page wherever accented characters are in use. 1) Apply this patch. 2) Re-run the OAI harvesting script in verbose + force mode (force mode is required to ignore record datestamps from previous runs): misc/cronjobs/harvest_oai.pl -v -r -f This time there should be no warnings printed on your screen, and any characters with accents in the updated records should look OK in the OPAC. Thanks-to: Franck Theeten Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Michal Denar changed: What|Removed |Added Attachment #162011|0 |1 is obsolete|| --- Comment #35 from Michal Denar --- Created attachment 162693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162693=edit Bug 35659: OAI Harvester Test plan: - Run updatedatabase.pl - Apply the DBIC update patch - Setup an OAI repository in Administration -> OAI repositories (admin/oaiservers.pl) If the repository dataformat is in oai_dc, you can use the sample XSLT files: For Unimarc: OAIDCtoUNIMARCXML.xsl for bibliographic records AuthOAIDCtoUNIMARCXML.xsl for authorities For Marc21: OAIDCtoMARC21XML.xsl for bibliographic records AuthOAIDCtoMARC21XML.xsl for authorities If the repository dataformat is in marc-xml, you can use OAIMarcxml2KohaMarcxml.xsl for both Unimarc and Marc21. - Some repositories to test with: Bibliographic records, oai_dc: Endpoint: http://staroai.theses.fr/OAIHandler Set: ddc:260 XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIDCtoMARC21XML.xsl Authorities, oai_dc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoUNIMARCXML.xsl or XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/AuthOAIDCtoMARC21XML.xsl Authorities, marc-xml, Unimarc: Endpoint: https://www.idref.fr/OAI/oai.jsp Set: a XSLT: /koha-tmpl/intranet-tmpl/prog/en/xslt/OAIMarcxml2KohaMarcxml.xsl - Note: marc-xml harvesting will not work with HTTP::OAI::Harvester version 3.xx Version 4.xx is needed. See Bug 17704 for updating Koha default version to 4.xx - If you want to receive a report email, fill the OAI-PMH:HarvestEmailReport syspref. The model used (OAI_HARVEST_REPORT) can be edited in tools -> Notices and slips. - start a harvest with the following command: misc/cronjobs/harvest_oai.pl This script starts an OAI Harvest This script has the following parameters : -h --help: this message -v --verbose (enable output to stdout) -r --repository: id of the OAI repository -d --days: number of days to harvest from (optional) -l --list: list the OAI repositories -f --force: force harvesting (ignore records datestamps) (optional) Example: misc/cronjobs/harvest_oai.pl -r 1 -d 10 -v -f - Check the logs in the Log Viewer (tools/viewlog.pl) (CronjobLog syspref must be activated) Sponsored-by: KohaLa Signed-off-by: John Doe Signed-off-by: Michal Signed-off-by: John Doe Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 --- Comment #34 from Michal Denar --- Created attachment 162692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162692=edit DO NOT PUSH: Bug 35659 DBIC Update Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36218] New: ITEM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36218 Bug ID: 36218 Summary: ITEM Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: Windows Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bibliotecah...@tae.edu.mx QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hello, I'm from CDMX and when I want to add or modify individual items to magazines or books it doesn't let me edit anything, it turns white and doesn't show anything. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35897] Print barcode range does not allow for barcodes with a mix of alphanumeric characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35897 --- Comment #1 from Esther Melander --- Perhaps one way to deal with this is to add a box for a prefix. In the example above, THLS functions as more of a prefix than an incrementing character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #28 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #25) > Thanks for testing Victor.. you did indeed highlight an issue with my > database update... (I always struggle with these bitwise ops) > > The follow-up corrects the DB update. > > No, don't remove those permissions from the users, they need to be left in > place else the features are disabled entirely for the user. Oh right, I won't be able to get to the view that uses the search. --- It works! :) Testing notes: - manage_bookings: search a patron to make a booking - edit_borrowers: search a guarantor when editing a patron - order_manage: search a patron in the form for new order - label_creator: search a patron when creating a new batch - routing: search a patron as a recipient in the "create routing list" form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162580|0 |1 is obsolete|| --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 162691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162691=edit Bug 29509: Correction to bitwise check I was using it wrong :( Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162579|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 162690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162690=edit Bug 29509: Update swagger specification and add permissions to users This patch removes the 'edit_borrowers', 'manage_bookings', 'lable_creator', 'routing' and 'order_manage' permissions from the list of options in the patrons list endpoint. We then assign the new 'list_borrowers' permission to any users who have those removed permissions Test plan 1) Apply patch and run the database update 2) Users with any of the permissions listed above should now also have the 'list_borrowers' permission too. 3) Check that patron searching continues to work from the various locations in the UI for the above affected users Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Brendan Lawlor changed:
What|Removed |Added
Attachment #162672|0 |1
is obsolete||
--- Comment #4 from Brendan Lawlor ---
Created attachment 162689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162689=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!
Signed-off-by: Brendan Lawlor
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #13 from Matthias Le Gac --- Created attachment 162688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162688=edit Bug 35169: Resolve the override situations Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162618|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 162687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162687=edit Bug 35950: Adjust tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162617|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 162686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162686=edit Bug 35950: Move AddReturn call into circulation.pl There should be no change in beahavior. Following the test plan from Bug 35840. To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36178] Add index for status on message queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162503|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 162685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162685=edit Bug 36178: Add index for status on message queue table For large libraries, the query to gather pending notices from the message queue can take a very long time. ByWater's Rackpace DBA Mike was kind enough to do some work on this for us and found the issue. He recommends adding a simple index on the status column to fix this issue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) SHOW CREATE TABLE message_queue should show the new index via koha-mysql Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36178] Add index for status on message queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36178 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36193] CSRF - Code review missed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36193 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 162684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162684=edit Bug 36193: Add more request information on Koha::Middleware::CSRF output Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 --- Comment #22 from Esther Melander --- I created a marc modification template per the test plan that creates an item with only 952$a. The new item was added to a bibliographic record where the 942$c = Visual Materials. The 952$y did default to matching the 942$c. So this is perhaps not a blocker, but could be made a bit more clear in documentation. As far as required fields, I think Koha will allow an item record to be created/exist with no required fields. However in practice, it seems the 952 $a, $b, $y are required in order for downstream circulation, holds, etc., to function properly. Perhaps, this is best addressed in documentation rather than forcing required fields. Or, perhaps there is a way to give best practices when creating items in general. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #162675|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 162683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162683=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161342|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 162682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162682=edit Bug 8461: Display information on whithdrawn item when checked in This patch displays the due date and withdrawn information in the Checked-in items table when 'ShowAllCheckins' is enabled. While the top message is clear, if a staff member checks in two items, then refers to the table they would not have all the information. To test: 1 - Enable system preference 'ShowAllCheckins' 2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block' 3 - Check out an item to a patron 4 - Mark the item as withdrawn 5 - Check the item in 6 - Note message at top says things like 'Cannot check in' 'Item has been withdrawn' 7 - Note the Checked-in items table says 'Not checked out' 8 - Apply patch, restart all 9 - Check the item in again 10 - Note top message has not changed 11 - Note the table now say 'Item was not checked in' and displays the due date and patron info 12 - Note the table also includes the withdrawn value for the item Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36217] New: Jobs page include last hour filter does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217
Bug ID: 36217
Summary: Jobs page include last hour filter does not work
Change sponsored?: ---
Product: Koha
Version: 23.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs@lists.koha-community.org
Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
The "include_last_hour" checkbox labelled "Only include jobs enqueued in the
last hour" on the Background Jobs page /cgi-bin/koha/admin/background_jobs.pl
does not seem to work, it filters out all jobs regardless of the time they were
enqueued.
To create:
- stage a MARC file for import (or do something else that creates a job)
- visit Administration > Jobs page
Expected:
The job your just created should be listed. The filters "include_last_hour" and
"only_current" ("Current jobs only", I don't actually know what this means,
jobs that have not completed?) are on by default. Even removing the current
filter, the job does not appear until you remove the include last hour filter.
No job ever appears if include last hour is checked.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36216] New: Hide Show checkouts/charges to guarantor when not necessary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36216 Bug ID: 36216 Summary: Hide Show checkouts/charges to guarantor when not necessary Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the patron file (moremember.pl), there is always "Show checkouts to guarantor" and "Show charges to guarantor", even if the library doesn't use the guarantor feature. If AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor are both set to "Don't allow", or if the patron has no guarantor, I think the "Show checkouts to guarantor" field should be hidden. Same for AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor. If both are set to "Don't allow" or if the patron has no guarantor, the "Show charges to guarantor" should be hidden. I'm thinking especially of academic libraries and special libraries, this is useless information that shows in the patron file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Alex, I must not understand. What is the use case for STAFF adding a guarantee? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24125] Batch delete should not remove authorities that are still in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- (In reply to Alex Buckley from comment #13) > (In reply to Owen Leonard from comment #10) > > (In reply to Owen Leonard from comment #9) > > > > > I'm a little bit concerned about using dateaccessioned for sorting > > > > Ignore me, I wasn't thinking about the fact that there is already a "Date > > added" sorting option. > > > > I wonder if there is a more user-friendly way to say "Date accessioned?" > > Some way to express that the order is by newest item? > > Hi Owen, > > Thanks for your feedback and taking a look! > > Looking at your screenshots now. > > Do you think 'Date acquired' might be a more helpful wording? Happy to > change the wording. > > Alex Looks like 'Date acquired' is used on returns.tt and catalogue_stats.tt and that seems to make sure much sense to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36215] Bookings calendar only shows bookings within RESTdefaultPageSize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36215 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36215] New: Bookings calendar only shows bookings within RESTdefaultPageSize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36215 Bug ID: 36215 Summary: Bookings calendar only shows bookings within RESTdefaultPageSize Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If a record has more bookings than the system preference RESTdefaultPageSize they will not appear in the calendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #132 from Lucas Gass --- Looks like a very small rebase is needed after Bug 34478 was pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36214] plugin install/update/removal should be logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36214 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33350] Show items info several times in notice content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33350 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #2 from Lucas Gass --- Can't we already do this with Template Toolkit? Not sure if adding more complexity to GetPreparedLetter when there is another way to already do this. But if we do add this I think it needs a unit test in this area. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36214] New: plugin install/update/removal should be logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36214 Bug ID: 36214 Summary: plugin install/update/removal should be logged Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: eve...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Plugin installation/updates/removal should be action logged. User, time/date, and what was changed should at least be included in the logs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #19 from David Gustafsson --- Now rebased. @solene.nga...@inlibro.com It's still reproducible for me, there could be issues if the mappings for title have sort enabled for more fields than 245, in which case the sort order will be unpredictable as some other field might be the one actually sorted on. Had that same issue myself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #34 from Barbara Johnson --- I tested this in a ByWater sandbox but am getting an error. I used the test plan from comment 27. In step 9 I am getting an error when saving on addorderiso2709.pl that says 'Some required item subfields are not set.' The only field that displays required next to it is budget_code which is already filled in from the xml file. I tried changing the budget_code to a different value but still got the error. I tried globally changing the budget_code via the 'Default accounting details' setting but am still getting the error message. I also noticed that the price (949$g) and replacementprice (949$v) were not populated on addorderiso2709.pl. I tried entering prices for those fields but that also did not clear the error. In case it matters, I also saw that the data in the xml file contained barcodes in the 949$p but those did not populate on addorderiso2709.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #12 from Matthias Le Gac --- (In reply to Lucas Gass from comment #10) > Matthias, > > Looking closer here. If you add values to the new system preferences they > override what is added at the cron level? Then you probably need to add a > better description about what is happening in the POD? > > Also, if you use the system preferences now you are unable to configure the > cron differently and run it more than once. For example you might want to do > something like this: > > longoverdue.pl --skip-category PT --lost 14=2 --confirm > longoverdue.pl --skip-category PT2 --lost 21=2 --confirm > > That seems like it could be a problem? > > I won't fail this again. I'll let someone else have a look and give opinions. I'll look into that to implement the correct behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24035] When recording local use, holds should be captured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24035 Andrew Fuerste-Henry changed: What|Removed |Added Summary|When recording local use, |When recording local use, |there is no alert for holds |holds should be captured CC||andre...@dubcolib.org Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Andrew Fuerste-Henry --- I've been slow to realize exactly how this was implemented. With bug 27992, if there is a hold on an item that is checked out to a statistical patron the resulting alert box will say both "Local use recorded" and "Item on hold, please checkin." Could we not trigger the hold from the checkout? What we have now is an easily-missed prompt to take an additional action involving multiple clicks. I'm going to reopen and rename this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162625|0 |1 is obsolete|| --- Comment #53 from ByWater Sandboxes --- Created attachment 162681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162681=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162624|0 |1 is obsolete|| --- Comment #52 from ByWater Sandboxes --- Created attachment 162680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162680=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162572|0 |1 is obsolete|| --- Comment #51 from ByWater Sandboxes --- Created attachment 162679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162679=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162571|0 |1 is obsolete|| --- Comment #50 from ByWater Sandboxes --- Created attachment 162678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162678=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162570|0 |1 is obsolete|| --- Comment #49 from ByWater Sandboxes --- Created attachment 162677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162677=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #11 from Lisette Scheer --- I agree with Lucas that it's a problem you can't set different options for different patron categories. Currently you can set not only to skip, but also to have different patron types go to lost at different times at the cron level (such as having staff go to lost at 365 when the default is 60.) The skip default is good, but this doesn't really address the other part where you can set different rules by category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #10 from Lucas Gass --- Matthias, Looking closer here. If you add values to the new system preferences they override what is added at the cron level? Then you probably need to add a better description about what is happening in the POD? Also, if you use the system preferences now you are unable to configure the cron differently and run it more than once. For example you might want to do something like this: longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm That seems like it could be a problem? I won't fail this again. I'll let someone else have a look and give opinions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 --- Comment #21 from Kyle M Hall --- (In reply to Kyle M Hall from comment #20) > (In reply to Andreas Jonsson from comment #19) > > We have been running this in a test system of a large coalition of regional > > Libraries, but I think that we need a collection of unit tests to > > sufficiently test all aspects. It is too tedious to manually walk through > > all possible scenarios. I will try to find some more time to work on this. Andreas, have you had any time to work on those tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162622|0 |1 is obsolete|| --- Comment #18 from Phan Tung Bui --- Created attachment 162676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162676=edit Bug 35145 : (follow-up) Rename number to display_order - Seperate DBIC file - Rename “number” to “display_order” -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Attachment #162520|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 162675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162675=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24720] Remove special characters from beginning of sort fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720 David Gustafsson changed: What|Removed |Added Attachment #125210|0 |1 is obsolete|| --- Comment #18 from David Gustafsson --- Created attachment 162674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162674=edit Bug 24720: Add test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Attachment #162459|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 162673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162673=edit Bug 36060: Simplify logic to enable/disable CheckinChecked/RenewChecked buttons This patch attempts to simplify for disabling/enabling the 'Check in selected items' and 'Renewal selected items' buttons. To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 12. When the table reloads the 'renew' selections should be retained 13. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 14. When the table reloads the 'check in' selections should be retained 15. Have overdues 16. Go to a patron account and load the issue table 17. The items that are overdue are checked for renewal by default 16. The 'Renew selected items' button show be enabled. Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #21 from Olivier Hubert --- Following a discussion on IRC with Jonathan, I waited until the commits for 34478 were pushed to master. I then updated everything on my KTD and made sure the commits were there before I started testing. When using SSO to login, I now get the "wrong_csrf_token" error message all the time. This happens using both the OPAC and Intranet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162622|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162621|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162348|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #76 from David Gustafsson --- Must have forgotten to change status, setting to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Kyle M Hall changed:
What|Removed |Added
Attachment #162669|0 |1
is obsolete||
--- Comment #3 from Kyle M Hall ---
Created attachment 162672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162672=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #10 from Lucas Gass --- Needs rebased now that Bug 34478 is in, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #160 from Jonathan Druart --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #159 from Jonathan Druart --- Created attachment 162671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162671=edit Bug 35329: Fix conflict with 33457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #158 from Jonathan Druart --- Created attachment 162670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162670=edit Bug 35329: (follow-up) Add styling to info and error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162622|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162621|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162347|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162620|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162348|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
--- Comment #2 from Kyle M Hall ---
Created attachment 162669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162669=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #9 from Lucas Gass --- (In reply to Brendan Lawlor from comment #8) > Hi Lucas, sorry for the false report and thanks for your time chatting with > me. > > I retested this bug this morning and could not reproduce it. So then I reset > git and tested again without the bug applied and then I could see it. > > So I think what happened was I didn't have the bug applied or had applied > the wrong bug by accident when I first saw the bug. > > My bad, status back to signed off. I appreciate your testing, Brendan. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] More detailed patron record changes log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Kyle M Hall changed: What|Removed |Added Blocks||36159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 [Bug 36159] Patron imports record a change for non-text columns that are not in the import file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Kyle M Hall changed: What|Removed |Added Depends on||3820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 [Bug 3820] More detailed patron record changes log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #8 from Brendan Lawlor --- Hi Lucas, sorry for the false report and thanks for your time chatting with me. I retested this bug this morning and could not reproduce it. So then I reset git and tested again without the bug applied and then I could see it. So I think what happened was I didn't have the bug applied or had applied the wrong bug by accident when I first saw the bug. My bad, status back to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Brendan Lawlor changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 --- Comment #1 from Jonathan Druart --- Created attachment 162668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162668=edit Bug 36195: serials/routing-preview.pl - Fix save and preview No idea why we are passing issue_escaped instead of the id, but this patch fixes the regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- Comment #19 from Tomás Cohen Arazi ---
Plugins should always use:
my $table_name = $self->get_qualified_table_name('name_you_want');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Phan Tung Bui changed: What|Removed |Added Attachment #162347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #9 from Matthias Le Gac --- (In reply to Lucas Gass from comment #7) > Matthias, > > I tested this and it seems to work as intended, you sysprefs.sql update > looks good to me. > > However, your DBUpdate explanation and type should not be NULL. Sorry to be > a pain! Thank you for your feedback. Normally it's good now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 --- Comment #8 from Matthias Le Gac --- Created attachment 162667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162667=edit Bug 35169: update DBupdate file Test Plan : 1 - Apply the patch 2 - Go to Koha administration > System preferences > Circulation > Checkout policy 3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to "2" 4 - Check out an item to a patron and set the date to more than two days. 5 - Remember the category of the patron Test of DefaultLongOverdueBorrowerCategories option : 6 - Go to Koha administration > System preferences > Circulation > Checkout policy 7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron 8 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 9 - Normaly you see in list the check out item set just before and the list it's only borrowers with the category Test of DefaultLongOverdueSkipBorrowerCategories option : 10 - Go to Koha administration > System preferences > Circulation > Checkout policy 11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 12 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 13 - Normaly you don't see in list the check out item set just before and the list it's only borrowers with others categories Test of warning : 14 - Go to Koha administration > System preferences > Circulation > Checkout policy 15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the patron 16 - Go to the terminal in the koha environment and execute the script "./misc/cronjobs/longoverdue.pl" 17 - Normaly you don't see in list the check out item set just before because the "DefaultLongOverdueSkipBorrowerCategories" take advantage of "DefaultLongOverdueBorrowerCategories" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
