[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #21 from Marcel de Rooy --- Created attachment 162944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162944=edit Bug 33898: (follow-up) Apply same solution to es_indexer_daemon Test plan: Similar as first patch with Elastic index jobs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #20 from Marcel de Rooy --- The alternative patch addresses the issues raised earlier on the use of signals and follows the suggestions of David. Kyle, Victor and Asymar: Would this work for you? Note that you should apply only the second patch as an alternative for the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Marcel de Rooy changed: What|Removed |Added Attachment #162942|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 162943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162943=edit Bug 33898: Alternative approach with receive frame timeout See bug 33898 comment6. Test plan: Based on comment12: Stage MARC import and manage. Look at the same time to the results of ps aux|grep Z. Verify that the lines with [background_jobs] disappear within 10 seconds. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #18 from Marcel de Rooy --- Created attachment 162942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162942=edit Bug 33898: Alternative approach with receive frame timeout See bug 33898 comment6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #17 from Marcel de Rooy --- In the above test plan Elastic is used, but note that those updates do not go via the regular worker script. There is another one (with more ore less the same code). Still to be merged :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #16 from Victor Grousset/tuxayo --- Thanks Asymar for your test plan, it's very simple and I was able to reproduce the issue and confirm that the patch prevents it. So with comment 12's test plan, there one zombie at the time. It's killed when the next staging/import starts. And a new zombie will stay at the end of the operation. So that blocking point is no more. (unless the elastic index update based test plan shows something more subtle or impactful that would benefit from being tested) Remaining is «there seems to be some discussion about implementation». -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #153194|0 |1 is obsolete|| --- Comment #15 from Victor Grousset/tuxayo --- Created attachment 162941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162941=edit Bug 33898: background_jobs_worker.pl may leave defunct children processes for extended periods of time It appears that the background jobs worker can leave defunct processes for periods of time. Though it is mostly harmless, it would be nice if that did not happen. Children are reaped automatically when start or wait_all_children are called. We only call start when a new job is found, and wait_all_children after exiting our while loop. The solution is to simply call reap_all_children after we sleep. This is a non-blocking call that will clean up those defunct processes. Test Plan: 1) Disable Rabbit 2) Set background_jobs_worker/max_processes to something like 5 3) Restart all the things! 4) Run a bunch of elastic index updates 5) Verify you have defunct processes 6) Apply this patch 7) Run more elastic index updates 8) Defunct processes should disappear every 10 seconds or so! If you do not see defunct processes, the test plan is to simply verify everything continues to work as expected. Signed-off-by: Emily Lamancusa Signed-off-by: Victor Grousset/tuxayo Used Asymar's test plan from comment 12. (based on record import) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||36280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280 [Bug 36280] Viewing batch of staged records broken: CSRF token error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36280] Viewing batch of staged records broken: CSRF token error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36280] New: Viewing batch of staged records broken: CSRF token error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280 Bug ID: 36280 Summary: Viewing batch of staged records broken: CSRF token error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: vic...@tuxayo.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl 1. Stage a batch 2. When it's done, click on "view batch" 3. Page loads but pops an alert that says "403: Forbidden" and table stays empty network tool show an XHR to /cgi-bin/koha/tools/batch_records_ajax.pl that returns 403. The content can be save in an HTML file and opened to show a page that says: > An error has occurred! > Error 403 > Programming error - No CSRF token passed for POST Going to "Manage staged MARC records" and view an existing batch has the same outcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #14 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #13) > To get child zombie processes reaped, you'd just need to stop the parent > process. Then the child process gets inherited by PID 1 and they'll get > reaped. In other words @Asymar just restart the koha services (plack more specifically). I think it's here: https://wiki.koha-community.org/wiki/Commands_provided_by_the_Debian_packages#koha-plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #62 from Victor Grousset/tuxayo --- It works :) -- @QA here is an example of the changes from the DB upgrade on the data used in test plan: ++-++--+-++++ | id | tag | module | filter | add | append | remove | delete | ++-++--+-++++ | 2 | 245 | source | z3950| 0 | 0 | 0 | 0 | | 3 | 300 | source | *| 0 | 0 | 0 | 0 | | 4 | 245 | source | batchmod | 0 | 0 | 0 | 0 | ++-++--+-++++ ↓ ++-++--+-++++ | id | tag | module | filter | add | append | remove | delete | ++-++--+-++++ | 2 | 245 | source | z3950| 0 | 0 | 0 | 0 | | 3 | 300 | source | *| 0 | 0 | 0 | 0 | | 4 | 245 | source | batchmod | 0 | 0 | 0 | 0 | | 12 | * | source | z3950| 1 | 1 | 1 | 1 | | 13 | * | source | batchmod | 1 | 1 | 1 | 1 | ++-++--+-++++ --- @David G. to address Comment 28 's point 3 (release notes) you can look at latest release announcement: https://koha-community.org/koha-23-11-released/ Some tickets have grey boxes with text. That's from the "Text to go in the release notes" field here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162805|0 |1 is obsolete|| --- Comment #61 from Victor Grousset/tuxayo --- Created attachment 162940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162940=edit Bug 33268: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162804|0 |1 is obsolete|| --- Comment #60 from Victor Grousset/tuxayo --- Created attachment 162939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162939=edit Bug 33268: If rules exists add rules to preserve current behavior Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162803|0 |1 is obsolete|| --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 162938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162938=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1. Administration => record overlay rules 2. Add this: Module Filter Tag Preset Added Appended Removed Deleted Source Z39.50 245 Protect Skip Skip SkipSkip Source * 300 Protect Skip Skip SkipSkip Source Batch record modification 245 Protect Skip Skip SkipSkip 3. Add MARC modification templates: Update existing or add new field 245$a with value CATSCATSCATSCATS Update existing or add new field 300$a with value CATSCATSCATSCATS 4. Find a record that has those fields (likely any record would) 5. Use batch record modification on the record 6. 300$a should have been catified (expected, that's the bug) 7. 245$a is preserved 8. Change the value of the 300$a to something else. Temporarly disable MARCOverlayRules to be able to do so. And reenable it. 9. Apply the patch, restart services 10. Use batch record modification on the record 11. 300$a should be preserved, cat protection should have worked 12. Run tests: prove t/db_dependent/Biblio/MarcOverlayRules.t 13. Celebrate! :D Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162802|0 |1 is obsolete|| --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 162937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162937=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162801|0 |1 is obsolete|| --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 162936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162936=edit Bug 33268: Add tests Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #56 from Victor Grousset/tuxayo --- (In reply to David Gustafsson from comment #55) > Yes, exactly. I retried and it works!!! :D I might have messed something because I should have been blocked at step: > 8. Change the values of the two subfields to something else Because the * overlay rules also include the editor. And back then I was able to change the values with the editor and now as expected, I can't. So likely had mess the rules. (You likely hit that too with my bogus test plan and that was an hint that I did something wrong) Anyway, I'm fixing the test plan and putting it in the patch commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Lisette Scheer --- Currently, you can set different lengths for different patrons, running the cron multiple times with different settings. Ideally a solution in the staff interface would also allow this. This + the option to add different settings at the patron category level with different settings would be ideal: longoverdue.pl --skip-category PT --lost 14=2 --confirm longoverdue.pl --skip-category PT2 --lost 21=2 --confirm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #106 from Lisette Scheer --- Applying: Bug 8137: Add 'global' has_priority rules for checkouts Using index info to reconstruct a base tree... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt .git/rebase-apply/patch:315: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 8137: Add 'global' has_priority rules for checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #289 from Lisette Scheer --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Lisette Scheer --- The table doesn't load and there's this error in the console: SyntaxError: Unexpected token ':' (at ill-list-table_23.126.js:231:23) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #5 from Lucas Gass --- (In reply to Owen Leonard from comment #3) > This works to display the form I think there's still a problem with the > check for duplicates. I filled out the form (title, author, isbn, and year) > using information from a book already in the catalog and when I submitted it > I got a blank page. Good catch. I approached this the wrong way. My new patch should be better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Lucas Gass changed: What|Removed |Added Attachment #162907|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 162935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162935=edit Bug 36274: Correct links leading to purchase suggestion page To test: 1. APPLY PATCH 2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. 3. Make a suggestion and confirm it works. 4. Try to make a suggestion using title, author, isbn information from an item that already exists. 5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. 6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. 7. Do an OPAC search that will yield no results as a logged in user. 8. Click the "Make a purchase suggestion" link, making sure it works. 9. Turn on AnonSuggestions and log out of the OPAC. 10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Lisette Scheer changed: What|Removed |Added Attachment #162715|0 |1 is obsolete|| --- Comment #4 from Lisette Scheer --- Created attachment 162934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162934=edit Attachment to Bug 36221 - Improve styling of Standard backend create OPAC form Bug 36221: Preparation This refactors the code for more DRY Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221 Lisette Scheer changed: What|Removed |Added Attachment #162716|0 |1 is obsolete|| --- Comment #3 from Lisette Scheer --- Created attachment 162933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162933=edit Bug 36221: OPAC Styling Test plan, dont apply patches yet: 1) Enable ILLModule 2) Create a new OPAC ILL request, visit: /cgi-bin/koha/opac-illrequests.pl?method=create=Standard 3) Notice the style. Apply patches. Repeat Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20644] Per itemtype setting for CheckPrevCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #13 from David Cook --- (In reply to Asymar Riu from comment #12) > A reboot of the server kills the zombie process. That's overkill. To get child zombie processes reaped, you'd just need to stop the parent process. Then the child process gets inherited by PID 1 and they'll get reaped. > Since it seems like a problem that doesn't affect everyone, could it be > something related to the Server settings? No, it's a real issue. It's more likely to happen to systems that use background jobs more, especially sporadically. This is just how parent/child processes work. Parent processes are responsible for reaping their child processes. As Kyle pointed out, currently child processes are only reaped under certain conditions. It's just about tweaking the code to reap them in a more responsible way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #21 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #19) > Just wondering about the direct SQL in this patch. > We do have HoldsQueueItems.pm - should we not be able to use a delete? Indeed it seems so , thanks for seeing that. @Kyle: up for a follow up patch? I can open the ticket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- I was able to rebuild and get the new mappings using the following command in ktd --shell koha-elasticsearch --rebuild -r -d -b -v kohadev -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose changed: What|Removed |Added Attachment #162913|0 |1 is obsolete|| --- Comment #3 from Caroline Cyr La Rose --- Created attachment 162932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162932=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #19 from Lucas Gass --- (In reply to Esther Melander from comment #16) > Testing other tables in Koha, it is possible to click on the sort arrows and > have the column sort. In lists, it looks like you have to click on the > column name. This is inconsistent behavior, but is perhaps a separate bug. Lists are one place in Koha that are not yet "DataTable'ed". There is an open bug regarding this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #18 from Esther Melander --- Signing off because this works according to the test plan. I agree that Date Added versus Date Accessioned are a bit confusing. They could mean the same thing, but these dates are pulled from different places. Date Added comes from the bibliographic record (?) and Date accessioned comes from the item record, if I understand the difference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Biblibre Sandboxes changed: What|Removed |Added Attachment #162555|0 |1 is obsolete|| --- Comment #17 from Biblibre Sandboxes --- Created attachment 162931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162931=edit Bug 36188: Sort lists by items.dateaccessioned in the OPAC When a list is sorted by dateaccessioned it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. In the Staff client, go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date accessioned' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates 5. In the staff client observe the list records are ordered by the 'Date accessioned' in descending order - i.e. titles with newest dateaccessioned are displayed first 6. In a new browser window navigate to the list in the Koha OPAC 7. Confirm the list titles in the OPAC are ordered in the same order as the staff client 8. In the OPAC click on the 'Sort' button and select 'Date accession (oldest to newest) 9. Confirm the OPAC list order reverses 10. In the OPAC choose other values from the 'Sort' button and confirm the list is re-sorted correctly Sponsored-By: The Treasury, New Zealand Signed-off-by: esther -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Matthias Le Gac changed: What|Removed |Added Attachment #154890|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Matthias Le Gac changed: What|Removed |Added Attachment #162929|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #16 from Esther Melander --- Testing other tables in Koha, it is possible to click on the sort arrows and have the column sort. In lists, it looks like you have to click on the column name. This is inconsistent behavior, but is perhaps a separate bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Blou changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Blou --- Well, I'll fail it myself :-P Matthias, the code for additional-contents.pl has been all reformated, like you passed it in perltidy. It makes it very hard to see the actual modifications. Please resend the patch with no extra formating, please (beside the lines with actual changes). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #15 from Esther Melander --- I tested this and it appears to work when selecting the date accessioned. However, I couldn't sort the list at all when clicking on the sort button for the other columns. Even though I selected the sort order by date accessioned, I would expect to retain the ability to continue to sort the list in different way when viewing. For example, maybe I want the date accessioned to reverse the sort, or maybe I need to sort by call number next. Clicking on the sort icons in the column header does nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 --- Comment #17 from Myka Kennedy Stephens --- I've been doing git pulls outside of Koha testing docker, which was making it look like my Koha repository was updating, but I guess it wasn't. I did a git pull from within the ktd shell, applied the patch, and then it worked! Applying the patch has the desired effect that a non-superuser from another branch has the option to preview HTML content but the edit and delete buttons are hidden from content for other branches and all libraries. After signing-off, I am having some trouble with steps 9 and 10 of the test plan. After trying to save new content with the limited-access user, I get the following error: Template process failed: undef error - The method Koha::AdditionalContent->idnew is not covered by tests! This error persists to the superuser login. When I do a hard reset to master, the error goes away and I can see the content that I attempted to add and save before I got the error. Hoping QA or a second tester can look into this further. I'm leaving it as signed off, but please change if there's a more appropriate status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36070] "Place recall" hover styling on OPAC not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36070 Emily Lamancusa changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36070] "Place recall" hover styling on OPAC not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36070 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #4 from Emily Lamancusa --- Nice catch! Fixes the problem and QA script passes. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36070] "Place recall" hover styling on OPAC not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36070 Emily Lamancusa changed: What|Removed |Added Attachment #162035|0 |1 is obsolete|| --- Comment #3 from Emily Lamancusa --- Created attachment 162930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162930=edit Bug 36070: Fix css class 1) Enable UseRecalls 2) Checkout an item to a patron: Top INTRA search bar: pick 'check out' and paste a patron cardnumber: 2352935676 press enter 3) Enter an item barcode: 303154 Press checkout 4) As user koha/koha, visit OPAC page for this biblio: opac-url/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Notice all sidebar actions on the right have hover effect except for 'Place recall' Apply patch, repeat test plan. Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Myka Kennedy Stephens changed: What|Removed |Added Attachment #162856|0 |1 is obsolete|| --- Comment #16 from Myka Kennedy Stephens --- Created attachment 162929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162929=edit Bug 34631: Independentbranches - Non-superuser should not be able to write Additional contents for other branches When syspref Independentbranches is enabled Non-superuser should not be able to write Additional contents for other branches To reproduce: 1- Connect to staff interface as superlibrarian 2- Enable IndependentBranches preference 3- Go to Tools -> HTML customizations 4- Crete an additional content for all libraries 5- Create or edit a borrower 5-1- Set permission for the borrower - catalogue - edit_additional_contents 4- Log in to the staff interface with the non-superlibrarian staff user 5- Go to Tools -> HTML customizations --> you can delete or edit the additional contents created by superlibrarian for All libraries 6- Click on New entry --> you can add additional content for other branches 7- Apply the patch 8- Repeat step 5 --> you cannot delete or edit the additional contents create by superlibrarian for All libraries 9- Repeat step 6 --> you cannot add additional content for other branches 10- submit the form --> the branch of the created additional content is the current user branch Signed-off-by: Myka Kennedy Stephens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Myka Kennedy Stephens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36279] New: Resending notice after changing delivery method still uses old method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36279 Bug ID: 36279 Summary: Resending notice after changing delivery method still uses old method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org If you update a patron's messaging preference, say from email to sms, then go to their sent notices and try to resend, it tries to resend using the method it used before (still email in this case). I know we fixed the notices so that if, for example, the email address is updated, when you hit resend, it sends to the new address. But changing formats doesn't seem to affect any change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Blou changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Blou --- Myka, Bug 35930 has been on the stack for a while. My grep tells me it's number 486 on the master stack. It's possible to test plenty of issue with an old master, but when it fails, it fails. The issue right now seems with your setup, I'm sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Assignee|koha-b...@lists.koha-commun |matthias.le-...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 --- Comment #14 from Myka Kennedy Stephens --- Matthias: I don't understand it either. I tried again just now. Fresh boot of Koha Testing Docker, fresh git pull, and an extra git reset just for extra measure. When I did the hard reset it said: HEAD is now at fee4368cd8 Bug 35930: Add guards for plugins_enabled Applying the patch with git bz, I get the same errors as yesterday: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt). error: could not build fake ancestor I was able to test and sign off on another patch for another bug yesterday, so I'm fairly certain the issue is with this patch and not my setup. I'm sorry I don't have any more insights than that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31572] E-mail and SMS verification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36278] New: Relabel "Gone no address"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36278 Bug ID: 36278 Summary: Relabel "Gone no address" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: sbr...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Many libraries find the "Gone no address" patron account flag awkwardly phrased/named. Perhaps "Address block", "Wrong address", "Address correction needed", or similar would more clearly indicate to library staff what this flag does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 --- Comment #13 from Matthias Le Gac --- Bug 34631 - Independentbranches - Non-superuser should not be able to write Additional contents for other branches 162856 - Bug 34631: Independentbranches - Non-superuser should not be able to write Additional contents for other branches Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34631: Independentbranches - Non-superuser should not be able to write Additional contents for other branches I have no problem to apply the patch, I don't understand your problem. Your master is up to date ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36262] Under an item's status, provide the shelving location drop down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36262 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 --- Comment #3 from Owen Leonard --- This works to display the form I think there's still a problem with the check for duplicates. I filled out the form (title, author, isbn, and year) using information from a book already in the catalog and when I submitted it I got a blank page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34962] Add a system messages feature to Koha to report issues and failures in a more visible way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34962 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #21 from Martin Renvoize --- OK, ready for testing now as a whole :) Test plan 1) Enable some items to be bookable as per the test plan for 29002 2) Click 'Place booking' on any of the biblio pages for those bilios marked bookable as above 3) Note you are now required to pick a pickup location 4) Experiment with different pickup location rules as per the holds system 5) Note that items are enabled/disabled from the item selection based on pickup location 6) Place your booking 7) Note that 'Pickup location' is now listed in the table on the 'Bookings' page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #20 from Martin Renvoize --- Created attachment 162928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162928=edit Bug 36120: Add pickup library to bookings list table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162922|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 162927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162927=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162921|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 162926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162926=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162920|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 162925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162925=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162919|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 162924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162924=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162918|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 162923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162923=edit Bug 36120: Add pickup_library_id to bookings table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162917|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 162922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162922=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162916|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 162921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162921=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162915|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 162920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162920=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162914|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 162919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162919=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #10 from Martin Renvoize --- Created attachment 162918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162918=edit Bug 36120: Add pickup_library_id to bookings table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162912|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #9 from Martin Renvoize --- Created attachment 162917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162917=edit Bug 36120: Add pickup locations to place bookings modal This patch adds a call to /biblios/biblionumber/pickup_locations to fetch valid pickup locations for the biblio. Upon selecting a pickup location we adapt the item select to only allow for selecting items returned as valid for pickup at the selected location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #8 from Martin Renvoize --- Created attachment 162916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162916=edit Bug 36120: Add pickup_library support to bookings API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #162911|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 162915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162915=edit Bug 36120: Add pickup_items to the pickup_locations response This patch adds pickup_items as a list of itemnumbers that can be picked from the library should it be selected as a pickup location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #6 from Martin Renvoize --- Created attachment 162914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162914=edit Bug 36120: Schema update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Thomas Klausner changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #2 from Thomas Klausner --- Created attachment 162913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162913=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #5 from Martin Renvoize --- I've not considered overrides really yet either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #4 from Martin Renvoize --- Still a lot to tie in here, but I wanted to put up the UI proof of concept to start facilitating feedback from Tomas and people regarding the calls to fetch pickup locations from the API. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27340] We should introduce Koha::PickupLocation(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36120 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27340 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36212] transferbook should not look for items without barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212 --- Comment #3 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36212] transferbook should not look for items without barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36212 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36134] Elasticsearch authentication using userinfo parameter crashes about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36134 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36134] Elasticsearch authentication using userinfo parameter crashes about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36134 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36056] Clarify subpermissions check behavior in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36056 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36056] Clarify subpermissions check behavior in C4::Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36056 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
