[Koha-bugs] [Bug 35989] Searching Geographic authorities generates error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35989 --- Comment #1 from Thomas Sycko --- I am able to replicate the error when searching all authorities and geographic authorities. Searching other authority types works as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35989] Searching Geographic authorities generates error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35989 Thomas Sycko changed: What|Removed |Added CC||tsy...@tswarren.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 --- Comment #22 from Myka Kennedy Stephens --- This patch works beautifully! I completed the test plan and everything worked as expected this time, very smooth. With the patch applied, the non-superlibrarian staff user can preview HTML customizations for all libraries and for other branches -- the edit and delete buttons are suppressed. This user can also edit existing content for their branch. When creating new content, the drop-down to select all libraries or a particular branch is suppressed. The user can create new content successfully and when returned to the table of all HTML customizations, the new content appears under the user's branch and has the edit and delete buttons available. Great work! Glad all the back-and-forth finally paid off and it sounds like we both learned a little in the process. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Myka Kennedy Stephens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34631] Independentbranches - Non-superuser should not be able to write Additional contents for other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34631 Myka Kennedy Stephens changed: What|Removed |Added Attachment #162972|0 |1 is obsolete|| --- Comment #21 from Myka Kennedy Stephens --- Created attachment 162995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162995=edit Bug 34631: Independentbranches - Non-superuser should not be able to write Additional contents for other branches When syspref Independentbranches is enabled Non-superuser should not be able to write Additional contents for other branches To reproduce: 1- Connect to staff interface as superlibrarian 2- Enable IndependentBranches preference 3- Go to Tools -> HTML customizations 4- Crete an additional content for all libraries 5- Create or edit a borrower 5-1- Set permission for the borrower - catalogue - edit_additional_contents 4- Log in to the staff interface with the non-superlibrarian staff user 5- Go to Tools -> HTML customizations --> you can delete or edit the additional contents created by superlibrarian for All libraries 6- Click on New entry --> you can add additional content for other branches 7- Apply the patch 8- Repeat step 5 --> you cannot delete or edit the additional contents create by superlibrarian for All libraries 9- Repeat step 6 --> you cannot add additional content for other branches 10- submit the form --> the branch of the created additional content is the current user branch Signed-off-by: Myka Kennedy Stephens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #18 from George Williams (NEKLS) --- > * Maybe a wild idea: Could we have something like a "reset to sample notice" > button? If it could get the translated version from the YAML files that > would be pretty awesome too. +1 here too. Awesome idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #17 from Lucas Gass --- > * Maybe a wild idea: Could we have something like a "reset to sample notice" > button? If it could get the translated version from the YAML files that > would be pretty awesome too. +1 to this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #16 from Katrin Fischer --- Hi all, first of all: Emily, you are awesome and we don't tell you nearly often enough! Something that hasn't come up here yet, but we need to keep in mind is translations and they complicate things a bit. We install translated notices now, which makes it much harder to tell which ones are "unchanged". And on the other side it makes it harder to insert new nice notices for everyone. It's even hard to determine which language was used when installing or which language a notice is in. Some other ideas: * Have a page on the wiki with the new nice notice sample templates, so it's easy for libraries to get them (sometimes you might just break something and want to go a step back). * Have a deprecation period for the old syntax to help people switch. I think that's almost a given. * Visually highlight notices in the old syntax that require updating? * Maybe a wild idea: Could we have something like a "reset to sample notice" button? If it could get the translated version from the YAML files that would be pretty awesome too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36290] New: Make it possible to turn off all notices for a single branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36290 Bug ID: 36290 Summary: Make it possible to turn off all notices for a single branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org An option, probably in the libraries settings, to turn of notices for a branch, even better if it's within a date range would be very helpful for library closures. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Andrew Fuerste-Henry changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 David Nind changed: What|Removed |Added Attachment #162935|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 162994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162994=edit Bug 36274: Correct links leading to purchase suggestion page To test: 1. APPLY PATCH 2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. 3. Make a suggestion and confirm it works. 4. Try to make a suggestion using title, author, isbn information from an item that already exists. 5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. 6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. 7. Do an OPAC search that will yield no results as a logged in user. 8. Click the "Make a purchase suggestion" link, making sure it works. 9. Turn on AnonSuggestions and log out of the OPAC. 10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 ByWater Sandboxes changed: What|Removed |Added Attachment #162987|0 |1 is obsolete|| --- Comment #15 from ByWater Sandboxes --- Created attachment 162993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162993=edit Bug 15461: Fix typo in system prefererence description Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 ByWater Sandboxes changed: What|Removed |Added Attachment #162982|0 |1 is obsolete|| --- Comment #14 from ByWater Sandboxes --- Created attachment 162992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162992=edit Bug 15461: perltidy DB update Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 ByWater Sandboxes changed: What|Removed |Added Attachment #162981|0 |1 is obsolete|| --- Comment #13 from ByWater Sandboxes --- Created attachment 162991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162991=edit Bug 15461: Implement StaffLocationOnDetail To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 ByWater Sandboxes changed: What|Removed |Added Attachment #162980|0 |1 is obsolete|| --- Comment #12 from ByWater Sandboxes --- Created attachment 162990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162990=edit Bug 15461: Add StaffLocationOnDetail system preference Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #9 from Matthias Le Gac --- this is the first time I do test for Koha, so let me know if there's anything to improve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #8 from Matthias Le Gac --- Created attachment 162989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162989=edit Bug 36122: add unit test Test plan : To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) 9. Apply the patch 10. now repeat steps 3 to 8 but : step 4 you have one NEW_SUGGESTION message in message_queue step 6 you have only one ACCEPTED message in message_queue step 8 you have only one ORDERED message in message_queue The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on each steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 ByWater Sandboxes changed: What|Removed |Added Attachment #162983|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 162988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162988=edit Bug 35796: Properly set patron_expiration value To test: 1) Set an expiration on the password in a patron account and save. 2) Go to patron details (moremember.pl) and confirm the password has an expiration. 3) Edit the patron account without touching anything and save the account. 4) Go back to patron details (moremember.pl) and note that the expiration on the password has been removed. 5) APPLY PATCH 6) Try 1 - 4 again except this time password expiration is not removed. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #23 from Lisette Scheer --- I can't apply one of the dependencies: Applying: Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook error: sha1 information is lacking or useless (Koha/Template/Plugin/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #11 from Lucas Gass --- Created attachment 162987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162987=edit Bug 15461: Fix typo in system prefererence description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36177] We need integration tests to cover csrf checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #11 from David Nind --- Testing notes (using KTD): 1. Ran cypress tests before applying the patches: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only 2. Ran the tests again after patches applied (I think I did a yarn there as well to add the new module/package, but I did a reset_all and shut down KTD and restarted as well - not sure of the correct way to do this). Results after patches applied: Spec Tests Passing Failing Pending Skipped ┌┐ │ ✔ InfiniteScrollSelect_spec.ts 00:1444 --- │ ├┤ │ ✔ KohaTable_spec.ts00:0311 --- │ ├┤ │ ✔ Auth/csrf.ts 00:1866 --- │ ├┤ │ ✔ ERM/Agreements_spec.ts 00:3155 --- │ ├┤ │ ✔ ERM/DataProviders_spec.ts00:49 13 13 --- │ ├┤ │ ✔ ERM/Dialog_spec.ts 00:1144 --- │ ├┤ │ ✔ ERM/Licenses_spec.ts 00:2155 --- │ ├┤ │ ✔ ERM/Packages_spec.ts 00:2255 --- │ ├┤ │ ✔ ERM/Searchbar_spec.ts00:1144 --- │ ├┤ │ ✔ ERM/Titles_spec.ts 00:3466 --- │ ├┤ │ ✔ ERM/UsageReports_spec.ts 00:42 13 13 --- │ ├┤ │ ✔ ERM/UserRoles_spec.ts00:0311 --- │ ├┤ │ ✔ Preservation/Settings.ts 00:1555 --- │ ├┤ │ ✔ Preservation/Trains.ts 00:2088 --- │ ├┤ │ ✔ Preservation/WaitingList.ts 00:0833 --- │ └┘ ✔ All specs passed!05:09 83 83 --- Done in 349.96s. all good Running [koha-shell kohadev -c "touch testing.success"]... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36177] We need integration tests to cover csrf checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177 David Nind changed: What|Removed |Added Attachment #162576|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 162986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162986=edit Bug 36177: Add Cypress tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36177] We need integration tests to cover csrf checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177 David Nind changed: What|Removed |Added Attachment #162533|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 162985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162985=edit Bug 36177: Cypress tests - cypress-mysql config Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36177] We need integration tests to cover csrf checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177 David Nind changed: What|Removed |Added Attachment #162532|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 162984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162984=edit Bug 36177: Cypress tests - yarn add cypress-mysql Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36177] We need integration tests to cover csrf checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36177 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch --- Comment #4 from Lucas Gass --- Trivial fix but this bug can result in some data loss, correctly set as major. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 --- Comment #3 from Lucas Gass --- Created attachment 162983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162983=edit Bug 35796: Properly set patron_expiration value To test: 1) Set an expiration on the password in a patron account and save. 2) Go to patron details (moremember.pl) and confirm the password has an expiration. 3) Edit the patron account without touching anything and save the account. 4) Go back to patron details (moremember.pl) and note that the expiration on the password has been removed. 5) APPLY PATCH 6) Try 1 - 4 again except this time password expiration is not removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29941] Automatic item modification by age should be able to set a value to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29941 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36289] New: Allow automatic item modification by age to set a date field to today's date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36289 Bug ID: 36289 Summary: Allow automatic item modification by age to set a date field to today's date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be helpful if automatic item modification by age could set a date field to today's date. Example: Age in days: 60 Age field: items.itemlost_on Conditions: items.itemlost=5 Substitutions: items.itemlost=6 items.itemlost_on=Today Or, if you want to update the date accessioned to the first day it was circulating, you could set up a custom damaged status to put items in before they go to circulate: Age in days: 1 Age field: items.itemdamaged_on Conditions: items.itemdamaged=3 Substitutions: items.itemdamaged=0 items.dateaccessioned= Today's date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 --- Comment #2 from Andrew Fuerste-Henry --- Filed Bug 36288 for the fact that BorrowerUnwantedField doesn't hide password expiration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36288] New: Password expiration date cannot be hidden with BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36288 Bug ID: 36288 Summary: Password expiration date cannot be hidden with BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The password expiration date field is hardcoded to only show in the patron edit screen for superlibrarians. It continues to appear for superlibrarians, even if selected in the BorrowerUnwantedField system preference. We should either make this field observe the BorrowerUnwantedField syspref or remove it from the list of fields in the syspref. Tangentially, that field is currently failing to load the patron's current password expiration date into the edit form, so the date is lost when the patron is saved. That's bug 35796. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36288 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #10 from Lucas Gass --- Created attachment 162982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162982=edit Bug 15461: perltidy DB update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #9 from Lucas Gass --- Created attachment 162981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162981=edit Bug 15461: Implement StaffLocationOnDetail To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #8 from Lucas Gass --- Created attachment 162980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162980=edit Bug 15461: Add StaffLocationOnDetail system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Patron password expiration |Patron password expiration |arbitrarily changes when|date lost when patron |account edited |edited by superlibrarian CC||andre...@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- We just noticed some missing password expiration dates and I think I see what's happening. It's important to note that the password expiration date is field is only shown and editable in the patron record if one is a superlibrarian. To recreate: - have a patron with a password expiration date - log into Koha on an account that can search and edit patrons but is not a superlibrarian - Edit the patron, confirm that password expiration date is included in the edit form, save your changes - confirm your patron still has a password expiration date - log into Koha as a superlibrarian - Edit the patron, confirm the password expiration date field is included in the patron edit form, but loads without a value. Do not add a date or click into this field. - Save the patron - confirm the patron no longer has a password expiration date I'm not sure why the expiration date value doesn't load when editing a patron, it appears that it is intended to: https://github.com/Koha-Community/Koha/blob/4032da3f964f438e913ed19d40b0b73aa4bd2533/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt#L1347 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33312] Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35394] Correct the message displayed when attempting to checkout an item during it's booking period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes the logic and release notes||message displayed if you ||try to check out an item ||where there is a booking. ||Now you cannot check out an ||item where there is a ||booking, and the message ||displayed is: "The item is ||booked for another patron". --- Comment #5 from David Nind --- Testing notes (using KTD): 1. To make an item bookable: 1.1 In the staff interface, go to the details page for a record with items. 1.2 Click on the 'Items' tab. 1.3 For an item, change 'Bookable' to 'Yes' and click on 'Update'. 1.4 Go back to the normal tab for the record. 2. To place a booking - click on the "Place booking" button for a record. 3. SQL to update the booking start date (adjust start_date and booking_id as appropriate): 3.1 Access the database: koha-mysql kohadev 3.2 SQL query: update bookings set start_date="2024-03-08 11:00:00" where booking_id=1; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35394] Correct the message displayed when attempting to checkout an item during it's booking period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 David Nind changed: What|Removed |Added Attachment #162973|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 162979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162979=edit Bug 35394: Correction to booked items logic This patch fixes the overly extreme message that was designed to appeared when someone tried to check out a booked item to the wrong user. However, the message never appeared due to a logic error within CanBookBeIssued which this patch also resolved. Test plan 1) Make an item bookable 2) Add a booking for the item to patron A from tomorrow 3) In the database, update the booking start_date to today (or wait a day before the next step) 4) Attempt to check the book out to patron B. Note that you are displayed with the new message 'The item is booked for another patron' and you are unable to check the item out. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35394] Correct the message displayed when attempting to checkout an item during it's booking period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35394 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36235] System preferences chopping everything after a semicolon.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36235 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21173] Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36287] Ability to view both the budget name and budget code in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36287 Laura Escamilla changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36287] Ability to view both the budget name and budget code in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36287 --- Comment #1 from Laura Escamilla --- Created attachment 162978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162978=edit Bug 36287: Add budget code to fund column in acq basket table Trivial patch is attached. I'm open for discussing whether this would work better as a system preference so that libraries could decide whether they would like to see only the fund name, code, or both. To test: 1. Create a basket and add an item. Notice that the fund column in the basket table only displays the budget name. 2. Apply the patch. 3. Refresh the page and note that the fund column now displays both the budget name and budget code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36287] Ability to view both the budget name and budget code in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36287 Laura Escamilla changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36287] New: Ability to view both the budget name and budget code in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36287 Bug ID: 36287 Summary: Ability to view both the budget name and budget code in a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some libraries have expressed interest in seeing both the budget name and code in the basket table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34472] Template Toolkit reference guide needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 --- Comment #8 from Emily Lamancusa --- Some thoughts / useful information I've come across while digging into the code to figure out what bug 15278 will entail: (This is mostly answering the questions of "what information do we need to provide to users?" and "where can we find this information in the code if it isn't well documented?") - To get a list of what TT objects are available to notices in general, possible places to look are two subs in C4::Letters: _get_tt_params and _parseletter_sth. ~ Near the beginning of _get_tt_params, a $config variable is defined that maps database table names to Template Toolkit variable names. ~ _parseletter_sth actually prepares (and caches?) database queries for notices ~ These two subs aren't 100% in sync with each other, though (I haven't dug quite deep enough to be sure if that's a bug in and of itself) - To know which specific tables a specific notice has access to, I believe one way to do that would be to find the GetPreparedLetter call for that notice. A list of tables is passed as a parameter. (git grep is your friend here) - Due, Predue, and Overdue notices might be weird - they have some custom handling in advance_notices.pl and overdue_notices.pl. There are also a few other notices that have weird custom things that aren't handled yet in Template Toolkit syntax. (See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278#c11) - Some Koha-specific TT things that aren't tied to a particular table that we should include: ~ accessing today's date ~ formatting a date ~ I feel like I've seen some environment context / syspref configuration things getting used in notices before? - We should include an explanation of how a TT variable can be singular or plural, and when and how to use each. (Is there any situation where we'd use the plural, other than a FOREACH loop or a count?) - We definitely need to make sure the '' syntax for digest notices is documented, and probably include an explanation of when to use '' and when to use a FOREACH. - I believe any database field in a given table is accessible as a variable in notices that have access to that table? If I'm correct in that, it would be really useful for the Template Toolkit documentation to link to the schema page for the relevant tables. - Ideally, it would be a nice idea to include some very basic, layman-friendly TT info as a starting point for users who may not have a programming background or experience reading technical documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Maude changed: What|Removed |Added CC||maude.boudr...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 Tomás Cohen Arazi changed: What|Removed |Added Attachment #162748|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 162977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162977=edit Bug 34755: Backport Koha::Token change from bug 34478 This change includes the Koha::Token changes which uses Koha::Session for generating and checking CSRF tokens. 0. Apply the patch and koha-plack --restart kohadev 1. Setup Keycloak OIDC SSO according to "Testing SSO" wiki guide 2. In a regular window go to http://localhost:8080 3. In a private window go to http://localhost:8080 and click the SSO "Log in with..." button, but don't log into Keycloak 4. In the regular window, login locally, and navigate to 5-6 pages 5. In the private window, log into Keycloak 6. Note that you are redirected back to Koha and logged in successfully (no wrong_csrf_token error). Signed-off-by: Olivier Hubert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #33 from Tomás Cohen Arazi --- Applied fine on top of 36098. QA script happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36098] Create Koha::Session module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #19 from Tomás Cohen Arazi --- This applies nicely on 23.11.x and works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35759] Preservation module home yields a blank page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35759 --- Comment #8 from Tomás Cohen Arazi --- *** Bug 36250 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36250] Add preservation.js to Makefile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36250 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- It seems a fix for this has just been pushed, Kyle. Thanks for taking care anyway! *** This bug has been marked as a duplicate of bug 35759 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #15 from Christopher Brannon --- (In reply to Emily Lamancusa from comment #14) > (In reply to Christopher Brannon from comment #13) > > Could you keep the old syntax functional for existing users and give them a > > version or two to update their notices/slips? Maybe only change the default > > notices that have not been modified from install? It seems reasonable to > > give existing users time to clean up their own notices with the new tools. > > That way, if there are any complications or something missed, they some > > wiggle room before the old stuff goes away. > > Yes, that's basically the idea. The old syntax will still be fully > functional for now. We have Bug 15279 to remove the functionality > eventually, but that bug is blocked and won't happen until after we update > the installation defaults (this bug), create a reference guide (bug 34472), > and improve the notice editor (bug 15277) so that users actually have the > tools to make good use of Template Toolkit syntax. > > The questions I'm trying to get at now are: > 1) If a library hasn't modified a particular notice from install, should we > still make them responsible for updating it themselves, or should we update > it automatically in that case (since it should be relatively straightforward > to check for the old default template and replace it with the new default > template)? > > 2) If we do update it automatically, should we do it now, or wait until the > old syntax actually becomes nonfunctional? 1) You should update it automatically if it hasn't been modified. 2) Right away. This gives people more exposure to how it is used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #14 from Emily Lamancusa --- (In reply to Christopher Brannon from comment #13) > Could you keep the old syntax functional for existing users and give them a > version or two to update their notices/slips? Maybe only change the default > notices that have not been modified from install? It seems reasonable to > give existing users time to clean up their own notices with the new tools. > That way, if there are any complications or something missed, they some > wiggle room before the old stuff goes away. Yes, that's basically the idea. The old syntax will still be fully functional for now. We have Bug 15279 to remove the functionality eventually, but that bug is blocked and won't happen until after we update the installation defaults (this bug), create a reference guide (bug 34472), and improve the notice editor (bug 15277) so that users actually have the tools to make good use of Template Toolkit syntax. The questions I'm trying to get at now are: 1) If a library hasn't modified a particular notice from install, should we still make them responsible for updating it themselves, or should we update it automatically in that case (since it should be relatively straightforward to check for the old default template and replace it with the new default template)? 2) If we do update it automatically, should we do it now, or wait until the old syntax actually becomes nonfunctional? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919
--- Comment #26 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #24)
> I don't understand why you stubborn and obstinate to do things differently.
> I have said that 10x on bug 32607, then here again.
Maybe because some things didn't exist when this was submitted in the first
place? Or maybe some things were rewritten by the time this got (finally) some
eyes on it.
I really thought I had covered all the remaining things. I removed all of the
contentious snippets.
I will try to understand your concerns. Vue is not my whellhouse. This is the
first time I work with Vue, trying to help someone else's dev to move forward.
And even learnt Cypress and wrote the darn tests for a trivial CRUD page!
> 1. computed title instead of the logic in template
> 2. retrieving the client api from setup()
> 3. _has_value should not be needed, we have form validation already
> 4. you should clean the api-client, why do you deal with headers and json
> stringify? we don't need it in other places!
> 5. in the routes:
> BeforeUnloadEvent() {
> window.location.href = "/cgi-bin/koha/admin/admin-home.pl";
> },
> Why?
> 6. Why do you name the add/edit component "Edit" when all others are named
> "AddForm"?
>
> 7. Why calling the client api this way:
> .then(() => something())
> when all existing occurrences do:
> .then(
> success => something(),
> error => {},
> );
> 8.Edit.vue
> Object.keys(response).forEach(key => {
> this.row[key] = response[key]
> })
> What's the point of this??
>
> Some are blocker, some are weirdness, others are better than what exist but
> different.
>
> I let you decide the status of this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #68 from Katrin Fischer --- I looked into this again: my problem is a "could not build fake ancestor" on bug 35782 right at the top of this tree. As it all still applies for you, maybe you could reattach the patches there for me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Can I please get a rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35782: Replace TT plugin's method Biblio::HoldsCount Applying: Bug 35782: Fix scoping problem with "biblio" error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). error: could not build fake ancestor Patch failed at 0001 Bug 35782: Fix scoping problem with "biblio" hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-35782-Fix-scoping-problem-with-biblio-wq6ym53n.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103 --- Comment #11 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36070] "Place recall" hover styling on OPAC not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36070 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36070] "Place recall" hover styling on OPAC not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36070 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36066] REST API: We should only allow deleting cancelled order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36066 --- Comment #25 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36066] REST API: We should only allow deleting cancelled order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36066 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36032] The "Next" pagination button has a double instead of a single angle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36032] The "Next" pagination button has a double instead of a single angle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35983] Library specific refund lost item replacement fee cannot be 'refund_unpaid'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35983] Library specific refund lost item replacement fee cannot be 'refund_unpaid'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #11 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 --- Comment #39 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35538] List of libraries on OPAC self registration form should sort by branchname rather than branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35538 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35538] List of libraries on OPAC self registration form should sort by branchname rather than branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35538 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36066] REST API: We should only allow deleting cancelled order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36066 --- Comment #24 from Katrin Fischer --- Thanks for also fixing POD :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35983] Library specific refund lost item replacement fee cannot be 'refund_unpaid'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Katrin Fischer changed: What|Removed |Added Summary|Branch specific Refund lost |Library specific refund |item replacement fee cannot |lost item replacement fee |be 'refund_unpaid' |cannot be 'refund_unpaid' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36103] Remove the "Cancel hold" link for item level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36103 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --- Comment #10 from Katrin Fischer --- Can we add the conclusion of the discussion to the release notes please? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 --- Comment #11 from Katrin Fischer --- Looking at this I was wondering, if moving from .pm to .pl is really the right move here concerning the API. Digging a little deeper, I think we are using AddIssue without CanBookBeIssued in the API, so this would not cause a change. I'll push, but leaving this note here in case I missed something in my line of thinking! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #13 from Christopher Brannon --- (In reply to Emily Lamancusa from comment #12) > One more thing to consider: do we just update the default text in > sample_notices.yml for new installations at this point, or do we also > include dbrevs for existing installations that use the default notice text? > > Normally, we don't update the default notice text for existing installations > unless there is a breaking change. However, since the goal is to eventually > deprecate the old syntax, which will be a breaking change, it might be > better to update the defaults on both new and existing installations > together... It will be unavoidable for libraries with customized notices to > need to update their own notices eventually. However, I'm sure there are > libraries who rely on the default notices and may not be familiar with > customizing their notices at all, and I could see it being a major issue if > a large number of their notices, which they haven't touched, stop working. > > One could argue that we should wait until we actually introduce the breaking > change to update the default notice text on existing installations, but IMO > it makes more sense to do it now rather than tracking down what the default > used to be sometime later. (Granted, we will still probably miss some > installations that have older "default" versions of notices whose defaults > have already been changed in the past, but I still think we should prevent > problems as much as we can now.) > > The downside is that it makes the current task harder, and introduces a > chance of bugs/regressions...but I still think it's worth it to avoid even > more difficulties later. Could you keep the old syntax functional for existing users and give them a version or two to update their notices/slips? Maybe only change the default notices that have not been modified from install? It seems reasonable to give existing users time to clean up their own notices with the new tools. That way, if there are any complications or something missed, they some wiggle room before the old stuff goes away. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
