[Koha-bugs] [Bug 36312] Authorities Z39.50 missing Subject-heading 21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36312 David Cook changed: What|Removed |Added Summary|Koha Z39.50 missing |Authorities Z39.50 missing |Subject-heading 21 |Subject-heading 21 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36312] New: Koha Z39.50 missing Subject-heading 21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36312 Bug ID: 36312 Summary: Koha Z39.50 missing Subject-heading 21 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl If you do a 1=21 (ie Subject-heading) Z39.50 search against Koha's authority database, you won't get a result. There's a few reasons for this. If using Zebra: - /etc/koha/zebradb/authorities/etc/bib1.att is missing a line like “att 21 Subject-heading” - /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl isn’t indexing the 150 field into the “Subject-heading” index If using z3950_responder.pl with Elastic, ./etc/z3950/attribute_mappings.yaml doesn't have an appropriate mapping. At a glance, I don't see a subject specific index for subject authorities either in ./admin/searchengine/elasticsearch/mappings.yaml If using z3950_responder.pl with Zebra, then it's the same problem as if you were just using Zebra. -- At the moment, I'm concerned with Zebra, but I'll want to look at Elastic at some point... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #163128|0 |1 is obsolete|| --- Comment #6 from Nicholas van Oudtshoorn --- Created attachment 163129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163129=edit Patch to redirect on login A quick patch which enables this. This also strips out the logout parameter from the referring URI, so that we don't end up in a loop. It also checks that the referring URI is part of the koha installation, and if not goes to either the main page or the user page. (Obsoleting old patch which I managed to mangle!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 Nicholas van Oudtshoorn changed: What|Removed |Added Attachment #163127|0 |1 is obsolete|| --- Comment #5 from Nicholas van Oudtshoorn --- Created attachment 163128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163128=edit Redirect to referring URL, excluding logout parameters A quick patch which enables this. This also strips out the logout parameter from the referring URI, so that we don't end up in a loop. It also checks that the referring URI is part of the koha installation, and if not goes to either the main page or the user page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Cook --- opac/cgi-bin/opac/svc/auth/googleopenidconnect is not a valid Koha path in the git. It also looks like this is based off a different version of ./opac/svc/auth/googleopenidconnect than what exists in Koha's master branch. I think too the goal is to deprecate and remove ./opac/svc/auth/googleopenidconnect in favour of the new generic OIDC functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34164] OAuth2/OIDC should redirect to page that initiated login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 Nicholas van Oudtshoorn changed: What|Removed |Added CC||vano...@gmail.com Assignee|koha-b...@lists.koha-commun |vano...@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #3 from Nicholas van Oudtshoorn --- Created attachment 163127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163127=edit Return to the referring URL when signing in using GoogleOpenID Just threw together a quick patch which enables this. This also strips out the logout parameter from the referring URL, so that we don't end up in a loop. It would be good to also check that the referring URI is part of the koha installation, and if not go to the main library page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 Danyon Sewell changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 Danyon Sewell changed: What|Removed |Added Attachment #163125|0 |1 is obsolete|| --- Comment #2 from Danyon Sewell --- Created attachment 163126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163126=edit Bug 36311: Add option to koha-run-backups, to only include database dump Updated patch logic to work better and zip up the database files and actually include table data instead of just the schema. Test plan: 1. Dry run koha-run-backups, to verify that both the .sql.gz and .tar.gz backups are included 2. Apply this patch 3. Run the script again, this time with the --db-only-zip flag 4. check /var/spool/koha/kohadev/ to see that only .sql.gz file has been included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 --- Comment #1 from Danyon Sewell --- Created attachment 163125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163125=edit Bug 36311: Add option to koha-run-backups, to only include database dump Test plan: 1. Dry run koha-run-backups, to verify that both the .sql.gz and .tar.gz backups are included 2. Apply this patch 3. Run the script again, this time with the --schema-only flag 4. check /var/spool/koha/kohadev/ to see that only .sql.gz file has been included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 Danyon Sewell changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 Danyon Sewell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36311] New: Add option to koha-run-backups, to only include database dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311 Bug ID: 36311 Summary: Add option to koha-run-backups, to only include database dump Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: danyonsew...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Adding an additional flag to koha-run-backups when used to exclude everything except the .sql.gz DB dump from koha-dump. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36304] Update C4::Auth in_iprange function to work when Koha is hosted behind a cloudflare proxy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36304 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Cloudflare is just a reverse proxy like any other, so it will pass the client's IP in the X-Forwarded-For header. This means that you should be able to use "koha_trusted_proxies" in koha-conf.xml to handle this scenario. This also means REMOTE_ADDR will be the client's IP for other IP-based scenarios like ILS-DI, logging, etc. Cloudflare provides a list of their public IP addresses at https://www.cloudflare.com/en-gb/ips/ -- If you did want to use HTTP_CF_CONNECTING_IP specifically, you could look at modifying Koha/Middleware/RealIP.pm But since CF_CONNECTING_IP is user-supplied you would still want to validate the REMOTE_ADDR against the list of Cloudflare's IP addresses. Otherwise, anyone could stick their own reverse proxy in front of your Koha and pretend to be someone else by inserting their own header. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36306] Make Koha UserName configurable how it is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36306 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36310] New: Add Course reserves API to facilitate the manipulation and display of data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36310 Bug ID: 36310 Summary: Add Course reserves API to facilitate the manipulation and display of data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org This would be helpful for discovery layers with partners that use course reserves, as well as leaving options for using the API to increase speed when loading large tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #6 from David Nind --- I'm getting a sha1/fake ancestor error when trying to apply the patch: Applying: Bug 36190: To not assume op is invalid if it is a TT variable error: sha1 information is lacking or useless (xt/find-missing-op-in-forms.t). error: could not build fake ancestor Patch failed at 0001 Bug 36190: To not assume op is invalid if it is a TT variable ... Testing notes - how I planned to test: 1. Run the tests before the patch is applied: prove xt/find-missing-op-in-forms.t 2. Apply the first patch and run the tests: tests should fail 3. Apply the rest of the patches and run the tests: tests should pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 David Cook changed: What|Removed |Added Blocks||36195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 [Bug 36195] CSRF - testing reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36195] CSRF - testing reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 David Cook changed: What|Removed |Added Depends on||34478 --- Comment #13 from David Cook --- (In reply to Fridolin Somers from comment #12) > Depends on Bug 34478 no ? Yep. I've just added as dependency. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 David Cook changed: What|Removed |Added Blocks||36193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36193 [Bug 36193] CSRF - Code review missed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36193] CSRF - Code review missed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36193 David Cook changed: What|Removed |Added Depends on||34478 --- Comment #27 from David Cook --- (In reply to Fridolin Somers from comment #26) > Depends on Bug 34478 no ? Yep. I've just added it as a dependency. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- That api_auth() function... yikes. One day we'll do better at AuthN and AuthZ... This looks like an easy win. I'll look at QAing it a bit later this morning... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. Before the patch, the message was: Invalid parameter passed, categorycode=POT does not exist 2. After patch - no changes to parameters: ERROR: 'ATO' is not valid for the 'branchcode' field Possible values are: CPL, FFL, FPL, FRL, IPT, LPL, MPL, PVL, RPL, SPL, TPL, UPL 3. After patch - change branchcode to valid value: ERROR: 'ATO' is not valid for the 'branchcode' field Possible values are: CPL, FFL, FPL, FRL, IPT, LPL, MPL, PVL, RPL, SPL, TPL, UPL 4. After path - change categorycode to valid value: no output, successfully adds user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 David Nind changed: What|Removed |Added Attachment #163118|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 163124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163124=edit Bug 36309: Make create_superlibrarian.pl output more useful In situations in which you are not familiar with all the Koha settings, and table structure, the fact this script just fails telling there's a broken FK is just not practical. We should capture those exceptions and display a useful message instead. This script does that. It adds some validations and some exception handling too. It prints a nice message about the bad value the user passed, and the valid values too! To test: 1. Run this on a fresh KTD: $ ktd --shell k$ perl misc/devel/create_superlibrarian.pl \ --userid tcohen \ --password tomasito \ --cardnumber 123456789 \ --categorycode POT \ --branchcode ATO => FAIL: It explodes with a MySQL exception message! 2. Apply this patch 3. Repeat 1 => SUCCESS: It tells you which value is wrong and what values you can pick to make the command work 4. Pick a valid value, and repeat => SUCCESS: Now the other value is wrong, a nice message is displayed! 5. Fix with a valid value and repeat => SUCCESS: Patron created! 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 David Nind changed: What|Removed |Added Attachment #163117|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 163123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163123=edit Bug 36308: Update sip login parameters To test: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login fails Apply patch, restart all perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login succeeds Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 David Nind changed: What|Removed |Added Attachment #163121|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 163122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163122=edit Bug 36302: Revert back to POST Pass the csrf token and 'cud-noop' After having discussed with Joubu and multiple failed attempts at fixing the issue AND restoring previous behavior, this is the fix we agreed on. This will change URL but not fiddle with browser history. Works the same (and as expected) in both Chrome and Firefox Test plan, ktd: 1) Search henry on the top search bar, notice 1 result is auto suggested 2) Ignore the auto-complete, press 'Enter' instead 3) Notice no results are returned. 4) Apply patch. Repeat. 5) Notice you get redirected to the single result of henry 6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox) 7) Visit patrons home directly: http://localhost:8081/cgi-bin/koha/members/members-home.pl 8) Notice no search is performed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Victor Grousset/tuxayo --- commit: > Fix width and enable clear option Unfortunately that sets in stone the width at page load. Any resizing of the width of the page will have the Vendor stay at the same width while the other filter are responsive. --- > 8 - Note only a partial list of vendors is loaded, confirm current vendor > still selected No, all my 31 vendors are there. Any additional reproduction step? > In a system with many vendors this can cause slowness or crashes. Neither a sign of that on my slowass PC @Lisette Did you witness any bad behavior without the patch? To confirm it fixes it. @Nick do you have a customer instance that had issue fixed by the patch. --- Otherwise, code looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Lucas Gass changed: What|Removed |Added Attachment #163113|0 |1 is obsolete|| --- Comment #22 from Lucas Gass --- Created attachment 163121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163121=edit Bug 36302: Revert back to POST Pass the csrf token and 'cud-noop' After having discussed with Joubu and multiple failed attempts at fixing the issue AND restoring previous behavior, this is the fix we agreed on. This will change URL but not fiddle with browser history. Works the same (and as expected) in both Chrome and Firefox Test plan, ktd: 1) Search henry on the top search bar, notice 1 result is auto suggested 2) Ignore the auto-complete, press 'Enter' instead 3) Notice no results are returned. 4) Apply patch. Repeat. 5) Notice you get redirected to the single result of henry 6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox) 7) Visit patrons home directly: http://localhost:8081/cgi-bin/koha/members/members-home.pl 8) Notice no search is performed Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- Looks good, I added a follow to fix the file permission for installer/data/mysql/atomicupdate/bug_36101.pl and perltidy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g --- Comment #3 from Kristi --- For us (one of the ByWater libraries), we would picture this as tied in to the circulation rules for item types. We have item types set up for the portions of our collection that can be booked. A kit that staff book for story hours, for example, has an item type of Staff Program Support and that item type has its own circ period (1 day plus built in prep time from the booking module) and number of renewals allowed (0). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22403] Temporary Card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22403 Dave changed: What|Removed |Added CC||ddagh...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 --- Comment #3 from Lucas Gass --- Created attachment 163120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163120=edit Bug 36101: (follow-up) Fix DBUpdate file permission and perltidy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Lucas Gass changed: What|Removed |Added Attachment #163087|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 163119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163119=edit Bug 36101: Drop constraint to items.itemnumber from old_reserves-table Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #21 from Christopher Brannon --- We seem to have lost Sam on this conversation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35370] There should be a system preference to disable checking for holds when issuing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370 --- Comment #4 from Mike Barrette --- We are interested in this at OSLRI as well. As long as the hold Koha is warning about is not an already waiting hold for another patron. We would still want the warning if a waiting hold is checked out to a different patron (family member pickup), with options to cancel or revert waiting status. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22403] Temporary Card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22403 --- Comment #3 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > (In reply to Christopher Brannon from comment #0) > > We are CONSTANTLY having to write out patron card numbers on post-its for > > patrons that forgot their library cards. > > I'm curious about the use case in your library. What do they need their > number for? Primarily for what Lisette mentioned, but sometimes patrons want it so they can do the self check rather than hold up a staff member, or they want to login on a catalog to place holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35370] There should be a system preference to disable checking for holds when issuing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370 Mike Barrette changed: What|Removed |Added CC||mbarre...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36154] Add images to the lists and loan histories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #23 from Esther Melander --- The change to Date acquired looks fine. Setting the sort to Date acquired in the list edit screen does seem to sort correctly. I had one bibliographic record with two items with different dates. The list sorted correctly even though the one item was acquired earlier than the other. For example, the top bibliographic record had items with dates acquired that looked like this: 09/04/2014 09/10/2020 The second bibliographic record had an item with this date: 03/17/2016 This sorting is correct since the bibliographic record with the newest item (09/10/2020) is at the top of the list. But is it confusing if the dates themselves are still out of order? Bibliographic records with multiple copies acquired at different times add to the appearance of an incorrect sort. Is there a way to deal with multiple copies acquired at different times. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 --- Comment #2 from Tomás Cohen Arazi --- Comment for QA: I'm not 100% happy with our exception system as there's no consistent way to implement this without several manual checks and disambiguations... and disabling STDERR warns at DBIx::Class level to avoid noise for the end user. That said, it is a discussion to have on another report. And the extra checks inside a transaction I implemented here cause no harm either. I think the benefits are worth the (tiny) extra overhead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 163118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163118=edit Bug 36309: Make create_superlibrarian.pl output more useful In situations in which you are not familiar with all the Koha settings, and table structure, the fact this script just fails telling there's a broken FK is just not practical. We should capture those exceptions and display a useful message instead. This script does that. It adds some validations and some exception handling too. It prints a nice message about the bad value the user passed, and the valid values too! To test: 1. Run this on a fresh KTD: $ ktd --shell k$ perl misc/devel/create_superlibrarian.pl \ --userid tcohen \ --password tomasito \ --cardnumber 123456789 \ --categorycode POT \ --branchcode ATO => FAIL: It explodes with a MySQL exception message! 2. Apply this patch 3. Repeat 1 => SUCCESS: It tells you which value is wrong and what values you can pick to make the command work 4. Pick a valid value, and repeat => SUCCESS: Now the other value is wrong, a nice message is displayed! 5. Fix with a valid value and repeat => SUCCESS: Patron created! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Blocks||36087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36087 [Bug 36087] Editing dates of a booked items causes failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36087] Editing dates of a booked items causes failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36087 Martin Renvoize changed: What|Removed |Added Depends on||29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36087] Editing dates of a booked items causes failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36087 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34472] Template Toolkit reference guide needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] New: create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 Bug ID: 36309 Summary: create_superlibrarian.pl output could be more helpful Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz This helpful script could provide better output instead of just exploding. For instance, it could display the valid values for branchcode and categorycode in the event of a broken FK while creating the patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #1 from Lisette Scheer --- Could we do this with codemirror support similar to the reports? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36102] Protect login forms from CSRF attacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102 Nick Clemens changed: What|Removed |Added Blocks||36308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 [Bug 36308] SIP2 login broken by CSRF changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 Nick Clemens changed: What|Removed |Added Depends on||36102 CC||jonathan.dru...@gmail.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | --- Comment #2 from Nick Clemens --- Probably we also need test coverage for this login Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102 [Bug 36102] Protect login forms from CSRF attacks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 --- Comment #1 from Nick Clemens --- Created attachment 163117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163117=edit Bug 36308: Update sip login parameters To test: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login fails Apply patch, restart all perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron=koha Login succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36308] New: SIP2 login broken by CSRF changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36308 Bug ID: 36308 Summary: SIP2 login broken by CSRF changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org bug 36102 changed the login parameters from 'userid'/'password' to 'login_userid'/'login_password' SIP authentication was missed in the update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 --- Comment #1 from Kyle M Hall --- Created attachment 163116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163116=edit Bug 36307 - SMS::Send driver errors are not captured and stored If an SMS::Send driver succeeds, it returns a value that evaluates to true. Every driver I've inspected uses croak when it encounters a failure state. When an SMS message fails to send, code hard codes the failure code to NO_NOTES (No notes from SMS driver). We should store the real error in `failure_code` and display that if the failure code doesn't match a known failure code. Test Plan: 1) Apply this patch 2) Set SMSSendDriver to any value 3) Generate a pending sms message 4) Run the following query: update message_queue set status = 'failed', failure_code = "This is a test"; 5) View the patron's messages, note the delivery note contains the contents of the failure code 6) Run the following query: update message_queue set status = 'failed', failure_code = "SMS_SEND_DRIVER_MISSING"; 7) Reload the patron's messages, not the delivery note is now "The SMS driver could not be loaded". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36307] New: SMS::Send driver errors are not captured and stored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 Bug ID: 36307 Summary: SMS::Send driver errors are not captured and stored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If an SMS::Send driver succeeds, it returns a value that evaluates to true. Every driver I've inspected uses croak when it encounters a failure state. When an SMS message fails to send, code hard codes the failure code to NO_NOTES (No notes from SMS driver). We should store the real error in `failure_code` and display that if the failure code doesn't match a known failure code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36270] Remove special handling for <>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36130] ILL batches table not showing all batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim changed: What|Removed |Added Keywords||rel_23_11_candidate --- Comment #12 from Pedro Amorim --- (In reply to Fridolin Somers from comment #11) > Depends on Bug 36241 not in 23.11.x Hey, sorry Frido I added the dependency because at the time I submitted the bug bug 36241 was required to follow the test plan. This actually depends on bug 30719 which is in 23.11.x so this should ideally be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36306] New: Make Koha UserName configurable how it is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36306 Bug ID: 36306 Summary: Make Koha UserName configurable how it is created Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice to allow libraries to configure how the Koha User Name is created in the system. Libraries have many different ways they use this field, such as patron-picked user name, card number, firstname.lastname, or a totally different value. This would be a nice system preference to allow libraries to identify which works for their library and also would be nice to have it as a patron category choice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 --- Comment #2 from Kyle M Hall --- Created attachment 163115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163115=edit Bug 36305: Implement op paramters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 --- Comment #1 from Kyle M Hall --- Created attachment 163114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163114=edit Bug 36305: Tidy forms -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36291] Scrolling glitch on ILL batches table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36291 --- Comment #4 from Pedro Amorim --- Can reproduce (only on Firefox tho, it doesn't happen in Chrome). Firefox throws this console entry: This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.html for further details and to join the discussion on related tools and features! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12723] Add separate fee for renewal of rental items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12723 JR changed: What|Removed |Added CC||jrudisill@cityofchesapeake. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Pedro Amorim changed: What|Removed |Added Attachment #163108|0 |1 is obsolete|| Attachment #163109|0 |1 is obsolete|| --- Comment #21 from Pedro Amorim --- Created attachment 163113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163113=edit Bug 36302: Revert back to POST Pass the csrf token and 'cud-noop' After having discussed with Joubu and multiple failed attempts at fixing the issue AND restoring previous behavior, this is the fix we agreed on. This will change URL but not fiddle with browser history. Works the same (and as expected) in both Chrome and Firefox Test plan, ktd: 1) Search henry on the top search bar, notice 1 result is auto suggested 2) Ignore the auto-complete, press 'Enter' instead 3) Notice no results are returned. 4) Apply patch. Repeat. 5) Notice you get redirected to the single result of henry 6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox) 7) Visit patrons home directly: http://localhost:8081/cgi-bin/koha/members/members-home.pl 8) Notice no search is performed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #30 from Asymar Riu --- Hi, sorry for the delay in replying: I confirm that it works. Thank you very much! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #29 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #28) > (In reply to Marcel de Rooy from comment #20) > > The alternative patch addresses the issues raised earlier on the use of > > signals and follows the suggestions of David. > > Thanks :) > > > Kyle, Victor and Asymar: Would this work for you? > > It works, so signing off. > As for the signal vs no signals I don't know the good practices to QA this. > Same for how this plays with when using database polling or the message > queue. (I would have missed that the 1st alternate patch missed this) I think we can move this to PQA with the sign-offs we have! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567 --- Comment #2 from Katrin Fischer --- I just checked again in a 22.11 installation and we are still not providing valid RSS data from the search results. This feed does not validate. line 45, column 4: Undefined description element: p (100 occurrences) [help] ^ In addition, interoperability with the widest range of feed readers could be improved by implementing the following recommendations. line 22, column 163: Self reference doesn't match document location [help] ... p;sort_by=acqdate_dscformat=atom"/> ^ line 32, column 1: Misplaced Item (49 occurrences) [help] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277
--- Comment #6 from Jonathan Druart ---
138 foreach my $from ( @from_branches ) {
139 foreach my $to ( @to_branches ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 --- Comment #5 from Jonathan Druart --- IMO those 2 nested loops need to be rewritten. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277
--- Comment #4 from Jonathan Druart ---
apt install stress
stress --cpu 16 (or the number of CPUs you have)
Run the following script to inject a lot of libraries
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
for my $i ( 1..10 ) {
say $i;
$builder->build_object({class => 'Koha::Libraries'});
}
% time prove t/db_dependent/api/v1/transfer_limits.t
t/db_dependent/api/v1/transfer_limits.t .. 3/4 # Inactivity timeout
# Failed test 'POST
//hN26548B2h7s3DR9jWZ55OcQnBYvz_olhgm6YAKWU8rRGvCuHOkjM:thePassword123@/api/v1/transfer_limits/batch'
# at t/db_dependent/api/v1/transfer_limits.t line 210.
# Failed test 'SWAGGER3.2.1'
# at t/db_dependent/api/v1/transfer_limits.t line 210.
# got: undef
# expected: '201'
t/db_dependent/api/v1/transfer_limits.t .. 4/4 # Looks like you failed 2
tests of 26.
# Failed test 'batch_add() and batch_delete() tests'
# at t/db_dependent/api/v1/transfer_limits.t line 269.
# Looks like you failed 1 test of 4.
t/db_dependent/api/v1/transfer_limits.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/4 subtests
Test Summary Report
---
t/db_dependent/api/v1/transfer_limits.t (Wstat: 256 Tests: 4 Failed: 1)
Failed test: 4
Non-zero exit status: 1
Files=1, Tests=4, 156 wallclock secs ( 0.03 usr 0.00 sys + 105.04 cusr 6.17
csys = 111.24 CPU)
Result: FAIL
real2m36.183s
user1m45.121s
sys 0m6.208s
No idea what to do then...
There might be a perf regression somewhere.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com --- Comment #3 from Jonathan Druart --- Koha_Master_MDB_Latest/1359 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 --- Comment #5 from Nick Clemens --- Created attachment 163112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163112=edit Bug 36190: Fix problems found by test opac-shelves - forms were stateless - changed to GET sco-main - forms stateless - changed to GET ** untested because sco + auth is broken smart-rules.tt - JS form template - added placeholder 'cud-' op ill-requests - added cud- tp ops ** tested comments, but not checkout, simple changes boraccount - removed repeated op - updated script patroncards/edit-batch - add placeholder 'cud-' op patroncards/manage - add placheholder 'cud-' op elasticsearch/mappings - separate forms - this could use a style follow-up, but makes more sense separate I think reports/dictionary - stateless - changed to GET guided_reports_start- stateless - changed to GET suggestion/suggestion - add placeholder 'cud-' op inventory - filed bug 36305, needs more handling -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 --- Comment #4 from Nick Clemens --- Created attachment 163111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163111=edit Bug 36190: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 Nick Clemens changed: What|Removed |Added Attachment #162530|0 |1 is obsolete|| Attachment #162531|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 163110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163110=edit Bug 36190: To not assume op is invalid if it is a TT variable Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36305 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 Nick Clemens changed: What|Removed |Added Depends on||36305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 [Bug 36305] Inventory tools need adjustments for CSRF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 Nick Clemens changed: What|Removed |Added Blocks||36192 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36305] New: Inventory tools need adjustments for CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 Bug ID: 36305 Summary: Inventory tools need adjustments for CSRF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The main forms don't use 'op' other than checking for the existence Problem follow-ups use an ajax post -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #20 from Jonathan Druart --- Still not happy with it, under Firefox: * Go to mainpage * Click "Patrons" in the header => You are on http://localhost:8081/cgi-bin/koha/members/members-home.pl * "Search for patrons": Search: "henry" (form on the left) => Redirected to the patron detail page * back => You are now on the mainpage! We expect the patron search page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #19 from Pedro Amorim --- (In reply to Brendan Lawlor from comment #7) > Not sure if I'm missing something, but with this patch applied the back > button still works how I would expect it to. > > If I search from the main page for Henry, it takes me directly to that > patron, and the back button takes me back to the main page. > > If I search for Bob it takes me to the results page with two entries. Then > if I search for Henry it takes me to the patron record and back takes me > back to the results page. Thank you Brendan for your initial sign-off. I've since followed up while discussing with Jonathan's in case you want to take a look again, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #18 from Pedro Amorim --- Created attachment 163109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163109=edit Bug 36302: use replace instead of href This will change URL but not fiddle with browser history. Works the same (and as expected) in both Chrome and Firefox Test plan, ktd: 1) Search henry on the top search bar, notice 1 result is auto suggested 2) Ignore the auto-complete, press 'Enter' instead 3) Notice no results are returned. 4) Apply patch. Repeat. 5) Notice you get redirected to the single result of "henry" 6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox) 7) Visit patrons home directly: http://localhost:8081/cgi-bin/koha/members/members-home.pl 8) Notice no search is performed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Pedro Amorim changed: What|Removed |Added Attachment #163099|0 |1 is obsolete|| Attachment #163105|0 |1 is obsolete|| Attachment #163106|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 163108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163108=edit Bug 36302: Get rid of defer_loading Update JS submit of patron_search_form to check for URLParams instead of defer_loading. This is to keep behavior of not doing a search when accessing http://localhost:8081/cgi-bin/koha/members/members-home.pl directly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 --- Comment #24 from Andreas Jonsson --- Created attachment 163107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163107=edit Bug 35826: Make copy of cost matrix when substituting inf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #16 from Jonathan Druart --- (In reply to Pedro Amorim from comment #13) > Created attachment 163106 [details] [review] [review] > Bug 36302: Remove unused code > > Please can someone tell me why we need this code? > Inititally I thought this is where the redirect was coming from, but it's > coming from JS, not here, so why do we need this? We need it. If you search for 42 you want the patron with cardnumber=42 to be displayed, not the table with all the occurrences of "42". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36302] Patron search from search bar broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 --- Comment #15 from Jonathan Druart --- (In reply to Pedro Amorim from comment #12) > Created attachment 163105 [details] [review] > Bug 36302: Use replace instead of href > > This will change URL but not fiddle with browser history. > Works the same (and as expected) in both Chrome and Firefox This is not fixing comment 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
