[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35659 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10662 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25905] REST API: create endpoint for importing OAI-PMH records from external OAI-PMH clients
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35659 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #37 from Victor Grousset/tuxayo --- (obsoleted duplicate old version of a patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35659] OAI Harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact||vic...@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- > 7) Click 'ILL request log', notice the entry is there but has no information > about who did the logged action. Testing notes: need to have this commit applied "Bug 36118: [DONT PUSH] patch to test patron notice only" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36135] Add tool to batch modify holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Brenda changed: What|Removed |Added CC||bow...@washoecounty.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue when release notes||the AutoSwitchPatron system ||preference is enabled (the ||issue was caused by bug ||35518 - added to Koha ||24.05.00, 23.11.03, and ||23.05.09). || ||If you went to ||check out an item to a ||patron, and then entered ||another patron's card ||number in the item bar ||code, it was correctly: ||- ||switching to that patron ||- ||showing a message to say ||that the patron was ||switched. || ||However, it was ||also incorrectly showing a ||"Barcode not found" message ||- this is now fixed, and is ||no longer displayed. --- Comment #9 from David Nind --- Testing notes (using koha-testing-docker (KTD): 1. Enable the AutoSwitchPatron system preference. 2. Go to check out an item to a patron: enter name, such as Mary, in the check out search box. 3. On the check out page, enter the card number for another patron instead of an item barcode, for example: Lisa - 23529000197047. 4. The patron correctly switches to Lisa. 5. Two messages are displayed: Patron was automatically switched by reading the patron card during checking out. Ensure you are working with the right patron. Barcode not found The barcode was not found: 23529000197047 Add record using fast cataloging 6. Only the first message should be displayed. 7. Apply the patch and repeat. 8. The barcode not found message is no longer displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Attachment #162310|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 --- Comment #8 from David Nind --- Created attachment 163287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163287=edit Bug 36139: Bug 35518 Follow-up to fix AutoSwitchPatron - clear variables Bug 35518 moved some code blocks to after the call to get_user_and_template() so that userenv would be populated before it was needed. This caused a couple variables to be set before the AutoSwitchPatron block could prevent them from being set. Which broke AutoSwitchPatron functionality. This clears two variable so that AuthSwitchPatron works again. The AutoSwitchPatron clears the $borrowernumber variable to switch patrons. With the AuthSwitchPatron block moved, the $patron variable still gets set, and the patron doesn't get switched. The clears the $patron variable too. Also clear the barcode list. The AutoSwitchPatron block got moved, and now the @$barcodes variable gets filled and not cleared. Leading to a 'Barcode not found' error when the patron is auto switched. Test plan: 1. Ensure AutoSwitchPatron is turned on. 2. Select the card number of two patron accounts. 3. Find the first patron in circulation. 4. Enter the second patron's card number in the item barcode field to switch patrons. 5. Observe the error about item barcode not existing, and the patron did not switch. 6. Apply patch and restart services. 7. Enter the second patron's card number in the item barcode field again. 8. Observe that the patron was switched with no error about an invalid barcode. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #7 from David Nind --- (In reply to Michael Hafen from comment #6) > There are four patches because the `git bz apply` command references the > parent bug, which is already in master as commits 90b6f68616 and b577b65670. > Please try `git bz apply 36139` instead. > The patch file here squashes the last two patches on the parent bug (those > two should probably be removed from there or something, since I mistakenly > added them after the patch had been pushed). > This will at least take care of the 'Barcode not found' error, and I think > clearing the $patron variable should be harmless at that point in the file. > (Looking over the code again, I don't know why it wasn't switching patrons > for me, the $patron variable clearly gets reset in the $findborrower block > below.) > I'll leave the status as is, just in case there is anything else that > causes the patch to not apply. Hi Michael. My apologies! I was reading things incorrectly, and as you spotted I applied the wrong patch! The patch does apply, now that I have used the correct bug number! Things now work as expected: with AutoSwitchPatron enabled, the patron is swicthed and the only message that is now displayed is: Patron was automatically switched by reading the patron card during checking out. Ensure you are working with the right patron. Sign off on the way. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163181|0 |1 is obsolete|| --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 163286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163286=edit Bug 36118: Tidy changed code block Simple tidy of the codeblock we added a line to so we get through the tidy requirements of the QA script. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163180|0 |1 is obsolete|| --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 163285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163285=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163179|0 |1 is obsolete|| --- Comment #15 from Victor Grousset/tuxayo --- Created attachment 163284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163284=edit Bug 36118: Send patron object to template Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163178|0 |1 is obsolete|| --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 163283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163283=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 --- Comment #17 from Michael Hafen --- (In reply to Fridolin Somers from comment #13) > Hi Michael > Thanks for that. > > You should create a new bug report with those patches since the previous > ones have already been pushed. > And beware of commit messages for follow-ups : > https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups I was to late in marking those two patches obsolete, they were included in the push to 23.05.x. I made bug 36139 to track my patches. I foresee some confusion here. in 23.05.x those two extra patches should be reverted, or bug 36139 needs to Not be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 Michael Hafen changed: What|Removed |Added Attachment #162218|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 Michael Hafen changed: What|Removed |Added Attachment #162216|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 --- Comment #6 from Michael Hafen --- There are four patches because the `git bz apply` command references the parent bug, which is already in master as commits 90b6f68616 and b577b65670. Please try `git bz apply 36139` instead. The patch file here squashes the last two patches on the parent bug (those two should probably be removed from there or something, since I mistakenly added them after the patch had been pushed). This will at least take care of the 'Barcode not found' error, and I think clearing the $patron variable should be harmless at that point in the file. (Looking over the code again, I don't know why it wasn't switching patrons for me, the $patron variable clearly gets reset in the $findborrower block below.) I'll leave the status as is, just in case there is anything else that causes the patch to not apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #51 from Victor Grousset/tuxayo --- Nice :D I'll submit my additional changes in another ticket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- Testing notes (using KTD): 1. Tests pass before and after the patches are applied: prove t/db_dependent/api/v1/transfer_limits.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 David Nind changed: What|Removed |Added Attachment #163234|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 163282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163282=edit Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType This patch adds tests for the different cases of `BranchTransferLimitsType`. It also adds tests for the situation of the consumer sending both limit criterias on the request. The controller gets adjusted for this new behavior and the spec gets documentation added about this. Bonus: tests are added the right guidelines code, and BranchTransferLimitsType gets mocked to avoid failures due to existing data. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ qa => SUCCESS: All green, and tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 David Nind changed: What|Removed |Added Attachment #163233|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 163281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163281=edit Bug 36329: Miscelaneous spec fixes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 David Nind changed: What|Removed |Added Attachment #163232|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 163280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163280=edit Bug 36329: Add missing return codes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36333] Remove all empty lines from template's output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36333
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Text to go in the||This removes extra blank
release notes||lines from the HTML page
||source for OPAC and staff
||interface pages. The HTML
||page source should now be
||more compact, which should
||make it easier to read.
||
||(The extra blank lines are
||caused by the way HTML
||output is generated by the
||Template Toolkit - it
||includes whitespace
||anywhere there is a
||template tag.)
--- Comment #3 from David Nind ---
Testing notes (using KTD):
1. View the page source for some OPAC and staff interface pages (for example:
home pages for staff interface and OPC, and the details page for a record).
2. Notice that there are a lot of empty lines.
3. Apply the patch.
4. Repeat step 1.
5. Now notice that the JTML page source is much more compact, with minimal
extra blank lines.
Some examples:
- OPAC home page: before - 944 lines; after - 398 lines
- OPAC detail page (262 - Programming perl): before - 2487 lines; after - 1285
lines
- Staff interface home page: before - 1326 lines; after - 706 lines
- Staff detail page (262 - Programming perl): before - 2754 lines; after - 1837
lines
Example source for staff interface home page
Before
~~
Koha staff interface
After
~
Koha staff interface
body{display:none !important;}
import { APIClient } from '/intranet-tmpl/prog/js/fetch/api-client.js';
window.APIClient = APIClient;
var Koha = {};
var CAN_user_parameters_manage_column_config = 1;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36333] Remove all empty lines from template's output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36333 David Nind changed: What|Removed |Added Attachment #163242|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 163279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163279=edit Bug 36333: Remove empty lines from template's output This patch removes empty lines (containing only whitespaces) from the output. It does not have the intented result, we don't gain much in term of size. However the source is way cleaner and easier to read. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36333] Remove all empty lines from template's output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36333 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |michael.ha...@washk12.org |ity.org | --- Comment #5 from David Nind --- I've also changed the assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #4 from David Nind --- The patch(es) didn't apply for me - I'm confused why there are four patches shown when applying, versus only one listed under the attachments in the bug. See [1]. In addition, before the patches are applied the current behaviour in master doesn't match with what is described in the bug. For me, the patron successfully switches, but the barcode error is displayed (tested using koha-testing-docker with the sample data): 1. Enable the AutoSwitchPatron system preference. 2. Go to check out an item to a patron: enter name, such as Mary, in the check out search box. 3. On the checkout page, enter the card number for another patron instead of an item barcode, for example: Lisa - 23529000197047. 4. The patron switches to Lisa. 5. Two messages are displayed: Patron was automatically switched by reading the patron card during checking out. Ensure you are working with the right patron. Barcode not found The barcode was not found: 23529000197047 Add record using fast cataloging [1] Result of trying to apply the patch(es): git bz apply 35518 Bug 35518 - Call to C4::Context->userenv happens before it's gets populated breaks code logic in circulation 161929 - Bug 35518: Check authentication and set userenv before fetching userenv variables 161930 - Bug 35518: Tidy the moved blocks 162216 - Bug 35518: follow up - clear the barcode list in AutoSwitchPatron block 162218 - Bug 35518: Follow-up for AutoSwitchPatron - clear $patron variable too Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35518: Check authentication and set userenv before fetching userenv variables Using index info to reconstruct a base tree... M circ/circulation.pl Falling back to patching base and 3-way merge... Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 35518: Check authentication and set userenv before fetching userenv variables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g --- Comment #5 from Kristi --- Re: I like the idea of changing it to "Manage items" and replacing the Add items form at the bottom with a button to add an item. I use this page for a few tasks, like duplicating an item, or editing items individually one after another instead of in a batch. I also like the idea of Manage items. I would hesitate to add a button to click into to add items from that form since it would add another click to the workflow. One click to get to the Add item form is ideal. Maybe "add items" could be its own option in the dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #163277|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 163278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163278=edit Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- Testing notes (using KTD): 1. Go to Reports > Other > Catalog by item type 2. Generate the report and note the results for: - Centerville - All libraries (leave library selection blank) 3. Apply the patch 4. Repeat steps 1-2 5. The results should be the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 David Nind changed: What|Removed |Added Attachment #163182|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 163277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163277=edit Bug 31988: Remove reports/itemtypes.plugin This "plugin system" is only used for the itemtypes report. We can simply remove the reports/manager.pl script and this plugin in favor of a dedicated report. Test plan: Same behaviour expected before and after this patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36326] Biblio detail view - Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36326 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #10 from David Nind --- I've signed off Jonathan's patch. Feel free to add me to the bug once bug 33568 is pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36326] Biblio detail view - Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36326 David Nind changed: What|Removed |Added Attachment #163227|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 163276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163276=edit Bug 36326: Fix batch item mod/del access from biblio detail page Allow both $op eq "show" and "cud-show". We need to keep the POST when we upload a file, but we can simply allow GET with "show". Test plan: Go to the biblio detail page, select an item and test both tools via the links "Delete selected items" and "Modify selected items" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36326] Biblio detail view - Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36326 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #4 from Andrew Fuerste-Henry --- It's worth noting that one also ends up on the Add Item screen with a blank item form after each edit of a single item. Whatever we decide on here should also be applied to the post-edit landing page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10060] Allow adding a branch parameter to the web-based self check to indicate library its used at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #24 from Christopher Brannon --- Another issue with forcing setups with multiple branches to login to their specific library for sco is that the typical self check kiosk does not have a standard keyboard. This makes it more difficult to login, and adds unnecessary fussing with setup every single morning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12450] Easily close a branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Liz Rea changed: What|Removed |Added Version|unspecified |master CC||wizzy...@gmail.com Summary|Closing libraries for the |Easily close a branch |summer | Severity|enhancement |new feature Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Nick Clemens --- Jonathan, can you confirm my follow-up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Nick Clemens changed: What|Removed |Added Attachment #163269|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 163275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163275=edit Bug 36334: (follow-up) Restore selection of previous values in sidebar Before and after the first patch the values for category and library were not populated To test: 1 - With nothing applied search in the top bar, clicking the 'settings' button 2 - Select a search field, search type, category, and library 3 - Perform search, note only search field and search type are populated 4 - Apply first path, repeat, same result 5 - Apply this patch, repeat 6 - Confirm all four fields now populate in sidebar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 --- Comment #21 from Kyle M Hall --- Created attachment 163274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163274=edit Bug 36206: (QA follow-up) Tidy admin-home.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 --- Comment #20 from Kyle M Hall --- Created attachment 163273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163273=edit Bug 36206: (follow-up) Change file permission Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 --- Comment #19 from Kyle M Hall --- Created attachment 163272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163272=edit Bug 36206: Add 'Run administration tool' to plugin actions This patch adds the new 'Run administration tool' option to the plugin actions dropdown menu for plugins with such a function. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 --- Comment #18 from Kyle M Hall --- Created attachment 163271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163271=edit Bug 36206: Expose administration page to users with plugins_admin permission This patch updates the intranet home page logic such that the administration button appears for those users with just the 'admin' subpermission of plugins to allow them to access such plugins. We also update the display logic found inside the admin-home page so that user see plugin management appropriately. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 Kyle M Hall changed: What|Removed |Added Attachment #162780|0 |1 is obsolete|| Attachment #162781|0 |1 is obsolete|| Attachment #162782|0 |1 is obsolete|| Attachment #162783|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 163270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163270=edit Bug 36206: Add 'admin' plugins option This patch adds an admin plugins class to the plugins system and displays such plugins under the 'Plugins' section in the Administration page. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36206] Administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #5 from Nick Clemens --- Created attachment 163269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163269=edit Bug 36334: (follow-up) Restore selection of previous values in sidebar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334
Nick Clemens changed:
What|Removed |Added
Attachment #163258|0 |1
is obsolete||
--- Comment #4 from Nick Clemens ---
Created attachment 163268
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163268=edit
Bug 36334: Remove unnecessary JS code from member.tt
This was initially written to set the input/select in the form in the
left side of the main patron search page.
But this is now done in patron-search.inc:
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:
I don't see how/when this code is still used.
Additionally:
#searchmember_filter
=> does not exist, it's .search_patron_filter
$("searchfieldstype_filter").val("[% searchfieldstype | html %]");
=> Not a valid selector
Signed-off-by: Pedro Amorim
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #70 from Nick Clemens --- Created attachment 163267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163267=edit Bug 30579: (follow-up) Remove unnecessary nested form elements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #69 from Nick Clemens --- Created attachment 163266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163266=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #68 from Nick Clemens --- Created attachment 163265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163265=edit Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #67 from Nick Clemens --- Created attachment 163264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163264=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #66 from Nick Clemens --- Created attachment 163263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163263=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #65 from Nick Clemens --- Created attachment 163262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163262=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #64 from Nick Clemens --- Created attachment 163261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163261=edit Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #157937|0 |1 is obsolete|| Attachment #157938|0 |1 is obsolete|| Attachment #157939|0 |1 is obsolete|| Attachment #157940|0 |1 is obsolete|| Attachment #157941|0 |1 is obsolete|| Attachment #157942|0 |1 is obsolete|| Attachment #157943|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 163260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163260=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea Signed-off-by: Sam Lau Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027 --- Comment #15 from Phan Tung Bui --- Created attachment 163259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163259=edit Bug 36027 : (follow-up) Improvement : Add check option i add the check option so that instead of skipping certain checks, you can also choose a specific test to run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334
Pedro Amorim changed:
What|Removed |Added
Attachment #163249|0 |1
is obsolete||
--- Comment #3 from Pedro Amorim ---
Created attachment 163258
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163258=edit
Bug 36334: Remove unnecessary JS code from member.tt
This was initially written to set the input/select in the form in the
left side of the main patron search page.
But this is now done in patron-search.inc:
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:
I don't see how/when this code is still used.
Additionally:
#searchmember_filter
=> does not exist, it's .search_patron_filter
$("searchfieldstype_filter").val("[% searchfieldstype | html %]");
=> Not a valid selector
Signed-off-by: Pedro Amorim
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Juliet Heltibridle changed: What|Removed |Added CC||jheltibri...@rcplib.org --- Comment #3 from Juliet Heltibridle --- I like the idea of changing it to "Manage items" and replacing the Add items form at the bottom with a button to add an item. I use this page for a few tasks, like duplicating an item, or editing items individually one after another instead of in a batch. Our system also has holdings on the normal view page split so other library holdings don't show in the first tab, and going to the "edit item" screen gives me a table with everyone's items, so I can see them together if needed. It looks like I could do the same things by using the Add item drop-down, so I wouldn't be opposed to getting rid of the "edit items" drop-down entirely, if that was the consensus. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36331] Items that cannot be held are prevented renewal when there are holds on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36331 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #163236|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 163254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163254=edit Bug 36331: Don't check reserves that an item cannot fill when checking if it can be renewed Before this patch we get all holds on a record and see if we can fill them with available items. This means we check to fill holds that the item in questoion may not be able to fill, especially in the case where no holds are allowed on the item type, this is wrong To test: 1 - Find or create a biblio with two items of different item types 2 - Make sure one item type allows holds, and the other has: "Default holds policy by item type" Set to "No holds allowed" 3 - Set system preference "AllowRenewalIfOtherItemsAvailable" to "Don't allow" 4 - Check out the unholdable item to a patron 5 - Set a hold for a different patron on the next available item 6 - Confirm the checked out item can be renewed (don't renew, just view the checkouts page) 7 - Checkout the other item to a third patron 8 - Confirm the first item can still be renewed 9 - Set system preference "AllowRenewalIfOtherItemsAvailable" to "Allow" 10 - Confirm the item cannot be renewed now 11 - Apply patch, restart all 12 - Confirm the item can be renewed 13 - Set the item type to a type that allows holds 14 - Confirm the item can no longer be renewed 15 - Restore the item type 16 - Set system preference "AllowRenewalIfOtherItemsAvailable" to "Don't allow" 17 - Confirm the item can be renewed 18 - Check in the item from the third patron 19 - Confirm the item can still be renewed 20 - prove -v t/db_dependent/Circulation.t - test still pass Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36331] Items that cannot be held are prevented renewal when there are holds on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36331 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36326] Biblio detail view - Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36326 --- Comment #8 from Jonathan Druart --- This second patch is causing a major conflict with bug 33568 while my single line patch is fixing the original problem without any conflicts. I would prefer to prevent change to this template until 33568 is pushed. I will be happy to provide a better fix on top of it once in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #71 from Jonathan Druart --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36324] Authority editor missing move icon next to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324 Esther Melander changed: What|Removed |Added Summary|Authority subfields cannot |Authority editor missing |be reordered|move icon next to subfields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36324] Authority subfields cannot be reordered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324 --- Comment #2 from Esther Melander --- Created attachment 163253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163253=edit Missing move icon Ah, I see that it does work and it is definitely not obvious. By clicking and dragging just to the left of the subfield letter the field can be reordered. However, the mouse pointer does not change to the double cross arrows when hovering. And with the missing move icon, the behavior is changed from previous versions. I have attached an image with screen shots of the Authority Editor versus the Basic Editor. Prior to 23.11, the Authority Editor had the move icon and the mouse pointer change. Changing the bug title to more accurately reflect the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #57 from Thomas Klausner --- Finally created a pull-req for KTD to add my "fix" to the KTD docs: https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/492 I still see no easy way to add this to KTD itself, because KTD is calling koha-plack, and we don't want to add hot-reload there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 --- Comment #1 from Fridolin Somers --- Created attachment 163251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163251=edit Bug 36335: Fix ILS-DI GetRecords bad encoding for UNIMARC ILS-DI GetRecords generates bad encoding of MARCXML for UNIMARC, like OAI in Bug 34467 Enable ILS-DI and display a record with : /cgi-bin/koha/ilsdi.pl?service=GetRecords= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Fridolin Somers changed: What|Removed |Added Blocks||36335 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 Fridolin Somers changed: What|Removed |Added Depends on||34467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 [Bug 34467] OAI GetRecord bad encoding for UNIMARC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36335] New: ILS-DI GetRecords bad encoding for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335 Bug ID: 36335 Summary: ILS-DI GetRecords bad encoding for UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org ILS-DI GetRecords generates bad encoding of MARCXML for UNIMARC, like OAI in Bug 34467 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36326] Biblio detail view - Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36326 Pedro Amorim changed: What|Removed |Added Attachment #163238|0 |1 is obsolete|| --- Comment #7 from Pedro Amorim --- Created attachment 163250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163250=edit Bug 36326: PoC followup I've moved the static elements to the form instead of appending them. This does not overlap 100% with bug 36193 or 34478 as in those cases we're not adding inputs to the form dynamically, so we should/have to keep that in here. Let me know what you think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #272 from Jonathan Druart --- *** Bug 19157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19157] XSS Stored in letter.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19157 Jonathan Druart changed: What|Removed |Added Product|Koha security |Koha Component|Koha|Architecture, internals, ||and plumbing Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE Group|Koha security | --- Comment #8 from Jonathan Druart --- Fixed. *** This bug has been marked as a duplicate of bug 13618 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36297] Avoid using var named "t" in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36297 --- Comment #8 from Julian Maurice --- (In reply to Julian Maurice from comment #4) > Or another (but hypothetical as I'm not sure it works): redefine these > functions as filters [% "..." | t %] (I believe filters don't conflict with > variable names ?) For the record, it can work as a filter. It requires some code modification that I will submit in another bug report. I think it can be useful whatever we decide on this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com, ||pedro.amo...@ptfs-europe.co ||m --- Comment #2 from Jonathan Druart --- Nick, Pedro, could you confirm that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334
--- Comment #1 from Jonathan Druart ---
Created attachment 163249
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163249=edit
Bug 36334: Remove unnecessary JS code from member.tt
This was initially written to set the input/select in the form in the
left side of the main patron search page.
But this is now done in patron-search.inc:
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:
I don't see how/when this code is still used.
Additionally:
#searchmember_filter
=> does not exist, it's .search_patron_filter
$("searchfieldstype_filter").val("[% searchfieldstype | html %]");
=> Not a valid selector
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36332] JS error on moremember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36332 --- Comment #3 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36332] JS error on moremember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36332 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36298] In patrons search road type authorized value code displayed in patron address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36298 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36298] In patrons search road type authorized value code displayed in patron address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36298 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36292] 'See all charges' hyperlink to view guarantee fees is not linked correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36292 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36292] 'See all charges' hyperlink to view guarantee fees is not linked correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36292 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 --- Comment #22 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36224] It looks like spsuggest functionality was removed years ago, but the templates still refer to it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36224 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36224] It looks like spsuggest functionality was removed years ago, but the templates still refer to it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36224 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
