[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36044] Show ISBN number of purchase suggestions on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044 Bug 36044 depends on bug 36274, which changed state. Bug 36274 Summary: OPAC suggestions form doesn't display https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36274] OPAC suggestions form doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 Fridolin Somers changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #11 from Fridolin Somers --- Bug 34478 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 --- Comment #25 from Jonathan Druart --- The error now starts with "Premature connection close" instead of "Inactivity timeout" koha_1 | # Premature connection close koha_1 | koha_1 | # Failed test 'POST //jJk8CE_fqJgQlLwZpiokcDRYn3YvprTEr5hQLvRFIQjcQDdyCMiW__Dx5yc:thePassword123@/api/v1/transfer_limits/batch' koha_1 | # at t/db_dependent/api/v1/transfer_limits.t line 210. koha_1 | koha_1 | # Failed test 'SWAGGER3.2.1' koha_1 | # at t/db_dependent/api/v1/transfer_limits.t line 210. koha_1 | # got: undef koha_1 | # expected: '201' koha_1 | # Looks like you failed 2 tests of 26. koha_1 | koha_1 | # Failed test 'batch_add() and batch_delete() tests' koha_1 | # at t/db_dependent/api/v1/transfer_limits.t line 269. koha_1 | # Looks like you failed 1 test of 4. koha_1 | [11:07:21] t/db_dependent/api/v1/transfer_limits.t . A successful run on Jenkins (Koha_Master#2813 Docker_15) is slow koha_1 | [10:56:23] t/db_dependent/api/v1/transfer_limits.t . ok41681 ms ( 0.01 usr 0.00 sys + 30.81 cusr 1.84 csys = 32.66 CPU) It takes ~10sec on my laptop and I compared with other tests, they are faster on Docker_15. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #3 from Tomás Cohen Arazi --- Nice catch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #8 from Jonathan Druart --- (In reply to Nick Clemens from comment #7) > Jonathan, can you confirm my follow-up? Yes, good catch! Thanks a lot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #27 from Jonathan Druart --- And we are not using it anywhere? Next step? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 --- Comment #14 from Jonathan Druart --- (In reply to Julian Maurice from comment #8) > (In reply to Jonathan Druart from comment #7) > > You are mixing unblessed and blessed in budget_owner. > > The logged in patron will be a hashref and others will be Koha::Patron > > objects. > No ? The %patrons hash only contains Koha::Patron object. $loggedinpatron is > a hashref but it's not in the %patrons hash and is not used for > budget_owner, only as a CanUserUseBudget parameter. Yes, sorry, it seems that I misread something! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36347] Return claims table is loaded twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36347] Return claims table is loaded twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347
--- Comment #1 from Julian Maurice ---
Created attachment 163340
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163340=edit
Bug 36347: Avoid return claims table being loaded twice
The issue is caused by these lines in circulation.js:
$("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){
$(this).click();
});
When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and
then another click event is triggered. And because the table was loaded
on tab click, it was loaded twice.
Visually it could have caused the rows to be duplicated (it was random,
probably due to timing, network latency, ...)
I don't know why we need to trigger a click in this case, but removing
this will probably break something else, so the fix here is to load the
table on 'shown.bs.tab' event instead of 'click'
This patch also contains a small fix in refreshReturnClaimsTable which
was reloading the table right after the table initialization.
Test plan:
1. Check out an item, and in the checkouts table, click "Claim returned"
2. Open the network tab of your browser's developer tools
3. Click on the "Claims" tab, verify that only one call is made to
svc/return_claims
4. Verify that the claims table is displayed correctly
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36347] New: Return claims table is loaded twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347
Bug ID: 36347
Summary: Return claims table is loaded twice
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Circulation
Assignee: julian.maur...@biblibre.com
Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
The issue is caused by these lines in circulation.js:
$("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){
$(this).click();
});
When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and then
another click event is triggered. And because the table is loaded on tab click,
it is loaded twice.
Visually it can cause the rows to be duplicated (it is random, probably due to
timing, network latency, ...)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36346] CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 --- Comment #1 from Thibaud Guillot --- Created attachment 163339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163339=edit Bug 36346 : Prevent moving to the next object on 'not_allowed' rule Test plan: 1) Enable AllowHoldPolicyOverride 2) Set a new circulation rule on "Default holds policy by item type": For example, an item type called "Comics" with Hold policy set on "No holds allowed" 3) Go to an item related to this item type and force a hold :) 4) Try to perform a check-in on this item, no pop up 5) Try to perform a check out for another patron, no pop up again 6) Apply this patch 7) Repeat step 4 and 4, normally now there is a pop up with hold information Sponsored by : BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36346] CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36346] CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36346] New: CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Bug ID: 36346 Summary: CheckReserves sometimes lead to bad behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guil...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi @ll, Some options in the circulation rules may lead to incorrect returns from CheckReserves. When you enabled AllowHoldPolicyOverride, you can forcing a hold, even when it is not authorized in the "Default holds policy by item type" rule table. Let me explain: when a hold is forced on an item whose itemtype has a holdallowed rule set to "not_allowed", if you return the item, the hold will not be detected. Similarly, when you perform a checkout, the pop-up indicating that a hold has been placed is not displayed. It's possible that in other places in the code this would cause other inconveniences, but I haven't counted them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36345 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36345] Deleting related things causes data loss for old_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36101 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30648] Title is lost in holds history when biblio is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Kyle M Hall changed: What|Removed |Added Blocks||36345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 [Bug 36345] Deleting related things causes data loss for old_reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36345] Deleting related things causes data loss for old_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 Kyle M Hall changed: What|Removed |Added Depends on||30648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 [Bug 30648] Title is lost in holds history when biblio is deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #11 from Martin Renvoize --- (In reply to Martin Renvoize from comment #10) > With bug 33036 having just been pushed, I think we need to move the > before_biblio hooks here. Hmm.. kinda annoying.. we're allowing for both metadata and biblio changes here in the hook.. that will be more difficult if we move within the merge_with routing of Koha::Biblio as we don't handle metadata in that merge routine at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36345] New: Deleting related things causes data loss for old_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 Bug ID: 36345 Summary: Deleting related things causes data loss for old_reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The old_reserves table is meant to be a historical preservation of data. Currently it has foreign keys a number of tables where that also have a delete/old table for preservation. For example, we may have an "old reserve" with an associated item. When we delete that item, the item is moved to the deleteditems, and old_reserves.itemnumber is set to NULL thus losing the associated item even though we still have the item data! This is true for borrowers, bibs and items. To enable saving this data, we should add a non FK column for each related table that has a delete/old version of that table. Then, when the associated item is deleted, copy the FK value to the new column before is is nullified. In fact, if we populated those columns when moving the hold from reserves to old_reserves, we wouldn't even have to add code to each of the delete methods! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #10 from Martin Renvoize --- With bug 33036 having just been pushed, I think we need to move the before_biblio hooks here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Martin Renvoize changed: What|Removed |Added Blocks||29392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 [Bug 29392] Add plugin hooks before merging biblios or authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize changed: What|Removed |Added Depends on||33036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 [Bug 33036] REST API: Merge biblio records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317
--- Comment #10 from Fridolin Somers ---
Working on this I learned that DBIx combines several searches into one :
Koha::Items->search( { itemnumber => 123 } )->search( {}, { join =>
'branchtransfers' } );
Will give only one SQL query :
SELECT * FROM items JOIN branchtransfers USING itemnumber WHERE
itemnumber='123'
So we should always use explicit "me" :
Koha::Items->search( { "me.itemnumber" => 123 } )->search( {}, { join =>
'branchtransfers' } );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact||jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317 Fridolin Somers changed: What|Removed |Added Attachment #163335|0 |1 is obsolete|| --- Comment #9 from Fridolin Somers --- Created attachment 163338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163338=edit Bug 36317: Koha::Biblio->host_items must use me.itemnumber Koha::Biblio->host_items fails with search_ordered() because of ambiguous column 'itemnumber' in where clause. It must use me.itemnumber like in Koha::Biblio->items Test plan : prove t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317 --- Comment #8 from Fridolin Somers --- (In reply to Fridolin Somers from comment #6) > Created attachment 163334 [details] [review] > Bug 36317: Add unit test > > If fails it shows : > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Column 'itemnumber' in where clause is ambiguous at > /kohadevbox/koha/Koha/Objects.pm line 399 Combining Koha::Biblio->host_items with Koha::Items->search_ordered in test suite was too hard. I've done a simpler join on an item transfer which fails on current master. Note that I test with MariaDB 10.6. Looks like it is more severe on join than lower versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36341] "Hold starts on date" should be limited to future dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921
Martin Renvoize changed:
What|Removed |Added
Attachment #163336|0 |1
is obsolete||
--- Comment #13 from Martin Renvoize ---
Created attachment 163337
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163337=edit
Bug 35921: Improve perfs of acqui-home.pl when there are many budgets
When there are a lot of budgets with the same owner, most of the time of
acqui-home.pl is spent loading the same patron over and over.
This patch makes sure each borrower is loaded only once.
Test plan:
0. Do not apply the patch yet
1. Create a thousand budgets with the following command (make sure the
budget_owner_id is an existing borrowernumber):
perl -MKoha::Database -e '
my $schema = Koha::Database->schema;
my $period = $schema->resultset("Aqbudgetperiod")->create({
budget_period_startdate => "2000-01-01",
budget_period_enddate => "2999-12-31"
});
$schema->resultset("Aqbudget")->create({
budget_owner_id => 1,
budget_period_id => $period->id
}) for (1..1000)
'
2. Measure the time it takes to load acqui/acqui-home.pl (do it several
times and keep the average time)
3. Apply the patch
4. Repeat step 2
Signed-off-by: Pedro Amorim
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921
Martin Renvoize changed:
What|Removed |Added
Attachment #163288|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 163336
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163336=edit
Bug 35921: Improve perfs of acqui-home.pl when there are many budgets
When there are a lot of budgets with the same owner, most of the time of
acqui-home.pl is spent loading the same patron over and over.
This patch makes sure each borrower is loaded only once.
Test plan:
0. Do not apply the patch yet
1. Create a thousand budgets with the following command (make sure the
budget_owner_id is an existing borrowernumber):
perl -MKoha::Database -e '
my $schema = Koha::Database->schema;
my $period = $schema->resultset("Aqbudgetperiod")->create({
budget_period_startdate => "2000-01-01",
budget_period_enddate => "2999-12-31"
});
$schema->resultset("Aqbudget")->create({
budget_owner_id => 1,
budget_period_id => $period->id
}) for (1..1000)
'
2. Measure the time it takes to load acqui/acqui-home.pl (do it several
times and keep the average time)
3. Apply the patch
4. Repeat step 2
Signed-off-by: Pedro Amorim
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317 --- Comment #7 from Fridolin Somers --- Created attachment 163335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163335=edit Bug 36317: Koha::Biblio->host_items must use me.itemnumber Koha::Biblio->host_items fails with search_ordered() because of ambiguous column 'itemnumber' in where clause. It must use me.itemnumber like in Koha::Biblio->items Test plan : prove t/db_dependent/Biblio.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317 Fridolin Somers changed: What|Removed |Added Attachment #163155|0 |1 is obsolete|| --- Comment #6 from Fridolin Somers --- Created attachment 163334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163334=edit Bug 36317: Add unit test If fails it shows : DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'itemnumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 399 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36101 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33262 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 --- Comment #24 from Katrin Fischer --- We still have this one failing seemingly randomly (first it was D11, now on U20) https://jenkins.koha-community.org/job/Koha_Master_U20/lastCompletedBuild/testReport/(root)/t_db_dependent_api_v1_transfer_limits_t/batch_add___and_batch_delete___tests__1683_/ :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What|Removed |Added Attachment #159788|0 |1 is obsolete|| --- Comment #34 from Nick Clemens --- Created attachment 16 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What|Removed |Added Attachment #159787|0 |1 is obsolete|| --- Comment #33 from Nick Clemens --- Created attachment 163332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163332=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What|Removed |Added Attachment #159786|0 |1 is obsolete|| --- Comment #32 from Nick Clemens --- Created attachment 163331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163331=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #9 from Martin Renvoize --- Rebased and added a consistency follow-up... we aught to have unit tests, but as we're at the controller level that's not quite as trivial as our other hook unit tests. I'm opting to PQA for now but hope in the future the logic of these merge op's will make it's way into the Model level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #8 from Martin Renvoize --- Created attachment 163330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163330=edit Bug 29392: Improve hook consistency. It would appear we've adopted 'payload' for passing additional data into action hooks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392
Martin Renvoize changed:
What|Removed |Added
Attachment #127217|0 |1
is obsolete||
--- Comment #7 from Martin Renvoize ---
Created attachment 163329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163329=edit
Bug 29392: Add plugin hooks before merging biblios or authorities
Hooks are called 'before_biblio_action' and 'before_authority_action'
and they both take an 'action' parameter whose value is 'merge'.
Other parameters include the record id (biblionumber or authid), the
object itself (Koha::Biblio or Koha::Authority), the MARC::Record about
to be saved (so plugins can modify it), and the list of record ids that
will be deleted after the merge.
Test plan:
1. Create a plugin with these two methods. For instance:
sub before_biblio_action {
my ($self, $args) = @_;
my $action = $args->{action};
return unless $action eq 'merge';
my $record = $args->{record};
my $merged_biblio_ids = $args->{merged_biblio_ids};
if ($record && $merged_biblio_ids) {
my @fields = map {
MARC::Field->new('035', ' ', ' ', 'z' => $_)
} @$merged_biblio_ids;
$record->insert_fields_ordered(@fields);
}
}
sub before_authority_action {
my ($self, $args) = @_;
my $action = $args->{action};
return unless $action eq 'merge';
my $record = $args->{record};
my $merged_authority_ids = $args->{merged_authority_ids};
if ($record && $merged_authority_ids) {
my @fields = map {
MARC::Field->new('035', ' ', ' ', 'z' => $_)
} @$merged_authority_ids;
$record->insert_fields_ordered(@fields);
}
}
This will copy the identifier of deleted records inside 035$z of the
final record.
(035$z is for "Canceled/invalid system control number")
2. Add the plugin path to your $KOHA_CONF
3. Run misc/devel/install_plugins.pl. It should say:
Installed version
4. Apply patch and restart starman
5. Create two or more biblios with the same title. Make sure they are
indexed in your search engine.
6. Search for them. In the results check their corresponding boxes and
click on "Edit -> Merge records"
7. Merge them and verify that your plugin code was called. If you used
the example above, verify that it added a 035$z for each deleted
record.
8. Do the same for authorities
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36344] New: Add schema changes summary to release notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36344 Bug ID: 36344 Summary: Add schema changes summary to release notes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: r.delahu...@arts.ac.uk QA Contact: testo...@bugs.koha-community.org The community release notes have summaries at the end for new and deleted system preferences and new authorised values and letter codes but none for schema changes. A list of new/deleted tables and one for new/renamed/deleted columns in tables would be useful. For example, issues.renewals became issues.renewals_count in 21.11 but this change was buried in bug 30275 (and reports broke as we missed mention of the change). And the schema change in bug 26057 altered the meaning of ‘missing in transit’ as we had defined it in our MIT reports (so they broke too). Schema changes are now included in our ‘upgrade pain-points’ and we will look very closely at them. A summary of the changes would be very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Blocks||29392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 [Bug 29392] Add plugin hooks before merging biblios or authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize changed: What|Removed |Added Depends on||34943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 [Bug 34943] Add a pre-save plugin hook for biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #1 from Martin Renvoize --- Created attachment 163328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163328=edit Bug 36343: Add support for 'payload' to _after_biblio_action This patch adds support for the payload key into the _after_bilio_action plugin hook wrapper routine. This brings it more inline with how these 'action hooks' appear in Holds and circulation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32729] Deleting an item removes the itemnumber from old_issues when it probably should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32729 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36101 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32729 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36101] Deleting an item removes the itemnumber from old_reserves when it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36101 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #14 from Andrew Fuerste-Henry --- (In reply to Marcel de Rooy from comment #7) > (In reply to Lari Strand from comment #0) > > Unless there's a good reason for this data loss, the itemnumber should be > > preserved in old_reserves after deleting an item. > > Please explain why there is a good reason to do so. Keeping an itemnumber in > this table that does no longer exist is bad practice. The itemnumber in the reserves table may refer to an item in the items table or may refer to an item in the deleteditems table. The [table]/deleted[table] structure for items and bibs supports the fundamental idea that a library may need to know about titles/items that were once in their collection but are not any longer. Even after an item has been removed from the collection, it's still useful to know which holds and checkouts involved that item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36343 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34943 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Keywords||Hackfest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36343] New: The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Bug ID: 36343 Summary: The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Our hooks should attempt to have a consistent routine signature whenever that can.. unfortunately, we've not been very good at spotting when patterns change. Whilst QAing bug 34943 we discovered an inconsistency in the hook signatures again. 'payload' vs no-payload. I propose we add support for 'payload' to the _after_biblio_action hook and set a deprecation period for the older signature style. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #163048|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 163327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163327=edit Bug 34943: (QA follow-up) Use `before_biblio_action` and an `action` param This patch harmonizes the hook name and parameters with the rest of the codebase. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa => SUCCESS: All looks green, and tests still pass (i.e. they were correctly adjusted to the new schema). 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #161696|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 163326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163326=edit Bug 34943: Implement `before_biblio_metadata_store` plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #161695|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 163325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163325=edit Bug 34943: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #26 from Martin Renvoize --- Good catch, thanks for highlighting that Tomas. Oh the fun of trying to stay consistent when we're already rather inconsistent aye. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35426] Improve layout of bookings modal form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 --- Comment #11 from Martin Renvoize --- I think we can backport this regardless of my negative comments.. I'd just love to see us get more consistent overall somehow in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Blocks||36342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 [Bug 36342] Allow entering date ranges directly in bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Blocks||36342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 [Bug 36342] Allow entering date ranges directly in bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36342] New: Allow entering date ranges directly in bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 Bug ID: 36342 Summary: Allow entering date ranges directly in bookings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 29002, 33703 We add input masking to flatpickr in bug 33703 but we explicitly disable it for the range case which is used in bookings. There are options to support this in the Maskito library too, so we could consider adding it back for bookings inputs too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 [Bug 33703] Entering dates should be more flexible accepting different entry formats -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #67 from Martin Renvoize --- This all looks great to me and works in my testing... it would be food to get a final QA as the implementation library changed during all the work but I think that can be fairly quick.. I'd also happily take a signoff from Owen to be a QA tick as someone familiar with the UI/Ux challenges this helps resolve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163083|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 163324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163324=edit Bug 33703: Add Maskito to about.tt Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163082|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 163323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163323=edit Bug 33703: Add Maskito support for OPAC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163081|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 163322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163322=edit Bug 33703: Add Maskito to dateaccessioned.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163080|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 163321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163321=edit Bug 33703: Don't use Maskito when picking a range Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163079|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 163320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163320=edit Bug 33703: Add time support Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize changed: What|Removed |Added Attachment #163078|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 163319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163319=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #24) > Look good to me.. I'm still comparing to the _after_biblio_action_hooks sub > though and the signature looks a little different with a top level hash vs a > hash under a 'payload' key.. thoughts on that? Yeah, I looked at C4::Reserves and C4::Circulation hooks and found those were all following this pattern. I'm not attached to any pattern, but the one I picked seems to be used more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #24 from Martin Renvoize --- Look good to me.. I'm still comparing to the _after_biblio_action_hooks sub though and the signature looks a little different with a top level hash vs a hash under a 'payload' key.. thoughts on that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34543] Content block accessibility helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #18 from Martin Renvoize --- I think this is still really important, but the patches no longer apply as is. As for fallbacks mentioned by Katrin, looking at the code it looks like it does just fallback to the value whenever a vendor record isn't found.. is that not enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27679] The notices and slips management area should be moved to 'Administration'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27679 --- Comment #4 from Martin Renvoize --- Still interested.. generally I'm interested in any efforts to simplify and clarify UI/UX and this counts as that to me. We do indeed need nice fine-grained permissions as part of that though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #9 from Kyle M Hall --- Created attachment 163318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163318=edit Bug 34643: (QA follow-up) Add new sysprefs to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #60 from Martin Renvoize --- Another rebase done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161591|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 163317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163317=edit Bug 28762: Unit tests for not_for_loan accessor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161590|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 163316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163316=edit Bug 28762: Add test for new 'instructors' accessor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161589|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 163315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163315=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161588|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 163314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163314=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161587|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 163313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163313=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize changed: What|Removed |Added Attachment #161586|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 163312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163312=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
