[Koha-bugs] [Bug 36368] Cannot save new patron after error

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36368

--- Comment #5 from Katrin Fischer  ---
(In reply to Emmi Takkinen from comment #4)
> Setting bugs importance as major since this is quite nasty bug. Feel free to
> change it.

I just did the same on another CSRF related bug, thanks for catching this one -
certainly not an enh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36368] Cannot save new patron after error

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36368

Emmi Takkinen  changed:

   What|Removed |Added

   Severity|enhancement |major

--- Comment #4 from Emmi Takkinen  ---
Setting bugs importance as major since this is quite nasty bug. Feel free to
change it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36379] Authorities search is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

--- Comment #17 from Emmi Takkinen  ---
(In reply to Laura Escamilla from comment #16)
> Hi! 
> 
> Thank you again for working on this patch! It works as described. :)
> 
> These could be follow-up bugs, but I think it would be helpful to have a
> column in the batch modify holds tool that either has the item barcode, or
> item number / bib record hyperlinked for easy access. 
> 
> It would also be helpful to display which items have a holds status that can
> not be suspended. It is difficult to determine at a glance which item cannot
> be suspended and it might be frustrating to libraries who are trying to
> suspend hundreds of holds at a time.

Hi!

Thank you for feedback :) I'll take a look what I can do to these and other
feedback I received from our superlibrarians. I'll probably provide separate
feedback patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329

--- Comment #13 from Katrin Fischer  ---
Pushed the follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #12 from Katrin Fischer  ---
We have seen the error 500 with a broken CHECKOUT/CHECKIN or HOLD notice
template. Maybe something to check (deactivate in the messaging preferences for
the patron or make sure there is no hold info coming up, see if that works)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #46 from David Cook  ---
Yeah it'll be something like that.

Sorry for not being more useful 😭

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #45 from Lucas Gass  ---
(In reply to David Cook from comment #44)
> (In reply to David Cook from comment #43)
> > Ah right. I think we removed some tests in master. I'll take a look...
> 
> Ran out of time to look at this today, but the answer is in master (via bug
> 34478 most likely).

Ah, thanks! I think 23.05 needs something like this:

https://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=t/Token.t;h=355282c6ed83f89f18ed0b7609667772f579b991;hp=d34089a9087a372dfcd0d50cb9d2c3e483daeb3f;hb=c9375e746b3f57e8c1101fce32d48138dc9c030b;hpb=f859c30704f868b11e0b5bbfb8185d4966ba0606

Will look tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #11 from Christian Pine  ---
(In reply to Jonathan Druart from comment #7)
> Christian, can you confirm this? Do you see the column in the DB?
> 
> Use 'desc checkout_renewals;' in the database CLI.

here is the result -->

mysql> desc checkout_renewals;
+--++--+-+---+---+
| Field| Type   | Null | Key | Default   |
Extra |
+--++--+-+---+---+
| renewal_id   | int| NO   | PRI | NULL  |
auto_increment|
| checkout_id  | int| YES  | | NULL  | 
 |
| renewer_id   | int| YES  | MUL | NULL  | 
 |
| seen | tinyint(1) | YES  | | 0 | 
 |
| interface| varchar(16)| NO   | | NULL  | 
 |
| timestamp| timestamp  | NO   | | CURRENT_TIMESTAMP |
DEFAULT_GENERATED |
| renewal_type | enum('Automatic','Manual') | NO   | | Manual| 
 |
+--++--+-+---+---+
7 rows in set (0.00 sec)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

--- Comment #14 from David Cook  ---
(In reply to David Cook from comment #13)
> (In reply to Katrin Fischer from comment #4)
> > Should we include a default/sample robots.txt with Koha?
> 
> It is tempting to add a robots.txt file to the koha-common package.

We still notice users of the standard koha-common package getting bitten by
bots due to a lack of a robots.txt file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #44 from David Cook  ---
(In reply to David Cook from comment #43)
> Ah right. I think we removed some tests in master. I'll take a look...

Ran out of time to look at this today, but the answer is in master (via bug
34478 most likely).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36328] C4::Scrubber should allow more html tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328

David Cook  changed:

   What|Removed |Added

 Attachment #163497|0   |1
is obsolete||

--- Comment #10 from David Cook  ---
Created attachment 163584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163584&action=edit
Bug 36328: Add a separate 'note' profile

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36328] C4::Scrubber should allow more html tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328

David Cook  changed:

   What|Removed |Added

 Attachment #163193|0   |1
is obsolete||

--- Comment #9 from David Cook  ---
Created attachment 163583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163583&action=edit
Bug 36328: Add test

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36328] C4::Scrubber should allow more html tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328

David Cook  changed:

   What|Removed |Added

 Attachment #163192|0   |1
is obsolete||

--- Comment #8 from David Cook  ---
Created attachment 163582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163582&action=edit
Bug 36328: Add p span div to Scrubber

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36328] C4::Scrubber should allow more html tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36328] C4::Scrubber should allow more html tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36328

--- Comment #7 from David Cook  ---
(In reply to Jonathan Druart from comment #6)
> Would this patch work for you? Here I am trying to tackle down bug 19613.

Looks good. I'll look at signing this off pronto...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36367] Remove context stack

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36367

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36304] Allow option to automatically trust cloudflare proxies

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36304

--- Comment #3 from David Cook  ---
Thanks for your work on this, Nicholas.

I don't mean to be a stickler, but since koha_trusted_proxies is a
koha-conf.xml config, it probably makes sense to have this one be one too. 

I like the idea of using the Cloudflare API to keep an up-to-date list, but the
list rarely changes. According to https://www.cloudflare.com/en-gb/ips/ it's
only changed 4 times in about 7 years. 

So I'm not sure that we should have each worker call the API on startup.
Personally, I find the startup super slow already. It might make more sense for
the list to be updated by a cronjob. Perhaps the "TrustCloudFlare" config
option could be a path to the list. 

Another thought I had might be to add a timeout to LWP::UserAgent, because I
think it defaults to 180 seconds. If there were an issue with the CloudFlare
API, I don't think you'd want each worker to wait 3 minutes before starting up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #12 from wainuiwitikap...@catalyst.net.nz ---
Can this please be rebased for 22.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

--- Comment #12 from David Cook  ---
(In reply to Martin Renvoize from comment #11)
> Plugins could lead to cross tenant exposures with this more easily I think. 
> Also worth some consideration

Agreed. I think there's another bug report or IRC chat where I talk about how
plugins would be a big problem for multi-tenancy. 

I'm not sure how practical it's going to be for Koha, even if I would love it
from a resource perspective...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27066] Implement hooks for patrons updates

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066

--- Comment #17 from David Cook  ---
(In reply to Martin Renvoize from comment #10)
> tl;dr I don't think 'before' or 'after' hooks should directly affect the
> data of the action.
> 
> We probably want 'before' and 'after' hooks.. and maybe even an 'around'.
> 
> Generally, a 'before' hook is for triggering actions prior to store (but not
> affecting the data for the store itself).. 'after' is for triggering actions
> after the store (like triggering zebraqueue.. again, it shouldn't affect the
> data of the store itself) and an around wraps the store and returns the
> updated data for the store to then act upon.
> 
> At least, that's my vague understanding of 'before', 'after', 'around' in
> other frameworks?

That's an interesting point. I hadn't thought of that...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29198] Inconsistencies in OPAC results display vs staff results display

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29198

cart...@slolibrary.org  changed:

   What|Removed |Added

 CC||cart...@slolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34596] Items in transit should not show up in the holds queue

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34596

cart...@slolibrary.org  changed:

   What|Removed |Added

 CC||cart...@slolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36364] Enhancement to non-EDI receiving

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36364

vesco...@altadenalibrary.org  changed:

   What|Removed |Added

 CC||vesco...@altadenalibrary.or
   ||g
   Priority|P5 - low|P1 - high

--- Comment #1 from vesco...@altadenalibrary.org  
---
A "select all" button would be extremely helpful when receiving multiple items 

For items where the information is correct:  The staff person would verify the
prices, quantity, and fund from this page and if everything is correct, check
the check box.  Once all the items for the invoice are verified and checked,
the yellow ‘Receive selected (X)’ button would actually receive the items. And
the items would be moved to the Already received part of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35934] Items in transit show as both in-transit and Available on holdings list

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35934

cart...@slolibrary.org  changed:

   What|Removed |Added

 CC||cart...@slolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #43 from David Cook  ---
(In reply to Lucas Gass from comment #42)
> This is causing some tests to fail in 23.05.x:
> 
> https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D10/
> lastCompletedBuild/testReport/
> https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D11/
> lastCompletedBuild/testReport/
> https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D12/
> lastCompletedBuild/testReport/

Ah right. I think we removed some tests in master. I'll take a look...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163144|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 163580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163580&action=edit
Bug 36321: Problem when dateexpiry in BorrowerUnwantedField

hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form.
The problem is when editing an existing patron the value is re-computed with
category settings, as if it where empty.

This comes from all fields in BorrowerUnwantedField beeing removed from
%newdata in memberentry.pl.
Whe must skip dateexpiry.

Test plan :
1) Be sure dateexpiry is not in BorrowerUnwantedField
2) Define a patron category with enrollment period 12 month
3) Create a new patron in this category
4) Its expiration date is in now + 12 month
5) Edit the patron category to set enrollment period 6 month
6) Add dateexpiry in BorrowerUnwantedField
7) Edit the patron and save
=> Without patch the expiration date is changed to now + 6 month
=> With patch the exporation date is unchanged

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36336] Exporting records from detail page is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36336

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163577|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 163579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163579&action=edit
Bug 36336: (bug 34478 follow-up) Fix export from catalogue detail

Signed-off-by: Owen Leonard 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163575|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 163578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163578&action=edit
Bug 36207: Use confirmation modal when removing tags from titles in the OPAC

This patch changes the process of removing a tag from a title on the
user's tag list. It now uses a confirmation modal dialog instead of a
JavaScript alert.

The patch also makes some minor tweaks to CSS to correct style on
"remove" links.

To test, apply the patch and rebuild the OPAC CSS.

 - Log in to the OPAC as a user who has submitted multiple tags or tags
   on multiple items.
  - Open the "Tags" link in the sidebar of the user summary page.
  - Click the "Remove tag" link next to one of the titles in the table
of the user's tags.
  - You should see a modal confirmation message, "Are you sure you want
to remove the selected tag from this title?" It should show the
title and the tag which will be removed.
  - Test both the "Yes, remove tag" and "No, do not remove tag" choices.

  - Check the box next to one of the tagged titles and click the
"Remove selected tags" button at the bottom of the table.
  - You should see a modal confirmation message, "Are you sure you want
to remove this item from the list?" It should show the title and
the tag which will be removed.
  - Test boh the "Yes" and "No" choices.

  - Check the box next to multiple tagged titles and click the
"Remove selected tags" button at the bottom of the table.
  - You should see a modal confirmation message, "Are you sure you want
to remove the selected tags from these titles" It should show the
titles of all the records you selected and the corresponding tags to be
removed.
  - Test both the "Yes" and "No" choices.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23285] Add patrons PATCH route

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23285

--- Comment #9 from Katrin Fischer  ---
(In reply to Fridolin Somers from comment #8)
> I've tested and I cant do partial update with PUT.
> I get "missing property" message.
> 
> I think since for both post and put we define for body :
> schema:
>   $ref: "../swagger.yaml#/definitions/patron"
> 
> And in /api/v1/swagger/definitions/patron.yaml we have:
> required:
>   - surname
>   - library_id
>   - category_id

It works, but you need to include those three always right now. (I just
recently looked into that and we had discussed it on IRC)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27647] Allowing lists to have a hierarchical structure/groups

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27647

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278

--- Comment #21 from Katrin Fischer  ---
I think just replacing the markers is not enough, as sometimes we need to make
sure to add a [% FOREACH %] loop in the right spots as well (ACQORDER; *DGST;
...) It might work, but needs some thought. 

I think having nice sample notices is a great first step and then we can figure
out the next ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #42 from Lucas Gass  ---
This is causing some tests to fail in 23.05.x:

https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D10/lastCompletedBuild/testReport/
https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D11/lastCompletedBuild/testReport/
https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D12/lastCompletedBuild/testReport/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Emily Lamancusa  changed:

   What|Removed |Added

 Blocks|36379   |
 Depends on||36379


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379
[Bug 36379] Authorities search is broken
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36379] Authorities search is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379

Emily Lamancusa  changed:

   What|Removed |Added

 Depends on|36192   |
 Blocks||36192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Emily Lamancusa  changed:

   What|Removed |Added

 Blocks||36379


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379
[Bug 36379] Authorities search is broken
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36379] New: Authorities search is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379

Bug ID: 36379
   Summary: Authorities search is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emily.lamanc...@montgomerycountymd.gov
QA Contact: testo...@bugs.koha-community.org
Depends on: 36192

In KTD:
1. Go to a biblio record
2. Click Edit > Edit Record
3. Pick a field with an authority link (e.g. 100$a) and click the tag editor
button to open an authority search popup
4. Enter some search terms and click "Search"
5. Nothing happens


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36345] Deleting related things causes data loss for old_reserves

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36336] Exporting records from detail page is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36336

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36336] Exporting records from detail page is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36336

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #163528|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 163577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163577&action=edit
Bug 36336: (bug 34478 follow-up) Fix export from catalogue detail

Signed-off-by: Owen Leonard 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27647] Allowing lists to have a hierarchical structure/groups

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27647

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

--- Comment #4 from Noémie Labine  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Kyle M Hall  ---
I think maybe a future enhancement would be to validate the branch ip when it
is  saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

--- Comment #2 from Kyle M Hall  ---
Created attachment 163576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163576&action=edit
Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is
not set correctly

We can get into a scenario what a user cannot stay logged in for more than a
single page load.
If AutoLocation is enabled with branch IP addresses being set to a space, you
will be logged out with every page load.

Test Plan:
1) Set your branch ip to a space
2) Enable AutoLocation
3) Restart all the things!
4) Log out
5) Log in
6) Browse to another page
7) You are logged out
8) Apply patch
9) Repeat 1-6
10) You are not logged out!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22861] Add ability to turn on/off the display of a public list

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22861

--- Comment #4 from Noémie Labine  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

--- Comment #1 from Kyle M Hall  ---
It looks like branchip has to contain a space to trigger the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

Kyle M Hall  changed:

   What|Removed |Added

Summary|Cannot stay logged in if|Cannot stay logged in if
   |AutoLocation is enabled but |AutoLocation is enabled but
   |branch ip is not set|branch ip is not set
   ||correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36357] Add Template::Toolkit filters for internationalization (I18N)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36357

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Kyle M Hall  ---
Getting
Can't locate object method "new" via package "Template::Filters" (perhaps you
forgot to load "Template::Filters"?) at /kohadevbox/koha/C4/Templates.pm line
74

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36378] New: Cannot stay logged in if AutoLocation is enabled but branch ip is not set

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378

Bug ID: 36378
   Summary: Cannot stay logged in if AutoLocation is enabled but
branch ip is not set
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We can get into a scenario what a user cannot stay logged in for more than a
single page load. If AutoLocation is enabled without branch IP addresses being
set, you will be logged out with every page load.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34355] Automated MARC record ordering process

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Matthias Le Gac  changed:

   What|Removed |Added

 Attachment #159147|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Matthias Le Gac  changed:

   What|Removed |Added

 CC||matthias.le-...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30299] Create a Registration API to allow for use of email verification when outside systems are registering patrons

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30299

Wally DesChamps  changed:

   What|Removed |Added

 CC||wdescha...@prospertx.gov

--- Comment #3 from Wally DesChamps  ---
Most of us use email as our primary communication medium.  Between email client
filters, local firewalls, and 3rd party systems such as amazonses, email
communication is fast becoming unreliable.  We need an automated way that will
quickly verify that the provided email address/communication [initially] works
at the new-member application stage.  With the marriages of discovery systems,
like Aspen, this is important to be able for companion systems function
seamlessly together.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

--- Comment #1 from Owen Leonard  ---
Created attachment 163575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163575&action=edit
Bug 36207: Use confirmation modal when removing tags from titles in the OPAC

This patch changes the process of removing a tag from a title on the
user's tag list. It now uses a confirmation modal dialog instead of a
JavaScript alert.

The patch also makes some minor tweaks to CSS to correct style on
"remove" links.

To test, apply the patch and rebuild the OPAC CSS.

 - Log in to the OPAC as a user who has submitted multiple tags or tags
   on multiple items.
  - Open the "Tags" link in the sidebar of the user summary page.
  - Click the "Remove tag" link next to one of the titles in the table
of the user's tags.
  - You should see a modal confirmation message, "Are you sure you want
to remove the selected tag from this title?" It should show the
title and the tag which will be removed.
  - Test both the "Yes, remove tag" and "No, do not remove tag" choices.

  - Check the box next to one of the tagged titles and click the
"Remove selected tags" button at the bottom of the table.
  - You should see a modal confirmation message, "Are you sure you want
to remove this item from the list?" It should show the title and
the tag which will be removed.
  - Test boh the "Yes" and "No" choices.

  - Check the box next to multiple tagged titles and click the
"Remove selected tags" button at the bottom of the table.
  - You should see a modal confirmation message, "Are you sure you want
to remove the selected tags from these titles" It should show the
titles of all the records you selected and the corresponding tags to be
removed.
  - Test both the "Yes" and "No" choices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35067] Allow authorised value parent category so categories can be linked and shown together

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35067

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #16 from Esther Melander  ---
I tested this and everything works as it should when I select an authorized
value from the Child category. I went back and edited the same record to change
the authorized value to a selection from the parent category and the
bibliographic detail view displayed a period punctuation mark and not the
value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32617] Koha thinks a rule is currently being edited if All patron All type rule has a Hard Due Date

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32617

--- Comment #1 from Noémie Labine  ---
Still valid in 23.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36120] Add pickup locations to Bookings

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

--- Comment #60 from Nick Clemens  ---
This works great in a lot of ways, but I found a couple issues:
1 - We need unit tests for the pickup_locations change and the API
2 - The pickup_locations for items should be set from the list for that item,
not from the entire bib so far:
for my $location (@pickup_locations) {
should be
for my $location (@{$item_pickup_locations}) {
3 - When changing branches, item options are disabled - if there are 100+ items
you may have to scroll through all the disabled options to find the correct one
4 - If you click on any single item, the 'Any item' option is disabled and
cannot be chosen again
5 - The pickup_library_id is defaulted to NULL - it should be NOT NULL to match
hold pickup location

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35800] edit_any_item permission required to see patron name in detail page

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.03   |24.05.00,23.11.03,23.05.10
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #13 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27182] Add ability to rename a MARC modification template

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36355] Auth/csrf.ts is failing if library with long info in the DB

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36355

--- Comment #6 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36355] Auth/csrf.ts is failing if library with long info in the DB

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36355

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351

--- Comment #14 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36327] Items view - Deletion of items is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327

--- Comment #10 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36327] Items view - Deletion of items is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #44 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36377


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36377
[Bug 36377] Fix translatability issues in koha-backend.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36327] Items view - Deletion of items is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|36377   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36377
[Bug 36377] Fix translatability issues in koha-backend.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36377] Fix translatability issues in koha-backend.js

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36377

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|36327   |36351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327
[Bug 36327] Items view -  Deletion of items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351
[Bug 36351] CSRF Adjustments for Cataloguing editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351

--- Comment #13 from Katrin Fischer  ---
There are some new and some pre-existing translatability issues with this one,
I filed a separate bug:
Bug 36377 - Fix translatability issues in koha-backend.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36327] Items view - Deletion of items is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327

--- Comment #9 from Katrin Fischer  ---
There are some new and some pre-existing translatability issues with this one,
I filed a separate bug:
Bug 36377 - Fix translatability issues in koha-backend.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36327] Items view - Deletion of items is broken

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36377


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36377
[Bug 36377] Fix translatability issues in koha-backend.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36377] New: Fix translatability issues in koha-backend.js

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36377

Bug ID: 36377
   Summary: Fix translatability issues in koha-backend.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, jonathan.dru...@gmail.com
Depends on: 36327

There are some strings in this .js file, that are not using the double
underscore, but only a single one (this won't work):

+error => {
+callback( { error: _('Could not parse response') } );
+}
+);},
+error => {
 callback( { error: _('Could not save record') } );


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36327
[Bug 36327] Items view -  Deletion of items is broken
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163573|0   |1
is obsolete||

--- Comment #11 from David Gustafsson  ---
Created attachment 163574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163574&action=edit
Bug 30515: Move Overdue transports to patron messaging preferences

Add syspref for using patron specific message preferences for
overdue messages instead of patron category level preferences.

To test:
1) Set UsePatronPreferencesForOverdueNotices to "individual patron preference"
2) Enable some transport for a patron in the messaging preferences form
2) Check out an item and set a due date that will result in an overdue notice
4) Run the overdue_notices.pl script
5) Verify that messages has been sent for the selected transport(s)
6) Run gather_print_notices.pl and verify a print notice is generated
7) Set UsePatronPreferencesForOverdueNotices to "when no other transport
   set"
8) Run the overdue_notices.pl and gather_print_notices.pl and verify
   that no print notice is generated
9) Disable all transports for the patron
10) Run the overdue_notices.pl and gather_print_notices.pl and verify
that print notice is generated
11)  Set UsePatronPreferencesForOverdueNotices to "never"
12) Run the overdue_notices.pl and gather_print_notices.pl and verify
that no print notice is generated
13) Enable some transport(s) for the patron
14) Run the overdue_notices.pl and gather_print_notices.pl and verify
that no print notice is generated
15) Set UsePatronPreferencesForOverdueNotices to "patron category"
16) Run the overdue_notices.pl and gather_print_notices.pl and verify
the patron category and library setting is used

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36376] Display library limitations issue in patron's messages

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||36376


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376
[Bug 36376] Display library limitations issue in patron's messages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36376] Display library limitations issue in patron's messages

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||31422


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422
[Bug 31422] Library limitations might cause data loss when editing patrons
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36376] New: Display library limitations issue in patron's messages

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376

Bug ID: 36376
   Summary: Display library limitations issue in patron's messages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 31422 added a warning message when library limitations issue in patron
edition page.
We should add this patron's messages in circ and details pages.
Like age limitations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35868] Warning sign for using a patron category that is limited to another library has moved to other side of page

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35868

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163564|0   |1
is obsolete||

--- Comment #10 from David Gustafsson  ---
Created attachment 163573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163573&action=edit
Bug 30515: Move Overdue transports to patron messaging preferences

Add syspref for using patron specific message preferences for
overdue messages instead of patron category level preferences.

To test:
1) Set UsePatronPreferencesForOverdueNotices "individual patron preference"
2) Enable some transport for a patron in the messaging preferences form
2) Check out an item and set a due date that will result in an overdue notice
4) Run the overdue_notices.pl script
5) Verify that messages has been sent for the selected transport(s)
6) Run gather_print_notices.pl and verify a print notice is generated
7) Set UsePatronPreferencesForOverdueNotices to "when no other transport
   set"
8) Run the overdue_notices.pl and gather_print_notices.pl and verify
   that no print notice is generated
9) Disable all transports for the patron
10) Run the overdue_notices.pl and gather_print_notices.pl and verify
that print notice is generated
11)  Set UsePatronPreferencesForOverdueNotices to "never"
12) Run the overdue_notices.pl and gather_print_notices.pl and verify
that no print notice is generated
13) Enable some transport(s) for the patron
14) Run the overdue_notices.pl and gather_print_notices.pl and verify
that no print notice is generated

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Martin Renvoize  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

--- Comment #2 from Martin Renvoize  ---
Just a quick proof of concept here...  Nice to have, but could have performance
implications and would need some tidying up before it's ready for prime time
(like, I'd like different items in different colors and the dots to have a
hover function that would yield item detail)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35800] edit_any_item permission required to see patron name in detail page

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800

Elise Konya  changed:

   What|Removed |Added

 CC||elise.konya@bywatersolution
   ||s.com

--- Comment #12 from Elise Konya  ---
Seconding Caroline's request! Could this be backported to 23.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

--- Comment #1 from Martin Renvoize  ---
Created attachment 163572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163572&action=edit
Bug 36373: Show existing bookings in the datepicker

This patch exposes existing bookings as info dots in the flatpickr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36374] The bookings modal JS should be tidied

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36373


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373
[Bug 36373] Show existing bookings in datepicker
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|36373   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373
[Bug 36373] Show existing bookings in datepicker
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|29002   |36374


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002
[Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374
[Bug 36374] The bookings modal JS should be tidied
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36374] The bookings modal JS should be tidied

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374

--- Comment #9 from Jonathan Druart  ---
As we also need other files (koha-tmpl/intranet-tmpl/prog/js/fetch/ should all
be tidied), maybe we should have a flag in the files (/* keep me tidy */) we
could git grep to list them? For discussion, I can have a look tomorrow. I am a
bit afraid to have a hardcoded list in 3 different places (koha, qa, git hook)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27182] Add ability to rename a MARC modification template

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182

--- Comment #2 from Miranda Nero  ---
Came here to file a bug about this myself. This would be extremely useful! 

A use case for me: I created a bunch of templates based on the specific MARC
tags they were updating and they were all next to each other, but as we've
created more templates, the original ones I created are now spread out. It
would be helpful if I could rename them to include something at the beginning
of each one so they would be sorted next to each other permanently.

Another use case: fixing typos!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27182] Add ability to rename a MARC modification template

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182

Miranda Nero  changed:

   What|Removed |Added

 CC||mn...@oslri.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36120] Add pickup locations to Bookings

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

--- Comment #59 from Martin Renvoize  ---
Just a rebase on the tidy up bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >