[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Victor Grousset/tuxayo  ---
Thanks for the follow-up.

> ("CircConfirmItemPartsSCI", ?, NULL, "Deny checkout of multipart items for 
> self-checkin", "Yes/No"),

Hmm, that question mark pretty sus.
Somehow it doesn't exploded when populating the DB and can go unnoticed :o

So, it should be 0, right? Because we copy CircConfirmItemParts in the dbrev
and here it defaults to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383

Andrii Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36324

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

Andrii Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36324

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36324] Authority editor missing move icon next to subfields

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324

Andrii Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36388,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35383

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36324] Authority editor missing move icon next to subfields

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324

Andrii Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #3 from Andrii Nugged  ---
I am noting here Bug 35383 and Bug 36388 to check those solutions: at least
even if not something to borrow, but to keep same styling in solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

--- Comment #3 from Andrii Nugged  ---
Note: there was related issue: Bug 35383, solved differently, but I think we
should analyze how to make "common", unified solution with same coding style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383

Andrii Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36388

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

Andrii Nugged  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35383
 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #13 from Christian Pine  ---
(In reply to Katrin Fischer from comment #12)
> We have seen the error 500 with a broken CHECKOUT/CHECKIN or HOLD notice
> template. Maybe something to check (deactivate in the messaging preferences
> for the patron or make sure there is no hold info coming up, see if that
> works)

Deactivate the messaging preferences - not working
Hold info - I disable the patrons ability to place hold in opac but its not
working

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 163657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163657=edit
Bug 34643: (QA follow-up): fix order of new sysprefs and quotation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988

--- Comment #14 from wainuiwitikap...@catalyst.net.nz ---
(In reply to wainuiwitikapark from comment #12)
> Can this please be rebased for 22.05

Figured out the conflicts

Backported for for 22.05.20

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36330] Fix typo: reseve

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330

--- Comment #2 from Alex Buckley  ---
Created attachment 163656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163656=edit
Bug 36330: Change 'reseve' to 'reserve'

Test plan:
1. git grep 'reseve'. Notice there are instances of 'reseve'
2. Apply patch
3. Repeat step 1, there should be no instances of 'reseve'

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36330] Fix typo: reseve

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330

Alex Buckley  changed:

   What|Removed |Added

 Attachment #163655|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36330] Fix typo: reseve

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 Status|NEW |Needs Signoff
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36330] Fix typo: reseve

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330

--- Comment #1 from Alex Buckley  ---
Created attachment 163655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163655=edit
Bug 36330: Change 'reseve' to 'reserve'

Test plan:
1. git grep 'reseve'. Notice there are instances of 'reseve'
2. Apply patch
3. Repeat step 1, there should be no instances of 'reseve'

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Hammat wele  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

--- Comment #1 from Hammat wele  ---
Created attachment 163654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163654=edit
Bug 36393: Renewal with a specific date does not take the new date due that we
pick

When we renew a notice with a specific date and we have to override the limit,
the new date due is not the date that we picked

To reproduce

1- Log in to the staff interface
 1-1. Make sure you have a ciculation rule that allows you to renew
 1-2. set the AllowRenewalLimitOverride system preference to Allow and
SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and
note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from
step 5 and submit
8. Click on Override limit and renew button
 ---> Note that the new date due is not the date that we picked in step 7
9. Apply the patch
10. Repeat step 6, 7 snd 8
 ---> Note that the new date due is the date that we picked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Hammat wele  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Hammat wele  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Hammat wele  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hammat.w...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] New: Renewal with a specific date does not take the new date due that we pick

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Bug ID: 36393
   Summary: Renewal with a specific date does not take the new
date due that we pick
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hammat.w...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reproduce

1- Log in to the staff interface
 1-1. Make sure you have a ciculation rule that allows you to renew
 1-2. set the AllowRenewalLimitOverride system preference to Allow and
SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and
note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from
step 5 and submit
8. Click on Override limit and renew button
 ---> Note that the new date due is not the date that we picked in step 7

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

--- Comment #84 from Katrin Fischer  ---
(In reply to Fridolin Somers from comment #83)
> Note there is an error in commit to master :
> b374358e84 Bug 35539: (QA follow-up) Remove defer_marc_save from
> Elasticsearch.t
> 
> Maybe need to fix manually in release notes.

Thanks Frido - I think it was bound to happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36392] Only 20 vendors in ERM dropdown

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords||regression
   Severity|enhancement |normal
 Depends on||34219

--- Comment #1 from Caroline Cyr La Rose  ---
I bisected and found that it was due to bug 34219 which was added to 23.05.04
which makes sense because my client's 23.05.05 has the wrong behaviour.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219
[Bug 34219] getAll not allowing additional parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34219] getAll not allowing additional parameters

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||36392


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392
[Bug 36392] Only 20 vendors in ERM dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

Donna  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Donna  ---
Beautiful! Works as expected, and if there are two notices, both color boxes
show on the modal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #163647|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 163653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163653=edit
Bug 31981: Add classes to each NEEDSCONFIRM message in circ/circulation.tt

This patch adds a 'needsconfirm' class and a unique class to each NEEDSCONFIRM
message on circ/circulation.tt to make these easier to style individually.

To test:
1. APPLY patch
2. Review the diff to see each of the NEEDSCONFIRMATION messages.
3. Add some CSS to IntranetUserCSS like this:

.needsconfirm { padding: 1em; color: #fff; }

.reserved { background: blue; }
.debt { background: red; }
.reserve_waiting { background: orange; }
.rentalcharge { background: purple; }
.renew_issue { background: limegreen; }

4. Place a hold on an item for Patron A, do not trigger the hold, and check the
item out to Patron B.  The message background is blue.
5. Then check the item in, confirm the hold, then check the item out to Patron
B.  The message background is orange
6. Check something out that is already checked out to that patron, message
background is lime green.
7. Have too much debt and check something out to a patron, message is red.

Note: There are plenty more NEEDSCONFIRMATION messages but I don't think we
need to test every single one.
Note: These background colors are more testing purposes only.
Signed-off-by: Donna 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393

--- Comment #35 from Alex Buckley  ---
(In reply to Kyle M Hall from comment #34)
> While I tend to agree PDF generation isn't the greatest, this is a minor
> enhancement and it was far too onerous to ask to replace an entire subsystem
> to add such a small enhancement. Let's get this in!

Thank you very much Kyle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36385] HTML escaped via JavaScript should encode all entities

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36385

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36364] Enhancement to non-EDI receiving

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36364

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #2 from Barbara Johnson  ---
+1 

Option #1 in the attached 'receiving workflow' document would be a wonderful
improvement. Most of our invoices don't require any changes in quantity, price
or fund so being able to do all the receiving work on the parcel.pl screen
would be such a great time saver. 

Right now, for an invoice with 50 items on it, I have to check 50 checkboxes on
parcel.pl. Then I have to click the 'Edit' button once on orderreceive.pl and
then the 'Next order' button 49 more times in order to cycle through every item
on the invoice. If the all receiving could be done on parcel.pl it would cut my
time in half!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36392] Only 20 vendors in ERM dropdown

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||36392


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392
[Bug 36392] Only 20 vendors in ERM dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36392] Only 20 vendors in ERM dropdown

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||32468


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468
[Bug 32468] Vendors select only allows selecting from first 20 vendors by
default
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36392] New: Only 20 vendors in ERM dropdown

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392

Bug ID: 36392
   Summary: Only 20 vendors in ERM dropdown
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.dru...@gmail.com
  Reporter: caroline.cyr-la-r...@inlibro.com
CC: jonathan.dru...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
matt.blenkin...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com

When there are more than 20 vendors in acquisitions, only 20 appear in the New
agreement dropdown list.

To recreate:
1. Enable the ERMModule system preference
2. In Acquisitions, create more than 20 vendors (see below for an sql insert
that I used)
3. Go to E-resource management > Agreements > New agreement
4. Open the vendor dropdown
   --> It stops at Sierra (or the 20th vendor if you created your own)
5. Type "Tango" or "Zulu" (or one of the names of your 21st+ vendor)
   --> No results

This is what I used to create all the vendors

INSERT INTO aqbooksellers (name,active) VALUES ('Alpha','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Bravo','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Charlie','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Delta','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Echo','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Foxtrot','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Golf','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Hotel','1');
INSERT INTO aqbooksellers (name,active) VALUES ('India','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Juliet','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Kilo','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Lima','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Mike','1');
INSERT INTO aqbooksellers (name,active) VALUES ('November','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Oscar','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Papa','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Quebec','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Romeo','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Sierra','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Tango','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Uniform','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Victor','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Whiskey','1');
INSERT INTO aqbooksellers (name,active) VALUES ('X-Ray','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Yankee','1');
INSERT INTO aqbooksellers (name,active) VALUES ('Zulu','1');

Paul D. pointed me to the RESTdefaultPageSize system preference which does
affect the dropdown. If I change the syspref to 50, I can see all the vendors
in the dropdown. The problem with this is that I'm not sure what else this
syspref affects. I have a client with 674 vendors, I don't want to put 1000 in
the syspref and then somewhere else something takes forever to load because of
this.

I'm not sure what is happening here. I found bug 32474 and bug 32468 that seem
to deal with this and that are marked as fixed, but I don't see the correct
behaviour in ktd with master. I hope someone else can confirm or invalidate
this...

The client who pointed this out to me (the one with 674 vendors) is on
23.05.05, which already has the patches from bug 32468.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163633|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 163652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163652=edit
Bug 36388: Mouse operation does not work in draggable fields in authority
editor

When using the authority editor in Firefox, it is not possible to set
the cursor or select text from the text field.

This patch mimics the corrections made in bug 35425 for biblio editor.

Test plan:
==
1. Start editing an existing authority record and try to put the cursor
   with the mouse in the middle of the content of any subfield or to
   select text with the mouse. It should not be possilbe.
2. Apply the patch (reload plack etc.).
3. Repeat p. 1 - everything should work as expected.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163650|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 163651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163651=edit
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163649|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 163650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163650=edit
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278

--- Comment #24 from Lisette Scheer  ---
(In reply to Martin Renvoize from comment #23)

> As for the --- digest thing, I feel like the logic for that one is backwards
> and strange.. we should be generating the notice all in one hit at a later
> point in time rather than queuing a notice and then munging extra stuff into
> it after the fact at various times.

The --- digest thing also doesn't make much sense to me. 
 With putting it together at one point in time, would that mean that say for
hold notices when notices send every hour that before that happened it would
build and check for the patron any waiting holds that had been set to waiting
since the last one? 

Or perhaps we could set some sort of flag when the hold is trapped that gets
cleared when the notice is sent?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35541] Chosen renewal due date not respected when we override limit

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35541

--- Comment #3 from Noémie Labine  ---
still valid in 23.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35541] Chosen renewal due date not respected when we override limit

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35541

--- Comment #2 from Noémie Labine  ---
hi Katrin,

I mean the renew page.

If we override the renewal restrictions and choose a due date manually in the
patron's account, this date is respected.

But in the renew page, if I choose a renewal date, then confirm that I want to
override the restriction, then the date I chose is not respected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36391] New: There is no listing of the cron job : archive_purchase_suggestions in the manual

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36391

Bug ID: 36391
   Summary: There is no listing of the cron job :
archive_purchase_suggestions in the manual
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

There is no listing of the cron job: archive_purchase_suggestions in the
current manual.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

--- Comment #1 from Owen Leonard  ---
Created attachment 163649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163649=edit
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36390] New: Two minor OPAC CSS fixes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36390

Bug ID: 36390
   Summary: Two minor OPAC CSS fixes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

1. Some Font Awesome icons are not getting styled correctly because we forgot
to update the class list to include .fa-solid.

2. The floating toolbar on pages like catalog search results has an unwanted
top margin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

 Attachment #163646|0   |1
is obsolete||

--- Comment #14 from Matthias Le Gac  ---
Created attachment 163648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163648=edit
Bug 21272: Change warning message

To test

Before make sure backgroundjobs process is running
(/misc/workers/background_jobs_worker.pl --queue long_tasks)

1- Go to Cataloging -> Stage records for import
2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or
homelibraary set and is not present in your installation
3- Click on Stage for import
4- Click on View batch
--> There is no message for the missing branches
5- Click on "Import this batch into the catalog"
--> The importation failed
6- Apply the patch
7- Run prove -t t/db_dependent/ImportBatch.t
8- Click on "Manage imported batch"
--> There is a warning message showing the missing branches in a link
9- Click on "Import this batch into the catalog" again
--> The records are imported
--> The items with wrong branches are ignored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Lucas Gass  ---
Looks promising. 

With this patch applied and UsePatronPreferencesForOverdueNotices set to
"individual patron preference" I do not see the Overdue messaging preferences
on the patron form. 

Maybe GetMessagingOptions (C4/Members/Messaging.pm) needs to be updated so it
can retrieve Overdue1, Overdue2, and Overdue3? 


Thanks for working on this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35172] Order receiving error

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172

Erin A.  changed:

   What|Removed |Added

 CC||erin.arn...@marionfl.org

--- Comment #6 from Erin A.  ---
We are seeing this error in 23.05.08  Thanks for looking into it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278

--- Comment #23 from Martin Renvoize  ---
It's not just the custom --- handling if digests that need thought.. there is
also a customer loop syntax in our <<>> style I believe.. that and the special
handling for attributes code conversion stuff that I'm already also working on.

As for the --- digest thing, I feel like the logic for that one is backwards
and strange.. we should be generating the notice all in one hit at a later
point in time rather than queuing a notice and then munging extra stuff into it
after the fact at various times.


Food for thought.  Happy to grab a call some time to discuss the things I've
been contemplating around this area for some time now if it helps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35796] Patron password expiration date lost when patron edited by superlibrarian

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35796

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36359] Broken OPAC mainpage layouts in 23.05.09

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36359

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #5 from Andrew Fuerste-Henry  ---
+1, this would be helpful

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33583] Put back the biblionumber column in batch records import table

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33583

--- Comment #1 from Noémie Labine  ---
still valid in 23.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

--- Comment #4 from Lucas Gass  ---
Created attachment 163647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163647=edit
Bug 31981: Add classes to each NEEDSCONFIRM message in circ/circulation.tt

This patch adds a 'needsconfirm' class and a unique class to each NEEDSCONFIRM
message on circ/circulation.tt to make these easier to style individually.

To test:
1. APPLY patch
2. Review the diff to see each of the NEEDSCONFIRMATION messages.
3. Add some CSS to IntranetUserCSS like this:

.needsconfirm { padding: 1em; color: #fff; }

.reserved { background: blue; }
.debt { background: red; }
.reserve_waiting { background: orange; }
.rentalcharge { background: purple; }
.renew_issue { background: limegreen; }

4. Place a hold on an item for Patron A, do not trigger the hold, and check the
item out to Patron B.  The message background is blue.
5. Then check the item in, confirm the hold, then check the item out to Patron
B.  The message background is orange
6. Check something out that is already checked out to that patron, message
background is lime green.
7. Have too much debt and check something out to a patron, message is red.

Note: There are plenty more NEEDSCONFIRMATION messages but I don't think we
need to test every single one.
Note: These background colors are more testing purposes only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

--- Comment #13 from Matthias Le Gac  ---
Created attachment 163646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163646=edit
Bug 21272: Change warning message

To test

Before make sure backgroundjobs process is running
(/misc/workers/background_jobs_worker.pl --queue long_tasks)

1- Go to Cataloging -> Stage records for import
2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or
homelibraary set and is not present in your installation
3- Click on Stage for import
4- Click on View batch
--> There is no message for the missing branches
5- Click on "Import this batch into the catalog"
--> The importation failed
6- Apply the patch
7- Run prove -t t/db_dependent/ImportBatch.t
8- Click on "Manage imported batch"
--> There is a warning message showing the missing branches in a link
9- Click on "Import this batch into the catalog" again
--> The records are imported
--> The items with wrong branches are ignored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #29 from Kyle M Hall  ---
Created attachment 163645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163645=edit
Bug 35826: Make copy of cost matrix when substituting inf

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #28 from Kyle M Hall  ---
Created attachment 163644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163644=edit
Bug 35826: Add unit tests.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #27 from Kyle M Hall  ---
Created attachment 163643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163643=edit
Bug 35826: Keep items on retry.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #26 from Kyle M Hall  ---
Created attachment 163642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163642=edit
Bug 35826: Fix errors in transport cost optimization

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #161373|0   |1
is obsolete||
 Attachment #161956|0   |1
is obsolete||
 Attachment #163017|0   |1
is obsolete||
 Attachment #163018|0   |1
is obsolete||
 Attachment #163107|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 163641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163641=edit
Bug 35826: optimize on transport cost when building holds queue

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

Lucas Gass  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31981] Add classes to each NEEDSCONFIRM message for easier styling in circ/circulation.tt

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981

Lucas Gass  changed:

   What|Removed |Added

Summary|Need to be able to more |Add classes to each
   |clearly distinguish between |NEEDSCONFIRM message for
   |hold warning boxes  |easier styling in
   ||circ/circulation.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28108] Move action logs 'SERIAL CLAIM' and 'ACQUISITION CLAIM' to a new 'CLAIMS' module

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||36389


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389
[Bug 36389] Acquisition order logging does not depend on AcquisitionLog system
preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36389] Acquisition order logging does not depend on AcquisitionLog system preference

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||28108


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108
[Bug 28108] Move action logs 'SERIAL CLAIM' and 'ACQUISITION CLAIM' to a new
'CLAIMS' module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36389] Acquisition order logging does not depend on AcquisitionLog system preference

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36389] New: Acquisition order logging does not depend on AcquisitionLog system preference

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389

Bug ID: 36389
   Summary: Acquisition order logging does not depend on
AcquisitionLog system preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Since Bug 28108 logging acquisition order is in module 'ACQUISITIONS'.
So logging must depend on AcquisitionLog system preference.
Currently it depends on ClaimsLog system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

   Assignee|hammat.w...@inlibro.com |matthias.le-...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Matthias Le Gac  changed:

   What|Removed |Added

Summary|MARC import should warn |MARC import should warn
   |about mis-matched branch|about mis-matched branch
   |and item-type fields in 952 |during staged import
   |during staged import|
 CC||matthias.le-...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35149] Add "do nothing" option to CircAutoPrintQuickSlip syspref

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #162323|0   |1
is obsolete||

--- Comment #7 from Laura Escamilla  ---
Created attachment 163640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163640=edit
Bug 35149: Change CircAutoPrintQuickSlip syspref explanation

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35149] Add "do nothing" option to CircAutoPrintQuickSlip syspref

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #157800|0   |1
is obsolete||

--- Comment #6 from Laura Escamilla  ---
Created attachment 163639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163639=edit
Bug 35149: Add Option to ignore submit of checkout field when empty

1) Apply patch
2) Set CircAutoPrintQuickSlip to "do nothing"
3) Go to the checkouts form for a specific patron
4) Submit the form with empty value
5) Verify that no action is taken and you stay on the current page

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35149] Add "do nothing" option to CircAutoPrintQuickSlip syspref

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278

--- Comment #22 from Emily Lamancusa  
---
Hmmm, I hadn't actually thought about replacing the digest syntax... [% FOREACH
%] doesn't work for digest-building, because the  marker doesn't represent
a piece of logic or substitution internal to one notice, but rather it's
metadata that tells the code how to parse and store the prepared message so
that a new message can be combined properly with an old message after the fact,
without duplicating the parts that should be the same:

> sub _metadata {
>my ($letter) = @_;
>if ($letter->{content} =~ //) {
>my ($header, $body, $footer) = split(/\r?\n?/, $letter->{content});
>return {
>header => $header,
>body   => [$body],
>footer => $footer,
>};
>} else {
>return {
>header => '',
>body   => [$letter->{content}],
>footer => '',
>};
>}
> }

Is that something we can (usefully) replace with Template Toolkit? (this may
also be a "next step" question, to avoid making the perfect the enemy of the
good)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #163343|0   |1
is obsolete||

--- Comment #7 from Laura Escamilla  ---
Created attachment 163638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163638=edit
Bug 35129: Return 400 if _per_page=0 passed

This patch adds a safe guard for when consumers pass _per_page=0 to
endpoints. This condition is checked for on a centralized place and
avoid reaching the controller in such scenarios that would provoke a
division by zero exception.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/pagination.t
=> FAIL: We expect a 400, but get a 500 instead
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! No more explosions for this!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #163342|0   |1
is obsolete||

--- Comment #6 from Laura Escamilla  ---
Created attachment 163637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163637=edit
Bug 35129: Regression tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36120] Add pickup locations to Bookings

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

--- Comment #75 from Martin Renvoize  ---
(In reply to Nick Clemens from comment #60)
> 3 - When changing branches, item options are disabled - if there are 100+
> items you may have to scroll through all the disabled options to find the
> correct one

Can we put this one on a follow-up bug.. it pre-exists this bug (selecting
dates and then trying to select item also disables but available items but
doesn't re-order the select list)

> 4 - If you click on any single item, the 'Any item' option is disabled and
> cannot be chosen again

This is resolved too

There's also a follow-up for something I spotted when digging more deeply.. we
now account for the dates AND pickup locations in combination when disabling
item options.. prior to that last patch we had a race condition where the most
recent selected option would govern which items could be selected rather than
both working in combination.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36120] Add pickup locations to Bookings

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

--- Comment #74 from Martin Renvoize  ---
Created attachment 163636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163636=edit
Bug 36120: Account for both pickup_location and date selection in items

This patch ensures we account for both pickup location and date
selections having taken place before an item selection is pondered. We
now correctly disable item options given both conditions rather than it
being a race between the two.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36120] Add pickup locations to Bookings

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

--- Comment #73 from Martin Renvoize  ---
Created attachment 163635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163635=edit
Bug 36120: Re-enable 'Any item' selectable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36376] Display library limitations alert in patron's messages

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #163621|0   |1
is obsolete||

--- Comment #3 from Laura Escamilla  ---
Created attachment 163634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163634=edit
Bug 36376: Display library limitations alert in patron's messages

Bug 31422 added a warning message when library limitations issue in patron
edition page.
We should add this patron's messages in circ and details pages.
Like age limitations.

Test plan:
1) User's login branch and home library is: Centerville
2) Patron category "B - Board" is limited to Franklin
3) Edit a patron with Board category from Centerville
4) A message appears "The patron's current category (Board) is limited to other
libraries."

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36376] Display library limitations alert in patron's messages

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388

Janusz Kaczmarek  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |janus...@gmail.com
   |ity.org |

--- Comment #1 from Janusz Kaczmarek  ---
Created attachment 163633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163633=edit
Bug 36388: Mouse operation does not work in draggable fields in authority
editor

When using the authority editor in Firefox, it is not possible to set
the cursor or select text from the text field.

This patch mimics the corrections made in bug 35425 for biblio editor.

Test plan:
==
1. Start editing an existing authority record and try to put the cursor
   with the mouse in the middle of the content of any subfield or to
   select text with the mouse. It should not be possilbe.
2. Apply the patch (reload plack etc.).
3. Repeat p. 1 - everything should work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36294] Replace inaccurate use of "book" in system preferences

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36294

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #163290|0   |1
is obsolete||

--- Comment #2 from Laura Escamilla  ---
Created attachment 163632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163632=edit
Bug 36294: Replace 'book' in system preference descriptions

Some system preference descriptions have been updated in order
to replace "books" with items, checkouts or bibliographic records.

To test:

* Check system preference descriptions for following system
  preferences with and without the patch applied:
  * virtualshelves
  * AutoSwitchPatron
  * SyndeticsSeries
  * OPACFineNoRenewals
  * OpacRenewalAllowed
* If they read better than before, sign off :)

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36294] Replace inaccurate use of "book" in system preferences

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36294

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #162609|0   |1
is obsolete||

--- Comment #20 from Laura Escamilla  ---
Created attachment 163631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163631=edit
Bug 34920: Add cypress tests

Run the agreements cypress test spec:

cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #162608|0   |1
is obsolete||

--- Comment #19 from Laura Escamilla  ---
Created attachment 163630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163630=edit
Bug 34920: Ensure 'description' property is an empty string if 'lib' is null

Test plan:
1. Enable ERM module
2. Confirm that you can open the ERM module in the staff interface.
3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit
the 'Cancelled' authorized value by removing the description. Making this
change with any of the ERM authorized values will result in an error.
4. Go back to the ERM module and notice that there is an error. 'Something went
wrong: Error: Expected string - got null.'
5. Apply patch. Run yarn js:build. Repeat test plan
6. Create a new agreement. Pick status 'Closed'.
7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty
entry below that.

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #162605|0   |1
is obsolete||

--- Comment #18 from Laura Escamilla  ---
Created attachment 163629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163629=edit
Bug 34920: Add API endpoint tests

prove koha/t/db_dependent/api/v1/authorised_values.t

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #162604|0   |1
is obsolete||

--- Comment #17 from Laura Escamilla  ---
Created attachment 163628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163628=edit
Bug 34920: Return sorted av_cats to be able to test

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-03-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >