[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 --- Comment #23 from David Cook --- I need to switch tasks, but let me know what you think. Otherwise, I can QA stamp this tomorrow... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 --- Comment #22 from David Cook --- For completeness, we should remove the AutoSelfCheck stuff from opac/sco/printslip.pl as well, since it's covered by the second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 --- Comment #21 from David Cook --- With the 1st patch, we've got manual log in fixed for /cgi-bin/koha/sco/sco-main.pl If it's the first session, I can manually log into /cgi-bin/koha/sci/sci-main.pl (However, if I log into /cgi-bin/koha/sco/sco-main.pl and then log into /cgi-bin/koha/sci/sci-main.pl it doesn't work, as I'm presented with the message "Access denied. Sorry, the system doesn't think you have permission to access this page." It looks like it's because it's doing the "kick_out" since we have $is_sco_user. That's a current system thing so nothing to worry about.) -- The 2nd patch fixes AutoSelfCheckAllowed, but I can see what Jonathan means about it being ugly. Something to keep in mind is that we're re-authenticating on every SCO page load, but my bug 34478 commit 8b69d0b4d3e72171d9f2d51234f345405a433c4f actually makes the AutoSelfCheck session persistent, so once we have that authenticated session, we don't really need to re-authenticate. One option could be to move the AutoSelfCheck auth process into "checkauth". Another option could be to allow sco-main.pl to do a sort of "preauth" and create its own authenticated session before get_template_and_user() if necessary. (At the moment, this is sort of what we're trying to do by force stuffing the AutoSelfCheck credentials on every load of sco-main.pl.) However, this option would need some tweaks to things like get_template_and_user() and checkauth() to be able to accept a sessionID passed in (instead of just looking at the incoming session cookie). So I think we could do something a bit smarter when handling our sessions. -- But... both of those options would take more work. Jonathan has provided something that already appears to work, and we're getting closer to our May release deadline, so I think perhaps we shouldn't make the perfect the enemy of the good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] New: Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Bug ID: 36515 Summary: Amend MARC modification templates so control fields can be copied to subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be nice if MARC modification templates could work with control fields - specifically to copy control fields to subfields. A MARC control field is a field where the tag is less than 10, e.g. 001. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36514] New: The "kick_out" in auth should return an anonymous session instead of no session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36514 Bug ID: 36514 Summary: The "kick_out" in auth should return an anonymous session instead of no session Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At the moment, when we "kick_out" of the self-checkout or the self-checkin, we send a CGISESSID cookie with an empty value and force the web app to render opac-auth.tt However, this doesn't really make sense. If the user just reloads the page again, they'll see the real template. And if you want to link to the self-registration from the self-checkout (say in a new tab), you'll want to see the real template instead of a login screen. -- In theory, it shouldn't be too hard to do this. We'll just want to create an anonymous session and return the actual requested template. This isn't a top priority for me at the moment, but I do have a library interested in this, so I might find myself working on this... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 --- Comment #20 from David Cook --- Sorry for neglecting this one so long. I'm taking a deeper look at the issue today... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Mason James changed: What|Removed |Added Attachment #164116|0 |1 is obsolete|| --- Comment #15 from Mason James --- Created attachment 164403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164403=edit Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #14 from Mason James --- (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #7) > > So we still need to package our own. > > > > Mason, are you ok with that? We would need to remove the '-really' and > > provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 > > No need to keep this in SO. > Mason, please respond or update our packages accordingly. hi Marcel, i've updated the packages in the staging repo i've had to keep the '+really' suffix, so existing packages will be correctly updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #32 from Victor Grousset/tuxayo --- It works :) --- > [% content | $raw %] Where is the `content` variable from? Review note: here is how to see the diff with the moved parts colored as such, thus leaving less lines to analyze in details. git diff upstream/master --color-moved --color-moved-ws=allow-indentation-change Also, there are some parts with alignment changes that are trivial to read with this: git diff --color-words=. upstream/master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #164185|0 |1 is obsolete|| --- Comment #31 from Victor Grousset/tuxayo --- Created attachment 164402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164402=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 3) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #164184|0 |1 is obsolete|| --- Comment #30 from Victor Grousset/tuxayo --- Created attachment 164401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164401=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #164183|0 |1 is obsolete|| --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 164400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164400=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #164182|0 |1 is obsolete|| --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 164399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164399=edit Bug 36118: Send patron object to template Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #164181|0 |1 is obsolete|| --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 164398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164398=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||NEW INSTALLATIONS ONLY. release notes||This sets the default value ||for the AutoRenewalNotices ||system preference to ||"according to patron ||messaging preferences". ||(The previous default value ||was deprecated - ||"(Deprecated) according to ||--send-notices cron ||switch".) --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Check the system preference AutoRenewalNotices - note that the default is "(Deprecated) according to --send-notices cron switch". 2. Apply the patch. 3. Reset everything (like it is a new installation): reset_all 4. Note that the AutoRenewalNotices system preference is now set to "according to patron messaging preferences". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind changed: What|Removed |Added Attachment #164394|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 164397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164397=edit Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 David Nind changed: What|Removed |Added Attachment #164395|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 164396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164396=edit Bug 36507: Allow non-superlibrarians to set desk and register To test: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks, get an error 5. Turn on UseCashRegisters 6. Create some registers 7. As a non-superlibrarian try to change your register, get an error. 8. APPLY PATCH and restart_all 9. Try changing your desk and register again, it should now work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36513] New: Default report output to template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36513 Bug ID: 36513 Summary: Default report output to template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org With the addition of templates for formatting reports (YAY!), it would be great if we had a way to default the display of a report through a template. Currently, there is no way to get to the final format of a report that has runtime parameters through a template without running the report first, then selecting the template. Templates are easy to run reports through if all the needed parameters are already in the URL, but if you need those parameters entered when the report is run, you options are limited. I would suggest that the report editor include an option to default the output to a specified template, or if you include a template parameter in the url, it would fist ask for runtime parameters, and then run the report with the template and parameters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36512] Build printing into reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36512 Christopher Brannon changed: What|Removed |Added Summary|Replace html export with|Build printing into reports |printing| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36512] New: Replace html export with printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36512
Bug ID: 36512
Summary: Replace html export with printing
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs@lists.koha-community.org
Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
Currently, to print a report via template, you have to export the report to an
html file, then open it and print it.
I would like to suggest building the print into the report. I currently use
the following via jquery:
//Report Printing (v23.05)
if($('#rep_guided_reports_start #format').length) {
$('#format').siblings('ul').append('Print Report');
$('#mnuPrintReport').on('click', function () {
var reportInfo = '' + $('#ReportContent').html()
+ '';
var myWindow=window.open('','','');
myWindow.document.write(reportInfo);
myWindow.document.close();
setTimeout(function(){
myWindow.focus();
myWindow.print();
myWindow.close();
},500);
});
}
//END Report Printing
Any report I want to print must be wrapped in
This works for templated reports, and might also work for regular reports. The
div could be baked into to code.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36098] Create Koha::Session module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098 --- Comment #24 from David Cook --- (In reply to Frédéric Demians from comment #23) > Backported to 22.11.x for 22.11.16 Many thanks :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36511] New: Local cover images in admin interface after update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36511 Bug ID: 36511 Summary: Local cover images in admin interface after update Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: isabel.pin...@ds.edu.sv QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Today I updated Koha from version 23.11.03 to 23.11.04 and now the local cover images of the books are not visible anymore in the admin interface. In the OPAC they are still visible normally. When I upload a new local cover image, I can see it in the OPAC interface too, but not in the admin interface. Is there some error in the update? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 --- Comment #4 from Lucas Gass --- Thanks for your work here Brendan! I have two questions: 1. Do we need all this JavaScript in desk_selection.js? Can't we just use what is already in set-library.tt? [% PROCESS options_for_desks desks => Desks.all(), selected => desk_id %] 2. Are there any circumstances where a user should be able to unset their desk? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #3 from Lucas Gass --- Created attachment 164395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164395=edit Bug 36507: Allow non-superlibrarians to set desk and register To test: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks, get an error 5. Turn on UseCashRegisters 6. Create some registers 7. As a non-superlibrarian try to change your register, get an error. 8. APPLY PATCH and restart_all 9. Try changing your desk and register again, it should now work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk or register as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Lucas Gass changed: What|Removed |Added Summary|Cannot set desk as non |Cannot set desk or register |superlibrarian |as non superlibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36510] New: Add CircControl information to circulation and fine rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36510 Bug ID: 36510 Summary: Add CircControl information to circulation and fine rules page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: he...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It would be great to see, from the circulation rules, smart-rules.pl, what is set in CircControl. The pertinent preferences for holds and return policies appear in the default holds policy section, so it would be nice and increase transparency to see Circ Control setting near the circulation rule matrix and would make trouble-shooting circulation anomalies easier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 --- Comment #1 from Brendan Lawlor --- Created attachment 164394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164394=edit Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Brendan Lawlor changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11456] Add validation to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11456 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31451] Can the display order be applied incrementally for item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31451 --- Comment #2 from Miranda Nero --- I would like to see it go +1 from the highest display order set. My initial thought was to take the number of item groups and add 1, but in a case where we've deleted some of the earlier issues of a periodical, the earliest item group remaining might start at display order 20 and go to 40. The number of item groups would be 21 and that would put the next display order at 22 in the middle of the existing ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #18 from Emily Lamancusa --- Setting back to Needs Signoff, because these patches are different enough from the previous ones that they should be retested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163730|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163729|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #163728|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #17 from Emily Lamancusa --- Created attachment 164393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164393=edit Bug 34972: Remove GetOtherReserves GetOtherReserves attempts to set the waiting/transit status for the next hold on the list when applicable, but in practice it either leaves the hold state unchanged, or sets the itemnumber without setting the found status (erroneously converting bib-level holds to item-level holds). The latter situation only occurs when the user has been prompted to confirm, cancel, or revert the hold, and is able to ignore the prompt. In those situations, the hold's state should not change. GetOtherReserves does not need to change the hold state, and it does not do so correctly. Besides that, it does not do much other than call CheckReserves, and is only used in 3 places. This patch removes GetOtherReserves, and refactors returns.pl and C4::Reserves::ModReserveCancelAll to call CheckReserves directly instead. To test: 1. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 2. Check in an item from that record to fill Patron A's hold 3. Set the hold's expiration date to yesterday by accessing the database in the command line: - In a ktd shell prompt, open the db client with koha-mysql kohadev - UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE borrowernumber = 4. Go to Circulation > Holds Awaiting Pickup, and find the hold in the "holds waiting past their expiration date" tab 5. Click the "Cancel hold" button in the Actions column next to the hold 6. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status in the command line: - In a ktd shell prompt, open the db client with koha-mysql kohadev - UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE borrowernumber = 4. Go to Circulation > Holds Awaiting Pickup, and find the hold in the "holds waiting past their expiration date" tab 5. Click the "Cancel hold" button in the Actions column next to the hold 6. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 7. Cancel Patron B's hold 8. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 9. Check in an item to fill Patron A's hold 10. Repeat steps 3-5 to expire and cancel Patron A's hold 11. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a transit status 12. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 13. Check in an item from that record to fill Patron A's hold 14. Check in the same item again. A modal will pop up, saying that the hold is already waiting 15. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 16. Click "Ignore" on the modal for Patron B's hold 17. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 18. Apply patch 19. Repeat steps 1-6 --> Note that Patron B's hold is still a bib-level/"next available" hold 20. Repeat steps 7-11 --> Note that Patron B's hold is still a bib-level/"next available" hold 21. Repeat steps 12-17 --> Note that Patron B's hold is still a bib-level/"next available" hold Make sure correct behavior is unchanged: 22. Cancel Patron B's hold 23. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 24. Check in an item from that record to fill Patron A's hold 25. Check in the same item again. A modal will pop up, saying that the hold is already waiting 26. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 27. Click "Print slip, transfer, and confirm" on the modal for Patron B's hold --> Confirm that the information on the slip is correct --> Confirm that the hold is correctly put in transit 22. Set HoldsAutoFill and HoldsAutoFillPrintSlip to "Do" 23. Place a bib-level hold for the logged-in library 24. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 25. Place a bib-level hold for a different library 26. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly put in transit 27. Change the logged-in branch to match the hold pickup location 28. Check
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #16 from Emily Lamancusa --- Created attachment 164392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164392=edit Bug 34972: Add tests for ModReservesCancelAll To test: 1. Apply this patch only 2. prove t/db_dependent/Koha/Holds.t --> Tests pass 3. Apply the other patch 4. prove t/db_dependent/Koha/Holds.test --> Tests still pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36508] Patron userid field can be overwritten by update_patron_categories when limiting by fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36508 --- Comment #1 from Nick Clemens --- Created attachment 164391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164391=edit Bug 36508: Refresh patron object when updating category To test: 1 - Find a ptron, I sued #45 in KTD, note their category 2 - Update them from one category to another using finesunder: perl misc/cronjobs/update_patrons_category.pl -f ST -t S --finesunder=5.00 --where "me.borrowernumber=45" -v -c 3 - Check their modification log (I told you to enabled BorrowersLog, right?) 4 - See many fields reported changed 5 - Apply patch 6 - Repeat, but change the to and from options perl misc/cronjobs/update_patrons_category.pl -f S -t ST --finesunder=5.00 --where "me.borrowernumber=45" -v -c 7 - Note only one column changed in the logs 8 - Ask for unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #2 from Lucas Gass --- N(In reply to Lucas Gass from comment #1) > Typo: IsSuperLibraian/IsSuperLibrarian Not just a typo though, with that fixed I am still unable to set a desk as a non-superlibrarian -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36509] Add option to search authority records by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36509 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36509] New: Add option to search authority records by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36509 Bug ID: 36509 Summary: Add option to search authority records by ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36508] New: Patron userid field can be overwritten by update_patron_categories when limiting by fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36508
Bug ID: 36508
Summary: Patron userid field can be overwritten by
update_patron_categories when limiting by fines
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
In Koha::Patrons->search_patrons_to_update_category we join to accountlines and
sum when using the fines over and fines under parameters.
The way this sql works requires a GROUP BY - which means we limit the columns
to borrowernumber
This means the object we use to update later loses many of the fields we expect
to be there
We end up with entries in modification log like:
{ "address" : { "after" : null, "before" : "5129 Library Rd." }, "auth_method"
: { "after" : null, "before" : "password" }, "autorenew_checkouts" : { "after"
: null, "before" : 1 }, "branchcode" : { "after" : null, "before" : "MPL" },
"cardnumber" : { "after" : null, "before" : "2352950113" }, "categorycode"
: { "after" : "S", "before" : "ST" }, "checkprevcheckout" : { "after" : null,
"before" : "inherit" }, "city" : { "after" : null, "before" : "Centerville, CA"
}, "dateenrolled" : { "after" : null, "before" : "1985-09-09" }, "dateexpiry" :
{ "after" : null, "before" : "2099-12-31" }, "dateofbirth" : { "after" : null,
"before" : "1952-05-27" }, "firstname" : { "after" : null, "before" : "Jordan"
}, "lang" : { "after" : null, "before" : "default" }, "phone" : { "after" :
null, "before" : "(212) 555-1212" }, "privacy" : { "after" : null, "before" : 1
}, "sex" : { "after" : null, "before" : "M" }, "sort1" : { "after" : null,
"before" : "0.54121395064631" }, "sort2" : { "after" : null, "before" :
"0.90967674824379" }, "surname" : { "after" : null, "before" : "Alford" },
"userid" : { "after" : "1", "before" : "2352950113" }, "zipcode" : {
"after" : null, "before" : "44262" } }
Most of these are ignored, null interpreting as not being updated, however, the
cardnumber does overwrite as it is treated specially.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] Cannot set desk as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 --- Comment #1 from Lucas Gass --- Typo: IsSuperLibraian/IsSuperLibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36507] New: Cannot set desk as non superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507 Bug ID: 36507 Summary: Cannot set desk as non superlibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1. Turn on UseCirculationDesks 2. Create some desks 3. Login as a non-superlibrarian 4. Try to switch desks Undefined subroutine ::Context::IsSuperLibraian called at /kohadevbox/koha/circ/set-library.pl line 54 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 --- Comment #18 from Chris Cormack --- Hnmm yep should be all the same chrisc@bugs:~/git/koha-bz-new-skin$ git pull Already up to date. All the cache has been recently regenerated /home/chrisc/bugzilla/data/assets# ls -l total 564 -rw-r--r-- 1 www-data www-data 7188 Apr 3 20:20 068fbf28a45907d22559d2f18e9ad427.css -rw-r--r-- 1 www-data www-data 4437 Apr 3 20:20 09183300347452246bc79833bf05c8d7.js -rw-r--r-- 1 www-data www-data 41393 Apr 3 20:20 0e60506fcac2922d10d46589e488aadf.css -rw-r--r-- 1 www-data www-data 12185 Apr 3 20:20 14dc9f799a0a806eeb6c22ce8c06029f.css -rw-r--r-- 1 www-data www-data 43974 Apr 3 20:20 1b4e898422a669ab82b604a2c23edce5.js -rw-r--r-- 1 www-data www-data 2220 Apr 3 20:20 206bb8e5b8584223b92afae06825d2fa.js -rw-r--r-- 1 www-data www-data 7788 Apr 3 20:20 29f04fcbf22cac0aee8418f77a932db2.js -rw-r--r-- 1 www-data www-data 34795 Apr 3 20:20 2e6e421b95bc76c273c65f113df06e10.js -rw-r--r-- 1 www-data www-data 13853 Apr 3 20:20 3cf88792325e4ad5452dbb4678dab74a.css -rw-r--r-- 1 www-data www-data 20680 Apr 3 20:20 4771f85fa07673965f2fb48ee7890999.css -rw-r--r-- 1 www-data www-data 32490 Apr 3 20:20 78b05fb7e0c02dc46b22b57371396dc9.js -rw-r--r-- 1 www-data www-data 126953 Apr 3 20:20 7aea391f77d255cdd754e18ddbf1133b.js -rw-r--r-- 1 www-data www-data 37317 Apr 3 20:20 97bc1cb9bcf1bc3a46be479a4fac73c1.js -rw-r--r-- 1 www-data www-data 13146 Apr 3 20:20 9a1eac68bcb6da87dff82c4694ac9657.js -rw-r--r-- 1 www-data www-data 26038 Apr 3 20:20 a20619e3724298545775187a20becc70.css -rw-r--r-- 1 www-data www-data 4796 Apr 3 20:20 a7b424fa476ffa0a75b33046277d60f9.js -rw-r--r-- 1 www-data www-data 7204 Apr 3 20:20 a96c7c46c532e011e0d274f885cd3c54.css -rw-r--r-- 1 www-data www-data 27007 Apr 3 20:20 b23fb94f692daff240a2533ba14f3475.js -rw-r--r-- 1 www-data www-data 32865 Apr 3 20:20 d35b2bb4a51536ba7d6ddaa30b08e17e.css -rw-r--r-- 1 www-data www-data 0 Apr 3 20:20 d41d8cd98f00b204e9800998ecf8427e.js -rw-r--r-- 1 www-data www-data 32547 Apr 3 20:20 e99587309f7dfa5ed1b8537099ec4ec9.js -rw-r--r-- 1 www-data www-data963 Apr 3 20:20 f95ec5672c38d4e576a4ce2c0be59932.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19814] Batch Check-in function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 --- Comment #33 from Madge Boldt --- The ability to do a batch check in was resolved in Koha 23.05. There is a new Check In option at the bottom of Batch Item Modifications. Bywater highlights the change in their Monday Morning Minute. https://bywatersolutions.com/education/monday-minutes-batch-item-improvement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 --- Comment #3 from Brendan Lawlor --- For some reason when I made this commit the code got autoformatted in a way that I don't really like. The code still works, but could be nicer to read if the whitespace is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #19 from Andrew Fuerste-Henry --- When I had no categories selected in BatchCheckoutsValidCategories, only one checkout was allowed at a time, as you described (Step 6). Once I'd enabled one category in BatchCheckoutsValidCategories, however, I was able to perform batch checkouts via the SCO with any patron, regardless of their category. Otherwise everything worked as described. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 [Bug 32256] Self checkout batch mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||36349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 [Bug 36349] Login for SCO/SCI broken by CSRF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 Brendan Lawlor changed: What|Removed |Added Attachment #164389|0 |1 is obsolete|| --- Comment #2 from Brendan Lawlor --- Created attachment 164390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164390=edit Bug 30123: Set desk default to logged-in-desk-id on set library page This patch refactors the javascript that runs on the set library page. If the logged in user branch code is the same as the seleceted library, default the desk selection to the current logged in desk id. Otherwise set the default desk selection to the first option for the current branch. Test plan: 1. Turn on UseCirculationDesks 2. Create a few desks with unique names for a few different libraries 3. Set your library and desk 4. Reload set-library.pl and notice that the desk always defaults to the last option for the library selected 5. Apply patch and restart_all 6. Reload set-library.pl and notice that the desk selection defaults to your current logged in desk 7. Try changing the library selection to libraries with and without desks 8. Notice that the desk selection defaults to the first option available for the selected library 9. Notice that the desk selection defaults to the --- no desk for libraries without desks 10. Notice the desk selection defaults to the currenty logged in desk if you select the library you are currently logged into -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 Brendan Lawlor changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |blaw...@clamsnet.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 --- Comment #1 from Brendan Lawlor --- Created attachment 164389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164389=edit Bug 30123: Set desk default to logged-in-desk-id on set library page This patch refactors the javascript that runs on the set library page. If the logged in user branch code is the same as the seleceted library, default the desk selection to the current logged in desk id. Otherwise set the default desk selection to the first option for the current branch. Test plan: 1. Turn on UseCirculationDesks 2. Create a few desks with unique names for a few different libraries 3. Set your library and desk 4. Reload set-library.pl and notice that the desk always defaults to the last option for the library selected 5. Apply patch and restart_all 6. Reload set-library.pl and notice that the desk selection defaults to your current logged in desk 7. Try changing the library selection to libraries with and without desks 8. Notice that the desk selection defaults to the first option available for the selected library 9. Notice that the desk selection defaults to the --- no desk for libraries without desks 10. Notice the desk selection defaults to the currenty logged in desk if you select the library you are currently logged into -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 Brendan Lawlor changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36424] Database update 22.06.00.078 breaks update process (II)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 --- Comment #5 from Pablo AB --- COMMENTS apart, they are identical except for these differences: reserves: These lines are swapped. Like this on show create: KEY `itemtype` (`itemtype`), KEY `desk_id` (`desk_id`), old_reserves: Only on show create: KEY `old_desk_id` (`desk_id`), About `SHOW CREATE TABLE item_groups;`: ERROR 1146 (42S02): Table 'koha_myinstance.item_groups' doesn't exist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Cannot update patron attributes via PUT request on Patrons endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Katrin Fischer changed: What|Removed |Added Summary|Cannot update patron|Cannot update patron |attributes via PUT reuqst |attributes via PUT request |on Patrons endpoint |on Patrons endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36502] Independent branches should not prevent holds if canreservefromotherbranches is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 ByWater Sandboxes changed: What|Removed |Added Attachment #164376|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 164388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164388=edit Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D Signed-off-by: esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35391] In new order empty first item type is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391 Noémie Labine changed: What|Removed |Added CC||noemie.lab...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25990] `WhenLostChargeReplacementFee` and `WhenLostForgiveFine` preferences should be moved into circulation rules to be consistent with `RefundLostOnReturn` rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25990 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36506 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36506] Processing Fee should be configurable by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36506] New: Processing Fee should be configurable by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Bug ID: 36506 Summary: Processing Fee should be configurable by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In a consortia environment, some branches might want a process fee and others might not. This could be worked around with multiple item types, but that can cause other issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Cannot update patron attributes via PUT reuqst on Patrons endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164302|0 |1 is obsolete|| --- Comment #18 from Matthias Le Gac --- Created attachment 164387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164387=edit Bug 9762: Change how to pass the param Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Cannot update patron attributes via PUT reuqst on Patrons endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] New: Cannot update patron attributes via PUT reuqst on Patrons endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505
Bug ID: 36505
Summary: Cannot update patron attributes via PUT reuqst on
Patrons endpoint
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
CC: tomasco...@gmail.com
According to our docs, you can include an array of patron attributes on a
patrons PUT request:
https://api.koha-community.org/Development.html#tag/patrons/operation/updatePatron
When testing I sent:
{"category_id":"PT","library_id":"CPL","surname":"Ballard","extended_attributes":[{"extended_attribute_id":"1","type":"SHOW_BCODE","value":"0"}]}
And I got an error:
[2024/04/03 17:27:40] [ERROR] PUT /api/v1/patrons/21: unhandled exception
(Koha::Exceptions::Object::PropertyNotFound)<>
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357 --- Comment #34 from Andrii Nugged --- IGNORE MY REPORT please. (In reply to Victor Grousset/tuxayo from comment #33) > This is weird, 23.11.x has $dbh declared at the beginning of the function. > https://gitlab.com/koha-community/Koha/-/blob/23.11.x/C4/Circulation.pm#L1548 I double-checked, right, it is there. It was another codebase, where "dangling" $dbh-es (unused) were removed (and without code this $dbh was unused but declared here), now it's used, and all ok. so, whatever it is - it is all correct, false alamf from my side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35856] Runtime parameter modal should provide option of ":all"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #11 from Brendan Lawlor --- Thanks Owen! I like the vertical layout of the radio buttons. It's much easier to read. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #16 from Nick Clemens --- (In reply to Julian Maurice from comment #15) > There is at least 3 places where IsAvailableForItemLevelRequest is called > and CanItemBeReserved is not: > > * opac/opac-ISBDdetail.pl > * opac/opac-MARCdetail.pl > * opac/opac-detail.pl > > (side note: it's the same code in those 3 scripts and it's used to set a > template variable used only in opac-detail-sidebar.inc; should be moved into > a TT plugin ?) Indeed, I just added those checks on bug 34886 > Removing checks from IsAvailableForItemLevelRequest means that those checks > won't be done in these places. > > Instead, do you think it's possible to call IsAvailableForItemLevelRequest > from CanItemBeReserved ? (and remove calls to IsAvailableForItemLevelRequest > whenever CanItemBeReserved is called) See comment 1 - I think that's the ultimate goal Would you be willing to accept a smaller change in those scripts for now? $can_holds_be_placed = IsAvailableForItemLevelRequest($item, $patron, undef) && CanItemBeReserved($patron, $item, undef); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 --- Comment #2 from Nick Clemens --- Created attachment 164386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164386=edit Bug 36504: Add a test-email option This is not necessarily for pushing, but makes testing first patch easier as it doesn't require setting up email. Apply this patch, and add --test-email when runnign the script. The email object will be dumped to the screen and you can verofy the content of the body/attachment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 --- Comment #1 from Nick Clemens --- Created attachment 164385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164385=edit Bug 36504: Add attach_only option to run report To test: 1 - Create a report in Koha 2 - Have koha setup to send emails 3 - perl misc/cronjobs/runreport.pl --to="exam...@example.org" --subject="Report cronjob" --format=csv --csv-header -a 1 4 - Note the email body and attachment contain the results 5 - Apply this patch 6 - Repeat above 7 - Note the email body says "Repost results attached" 8 - Confirm results attached 9 - Adjust report to have 0 results 10 - perl misc/cronjobs/runreport.pl --to="exam...@example.org" --subject="Report cronjob" --format=csv --csv-header -a 1 --send_empty 11 - Confirm the attachment exists, but message body indicates no results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #98 from Katrin Fischer --- (In reply to Pedro Amorim from comment #97) > ./t/db_dependent/Illrequest directory still exists (it shouldn't after this > work). > I don't want to add anything else here before this is pushed because it's > long as it is. > @Tomas, @Katrin add it here or handle this later? It's not critically > important anyway. I haven't had time to look here closely yet, leaving it to Tomas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 164384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164384=edit Bug 36495: Use render_resource_deleted() helper everywhere This patch makes the API controllers use the render_resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 164383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164383=edit Bug 36495: Use render_resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi changed: What|Removed |Added Attachment #164291|0 |1 is obsolete|| Attachment #164377|0 |1 is obsolete|| Attachment #164378|0 |1 is obsolete|| Attachment #164380|0 |1 is obsolete|| --- Comment #14 from Tomás Cohen Arazi --- Created attachment 164382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164382=edit Bug 36495: Add render_resource_not_found() and render_resource_deleted() helpers This patch introduces two helpers to be used in controllers. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/responses.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #97 from Pedro Amorim --- ./t/db_dependent/Illrequest directory still exists (it shouldn't after this work). I don't want to add anything else here before this is pushed because it's long as it is. @Tomas, @Katrin add it here or handle this later? It's not critically important anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36504] New: Run report should have an option to only send the attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36504 Bug ID: 36504 Summary: Run report should have an option to only send the attachment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Currently, if runreport sends results via email, they are included in the body when also supplied as an attachment. Some libraries would like to receive only the attachment, to make the email less cluttered for large reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36497] Cancel unfilled holds should be a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36497 --- Comment #2 from he...@bywatersolutions.com --- That does sound like an elegant solution, Pedro. I like it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36497] Cancel unfilled holds should be a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36497 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m --- Comment #1 from Pedro Amorim --- Would something like CancelUnfilledHoldsAfter expecting a numeric input for days work? Default 0, with 0 meaning don't cancel. This would make it 1 sys pref instead of 2. cancel_unfilled_holds.pl would be updated to check, in the following order: 1 - Days supplied as cron parameter 2 - Days value configured in CancelUnfilledHoldsAfter (if >1) 3 - Show the same 'Error: You must specify a value for days waiting to cancel holds.' as it does currently if both above conditions fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36381] "not a tree object" error from Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36381 --- Comment #9 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #8) > Have we been able to reproduce one of this errors/warnings locally? It > certainly comes from the fact Jenkins is making a shallow clone from a > directory. No, see comment 2. I have tried to remove that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317
--- Comment #14 from Fridolin Somers ---
(In reply to Nick Clemens from comment #13)
> How is this failure encountered? Or is this the base for another bug?
>
> 1 - Enable EasyAnalyticalRecords
> 2 - Go to a records details page and copy a barcode
> 3 - Go to another record
> 4 - Edit -> Link to host record
> 5 - Enter the barcode
> 6 - Records are now linked, and display with no error
Currently there is no failure but there is a good chance in the future.
For example Bug 24192 wants to add :
$dat->{ITEM_RESULTS} = $biblio->host_items->search_ordered;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36416] Check out using CirculateILL is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36416 Pedro Amorim changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36414] Consequent workflow stages form submit fail due to CSRF token conflict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 Pedro Amorim changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 --- Comment #1 from Pedro Amorim --- Created attachment 164381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164381=edit Bug 35716: PoC **K-T-D TEST ONLY** At /kohadevbox/koha, run the following: - sudo cpan File::Copy::Recursive - sudo rm -rf /usr/share/koha - sudo perl Makefile.PL # press Enter on all prompts - sudo make install - find /usr/share/koha -name hello.js Notice the output: /usr/share/koha/opac/htdocs/opac-tmpl/js/hello.js /usr/share/koha/intranet/htdocs/intranet-tmpl/js/hello.js My first attemp was using the file_map that is used to PM but I failed. Even changing the code to allow for multiple targets in the file_map, the WriteMakefile will always only map 1 to 1 from the PM hashref. But PL_FILES allows for an array of destinations given one source. This patch needs more work as a SHARED_TMPL_DIR env variable would be ideal, amongst other improvements, but this is just a proof of concept to have others look at and see if they agree with this approach. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 Pedro Amorim changed: What|Removed |Added CC||lu...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36381] "not a tree object" error from Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36381 --- Comment #8 from Tomás Cohen Arazi --- Have we been able to reproduce one of this errors/warnings locally? It certainly comes from the fact Jenkins is making a shallow clone from a directory. The tip of the iceberg is the 'Koha_Source', as that name shouldn't be mentioned at all on the Jenkins runs: the clone is named as the task. Maybe it is a git version thing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36381] "not a tree object" error from Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36381
--- Comment #7 from Jonathan Druart ---
This is happening all the time with Docker_15 (last one is Koha_Master/2827)
It's coming from the 'git ls-tree' calls
t/00-testcritic.t:my @files = map { chomp; $_ } `git ls-tree -r HEAD
--name-only`;# only files part of git
t/Makefile.t:my @files = `git ls-tree HEAD|tr -s '\t' ' '|cut -d' ' -f4`;
xt/check_makefile.t:my @dirs = `git ls-tree -d --name-only HEAD`;
My guess is that it's coming from PTFS-e's nodes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36381] "not a tree object" error from Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36381 --- Comment #6 from Jonathan Druart --- I run out of ideas, we need somebody else to look into this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20340 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36503 CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
