[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #73 from Fridolin Somers  ---
(In reply to Katrin Fischer from comment #72)
> Hi Frido, why add the keyword, when this is already pushed?

Sorry it was to remember no backport to 23.11.x ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36616] Ability to stop Complex See Reference authority records from being linked to bibliographic records

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36616

--- Comment #4 from Aleisha Amohia  ---
Created attachment 165249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165249=edit
Bug 36616: [WIP] Add option to authority cataloguing plugin to show established
headings only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36616] Ability to stop Complex See Reference authority records from being linked to bibliographic records

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36616

--- Comment #3 from Aleisha Amohia  ---
Created attachment 165248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165248=edit
Bug 36616: Add LinkEstablishedHeadings system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 165247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165247=edit
Bug 25996: Add restrictions to the log viewer

This patch adds the new log actions, related to restrictions, to the log
viewer.

To test:
0. Set BorrowersLog to 'Log'
1. Pick a patron
2. Add a restriction and identify it's id, maybe using the DB:
   $ ktd --shell
  k$ koha-mysql kohadev
   > SELECT * FROM borrower_debarments;
3. Run [1]:
  k$ perl -MKoha::Patron::Debarments \
 -e 'Koha::Patron::Debarments::ModDebarment( { borrower_debarment_id =>
195, comment => "potato" } );'
4. Visit the log viewer.
=> SUCCESS: You can filter on 'Create restriction', 'Modify restriction'
and 'Delete restriction', things are displayed correctly.

[1] There's the ModDebarment method in the codebase, but I couldn't find
a way to trigger it for testing, so my last resort was to do it from the
CLI, manually. The tests on the previous patches cover the method
anyway.

Sponsored-by: Karlsruhe Institute of Technology (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 165246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165246=edit
Bug 25996: Add logging to restrictions actions

This patch adds logging for the following actions:

* CREATE_RESTRICITON
* MODIFY_RESTRICTION
* DELETE_RESTRICTION

To test:
1. Apply the unit tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Patron/Borrower_Debarments.t
=> FAIL: The feature is not implemented! Nothing is logged!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Sponsored-by: Karlsruhe Institute of Technology (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 165245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165245=edit
Bug 25996: Unit tests

Sponsored-by: Karlsruhe Institute of Technology (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 165244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165244=edit
Bug 25996: Make AddDebarment() use Koha::Patron::Restriction

This patch makes the AddDebarment() method use the Koha::Object-based
class to ease the next steps. The current codebase makes the feature
fragile otherwise, as adding a new row and then querying for the latest
row of that kind seems risky,

With this approach the result is the same, but we have the
Koha::Patron::Restriction object for using it later in logging.

I opted to return 1 as it does now. The whole module deserves to be
removed in the future but it is out of the scope of this report.

To test:
1. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Patron/Borrower_Debarments.t
=> SUCCESS: Tests pass
2. Apply this tiny refactoring patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Sponsored-by: Karlsruhe Institute of Technology (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36660] Make Authorities 'see from' searches more specific

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36660

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36660] New: Make Authorities 'see from' searches more specific

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36660

Bug ID: 36660
   Summary: Make Authorities 'see from' searches more specific
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

When searching for an authority, 'see from' unlinked headings show as links
that conduct new authority searches.

These searches are 'any' and 'contains' searches so they end up being quite
wide and unspecific, potentially producing more results than the original
search that suggested this 'see from' heading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

--- Comment #1 from Aleisha Amohia  ---
Created attachment 165243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165243=edit
Bug 36659: Show correct tab after conducting an Authorities search

To test:

1. In the staff interface, go to Authorities
2. Do a search for each tab, i.e. 'Main heading' and 'Entire record'
3. Notice every search has the 'Main heading ($a only)' tab selected when the
results page loads.

4. Apply patch and restart services

5. Repeat step 2 and confirm the appropriate tab is selected by default after
each search.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659
[Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25653] Authorities search does not retain selection

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659
[Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12295] Javascript error when merging authorities

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659
[Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||32683, 12295, 25653
   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295
[Bug 12295] Javascript error when merging authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653
[Bug 25653] Authorities search does not retain selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683
[Bug 32683] Convert header search tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] New: Authorities search tab keeps defaulting to main heading ($a only)

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Bug ID: 36659
   Summary: Authorities search tab keeps defaulting to main
heading ($a only)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

When doing a search from the Authorities home, it keeps selecting the 'Main
heading ($a only)' tab after conducting a search, even from the other tabs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33184] Warnings when running holds queue builder

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
I'm seeing a lot of these warnings in 23.11.x in my email inbox, which do get
annoying...

At a glance, this looks like a good change. 

If we could get a unit test for this, I think we could just pass it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36261] Calculating OpacHiddenItems is too slow in OPAC search

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36261

--- Comment #2 from David Cook  ---
(In reply to Andreas Jonsson from comment #1)
> Ideally we should resolve this at indexing time so we get the information
> directly from the search index.

You can't do it at indexing time, since OpacHiddenItems can be changed at any
time. (The OpacHiddenItems feature in general is a bad idea imho.)

> Also the systempreference OpacHiddenItemsHidesRecord could be implemented
> properly, as it now breaks the result count, and theoretically you could get
> a blank search result page with a positive result count, and visible results
> at page two.

I don't think this is possible since the calculation is too complex.
Personally, I'd rather deprecate OpacHiddenItemsHidesRecord and just require
OpacSuppression to be used for any record that must be completely hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

--- Comment #40 from Aleisha Amohia  ---
Created attachment 165242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165242=edit
Bug 23781: SMS notices and messaging preferences for recalls

This patch adds recalls notices (pick up a waiting recall or return a
requested recall) to the messaging preferences.

To test:
1) Apply Bug 19532
2) Apply this bug
3) Update database, restart services
4) Ensure UseRecalls syspref is enabled and values have been set in the
circulation rules for recalls
5) Go to a borrower (Person A) account page in the Intranet or the OPAC
6) Go to messaging preferences
7) Notice there are now preferences for two recalls notices
8) Select email as a preference
9) Find a different borrower (Person B) and set their messaging
preferences to SMS
10) Check out any item to Person B
11) Go to the OPAC logged in as Person A and find that item
12) Recall the item
13) In the terminal, look at the message_queue in the database. There
should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS
14) Go back to the Intranet and check in the item. Confirm the recall
when checking in
15) Look at the message_queue in the database again. There should be a
'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email.
16) Confirm tests pass
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t
17) Confirm that 'Unknown' doesn't show in the the staff and OPAC messaging
preferences tables when UseRecalls syspref is disabled

Sponsored-by: Toi Ohomai Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

--- Comment #39 from Aleisha Amohia  ---
Created attachment 165241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165241=edit
Bug 23781: Tests for Recalls messaging preferences

- t/db_dependent/Koha/Recall.t
- t/db_dependent/Koha/Recalls.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162377|0   |1
is obsolete||
 Attachment #162378|0   |1
is obsolete||
 Attachment #162379|0   |1
is obsolete||
 Attachment #162380|0   |1
is obsolete||

--- Comment #38 from Aleisha Amohia  ---
Created attachment 165240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165240=edit
Bug 23781: Database updates

This patch adds RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM SMS notices and
makes recalls notices available to be configured in patron messaging
preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #164787|0   |1
is obsolete||

--- Comment #62 from Aleisha Amohia  ---
Created attachment 165239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165239=edit
Bug 33260: Move patron search into main body of page

This patch moves the patron search in the Notices management page to the main
body of the page so that the patron search result table displays more nicely.

This is a better place for it anyway, as using this search takes the user to a
different page. In the sidebar, where it was previously, it implied it would
have the same results display as the search filters.

Signed-off-by: Laura Escamilla 
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #164786|0   |1
is obsolete||

--- Comment #61 from Aleisha Amohia  ---
Created attachment 165238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165238=edit
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter
by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new
view_generated_notices user permission.

This enhancement has been built on top of Bug 33478 so print format settings
are taken into account when printing notices.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission
checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron
search box works by searching for one of the patrons you generated a notice
for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for
notices. Leaving the search filters empty will return all notices generated.
Confirm the filters work as expected by using different combinations of
filters.
8. Conduct a search so your notices show in a table. Confirm the information
fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up
box.
10. Click one of the Print buttons next to a notice. Confirm the notice is
opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed
has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the
checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to
'Print selected notices'. Confirm the notices have been collated into one
document, separated by horizontal lines, and prints successfully. The statuses
for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the
view_generated_notices permission
15. Confirm the Notices management page is not visible without the
NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user
permission is checked for your logged in patron, you should see a Print button
for each notice. Confirm this works. Confirm this button doesn't show if your
logged in patron does not have the view_generated_notices user permission. It
does not require the NoticesManagement system preference.

17. Go to Tools -> Notices & slips
18. Edit the format settings of a few different notices i.e. HOLD and WELCOME
19. Generate these notices by filling a hold for a patron and sending a welcome
email
20. Search for all notices under Tools -> Notices management
21. Select all notices and print selected notices
22. Confirm the notices different format settings are taken into account in the
printed PDF

Sponsored-by: Colorado Library Consortium
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

Michael  changed:

   What|Removed |Added

 CC||michael.r.ge...@gmail.com

--- Comment #15 from Michael  ---
Enabling  ModSecurity + ModSecurity-CRS, blocked it all, but needs further
configuration to let all functions work probably and overwrite some rules set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27690] Add search bar to OPAC for public lists

2024-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27690

kch-tr.lhl-consort...@nhs.net  changed:

   What|Removed |Added

 CC||kch-tr.lhl-consortium@nhs.n
   ||et

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/