[Koha-bugs] [Bug 36616] Ability to stop Complex See Reference authority records from being linked to bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36616 --- Comment #6 from Aleisha Amohia --- I'm close but I'm struggling with getting it working for 'a' OR 'f' OR '|'! Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36616] Ability to stop Complex See Reference authority records from being linked to bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36616 Aleisha Amohia changed: What|Removed |Added Attachment #165249|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 166033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166033=edit Bug 36616: [WIP] Add option to authority cataloguing plugin to show established headings only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36750 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35138 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #36 from David Nind --- Some facet heading labels are not displayed in the OPAC search results when using Elasticsearch. I'm not sure if this is related to this bug, or is unrelated. I've created bug 36750 for the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14007] Item types for items hidden by OpacHiddenItems turn up in facet results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #18 from David Nind --- Testing notes (using KTD): 1. To start up Koha with Elasticsearch: ktd --es8 up (also --es7, os1, and os2) (tested with es7 and es8, os1 and os2 were having trouble starting up for me). 2. To reindex: koha-elasticsearch --rebuild -d -b -a kohadev 3. Note that in Elasticsearch some heading labels for facets are missing in the OPAC (but not in the staff interface or when using Zebra). I'm not sure whether this is related to the recent changes from bug 35138. I've created bug 36750 for this in case it isn't. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750 --- Comment #2 from David Nind --- Created attachment 166032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166032=edit OPAC - Zebra facet headings (no issues) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750 --- Comment #1 from David Nind --- Created attachment 166031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166031=edit OPAC - Missing facet headings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36750] New: OPAC - some facet heading labels are not displayed in search results when using Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750 Bug ID: 36750 Summary: OPAC - some facet heading labels are not displayed in search results when using Elasticsearch Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: da...@davidnind.com When searching in the OPAC using Elasticsearch (or OpenSearch) some facet labels are not displayed in the search results. The actual facets are displayed, but not the heading they are grouped under. The facet heading labels that are not displayed are (for the sample data in KTD): - Item types - Collections - Holding libraries - Home libraries - Languages To replicate (using koha-testing-docker (KTD)): 1. Start up KTD using Elasticsearch (or OpenSearch): ktd --es8 up (or --es7, os1, os2 - note os1 and os2 were having trouble starting up for me when I created this bug). 2. In the OPAC, search for books. 3. Note that facet heading labels are missing for these facets: - Item types - Collections - Holding libraries - Home libraries - Languages 4. Search in the staff interface, and note that facet headings are displayed correctly. 5. Change the Searchengine system preference to Zebra. 6. Search in the OPAC again for books and note that the facet heading labels are correctly displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #13 from David Cook --- So not a problem in prod for people using the "koha" apt repo. But it is a problem in the "koha-staging" apt repo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 David Cook changed: What|Removed |Added Blocks|36722 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema# -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 David Cook changed: What|Removed |Added Version|22.05 |Main Depends on|30194 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 [Bug 30194] Update required JSON::Validator version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #12 from David Cook --- Ok now I'm super curious... My Koha 23.11 dev system on Ubuntu 22.04 libjson-validator-perl 5.99+really5.08-koha1 /usr/share/perl5/JSON/Validator/cache/089e74a6d17f64af17a9efd6d0fa0de6 /usr/share/perl5/JSON/Validator/cache/10a5eeb37fcd5d829449028f7ceb0774 /usr/share/perl5/JSON/Validator/cache/33912dbbde6e1d936140f1c82b283d01 /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df /usr/share/perl5/JSON/Validator/cache/3be3f46eb248daf48925640f8ef057e8 /usr/share/perl5/JSON/Validator/cache/3d35aac549d951f4cf9182ff47bff0b4 /usr/share/perl5/JSON/Validator/cache/49c95b866e40f788892a7fb3c816b0e8 /usr/share/perl5/JSON/Validator/cache/4a31fe43be9e23ca9eb8d9e9faba8892 /usr/share/perl5/JSON/Validator/cache/546acf85ddc442761c18517490215b90 /usr/share/perl5/JSON/Validator/cache/630949337805585c8e52deea27d11419 /usr/share/perl5/JSON/Validator/cache/7fe97ed1a4c3fac607dd276b2b298275 /usr/share/perl5/JSON/Validator/cache/a0f5b4b4e75ea17fc09e88ec0343d148 /usr/share/perl5/JSON/Validator/cache/a516498b60c53096b2ce2cd83ebe0abc /usr/share/perl5/JSON/Validator/cache/c6f188eb288cf986f23db49297b25e83 /usr/share/perl5/JSON/Validator/cache/d18065ce8fb1f748e766b2737bae5200 /usr/share/perl5/JSON/Validator/cache/d8cf7ae7a0fd14accadf5d18bc84d14f /usr/share/perl5/JSON/Validator/cache/ea34d47d4e060a1c3b12d2287aff89a7 /usr/share/perl5/JSON/Validator/cache/eaa832720f36cff0abc20c05236a9cd9 My Koha main dev system on Debian 12 libjson-validator-perl 5.99+really5.14-koha1 /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df /usr/share/perl5/JSON/Validator/cache/a516498b60c53096b2ce2cd83ebe0abc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #11 from David Cook --- (In reply to David Cook from comment #7) > I think the shortest solution for this one is going to be to add the > contents of http://json-schema.org/draft-04/schema# as > /usr/share/perl5/JSON/Validator/cache/49c95b866e40f788892a7fb3c816b0e8 > > And that can be done via the libjson-validator-perl package that the Koha > community puts together. /usr/share/perl5/JSON/Validator/Store.pm removes the fragment from the URL, so you end up with the following: echo -n "http://json-schema.org/draft-04/schema; | md5sum 49c95b866e40f788892a7fb3c816b0e8 - -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14007] Item types for items hidden by OpacHiddenItems turn up in facet results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 David Nind changed: What|Removed |Added Attachment #164978|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 166030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166030=edit Bug 14007: Hide hidden itemtypes in opac facets. Test plan: * Start koha-testing-docker with elasticsearch or opensearch (e.g., ku-es7) * Make sure there is a built index for Elastic/OpenSearch: > koha-elasticsearch --reset --rebuild kohadev * Search for "book" in opac and note the facet values for itemtype * Change systempreference SearchEngine to ElasticSearch * Search for "book" in opac and note the facet values for itemtype * Go to the adminstration view of one of the itemtypes (for instance Visual Materials) and check "Hide in OPAC". * Search for "book" in opac and make sure the hidden itemtype do not appear as facet. * Search for "book" in staff interface and make sure the hidden itemtype still does appear as a facet. * Change back the systemprefence to Zebra * Search for "book" in opac and make sure the hidden itemtype do not appear as facet. * Search for "book" in staff interface and make sure the hidden itemtype still does appear as a facet. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14007] Item types for items hidden by OpacHiddenItems turn up in facet results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 --- Comment #26 from David Nind --- (In reply to Emily Lamancusa from comment #21) Thanks Emily! I have now signed off. (I hope I tested it correctly!) David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Attachment #166024|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 166029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166029=edit Bug 34972: Remove GetOtherReserves GetOtherReserves attempts to set the waiting/transit status for the next hold on the list when applicable, but in practice it either leaves the hold state unchanged, or sets the itemnumber without setting the found status (erroneously converting bib-level holds to item-level holds). The latter situation only occurs when the user has been prompted to confirm, cancel, or revert the hold, and is able to ignore the prompt. In those situations, the hold's state should not change. GetOtherReserves does not need to change the hold state, and it does not do so correctly. Besides that, it does not do much other than call CheckReserves, and is only used in 3 places. This patch removes GetOtherReserves, and refactors returns.pl and C4::Reserves::ModReserveCancelAll to call CheckReserves directly instead. To test: 1. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 2. Check in an item from that record to fill Patron A's hold 3. Set the hold's expiration date to yesterday by accessing the database in the command line: - In a ktd shell prompt, open the db client with koha-mysql kohadev - UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE borrowernumber = 4. Go to Circulation > Holds Awaiting Pickup, and find the hold in the "holds waiting past their expiration date" tab 5. Click the "Cancel hold" button in the Actions column next to the hold (do not check in the book) 6. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 7. Cancel Patron B's hold 8. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 9. Check in an item to fill Patron A's hold 10. Repeat steps 3-5 to expire and cancel Patron A's hold 11. Return to the Holds tab of the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold, and there is no "Revert transit status" button 12. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 13. Check in an item from that record to fill Patron A's hold 14. Check in the same item again. A modal will pop up, saying that the hold is already waiting 15. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 16. Click "Ignore" on the modal for Patron B's hold 17. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 18. Apply patch 19. Repeat steps 1-6 --> Note that Patron B's hold is still a bib-level/"next available" hold 20. Repeat steps 7-11 --> Note that Patron B's hold is still a bib-level/"next available" hold 21. Repeat steps 12-17 --> Note that Patron B's hold is still a bib-level/"next available" hold Make sure correct behavior is unchanged: 22. Cancel Patron B's hold 23. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 24. Check in an item from that record to fill Patron A's hold 25. Check in the same item again. A modal will pop up, saying that the hold is already waiting 26. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 27. Click "Print slip, transfer, and confirm" on the modal for Patron B's hold --> Confirm that the information on the slip is correct --> Confirm that the hold is correctly put in transit 22. Set HoldsAutoFill and HoldsAutoFillPrintSlip to "Do" 23. Place a bib-level hold for the logged-in library 24. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 25. Place a bib-level hold for a different library 26. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly put in transit 27. Change the logged-in branch to match the hold pickup location 28. Check the item in --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 29. Repeat steps 22-26 --> Confirm a correct hold slip pops up for Patron B's hold --> Confirm that Patron B's hold is
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Attachment #164392|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 166028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166028=edit Bug 34972: Add tests for ModReservesCancelAll To test: 1. Apply this patch only 2. prove t/db_dependent/Koha/Holds.t --> Tests pass 3. Apply the other patch 4. prove t/db_dependent/Koha/Holds.test --> Tests still pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36749] Link field to authorities removes subfield $e in advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36749 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36749] New: Link field to authorities removes subfield $e in advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36749 Bug ID: 36749 Summary: Link field to authorities removes subfield $e in advanced editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: mn...@oslri.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When linking a heading in advanced editor (Ctrl+shift+l), selecting "Choose" will link the heading, adding the $9, but will also delete all $e relationship designator fields. This does not happen in the basic editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 David Nind changed: What|Removed |Added Attachment #165929|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 166027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166027=edit Bug 36515: Add unit tests Test plan: 1. Run unit tests ktd --shell prove t/SimpleMARC.t Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 David Nind changed: What|Removed |Added Attachment #165928|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 166026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166026=edit Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36555] Add report_id to file name when exporting report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36555 Andrew Fuerste-Henry changed: What|Removed |Added CC||aman...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- Testing notes using KTD: 1. Step 5: [hostname]/cgi-bin/koha/sco/sco-main.pl 2. Step 8: While the URL is /cgi-bin/koha/opac-main.pl, the page has the log in form in the middle and none of the normal header (including the OPAC search box). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679 David Nind changed: What|Removed |Added Attachment #165487|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 166025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166025=edit Bug 36679: Prevent SCO login for the AnonymousPatron 1. Make sure AutoSelfCheckAllowed is Allowed and AutoSelfCheckID and AutoSelfCheckPass are in use. 2. Make sure AnonymousPatron is pointed to an account. 3. Set SelfCheckoutByLogin to cardnumber. 4. Verify that if you go to the anonymous patron account in the staff interface, you cannot checkout items. 5. Go to the selfcheck path of the library. It should auto login. Put in the cardnumber for the anonymous user. 6. Proceed to check out items! 7. APPLY PATCH, restart_all 8. Try step 5 again, you should not be able to log in as the AnonymousPatron. Instead you should be redirected to OPAC home page 9. Switch SelfCheckoutByLogin to 'username and pasword'. 10. Again try to log in as the AnonymousPatron, you should not be able to. 11. Make sure you can login as a regular patron when SelfCheckoutByLogin is set to 'cardnumber' and when it is set to 'username and pasword'. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #23 from Emily Lamancusa --- Everything mentioned above should be fixed and ready for testing again. Testing note for steps 15-16: there seems to be a regression in main currently - when checking in a waiting hold and cancelling it from the check-in modal, a second modal does not pop up to fill the next hold. Until that is fixed, skip step 16 - the result will be the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #77 from Aleisha Amohia --- (In reply to Martin Renvoize from comment #76) > Still looking here.. must admit I'm a little disappointed to find it all > coded in a style we've long since moved away from even though it's a very > recent project in the grand scheme. > It was an oversight, I started this development over a year ago but I know that standard has been in place for a while so my apologies. The API and datatables stuff has moved on quite a lot since we first started using it and it isn't documented well in the wiki, so unfortunately sometimes I do need to make mistakes and be corrected. I really appreciate any specific comments or feedback I can implement here, or links to the wiki which explains the standards for these things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Emily Lamancusa changed: What|Removed |Added Attachment #164393|0 |1 is obsolete|| --- Comment #22 from Emily Lamancusa --- Created attachment 166024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166024=edit Bug 34972: Remove GetOtherReserves GetOtherReserves attempts to set the waiting/transit status for the next hold on the list when applicable, but in practice it either leaves the hold state unchanged, or sets the itemnumber without setting the found status (erroneously converting bib-level holds to item-level holds). The latter situation only occurs when the user has been prompted to confirm, cancel, or revert the hold, and is able to ignore the prompt. In those situations, the hold's state should not change. GetOtherReserves does not need to change the hold state, and it does not do so correctly. Besides that, it does not do much other than call CheckReserves, and is only used in 3 places. This patch removes GetOtherReserves, and refactors returns.pl and C4::Reserves::ModReserveCancelAll to call CheckReserves directly instead. To test: 1. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 2. Check in an item from that record to fill Patron A's hold 3. Set the hold's expiration date to yesterday by accessing the database in the command line: - In a ktd shell prompt, open the db client with koha-mysql kohadev - UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE borrowernumber = 4. Go to Circulation > Holds Awaiting Pickup, and find the hold in the "holds waiting past their expiration date" tab 5. Click the "Cancel hold" button in the Actions column next to the hold (do not check in the book) 6. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 7. Cancel Patron B's hold 8. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 9. Check in an item to fill Patron A's hold 10. Repeat steps 3-5 to expire and cancel Patron A's hold 11. Return to the Holds tab of the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold, and there is no "Revert transit status" button 12. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 13. Check in an item from that record to fill Patron A's hold 14. Check in the same item again. A modal will pop up, saying that the hold is already waiting 15. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 16. Click "Ignore" on the modal for Patron B's hold 17. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 18. Apply patch 19. Repeat steps 1-6 --> Note that Patron B's hold is still a bib-level/"next available" hold 20. Repeat steps 7-11 --> Note that Patron B's hold is still a bib-level/"next available" hold 21. Repeat steps 12-17 --> Note that Patron B's hold is still a bib-level/"next available" hold Make sure correct behavior is unchanged: 22. Cancel Patron B's hold 23. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 24. Check in an item from that record to fill Patron A's hold 25. Check in the same item again. A modal will pop up, saying that the hold is already waiting 26. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 27. Click "Print slip, transfer, and confirm" on the modal for Patron B's hold --> Confirm that the information on the slip is correct --> Confirm that the hold is correctly put in transit 22. Set HoldsAutoFill and HoldsAutoFillPrintSlip to "Do" 23. Place a bib-level hold for the logged-in library 24. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 25. Place a bib-level hold for a different library 26. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly put in transit 27. Change the logged-in branch to match the hold pickup location 28. Check the item in --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 29. Repeat steps 22-26 --> Confirm a correct hold slip pops up for Patron B's hold --> Confirm that Patron B's hold
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972
--- Comment #21 from Emily Lamancusa
---
Thank you for testing and the detailed notes, David!
> - Step 4: When I cancel the hold, there is a message saying "Please retain
> this item and check it in to process the hold." for Patron B.
Yes, that's the current behavior. Sometimes staff miss that step of checking
the item in, though, which can cause the bug this patch is meant to fix.
> - Steps 6, 4, and 5; then there is step 6 again - I'm assuming these can be
> ignored. For example the SQL in the first step 6 says "Patron A's
> borrowernumber", however there is only one row in the table and that is the
> hold for Patron B.
Oops, thanks for catching that! I'll fix the commit message.
> - Step 11:
> . For the Holds section of the bibliographic record it shows as an item
> level hold, as per the test plan
> . On the normal view: "In transit from Centerville to Midway since
> 04/30/2024 There is an item level hold on this item (priority = 1)."
> . If I change the library to Midway, Circulation > Transfers > Transfers
> to receive shows the transfer
> . I cancelled the transfer and deleted the hold
It looks like the Holds Awaiting Pickup page is initiating the item transfer,
but not marking the hold as In Transit. Which is less than ideal, but not in
scope for this bug. I'll be more specific in that part of the test plan,
though.
> - Step 15:
> . No new modal popped up after selecting a cancellation reason the cancel
> hold
> . Normal view status: There is an item level hold on this item (priority =
> 1).
> . Holds section details: Only item X
> . Patron details: not showing as waiting for pickup
> . Circulation > Holds awaiting pickup: no holds showing
>
> - Step 19: repeat steps 1-6 - for step 2, I get this error:
>
> Can't locate object method "damaged" via package "32" (perhaps you forgot to
> load "32"?) at /kohadevbox/koha/C4/Reserves.pm line 858
> in C4::Reserves::CheckReserves at /kohadevbox/koha/C4/Reserves.pm line 858
> 855:
> 856: return unless $item; # bail if we got nothing.
> 857:
> 858: return if ( $item->damaged &&
> !C4::Context->preference('AllowHoldsOnDamagedItems') );
> 859:
> 860: # if item is not for loan it cannot be reserved either.
> 861: # except where items.notforloan < 0 : This indicates the item is
> holdable.
I do recreate these last two. Step 15 is still on main, so it must be an
unrelated regression - I'll file a separate bug report for that. It has the
same result as clicking "Ignore" on the second modal, so it won't block testing
here (once I fix the second issue, which is definitely caused by the patch).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182 Katrin Fischer changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #15 from Katrin Fischer --- *** Bug 36747 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36747] Add 952$e Source of Acquisition to holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36747 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 36182 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36748] New: Closures on calendars should include options to block holds, turn off pickup locations, and set hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36748 Bug ID: 36748 Summary: Closures on calendars should include options to block holds, turn off pickup locations, and set hard due dates Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org It would be helpful if closures on the calendar had the option to indicate that library closure should block holds requests for that library's items, and another option to indicate that library is not a pickup location at that time. It would also be useful if you could set a hard due date for a library closure. This would be particularly useful for schools. So, let's say it is March. You may have one or more future closures that indicates a hard due date (hard due dates should allow you to specify dates prior to the closure). Koha rules would look at the closest upcoming event/closer that has a hard due date set, and set the existing rules to that date. Once that date has past, it would set the next one that is set, if there is one. If any of these options are set, it would show it in that library's rules or branch (hard due dates in grey on each rule like "before 5/31/2024 (set by calendar)". If you need to, you can specify a hard due date for any rule, and it would ignore the calendar (maybe until it passed???). Hold policy could indicate that it is set by a calendar event. In branches, the pickup location could indicate the upcoming setting and date (or range). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36747] New: Add 952$e Source of Acquisition to holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36747 Bug ID: 36747 Summary: Add 952$e Source of Acquisition to holdings table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be nice if the 952$e was available in the holdings table. As of 23.11 this column can only be viewed in the Edit Items screen. It would be nice if it was available in the Columns configuration and Tables Configuration so libraries can customize viewability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Lucas Gass changed: What|Removed |Added Attachment #166022|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 166023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166023=edit Bug 35929: Don't record a change for empty fields submitted in patron form This is reminiscent of bug 36159 - when a field is submitted as empty, and null in the DB we need to reject this as a change. I tried to copy the logic from that bug, as well as deleting submitted changes for hidden fields (from html manipulation) This should be tested extensively. One note: If you submit a valid change request, then submit a second with no change the second will be ignored, but the first will remain. i.e. if you change your name from 'Nick' to 'Nack' - then realize your typo you cannot submit a new request to change it back untl the initial request is cleared To test: 1 - Play with PatronSelfModificationBorrowerUnwantedField and PatronSelfModificationMandatory field to have some fields set 2 - Add a patron attribute, or several, that are editable in the OPAC 3 - Try submitting a form with no changes, note a modification requets is submitted 4 - Approve the request 5 - Apply patch, restart all 6 - Try submitted a blank request, you are notified there were no changes 7 - Try to force an unwanted field via html modification 8 - No changes reported 9 - Confirm attributes changes are successful 10 - After a successful request, try submitting a blank request 11 - Note no changes are recorded, but the initial request is still active Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36684] Cancelling an item with uncertain prices leaves the basket marked as a problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry --- I don't understand your proposed solution. Is there something inherently undesirable about cancelling an order with an uncertain price? Why should we require the user to clear the uncertain price if they're just going to cancel the order? I would suggest an alternate solution: if an order with an uncertain price is cancelled, we could automatically clear the uncertain price flag before cancelling the order. We'd prevent the unclearable "problem" on the basket without creating more work for the user. If you prefer your current solution, you need to deal with the "Cancel order and delete catalog record" button. As your patch stands, I'm still able to click "cancel order and delete record," which still hits your described issue of leaving the basket flagged as a problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #3 from Nick Clemens --- Created attachment 166022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166022=edit Bug 35929: Don't record a change for empty fields submitted in patron form This is reminiscent of bug 36159 - when a field is submitted as empty, and null in the DB we need to reject this as a change. I tried to copy the logic from that bug, as well as deleting submitted changes for hidden fields (from html manipulation) This should be tested extensively. One note: If you submit a valid change request, then submit a second with no change the second will be ignored, but the first will remain. i.e. if you change your name from 'Nick' to 'Nack' - then realize your typo you cannot submit a new request to change it back untl the initial request is cleared To test: 1 - Play with PatronSelfModificationBorrowerUnwantedField and PatronSelfModificationMandatory field to have some fields set 2 - Add a patron attribute, or several, that are editable in the OPAC 3 - Try submitting a form with no changes, note a modification requets is submitted 4 - Approve the request 5 - Apply patch, restart all 6 - Try submitted a blank request, you are notified there were no changes 7 - Try to force an unwanted field via html modification 8 - No changes reported 9 - Confirm attributes changes are successful 10 - After a successful request, try submitting a blank request 11 - Note no changes are recorded, but the initial request is still active -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35929 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36159 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34200] Lists and merge catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34200 Christopher Brannon changed: What|Removed |Added Version|unspecified |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36746] New: Batch rule modification and deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36746 Bug ID: 36746 Summary: Batch rule modification and deletion Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I would like to suggest a batch modification/deletion set of tools, much like the batch item and patron tools. Something that would make overhauling rules easier, especially for consortiums. Only change the fields that are edited, much like the existing tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36614] Reinstate Phone column in patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36614 Nick Clemens changed: What|Removed |Added Attachment #165021|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 166021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166021=edit Bug 36614: Restore 'phone' on the main patron search It disappeared at some point (history is tricky here, I didn't manage to track down what happened, it's a mess) This patch adds a phone column after the "name and address" one. It's hidden by default. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36614] Reinstate Phone column in patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36614 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #76 from Martin Renvoize --- Still looking here.. must admit I'm a little disappointed to find it all coded in a style we've long since moved away from even though it's a very recent project in the grand scheme. I'm worried about performance.. that table fills up with notice quickly and we're not paging or using API's. Also, we now have non-template driven notices and those cause a spectacular error on attempting to print. It looks like you're generating the notice from scratch at print time rather than using the notice that exists.. that also feels odd.. it could lead to viewing the preview and then printing something entirely different to what you just previewed. Anyway.. I'll come back to this asap once I've dug a little further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34579] Separate notice/message languages from installed languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34579 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #75 from Martin Renvoize --- Created attachment 166020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166020=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Chip Halvorsen changed: What|Removed |Added CC||Chip.Halvorsen@WestlakeLibr ||ary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Chip Halvorsen changed: What|Removed |Added CC||Chip.Halvorsen@WestlakeLibr ||ary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #81 from Nick Clemens --- Looks like there was an addition when using item groups to list the items and to list (disabled) groups with no items - so should define an item group with no items for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163267|0 |1 is obsolete|| --- Comment #80 from Nick Clemens --- Created attachment 166019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166019=edit Bug 30579: (follow-up) Remove unnecessary nested form elements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163266|0 |1 is obsolete|| --- Comment #79 from Nick Clemens --- Created attachment 166018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166018=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163265|0 |1 is obsolete|| --- Comment #78 from Nick Clemens --- Created attachment 166017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166017=edit Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163264|0 |1 is obsolete|| --- Comment #77 from Nick Clemens --- Created attachment 166016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166016=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163263|0 |1 is obsolete|| --- Comment #76 from Nick Clemens --- Created attachment 166015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166015=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163262|0 |1 is obsolete|| --- Comment #75 from Nick Clemens --- Created attachment 166014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166014=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163261|0 |1 is obsolete|| --- Comment #74 from Nick Clemens --- Created attachment 166013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166013=edit Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Attachment #163260|0 |1 is obsolete|| --- Comment #73 from Nick Clemens --- Created attachment 166012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166012=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea Signed-off-by: Sam Lau Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36745] Add ability to select multiple items for deletion from a rota
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36745 Heather Rommens changed: What|Removed |Added CC||heat...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36745] New: Add ability to select multiple items for deletion from a rota
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36745 Bug ID: 36745 Summary: Add ability to select multiple items for deletion from a rota Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: heat...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the stock rotation module rotas, it would be very helpful if multiple items could be selected for deletion, rather than having to delete items individually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 --- Comment #28 from Nick Clemens --- Created attachment 166011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166011=edit Bug 22740: Write unit tests for automatic lost status switching This patch adds the unit tests for the new system preferences that will automatically change an items lost status to an authorised value defined in these preferences on payment or write off of outstanding balance. Signed-off-by: Martin Renvoize Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Nick Clemens changed: What|Removed |Added Attachment #166003|0 |1 is obsolete|| Attachment #166004|0 |1 is obsolete|| --- Comment #27 from Nick Clemens --- Created attachment 166010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166010=edit Bug 22740: Automatically change lost status when item is paid for This patch implements two new system preferences, "UpdateItemLostStatusWhenWriteOff" and "UpdateItemLostStatusWhenPaid" that allow you to specify the status to change an item to when the outstanding balance of a lost item is paid or written off. These preferences are tied to the LOST authorised values set. Test Plan: - Set one of the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay/Write Off depending on the system preference you selected above - Pay - Note that the status of the item has changed to the status you set with the system preference - Repeat for all values of both system preferences - Check that when the system preference is left blank and no option is chosen, the lost status does not update. Signed-off-by: Martin Renvoize Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #72 from Martin Renvoize --- Poke me in mattermost or slack when this is rebased and I'll jump straight on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36677] Unable to access the dropdown options for list and account details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36677 Owen Leonard changed: What|Removed |Added Severity|blocker |normal OS|Windows |All --- Comment #2 from Owen Leonard --- Ruth do you have any updates on this issue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #301 from Nick Clemens --- Created attachment 166009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166009=edit Bug 15565: (QA follow-up) Add atomic update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #300 from Nick Clemens --- Created attachment 166008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166008=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item holds These patches allow the display of checkboxes instead of radio buttons for placing specific item holds in the OPAC and staff interface. This display is controlled by the system preference 'DisplayMultiItemHolds'. When disabled, the hold display is the same as in the past. When enabled, the user can select multiple items to place holds on at the same time. If there is an error placing one or more holds, an error will display on the following screen. Test plan: 0. Apply the patches and koha-plack --reload kohadev 1. Enable 'DisplayMultiItemHolds' syspref 2. In staff interface, go to a record with multiple holdable items 3. Check the boxes next to 2+ items and click the button to place the holds 4. Note that the holds are all placed (unless there is a failure) 5. Cancel the holds, and try again (but this time make Holds per record (count) only 1 in the circ rules) 6. Note that one of the holds is placed, but the others are not and an error message is displayed saying that one or more holds could not be placed because the holds per record was exceeded 7. Perform the same above procedure on the OPAC 8. If DisplayMultiPlaceHold is enabled, you can test placing multiple specific item holds across multiple bibs in the OPAC via the search results 9. If EnableItemGroups and EnableItemGroupHolds is enabled, you can test that you can either place item group holds or specific item holds. Toggling the checkboxes in the staff interface will uncheck the item group hold radio button. Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #299 from Nick Clemens --- Created attachment 166007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166007=edit Bug 15565: Place multiple holds on one or more records in OPAC Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #298 from Nick Clemens --- Created attachment 166006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166006=edit Bug 15565: Tidy reserve/placerequest.pl Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Attachment #163053|0 |1 is obsolete|| Attachment #163054|0 |1 is obsolete|| Attachment #163055|0 |1 is obsolete|| Attachment #163093|0 |1 is obsolete|| --- Comment #297 from Nick Clemens --- Created attachment 166005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166005=edit Bug 15565: Place multiple holds on one record on staff interface Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #26 from Martin Renvoize --- For a simple re-tidy for the QA script you don't need to loose the original signoff Jacob. I've restored it and added my own for the internal review we did. Setting to Signed off and throwing it at the QA queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Martin Renvoize changed: What|Removed |Added Attachment #165974|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 166004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166004=edit Bug 22740: Write unit tests for automatic lost status switching This patch adds the unit tests for the new system preferences that will automatically change an items lost status to an authorised value defined in these preferences on payment or write off of outstanding balance. Signed-off-by: Martin Renvoize Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Martin Renvoize changed: What|Removed |Added Attachment #165973|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 166003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166003=edit Bug 22740: Automatically change lost status when item is paid for This patch implements two new system preferences, "UpdateItemLostStatusWhenWriteOff" and "UpdateItemLostStatusWhenPaid" that allow you to specify the status to change an item to when the outstanding balance of a lost item is paid or written off. These preferences are tied to the LOST authorised values set. Test Plan: - Set one of the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay/Write Off depending on the system preference you selected above - Pay - Note that the status of the item has changed to the status you set with the system preference - Repeat for all values of both system preferences - Check that when the system preference is left blank and no option is chosen, the lost status does not update. Signed-off-by: Martin Renvoize Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33014] Add link to serial advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33014 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|CLOSED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36744] Can't save a custom search filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36744 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added URL|https://github.com/PTFS-Eur | |ope/koha/tree/bug_36120 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165435|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #134 from Martin Renvoize --- Tests all passing now and full set rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #133 from Martin Renvoize --- Created attachment 166002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166002=edit Bug 36120: (QA follow-up) Fix api/v1/bookings.t We now require pickup_library_id and so need to update the unit tests to reflect that for our sample bookings Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #132 from Martin Renvoize --- Created attachment 166001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166001=edit Bug 36120: (QA follow-up) Fix Circulation.t We now require pickup_library_id and so need to update the unit tests to reflect that for our sample bookings Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #131 from Martin Renvoize --- Created attachment 166000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166000=edit Bug 36120: (QA follow-up) Fix /biblios.t unit test This patch adds some mock data for pickup_items getting included in the pickup locations response. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165434|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 165999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165999=edit Bug 36120: Restore edit Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165433|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 165998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165998=edit Bug 36120: (follow-up) Only display locations for bookable items This patch updates the pickup locations picker to only include locations for items that are bookable. We should look at doing this on the API level as it highlights some issues with re-using item holds pickup location rules. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165432|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 165997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165997=edit Bug 36120: Ensure pickup location and item can be picked in either order Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165431|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 165996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165996=edit Bug 36120: Account for both pickup_location and date selection in items This patch ensures we account for both pickup location and date selections having taken place before an item selection is pondered. We now correctly disable item options given both conditions rather than it being a race between the two. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Martin Renvoize changed: What|Removed |Added Attachment #165430|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 165995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165995=edit Bug 36120: Re-enable 'Any item' selectable Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
