[Koha-bugs] [Bug 36372] Allow privileged users to set the 'record source' on cataloguing

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372

Arthur Suzuki  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|arthur.suz...@biblibre.com
 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36372] Allow privileged users to set the 'record source' on cataloguing

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372

--- Comment #2 from Arthur Suzuki  ---
Created attachment 166161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166161=edit
Bug 36372: provide an interface to set the source of a record from the staff
interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #23 from David Nind  ---
Created attachment 166160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166160=edit
Screenshots - Patron check out and details tabs (before and after)

Screenshots of a patron's check out and details tabs, before and after the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the markup, style, and
   ||behaviour of counters which
   ||are displayed on a patron's
   ||check out and details tabs:
   ||1. A new style: the counter
   ||background has a light blue
   ||square with rounded corners
   ||2. The claims tab:
   ||   . The
   ||order of the counters is
   ||now Unresolved claims /
   ||Resolved claims
   ||   . The
   ||background colour for the
   ||counter changes to orange
   ||when the value set in
   ||ClaimReturnedWarningThresho
   ||ld is reached
   ||3. The
   ||restrictions tab: the
   ||counter background color is
   ||red
   ||4. The clubs tab: now
   ||only shows the number of
   ||clubs a patron is enrolled
   ||in (the count of available
   ||clubs is removed)
 CC||da...@davidnind.com

--- Comment #22 from David Nind  ---
I'll attach some before and after screenshots.

My testing notes (using KTD):

1. Recalls
   - Enable system preference
   - Set some rules:
 . Recalls allowed (total): 5
 . Recalls per record (count): 5
 . On shelf recalls allowed: Recall due date interval (day)
 . Recall overdue fine amount: 5
 . Recall pickup period (day): 5
   - Checkout some items to Patron A
   - Log in as Patron B (set username/password by editing the patron details)
   - Make a recall for Patron B for one of the items checked out by Patron A

2. Returns claimed:
   - Select a value for ClaimReturnedLostValue for the claim lost action button
to appear under a patron's checkouts: I used Lost
   - Set a value for ClaimReturnedWarningThreshold: 2
   - Check out some items to the patron
   - Make 3 claims
   - Resolve one claim: Claims tab > Actions > Resolve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

David Nind  changed:

   What|Removed |Added

 Attachment #166147|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 166159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166159=edit
Bug 26258: Circulation tabs inconsistent with counters

This patch makes changes to the markup, style, and behaviour of counters
which are displayed on the patron's account tabs: Checkouts, Holds, etc.
Tabs which contain a count which might change based on a user's actions
will keep up to date, e.g. changing claims status, enrolling in clubs,
etc.

To test, apply the patch and enable features if necessary: recalls,
article requests, claims, clubs, and patron lists. Test both from the
checkout page and the patron detail page:

Recalls:

- If necessary, check out some items to patrons so that there are titles
  which can be recalled.
- Log in to the OPAC and place one or more recalls.
- Return to the staff interface and view the "Recalls" tab on the
  patron's account.
- Click Actions -> Cancel for one of the recalls. The recall should be
  marked "Cancelled" and the count on the tab should update.

Return claims:

- If necessary, check out some items to a patron. Click the "Claim
  returned" button on a few of the patron's checkouts.
- As you add claims, the "Claims" tab should update the count of claims.

  *** NOTE: This changes the display of claims in the tab so that the
  count of unresolved claims appears first: "Unresolved / Resolved".
  I think it makes more sense for the first number to be the one
  which shows the number of "active" issues.

- Open the Claims tab. Click Actions->Resolve on one or more claims,
  confirming that the resolved claim is hidden and the tab numbers
  update.
- Test setting the ClaimReturnedWarningThreshold system preference to
  various values: e.g. empty, 1, 5.
  - If the pref is empty, OR if the pref is set to a number higher
than the number of patron claims, the count of claims should be
styled with the "info" blue background and the count of resolved
claims is not shown.

*** NOTE: Hiding the resolved claims seems logical if there is not a
concern about the total number of claims.

  - If the number of all claims exceeds the value of the preference,
the tab should show a count of "Unresolved claims / Resolved claims"
with the yellow warning style.

Restrictions:

- Adding a restriction to the account should cause a counter with a
  red background to appear on the tab.

Clubs:

- If necessary, create at least one club template and then multiple
  clubs.
- From the "Clubs" tab on the patron's account, try enrolling and
  cancelling enrollments to confirm that the count on the tab updates
  correctly.

  *** NOTE: I have removed the count of available clubs because I think
  it's not relevant to this interface. We don't do it with patron
  lists, so this makes it a little more consistent..

Patron lists:

- If necessary, create two ore more patron lists.
- From the "Patron lists" tab, try adding and removing the patron from
  lists. The tab counter should update correctly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Phil Ringnalda  changed:

   What|Removed |Added

 Blocks||24424


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424
[Bug 24424] Advanced editor - interface hangs as "Loading" when given an
invalid bib number
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24424] Advanced editor - interface hangs as "Loading" when given an invalid bib number

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org
 Depends on||29697

--- Comment #1 from Phil Ringnalda  ---
We could have (but didn't) handled the returned 404 Not found from
https://git.koha-community.org/Koha-community/Koha/src/commit/ccd4738e26ef3c2e40bfa1dc1e74dfdb94a34239/svc/bib#L84
before bug 29697 accidentally turned that into dead code. Now svc/bib calls
Koha::Biblios->find( $biblionumber ) which returns undef if the biblio doesn't
exist, but rather than returning 404 if we can't find the biblio, we forge
ahead, calling $biblio->metadata->record() on undef and getting a 500 thrown
instead.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
[Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36780] New: Should templates (notices and slips) ignore print_XXX.css stylesheet

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36780

Bug ID: 36780
   Summary: Should templates (notices and slips) ignore
print_XXX.css stylesheet
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

It seems I am fighting against the print stylesheet at times.  Particularly
with the templates (notices and slips) regarding tables in report templates. 
Everything looks great on screen, just the way I plan it, then when you get to
the print preview and printing, the print stylesheet takes over.

This is extremely troubling when you are working hard to style something for
print.

It seems like the template should offer a way to exclude the stylesheet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29904] Serials: Clear 'Automatically set to late' when changing status

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29904

--- Comment #5 from Katrin Fischer  ---
(In reply to Esther Melander from comment #4)
> This note appears to be tied to a serial status, so it would be nice if it
> disappeared when received. However, there is no way to customize the text of
> this note, nor the ability to control whether it should appear or not at
> all. One library would prefer the note field remain blank, even for late
> issues.

This is not quite true. It's tied to the serialsUpdate cron job and can be
customized/configured there. I looked into it as we didn't want to set the note
any longer, only the Late status.

https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/cronjobs/serialsUpdate.pl
   --no-note   Do not set a note on affected serial issues

> The note box in serial receiving is also used as a free text box. But it is
> not made clear this note is a public note and will show in the OPAC. The
> only way to control the visibility of the note in the OPAC is to delete the
> note on receiving. There should be options on visibility here. Or perhaps it
> should not show at all and the 952$z should be the only public facing note
> field.

I once filed a bug that we should create another note field for serial issues,
so we can have an internal and a public one. Not all libraries are creating
serial items and they like to add things like + CD in the note field. I think
there is a need for a public one too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21329] Add additional fields to purchase suggestions

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716

--- Comment #5 from Martin Renvoize  ---
https://gitlab.com/koha-community/Koha/-/blob/main/C4/Templates.pm?ref_type=heads#L52

I feel like we could do something here perhaps.. so instead of make copying to
two places, we have a shared directory at the top level where we look for
included including translated ones after we've looked in the more localised for
themes version of the same files?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716

--- Comment #4 from Martin Renvoize  ---
I love the direction here though I wonder what you mean by a SHARED_TMPL_DIR
environment variable?

I wonder if we could perhaps use some symlinking for development so one doesn't
have to run make to test changes to these files?.. not sure if there would be a
performance implications in live running using symlinks Vs hard files either on
that front.

Thanks for raising this again Pedro.. sure we must be able to resolve this age
old problem by now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2894] Routing list holds are broken

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894

Koha collecto  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20962] Overhaul to notices

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2894] Routing list holds are broken

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29904] Serials: Clear 'Automatically set to late' when changing status

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29904

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #4 from Esther Melander  ---
This note appears to be tied to a serial status, so it would be nice if it
disappeared when received. However, there is no way to customize the text of
this note, nor the ability to control whether it should appear or not at all.
One library would prefer the note field remain blank, even for late issues.

The note box in serial receiving is also used as a free text box. But it is not
made clear this note is a public note and will show in the OPAC. The only way
to control the visibility of the note in the OPAC is to delete the note on
receiving. There should be options on visibility here. Or perhaps it should not
show at all and the 952$z should be the only public facing note field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17763] Exact punctuation and word order is needed for matching author and vendor names in acq order search

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

--- Comment #3 from Noémie Labine  ---
+1 still valid in 23.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36778] Push default message preferences "button"

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36778

Katrin Fischer  changed:

   What|Removed |Added

Summary|Push Default Message|Push default message
   |Preferences "Button"|preferences "button"
Version|23.05   |Main

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6425] Advanced search: begins with and contains searches

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6425

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36779] New: Automatic renewal column doesn't always populate correctly when editing

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36779

Bug ID: 36779
   Summary: Automatic renewal column doesn't always populate
correctly when editing
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sbr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If I'm editing a rule with Yes in the 'Automatic renewal' column and then
select to edit a different rule that has No in the 'Automatic renewal' column
without saving the first rule, Yes 'sticks'/remains populate for the second
rule. To recreate:

1. Select Edit on a rule with Yes in 'Automatic renewal'. Note that Yes
populates (as it should) in the editing line.
2. Without saving any changes to the rule selected above, click Edit on a rule
with No in the 'Automatic renewal' column. Note that Yes still shows in the
'Automatic renewal' column, even though other values have populated from the
second rule you selected to edit.

If a library doesn't notice this, they could accidentally set rules for
automatic renewal when making other unrelated edits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

David Nind  changed:

   What|Removed |Added

 Attachment #166152|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 166158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166158=edit
Bug 36775: Allow multiple holds on record when holds per record is unlimited

To test:
1 set Holds Per Record to Unlimited
2 confirm hold placement interface does not include "Holds to place (count)"
3 apply patch, restart all
4 reload hold placement interface, confirm it does include "Holds to place
(count)"
5 set Holds Per Record to 2
6 confirm Holds to place shows when placing a first hold for a patron, but not
when placing a second
7 set Holds Per Record to 1
8 confirm Holds to Place does not show
9 sign off and eat a nice snack

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36778] New: Push Default Message Preferences "Button"

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36778

Bug ID: 36778
   Summary: Push Default Message Preferences "Button"
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: e...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

A button or option when updating the patron category's default messaging
preferences that would allow you to push the new preferences out to that patron
category.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19763] Improve the close budget screen

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19763

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20488] Manual renewal due date ignore closed day in calendar

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20488

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14089] show reason for cancellation on order search results

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14089

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

--- Comment #2 from Noémie Labine  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3309] Deleting authorized values when data exists

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23366] Add html option on subscription additional field

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23366

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

--- Comment #6 from Katrin Fischer  ---
Will be back for this on Monday!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue patron category options configurable in interface

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

Katrin Fischer  changed:

   What|Removed |Added

Summary|Make long overdue borrower  |Make long overdue patron
   |category options|category options
   |configurable in interface   |configurable in interface
   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #24 from Katrin Fischer  ---
Small things, but please provide a follow-up:

1) Terminology:

DefaultLongOverdueSkipBorrowerCategories
DefaultLongOverdueSkipBorrowerCategories

I have checked, we have no other BorrowerCategories system preferences, but we
have suggestionPatronCategoryExceptions. I think it's worthwhile to make these
*PatronCategories.

Also in sysprefs.sql and the database update:
+('DefaultLongOverdueBorrowerCategories', '', NULL, "Set the borrower
categories that will be listed when longoverdue cronjob is executed",
'choice'),

-> patron categories

2) Typo

Set the default patron categories to recieve overdues to
Set the default patron categories to recieve overdues to

-> receive

3) Sponsorship

Just asking as the new version of the QA script keeps asking me about it! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #5 from Caroline Cyr La Rose  ---
(In reply to Katrin Fischer from comment #4)
> Description reads like a bug, not an enh? ;)

I think so too! Changing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22179] Hide columns of all the subscriptions of a record with columns settings (id=subscriptionst) for the OPAC

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22179

--- Comment #4 from Noémie Labine  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22188] Use publication date as numbering pattern

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

--- Comment #45 from Koha collecto  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36039] Output of database_audit.pl should be accessible through UI

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36039

--- Comment #22 from Jesse Maseto  ---
Created attachment 166157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166157=edit
Bug 36039: (follow-up) Move view logic to script/template

This patch updates the module as suggested by David to handle just the
diff code and leaves the display logic up to the templates and script.

Signed-off-by: Martin Renvoize 
Signed-off-by: JesseM 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36039] Output of database_audit.pl should be accessible through UI

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36039

--- Comment #21 from Jesse Maseto  ---
Created attachment 166156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166156=edit
Bug 36039: New 'datatabase audit' tab in about page

Signed-off-by: Martin Renvoize 
Signed-off-by: JesseM 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36039] Output of database_audit.pl should be accessible through UI

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36039

Jesse Maseto  changed:

   What|Removed |Added

 Attachment #166097|0   |1
is obsolete||
 Attachment #166098|0   |1
is obsolete||
 Attachment #166099|0   |1
is obsolete||

--- Comment #20 from Jesse Maseto  ---
Created attachment 166155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166155=edit
Bug 36039: Move audit_database script logic to a dedicated module

Test plan #1 ensure same script functionality (same as bug 34064):
0. Apply patch
1. vi ./installer/data/mysql/kohastructure.sql
2. Comment out some columns, change NULL status, or whatever you like
3. perl misc/maintenance/audit_database.pl \
--filename /kohadevbox/koha/installer/data/mysql/kohastructure.sql
4. Note that the output includes SQL commands to change the database
to match the new kohastructure.sql

5a. Try using koha-foreach and note that the database name appears above
the database comparison
5b. koha-foreach "perl misc/maintenance/audit_database.pl \
--filename /kohadevbox/koha/installer/data/mysql/kohastructure.sql"

Test plan #2:
1. After doing test plan #1, access the new 'database audit' tab, visit:
/cgi-bin/koha/about.pl?tab=database
2. Ensure the output is the same as test plan #1

Signed-off-by: Martin Renvoize 
Signed-off-by: JesseM 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22179] Hide columns of all the subscriptions of a record with columns settings (id=subscriptionst) for the OPAC

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22179

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35954] Add --status to koha-plack

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954

--- Comment #8 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35954] Add --status to koha-plack

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

--- Comment #29 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36534] Batch operations when using limit in report

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534

Owen Leonard  changed:

   What|Removed |Added

 Attachment #166068|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 166154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166154=edit
Bug 36534: Batch operations when using limit in report

When report results number exceeds the result per page limit, batch
operations link reads "Batch operations with (page limit) records" even
if there are more or less shown records (more when using limit in SQL or
less in the last page of result). This patch fixes the link text to
actual shown records.

To test:
1) Create a report of items with a limit of e.g., 26.
2) Run report.
3) See that number of results shown exceeds 20 but the link says "Batch
   operations with 20 visible records".
4) See that the second page shows 6 results but the link is still for 20
   records.
5) Apply patch.
6) Run report again.
7) See that the link texts will show correctly 26 records on the first
   page and 6 records on the second.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36534] Batch operations when using limit in report

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705

Angela Berrett  changed:

   What|Removed |Added

 CC||angela.berrett@familysearch
   ||.org

--- Comment #1 from Angela Berrett  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36777

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36777] New: Create a new section for system preferences related to lost item handling

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36777

Bug ID: 36777
   Summary: Create a new section for system preferences related to
lost item handling
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: andre...@dubcolib.org, gmcha...@gmail.com,
jake.de...@ptfs-europe.com

We have quite a few lost related system preferences in the "checkout policy"
section of the system preferences on the circulation tab.

I wonder if it might be nice to have a new section that groups them under their
own section heading.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

--- Comment #50 from Katrin Fischer  ---
(In reply to Andrew Fuerste-Henry from comment #49)
> (In reply to Katrin Fischer from comment #48)
> > I think this should have its own system preference. I am not sure that a
> > ON/OFF is really needed - we could just do something like
> > SCOBatchCheckoutsValidCategories and place it right in the "Self check-out
> > module" section with the other relevant preferences.
> 
> This solution makes sense to me. Should we rename the existing syspref
> "IntranetBatchCheckoutsValidCategories" while we're at it?

Let's move this to a new bug report:
Bug 36776 - Clarify description of BatchCheckouts* system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

--- Comment #9 from Owen Leonard  ---
Created attachment 166153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166153=edit
Bug 35648: (follow-up) Remove sorting from transport columns

There's not a simple way to handle sorting of a column containing only
checkboxes, so I think it makes sense to remove the sorting unless
someone feels strongly about it being necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36776] Clarify description of BatchCheckouts* system preferences

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36776

Katrin Fischer  changed:

   What|Removed |Added

Summary|Clarify description of  |Clarify description of
   |BatchCheckouts* system  |BatchCheckouts* system
   |preferences.|preferences

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36776

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36776] New: Clarify description of BatchCheckouts* system preferences.

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36776

Bug ID: 36776
   Summary: Clarify description of BatchCheckouts* system
preferences.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, pedro.amo...@ptfs-europe.com

These are the system preferences in question:

BatchCheckouts : General ON/OFF switch.
BatchCheckoutsValidCategories : Patron categories allowed to checkout in a
batch.

We should make clear in their description:

* that they apply to circulation in the staff interface
* that the patron categories are the ones you can batch checkout to as a staff
user, not the patron categories allowed to perform batch checkouts

We could also consider REMOVING BatchCheckouts as "not having set any patron
categories" also deactivates the feature effectively.

(adding Pedro so he sees that suggestion ;D )

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

--- Comment #49 from Andrew Fuerste-Henry  ---
(In reply to Katrin Fischer from comment #48)
> I think this should have its own system preference. I am not sure that a
> ON/OFF is really needed - we could just do something like
> SCOBatchCheckoutsValidCategories and place it right in the "Self check-out
> module" section with the other relevant preferences.

This solution makes sense to me. Should we rename the existing syspref
"IntranetBatchCheckoutsValidCategories" while we're at it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #48 from Katrin Fischer  ---
I am sorry as this might be coming (too) late, but I think the way this patch
re-uses the existing system preferences doesn't quite work for the use case.

We have 2 preferences that come into play here:
BatchCheckouts : General ON/OFF switch.
BatchCheckoutsValidCategories : Patron categories allowed to checkout in a
batch.

I believe the second one is currently described misleadingly. It should
probably read: Patron categories a staff user can batch checkout items to. 

Just to be sure I have confirmed the current behavior in our 22.11 demo
installation and on main.

What it means is that with the current preferences the behavior in the staff
interface and the OPAC cannot be configured separately. I can't turn it off in
the OPAC if I want to feature to remain available to my staff users.
Just checking "staff" will not allow staff to still keep doing batch checkouts
to all users and block patrons from doing so. 

We don't know how the self check stations are equipped/built and this could
come as an unwanted feature for some libraries that want that patrons check out
one after the other to avoid any confusion for errors/problems.

I think this should have its own system preference. I am not sure that a ON/OFF
is really needed - we could just do something like
SCOBatchCheckoutsValidCategories and place it right in the "Self check-out
module" section with the other relevant preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35667] Editing "current checkouts allowed" copies string "Unlimited" into input field

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35667

--- Comment #2 from Katrin Fischer  ---
It would probably not be hard to fix, but we need to get some attention here!
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35667] Editing "current checkouts allowed" copies string "Unlimited" into input field

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35667

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
"Holds per record" does the same thing. All other rules seem to behave
themselves when blank/undef/unlimited.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON (and as a diff of the change)

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

--- Comment #59 from Martin Renvoize  ---
Looks like I maintained my own JSON::Patch library back then. 8 years ago,
wow.. I should really have upstreamed it to cpan.

Anywho, I think Struct::Diff, whilst not the nicest output for humans, works
pretty well and isn't as badly maintained as you suggest.. it's got a few
things depending on it etc.im happy to submit my JSON::Patch library is people
would prefer however

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

--- Comment #1 from Andrew Fuerste-Henry  ---
Created attachment 166152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166152=edit
Bug 36775: Allow multiple holds on record when holds per record is unlimited

To test:
1 set Holds Per Record to Unlimited
2 confirm hold placement interface does not include "Holds to place (count)"
3 apply patch, restart all
4 reload hold placement interface, confirm it does include "Holds to place
(count)"
5 set Holds Per Record to 2
6 confirm Holds to place shows when placing a first hold for a patron, but not
when placing a second
7 set Holds Per Record to 1
8 confirm Holds to Place does not show
9 sign off and eat a nice snack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mksteph...@fosgail.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #105 from Katrin Fischer  ---
I know people are keen on this from the activity - it's still on the table, but
we will need to hurry a little.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |andre...@dubcolib.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON (and as a diff of the change)

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

Angela Berrett  changed:

   What|Removed |Added

 CC|angela.berrett@familysearch |
   |.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON (and as a diff of the change)

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

--- Comment #58 from Martin Renvoize  ---
I asked the question to myself whilst QAing and couldn't find any comparable
module..


Data::Compare isn't one I came across but a quick look now suggests it has very
different output and use case.. i.e. it's a simple boolean result of are these
things the same whilst Struct::Diff is rather different in that it offers a
structured diff output highlight what's changed where.

I have actually done this before though come to think about it.. I should see
what I used back then.. I was generating JSON::Patch patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36775] New: Option to place multiple holds on single bib should not be hidden when holds per record is unlimited

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775

Bug ID: 36775
   Summary: Option to place multiple holds on single bib should
not be hidden when holds per record is unlimited
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In request.tt, we tell the "Holds to place (count)" field to show only if
holds_per_record > 1. That means it does not show when holds_per_record is null
and therefore unlimited.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #104 from Andrew Fuerste-Henry  ---
(In reply to Katrin Fischer from comment #103)
> Can you check if that is the same thing you were looking at?

It is not! I thought you meant placing more than one hold at a time on the same
record.

I can confirm that the interface to place holds on multiple different records
at once currently includes notes, a selection for pickup branch, expiration
date, and non-priority toggle. With this patch, none of those things show.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34899] Circulation rules: Only allow "Local use" patron category to place holds on specific library's items

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34899

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mksteph...@fosgail.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36393] Renewal with a specific date does not take the new date due that we pick

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36393

--- Comment #4 from Katrin Fischer  ---
Description reads like a bug, not an enh? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #103 from Katrin Fischer  ---
(In reply to Andrew Fuerste-Henry from comment #102)
> (In reply to Katrin Fischer from comment #101)
> > 4) Multi-holds missing pick-up location and other options (blocker)
> > 
> > If you do a lot of holds at once, the pick-up location at the top allowed
> > you to set them all at once. now this option and others, like "hold expires
> > on" and "notes" are completely gone.
> 
> I can't recreate this. Or maybe it's more a question of clarity of
> interface? Anything I set in the top "Hold details" section of the page is
> applied to all holds created, regardless of choices lower in the page. When
> I entered notes and hold expiration date, those values were applied to all
> holds created via multi-hold, just as they were applied to individual bib-
> or item-level holds.

Maybe I should have been more clear: I am placing multiple holds on different
records by selecting them in the staff interface result list.
The hold details section is completely missing on top of the table.

Can you check if that is the same thing you were looking at?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13243] Make it possible to have library-level patron restrictions

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13243

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mksteph...@fosgail.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36246] Have a centralized method for submitting a form via a link

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246

--- Comment #15 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36246] Have a centralized method for submitting a form via a link

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36137] update_totalissues.pl should always skip_holds_queue

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36137

--- Comment #10 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36137] update_totalissues.pl should always skip_holds_queue

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36137

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #26 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #102 from Andrew Fuerste-Henry  ---
(In reply to Katrin Fischer from comment #101)
> 4) Multi-holds missing pick-up location and other options (blocker)
> 
> If you do a lot of holds at once, the pick-up location at the top allowed
> you to set them all at once. now this option and others, like "hold expires
> on" and "notes" are completely gone.

I can't recreate this. Or maybe it's more a question of clarity of interface?
Anything I set in the top "Hold details" section of the page is applied to all
holds created, regardless of choices lower in the page. When I entered notes
and hold expiration date, those values were applied to all holds created via
multi-hold, just as they were applied to individual bib- or item-level holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25996] Changes to restrictions should be logged

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996

--- Comment #25 from Katrin Fischer  ---
Some notes:

1) Love to see how this replaces some SQL in Koha namespace.

2) Log viewer GUI needs some work

As this is not a new module, we create new actions for create, modify and
delete or restrictions, that clutter the log viewer page a little more.
Something to tackle on another day (bug) 

3) Add JSON soon? 

This development overlapped with the just pushed work from Kyle on making the
data storage in action logs a bit more standardized:

Bug 25159 - Action logs should be stored in JSON

This is at the moment not applied to all existing logging, so definitely not a
blocker here.

4) Amended BorrowersLog system preference description to include "patron
restrictions" in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON (and as a diff of the change)

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

Katrin Fischer  changed:

   What|Removed |Added

Summary|Action logs should be   |Action logs should be
   |stored in JSON ( and as a   |stored in JSON (and as a
   |diff of the change )|diff of the change)
   Keywords|rel_24_05_candidate |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36137] update_totalissues.pl should always skip_holds_queue

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36137

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] Circulation rules are performing too many lookups

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

--- Comment #4 from Pedro Amorim  ---
Testing notes:
Used Kyle's script bug 36668 (8,368 entries in * table )

-
http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl:
Before patch:
Time: 20.72s | 25.27s | 26.21s | 21.68s -> 23.47s avg

After patch:
Time: 17.24s | 22.31s | 19.96s | 16.80s -> 19.07s avg

Result: ~20% performance improvement
-

-
http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl?branch=FFL (with a
single rule entry)
Before patch:
Time 5.94s | 5.72s | 5.86s | 5.67s

After patch:
Time: 1.88s | 1.68 | 1.71s | 1.65s

Result: Lightning fast
-

Adding and removing rules all appears to be working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] Circulation rules are performing too many lookups

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #165687|0   |1
is obsolete||

--- Comment #3 from Pedro Amorim  ---
Created attachment 166151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166151=edit
Bug 36672: Circulation rules are performing too many lookups

Looking at the template, for every section after the main rules block we loop
over categories or itemtypes, and lookup the value for each rule name.

In systems with large numbers of categories and item types this becomes very
slow.

In the rules section, we have already built a hash of rules by category and
itemtype - we should continue to use this throughout the page.

Test Plan:
1) Apply this patch
2) For each rule section, create and delete a rule
3) No change in behavior should be noted!

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] Circulation rules are performing too many lookups

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #101 from Katrin Fischer  ---
Tiny bit torn about this one, it makes things clearer, but it adds a click...
but yes, I can see why we are doing this. Still... sadly found some blockers
that prevent me from pushing this right now. Please follow-up quickly!

If not marked as blocker, it's also good for a later follow-up.

1) Standardize headings

We have:
Hold next available item
Place a hold on a specific item 

We could do:
Hold on next available item
Hold on a specific item

OR
Place hold on next available item
Place hold on a specific item

Tend to the first, because it's a little shorter.

2) Usability

I know that I can click on the text instead of into the radio box, but from the
formatting that is not visually clear. Could we think about replacing the
checkboxes for an element that makes for a bigger "click target" visually?

3) Multi-holds result in a CSRF error (blocker)

Programming error - No CSRF token passed for POST
http://localhost:8081/intranet/reserve/placerequest.pl (referer:
http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=262biblionumber=5biblionumber=13biblionumber=146biblionumber=191biblionumber=11biblionumber=126biblionumber=139biblionumber=165biblionumber=255biblionumber=115multi_hold=1=19)

4) Multi-holds missing pick-up location and other options (blocker)

If you do a lot of holds at once, the pick-up location at the top allowed you
to set them all at once. now this option and others, like "hold expires on" and
"notes" are completely gone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #100 from Katrin Fischer  ---
This one is for Nick's hair...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36618] Make biblio creation optional for ERM local titles

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618

--- Comment #7 from Clemens Tubach  ---
Created attachment 166150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166150=edit
Bug 36618: Add unit tests

prove t/db_dependent/api/v1/erm_eholdings_titles.t

Signed-off-by: Clemens Tubach 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36618] Make biblio creation optional for ERM local titles

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618

Clemens Tubach  changed:

   What|Removed |Added

 Attachment #164992|0   |1
is obsolete||
 Attachment #164993|0   |1
is obsolete||

--- Comment #6 from Clemens Tubach  ---
Created attachment 166149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166149=edit
Bug 36618: Make biblio creation optional for ERM local titles

This patch makes biblio creation on local title creation optional.

Test plan:
1) Navigate to the local title creation form
2) Create a title and leave the "Create record" box unchecked
3) Submit the form
4) Search the catalogue for the title you have just created - no biblio result
will be available
5) Repeat steps 2 - 3 but this time check the box to create a record
6) You should now be able to find a record in the catalogue for the title you
just imported

Signed-off-by: Clemens Tubach 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36618] Make biblio creation optional for ERM local titles

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618

Clemens Tubach  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36731] Delete cancelled order line that still refers to bibliographic record

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36731

--- Comment #2 from Emily Lamancusa  ---
Seems reasonable to me to allow deletion of the order line without deleting the
biblio record. If someone added a mistaken order line and wants to delete it,
it's certainly possible that the biblio record is attached to other orders that
are being kept, or may have current items that aren't linked to an order at
all.

A warn seems like a good balance between not being too restrictive and giving
an opportunity to catch "ghost" records (especially if the warn can include
information on whether the biblio record has any other linked orders or
existing items).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #8 from Kyle M Hall  ---
The transport columns appear to be sortable but do not actually sort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36618] Make biblio creation optional for ERM local titles

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618

--- Comment #5 from Clemens Tubach  ---
The test works, sorry ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363

Owen Leonard  changed:

   What|Removed |Added

 Attachment #166092|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  ---
Created attachment 166148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166148=edit
Bug 27363: Restore temporary selection of Z39.50 targets throughout multiple
searches

The advanced editor currently saves which Z39.50 servers are selected
in local storage using the index in the sorted array of servers, and
then misreads them back as though they were server_ids. We want them to
be server_ids, since that's immutable and the index can change with
changes in rank or server name.

We use the data-server-id property in the HTML more often as a server_id
than as the index that's currently stored there, so this patches
switches it back to be the server_id, and in the one place we would use
the index, instead uses Array.find to just get the server object instead
of referencing it by index.

Test plan:
 1. Set the preference EnableAdvancedCatalogingEditor to enable
 2. Administration - Z39.50 Servers, for NATIONAL LIBRARY OF FRANCE
uncheck "Preselected"
 3. To be sure you don't have confusing saved preferences, open
Firefox's Developer Tools, in the Storage tab open Local Storage and
select your URL
 4. In the row for cateditor_preferences_{your Koha user id}, if there
are any values for selected_search_targets, delete them so you
have "selected_search_targets":{}
 5. Open the advanced editor, and click "Advanced »" in the search box
 6. You should have Local catalog unchecked, LIBRARY OF CONGRESS checked
because it is preselected, and NATIONAL LIBRARY OF FRANCE unchecked
 7. Toggle each checkbox so Local catalog and France are selected, and
LoC is unselected.
 8. In a new broser tab, open the advanced editor, and click "Advanced »"
 9. You will see Local catalog unchecked, LoC checked, and France
unchecked.
That's the bug.
10. Apply patch, open the advanced editor in a new tab, click "Advanced »"
11. Toggle the checkboxes so Local catalog and France are selected, and
LoC is not selected.
12. Open the advanced editor in another new tab, click "Advanced »"
13. You should see what you just set, Local catalog and France checked,
and LoC unchecked, That's the correct behavior.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

Owen Leonard  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >