[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|amitddng...@gmail.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #26 from Katrin Fischer --- I feel like this is covered by the acquisitions tab added to the detail page after this bug was files. Please reopen if I am mistaken with information on what else is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- This has been selected by someone for the hackfest in Marseille, but the patches are not testable. Any chance to see this rebased? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||git...@bugs.koha-community. ||org When did the bot||2013-10-30 last check this|| --- Comment #24 from I'm just a bot git...@bugs.koha-community.org --- Applying: Bug 10013 - Ability to link directly from an item in the Staff client to budget information. Using index info to reconstruct a base tree... MC4/Acquisition.pm Mcatalogue/detail.pl Mkoha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging catalogue/detail.pl Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Patch failed at 0001 Bug 10013 - Ability to link directly from an item in the Staff client to budget information. The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #20064|0 |1 is obsolete|| --- Comment #23 from Amit amitddng...@gmail.com --- Created attachment 22061 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22061action=edit Unit Test for newly created routine: GetBudgetInfoFromItemnumber Kyle, I have added the Test case for newly created routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18598|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20061 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20061action=edit Bug 10013 - Ability to link directly from an item in the Staff client to budget information. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18600|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20063action=edit Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18600|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20064action=edit Bug-10013-New unit tests for routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Kyle M Hall k...@bywatersolutions.com --- The feature patch works as advertised, but I'm a bit confused by the unit test. There is language in it that says it's a stub, it it's not. Additionally, it doesn't mock any data, and fails for me. It makes invalid assumptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18600|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20063|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added CC||amitddng...@gmail.com Assignee|amit.gu...@osslabs.biz |amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #17623|0 |1 is obsolete|| Attachment #17645|0 |1 is obsolete|| --- Comment #17 from Amit amitddng...@gmail.com --- Created attachment 18598 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18598action=edit Ability to link directly from an item in the Staff client to budget information. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #18 from Amit amitddng...@gmail.com --- Created attachment 18600 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18600action=edit New unit tests for routine: GetBudgetInfoFromItemnumber New unit tests for routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Pierre Angot tredok.pie...@gmail.com changed: What|Removed |Added CC||tredok.pie...@gmail.com --- Comment #14 from Pierre Angot tredok.pie...@gmail.com --- Hello, I'm questionning about the use of this patch. Why made a link to budget ? I've maybe misunderstood the goal of this patch. Can you give me more explaination ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #15 from Amit Gupta amit.gu...@osslabs.biz --- Hi, The purpose of this patch will show under which budget you ordered/purchased the item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #16 from Pierre Angot tredok.pie...@gmail.com --- Ok. I think the proposals that Mathieu did are more complete. Have you seen them ? It will be a good idea to work to include what Rennes2 did. If evebody think this patch (10013) is essential, I can sign it (it works ^^). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #13 from Amit Gupta amit.gu...@osslabs.biz --- Created attachment 17645 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17645action=edit Add new unit tests for new routine: GetBudgetInfoFromItemnumber Add new unit tests for new routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #6 from Colin Campbell colin.campb...@ptfs-europe.com --- The use case for the for this is the desire of a number of sites to access the funding information for copies of titles held from the results of standard staff search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr --- Yes, it is a very needed feature! For the moment, in my library, we made a hack in JQuery for displaying this information. I just made previous comment to remark that there are 4 bugs BZ for the same subject. Maybe some ideas developped of the other patchs could be interesting for this one? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ok, I see :) I thought that the link was not very helpful as it will just show you the totals, but I can see that displaying the fund itself would be useful. I still think acq related information should be grouped together in one place tho - meaning not to add columns to items, but have that in a separate place. The items table already has a lot of columns and display won't get more readable adding more information that is not needed for circ. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #9 from mathieu saby mathieu.s...@univ-rennes2.fr --- I can join a screenshot of what we made in JQuery in Rennes 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 17610 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17610action=edit Screenshot of a dev made in Rennes2 with JQuery I don't know if it could be helpful, but I join a screenshot of a dev made in Rennes2 with JQuery. We create items only when we receive books. So we need a way to show information about pending orders before reception. We made a little dev in jquery that 1 - creates a new tab for acquisition information : # order with a link # basket with a link Budget Note Collection code (our stat1) Level of public (our stat2) Date of order Date of reception Quantity (received/ordered) Date of cancellation 2 - show a summary of those information in item tab, ONLY if no real items have been created. 3 - show the same information in OPAC M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Attachment #17598|0 |1 is obsolete|| --- Comment #11 from Amit Gupta amit.gu...@osslabs.biz --- Created attachment 17623 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17623action=edit Bug 10013 - Ability to link directly from an item in the Staff client to budget information. Hi Kartrin, Colin has already provided the use case and i have followed the Capitalization strings consistently guidelines. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Amit, thank you for fixing the capitalization problems. There is still one open problem - we need a unit test for the new GetBudgetInfoFromItemnumber. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #2 from Amit Gupta amit.gu...@osslabs.biz --- Created attachment 17598 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17598action=edit Ability to link directly from an item in the Staff client to budget information To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 17598 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17598 Ability to link directly from an item in the Staff client to budget information Review of attachment 17598: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10013attachment=17598) - Hi Amit, I found a couple of problems with this patch - I have noted them using the splinter review below. Please take a look at the coding guidelines in the wiki (http://wiki.koha-community.org/wiki/Coding_Guidelines). Also, I am not sure about the workflow here. Can you perhaps explain the use case for the link to the budget? ::: C4/Acquisition.pm @@ +75,1 @@ Capitalization seems a bit off here. Also, unit tests are mandatory for every new sub in the C4 and Koha namespaces. ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +370,4 @@ [% IF ( SpineLabelShowPrintOnBibDetails ) %]thSpine label/th[% END %] [% IF ( hostrecords ) %]thHost records/th[% END %] [% IF ( analyze ) %]thUsed in/thth/th[% END %] +[% IF ( itemdata_booksellerid ) %]thBudget Information/th[% END %] Wrong capitalization. @@ +523,5 @@ tda href=/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=[% item.biblionumber %]amp;hostitemnumber=[% item.itemnumber %]Create analytics/a/td +[% END %] +[% IF ( itemdata_booksellerid ) %] +tda href=/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% item.budget_period_id %] [% item.budget_name %]/a/td +[% END %] I am not sure this is the right place for this information. If I read the code correctly, this will appear in the holdings table on the detail page. All other acq related information is shown on the holdings tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ah, I see I got the wrong line - the first comment refers to the capitalization of the new sub's name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr --- Hello Amit. I will take a look at your patch later, but I think its goal is partially the same as 6777 , 9780 (I did this one), and 7294. Maybe it could be interesting for you to take a look at them ? For 9780, it was supposed to show a link between record and Acq, but in a different way than your patch did (not in tabs, but under the record description). It is also forbidding librarians to suppress a record if it is used in an order. BZ9780 was signed off and waiting for QA, but I think I am going to rewrite it, keeping only the last point and removing the display of the link between record and Acq, as maybe your tab solution is better on UX point of view. For 6777, it is adding a new column in the holding tabs, showing acq info. For 7294, it is also using the tabs, but doing other things. Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com Assignee|koha-b...@lists.koha-commun |amit.gu...@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr --- Hello Amit Did you see 5336 and 9780 ? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
