[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||n...@bywatersolutions.com

--- Comment #49 from Nick Clemens  ---
Awesome work all!  Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #48 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #46)
> Created attachment 69696 [details] [review]
> Bug 10021: Remove notify headers from pay*.tt

(In reply to Jonathan Druart from comment #47)
> Created attachment 69698 [details] [review]
> Bug 10021: Only display outstanding fines in 'Pay fines'

These last 2 patches have been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #47 from Jonathan Druart  
---
Created attachment 69698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69698=edit
Bug 10021: Only display outstanding fines in 'Pay fines'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69695|0   |1
is obsolete||

--- Comment #46 from Jonathan Druart  
---
Created attachment 69696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69696=edit
Bug 10021: Remove notify headers from pay*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #45 from Jonathan Druart  
---
Created attachment 69695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69695=edit
Bug 10021: Remove notify headers from pay*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #44 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #43 from Marcel de Rooy  ---
Would have preferred to see a test for GetOverduesForBranch, but it is not a
blocker for me.
A rename of this sub would be nice too (see FIXME). Something like
GetOverduesWithFines ?
Similarly, it is weird that the script branchoverdues.pl (whats in a name) does
not list Overdues with fines in the header but just Overdues.
Apart from these observations, it is wonderful to see dead code moving out !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68920|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Created attachment 68959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68959=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68798|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 68958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68958=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68797|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Created attachment 68957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68957=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68794|0   |1
is obsolete||

--- Comment #37 from Marcel de Rooy  ---
Created attachment 68954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68954=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68796|0   |1
is obsolete||

--- Comment #39 from Marcel de Rooy  ---
Created attachment 68956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68956=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68795|0   |1
is obsolete||

--- Comment #38 from Marcel de Rooy  ---
Created attachment 68955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68955=edit
Bug 10021: Update DB changes

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68793|0   |1
is obsolete||

--- Comment #36 from Marcel de Rooy  ---
Created attachment 68953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68953=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #35 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #33)
> (In reply to Marcel de Rooy from comment #32)
> > QA Comment:
> > 
> > GetOverduesForBranch
> > Please add a test. You make some fundamental changes here.
> 
> Fundamental? I do not understand what you want me to test.

Maybe non-trivial would have been a better word ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #34 from Jonathan Druart  
---
Created attachment 68920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68920=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #33 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #30)
> When you remove a sub from a module without full coverage, this is the
> result. Something for QA tools ?

Yes, could be improved. POD failures must be considered as warnings.

(In reply to Marcel de Rooy from comment #31)
> (In reply to Jonathan Druart from comment #8)
> > It appears that has never worked.
> > Could someone confirm?
> 
> Did you have any response whatsoever ?

I think we discussed it on IRC, but I do not find the logs.

(In reply to Marcel de Rooy from comment #32)
> QA Comment:
> 
> GetOverduesForBranch
> Please add a test. You make some fundamental changes here.

Fundamental? I do not understand what you want me to test.

> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> -
> Not sure. Why do yo remove this line ?

Yes it could have been done somewhere else, it's not directly related to these
changes. There is no "totals*" variables retrieved from the pl script.

> New code:
> +my $accounts = Koha::Account::Lines->search({ borrowernumber =>
> $borrowernumber, }, { order_by => ['accounttype'] });
> +my @accounts;
> +while ( my $account = $accounts->next ) {
> This does not look very nice. Can we get more confusion on $account,
> @accounts or $accounts ?
> Renaming @accounts here might be the least we can do?
> No blocker on itself.

Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #32 from Marcel de Rooy  ---
QA Comment:

GetOverduesForBranch
Please add a test. You make some fundamental changes here.

koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
-
Not sure. Why do yo remove this line ?

New code:
+my $accounts = Koha::Account::Lines->search({ borrowernumber =>
$borrowernumber, }, { order_by => ['accounttype'] });
+my @accounts;
+while ( my $account = $accounts->next ) {
This does not look very nice. Can we get more confusion on $account, @accounts
or $accounts ?
Renaming @accounts here might be the least we can do?
No blocker on itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #31 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #8)
> Created attachment 68263 [details] [review]
> Bug 10021: Drop columns notify_id and notify_level from accountlines
> 
> It appears that has never worked.
> Could someone confirm?

Did you have any response whatsoever ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #30 from Marcel de Rooy  ---
 FAIL   C4/Members.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   C4/Overdues.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

No reason to immediately move this to FQA !
When you remove a sub from a module without full coverage, this is the result.
Something for QA tools ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Severity|normal  |enhancement

--- Comment #29 from Marcel de Rooy  ---
Moving this to enh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #28 from Josef Moravec  ---
Created attachment 68798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68798=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #26 from Josef Moravec  ---
Created attachment 68796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68796=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #25 from Josef Moravec  ---
Created attachment 68795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68795=edit
Bug 10021: Update DB changes

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #24 from Josef Moravec  ---
Created attachment 68794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68794=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #27 from Josef Moravec  ---
Created attachment 68797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68797=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Josef Moravec  changed:

   What|Removed |Added

  Attachment #68477|0   |1
is obsolete||
  Attachment #68478|0   |1
is obsolete||
  Attachment #68479|0   |1
is obsolete||
  Attachment #68480|0   |1
is obsolete||
  Attachment #68505|0   |1
is obsolete||
  Attachment #68506|0   |1
is obsolete||

--- Comment #23 from Josef Moravec  ---
Created attachment 68793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68793=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #22 from Jonathan Druart  
---
Created attachment 68506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68506=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #21 from Jonathan Druart  
---
Created attachment 68505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68505=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Josef Moravec  ---
Good job Jonathan, just few small things:

1) There is still remaining one column "Notified by" in table on page
branchtransfers (line 41 of branchtransfers.tt", it is using values overdue1,
overdue2, overdue3, which were removed from branchtransfers.pl

2) The column "Overdue status" should be removed too

3) Any owed fees are not shown on pay.pl page

Otherwise it looks good for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #19 from M. Tompsett  ---
Code changes read okay.
But given that I don't know how to trigger all the changes, I'm not going to
sign off. I'll leave that for someone else more fearless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #18 from Jonathan Druart  
---
Created attachment 68480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68480=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #17 from Jonathan Druart  
---
Created attachment 68479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68479=edit
Bug 10021: Update DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #16 from Jonathan Druart  
---
Created attachment 68478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68478=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68419|0   |1
is obsolete||
  Attachment #68420|0   |1
is obsolete||
  Attachment #68421|0   |1
is obsolete||
  Attachment #68422|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 68477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68477=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #14 from Josef Moravec  ---
I have problem applying the patch on current master - probably because of bug
12768, could you please rebase one more time? Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #13 from Jonathan Druart  
---
Created attachment 68422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68422=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #12 from Jonathan Druart  
---
Created attachment 68421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68421=edit
Bug 10021: Update DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68263|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 68420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68420=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68262|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 68419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68419=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Katrin Fischer  ---
There seems to be an issue with the second patch:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10021: Drop table notifys and related code
Applying: Bug 10021: Drop columns notify_id and notify_level from accountlines
error: sha1 information is lacking or useless (C4/Overdues.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 10021: Drop columns notify_id and notify_level from
accountlines
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-10021-Drop-columns-notifyid-and-notifylevel-fr-hdUZOE.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54194|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 68262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68262=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #8 from Jonathan Druart  
---
Created attachment 68263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68263=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #6 from Jonathan Druart  
---
There are still code in C4::Account about accountlines.notify_id (at least).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12768

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

Summary|Remove dead(?) code related |Remove dead code related to
   |to notifys  |notifys
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> A second patch should remove the 2 columns notify_id and notify_level
> from the accountlines table.

But I am not familiar enough with this module to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #4 from Jonathan Druart  
---
Created attachment 54194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54194=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021
Bug 10021 depends on bug 6427, which changed state.

Bug 6427 Summary: Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Depends on||6427
 CC||kyle.m.h...@gmail.com,
   ||neng...@gmail.com

--- Comment #3 from Nicole C. Engard neng...@gmail.com ---
Most of this is solved in the accounts rewrite - bug 6427

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|3.14|master

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Now that bug 10256 has been pushed to master, we should also remove the
database parts of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10256

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
*** Bug 7081 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks||7315

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/