[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||27685


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685
[Bug 27685] Syspref OpacSuppression has no effect on the bibliographic detail
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478
[Bug 28478] MARC detail and ISBD pages still show suppressed records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #12 from Katrin Fischer  ---
(In reply to David Cook from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > (In reply to Sophie MEYNIEUX from comment #9)
> > > The field used for OpacSuppression should be set in a syspref : 942$n is
> > > used in marc21 but not in Unimarc
> > 
> > Could we hardcode a field for UNIMARC? You also need an index with a
> > specific name for it to work - would be good to have a default. Or have
> > harcoded values and a pref if they don't apply, with a warning that you have
> > to take care of indexing?
> > 
> > Anyway, we will need a new bug! :)
> 
> I'm thinking it's worthwhile having a database field for OpacSuppression,
> and then people can map the relevant MARC field using
> /cgi-bin/koha/admin/koha2marclinks.pl

It would be cleaner by fitting in better with existing patterns, but it
wouldn't solve the problem that you'd need an index defined. Having a
pre-defined index for UNIMARC could help people being able the feature in Koha
out of the box.

Btw. this bug has been fixed ages ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
(In reply to Katrin Fischer from comment #10)
> (In reply to Sophie MEYNIEUX from comment #9)
> > The field used for OpacSuppression should be set in a syspref : 942$n is
> > used in marc21 but not in Unimarc
> 
> Could we hardcode a field for UNIMARC? You also need an index with a
> specific name for it to work - would be good to have a default. Or have
> harcoded values and a pref if they don't apply, with a warning that you have
> to take care of indexing?
> 
> Anyway, we will need a new bug! :)

I'm thinking it's worthwhile having a database field for OpacSuppression, and
then people can map the relevant MARC field using
/cgi-bin/koha/admin/koha2marclinks.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #10 from Katrin Fischer  ---
(In reply to Sophie MEYNIEUX from comment #9)
> The field used for OpacSuppression should be set in a syspref : 942$n is
> used in marc21 but not in Unimarc

Could we hardcode a field for UNIMARC? You also need an index with a specific
name for it to work - would be good to have a default. Or have harcoded values
and a pref if they don't apply, with a warning that you have to take care of
indexing?

Anyway, we will need a new bug! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m

--- Comment #9 from Sophie MEYNIEUX  ---
The field used for OpacSuppression should be set in a syspref : 942$n is used
in marc21 but not in Unimarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #7 from Frédéric Demians frede...@tamil.fr ---
This patch could be seen as a regression for some libraries. I know one of them
which doesn't want to show 'hidden' biblio records on result page, but want to
propose to users direct links to some of those records from their intranet web
site: something like a 'confidential' bibliography.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think the best solution would be to add a third option then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19873|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20428
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20428action=edit
Bug 10195 Records hidden with OpacSuppression can still be accessed

Records hidden with OpacSuppression are filtered from the search
results, but the opac-detail page is still visible if you know the
biblio number. This patch hides the detail page for suppressed biblios
by redirecting (controlled by the syspref OpacSuppressionRedirect)
either to opac-blocked (default), explaining that the record is blocked
(including optional explanatory text from the syspref
OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a
biblio with that number exists in the system.

Test plan:

Make sure you have at least one record with 942$n == 1.
Set OpacSuppression to Don't hide.

Do an OPAC search that should bring up your hidden record and other
records.
  Observe that your record is found.
Open the detail page for the record.
  Observe that it is accessible. Copy the URL for later(!).

Set OpacSuppression to Hide.
Leave OpacSuppressionByIPRange blank.
Set OpacSuppressionRedirect to an explanatory page ('This record is
blocked').
Leave OpacSuppressionMessage blank for now.
Disable queryparser(!) (because of bug 10542).

Do a full zebra reindex.

Do an OPAC search that should bring up your hidden record and other
records.
  Observe that your record is not found.
Open the opac-detail URL of the record (the one you copied before).
  Observe that you are redirected to opac-blocked and it displays a
short standard message.

Edit OpacSuppressionMessage and input some text.
Open the opac-detail URL of the record again (the one you copied
before).
  Observe that the text you entered in OpacSuppressionMessage is
displayed under the standard text you have seen before.

Set OpacSuppressionRedirect to the 404 error page ('Not found').
Open the opac-detail URL of the record again (the one you copied before).
  Observe that you are redirected to Koha's 404 error page.

Sign off the patch. :)

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Passes koha-qa.pl, works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #19697|0   |1
is obsolete||

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19873
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19873action=edit
[SIGNED-OFF] Bug 10195 Records hidden with OpacSuppression can still be
accessed

Records hidden with OpacSuppression are filtered from the search
results, but the opac-detail page is still visible if you know the
biblio number. This patch hides the detail page for suppressed biblios
by redirecting (controlled by the syspref OpacSuppressionRedirect)
either to opac-blocked (default), explaining that the record is blocked
(including optional explanatory text from the syspref
OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a
biblio with that number exists in the system.

Test plan:

Make sure you have at least one record with 942$n == 1.
Set OpacSuppression to Don't hide.

Do an OPAC search that should bring up your hidden record and other
records.
  Observe that your record is found.
Open the detail page for the record.
  Observe that it is accessible. Copy the URL for later(!).

Set OpacSuppression to Hide.
Leave OpacSuppressionByIPRange blank.
Set OpacSuppressionRedirect to an explanatory page ('This record is
blocked').
Leave OpacSuppressionMessage blank for now.
Disable queryparser(!) (because of bug 10542).

Do a full zebra reindex.

Do an OPAC search that should bring up your hidden record and other
records.
  Observe that your record is not found.
Open the opac-detail URL of the record (the one you copied before).
  Observe that you are redirected to opac-blocked and it displays a
short standard message.

Edit OpacSuppressionMessage and input some text.
Open the opac-detail URL of the record again (the one you copied
before).
  Observe that the text you entered in OpacSuppressionMessage is
displayed under the standard text you have seen before.

Set OpacSuppressionRedirect to the 404 error page ('Not found').
Open the opac-detail URL of the record again (the one you copied before).
  Observe that you are redirected to Koha's 404 error page.

Sign off the patch. :)

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #1 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19691
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19691action=edit
Bug 10195 Records hidden with OpacSuppression can still be accessed

Initial commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #19691|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19693
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19693action=edit
Bug 10195 Records hidden with OpacSuppression can still be accessed

Records hidden with OpacSuppression are filtered from the search results, but
the opac-detail page is still visible if you know the biblio number. This patch
hides the detail page for suppressed biblios by redirecting (controlled by the
syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining
that the record is blocked (including optional explanatory text from the
syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a
biblio with that number exists in the system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #19693|0   |1
is obsolete||

--- Comment #3 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19697action=edit
Bug 10195 Records hidden with OpacSuppression can still be accessed

Records hidden with OpacSuppression are filtered from the search results, but
the opac-detail page is still visible if you know the biblio number. This patch
hides the detail page for suppressed biblios by redirecting (controlled by the
syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining
that the record is blocked (including optional explanatory text from the
syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a
biblio with that number exists in the system.

Test plan:

Make sure you have at least one record with 942$n == 1.
Set OpacSuppression to Don't hide.

Do an OPAC search that should bring up your hidden record and other records.
  Observe that your record is found.
Open the detail page for the record.
  Observe that it is accessible. Copy the URL for later(!).

Set OpacSuppression to Hide.
Leave OpacSuppressionByIPRange blank.
Set OpacSuppressionRedirect to an explanatory page ('This record is
blocked').
Leave OpacSuppressionMessage blank for now.
Disable queryparser(!) (because of bug 10542).

Do a full zebra reindex.

Do an OPAC search that should bring up your hidden record and other records.
  Observe that your record is not found.
Open the opac-detail URL of the record (the one you copied before).
  Observe that you are redirected to opac-blocked and it displays a short
standard message.

Edit OpacSuppressionMessage and input some text.
Open the opac-detail URL of the record again (the one you copied before).
  Observe that the text you entered in OpacSuppressionMessage is displayed
under the standard text you have seen before.

Set OpacSuppressionRedirect to the 404 error page ('Not found').
Open the opac-detail URL of the record again (the one you copied before).
  Observe that you are redirected to Koha's 404 error page.

Sign off the patch. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mi...@abunchofthings.net
   Assignee|oleon...@myacpl.org |mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/