[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18474|0 |1 is obsolete|| Attachment #18475|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18757 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18757action=edit Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes Renames the pref for install and upgrade. Test plan: See the other patch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18758 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18758action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) Signed-off-by: Kyle M Hall k...@bywatersolutions.com Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- git grep OpacShowHoldNotes returns 0 occurrence. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18762 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18762action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18757|0 |1 is obsolete|| Attachment #18758|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18761 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18761action=edit Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes Renames the pref for install and upgrade. Test plan: See the other patch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18415|0 |1 is obsolete|| --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18473 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18473action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18473|0 |1 is obsolete|| --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18474 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18474action=edit Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes Renames the pref for install and upgrade. Test plan: See the other patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18475 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18475action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- Separated the dbrev from the other changes. A merge conflict on the dbrev patch should not be hard to resolve :) Please test them on top of bug 10321. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Depends on||10321 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Building this on top of bug 10321. Please apply/test that one first :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18415 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18415action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in this patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
