[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12953

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12851

--- Comment #99 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #97)
> 1/ The letter generated contains the  tags.

I am going to provide a patch on bug 12851.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #98 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jared!

Note: some small template glitches I've seen vanished after I did ctrl+shift+r
to reload CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #97 from Jonathan Druart  ---
QA comment:

not blocker: On a editing a supplier with 1 contact, the "Delete contact"
button will remove the contact form. It is not blocker since you can click on
the "add contact" to add another contact.

Still in master:
1/ The letter generated contains the  tags.
2/ The validation on claiming serials does not work (no warning/error/ok
message on sending the emails). This should be done with bug 5342 (pending for
2 years...).

No regression found, all works as expected.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #92 from Jonathan Druart  ---
Created attachment 31092
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31092&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 
Signed-off-by: Paola Rossi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #96 from Jonathan Druart  ---
Created attachment 31096
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31096&action=edit
Bug 10402: FIX conflicts in Letters.t

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #95 from Jonathan Druart  ---
Created attachment 31095
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31095&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

Signed-off-by: Paola Rossi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #93 from Jonathan Druart  ---
Created attachment 31093
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31093&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 
Signed-off-by: Paola Rossi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #94 from Jonathan Druart  ---
Created attachment 31094
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31094&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 
Signed-off-by: Paola Rossi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #30460|0   |1
is obsolete||
  Attachment #30461|0   |1
is obsolete||
  Attachment #30462|0   |1
is obsolete||
  Attachment #30463|0   |1
is obsolete||
  Attachment #30464|0   |1
is obsolete||

--- Comment #91 from Jonathan Druart  ---
Created attachment 31091
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31091&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 
Signed-off-by: Paola Rossi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

  Attachment #30213|0   |1
is obsolete||

--- Comment #90 from Paola Rossi  ---
Created attachment 30464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30464&action=edit
Bug 10402 follow-up: choose contacts for claims

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

  Attachment #30211|0   |1
is obsolete||

--- Comment #88 from Paola Rossi  ---
Created attachment 30462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30462&action=edit
Bug 10402: Add ability to enter multiple contacts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

  Attachment #30212|0   |1
is obsolete||

--- Comment #89 from Paola Rossi  ---
Created attachment 30463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30463&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

  Attachment #30210|0   |1
is obsolete||

--- Comment #87 from Paola Rossi  ---
Created attachment 30461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30461&action=edit
Bug 10402: Move contacts to separate table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

  Attachment #30209|0   |1
is obsolete||

--- Comment #86 from Paola Rossi  ---
Created attachment 30460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30460&action=edit
Bug 10402: Use an object for contacts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #85 from Paola Rossi  ---
Thanks, Jared.

I've applied against 3.17.00.011.

Everything's ok.

So I pass the patches to "Signed Off" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #84 from Jared Camins-Esakov  ---
(In reply to Paola Rossi from comment #83)
> Today I've tried to apply against 3.17.00.011
> 
> Applying: Bug 10402: Use an object for contacts
> Using index info to reconstruct a base tree...
> Falling back to patching base and 3-way merge...
> Auto-merging acqui/supplier.pl
> 
> So I pass the patch to "Patch doesn't apply" status

This message doesn't mean that the patch doesn't apply. It's just telling you
that there were other changes made to acqui/supplier.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #83 from Paola Rossi  ---
Today I've tried to apply against 3.17.00.011

Applying: Bug 10402: Use an object for contacts
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging acqui/supplier.pl

So I pass the patch to "Patch doesn't apply" status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29602|0   |1
is obsolete||

--- Comment #80 from Jared Camins-Esakov  ---
Created attachment 30211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30211&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29603|0   |1
is obsolete||

--- Comment #81 from Jared Camins-Esakov  ---
Created attachment 30212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30212&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29761|0   |1
is obsolete||

--- Comment #82 from Jared Camins-Esakov  ---
Created attachment 30213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30213&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29601|0   |1
is obsolete||

--- Comment #79 from Jared Camins-Esakov  ---
Created attachment 30210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30210&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29600|0   |1
is obsolete||

--- Comment #78 from Jared Camins-Esakov  ---
Created attachment 30209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30209&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #77 from Paola Rossi  ---
Thanks, Jared.

I've tried to apply the patches against master 3.17.00.010.

Applying: Bug 10402: Use an object for contacts
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging acqui/uncertainprice.pl
Auto-merging acqui/supplier.pl

So I pass the patch to "Patch doesn't apply" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29604|0   |1
is obsolete||

--- Comment #76 from Jared Camins-Esakov  ---
Created attachment 29761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29761&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #75 from Jared Camins-Esakov  ---
(In reply to Paola Rossi from comment #74)
> 1) I've edited the vendor. The "Notes" field of the contact is shown empty.

Good catch!

Issues 2-4 and the breadcrumbs you mention are outside the scope of this
development. The following are true of Koha going back to 3.8 at least (so far
as I can tell):
2) you can save an invalid e-mail address
3-4) notices will fail if you don't have an e-mail address set up for your
account
5) you will see the vendor ID number rather than the vendor name in breadcrumbs
after saving a vendor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #74 from Paola Rossi  ---
I've applied the patches against master 3.17.00.009

I've added a vendor.
I've added a contact [filling the "Notes" field].
I've saved the vendor.

1) I've edited the vendor. The "Notes" field of the contact is shown empty.

2) I've filled the "Email" field of the contact with such a string :
X
I've selected "Save". The system has given no error, instead of sending "Please
enter a valid email address" error.

3) I've tried to send late orders. The system has shown:
"Email has been sent"
but I (I'm the vendor...) have received no mail.
On apache' log:
[Fri Jul 11 17:09:29] lateorders.pl at line 107: Bad or missing From address:
''

It seems SendAlerts line 366 has no mail in $userenv->{emailaddress}.
[The "Primary email", "Secondary email" and "Alternate address' email" fields
of the patron/login-user are set well.]

4) I've tried to send serials claims. 
I've "sent a notification". 
The system has given me no feedback, the subscription has become in "Claimed"
status, but I've received no mail.
On apache' log:
[Fri Jul 11 17:29:43] claims.pl at line 78: Bad or missing From address: ''

So I've passed the patch to "Failed QA" status.
---

NB. Soon after having saved the vendor "XX", I see:
Home > Acquisition > Search for vendor Y,
where Y is the id of the aqbookseller "XX".
IMO Y is instead of the vendor's name, which can be searched.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29226|0   |1
is obsolete||

--- Comment #72 from Jared Camins-Esakov  ---
Created attachment 29603
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29603&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29511|0   |1
is obsolete||

--- Comment #73 from Jared Camins-Esakov  ---
Created attachment 29604
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29604&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29224|0   |1
is obsolete||

--- Comment #70 from Jared Camins-Esakov  ---
Created attachment 29601
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29601&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29225|0   |1
is obsolete||

--- Comment #71 from Jared Camins-Esakov  ---
Created attachment 29602
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29602&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29223|0   |1
is obsolete||

--- Comment #69 from Jared Camins-Esakov  ---
Created attachment 29600
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29600&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #68 from Paola Rossi  ---
[I beg your pardon.]

I've tried to apply against master 3.17.00.009

Applying: Bug 10402 follow-up: choose contacts for claims
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging t/db_dependent/Bookseller.t
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

I've passed the patch to "Patch doesn't apply" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #67 from Paola Rossi  ---
I've tried to apply against master 3.17.00.009

Applying: Bug 10402 follow-up: choose contacts for claims
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging t/db_dependent/Bookseller.t
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

So I've passed the patch to "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #29227|0   |1
is obsolete||

--- Comment #66 from Jared Camins-Esakov  ---
Created attachment 29511
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29511&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #65 from Jared Camins-Esakov  ---
(In reply to Paola Rossi from comment #63)
> Going on, on editing a vendor an empty contact was always listed before the
> filled contacts. So "Save" could add a further contact, whilest "Add another
> contact" didn't seem to be needed.
> I have not been able to delete one contact from a vendor with multiple
> contacts selecting "x Delete contact".

I have a patch which fixes the update and the contact deleting. The empty
contact is intentional- there should always be one contact visible when you
open up the form, because otherwise you might forget to enter any contact
information you might have.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #64 from Paola Rossi  ---

Today I've tried against master 3.17.00.009

After I've replaced [in th 5-th patch to apply, line 274]:

"acquisitionprimary" with "acqprimary", 
"issuesprimary" with "serialsprimary", 

updating the DB was OK.

I've kept the "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #63 from Paola Rossi  ---
I've applied against master 3.1.7.00.008.

I've tried to update database, and an error occurred:

Update report :
Upgrade to 3.17.00.009 done (Bug 10402: Move bookseller contacts to
separate table)
Update errors :
[Fri Jun 27 14:44:13 2014] updatedatabase.pl: DBD::mysql::db do failed:
Unknown column 'acquisitionprimary' in 'field list' at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8583.

So I've passed the patch to "Failed QA" status.
--
After having passed acquisitionprimary to acqprimary, another error occured:

Update errors :
[Fri Jun 27 15:07:19 2014] updatedatabase.pl: DBD::mysql::db do failed:
Unknown column 'issuesprimary' in 'field list' at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8583.

After having passed issuesprimary to acqprimary, updating the DB was OK. 

Going on, on editing a vendor an empty contact was always listed before the
filled contacts. So "Save" could add a further contact, whilest "Add another
contact" didn't seem to be needed.
I have not been able to delete one contact from a vendor with multiple contacts
selecting "x Delete contact".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #24565|0   |1
is obsolete||
  Attachment #24566|0   |1
is obsolete||
  Attachment #24567|0   |1
is obsolete||
  Attachment #24568|0   |1
is obsolete||

--- Comment #62 from Jared Camins-Esakov  ---
Created attachment 29227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29227&action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #24564|0   |1
is obsolete||

--- Comment #61 from Jared Camins-Esakov  ---
Created attachment 29226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29226&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #24562|0   |1
is obsolete||

--- Comment #59 from Jared Camins-Esakov  ---
Created attachment 29224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29224&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #24563|0   |1
is obsolete||

--- Comment #60 from Jared Camins-Esakov  ---
Created attachment 29225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29225&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #24561|0   |1
is obsolete||

--- Comment #58 from Jared Camins-Esakov  ---
Created attachment 29223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29223&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Holger Meißner  changed:

   What|Removed |Added

 CC||h.meissner...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #57 from Jonathan Druart  ---
It seems I cannot deactivate the 2 values claimacquisition and claimissues (on
editing a supplier). The 2 checkboxes are always checked.
I don't see (in the code) where you check the aqcontacts.claimacquisition flag
before sending a claim for late orders.
It seems only the first contact is notified, is it wanted?

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23377|0   |1
is obsolete||

--- Comment #56 from Jared Camins-Esakov  ---
Created attachment 24568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24568&action=edit
Bug 10402: correct number of tests

When merging t/db_dependent/Bookseller.t, the number of tests listed
was not changed, causing the test to fail with too many tests.

All patches rebased on master 2014/01/19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23375|0   |1
is obsolete||

--- Comment #54 from Jared Camins-Esakov  ---
Created attachment 24566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24566&action=edit
Bug 10402 follow-up: fix perlcritic exception

Perlcritic doesn't like the syntax keys $variable, and requires that
you explicitly dereference a hashref to a hash before using keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23376|0   |1
is obsolete||

--- Comment #55 from Jared Camins-Esakov  ---
Created attachment 24567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24567&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23372|0   |1
is obsolete||

--- Comment #51 from Jared Camins-Esakov  ---
Created attachment 24563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24563&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23373|0   |1
is obsolete||

--- Comment #52 from Jared Camins-Esakov  ---
Created attachment 24564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24564&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23374|0   |1
is obsolete||

--- Comment #53 from Jared Camins-Esakov  ---
Created attachment 24565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24565&action=edit
Bug 10402 follow-up: rebase onto latest master

Because of the complexity of the rebase, I have chosen to correct
a couple merge errors in a separate patch rather than squashing the
corrections into the last patch in the patchset.

This rebase patch does one thing that may not be completely obvious:
in order to keep the existing tests matching their stated aims, it
centralizes contact-related unit testing at the end of the Bookseller.t
unit test, and removes contacts from earlier tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23371|0   |1
is obsolete||

--- Comment #50 from Jared Camins-Esakov  ---
Created attachment 24562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24562&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-01-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #23370|0   |1
is obsolete||

--- Comment #49 from Jared Camins-Esakov  ---
Created attachment 24561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24561&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21056|0   |1
is obsolete||

--- Comment #46 from Jared Camins-Esakov  ---
Created attachment 23375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23375&action=edit
Bug 10402 follow-up: fix perlcritic exception

Perlcritic doesn't like the syntax keys $variable, and requires that
you explicitly dereference a hashref to a hash before using keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21804|0   |1
is obsolete||

--- Comment #47 from Jared Camins-Esakov  ---
Created attachment 23376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23376&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #48 from Jared Camins-Esakov  ---
Created attachment 23377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23377&action=edit
Bug 10402: correct number of tests

When merging t/db_dependent/Bookseller.t, the number of tests listed
was not changed, causing the test to fail with too many tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21023|0   |1
is obsolete||

--- Comment #45 from Jared Camins-Esakov  ---
Created attachment 23374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23374&action=edit
Bug 10402 follow-up: rebase onto latest master

Because of the complexity of the rebase, I have chosen to correct
a couple merge errors in a separate patch rather than squashing the
corrections into the last patch in the patchset.

This rebase patch does one thing that may not be completely obvious:
in order to keep the existing tests matching their stated aims, it
centralizes contact-related unit testing at the end of the Bookseller.t
unit test, and removes contacts from earlier tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21022|0   |1
is obsolete||

--- Comment #44 from Jared Camins-Esakov  ---
Created attachment 23373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23373&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21021|0   |1
is obsolete||

--- Comment #43 from Jared Camins-Esakov  ---
Created attachment 23372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23372&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21019|0   |1
is obsolete||

--- Comment #41 from Jared Camins-Esakov  ---
Created attachment 23370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23370&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21020|0   |1
is obsolete||

--- Comment #42 from Jared Camins-Esakov  ---
Created attachment 23371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23371&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

I'm just a bot  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00 |2013-10-28
last check this||

--- Comment #40 from I'm just a bot  ---
Applying: Bug 10402: Use an object for contacts
Using index info to reconstruct a base tree...
MC4/Bookseller.pm
Macqui/uncertainprice.pl
Mkoha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Mkoha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
Mt/db_dependent/Bookseller.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Bookseller.t
CONFLICT (content): Merge conflict in t/db_dependent/Bookseller.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging acqui/uncertainprice.pl
CONFLICT (content): Merge conflict in acqui/uncertainprice.pl
Auto-merging C4/Bookseller.pm
Patch failed at 0001 Bug 10402: Use an object for contacts
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-10-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-10-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21549|0   |1
is obsolete||

--- Comment #39 from Jared Camins-Esakov  ---
Created attachment 21804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21804&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-10-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bgkrie...@gmail.com

--- Comment #38 from Bernardo Gonzalez Kriegel  ---
There is a problem in updatedatabase.pl
this creates the table, note selected columns (->)

$dbh->do("CREATE TABLE aqcontacts (
id int(11) NOT NULL auto_increment,
name varchar(100) default NULL,
position varchar(100) default NULL,
phone varchar(100) default NULL,
altphone varchar(100) default NULL,
fax varchar(100) default NULL,
email varchar(100) default NULL,
notes mediumtext,
->claimacquisition BOOLEAN NOT NULL DEFAULT 0,
->claimissues BOOLEAN NOT NULL DEFAULT 0,
booksellerid int(11) not NULL,
PRIMARY KEY  (id),
CONSTRAINT booksellerid_fk2 FOREIGN KEY (booksellerid)
REFERENCES aqbooksellers (id) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;");

this try to insert into non-existent columns (->)

$dbh->do("INSERT INTO aqcontacts (name, position, phone, altphone, fax,
email, notes, booksellerid, -> acq_claim, -> serial_claim)

perl installer/data/mysql/updatedatabase.pl
DBD::mysql::db do failed: Unknown column 'acq_claim' in 'field list' at
installer/data/mysql/updatedatabase.pl line 7176.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

I'm just a bot  changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-09-29
last check this||

--- Comment #37 from I'm just a bot  ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #21547|0   |1
is obsolete||

--- Comment #36 from Jared Camins-Esakov  ---
Created attachment 21549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21549&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
> prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #35 from Jared Camins-Esakov  ---
Created attachment 21547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21547&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #34 from Katrin Fischer  ---
Hi Jared,

I think this is a great improvement and it works nicely in the UI, but there
are 2 concerns:
- aqcontacts.rank is not used as far as I can see
- it seems to break use of the contact fields in serials and acquisition claim
letters.

Could you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #33 from Jared Camins-Esakov  ---
Created attachment 21056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21056&action=edit
Bug 10402 follow-up: fix perlcritic exception

Perlcritic doesn't like the syntax keys $variable, and requires that
you explicitly dereference a hashref to a hash before using keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #32 from Kyle M Hall  ---
FAIL   acqui/supplier.pl
   OK pod
   OK forbidden patterns
   FAIL   valid
Type of arg 1 to keys must be hash (not private variable)
acqui/supplier.pl had compilation errors.
   OK critic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #31 from Jared Camins-Esakov  ---
Created attachment 21023
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21023&action=edit
Bug 10402 follow-up: rebase onto latest master

Because of the complexity of the rebase, I have chosen to correct
a couple merge errors in a separate patch rather than squashing the
corrections into the last patch in the patchset.

This rebase patch does one thing that may not be completely obvious:
in order to keep the existing tests matching their stated aims, it
centralizes contact-related unit testing at the end of the Bookseller.t
unit test, and removes contacts from earlier tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20561|0   |1
is obsolete||

--- Comment #29 from Jared Camins-Esakov  ---
Created attachment 21021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21021&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20562|0   |1
is obsolete||

--- Comment #30 from Jared Camins-Esakov  ---
Created attachment 21022
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21022&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20559|0   |1
is obsolete||

--- Comment #27 from Jared Camins-Esakov  ---
Created attachment 21019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21019&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20560|0   |1
is obsolete||

--- Comment #28 from Jared Camins-Esakov  ---
Created attachment 21020
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21020&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #26 from Katrin Fischer  ---
Hi Jared, 
can you please rebase? Thx!
#both modified:  C4/Bookseller.pm
#both added: t/db_dependent/Bookseller.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20048|0   |1
is obsolete||

--- Comment #25 from Jared Camins-Esakov  ---
Created attachment 20562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20562&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20047|0   |1
is obsolete||

--- Comment #24 from Jared Camins-Esakov  ---
Created attachment 20561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20561&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20046|0   |1
is obsolete||

--- Comment #23 from Jared Camins-Esakov  ---
Created attachment 20560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20560&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #20045|0   |1
is obsolete||

--- Comment #22 from Jared Camins-Esakov  ---
Created attachment 20559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20559&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #21 from Owen Leonard  ---
Created attachment 20048
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20048&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Owen Leonard  changed:

   What|Removed |Added

  Attachment #20019|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  ---
Created attachment 20045
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20045&action=edit
[SIGNED-OFF] Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Owen Leonard  changed:

   What|Removed |Added

  Attachment #20021|0   |1
is obsolete||

--- Comment #20 from Owen Leonard  ---
Created attachment 20047
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20047&action=edit
[SIGNED-OFF] Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Owen Leonard  changed:

   What|Removed |Added

  Attachment #20020|0   |1
is obsolete||

--- Comment #19 from Owen Leonard  ---
Created attachment 20046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20046&action=edit
[SIGNED-OFF] Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19810|0   |1
is obsolete||

--- Comment #17 from Jared Camins-Esakov  ---
Created attachment 20021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20021&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19809|0   |1
is obsolete||

--- Comment #16 from Jared Camins-Esakov  ---
Created attachment 20020
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20020&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19808|0   |1
is obsolete||

--- Comment #15 from Jared Camins-Esakov  ---
Created attachment 20019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20019&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19603|0   |1
is obsolete||

--- Comment #13 from Jared Camins-Esakov  ---
Created attachment 19809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19809&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >