[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #9 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20032|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20396 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20396action=edit Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error Can't use an undefined value as a HASH reference on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration Currency Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) = without the patch you get the software error = with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20397 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20397action=edit Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency Fixes the following koha-qa.pl error: FAIL misc/cronjobs/overdue_notices.pl OK pod OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19991|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20032 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20032action=edit [SIGNED-OFF] Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error Can't use an undefined value as a HASH reference on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration Currency Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) = without the patch you get the software error = with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz --- Currency stuff should be moved out of Budgets.pm ASAP. It is ridiculous for Output.pm to depend on Budgets.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 --- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 19991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19991action=edit Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error Can't use an undefined value as a HASH reference on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration Currency Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) = without the patch you get the software error = with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8378 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
