[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Katariina Hanhisalo  changed:

   What|Removed |Added

 CC||katariina.hanhis...@xamk.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #78 from Katrin Fischer  ---
Now that 33262 has been pushed, we could possibly fix this. I have seen some
work on deleted objects on other bugs, maybe we could even benefit from that
work here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||33262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262
[Bug 33262] When an ordered record is deleted, we lose all information on what
was ordered
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #77 from Katrin Fischer  ---
I believe this has been kept open for way too long, we need to find a fix
independent of bug 20271 because we keep losing data and bug 20271 is no quick
fix. The least we need to do is make sure the biblionumber is not lost from
aqorders when the record is deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #76 from mathieu saby  ---
Hi
Is there still a will to work on that? Or should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 be pushed
first?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Sophie H  changed:

   What|Removed |Added

 CC||sophie.halden@cheshireshare
   ||dservices.gov.uk

--- Comment #75 from Sophie H  ---
We would also be interested in this feature

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

--- Comment #73 from Michaela Sieber  ---
+1 and voted :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #74 from Rhonda Kuiper  ---
+1 This would be a fantastic feature to have.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #72 from mathieu saby  ---
Hi
I proposed a patch for that bug a lng time ago. I suppose it is obsolete
now, but I am a bit sad to see that the situation has not evolved.
Is it reasonable to expect a solution in the foreseeable future?

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #71 from Barbara Johnson  ---
+1 - Displaying the bib info for cancelled orders is essential functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Donna  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

--- Comment #70 from Donna  ---
This is definitely an ongoing issue - users have no way of telling what was
cancelled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #69 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #68)
> (In reply to Jonathan Druart from comment #67)
> > That should be done on top of bug 20271.
> 
> We could do it in a different way too - I know that we got some logic in a
> table now where 2 biblionumbers are stored in different columns - that way
> FK can be set. Martin did it, I just fail to remember the bug report and
> table.

Yes, but it is adding more stuffs to unravel for bug 20271.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #68 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #67)
> That should be done on top of bug 20271.

We could do it in a different way too - I know that we got some logic in a
table now where 2 biblionumbers are stored in different columns - that way FK
can be set. Martin did it, I just fail to remember the bug report and table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20271

--- Comment #67 from Jonathan Druart  
---
That should be done on top of bug 20271.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
[Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items
tables with their "alive" cousins
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #66 from Katrin Fischer  ---
I'd really love to see progress here, it's a big issue in the acquisition
module as we display the cancelled orders so prominently. I get asked to
manually delete them on a regular basis by one our libraries as you can't see
what was cancelled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #65 from Jonathan Druart  
---
Created attachment 95782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95782=edit
Bug 10758: WIP

Started working on this but then realised we do not have
Koha::Old::Biblios classes. It is getting complicated and will put a
spoke in bug 20271's wheel

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Suzanne Fayle  changed:

   What|Removed |Added

 CC|sfa...@roseman.edu  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

karen.fell...@citruslibraries.org changed:

   What|Removed |Added

 CC||karen.fellows@citruslibrari
   ||es.org

--- Comment #64 from karen.fell...@citruslibraries.org ---
It would be great if this got some attention.  If it would be possible to just
display the info in the Acquisitions side rather than just deleting the title
and other information.  Maybe remove the links and add an internal note (item
deleted) or something to that effect?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16872

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #63 from Jonathan Druart  
---
(In reply to Sandre Cunha from comment #62)
> What is the current status of this issue?

The bug report is not assigned to anyone. A patch has been submitted few years
ago but need to be rebased and certainly adapted to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Sandre Cunha  changed:

   What|Removed |Added

 CC||cu...@monterey.org

--- Comment #62 from Sandre Cunha  ---
What is the current status of this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #60 from Nicole C. Engard neng...@gmail.com ---
Removing in discussion as it seems we can maybe get this in now? It's a big big
deal to track what was ordered/deleted for reorder and accounting purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #61 from mathieu saby mathsaby...@gmail.com ---
Sorry Katrin, I'm to far from Koha now to continue my work on that issue. So if
someone want to work on it, feel free to take my patches as a base. I'm
unassinging me.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

   Assignee|mathsaby...@gmail.com   |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #59 from Paola Rossi paola.ro...@cineca.it ---
(In reply to mathieu saby from comment #58)
 Bug 7162 (passed QA) will have consequencies for this one, as it is
 refactoring DelOrder. I will have to make some adjusments. So do not test
 before 7162 is passed, it will be a waste of time...
 I change the status to in discussion.
 
 Matheiu

Hi Mathieu,

bug 7162 has been pushed to master. What about this bug now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7162

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #58 from mathieu saby mathsaby...@gmail.com ---
Bug 7162 (passed QA) will have consequencies for this one, as it is refactoring
DelOrder. I will have to make some adjusments. So do not test before 7162 is
passed, it will be a waste of time...
I change the status to in discussion.

Matheiu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #54 from Paola Rossi paola.ro...@cineca.it ---
Kind Mr. Mathieu Saby, I'm in doubt that the patch Show... that you filed on
Aug the 6-th may not be the right one.

The date inside the Show ... patch is :
Date: Fri, 4 Apr 2014 09:36:52 +0200
and the patch is about 3.17.00.008 changing updatedatabase.pl .

Could you please verify? Thanks in advance.

Anyway today the patch doesn't apply [against master 3.17.00.013] :

Applying: Bug 10758 - Show bibliographic information of deleted records in
acquisitions
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 10758 - Show bibliographic information of deleted
records in acquisitions

So I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #55 from mathieu saby mathsaby...@gmail.com ---
My machine does not update the date when I rebase a patch. I don't know if
there is an option for that. So, all the versions of this patch - that are
obsoleted - are dated from April 4.
I'm going to rebase it again and set manually a new date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #56 from mathieu saby mathsaby...@gmail.com ---
Well, in fact you were probably right :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #30552|0   |1
is obsolete||

--- Comment #57 from mathieu saby mathsaby...@gmail.com ---
Created attachment 30623
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30623action=edit
[PATCH] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

Rebased
I've tested it, it seems to work

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #49 from Paola Rossi paola.ro...@cineca.it ---
I've tried to apply the patches against master 3.17.00.011.

Applying: Bug 10758 - Show bibliographic information of deleted records in
acquisitions
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging acqui/neworderempty.pl
Auto-merging acqui/basket.pl
Auto-merging C4/Biblio.pm
CONFLICT (content): Merge conflict in C4/Biblio.pm
Auto-merging C4/Acquisition.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 10758 - Show bibliographic information of deleted
records in acquisitions
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.

So I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #29667|0   |1
is obsolete||

--- Comment #50 from mathieu saby mathsaby...@gmail.com ---
Created attachment 30551
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30551action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

1st patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #51 from mathieu saby mathsaby...@gmail.com ---
ooops, still a mistake, please don't test for the moment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #30551|0   |1
is obsolete||

--- Comment #52 from mathieu saby mathsaby...@gmail.com ---
Created attachment 30552
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30552action=edit
[PATCH] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

--- Comment #53 from mathieu saby mathsaby...@gmail.com ---
rebased again, it applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #28514|0   |1
is obsolete||

--- Comment #48 from mathieu saby mathsaby...@gmail.com ---
Created attachment 29667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29667action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

Indeed, that horrible HEAD was breaking everything!
It's fixed.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||paola.ro...@cineca.it

--- Comment #47 from Paola Rossi paola.ro...@cineca.it ---
I apply against master 3.17.00.007.

I think that the first patch (Show bibliographic ...) has an error:
on updtedatabase.pl it requires this insertion:

+ HEAD


Anyway the Web installer Step 3 gives this error report on updating database
structure:
Update report :
Status: 500
Content-type: text/html
h1Software error:/h1
presyntax error at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8172, near
quot;-andquot;
(Might be a runaway multi-line lt;lt; string starting on line 8169)
Can't find string terminator quot;shareurlquot; anywhere before EOF at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8174.
/pre
p
For help, please send mail to the webmaster (a
href=mailto:webmaster@linux-test;webmaster@linux-test/a), giving this error
message
and the time and date of the error.
/p

Update errors :

[Fri Jun 6 17:46:50 2014] updatedatabase.pl: Use of bare  to mean  is
deprecated at /var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl
line 8162.
[Fri Jun 6 17:46:50 2014] updatedatabase.pl: Use of bare  to mean  is
deprecated at /var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl
line 8169.
[Fri Jun 6 17:46:50 2014] updatedatabase.pl: syntax error at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8172, near
-and
[Fri Jun 6 17:46:50 2014] updatedatabase.pl: (Might be a runaway multi-line
 string starting on line 8169)
[Fri Jun 6 17:46:50 2014] updatedatabase.pl: Can't find string terminator
shareurl anywhere before EOF at
/var/root-koha/bug-7162/installer/data/mysql/updatedatabase.pl line 8174.
--- 
I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #27314|0   |1
is obsolete||

--- Comment #44 from mathieu saby mathsaby...@gmail.com ---
Created attachment 28514
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28514action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #27315|0   |1
is obsolete||

--- Comment #45 from mathieu saby mathsaby...@gmail.com ---
Created attachment 28515
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28515action=edit
[PATCH 2/2] Bug 10758 - Fix Acquisition unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #46 from mathieu saby mathsaby...@gmail.com ---
Patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11243

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #26832|0   |1
is obsolete||

--- Comment #40 from mathieu saby mathsaby...@gmail.com ---
Created attachment 27312
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27312action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #27312|0   |1
is obsolete||

--- Comment #41 from mathieu saby mathsaby...@gmail.com ---
Created attachment 27313
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27313action=edit
[PATCH 2/2] Bug 10758 - Fix Acquisition unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #27273|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #27313|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #42 from mathieu saby mathsaby...@gmail.com ---
Created attachment 27314
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27314action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #43 from mathieu saby mathsaby...@gmail.com ---
Created attachment 27315
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27315action=edit
[PATCH 2/2] Bug 10758 - Fix Acquisition unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #38 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
test on a sandbox :
h1Something went wrong !/h1Applying: Bug 10758 - Fix Acquisition unit tests
Applying: Bug 10758 - Show bibliographic information of deleted records in
acquisitions
fatal: sha1 information is lacking or useless
(installer/data/mysql/updatedatabase.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #39 from mathieu saby mathsaby...@gmail.com ---
I don't understand.
It applies properly against master on my VM, either with git bz apply 10758
or by applying manually the 2 patches with git am.

Maybe a sandbox issue?

I put it back to needs signoff. If the problem persists I hope someone could
help me on that :(

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10869

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #26830|0   |1
is obsolete||

--- Comment #36 from mathieu saby mathsaby...@gmail.com ---
Created attachment 27273
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27273action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

(I removed the changes to Koha/Schema/Result/Aqorder.pm, as it should not be
integrated in the main patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #37 from mathieu saby mathsaby...@gmail.com ---
Please note that bug 10869 is linked to this bug.

There is no dependancy strictly speaking, so both can be tested, but bug 10758
is bigger, so I suppose bug 10869 will be pushed first, and I will have then
to make some changes to bug 10758.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Depends on|10869   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

  Attachment #22106|0   |1
is obsolete||

--- Comment #33 from mathieu saby mathsaby...@gmail.com ---
Created attachment 26830
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26830action=edit
[PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

No more dependancy

Fully testable, but a second patch will be provided for fixing and improving
the UTs
Aim of the patch : when a record is deleted but used in an order, display
information stored
in deletedbiblio and deletedbiblioitems tables on some pages of acquisition
module

Note that this patch will only have real effects for records deleted AFTER its
application.

Changes :
- modification of database structure : new column deletedbiblionumber in
aqorders
We keep the constraint between aqorders.biblionumber and biblio.biblionumber,
but we create a new one between
aqorders.deletedbiblionumber and deletedbiblio.biblionumber
With this system, we can make a JOIN between aqorders and
deleted(biblio/biblioitems) table, and retreive information.

- modification of GetOrder, GetOrders, GetCancelledOrders and SearchOrders in
C4::Acquisition :
Those subs are now also getting bibliographic information from deleted tables
deletedbiblio and deletedbiblioitems
Only usefull or potentially usefull fields are retreived (no more biblio.* and
biblioitems.*)
For each field, I used COALESCE in SQL query. Ex: COALESCE
(biblio.title,deletedbiblio.title) AS title

- modification of DelBiblio in C4::Biblio
Wen a record is deleted with DelBiblio, the sub checks if it used in an order
If so, the biblionumber is deleted from aqorders.biblionumber (as before), but
it is copied to aqorder.deletedbiblionumber

- modification of files in acqui : basket.pl, neworderempty.pl
To transmit the new key deletedbiblionumber to the templates

- modification of templates in intranet/module/acqui : basket.tt,
histsearch.tt, lateorders.tt, neworderempty.tt, parcel.tt

Test plan :
A. BEFORE applying the patch
- create a basket with at least 4 orders,using different records
- in the catalog, delete one of the record used by 1st order, whithout
cancelling the order (there will be an alert, but you can do that)
- return to the basket page (or refresh it) : the information about the record
is lost
- if you want, try to receive orders or to search orders : in those pages too
the information for this record will be lost

B. Apply the patch and run updatedatabase.pl

C. Go back to your basket and refresh it
- the information of the record deleted before the application of the patch is
still lost (Can't find title)
- in the catalog, delete one of the record used by 2d order, whithout
cancelling the order
- return to the basket page (or refresh it) : the information about the record
is still visible, with the mention (Deleted record)
- Try to modify the 2d order : click on Modifiy on the right column of the
table
- you will get on neworderempty.pl, but with a message (Deleted record, not
editable).
You will be able to change accounting details but not bibliographic information
(In a future development, we could imagine to recreate a record and in order to
make the order editable even if the original record
is deleted, but it would be dangerous to do so now)
- in the basket, cancel the 3rd order AND the record (click on Delete order
and record)
- in the Cancelled orders, you still could see bibliographic information
about the cancelled order, with the mention (Deleted record)

D. Go on late orders page
- check you can see information about 2d order (which is linked with a deleted
record)

E. Go on order advanced search page
- fill the form with the title of 2d order and click on Search
- check Koha can retreive the order, and show correct information

F. Try to receive orders from the vendor used for your basket
- in the filters on the left of the page which displays the table of pending
orders, search the title of the 2d order
- Koha should retreive the 2d order
- you must have a mention Deleted record, order cannot be received above the
title
- you must not have a link Receive on the left of the table
(In a future development, we could imagine to recreate a record to do the
receipt, but it would be dangerous to do so now.
The best to do if a record was deleted and the order not yet received is
probably to cancel the order, and to recreate it by hand)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : 

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #34 from mathieu saby mathsaby...@gmail.com ---
I'm working on UT, but you can already test.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #35 from mathieu saby mathsaby...@gmail.com ---
Created attachment 26832
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26832action=edit
[PATCH 2/2] Bug 10758 - Fix Acquisition unit tests


This patch fixes Acquisition UT
Maybe more work could be done to write specific UT for testing the new features
introduced by bug 10758

To test : prove -v t/db_dependant/Acquisition.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Depends on|11224   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #32 from mathieu saby mathsaby...@gmail.com ---
Bug 11224 is pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 Depends on||11224

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #31 from mathieu saby mathieu.s...@univ-rennes2.fr ---
In fact, the 1st step is adding UT to current master. Then, I will work again
on that bug.
See Bug 11224 for new UTs

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #30 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I think factorizing code would make things much easier.
Katrin and Jonathan, could you take a look at Bug 11206 please?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #29 from mathieu saby mathieu.s...@univ-rennes2.fr ---
patch does not apply anymore. I'm working on that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I won't make Biblio.t unimarc compliant, that's too complex. But I'm still
working on writing UT.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #27 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I see UT for Acquisition subs in Acquisition.t and in separate files for
TransferOrder, OrderFromSubscription and GetOrdersByBiblionumber.

If I want to add UT for NewOrder, DelOrder, GetOrder, GetOrders, etc etc etc ,
what is the better : use Acquisition.t, whith comments to make clear which Sub
I am testing, or creating a new file of each one?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

  Attachment #21296|0   |1
is obsolete||

--- Comment #28 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 22106
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22106action=edit
[PATCH] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

Some modification to the original patch + 2 UT
I still need to write 2 UT.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #25 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Katrin Fischer from comment #24)
 Hi Mathieu,
 
 I don't have a lot of time until after KohaCon probably - but it would
 really help this along if you can provide unit tests for the changed
 routines.

Ok.
I will take  the occasion for improving Biblio.t. It is failing with my unimarc
database.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 CC||tredok.pie...@gmail.com

--- Comment #21 from Pierre Angot tredok.pie...@gmail.com ---
There is a problem on sandbox : 

Some problems occurred applying patches from bug 10758:
h1Something went wrong !/h1Applying: Bug 10758 - Show bibliographic
information of deleted records in acquisitions
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10758 - Show bibliographic information of deleted
records in acquisitions
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10758 - Show bibliographic information of deleted records in acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Depends on: 10869
You cannot test on sandbox

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #23 from mathieu saby mathieu.s...@univ-rennes2.fr ---
By the way, if Jonathan or Katrin could drop an eye on my code before somebody
try to sign it off, I would appreciate (especially the queries changed in
C4/Acquisitions)
If somebody sign it off and if QA tell me I need to rewrite it on a different
base it afterwards, the tester would have work for nothing ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Mathieu,

I don't have a lot of time until after KohaCon probably - but it would really
help this along if you can provide unit tests for the changed routines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #20 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(I suppose Jonathan's code is better)
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #19 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I have just seen that Jonathan Druart has made an other choice (COALESCE
biblio.title, deletedbiblio.title) for the same purpose in his bug for
improving order search (bug 5336, attachment 21689).
I am not a database expert, so could somebody check the code and tell me if my
solution (UNION ALL...) is good?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #18 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Note : Bug 10869 has been signed off.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-09-24
last check this||

--- Comment #16 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #17 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #15 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 21296
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21296action=edit
[PATCH] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

This patch must be applied on top of patch 10869
Aim of the patch : display information stored in deletedbiblio and
deletedbiblioitems tables in basket.tt and neworderempty.tt pages
Content :
- modification of database structure : new column deletedbiblionumber in
aqorders
- modification of GetOrder, GetOrders and GetCancelledOrders in C4::Acquisition
- modification of DelBiblio in C4::Biblio
- modification of the 2 templates

Maybe some changes must be made to UT, and maybe the performance of my queries
is not optimal.
But please first test to check if it is doing what it is meant for...

To test:
- create a basket with 5 orders using records A,B,C,D (you can use existing
records or create new ones, it does not matter)
- delete 2 orders A  B, but keep the records
- in the catalogue, suppress record A (used by a cancelled order)  D (used by
an active order)
- refresh the basket page : you should see the suppressed orders in Cancelled
Orders block, with readable title and authors of deleted records, and a note
(Deleted record)
- click on Modifiy for order D. You should see the title, author, publisher,
date... without the link [Edit Record] but with a message (Deleted record, non
editable)
- click on Modify for record C. You should have [Edit record] link
- create an order E.
- delete order E, and the record (link 'delete order and record')
- refresh the basket. you should see the order in the Cancelled Orders, with a
readable title and author


M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Depends on||10869

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #14 from mathieu saby mathieu.s...@univ-rennes2.fr ---
*** Bug 6920 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to mathieu saby from comment #9)
 Could you tell me how to write the constraint to link aqorders.biblionumber
 with biblio.biblionumber, but to keep the value of  aqorders.biblionumber
 when the biblio is suppressed ?

No possible. To do that, I think you must add a new column in aqorders which
point to deletedbiblio.biblionumber.
You have to delete the biblio, the aqorders.biblionumber will be set to NULL.
Next update the aqorders.deletedbiblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Thanks
I have looked at the documentation of MySQL, and that's I understood, but I was
not sure of that...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr ---
*** Bug 8638 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/