[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17559
[Bug 17559] Invalid ID of element B_streetnumber in member edit form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #18 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #17 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #15 from Kyle M Hall  ---
Created attachment 52830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52830=edit
Bug 10760: Alternate Address: Display street number and street type

This patch displays alternate streetnumber and street type on patron's
detail page.

To test:
- Apply patch
- Verify that the alternate address information displays follwing the
  setting in syspref AddressFormat and contains street type and
  street number (as appropriate)

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #16 from Kyle M Hall  ---
Created attachment 52831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52831=edit
Bug 10760: (followup) Move street type after address

As of comment #7

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52598|0   |1
is obsolete||
  Attachment #52599|0   |1
is obsolete||
  Attachment #52600|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 52829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52829=edit
Bug 10760: Alternate Address: Make street number and street type editable

Table 'borrowers' contain columns B_streetnumber and B_streettype.
This patch makes them editable for alternate address.

To test:
- Apply patch
- Edit a patron's details
- Verify that in edit mode for Alternate address, the fields 'street type' and
'street number' appear
  and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField,
BorrowerUnwantedField
- Verify that the values are saved correctly.

Note: A second patch will follow to manage the display of street number and
street type
Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

--- Comment #13 from Owen Leonard  ---
*** Bug 13996 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52351|0   |1
is obsolete||

--- Comment #10 from Owen Leonard  ---
Created attachment 52598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52598=edit
[SIGNED-OFF] Bug 10760: Alternate Address: Make street number and street type
editable

Table 'borrowers' contain columns B_streetnumber and B_streettype.
This patch makes them editable for alternate address.

To test:
- Apply patch
- Edit a patron's details
- Verify that in edit mode for Alternate address, the fields 'street type' and
'street number' appear
  and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField,
BorrowerUnwantedField
- Verify that the values are saved correctly.

Note: A second patch will follow to manage the display of street number and
street type
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52595|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 52600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52600=edit
[SIGNED-OFF] Bug 10760: (followup) Move street type after address

As of comment #7

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52352|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 52599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52599=edit
[SIGNED-OFF] Bug 10760: Alternate Address: Display street number and street
type

This patch displays alternate streetnumber and street type on patron's
detail page.

To test:
- Apply patch
- Verify that the alternate address information displays follwing the
  setting in syspref AddressFormat and contains street type and
  street number (as appropriate)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16779

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #9 from Marc Véron  ---
(In reply to Owen Leonard from comment #7)
> The format for US addresses should be:
> 
> [Street number] [Address] [Road type]
> 
> Correct: 25 Euclid Drive
> Incorrect: 25 Drive Euclid

Same issue with main address (introduced by Bug 4041), see Bug 16779

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #8 from Marc Véron  ---
Created attachment 52595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52595=edit
Bug 10760: (followup) Move street type after address

As of comment #7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Owen Leonard  ---
The format for US addresses should be:

[Street number] [Address] [Road type]

Correct: 25 Euclid Drive
Incorrect: 25 Drive Euclid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #6 from Katrin Fischer  ---
Thx for the explanation Marc - looks ok to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16730

--- Comment #5 from Marc Véron  ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 52352 [details] [review]
> Bug 10760: Alternate Address: Display street number and street type
> 
> Review of attachment 52352 [details] [review]:
> -
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
> @@ +413,5 @@
> >   
> >  Alternate address
> > +
> > +[% IF Koha.Preference( 'AddressFormat' ) %]
> > +[% INCLUDE "member-display-alt-address-style-${ Koha.Preference( 
> > 'AddressFormat' ) }.inc" %]
> 
> What if the file doesn't exist?

It works the same as with Bug 4041 - Address Format as a I18N/L10N system
preference and Bug 16730 - Use member-display-address-style*-includes in
moremember-brief.tt 

Syspref 'AddressFormat' can have 2 values: us and de
snip---
- pref: addressformat
  default: us
  choices:
  us: US style ([Street number], [Address] - [City], [Zip/Postal
Code], [Country])
  de: German style ([Adress] [Street number] - [Zip/Postal Code]
[City] - [Country]
snip---
For each choice, a file exists:
member-display-alt-address-style-us.inc
member-display-alt-address-style-de.inc

Fallback is us if syspref 'AdressFormat' is not defined

If more formats are needed, you have to
- add an additional syspref value
- add inc files to folder koha-tmpl/intranet-tmpl/prog/en/includes as
appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #4 from M. Tompsett  ---
Comment on attachment 52352
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52352
Bug 10760: Alternate Address: Display street number and street type

Review of attachment 52352:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10760=52352)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +413,5 @@
>   
>  Alternate address
> +
> +[% IF Koha.Preference( 'AddressFormat' ) %]
> +[% INCLUDE "member-display-alt-address-style-${ Koha.Preference( 
> 'AddressFormat' ) }.inc" %]

What if the file doesn't exist?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4041

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

Summary|Street Number field is  |Use Street Number and
   |missing from the Alternate  |Street type in Alternate
   |Address section |Address section
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/