[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Giannis Tsakonas  changed:

   What|Removed |Added

 CC||j...@lis.upatras.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #23 from David Cook  ---
Finally took the time to look at this one again... thanks indeed Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|major   |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #21 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #22 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #20 from Tomás Cohen Arazi tomasco...@gmail.com ---
Chris, tests on t/db_dependent are considered standard and are always run by
the dev team and jenkins too, when pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #19 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to Tomás Cohen Arazi from comment #18)
 I would say this is an enhancement.

This is not the intended nor expected behavior which makes me lean toward it
being a true bug.

 But, anyway, Chris N. is about to post a
 followup with regression tests, so I'll be holding this until then.

FTR, here are my current thoughts on this:

This is going to be a bit of a problem to try to mock. Notice here:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=bd3ee4fe7bbdc723d9b8b13bbb22ba8da3686086;hb=HEAD#l81

we grab all of the data in 4 tables. I know that DBD::Mock allows mocking
resultsets, but this would require a significant amount of coding, and it is
not clear whether DBD::Mock will handle a join or not. The way I read the docs,
it will not.

I think the only way to do this is to make it run over a test database which
means it will not be run as part of the standard test suite.

I will be glad to write up a test for this, but question the value of it if it
will not be run as a part of the standard test suite.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #18 from Tomás Cohen Arazi tomasco...@gmail.com ---
I would say this is an enhancement. But, anyway, Chris N. is about to post a
followup with regression tests, so I'll be holding this until then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12553

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

   Severity|enhancement |major
   Priority|P5 - low|P3
 CC||cnighswon...@foundations.ed
   ||u

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #17 from Chris Nighswonger cnighswon...@foundations.edu ---
Bumping the priority on this as it is causing issues for several folks at this
point.

It would be good to get this into the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #16 from Chris Nighswonger cnighswon...@foundations.edu ---
*** Bug 12553 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36086action=edit
[PASSED QA] Bug 10773 - add help for *_description fields

Signed-off-by: Nick n...@quechelibrary.org

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36051|0   |1
is obsolete||
  Attachment #36052|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36085
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36085action=edit
[PASSED QA] Bug 10773 - Add item-level descriptions for Label Printing

This patch adds new fields ccode_description, homebranch_description,
holdingbranch_description, location_description and
permanent_location_description which can be used in the Label Creator
to display names/descriptions instead of codes

Test Plan:

1) Edit a layout in the Label Creator so that it includes any of these
fields. I suggest including homebranch_description and perhaps
ccode_description if you have them in your item data.
2) Add items to a batch in the Label Creator.
3) Export the batch using the layout, and view as PDF
4) Verify that you see descriptions for fields which you added

Signed-off-by: Nick n...@quechelibrary.org

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #35031|0   |1
is obsolete||

--- Comment #13 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 36052
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36052action=edit
[SIGNED OFF]Bug 10773 - add help for *_description fields

Signed-off-by: Nick n...@quechelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #34539|0   |1
is obsolete||

--- Comment #12 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 36051
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36051action=edit
[SIGNED OFF] Bug 10773 - Add item-level descriptions for Label Printing

This patch adds new fields ccode_description, homebranch_description,
holdingbranch_description, location_description and
permanent_location_description which can be used in the Label Creator
to display names/descriptions instead of codes

Test Plan:

1) Edit a layout in the Label Creator so that it includes any of these
fields. I suggest including homebranch_description and perhaps
ccode_description if you have them in your item data.
2) Add items to a batch in the Label Creator.
3) Export the batch using the layout, and view as PDF
4) Verify that you see descriptions for fields which you added

Signed-off-by: Nick n...@quechelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

  Attachment #34634|0   |1
is obsolete||

--- Comment #10 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 35031
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35031action=edit
Bug 10773 - add help for *_description fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #11 from Dobrica Pavlinusic dpav...@rot13.org ---
(In reply to paxed from comment #9)
 (In reply to Dobrica Pavlinusic from comment #8)
  Created attachment 34634 [details] [review] [review]
  Bug 10773 - add help for *_description fields
 
 Typo Fileds in there

Thanks, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

   Assignee|dc...@prosentient.com.au|dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

paxed pasi.kalli...@pttk.fi changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #9 from paxed pasi.kalli...@pttk.fi ---
(In reply to Dobrica Pavlinusic from comment #8)
 Created attachment 34634 [details] [review]
 Bug 10773 - add help for *_description fields

Typo Fileds in there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

Summary|Replace item-level codes|Add item-level descriptions
   |with names/descriptions for |for Label Printing
   |Label Printing  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

  Attachment #21285|0   |1
is obsolete||

--- Comment #8 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 34634
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34634action=edit
Bug 10773 - add help for *_description fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/