[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #135 from Séverine Queune  ---
Created attachment 94833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94833=edit
No option visible with patch applied

First screenshot = master
Second screenshot = patch 10585 applied, all the options are hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #134 from Séverine Queune  ---
When I apply the patch, the 'selections-toolbar' is emptied of all its options.
See screenshot attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #133 from Owen Leonard  ---
Why not add the JS in the new common.js file to global.js?

It doesn't look like there is a way to clear your selection. Is it necessary to
uncheck each selected record?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71223|0   |1
is obsolete||

--- Comment #132 from Julian Maurice  ---
Created attachment 91589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91589=edit
Bug 10858: (QA follow-up) Fix translatibility

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71222|0   |1
is obsolete||

--- Comment #131 from Julian Maurice  ---
Created attachment 91588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91588=edit
Bug 10858: Add 2 missing nav class

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71221|0   |1
is obsolete||

--- Comment #130 from Julian Maurice  ---
Created attachment 91587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91587=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71219|0   |1
is obsolete||

--- Comment #128 from Julian Maurice  ---
Created attachment 91585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91585=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71220|0   |1
is obsolete||

--- Comment #129 from Julian Maurice  ---
Created attachment 91586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91586=edit
Bug 10858: Replace the unique jQuery function with our own

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #71218|0   |1
is obsolete||

--- Comment #127 from Julian Maurice  ---
Created attachment 91584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91584=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply
 CC||nicolas.legr...@bulac.fr

--- Comment #126 from Nicolas Legrand  ---
failed with new JS name scheme.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #125 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #124)
> As bug 19290 adds a new pref to turn the feature on/off, should not we do
> the same for the OPAC?

To me, that would be more logical.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios - OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart  changed:

   What|Removed |Added

Summary|Browse selected biblios |Browse selected biblios -
   ||OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #124 from Jonathan Druart  
---
As bug 19290 adds a new pref to turn the feature on/off, should not we do the
same for the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #122 from Josef Moravec  ---
Created attachment 71222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71222=edit
Bug 10858: Add 2 missing nav class

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #123 from Josef Moravec  ---
Created attachment 71223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71223=edit
Bug 10858: (QA follow-up) Fix translatibility

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #121 from Josef Moravec  ---
Created attachment 71221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71221=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #119 from Josef Moravec  ---
Created attachment 71219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71219=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #120 from Josef Moravec  ---
Created attachment 71220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71220=edit
Bug 10858: Replace the unique jQuery function with our own

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Josef Moravec  changed:

   What|Removed |Added

  Attachment #67974|0   |1
is obsolete||
  Attachment #67975|0   |1
is obsolete||
  Attachment #67976|0   |1
is obsolete||
  Attachment #67977|0   |1
is obsolete||
  Attachment #67978|0   |1
is obsolete||

--- Comment #118 from Josef Moravec  ---
Created attachment 71218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71218=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #117 from Jonathan Druart  
---
Created attachment 67978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67978=edit
Bug 10858: Add 2 missing nav class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #116 from Jonathan Druart  
---
Created attachment 67977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67977=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67089|0   |1
is obsolete||
  Attachment #67090|0   |1
is obsolete||
  Attachment #67092|0   |1
is obsolete||
  Attachment #67093|0   |1
is obsolete||

--- Comment #113 from Jonathan Druart  
---
Created attachment 67974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67974=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #115 from Jonathan Druart  
---
Created attachment 67976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67976=edit
Bug 10858: Replace the unique jQuery function with our own

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #114 from Jonathan Druart  
---
Created attachment 67975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67975=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19290

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #67076|0   |1
is obsolete||

--- Comment #112 from Nicolas Legrand  ---
Created attachment 67093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67093=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #67086|0   |1
is obsolete||

--- Comment #109 from Nicolas Legrand  ---
Created attachment 67089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67089=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #67075|0   |1
is obsolete||

--- Comment #111 from Nicolas Legrand  ---
Created attachment 67092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67092=edit
Bug 10858: Replace the unique jQuery function with our own

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #67074|0   |1
is obsolete||

--- Comment #110 from Nicolas Legrand  ---
Created attachment 67090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67090=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #67073|0   |1
is obsolete||

--- Comment #108 from Nicolas Legrand  ---
Created attachment 67086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67086=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #107 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #56479|0   |1
is obsolete||

--- Comment #103 from Julian Maurice  ---
Created attachment 67073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67073=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #56481|0   |1
is obsolete||

--- Comment #105 from Julian Maurice  ---
Created attachment 67075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67075=edit
Bug 10858: Replace the unique jQuery function with our own

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #56482|0   |1
is obsolete||

--- Comment #106 from Julian Maurice  ---
Created attachment 67076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67076=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #56480|0   |1
is obsolete||

--- Comment #104 from Julian Maurice  ---
Created attachment 67074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67074=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Eric  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||eric.gosseli...@gmail.com

--- Comment #102 from Eric  ---
Doesn't apply in the sandboxes. Could you rebase it? Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #101 from Jonathan Druart  
---
Yes indeed, launching several searches in different tabs will give wrong
results.
I have no idea how we could fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #100 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #99)
> These patches have been submitted 3 years ago, and have been rewritten 3
> times already.

Okay that's fair. My comments are not about issues which should block this.

One thing I am concerned about is the behavior of browsing when you have
multiple tabs open. Browsing selected records seems to get confused if you
perform a search in another tab, with the list of selected records getting
replaced by the list of searched records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #99 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #98)
> (In reply to Marcel de Rooy from comment #26)
> 
> > If you browse the selection, it would imo be good to show that you are doing
> > so (Browse selected results vs. Browse results).
> 
> I like this suggestion too, but I think it could be handled in a follow-up.
> 
> It looks to me like the contents of common.js could be put into global.js
> and we could avoid having a separate file. Do you think there is a reason
> not to?

These patches have been submitted 3 years ago, and have been rewritten 3 times
already. If we want additional behaviours they should go to another bug report.
The commons.js content could be moved to global.js but note that bug 11311 is
adding more content to this file. Maybe we could move it to something less
vague than 'commons' but keep it apart from global.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #98 from Owen Leonard  ---
(In reply to Marcel de Rooy from comment #26)

> If you browse the selection, it would imo be good to show that you are doing
> so (Browse selected results vs. Browse results).

I like this suggestion too, but I think it could be handled in a follow-up.

It looks to me like the contents of common.js could be put into global.js and
we could avoid having a separate file. Do you think there is a reason not to?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #44903|0   |1
is obsolete||

--- Comment #97 from Julian Maurice  ---
Created attachment 56482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56482=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41841|0   |1
is obsolete||

--- Comment #96 from Julian Maurice  ---
Created attachment 56481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56481=edit
Bug 10858: Replace the unique jQuery function with our own

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41840|0   |1
is obsolete||

--- Comment #95 from Julian Maurice  ---
Created attachment 56480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56480=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41839|0   |1
is obsolete||

--- Comment #94 from Julian Maurice  ---
Created attachment 56479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56479=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita 

Signed-off-by: Koha Team Amu 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #93 from Katrin Fischer  ---
hm, the last line seems correct to me: if holds and login are allowed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #92 from Frédéric Demians  ---
On last patch, I don't understand that, the last test:

[% IF
   ( Koha.Preference('opacbookbag') == 1 )
|| ( Koha.Preference('virtualshelves') == 1 )
|| ( Koha.Preference('OpacBrowseResults') == 1 )
|| ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) &&
Koha.Preference('opacuserlogin') )
%]

I think that it's rather:

|| ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) &&
(not Koha.Preference('opacuserlogin')) )

But I'm not sure...

And When everything is disabled, no checkboxes at all, links 'check all' /
'clear all' are still displayed. This bug is also in master, but still...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #90 from Julian Maurice  ---
Hi Katrin,

I made this assumption by looking at the code, but the code is wrong, and you
are right ;)
I will submit a followup, replacing the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41842|0   |1
is obsolete||

--- Comment #91 from Julian Maurice  ---
Created attachment 44903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44903=edit
Bug 10858: Show checkbox if OpacBrowseResult is set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #89 from Katrin Fischer  ---
Hi Julian,

I think the last patch makes a wrong assumption - the browse feature is useless
if OpacBrowseResults is turned off (which some of our libraries actually have).
So I think removing the checks for the checkboxes should be undone and a check
for this pref added to the code - for the checkboxes and also for the link at
the top of the results.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #84 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41838
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41838action=edit
Bug 10858: Always show checkboxes in OPAC search results

Because Browse selected biblios action will always be available

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #38405|0   |1
is obsolete||

--- Comment #86 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41840
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41840action=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #38033|0   |1
is obsolete||

--- Comment #85 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41839
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41839action=edit
Bug 10858: Browse selected biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #41838|0   |1
is obsolete||

--- Comment #88 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41842
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41842action=edit
Bug 10858: Always show checkboxes in OPAC search results

Because Browse selected biblios action will always be available

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #39502|0   |1
is obsolete||

--- Comment #87 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41841
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41841action=edit
Bug 10858: Replace the unique jQuery function with our own

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #83 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39938
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39938action=edit
No way to select records with list and cart inactive - link stil shows

Hi Jonathan, I think the link should disappear when neither cart nor list are
available - or we need to keep showing the checkboxes for selecting records in
the result list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #82 from Jonathan Druart jonathan.dru...@biblibre.com ---
No sorry, back to Needs QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #81 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan, thx for the follow-up replacing the jQuery! Are we waiting for
another follow-up  here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om
   Assignee|jonathan.dru...@biblibre.co |julian.maur...@biblibre.com
   |m   |
 Status|Signed Off  |Failed QA

--- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #78)
 Some of the other problems went away after making sure my browser cache was
 cleared. But I still see a problem when both cart and list are turned off:
 the text browse selected records still shows up, but there are no
 checkboxes to select a record.

This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39502
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39502action=edit
Bug 10858: Replace the unique jQuery function with our own

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #78 from Katrin Fischer katrin.fisc...@bsz-bw.de ---

  1) Shoudl this be included on the about.pl page?
  +// Extends jQuery API
  +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js
 
 The domain is down and I don't know at all where I found this piece of code.
 It was certainly under the MIT license.

I am not very comfortable with the dependency as it doesn't include a lisence
statement right now and there seems no way to trace it back to an author. Could
we replace this with our own code or some other plugin?

Some of the other problems went away after making sure my browser cache was
cleared. But I still see a problem when both cart and list are turned off: the
text browse selected records still shows up, but there are no checkboxes to
select a record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #75 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
1) Shoudl this be included on the about.pl page?
+// Extends jQuery API
+// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js

2) I think there are display problems, when both the cart and the lists are
turned off:

For example, this is only available with the prefs ON:
 var MSG_NO_RECORD_SELECTED = _(No item was selected);

Browse selected record still shows up, but I see only one checkbox on my third
record in the list? (confusing)

I am not logged in and tried in 2 different browsers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #77 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #75)
 1) Shoudl this be included on the about.pl page?
 +// Extends jQuery API
 +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js

The domain is down and I don't know at all where I found this piece of code.
It was certainly under the MIT license.

 2) I think there are display problems, when both the cart and the lists are
 turned off:
 
 For example, this is only available with the prefs ON:
  var MSG_NO_RECORD_SELECTED = _(No item was selected);

Ok fixed.

 Browse selected record still shows up, but I see only one checkbox on my
 third record in the list? (confusing)
 
 I am not logged in and tried in 2 different browsers.

I don't get it, I have never seen that.
Please provide more info to recreate the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38405
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38405action=edit
Bug 10858: Define the NO_RECORD_SELECTED msg in any case

And not only when cart or list are defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #73 from M. de Rooy m.de.r...@rijksmuseum.nl ---
CONFLICT (add/add): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js
Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/basket.js
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36757|0   |1
is obsolete||

--- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38033action=edit
Bug 10858: Browse selected biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com ---
Ok so, back on this one.
It did not apply at all and had ccsr+prog themes.
This new patch is just a squash patch with only the bootstrap theme changes.
Test plan is the same.

QA Note:(In reply to M. de Rooy from comment #26)
 If you browse the selection, it would imo be good to show that you are doing
 so (Browse selected results vs. Browse results).

I removed this change, it did not work.
Actually I don't see an easy way to do that and consider it as a minor and
should not be a blocker.

Switch back in the QA queue to give confidence to the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #25643|0   |1
is obsolete||
  Attachment #25644|0   |1
is obsolete||
  Attachment #25645|0   |1
is obsolete||
  Attachment #25646|0   |1
is obsolete||
  Attachment #25647|0   |1
is obsolete||
  Attachment #25648|0   |1
is obsolete||
  Attachment #25649|0   |1
is obsolete||
  Attachment #25650|0   |1
is obsolete||
  Attachment #25651|0   |1
is obsolete||
  Attachment #25652|0   |1
is obsolete||
  Attachment #25653|0   |1
is obsolete||

--- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 36757
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36757action=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link Browse selected biblios  when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the Browse results block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the Browse selected biblios  link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com ---
Dear RM, what about this feature? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

--- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com ---
I removed the in discussion status. Sent to the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |In Discussion

--- Comment #68 from Galen Charlton gmcha...@gmail.com ---
This set up rather a lot of infrastructure for a feature whose workflow purpose
can be met by the cart, and I remain dubious.  Consequently, I'm punting this
to the next RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25450|0   |1
is obsolete||

--- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25643
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25643action=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link Browse selected biblios  when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the Browse results block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the Browse selected biblios  link
- Check that you are able to browse results you had checked.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25452|0   |1
is obsolete||

--- Comment #57 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25645
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25645action=edit
Bug 10858: FIX error if no biblio is selected

If the user launch a search a directly go to the opac detail page, an
error occurs:

  malformed JSON string, neither array, object, number, string or atom, at
  character offset 0 (before (end of string)) at
  /usr/share/perl5/JSON.pm line 171.

Test plan:
- remove the bibs_selected cookie
- launch a search
- click on a result
- the page should be displayed correctly
(cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252)

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25451|0   |1
is obsolete||

--- Comment #56 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25644
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25644action=edit
Bug 10858 [Follow-up] Browse selected biblios

This follow-up adds the browse functionality to the CCSR theme and
adds some CSS for the browse link, including a new image in the image
sprite.

To test, apply the patch, clear your cache, and test the browsing
functionality again. Confirm that the browse link looks good and works
correctly in both the prog and CCSR themes.

Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Passes koha-qa.pl, works as advertised for prog and ccsr.
Not implemented for bootstrap, but doesn't affect it detrimentally
either. Jonathan plans to open a new bug to implement for bootstrap.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25454|0   |1
is obsolete||

--- Comment #59 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25647
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25647action=edit
Bug 10858: Browse selected biblios - bootstrap

Add the changes from bug 10858 to the bootstrap theme.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the Browse selected biblios  link
- Check that you are able to browse results you had checked.

In addition to prog and ccsr templates, this patch allows to add
selected biblios (from multiple pages) to the cart or a list.
To test:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25455|0   |1
is obsolete||

--- Comment #60 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25648
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25648action=edit
Bug 10858: FIX the Browse selected link

It should be updated on checkbox changes.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25453|0   |1
is obsolete||

--- Comment #58 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25646
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25646action=edit
Bug 10858: Don't use the cookie if the ft is disabled

Is the pref 'OpacBrowseResults' is off, the feature should be completly
off.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25456|0   |1
is obsolete||

--- Comment #61 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25649
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25649action=edit
Bug 10858: FIX Only one occurrence of the biblionumbers should be stored

We have to remove duplicate biblionumber in the array of biblionumbers
stored in the cookie.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10858] Browse selected biblios

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25512|0   |1
is obsolete||

--- Comment #63 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25651
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25651action=edit
Bug 10858: fix bad merge conflict

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/